[Public]
Reviewed-by: Srinivasan Shanmugam
-Original Message-
From: amd-gfx On Behalf Of
shijie...@208suo.com
Sent: Friday, July 14, 2023 1:36 PM
To: Deucher, Alexander ; Pan, Xinhui
; airl...@gmail.com; dan...@ffwll.ch
Cc: dri-devel@lists.freedesktop.org;
On 2023-07-14 05:57, Christian König wrote:
> Am 14.07.23 um 11:49 schrieb Asahi Lina:
>> On 14/07/2023 17.43, Christian König wrote:
>>> Am 14.07.23 um 10:21 schrieb Asahi Lina:
A signaled scheduler fence can outlive its scheduler, since fences are
independencly reference counted.
On 15/07/2023 03:59, Jessica Zhang wrote:
On 7/14/2023 3:30 PM, Dmitry Baryshkov wrote:
On Fri, 14 Jul 2023 at 22:03, Jessica Zhang
wrote:
On 7/13/2023 6:23 PM, Dmitry Baryshkov wrote:
On 14/07/2023 03:21, Jessica Zhang wrote:
DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode
On 7/14/2023 3:30 PM, Dmitry Baryshkov wrote:
On Fri, 14 Jul 2023 at 22:03, Jessica Zhang wrote:
On 7/13/2023 6:23 PM, Dmitry Baryshkov wrote:
On 14/07/2023 03:21, Jessica Zhang wrote:
DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode that allows DSI
to send 48 bits of
On 7/7/2023 4:12 PM, Dmitry Baryshkov wrote:
Use devm_kzalloc to create MDP TOP structure. This allows us to remove
corresponding kfree and drop dpu_hw_mdp_destroy() function.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 17 +++--
On Fri, Jul 14, 2023 at 11:11:30AM +0100, Tvrtko Ursulin wrote:
>
> On 14/07/2023 06:43, Yang, Fei wrote:
> > > From: Tvrtko Ursulin
> > >
> > > According to the comment in i915_gem_object_can_bypass_llc the
> > > purpose of the function is to return false if the platform/object
> > > has a
NAK - checkpatch.pl is a (strongish) guideline, but not a rule. In the cases
corrected in the patch series here, we format the switch cases on single lines
as it dramatically improves the readability of what is otherwise just a /long/
list of slightly different static mappings. I don't believe
On Fri, 14 Jul 2023 at 22:03, Jessica Zhang wrote:
>
>
>
> On 7/13/2023 6:23 PM, Dmitry Baryshkov wrote:
> > On 14/07/2023 03:21, Jessica Zhang wrote:
> >> DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode that allows DSI
> >> to send 48 bits of compressed data per pclk instead of 24.
>
On Fri, 14 Jul 2023 at 23:09, Jessica Zhang wrote:
>
>
>
> On 7/14/2023 12:41 AM, Dmitry Baryshkov wrote:
> > On 14/07/2023 03:21, Jessica Zhang wrote:
> >> DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode that allows DSI
> >
> > sm8250 has widebus support in DP and thus in DPU,
On 7/4/2023 9:36 AM, Rob Clark wrote:
From: Rob Clark
Recently, a WARN_ON() was introduced to ensure that revn is filled before
adreno_is_aXYZ is called. This however doesn't work very well when revn is
0 by design (such as for A635).
Cc: Konrad Dybcio
Fixes: cc943f43ece7
On 7/7/2023 4:12 PM, Dmitry Baryshkov wrote:
It was noticed that dpu_kms_hw_init()'s error path contains several
labels which point to the same code path. Replace all of them with a
single label.
Suggested-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
https://bugzilla.kernel.org/show_bug.cgi?id=199979
Artem S. Tashkinov (a...@gmx.com) changed:
What|Removed |Added
Status|NEW |RESOLVED
On 7/14/2023 12:41 AM, Dmitry Baryshkov wrote:
On 14/07/2023 03:21, Jessica Zhang wrote:
DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode that allows DSI
sm8250 has widebus support in DP and thus in DPU, according to the
published DT. Thus the 'DPU 7.x+' is not fully correct.
Hi Gaosheng,
On Fri, Jul 14, 2023 at 09:48:18AM +0800, Gaosheng Cui wrote:
> The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
> we should use IS_ERR() to check the return value.
Correct - so the code is indeed wrong.
Can you update it so we print the error code as this can be
On 7/14/2023 12:10 PM, Abhinav Kumar wrote:
On 7/13/2023 6:48 PM, Gaosheng Cui wrote:
The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should
use IS_ERR() to check the return value.
use IS_ERR_OR_NULL()
I can even fix this while applying
Actually even subject line needs
On 13/07/2023 17:52, Amit Pundir wrote:
> Adding a reserved memory region for the framebuffer memory
> (the splash memory region set up by the bootloader).
>
> Signed-off-by: Amit Pundir
Reviewed-by: Caleb Connolly
> ---
> v5: Re-sending with updated dt-bindings patch in mdss-common
>
On 7/13/2023 6:48 PM, Gaosheng Cui wrote:
The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should
use IS_ERR() to check the return value.
use IS_ERR_OR_NULL()
I can even fix this while applying
Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl")
Signed-off-by:
On 7/13/2023 6:23 PM, Dmitry Baryshkov wrote:
On 14/07/2023 03:21, Jessica Zhang wrote:
DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode that allows DSI
to send 48 bits of compressed data per pclk instead of 24.
For all chipsets that support this mode, enable it whenever DSC is
On Fri, Jul 14, 2023 at 08:56:15AM +0200, Christian König wrote:
> Am 13.07.23 um 21:47 schrieb Ville Syrjala:
> > From: Ville Syrjälä
> >
> > Currently dma_resv_get_fences() will leak the previously
> > allocated array if the fence iteration got restarted and
> > the krealloc_array() fails.
> >
The pull request you sent on Fri, 14 Jul 2023 14:39:37 +1000:
> git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-07-14-1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3a97a2993e7e7392292323fefc46d79bf9633e44
Thank you!
--
Deet-doot-dot, I am a bot.
Introduce a test to cover the creation of a framebuffer with
a setted modifier and a driver that don't support modifiers.
Signed-off-by: Carlos Eduardo Gallo Filho
---
drivers/gpu/drm/tests/drm_framebuffer_test.c | 21
1 file changed, 21 insertions(+)
diff --git
Extend the existing test case to cover:
1. Invalid flag atribute in the struct drm_mode_fb_cmd2.
2. Pixel format which requires non-linear modifier with
DRM_FORMAT_MOD_LINEAR set.
3. Non-zero buffer offset for an unused plane
Signed-off-by: Carlos Eduardo Gallo Filho
---
Add a parametrized test for the drm_framebuffer_check_src_coords function.
Signed-off-by: Carlos Eduardo Gallo Filho
---
drivers/gpu/drm/tests/drm_framebuffer_test.c | 107 +++
1 file changed, 107 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c
Signed-off-by: Carlos Eduardo Gallo Filho
---
drivers/gpu/drm/drm_framebuffer.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_framebuffer.c
b/drivers/gpu/drm/drm_framebuffer.c
index aff3746dedfb..49df3ca3b3ee 100644
---
This series adds documentation and unit tests for
drm_framebuffer_check_src_coords() and drm_internal_framebuffer_create()
functions on drm_framebuffer.c, including new parameters to the, until
then, only existent test.
Many thanks,
Carlos
Carlos Eduardo Gallo Filho (4):
drm: Add kernel-doc
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result,
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result,
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result,
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result,
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result,
> On 14/07/2023 06:43, Yang, Fei wrote:
>>> From: Tvrtko Ursulin
>>>
>>> According to the comment in i915_gem_object_can_bypass_llc the
>>> purpose of the function is to return false if the platform/object has
>>> a caching mode where GPU can bypass the LLC.
>>>
>>> So far the only platforms
On Thu, Jul 13, 2023 at 1:13 PM Randy Dunlap wrote:
>
>
>
> On 7/13/23 09:36, Jim Cromie wrote:
> > Add some basic info on classmap usage and api
> >
> > Signed-off-by: Jim Cromie
> > ---
> > .../admin-guide/dynamic-debug-howto.rst | 64 ++-
> > 1 file changed, 63
On Thu, Jul 13, 2023 at 1:04 PM Randy Dunlap wrote:
>
> Hi Jim,
>
> On 7/13/23 09:36, Jim Cromie wrote:
> > Signed-off-by: Jim Cromie
> > ---
> > lib/Kconfig.debug | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index
Hi Frieder
On Mon, 10 Jul 2023 at 08:46, Frieder Schrempf
wrote:
>
> On 07.07.23 21:00, Vladimir Lypak wrote:
> > [Sie erhalten nicht häufig E-Mails von vladimir.ly...@gmail.com. Weitere
> > Informationen, warum dies wichtig ist, finden Sie unter
> >
Currently the CONFIG_FB option has to be enabled even if no legacy fbdev
drivers are needed (e.g: only to have support for framebuffer consoles).
The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB
and so it can only be enabled if that dependency is enabled as well.
That
Now that fbdev core has been split in FB_CORE and FB, make the DRM symbol
to select the FB_CORE option if the DRM fbdev emulation layer is enabled.
This allows to disable the CONFIG_FB option if is not needed, which will
avoid the need to explicitly disable each of the legacy fbdev drivers.
The drivers/video/fbdev/Kconfig defines both symbols for fbdev drivers and
core fbdev symbols, that can be enabled independently of the fbdev drivers.
Split the Kconfig in two, one that only has the symbols for fbdev drivers
and another one that contains the fbdev core symbols.
Suggested-by:
The drivers in this subsystem are for character-based LCD displays, which
can fall into the same category of the DRM/KMS and fbdev drivers that are
located under the "Graphics support" menu. Add auxdisplay there as well.
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
This patch series splits the fbdev core support in two different Kconfig
symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to
be disabled, while still having the the core fbdev support needed for the
CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically
On 7/14/2023 5:47 AM, Pranjal Ramajor Asha Kanojiya wrote:
On 7/11/2023 1:51 PM, Dan Carpenter wrote:
If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages. Call put_page() on
the pages before returning.
Fixes: 129776ac2e38
On 7/14/2023 5:44 AM, Pranjal Ramajor Asha Kanojiya wrote:
On 7/11/2023 1:51 PM, Dan Carpenter wrote:
The encode_dma() function has integer overflow checks. The
encode_passthrough(), encode_activate() and encode_status() functions
did not. I added integer overflow checking everywhere. I
Even if there's nothing currently parsing amdgpu's coredump files, if
we eventually have such tools they will be glad to find a version field
to properly read the file.
Create a version number to be displayed on top of coredump file, to be
incremented when the file format or content get changed.
Giving that we use codedump just for device resets, move it's functions
and structs to a more semantic file, the amdgpu_reset.{c, h}.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 ---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 80 --
During a GPU reset, a normal memory reclaim could block to reclaim
memory. Giving that coredump is a best effort mechanism, it shouldn't
disturb the reset path. Change its memory allocation flag to a
nonblocking one.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
Instead of storing coredump information inside amdgpu_device struct,
move if to a proper separated struct and allocate it dynamically. This
will make it easier to further expand the logged information.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 14 +++--
Create a module parameter to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
Hi,
The goal of this patchset is to improve debugging device resets on amdgpu.
The first patch creates a new module parameter to disable soft recoveries,
ensuring every recovery go through the full device reset, making easier to
generate resets from userspace tools like [0] and [1]. This is
On 7/14/2023 5:42 AM, Pranjal Ramajor Asha Kanojiya wrote:
On 7/11/2023 1:50 PM, Dan Carpenter wrote:
Copy the bounds checking from encode_message() to decode_message().
This patch addresses the following concerns. Ensure that there is
enough space for at least one header so that we don't
On 7/14/2023 5:41 AM, Pranjal Ramajor Asha Kanojiya wrote:
On 7/11/2023 1:50 PM, Dan Carpenter wrote:
There are several issues in this code. The check at the start of the
loop:
if (user_len >= user_msg->len) {
This check does not ensure that we have enough space for the trans_hdr
(8
On Fri, Jul 14, 2023 at 09:05:21AM +0200, Christian Brauner wrote:
> I have no skin in the game aside from having to drop this conversion
> which I'm fine to do if there are actually users for this btu really,
> that looks a lot like abusing an api that really wasn't designed for
> this.
Yeah, I
Am 2023-07-14 um 10:26 schrieb Vlastimil Babka:
On 7/12/23 18:24, Felix Kuehling wrote:
Allocations in the heap and stack tend to be small, with several
allocations sharing the same page. Sharing the same page for different
allocations with different access patterns leads to thrashing when we
Hi
Am 14.07.23 um 16:37 schrieb Simon Ser:
On Friday, July 14th, 2023 at 16:28, Thomas Zimmermann
wrote:
Hi Simon
Am 14.07.23 um 12:46 schrieb Simon Ser:
This entry should never be used by the kernel. Record the historical
context in a comment.
Signed-off-by: Simon Ser
Cc: Christian
On Friday, July 14th, 2023 at 16:28, Thomas Zimmermann
wrote:
> Hi Simon
>
> Am 14.07.23 um 12:46 schrieb Simon Ser:
> > This entry should never be used by the kernel. Record the historical
> > context in a comment.
> >
> > Signed-off-by: Simon Ser
> > Cc: Christian König
> > Cc: James Zhu
Add the Series AXE GPU node to the AM62 device tree.
Signed-off-by: Sarah Walker
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index
Add documentation for the UAPI and for the virtual memory design.
Signed-off-by: Sarah Walker
---
Documentation/gpu/drivers.rst | 2 +
Documentation/gpu/imagination/index.rst | 14 +
Documentation/gpu/imagination/uapi.rst| 174 +++
Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0.
Trace is enabled via the group mask at
/sys/debug/dri//pvr_params/fw_trace_mask.
Changes since v3:
- Use drm_dev_{enter,exit}
Signed-off-by: Sarah Walker
---
drivers/gpu/drm/imagination/Makefile | 4 +
Implement job submission ioctl. Job scheduling is implemented using
drm_sched.
Jobs are submitted in a stream format. This is intended to allow the UAPI
data format to be independent of the actual FWIF structures in use, which
vary depending on the GPU in use.
The stream formats are documented
Implement ioctls for the creation and destruction of contexts. Contexts are
used for job submission and each is associated with a particular job type.
Changes since v3:
- Use drm_dev_{enter,exit}
Signed-off-by: Sarah Walker
---
drivers/gpu/drm/imagination/Makefile | 4 +
Implement ioctls to create and destroy free lists and HWRT datasets. Free
lists are used for GPU-side memory allocation during geometry processing.
HWRT datasets are the FW-side structures representing render targets.
Changes since v3:
- Support free list grow requests from FW
- Use
Hi Simon
Am 14.07.23 um 12:46 schrieb Simon Ser:
This entry should never be used by the kernel. Record the historical
context in a comment.
Signed-off-by: Simon Ser
Cc: Christian König
Cc: James Zhu
Cc: Marek Olšák
Cc: Daniel Vetter
---
include/drm/drm_file.h | 4 +++-
1 file changed,
Add support for the MIPS firmware processor, used in the Series AXE GPU.
The MIPS firmware processor uses a separate MMU to the rest of the GPU, so
this patch adds support for that as well.
Changes since v3:
- Get regs resource (removed from GPU resources commit)
Signed-off-by: Sarah Walker
---
The infrastructure includes parsing of the firmware image, initialising
FW-side structures, handling the kernel and firmware command
ringbuffers and starting & stopping the firmware processor.
This patch also adds the necessary support code for the META firmware
processor.
Changes since v3:
-
Add power management to the driver, using runtime pm. The power off
sequence depends on firmware commands which are not implemented in this
patch.
Changes since v3:
- Don't power device when calling pvr_device_gpu_fini()
- Documentation for pvr_dev->lost has been improved
- pvr_power_init()
Read the GPU ID register at probe time and select the correct
features/quirks/enhancements. Use the GPU ID to form the firmware
file name and load the firmware.
The features/quirks/enhancements arrays are currently hardcoded in
the driver for the supported GPUs. We are looking at moving this
Acquire clock and register resources, and enable/map as appropriate.
Changes since v3:
- Remove regulator resource (not used on supported platform)
- Use devm helpers
- Use devm_clk_get_optional() for optional clocks
- Don't prepare clocks on resource acquisition
- Drop
On 7/12/23 18:24, Felix Kuehling wrote:
> Allocations in the heap and stack tend to be small, with several
> allocations sharing the same page. Sharing the same page for different
> allocations with different access patterns leads to thrashing when we
> migrate data back and forth on GPU and
Add the device tree binding documentation for the Series AXE GPU used in
TI AM62 SoCs.
Changes since v3:
- Remove oneOf in compatible property
- Remove power-supply (not used on AM62)
Changes since v2:
- Add commit message description
- Remove mt8173-gpu support (not currently supported)
- Drop
This adds the basic skeleton of the driver. The driver registers
itself with DRM on probe. Ioctl handlers are currently implemented
as stubs.
Changes since v3:
- Clarify supported GPU generations in driver description
- Use drm_dev_unplug() when removing device
- Change from_* and to_* functions
Add the UAPI implementation for the PowerVR driver.
Signed-off-by: Sarah Walker
---
MAINTAINERS|1 +
include/uapi/drm/pvr_drm.h | 1304
2 files changed, 1305 insertions(+)
create mode 100644 include/uapi/drm/pvr_drm.h
diff --git
From: Matt Coster
Signed-off-by: Matt Coster
Reviewed-by: Linus Walleij
---
include/linux/sizes.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/sizes.h b/include/linux/sizes.h
index 84aa448d8bb3..c3a00b967d18 100644
--- a/include/linux/sizes.h
+++
This patch series adds the initial DRM driver for Imagination Technologies
PowerVR
GPUs, starting with those based on our Rogue architecture. It's worth pointing
out that this is a new driver, written from the ground up, rather than a
refactored version of our existing downstream driver
Test initialization and cleanup of the ttm_device struct, including
some error paths. Verify the creation of page pools if use_dma_alloc
param is true.
Signed-off-by: Karolina Stolarek
Reviewed-by: Christian König
---
drivers/gpu/drm/ttm/tests/ttm_device_test.c | 158
1
Add KUnit tests that exercise page allocation using page pools
and freeing pages, either by returning them to the pool or
freeing them. Add a basic test for ttm_pool cleanup. Introduce
helpers to create a dummy ttm_buffer_object.
Signed-off-by: Karolina Stolarek
---
This series introduces KUnit[1] tests for TTM (Translation Table Manager)
subsystem, a memory manager used by graphics drivers to create and manage
memory buffers across different memory domains, such as system memory
or VRAM.
Unit tests implemented here cover two data structures:
- ttm_device
Add the initial version of unit tests for ttm_device struct, together
with helper functions.
Signed-off-by: Karolina Stolarek
---
drivers/gpu/drm/Kconfig | 15 +++
drivers/gpu/drm/ttm/Makefile | 1 +
drivers/gpu/drm/ttm/tests/.kunitconfig| 4 +
Hi Maxime,
On Fri, 2023-07-07 at 14:48 +0200, Maxime Ripard wrote:
> On Tue, Jun 13, 2023 at 03:47:52PM +0100, Sarah Walker wrote:
> > @@ -503,21 +506,31 @@ pvr_device_init(struct pvr_device *pvr_dev)
> > if (err)
> > goto err_device_clk_fini;
> >
> > + /* Explicitly
Hi Maxime,
On Fri, 2023-07-07 at 14:47 +0200, Maxime Ripard wrote:
> On Tue, Jun 13, 2023 at 03:47:48PM +0100, Sarah Walker wrote:
> > Acquire clock, regulator and register resources, and enable/map as
> > appropriate.
> >
> > Signed-off-by: Sarah Walker
> > ---
> >
Hi Maxime,
Thank you for your feedback (comments below).
On Fri, 2023-07-07 at 14:46 +0200, Maxime Ripard wrote:
> Hi,
>
> [I just noticed I dropped the Cc list, resending]
>
> Thanks for contributing this driver, it's awesome to see it moving
> forward.
>
> And congrats on the documentation
Geert Uytterhoeven writes:
Hello Geert,
> Hi Javier,
[...]
>> >
>> > The display should not be updated after .remove(), so I think plain
>> > devm_kcalloc() should be fine.
>>
>> That was precisely my point, that there could be atomic commits even after
>> the driver has been removed (e.g: if
Hi Javier,
On Fri, Jul 14, 2023 at 2:35 PM Javier Martinez Canillas
wrote:
> Geert Uytterhoeven writes:
> > On Fri, Jul 14, 2023 at 12:14 PM Javier Martinez Canillas
> > wrote:
> >> Geert Uytterhoeven writes:
> >> Thanks a lot for your patch, this has been on my TODO for some time!
> >>
> >>
Geert Uytterhoeven writes:
Hello Geert,
> Hi Javier,
>
> On Fri, Jul 14, 2023 at 12:14 PM Javier Martinez Canillas
> wrote:
>> Geert Uytterhoeven writes:
>> Thanks a lot for your patch, this has been on my TODO for some time!
>>
>> > The native display format is monochrome light-on-dark (R1).
Em 14/07/2023 04:57, Christian König escreveu:
Am 13.07.23 um 23:32 schrieb André Almeida:
Log the IB addresses used by the hung job along with the stuck ring
name. Note that due to nested IBs, the one that caused the reset itself
may be in not listed address.
Signed-off-by: André Almeida
Em 14/07/2023 04:52, Christian König escreveu:
Am 13.07.23 um 23:32 schrieb André Almeida:
If a kernel thread caused the reset, the information available to be
logged will be limited, so return early in the dump function.
Why? The register values and vram lost state should still be valid.
The lp855x_bl_update_status function's return type is int, but
it always returns 0, without checking for the results of the
write_byte/pwm_ctrl functions called within.
Make this function return the return values of the functions it
calls, and modify the lp855x_pwm_ctrl function to return errors.
As pointed out by Uwe Kleine-König[1], the changes introduced in
commit c1ff7da03e16 ("video: backlight: lp855x: Get PWM for PWM mode
during probe") caused the PWM state set up by the bootloader to be
re-set when the driver is probed. This differs from the behavior from
before that patch, where
Two small fixes after commit c1ff7da03e16 ("video: backlight: lp855x:
Get PWM for PWM mode during probe"), stemming from a review[1] by
Uwe Kleine-König.
[1] https://lore.kernel.org/all/20230614083953.e4kkweddjz7wz...@pengutronix.de/
Signed-off-by: Artur Weber
Artur Weber (2):
backlight:
Hi Simon
Thanks!
Reviewed-by:JamesZhufortheseries.Best Regards! James Zhu
On 2023-07-14 06:46, Simon Ser wrote:
This makes it easier to figure out what the "type" variable can be
set to when reading the implementation of these functions.
Signed-off-by: Simon Ser
Cc: Christian König
Cc: James
On 14/07/2023 19.18, Christian König wrote:
Am 14.07.23 um 12:06 schrieb Asahi Lina:
On 14/07/2023 18.57, Christian König wrote:
Am 14.07.23 um 11:49 schrieb Asahi Lina:
On 14/07/2023 17.43, Christian König wrote:
Am 14.07.23 um 10:21 schrieb Asahi Lina:
A signaled scheduler fence can
On 7/11/2023 1:51 PM, Dan Carpenter wrote:
If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages. Call put_page() on
the pages before returning.
Fixes: 129776ac2e38 ("accel/qaic: Add control path")
Signed-off-by: Dan Carpenter
On 7/11/2023 1:51 PM, Dan Carpenter wrote:
The integer overflow checking for find_and_map_user_pages() was done in
encode_dma(). Presumably this was to do it before the allocation. But
it's not super important that the failure path is a fast path and it
hurts readability to put the check so
On 7/11/2023 1:51 PM, Dan Carpenter wrote:
The encode_dma() function has integer overflow checks. The
encode_passthrough(), encode_activate() and encode_status() functions
did not. I added integer overflow checking everywhere. I also
updated the integer overflow checking in encode_dma() to
On 7/11/2023 1:50 PM, Dan Carpenter wrote:
Copy the bounds checking from encode_message() to decode_message().
This patch addresses the following concerns. Ensure that there is
enough space for at least one header so that we don't have a negative
size later.
if (msg_hdr_len <
On 7/11/2023 1:50 PM, Dan Carpenter wrote:
There are several issues in this code. The check at the start of the
loop:
if (user_len >= user_msg->len) {
This check does not ensure that we have enough space for the trans_hdr
(8 bytes). Instead the check needs to be:
if
Hi Javier,
On Fri, Jul 14, 2023 at 12:25 PM Javier Martinez Canillas
wrote:
> Geert Uytterhoeven writes:
> > drm_fb_helper_single_fb_probe() first calls drm_fb_helper_find_sizes(),
> > followed by drm_fbdev_generic_helper_fb_probe():
> > - The former tries to find a suitable buffer format,
Hi Simon,
On Fri, Jul 14, 2023 at 1:01 PM Simon Ser wrote:
> On Thursday, July 13th, 2023 at 15:17, Geert Uytterhoeven
> wrote:
> > Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(),
> > which uses bpp and depth to guess the wanted buffer format.
> > However,
Hi Javier,
On Fri, Jul 14, 2023 at 12:14 PM Javier Martinez Canillas
wrote:
> Geert Uytterhoeven writes:
> Thanks a lot for your patch, this has been on my TODO for some time!
>
> > The native display format is monochrome light-on-dark (R1).
> > Hence add support for R1, so monochrome
Introduce a new DRM_IOCTL_SYNCOBJ_EVENTFD IOCTL which signals an
eventfd from a syncobj.
This is useful for Wayland compositors to handle wait-before-submit.
Wayland clients can send a timeline point to the compositor
before the point has materialized yet, then compositors can wait
for the point
Hi
Am 13.07.23 um 17:14 schrieb Tvrtko Ursulin:
On 13/07/2023 16:09, Thomas Zimmermann wrote:
Hi
Am 13.07.23 um 16:41 schrieb Sean Paul:
On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König
wrote:
hello Sean,
On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote:
I'd really prefer this
Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line
Signed-off-by: Jie Shi
---
drivers/gpu/drm/radeon/radeon_audio.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
On Thursday, July 13th, 2023 at 15:17, Geert Uytterhoeven
wrote:
> Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(),
> which uses bpp and depth to guess the wanted buffer format.
> However, drm_client_buffer_addfb() already knows the exact buffer
> format, so there is no
1 - 100 of 213 matches
Mail list logo
