Re: [PATCH v2 2/9] drm/sched: Move schedule policy to scheduler / entity

2023-08-11 Thread Matthew Brost
On Fri, Aug 11, 2023 at 06:43:22PM -0300, Maira Canal wrote: > Hi Matthew, > > I'm not sure in which tree you plan to apply this series, but if you > plan to apply it on drm-misc-next, it would be nice to rebase on top of > it. It would make it easier for driver maintainers to review it. > I

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/gt/pxp: User PXP contexts requires runalone bit in lrc

2023-08-11 Thread kernel test robot
Hi Alan, kernel test robot noticed the following build warnings: [auto build test WARNING on 51fec314404b6a360493f225481083b2a664e3e1] url: https://github.com/intel-lab-lkp/linux/commits/Alan-Previn/drm-i915-pxp-mtl-Update-pxp-firmware-response-timeout/20230811-124534 base

Re: [PATCH -next 3/7] drm/msm: Remove unnecessary NULL values

2023-08-11 Thread Abhinav Kumar
On 8/8/2023 8:44 PM, Ruan Jinjie wrote: The NULL initialization of the pointers assigned by kzalloc() first is not necessary, because if the kzalloc() failed, the pointers will be assigned NULL, otherwise it works as usual. so remove it. Signed-off-by: Ruan Jinjie ---

Re: [PATCH] PCI/VGA: Make the vga_is_firmware_default() less arch-independent

2023-08-11 Thread Bjorn Helgaas
On Tue, Aug 08, 2023 at 10:58:59PM +0800, Sui Jingfeng wrote: > Currently, the vga_is_firmware_default() function works only on x86 and > IA64 architectures, but it is a no-op on ARM64, PPC, RISC-V, etc. This > patch completes the implementation by tracking the firmware framebuffer's > address

Re: [PATCH v2 2/9] drm/sched: Move schedule policy to scheduler / entity

2023-08-11 Thread Maira Canal
Hi Matthew, I'm not sure in which tree you plan to apply this series, but if you plan to apply it on drm-misc-next, it would be nice to rebase on top of it. It would make it easier for driver maintainers to review it. Apart from the small nit below it, I tested the Xe tree on v3d and things

[pull] amdgpu, amdkfd, radeon, drm_buddy drm-next-6.6

2023-08-11 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 6.6. The following changes since commit d9aa1da9a8cfb0387eb5703c15bd1f54421460ac: Merge tag 'drm-intel-gt-next-2023-08-04' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2023-08-07 13:49:25 +1000) are available in the Git repository at:

Re: [PATCH v6] drm/doc: Document DRM device reset expectations

2023-08-11 Thread Randy Dunlap
Hi, On 8/11/23 11:55, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > > --- > > Changes: > - Due to substantial changes in the content, dropped Pekka's Acked-by > - Grammar fixes

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-11 Thread Robin Murphy
On 2023-08-11 17:56, Daniel Stone wrote: Hi, On 11/08/2023 17:35, Robin Murphy wrote: On 2023-08-09 17:53, Boris Brezillon wrote: +obj-$(CONFIG_DRM_PANTHOR) += panthor.o FWIW I still think it would be nice to have a minor directory/Kconfig/Makefile reshuffle and a trivial bit of extra

Re: [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-08-11 Thread Rob Clark
It is in https://gitlab.freedesktop.org/drm/msm/-/merge_requests/75 so should be in msm-next for v6.6 BR, -R On Fri, Aug 11, 2023 at 9:11 AM Fabio Estevam wrote: > > Hi Rob, > > Any comments, please? > > On Mon, Jul 24, 2023 at 5:28 PM Fabio Estevam wrote: > > > > Hi Rob, > > > > A gentle

[PATCH v6] drm/doc: Document DRM device reset expectations

2023-08-11 Thread André Almeida
Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Signed-off-by: André Almeida --- Changes: - Due to substantial changes in the content, dropped Pekka's Acked-by - Grammar fixes (Randy) - Add paragraph about disabling device resets - Add

[PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-11 Thread Zhanjun Dong
This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. When intel_gt_reset was called, task will hold a lock. To cacel delayed work here, the _sync version will also acquire a lock, which might trigger the possible cirular locking dependency warning. When

[PATCH v2 6/6] drm/tests: Add KUnit tests for drm_fb_memcpy()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_memcpy() to ensure correctness and prevent future regressions. The test case can accept different formats. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 391 + 1 file changed, 391 insertions(+)

[PATCH v2 5/6] drm/tests: Add multi-plane support to conversion_buf_size()

2023-08-11 Thread Arthur Grillo
The drm_fb_memcpy() supports multi-plane formats. To fully test it in the future, add multi-plane support to the conversion_buf_size() helper. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 28 +- 1 file

[PATCH v2 2/6] drm/tests: Add KUnit tests for drm_fb_swab()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_swab() to ensure correctness and prevent future regressions. Each expected color has it bytes reversed in order, so xrgb would be bgrx. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 66

[PATCH v2 3/6] drm/tests: Add KUnit tests for drm_fb_clip_offset()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_clip_offset() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 91 ++ 1 file changed, 91 insertions(+) diff --git

[PATCH v2 4/6] drm/tests: Add KUnit tests for drm_fb_build_fourcc_list()

2023-08-11 Thread Arthur Grillo
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 148 + 1 file changed, 148 insertions(+) diff --git

[PATCH v2 1/6] drm/tests: Test default pitch fallback

2023-08-11 Thread Arthur Grillo
Test the default pitch fallback when NULL is passed as the dst_pitch on the conversion procedures. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 126 - 1 file changed, 81 insertions(+), 45 deletions(-) diff --git

[PATCH v2 0/6] Increase code coverage on drm_format_helper.c

2023-08-11 Thread Arthur Grillo
The following series include improvements and new KUnit tests to some functions on drm_format_helper.c. The first patch improves existing conversion tests to assure that the default pitch is used when NULL is used on the `dst_pitch` argument. Patches 2, 3, 4, and 6 add the new parametrized tests

Re: [PATCH drm-misc-next] drm/nouveau: sched: avoid job races between entities

2023-08-11 Thread Faith Ekstrand
On Thu, Aug 10, 2023 at 8:06 PM Danilo Krummrich wrote: > If a sched job depends on a dma-fence from a job from the same GPU > scheduler instance, but a different scheduler entity, the GPU scheduler > does only wait for the particular job to be scheduled, rather than for > the job to fully

Re: [PATCH 05/11] drm/bridge: tc358768: Print logical values, not raw register values

2023-08-11 Thread Tomi Valkeinen
On 11/08/2023 19:31, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: The driver debug prints DSI related timings as raw register values in hex. It is much more useful to see the "logical" value of the timing, not the register value. I'm a bit confused by the term 'logical'

Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-08-11 Thread Rob Herring
On Thu, 27 Jul 2023 18:13:33 +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > > Changes in v2: > - Removed the unnecessary inclusion of header rpmpd.h. > > This patch is

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-11 Thread Tomi Valkeinen
On 11/08/2023 19:23, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: The driver has a few places where it does: if (thing_is_enabled_in_config) update_thing_bit_in_hw() This means that if the thing is _not_ enabled, the bit never gets cleared. This affects the

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-11 Thread Tomi Valkeinen
On 11/08/2023 19:44, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: I would rather have a commit message than a blank one. Oops... Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358768.c | 64 +++ 1 file changed, 45

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-11 Thread Daniel Stone
Hi, On 11/08/2023 17:35, Robin Murphy wrote: On 2023-08-09 17:53, Boris Brezillon wrote: +obj-$(CONFIG_DRM_PANTHOR) += panthor.o FWIW I still think it would be nice to have a minor directory/Kconfig/Makefile reshuffle and a trivial bit of extra registration glue to build both drivers into

Re: [git pull] drm fixes for 6.4-rc6

2023-08-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Aug 2023 16:27:34 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9b1b1b74ddb236e7ccf6d11d4c0b642fbe0c66c6 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: I would rather have a commit message than a blank one. > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/tc358768.c | 64 > +++ > 1 file changed, 45 insertions(+), 19 deletions(-) > > diff --git

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
On Fri, Aug 11, 2023 at 9:31 AM Konrad Dybcio wrote: > > On 11.08.2023 18:21, Rob Clark wrote: > > On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio > > wrote: > >> > >> On 11.08.2023 18:09, Rob Clark wrote: > >>> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: > > From: Rob Clark >

Re: [PATCH 10/11] drm/bridge: tc358768: Attempt to fix DSI horizontal timings

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The DSI horizontal timing calculations done by the driver seem to often > lead to underflows or overflows, depending on the videomode. > > There are two main things the current driver doesn't seem to get right: > DSI HSW and HFP, and VSDly. However,

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-11 Thread Robin Murphy
On 2023-08-09 17:53, Boris Brezillon wrote: Now that all blocks are available, we can add/update Kconfig/Makefile files to allow compilation. v2: - Rename the driver (pancsf -> panthor) - Change the license (GPL2 -> MIT + GPL2) - Split the driver addition commit - Add new dependencies on GPUVA

Re: [PATCH 09/11] drm/bridge: tc358768: Fix tc358768_ns_to_cnt()

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The tc358768_ns_to_cnt() is, most likely, supposed to do a div-round-up > operation, but it misses subtracting one from the dividend. > > Fix this by just using DIV_ROUND_UP(). Reviewed-by: Peter Ujfalusi > Fixes: ff1ca6397b1d ("drm/bridge: Add

Re: [PATCH 08/11] drm/bridge: tc358768: Clean up clock period code

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The driver defines TC358768_PRECISION as 1000, and uses "nsk" to refer > to clock periods. The original author does not remember where all this > came from. I can confirm this! > Effectively the driver is using picoseconds as the unit for > clock

Re: [PATCH 07/11] drm/bridge: tc358768: Rename dsibclk to hsbyteclk

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The Toshiba documentation talks about HSByteClk when referring to the > DSI HS byte clock, whereas the driver uses 'dsibclk' name. Also, in a > few places the driver calculates the byte clock from the DSI clock, even > if the byte clock is already

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Konrad Dybcio
On 11.08.2023 18:21, Rob Clark wrote: > On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio > wrote: >> >> On 11.08.2023 18:09, Rob Clark wrote: >>> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: From: Rob Clark There isn't actually a a690_gmu.bin. But it appears that the

Re: [PATCH 06/11] drm/bridge: tc358768: Use dev for dbg prints, not priv->dev

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > Simplify the code by capturing the priv->dev value to dev variable, and > use it. Reviewed-by: Peter Ujfalusi > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/tc358768.c | 41 > --- > 1 file

Re: [PATCH 05/11] drm/bridge: tc358768: Print logical values, not raw register values

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The driver debug prints DSI related timings as raw register values in > hex. It is much more useful to see the "logical" value of the timing, > not the register value. I'm a bit confused by the term 'logical' value, I think you meant decimal, easier

Re: [PATCH 04/11] drm/bridge: tc358768: Use struct videomode

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The TC358768 documentation uses HFP, HBP, etc. values to deal with the > video mode, while the driver currently uses the DRM display mode > (htotal, hsync_start, etc). > > Change the driver to convert the DRM display mode to struct videomode, >

Re: [PATCH 03/11] drm/bridge: tc358768: Cleanup PLL calculations

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > As is quite common, some of TC358768's PLL register fields are to be > programmed with (value - 1). Specifically, the FBD and PRD, multiplier > and divider, are such fields. > > However, what the driver currently does is that it considers that the >

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The driver has a few places where it does: > > if (thing_is_enabled_in_config) > update_thing_bit_in_hw() > > This means that if the thing is _not_ enabled, the bit never gets > cleared. This affects the h/vsyncs and continuous DSI clock

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio wrote: > > On 11.08.2023 18:09, Rob Clark wrote: > > On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: > >> > >> From: Rob Clark > >> > >> There isn't actually a a690_gmu.bin. But it appears that the normal > >> a660_gmu.bin works fine. Normally

Re: [PATCH 01/11] drm/bridge: tc358768: Fix use of uninitialized variable

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > smatch reports: > > drivers/gpu/drm/bridge/tc358768.c:223 tc358768_update_bits() error: > uninitialized symbol 'orig'. > > Fix this by bailing out from tc358768_update_bits() if the > tc358768_read() produces an error. > > Fixes: ff1ca6397b1d

Re: [PATCH 1/1] drm/fourcc: Add documentation about software color conversion.

2023-08-11 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Hello Jocelyn, > On 10/08/2023 09:45, Maxime Ripard wrote: >> Hi >> >> On Mon, Aug 07, 2023 at 03:45:15PM +0200, Jocelyn Falempe wrote: >>> After discussions on IRC, the consensus is that the DRM drivers should >>> not do software color conversion, and only advertise

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Konrad Dybcio
On 11.08.2023 18:09, Rob Clark wrote: > On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: >> >> From: Rob Clark >> >> There isn't actually a a690_gmu.bin. But it appears that the normal >> a660_gmu.bin works fine. Normally all the devices within a sub- >> generation (or "family") will use the

Re: [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-08-11 Thread Fabio Estevam
Hi Rob, Any comments, please? On Mon, Jul 24, 2023 at 5:28 PM Fabio Estevam wrote: > > Hi Rob, > > A gentle ping. > > On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov > wrote: > > > > On 21/06/2023 02:23, Fabio Estevam wrote: > > > From: Fabio Estevam > > > > > > The adreno_is_a20x() and

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: > > From: Rob Clark > > There isn't actually a a690_gmu.bin. But it appears that the normal > a660_gmu.bin works fine. Normally all the devices within a sub- > generation (or "family") will use the same fw, and a690 is in the a660 > family. >

Re: [PATCH v2 15/15] drm/panthor: Add an entry to MAINTAINERS

2023-08-11 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Add an entry for the Panthor driver to the MAINTAINERS file. > > v2: > - New commit > > Signed-off-by: Boris Brezillon > --- > > If anyone from Arm wants to volunteer to become a co-maintainer, that > would be highly appreciated *sticks his hand

[PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
From: Rob Clark There isn't actually a a690_gmu.bin. But it appears that the normal a660_gmu.bin works fine. Normally all the devices within a sub- generation (or "family") will use the same fw, and a690 is in the a660 family. Signed-off-by: Rob Clark ---

Re: [PATCH 1/6] dt-bindings: trivial-devices: Remove national,lm75

2023-08-11 Thread Rob Herring
On Thu, 10 Aug 2023 16:44:46 +0200, Alexander Stein wrote: > Starting with commit 3e37c9d48f7a ("dt-bindings: hwmon: Convert lm75 > bindings to yaml") 'national,lm75' has it's own dedicated (YAML) binding. > If kept in this file device specific properties as 'vs-supply' are > considered

Re: [PATCH v2 04/15] drm/panthor: Add the device logical block

2023-08-11 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > The panthor driver is designed in a modular way, where each logical > block is dealing with a specific HW-block or software feature. In order > for those blocks to communicate with each other, we need a central > panthor_device collecting all the

Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support

2023-08-11 Thread Chris Morgan
On Thu, Aug 10, 2023 at 05:24:09PM -0600, Rob Herring wrote: > On Wed, Aug 09, 2023 at 10:39:40AM -0500, Chris Morgan wrote: > > From: Chris Morgan > > > > Document the Anbernic RG351V panel, which appears to be identical to > > the panel used in their 353 series except for in inclusion of an >

Re: [PATCH drm-misc-next] drm/ttm/tests: Require MMU when testing

2023-08-11 Thread Christian König
Am 11.08.23 um 13:36 schrieb Karolina Stolarek: Satisfy MMU dependency when testing TTM with KUnit. This fixes compilation errors on platforms that don't select this option by default. Signed-off-by: Karolina Stolarek Cc: Christian König Reported-by: kernel test robot Closes:

Re: [PATCH v2 02/15] drm/panthor: Add uAPI

2023-08-11 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Panthor follows the lead of other recently submitted drivers with > ioctls allowing us to support modern Vulkan features, like sparse memory > binding: > > - Pretty standard GEM management ioctls (BO_CREATE and BO_MMAP_OFFSET), > with the

Re: [PATCH v2 03/15] drm/panthor: Add GPU register definitions

2023-08-11 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Those are the registers directly accessible through the MMIO range. > > FW registers are exposed in panthor_fw.h. > > v2: > - Rename the driver (pancsf -> panthor) > - Change the license (GPL2 -> MIT + GPL2) > - Split the driver addition commit > >

Re: [PATCH 2/6] dt-bindings: imx-thermal: Add #thermal-sensor-cells property

2023-08-11 Thread Rob Herring
On Thu, 10 Aug 2023 16:44:47 +0200, Alexander Stein wrote: > This property is defined in thermal-sensor.yaml. Reference this file and > constraint '#thermal-sensor-cells' to 0 for imx-thermal. > Fixes the warning: > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: tempmon: > '#thermal-sensor-cells'

Re: [Intel-xe] [RFC PATCH] Documentation/gpu: Draft VM_BIND locking document

2023-08-11 Thread Thomas Hellström
Thanks for reviewing, Rodrigo! On 8/4/23 22:15, Rodrigo Vivi wrote: On Fri, Jun 30, 2023 at 06:44:52PM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss

[PATCH] backlight: lp855x: fix unintialized function return

2023-08-11 Thread Arnd Bergmann
From: Arnd Bergmann The function now returns an error code in some cases, but fails to initialize it in others: drivers/video/backlight/lp855x_bl.c:252:11: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] else if

Re: [PATCH 1/2] drm/bridge: adv7511: fix Wvoid-pointer-to-enum-cast warning

2023-08-11 Thread Robert Foss
On Thu, Aug 10, 2023 at 12:12 PM Laurent Pinchart wrote: > > Hi Krzysztof, > > Thank you for the patch. > > On Thu, Aug 10, 2023 at 11:59:22AM +0200, Krzysztof Kozlowski wrote: > > 'type' is an enum, thus cast of pointer on 64-bit compile test with W=1 > > causes: > > > > adv7511_drv.c:1214:19:

Re: [PATCH 1/1] drm/bridge: lvds-codec: Implement atomic_get_input_bus_fmts for LVDS encoder

2023-08-11 Thread Robert Foss
On Thu, 10 Aug 2023 08:32:29 +0200, Alexander Stein wrote: > atomic_get_input_bus_fmts is only implemented for LVDS decoders, resulting > that LVDS encoders only support bus format MEDIA_BUS_FMT_FIXED. This > results in warnings like: > mxsfb 21c8000.lcdif: Bridge does not provide bus format,

Re: [PATCH 1/1] drm/bridge: lvds-codec: Implement atomic_get_input_bus_fmts for LVDS encoder

2023-08-11 Thread Robert Foss
On Thu, Aug 10, 2023 at 8:32 AM Alexander Stein wrote: > > atomic_get_input_bus_fmts is only implemented for LVDS decoders, resulting > that LVDS encoders only support bus format MEDIA_BUS_FMT_FIXED. This > results in warnings like: > mxsfb 21c8000.lcdif: Bridge does not provide bus format,

Re: [PATCH v2 01/15] drm/shmem-helper: Make pages_use_count an atomic_t

2023-08-11 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > This way we can grab a pages ref without acquiring the resv lock when > pages_use_count > 0. Need to implement asynchronous map using the NIT: s/Need/This is needed/ > drm_gpuva_mgr when the map/unmap operation triggers a mapping split, > requiring

Re: [PATCH v4] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-08-11 Thread Robert Foss
On Wed, 9 Aug 2023 16:56:41 +0200, Marek Szyprowski wrote: > Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) > doesn't report empty level of packer header FIFO. In case of those SoCs, > use the old way of waiting for empty command tranfsfer FIFO, removed > recently by commit

Re: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY

2023-08-11 Thread Robert Foss
On Thu, 3 Aug 2023 20:01:37 -0700, Randy Dunlap wrote: > Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY > might not be set. This causes Kconfig warnings and a build error. > > WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY > Depends on [n]:

Re: [PATCH] drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM

2023-08-11 Thread Robert Foss
On Sun, 9 Jul 2023 15:48:27 +0200, Marek Vasut wrote: > The ULPS EXIT is initialized to 0xaf in downstream BSP as well as older > revisions of this patchset, in newer revisions of the DSIM patchset it > was left out and set to 0. Fix it. > > Applied, thanks! [1/1] drm: bridge: samsung-dsim:

[PATCH drm-misc-next] drm/ttm/tests: Require MMU when testing

2023-08-11 Thread Karolina Stolarek
Satisfy MMU dependency when testing TTM with KUnit. This fixes compilation errors on platforms that don't select this option by default. Signed-off-by: Karolina Stolarek Cc: Christian König Reported-by: kernel test robot Closes:

Re: [RFC PATCH v2 00/11] Device Memory TCP

2023-08-11 Thread Christian König
Am 10.08.23 um 20:44 schrieb Mina Almasry: On Thu, Aug 10, 2023 at 3:29 AM Christian König wrote: Am 10.08.23 um 03:57 schrieb Mina Almasry: Changes in RFC v2: -- The sticking point in RFC v1[1] was the dma-buf pages approach we used to deliver the device memory to the TCP

[PULL] drm-intel-gt-next

2023-08-11 Thread Joonas Lahtinen
Hi Dave & Daniel, Here's the final drm-intel-gt-next PR for v6.6. Not too many patches as the previous PR was later than usual. Just one more workaround fix for MTL, some object coherency refactoring and selftest fix. Note that there is a backmerge of drm-next[1], too. Regards, Joonas [1] As

[PATCH -next] drm/virtio: Remove unused function declarations

2023-08-11 Thread Yue Haibing
Commit dc5698e80cf7 ("Add virtio gpu driver.") declared but never implemented virtio_gpu_attach_status_page()/virtio_gpu_detach_status_page() Also commit 62fb7a5e1096 ("virtio-gpu: add 3d/virgl support") declared but never implemented virtio_gpu_fence_ack() and virtio_gpu_dequeue_fence_func().

Re: [Intel-xe] [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-08-11 Thread Thomas Hellström
On 8/10/23 22:51, Zanoni, Paulo R wrote: On Thu, 2023-08-10 at 21:49 +0200, Thomas Hellström wrote: Hi, Paulo. Thanks for reviewing. I'd like to try give some answers below. On 8/4/23 23:30, Zanoni, Paulo R wrote: On Fri, 2023-08-04 at 16:02 -0400, Rodrigo Vivi wrote: On Wed, Jul 19, 2023

Re: [PATCH V8 2/9] drivers core: add ACPI based WBRF mechanism introduced by AMD

2023-08-11 Thread Simon Horman
On Thu, Aug 10, 2023 at 03:37:56PM +0800, Evan Quan wrote: > AMD has introduced an ACPI based mechanism to support WBRF for some > platforms with AMD dGPU + WLAN. This needs support from BIOS equipped > with necessary AML implementations and dGPU firmwares. > > For those systems without the ACPI

Re: [PATCH V8 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-11 Thread Simon Horman
On Thu, Aug 10, 2023 at 03:38:00PM +0800, Evan Quan wrote: > With WBRF feature supported, as a driver responding to the frequencies, > amdgpu driver is able to do shadow pstate switching to mitigate possible > interference(between its (G-)DDR memory clocks and local radio module > frequency bands

Re: [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES

2023-08-11 Thread Stanislaw Gruszka
On Thu, Aug 10, 2023 at 08:49:00AM -0600, Jeffrey Hugo wrote: > On 8/10/2023 8:32 AM, Stanislaw Gruszka wrote: > > On Thu, Aug 10, 2023 at 08:27:08AM -0600, Jeffrey Hugo wrote: > > > On 8/10/2023 2:07 AM, Stanislaw Gruszka wrote: > > > > Add comments regarding new DRM_IVPU_PARAM_CAPABILITIES

[PATCH -next] fbdev: atmel_lcdfb: Remove redundant of_match_ptr()

2023-08-11 Thread Ruan Jinjie
The driver depends on CONFIG_OF, it is not necessary to use of_match_ptr() here. Signed-off-by: Ruan Jinjie --- drivers/video/fbdev/atmel_lcdfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index

Re: [PATCH v2 07/11] PCI/VGA: vga_client_register() return -ENODEV on failure, not -1

2023-08-11 Thread Ilpo Järvinen
On Thu, 10 Aug 2023, suijingfeng wrote: > On 2023/8/9 21:52, Ilpo Järvinen wrote: > > On Wed, 9 Aug 2023, Sui Jingfeng wrote: > > > > > From: Sui Jingfeng > > > > > Changelog body is missing. > > > I thought that probably the Fixes tag could be taken as the body of this > commit, > since

[REGRESSION] HDMI connector detection broken in 6.3 on Intel(R) Celeron(R) N3060 integrated graphics

2023-08-11 Thread Mikhail Rudenko
The following is a copy an issue I posted to drm/i915 gitlab [1] two months ago. I repost it to the mailing lists in hope that it will help the right people pay attention to it. After kernel upgrade from 6.2.13 to 6.3 HDMI connector detection is broken for me. Issue is 100% reproducible: 1.

Re: [PATCH] accel/qaic: Clean up integer overflow checking in map_user_pages()

2023-08-11 Thread Carl Vanderlip
On 8/10/2023 5:23 AM, Dan Carpenter wrote: The encode_dma() function has some validation on in_trans->size but it would be more clear to move those checks to find_and_map_user_pages(). The encode_dma() had two checks: if (in_trans->addr + in_trans->size < in_trans->addr ||

[PATCH] drm/i915/gmch: fix build error var set but not used

2023-08-11 Thread Wang Jinchao
When CONFIG_PNP is not defined, i915 will fail to compile with error bellow: drivers/gpu/drm/i915/soc/intel_gmch.c:43:13: error: variable ‘mchbar_addr’ set but not used Fix it by surrounding variable declaration and assignment with ifdef Signed-off-by: Wang Jinchao ---

[PATCH -next] drm/nouveau/fifo: Remove duplicated include

2023-08-11 Thread GUO Zihua
Remove duplicated include of chid.h. Resolves checkincludes message. Signed-off-by: GUO Zihua --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c

[PATCH -next] drm/shmem-helper: Remove duplicated include

2023-08-11 Thread GUO Zihua
Remove duplicated include of linux/module.h. Resolves checkincludes message. Signed-off-by: GUO Zihua --- drivers/gpu/drm/drm_gem_shmem_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index

[PATCH] drm: xlnx: Use devm_platform_ioremap_resource_byname() helper function

2023-08-11 Thread Zhang Zekun
platform_get_resource_byname() and devm_ioremap_resource() can be replaced by devm_platform_ioremap_resource_byname(), which can simplify the code logic a bit, No functional change here. Signed-off-by: Zhang Zekun --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 10 +++--- 1 file changed, 3

Re: [Nouveau] Fwd: System (Xeon Nvidia) hangs at boot terminal after kernel 6.4.7

2023-08-11 Thread Peter Bottomley
6.4.9 built with unconn.c from 6.4.6 builds and boots and runs fine. Thanks everybody.

Re: [PATCH] drm: xlnx: Use devm_platform_ioremap_resource_byname() helper function

2023-08-11 Thread zhangzekun (A)
I am sorry for make noise, this patch has been sent  before: https://lore.kernel.org/linux-arm-kernel/20230801214729.gf8...@pendragon.ideasonboard.com/T/ Please ignore this patch. 在 2023/8/11 10:11, Zhang Zekun 写道: platform_get_resource_byname() and devm_ioremap_resource() can be replaced by

drm/nouveau: switch over to vmemdup_user()

2023-08-11 Thread Atul Raut
Use vmemdup_user() rather than duplicating its implementation. This patch fixes the following Coccinelle warning: ./drivers/gpu/drm/nouveau/nouveau_gem.c:630:7-15: WARNING opportunity for vmemdup_user Signed-off-by: Atul Raut --- drivers/gpu/drm/nouveau/nouveau_gem.c | 9 ++--- 1 file

Re: [PATCH v2 02/11] PCI: Add the pci_get_class_masked() helper

2023-08-11 Thread Ilpo Järvinen
On Thu, 10 Aug 2023, suijingfeng wrote: > Hi, > > > On 2023/8/9 22:01, Ilpo Järvinen wrote: > > On Wed, 9 Aug 2023, Sui Jingfeng wrote: > > > > > From: Sui Jingfeng > > > > > > Because there is no good way to get the mask member used to searching for > > > devices that conform to a specific

Re: [REGRESSION] HDMI connector detection broken in 6.3 on Intel(R) Celeron(R) N3060 integrated graphics

2023-08-11 Thread Jani Nikula
On Fri, 11 Aug 2023, Thorsten Leemhuis wrote: > [CCing the i915 maintainers and the dri maintainers] > > Hi, Thorsten here, the Linux kernel's regression tracker. > > On 10.08.23 21:33, Mikhail Rudenko wrote: >> The following is a copy an issue I posted to drm/i915 gitlab [1] two >> months ago. I

Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

2023-08-11 Thread Conor Dooley
On Thu, Aug 10, 2023 at 08:30:21PM +0100, Conor Dooley wrote: > On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: > > Hi, > > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > > > requirement

Re: [REGRESSION] HDMI connector detection broken in 6.3 on Intel(R) Celeron(R) N3060 integrated graphics

2023-08-11 Thread Thorsten Leemhuis
[CCing the i915 maintainers and the dri maintainers] Hi, Thorsten here, the Linux kernel's regression tracker. On 10.08.23 21:33, Mikhail Rudenko wrote: > The following is a copy an issue I posted to drm/i915 gitlab [1] two > months ago. I repost it to the mailing lists in hope that it will help

[git pull] drm fixes for 6.4-rc6

2023-08-11 Thread Dave Airlie
Hey Linus, This week's fixes, as expected amdgpu is probably a little larger since it skipped a week, but otherwise a few nouveau fixes, a couple of bridge, rockchip and ivpu fixes. Dave. drm-fixes-2023-08-11: drm fixes for 6.4-rc6 amdgpu: - S/G display workaround for platforms with >= 64G of