Re: [PATCH v4 00/14] drm: Add a driver for CSF-based Mali GPUs

2024-01-28 Thread Boris Brezillon
On Mon, 22 Jan 2024 17:30:31 +0100 Boris Brezillon wrote: > Hello, > > This is the 4th version of the kernel driver for Mali CSF-based GPUs. > > A branch based on drm-misc-next and containing all the dependencies > that are not yet available in drm-misc-next here[1], and another [2] >

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Vlastimil Babka
On 1/29/24 08:44, Christian König wrote: > Am 26.01.24 um 17:29 schrieb Matthew Brost: >> On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: >>> Am 25.01.24 um 18:30 schrieb Matthew Brost: On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: > Am 24.01.24 um

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Christian König
Am 26.01.24 um 17:29 schrieb Matthew Brost: On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: Am 25.01.24 um 18:30 schrieb Matthew Brost: On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: Am 24.01.24 um 22:08 schrieb Matthew Brost: All entities must be drained

Re: [PATCH] dt-bindings: display: bridge: it6505: Add #sound-dai-cells

2024-01-28 Thread Chen-Yu Tsai
On Fri, Jan 26, 2024 at 6:17 PM Krzysztof Kozlowski wrote: > > On 26/01/2024 08:35, Chen-Yu Tsai wrote: > > The ITE IT6505 display bridge can take one I2S input and transmit it > > over the DisplayPort link. > > > > Add #sound-dai-cells (= 0) to the binding for it. > > > > Signed-off-by: Chen-Yu

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar wrote: On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar wrote: On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:48, Paloma

[PATCH v4, 21/22] media: mediatek: vcodec: move vdec init interface to setup callback

2024-01-28 Thread Yunfei Dong
Getting secure video playback (svp) flag when request output buffer, then calling init interface to init svp parameters in optee-os. Signed-off-by: Yunfei Dong --- .../mediatek/vcodec/decoder/mtk_vcodec_dec.c | 139 +++--- 1 file changed, 89 insertions(+), 50 deletions(-) diff

[PATCH v4, 17/22] media: mediatek: vcodec: re-construct h264 driver to support svp mode

2024-01-28 Thread Yunfei Dong
Need secure buffer size to convert secure handle to secure pa in optee-os, re-construct the vsi struct to store each secure buffer size. Separate svp and normal wait interrupt condition for svp mode waiting hardware interrupt in optee-os. Signed-off-by: Yunfei Dong ---

[PATCH v4, 16/22] media: mediatek: vcodec: support one plane capture buffer

2024-01-28 Thread Yunfei Dong
The capture buffer has two planes for format MM21, but user space only allocate secure memory for plane[0], and the size is Y data + uv data. The driver need to support one plane decoder for svp mode. Signed-off-by: Yunfei Dong --- .../mediatek/vcodec/decoder/mtk_vcodec_dec.c | 7 -

[PATCH v4,09/22] media: mediatek: vcodec: allocate tee share memory

2024-01-28 Thread Yunfei Dong
Allocate two share memory for each lat and core hardware used to share information with optee-os. Msg buffer used to send ipi command and get ack command with optee-os, data buffer used to store vsi information which used for hardware decode. Signed-off-by: Yunfei Dong ---

[PATCH v4, 13/22] media: mediatek: vcodec: using shared memory as vsi address

2024-01-28 Thread Yunfei Dong
The vsi buffer is allocated by tee share memory for svp mode, need to use the share memory as the vsi address to store vsi data. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c | 9 +++-- .../media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c | 8

[PATCH v4, 19/22] media: mediatek: vcodec: disable wait interrupt for svp mode

2024-01-28 Thread Yunfei Dong
Waiting interrupt in optee-os for svp mode, need to disable it in kernel in case of interrupt is cleaned. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/mtk_vcodec_dec_hw.c| 34 +-- .../vcodec/decoder/mtk_vcodec_dec_pm.c| 6 +-

[PATCH v4,20/22] media: mediatek: vcodec: support tee decoder

2024-01-28 Thread Yunfei Dong
Initialize tee private data to support secure decoder. Release tee related information for each instance when decoder done. Signed-off-by: Yunfei Dong --- .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v4, 22/22] media: mediatek: vcodec: support hevc svp for mt8188

2024-01-28 Thread Yunfei Dong
Change hevc driver to support secure video playback(svp) for mt8188. Need to map shared memory with optee interface and wait interrupt in optee-os. Signed-off-by: Yunfei Dong --- .../decoder/vdec/vdec_hevc_req_multi_if.c | 89 +++ 1 file changed, 54 insertions(+), 35

[PATCH v4, 08/22] media: mediatek: vcodec: add tee client interface to communiate with optee-os

2024-01-28 Thread Yunfei Dong
Open tee context to initialize the environment in order to communication with optee-os, then open tee session as the communication pipeline for lat and core to send data for hardware decode. Signed-off-by: Yunfei Dong --- .../platform/mediatek/vcodec/decoder/Makefile | 1 +

[PATCH v4, 18/22] media: mediatek: vcodec: remove parse nal_info in kernel

2024-01-28 Thread Yunfei Dong
The hardware can parse syntax to get nal_info, needn't to use cpu. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c| 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git

[PATCH v4, 14/22] media: mediatek: vcodec: Add capture format to support one plane memory

2024-01-28 Thread Yunfei Dong
Define one uncompressed capture format V4L2_PIX_FMT_MS21 in order to support one plane memory. The buffer size is luma + chroma, luma is stored at the start and chrome is stored at the end. Signed-off-by: Yunfei Dong --- Documentation/userspace-api/media/v4l/pixfmt-reserved.rst | 8

[PATCH v4,15/22] media: mediatek: vcodec: Add one plane format

2024-01-28 Thread Yunfei Dong
Adding capture formats to support V4L2_PIX_FMT_MS21. This format has one plane and only be used for secure video playback at current period. Signed-off-by: Yunfei Dong --- .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec.c| 4 +++- .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c

[PATCH v4, 10/22] media: mediatek: vcodec: send share memory data to optee

2024-01-28 Thread Yunfei Dong
Setting msg and vsi information to shared buffer, then call tee invoke function to send it to optee-os. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/mtk_vcodec_dec_optee.c | 140 ++ .../vcodec/decoder/mtk_vcodec_dec_optee.h | 51 +++ 2 files changed, 191

[PATCH v4, 12/22] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-01-28 Thread Yunfei Dong
Need to call dma heap interface to allocate/free secure memory when playing secure video. Signed-off-by: Yunfei Dong --- .../media/platform/mediatek/vcodec/Kconfig| 1 + .../mediatek/vcodec/common/mtk_vcodec_util.c | 122 +- .../mediatek/vcodec/common/mtk_vcodec_util.h |

[PATCH v4, 03/22] v4l2: verify restricted dmabufs are used in restricted queue

2024-01-28 Thread Yunfei Dong
From: Jeffrey Kardatzke Verfies in the dmabuf implementations that if the restricted memory flag is set for a queue that the dmabuf submitted to the queue is unmappable. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- drivers/media/common/videobuf2/videobuf2-dma-contig.c | 8

[PATCH v4, 11/22] media: mediatek: vcodec: initialize msg and vsi information

2024-01-28 Thread Yunfei Dong
Need to initialize msg and vsi information before sending to optee-os, then calling optee invoke command to send the information to optee-os. For the optee communication interface is different with scp, using flag to separate them. Signed-off-by: Yunfei Dong ---

[PATCH v4,04/22] v4l: add documentation for restricted memory flag

2024-01-28 Thread Yunfei Dong
From: Jeffrey Kardatzke Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- Documentation/userspace-api/media/v4l/buffer.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH v4,06/22] dma-heap: Add proper kref handling on dma-buf heaps

2024-01-28 Thread Yunfei Dong
From: John Stultz Add proper refcounting on the dma_heap structure. While existing heaps are built-in, we may eventually have heaps loaded from modules, and we'll need to be able to properly handle the references to the heaps Signed-off-by: John Stultz Signed-off-by: T.J. Mercier

[PATCH v4,00/22] media: add driver to support secure video decoder

2024-01-28 Thread Yunfei Dong
The patch series used to enable secure video playback (SVP) on MediaTek hardware in the Linux kernel. Memory Definitions: secure memory - Memory allocated in the TEE (Trusted Execution Environment) which is inaccessible in the REE (Rich Execution Environment, i.e. linux kernel/user space). secure

[PATCH v4, 07/22] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2024-01-28 Thread Yunfei Dong
From: John Stultz This allows drivers who don't want to create their own DMA-BUF exporter to be able to allocate DMA-BUFs directly from existing DMA-BUF Heaps. There is some concern that the premise of DMA-BUF heaps is that userland knows better about what type of heap memory is needed for a

[PATCH v4, 05/22] dma-buf: heaps: Deduplicate docs and adopt common format

2024-01-28 Thread Yunfei Dong
From: "T.J. Mercier" The docs for dma_heap_get_name were incorrect, and since they were duplicated in the header they were wrong there too. The docs formatting was inconsistent so I tried to make it more consistent across functions since I'm already in here doing cleanup. Remove multiple

[PATCH v4,01/22] v4l2: add restricted memory flags

2024-01-28 Thread Yunfei Dong
From: Jeffrey Kardatzke Adds a V4L2 flag which indicates that a queue is using restricted dmabufs and the corresponding capability flag. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- include/media/videobuf2-core.h | 8 +++- include/uapi/linux/videodev2.h | 2 ++ 2 files

[PATCH v4,02/22] v4l2: handle restricted memory flags in queue setup

2024-01-28 Thread Yunfei Dong
From: Jeffrey Kardatzke Validates the restricted memory flags when setting up a queue and ensures the queue has the proper capability. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- .../media/common/videobuf2/videobuf2-core.c | 21 +++

Re: [PATCH v19 22/30] drm/shmem-helper: Add common memory shrinker

2024-01-28 Thread Dmitry Osipenko
On 1/26/24 21:12, Boris Brezillon wrote: > On Fri, 26 Jan 2024 19:27:49 +0300 > Dmitry Osipenko wrote: > >> On 1/26/24 12:55, Boris Brezillon wrote: >>> On Fri, 26 Jan 2024 00:56:47 +0300 >>> Dmitry Osipenko wrote: >>> On 1/25/24 13:19, Boris Brezillon wrote: > On Fri, 5 Jan 2024

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar wrote: > > > > On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: > >>> On Sun, 28 Jan 2024 at 07:48, Paloma Arellano > >>>

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 9:05 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 06:30, Abhinav Kumar wrote: On 1/28/2024 7:52 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:17, Abhinav Kumar wrote: On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Luben Tuikov
On 2024-01-26 11:29, Matthew Brost wrote: > On Fri, Jan 26, 2024 at 11:32:57AM +0100, Christian König wrote: >> Am 25.01.24 um 18:30 schrieb Matthew Brost: >>> On Thu, Jan 25, 2024 at 04:12:58PM +0100, Christian König wrote: Am 24.01.24 um 22:08 schrieb Matthew Brost: > All entities

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 06:33, Abhinav Kumar wrote: > > > > On 1/28/2024 8:12 PM, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 06:01, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 1/28/2024 7:23 PM, Dmitry Baryshkov wrote: > >>> On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar > >>> wrote:

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 06:30, Abhinav Kumar wrote: > > > > On 1/28/2024 7:52 PM, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 05:17, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: > >>> On 25/01/2024 21:38, Paloma Arellano wrote: > All the

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar wrote: On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:48, Paloma Arellano wrote: On 1/25/2024 1:57 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 8:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 06:01, Abhinav Kumar wrote: On 1/28/2024 7:23 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar wrote: On 1/26/2024 4:39 PM, Paloma Arellano wrote: On 1/25/2024 1:14 PM, Dmitry Baryshkov

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 7:52 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:17, Abhinav Kumar wrote: On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector property as

Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-01-28 Thread Byungchul Park
On Fri, Jan 26, 2024 at 06:30:02PM +0100, Thomas Gleixner wrote: > On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: > > Why is lockdep in the subsystem prefix here? You are changing the CPU > hotplug (not hotplus) code, right? I will fix the typo ;( Thank you. I referred to the commit

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 06:01, Abhinav Kumar wrote: > > > > On 1/28/2024 7:23 PM, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 1/26/2024 4:39 PM, Paloma Arellano wrote: > >>> > >>> On 1/25/2024 1:14 PM, Dmitry Baryshkov wrote: >

Re: [PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-28 Thread Luben Tuikov
On 2024-01-24 16:08, Matthew Brost wrote: > All entities must be drained in the DRM scheduler run job worker to > avoid the following case. An entity found that is ready, no job found > ready on entity, and run job worker goes idle with other entities + jobs > ready. Draining all ready entities

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 7:23 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar wrote: On 1/26/2024 4:39 PM, Paloma Arellano wrote: On 1/25/2024 1:14 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Generalize dpu_encoder_helper_phys_setup_cdm to be

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 05:17, Abhinav Kumar wrote: > > > > On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: > > On 25/01/2024 21:38, Paloma Arellano wrote: > >> All the components of YUV420 over DP are added. Therefore, let's mark the > >> connector property as true for DP connector when the DP type

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar wrote: > > > > On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: > > On Sun, 28 Jan 2024 at 07:48, Paloma Arellano > > wrote: > >> > >> > >> On 1/25/2024 1:57 PM, Dmitry Baryshkov wrote: > >>> On 25/01/2024 21:38, Paloma Arellano wrote: > Adjust the

Re: [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-28 Thread Dharma.B
Hi Conor, On 26/01/24 9:03 pm, Conor Dooley wrote: > On Fri, Jan 26, 2024 at 02:22:42PM +,dharm...@microchip.com wrote: >> On 25/01/24 1:57 pm, Conor Dooley - M52691 wrote: > If the lvds pll is an input to the hlcdc, you need to add it here. >From your description earlier it does

Re: [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()

2024-01-28 Thread Zhenyu Wang
On 2024.01.26 11:41:47 +0300, Dan Carpenter wrote: > This code prints the wrong variable in the warning message. It should > print "i" instead of "info->offset". On the first iteration "info" is > uninitialized leading to a crash and on subsequent iterations it prints > the previous offset

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Dmitry Baryshkov
On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar wrote: > > > > On 1/26/2024 4:39 PM, Paloma Arellano wrote: > > > > On 1/25/2024 1:14 PM, Dmitry Baryshkov wrote: > >> On 25/01/2024 21:38, Paloma Arellano wrote: > >>> Generalize dpu_encoder_helper_phys_setup_cdm to be compatible with DP. > >>> > >>>

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Abhinav Kumar
On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector property as true for DP connector when the DP type is not eDP and when VSC SDP is supported. Signed-off-by: Paloma

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Abhinav Kumar
On 1/26/2024 4:39 PM, Paloma Arellano wrote: On 1/25/2024 1:14 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Generalize dpu_encoder_helper_phys_setup_cdm to be compatible with DP. Signed-off-by: Paloma Arellano ---   .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h 

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Abhinav Kumar
On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:48, Paloma Arellano wrote: On 1/25/2024 1:57 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate CDM related

[drm-tip:drm-tip 1/7] drivers/gpu/drm/bridge/samsung-dsim.c:1504:3: error: implicit declaration of function 'samsung_dsim_set_stop_state' is invalid in C99

2024-01-28 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 0f1b42b9d395bd4097b2846230a13869dc638216 commit: cd3a0e22e5de2867cd98b5223094a467a5b0993d [1/7] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: arm-defconfig

[PATCH] nouveau: offload fence uevents work to workqueue

2024-01-28 Thread Dave Airlie
From: Dave Airlie This should break the deadlock between the fctx lock and the irq lock. This offloads the processing off the work from the irq into a workqueue. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_fence.c | 24 ++--

Re: [PATCH] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-01-28 Thread Dominik Förderer
I've applied the patch to 6.7.2. The device then shows up under: /sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings (on Framework Laptop 13 amd 7840U with 780M). After a few tests i can say that at least in my system it’s not working. Setting a

Re: KASAN: use-after-free Read in drm_gem_object_release

2024-01-28 Thread Hussen Argaw
+251961377649 dila Ethiopia

Re: [PATCH] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-01-28 Thread administrator
I've applied the patch to 6.7.2. The device then shows up under: /sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings (on Framework Laptop 13 amd 7840U with 780M). After a few tests i can say that at least in my system it’s not working. Setting a

Re: [PATCH] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-01-28 Thread Dominik Förderer
I've applied the patch to 6.7.2. The device then shows up under: /sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings (on Framework Laptop 13 amd 7840U with 780M). After a few tests i can say that at least in my system it’s not working. Setting a

Re: [PATCH] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-01-28 Thread Dominik Förderer
I've applied the patch to 6.7.2. The device then shows up under: /sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings (on Framework Laptop 13 amd 7840U with 780M). After a few tests i can say that at least in my system it’s not working. Setting a

Re: [PATCH next 10/11] block: Use a boolean expression instead of max() on booleans

2024-01-28 Thread Linus Torvalds
On Sun, 28 Jan 2024 at 14:22, David Laight wrote: > > H blame gcc :-) I do agree that the gcc warning quoting is unnecessarily ugly (even just visually), but.. > The error message displays as '0' but is e2:80:98 30 e2:80:99 > I HATE UTF-8, it wouldn't be as bad if it were a bijection. No,

RE: [PATCH next 10/11] block: Use a boolean expression instead of max() on booleans

2024-01-28 Thread David Laight
From: Linus Torvalds > Sent: 28 January 2024 19:59 > > On Sun, 28 Jan 2024 at 11:36, David Laight wrote: > > > > However it generates: > > error: comparison of constant ‘0’ with boolean expression is always > > true [-Werror=bool-compare] > > inside the signedness check that max() does

[PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes

2024-01-28 Thread André Almeida
AMD GPUs can do async flips with changes on more properties than just the FB ID, so implement a custom check_async_props for AMD planes. Allow amdgpu to do async flips with overlay planes as well. Signed-off-by: André Almeida --- v3: allow overlay planes

[PATCH v3 0/3] drm/atomic: Allow drivers to write their own plane check for async

2024-01-28 Thread André Almeida
Hi, AMD hardware can do more on the async flip path than just the primary plane, so to lift up the current restrictions, this patchset allows drivers to write their own check for planes for async flips. This patchset allows for async commits with IN_FENCE_ID in any driver and overlay planes on

[PATCH v3 1/3] drm/atomic: Allow drivers to write their own plane check for async flips

2024-01-28 Thread André Almeida
Some hardware are more flexible on what they can flip asynchronously, so rework the plane check so drivers can implement their own check, lifting up some of the restrictions. Signed-off-by: André Almeida --- v3: no changes drivers/gpu/drm/drm_atomic_uapi.c | 62 ++-

[PATCH v3 2/3] drm/atomic: Allow userspace to use explicit sync with atomic async flips

2024-01-28 Thread André Almeida
Allow userspace to use explicit synchronization with atomic async flips. That means that the flip will wait for some hardware fence, and then will flip as soon as possible (async) in regard of the vblank. Signed-off-by: André Almeida --- v3: new patch drivers/gpu/drm/drm_atomic_uapi.c | 3 ++-

[PATCH] drm/imagination: Use memdup_user() rather than duplicating its implementation

2024-01-28 Thread Markus Elfring
From: Markus Elfring Date: Sun, 28 Jan 2024 20:50:36 +0100 * Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Generated by: scripts/coccinelle/api/memdup_user.cocci * Delete labels and statements which became unnecessary with this refactoring.

Re: [PATCH next 10/11] block: Use a boolean expression instead of max() on booleans

2024-01-28 Thread Linus Torvalds
On Sun, 28 Jan 2024 at 11:36, David Laight wrote: > > However it generates: > error: comparison of constant ‘0’ with boolean expression is always true > [-Werror=bool-compare] > inside the signedness check that max() does unless a '+ 0' is added. Please fix your locale. You have random

[PATCH next 11/11] minmax: min() and max() don't need to return constant expressions

2024-01-28 Thread David Laight
After changing the handful of places max() was used to size an on-stack array to use max_const() it is no longer necessary for min() and max() to return constant expressions from constant inputs. Remove the associated logic to reduce the expanded text. Remove the 'hack' that allowed max(bool,

[PATCH next 10/11] block: Use a boolean expression instead of max() on booleans

2024-01-28 Thread David Laight
blk_stack_limits() contains: t->zoned = max(t->zoned, b->zoned); These are bool, so it is just a bitwise or. However it generates: error: comparison of constant ‘0’ with boolean expression is always true [-Werror=bool-compare] inside the signedness check that max() does unless a '+ 0'

[PATCH next 09/11] tree-wide: minmax: Replace all the uses of max() for array sizes with max_const()

2024-01-28 Thread David Laight
These are the only uses of max() that require a constant value from constant parameters. There don't seem to be any similar uses of min(). Replacing the max() by max_const() lets min()/max() be simplified speeding up compilation. max_const() will convert enums to int (or unsigned int) so that

[PATCH next 08/11 minmax: Add min_const() and max_const()

2024-01-28 Thread David Laight
The expansions of min() and max() contain statement expressions so are not valid for static intialisers. min_const() and max_const() are expressions so can be used for static initialisers. The arguments are checked for being constant and for negative signed values being converted to large unsigned

RE: [PATCH next 02/11] minmax: Use _Static_assert() instead of static_assert()

2024-01-28 Thread David Laight
The wrapper just adds two more lines of error output when the test fails. Signed-off-by: David Laight --- include/linux/minmax.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/minmax.h b/include/linux/minmax.h index 63c45865b48a..900eec7a28e5 100644

RE: [PATCH next 01/11] minmax: Put all the clamp() definitions together

2024-01-28 Thread David Laight
The defines for clamp() have got separated, move togther for readability. Update description of signedness check. Signed-off-by: David Laight --- include/linux/minmax.h | 120 +++-- 1 file changed, 56 insertions(+), 64 deletions(-) diff --git

[PATCH next 00/11] minmax: Optimise to reduce .i line length.

2024-01-28 Thread David Laight
The changes to minmax.h that changed the type check to a signedness check significantly increased the length of the expansion. In some cases it has also significantly increased compile type. This is particularly noticeable for nested expansions. The fact that _Static_assert() only requires a

RE: [PATCH next 00611] minmax: Remove 'constexpr' check from __careful_clamp()

2024-01-28 Thread David Laight
Nothing requires that clamp() return a constant expression. The logic to do so significantly increases the .i file. Remove the check and directly expand __clamp_once() from clamp_t() since the type check can't fail. Signed-off-by: David Laight --- include/linux/minmax.h | 14 +++--- 1

RE: [PATCH next 0711] minmax: minmax: Add __types_ok3() and optimise defines with 3 arguments

2024-01-28 Thread David Laight
min3() and max3() were added to optimise nested min(x, min(y, z)) sequences, bit only moved where the expansion was requiested. Add a separate implementation for 3 argument calls. These are never required to generate constant expressiions to remove that logic. Signed-off-by: David Laight ---

RE: [PATCH next 04/11] minmax: Replace multiple __UNIQUE_ID() by directly using __COUNTER__

2024-01-28 Thread David Laight
Provided __COUNTER__ is passed through an extra #define it can be pasted onto multiple local variables to give unique names. This saves having 3 __UNIQUE_ID() for #defines with three locals and look less messy in general. Stop the umin()/umax() lines being overlong by factoring out the

RE: [PATCH next 05/11] minmax: Move the signedness check out of __cmp_once() and __clamp_once()

2024-01-28 Thread David Laight
There is no need to do the signedness/type check when the arguments are being cast to a fixed type. So move the check out of __xxx_once() into __careful_xxx(). Signed-off-by: David Laight --- include/linux/minmax.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

RE: [PATCH next 03/11] minmax: Simplify signedness check

2024-01-28 Thread David Laight
It is enough to check that both 'x' and 'y' are valid for either a signed compare or an unsigned compare. For unsigned they must be an unsigned type or a positive constant. For signed they must be signed after unsigned char/short are promoted. The predicate for _Static_assert() only needs to be a

Re: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()

2024-01-28 Thread Uwe Kleine-König
Hello Sean, On Sun, Jan 28, 2024 at 03:49:04PM +, Sean Young wrote: > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename > pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user > in the tree. > > Signed-off-by: Sean Young The "problem" here is that

[PATCH AUTOSEL 4.19 8/8] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 5.10 12/13] drm/amd/powerplay: Fix kzalloc parameter 'ATOM_Tonga_PPM_Table' in 'get_platform_power_management_table()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 6616b5e1999146b1304abe78232af810080c67e3 ] In 'struct phm_ppm_table *ptr' allocation using kzalloc, an incorrect structure type is passed to sizeof() in kzalloc, larger structure types were used, thus using correct type 'struct phm_ppm_table' fixes

[PATCH AUTOSEL 5.4 11/11] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 5.15 19/19] drm/amdkfd: Fix 'node' NULL check in 'svm_range_get_range_boundaries()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit d7a254fad873775ce6c32b77796c81e81e6b7f2e ] Range interval [start, last] is ordered by rb_tree, rb_prev, rb_next return value still needs NULL check, thus modified from "node" to "rb_node". Fixes the below:

[PATCH AUTOSEL 5.10 13/13] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 5.15 18/19] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 5.15 17/19] drm/amd/powerplay: Fix kzalloc parameter 'ATOM_Tonga_PPM_Table' in 'get_platform_power_management_table()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 6616b5e1999146b1304abe78232af810080c67e3 ] In 'struct phm_ppm_table *ptr' allocation using kzalloc, an incorrect structure type is passed to sizeof() in kzalloc, larger structure types were used, thus using correct type 'struct phm_ppm_table' fixes

[PATCH AUTOSEL 5.15 13/19] drm/amdkfd: Fix lock dependency warning

2024-01-28 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 47bf0f83fc86df1bf42b385a91aadb910137c5c9 ] == WARNING: possible circular locking dependency detected 6.5.0-kfd-fkuehlin #276 Not tainted --

[PATCH AUTOSEL 6.1 26/27] drm/amdkfd: Fix 'node' NULL check in 'svm_range_get_range_boundaries()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit d7a254fad873775ce6c32b77796c81e81e6b7f2e ] Range interval [start, last] is ordered by rb_tree, rb_prev, rb_next return value still needs NULL check, thus modified from "node" to "rb_node". Fixes the below:

[PATCH AUTOSEL 6.1 25/27] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 6.1 24/27] drm/amdgpu: Fix with right return code '-EIO' in 'amdgpu_gmc_vram_checking()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit fac4ebd79fed60e79cccafdad45a2bb8d3795044 ] The amdgpu_gmc_vram_checking() function in emulation checks whether all of the memory range of shared system memory could be accessed by GPU, from this aspect, -EIO is returned for error scenarios. Fixes

[PATCH AUTOSEL 6.1 23/27] drm/amd/powerplay: Fix kzalloc parameter 'ATOM_Tonga_PPM_Table' in 'get_platform_power_management_table()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 6616b5e1999146b1304abe78232af810080c67e3 ] In 'struct phm_ppm_table *ptr' allocation using kzalloc, an incorrect structure type is passed to sizeof() in kzalloc, larger structure types were used, thus using correct type 'struct phm_ppm_table' fixes

[PATCH AUTOSEL 6.1 16/27] drm/amdkfd: Fix lock dependency warning

2024-01-28 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 47bf0f83fc86df1bf42b385a91aadb910137c5c9 ] == WARNING: possible circular locking dependency detected 6.5.0-kfd-fkuehlin #276 Not tainted --

[PATCH AUTOSEL 6.1 17/27] drm/amdkfd: Fix lock dependency warning with srcu

2024-01-28 Thread Sasha Levin
From: Philip Yang [ Upstream commit 2a9de42e8d3c82c6990d226198602be44f43f340 ] == WARNING: possible circular locking dependency detected 6.5.0-kfd-yangp #2289 Not tainted -- kworker/0:2/996

[PATCH AUTOSEL 6.6 30/31] drm/amdkfd: Fix 'node' NULL check in 'svm_range_get_range_boundaries()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit d7a254fad873775ce6c32b77796c81e81e6b7f2e ] Range interval [start, last] is ordered by rb_tree, rb_prev, rb_next return value still needs NULL check, thus modified from "node" to "rb_node". Fixes the below:

[PATCH AUTOSEL 6.6 29/31] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 6.6 26/31] drm/amdgpu: fix avg vs input power reporting on smu7

2024-01-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 25852d4b97572ff62ffee574cb8bb4bc551af23a ] Hawaii, Bonaire, Fiji, and Tonga support average power, the others support current power. Reviewed-by: Yang Wang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.6 28/31] drm/amdgpu: Fix with right return code '-EIO' in 'amdgpu_gmc_vram_checking()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit fac4ebd79fed60e79cccafdad45a2bb8d3795044 ] The amdgpu_gmc_vram_checking() function in emulation checks whether all of the memory range of shared system memory could be accessed by GPU, from this aspect, -EIO is returned for error scenarios. Fixes

[PATCH AUTOSEL 6.6 27/31] drm/amd/powerplay: Fix kzalloc parameter 'ATOM_Tonga_PPM_Table' in 'get_platform_power_management_table()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 6616b5e1999146b1304abe78232af810080c67e3 ] In 'struct phm_ppm_table *ptr' allocation using kzalloc, an incorrect structure type is passed to sizeof() in kzalloc, larger structure types were used, thus using correct type 'struct phm_ppm_table' fixes

[PATCH AUTOSEL 6.6 20/31] drm/amdkfd: Fix lock dependency warning with srcu

2024-01-28 Thread Sasha Levin
From: Philip Yang [ Upstream commit 2a9de42e8d3c82c6990d226198602be44f43f340 ] == WARNING: possible circular locking dependency detected 6.5.0-kfd-yangp #2289 Not tainted -- kworker/0:2/996

[PATCH AUTOSEL 6.6 19/31] drm/amdkfd: Fix lock dependency warning

2024-01-28 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 47bf0f83fc86df1bf42b385a91aadb910137c5c9 ] == WARNING: possible circular locking dependency detected 6.5.0-kfd-fkuehlin #276 Not tainted --

[PATCH AUTOSEL 6.7 37/39] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below:

[PATCH AUTOSEL 6.7 38/39] drm/amdkfd: Fix 'node' NULL check in 'svm_range_get_range_boundaries()'

2024-01-28 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit d7a254fad873775ce6c32b77796c81e81e6b7f2e ] Range interval [start, last] is ordered by rb_tree, rb_prev, rb_next return value still needs NULL check, thus modified from "node" to "rb_node". Fixes the below:

  1   2   >