Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-26 Thread Sui Jingfeng
Hi, On 2024/4/26 14:23, Maxime Ripard wrote: Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the

[PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free

2024-04-26 Thread R Sundar
use the new cleanup magic to replace of_node_put() with __free(device_node) marking to auto release when they get out of scope. Suggested-by: Julia Lawall Signed-off-by: R Sundar --- drivers/gpu/ipu-v3/ipu-pre.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[drm-misc:for-linux-next 1/1] drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1267:3: error: label at end of compound statement is a C23 extension

2024-04-26 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 61ba791c4a7a09a370c45b70a81b8c7d4cf6b2ae commit: b58a0bc904ffa091fc020f7fd00e91808fec820e [1/1] nouveau: add command-line GSP-RM registry support config: powerpc-allyesconfig

[drm-misc:for-linux-next 1/1] drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1267:3: warning: label at end of compound statement is a C23 extension

2024-04-26 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 61ba791c4a7a09a370c45b70a81b8c7d4cf6b2ae commit: b58a0bc904ffa091fc020f7fd00e91808fec820e [1/1] nouveau: add command-line GSP-RM registry support config: riscv-defconfig

RE: [PATCH v1 1/1] fbtft: seps525: Don't use "proxy" headers

2024-04-26 Thread Hennerich, Michael
> -Original Message- > From: Andy Shevchenko > Sent: Tuesday, April 23, 2024 1:36 PM > To: Andy Shevchenko ; linux- > fb...@vger.kernel.org; dri-devel@lists.freedesktop.org; linux- > stag...@lists.linux.dev; linux-ker...@vger.kernel.org > Cc: Hennerich, Michael ; Greg Kroah- > Hartman

[drm-misc:for-linux-next 1/1] drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1266:11: error: label at end of compound statement: expected statement

2024-04-26 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 61ba791c4a7a09a370c45b70a81b8c7d4cf6b2ae commit: b58a0bc904ffa091fc020f7fd00e91808fec820e [1/1] nouveau: add command-line GSP-RM registry support config: arm-defconfig

[drm-misc:for-linux-next 1/1] drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1117: warning: cannot understand function prototype: 'struct registry_list_entry '

2024-04-26 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 61ba791c4a7a09a370c45b70a81b8c7d4cf6b2ae commit: b58a0bc904ffa091fc020f7fd00e91808fec820e [1/1] nouveau: add command-line GSP-RM registry support config: parisc-defconfig

Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support

2024-04-26 Thread Mina Almasry
On Fri, Apr 26, 2024 at 5:18 PM David Wei wrote: > > On 2024-04-02 5:20 pm, Mina Almasry wrote: > > @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) > > */ > > typedef unsigned long __bitwise netmem_ref; > > > > +static inline bool netmem_is_net_iov(const netmem_ref netmem) > >

Re: [PATCH v2 3/8] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Dmitry Baryshkov
On Sat, 27 Apr 2024 at 02:59, Douglas Anderson wrote: > > Through a cooperative effort between Hsin-Yi Wang and Dmitry > Baryshkov, we have realized the dev_err_ratelimited() in the > mipi_dsi_*_write_seq() macros was causing quite a bit of bloat to the > kernel. Let's hoist this call into

Re: [PATCH v2 1/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-04-26 Thread Dmitry Baryshkov
On Sat, 27 Apr 2024 at 02:59, Douglas Anderson wrote: > > The mipi_dsi_dcs_write_seq() macro makes a call to > mipi_dsi_dcs_write_buffer() which returns a type ssize_t. The macro > then stores it in an int and checks to see if it's negative. This > could theoretically be a problem if "ssize_t" is

Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support

2024-04-26 Thread David Wei
On 2024-04-02 5:20 pm, Mina Almasry wrote: > @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) > */ > typedef unsigned long __bitwise netmem_ref; > > +static inline bool netmem_is_net_iov(const netmem_ref netmem) > +{ > +#if defined(CONFIG_PAGE_POOL) &&

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 8:28 AM Doug Anderson wrote: > > > I don't find this unintuitive, but if it helps, you could conceivably > > add a context parameter: > > > > struct mipi_dsi_seq_context context = { > > .dsi = dsi, > > }; > > > >

[PATCH v2 8/8] drm/panel: boe-tv101wum-nl6: Convert hex to lowercase

2024-04-26 Thread Douglas Anderson
Kernel convention is that we use 0xabcd, not 0xABCD. Convert the boe-tv101wum-nl6 driver to this convention. Signed-off-by: Douglas Anderson --- Changes in v2: - New .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 1912 - 1 file changed, 956 insertions(+), 956 deletions(-)

[PATCH v2 3/8] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Douglas Anderson
Through a cooperative effort between Hsin-Yi Wang and Dmitry Baryshkov, we have realized the dev_err_ratelimited() in the mipi_dsi_*_write_seq() macros was causing quite a bit of bloat to the kernel. Let's hoist this call into drm_mipi_dsi.c by adding a "chatty" version of the functions that

[PATCH v2 5/8] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

2024-04-26 Thread Douglas Anderson
We really don't expect these errors to be printed over and over again. When a driver hits the error it should bail out. Just use a normal error print. Signed-off-by: Douglas Anderson --- Changes in v2: - New drivers/gpu/drm/drm_mipi_dsi.c | 20 ++-- 1 file changed, 10

[PATCH v2 7/8] drm/panel: boe-tv101wum-nl6: Don't use a table for initting commands

2024-04-26 Thread Douglas Anderson
Consensus on the mailing lists is that panels shouldn't use a table of init commands but should instead use init functions. With the recently introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy but also saves space. Measuring before/after this change: $ scripts/bloat-o-meter \

[PATCH v2 6/8] drm/panel: novatek-nt36672e: Switch to mipi_dsi_dcs_write_seq_multi()

2024-04-26 Thread Douglas Anderson
This is a mechanical conversion of the novatek-nt36672e driver to use the new mipi_dsi_dcs_write_seq_multi(). The new function is easier for clients to understand and using it also causes smaller code to be generated. Specifically: $ scripts/bloat-o-meter \ ...after/panel-novatek-nt36672e.ko \

[PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-26 Thread Douglas Anderson
The current mipi_dsi_*_write_seq() macros are non-intutitive because they contain a hidden "return" statement that will return out of the _caller_ of the macro. Let's mark them as deprecated and instead introduce some new macros that are more intuitive. These new macros are less optimal when an

[PATCH v2 1/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-04-26 Thread Douglas Anderson
The mipi_dsi_dcs_write_seq() macro makes a call to mipi_dsi_dcs_write_buffer() which returns a type ssize_t. The macro then stores it in an int and checks to see if it's negative. This could theoretically be a problem if "ssize_t" is larger than "int". To see the issue, imagine that "ssize_t" is

[PATCH v2 2/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_generic_write_seq()

2024-04-26 Thread Douglas Anderson
The mipi_dsi_generic_write_seq() macro makes a call to mipi_dsi_generic_write() which returns a type ssize_t. The macro then stores it in an int and checks to see if it's negative. This could theoretically be a problem if "ssize_t" is larger than "int". To see the issue, imagine that "ssize_t" is

[PATCH v2 0/8] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-04-26 Thread Douglas Anderson
The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move to init functions that can use common DRM functions. The issue thus far has been that using the macros mipi_dsi_generic_write_seq() and mipi_dsi_dcs_write_seq()

[pull] amdgpu, amdkfd drm-next-6.10

2024-04-26 Thread Alex Deucher
Hi Dave, Sima, More new stuff for 6.10. The following changes since commit 0208ca55aa9c9b997da1f5bc45c4e98916323f08: Backmerge tag 'v6.9-rc5' into drm-next (2024-04-22 14:35:52 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v6 00/10] Make PCI's devres API more consistent

2024-04-26 Thread Bjorn Helgaas
On Fri, Apr 26, 2024 at 10:07:02AM +0200, Philipp Stanner wrote: > On Wed, 2024-04-24 at 15:12 -0500, Bjorn Helgaas wrote: > > On Mon, Apr 08, 2024 at 10:44:12AM +0200, Philipp Stanner wrote: > > > ... > > > PCI's devres API suffers several weaknesses: > > > > > > 1. There are functions prefixed

[linux-next:master] BUILD REGRESSION bb7a2467e6beef44a80a17d45ebf2931e7631083

2024-04-26 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: bb7a2467e6beef44a80a17d45ebf2931e7631083 Add linux-next specific files for 20240426 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404262217.dt4hoodh-...@intel.com Error

RE: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

2024-04-26 Thread Klymenko, Anatoliy
> -Original Message- > From: Tomi Valkeinen > Sent: Thursday, April 25, 2024 11:36 PM > To: Klymenko, Anatoliy > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org; > linux-ker...@vger.kernel.org; kernel test robot ; Laurent > Pinchart ; Maarten Lankhorst > ;

[PATCH v3 1/2] drm: xlnx: zynqmp_dpsub: Fix few function comments

2024-04-26 Thread Anatoliy Klymenko
Fix arguments description for zynqmp_disp_layer_find_live_format() and zynqmp_disp_layer_set_live_format(). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404260616.kfgdpcdn-...@intel.com/ Signed-off-by: Anatoliy Klymenko ---

[PATCH v3 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

2024-04-26 Thread Anatoliy Klymenko
Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats(). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4ozxvhd2-...@intel.com/ Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +- 1 file changed, 1

[PATCH v3 0/2] Fix Kernel CI issues

2024-04-26 Thread Anatoliy Klymenko
Fix number of CI reported W=1 build issues. Patch 1/2: Fix function arguments description. Closes: https://lore.kernel.org/oe-kbuild-all/202404260616.kfgdpcdn-...@intel.com/ Patch 2/2: Fix clang compilation error. Closes:

Re: [PATCH v2 3/6] drm/xe: Add helper to accumulate exec queue runtime

2024-04-26 Thread Umesh Nerlige Ramappa
On Fri, Apr 26, 2024 at 11:49:32AM +0100, Tvrtko Ursulin wrote: On 24/04/2024 00:56, Lucas De Marchi wrote: From: Umesh Nerlige Ramappa Add a helper to accumulate per-client runtime of all its exec queues. Currently that is done in 2 places: 1. when the exec_queue is destroyed

Re: [git pull] drm fixes for 6.8-rc6

2024-04-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Apr 2024 13:12:03 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/61ef6208e0df073072a764eb5c5f5a6db3ffadb6 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v3 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-26 Thread kernel test robot
Hi Animesh, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm/drm-next drm-exynos/exynos-drm-next next-20240426] [cannot apply to drm-intel/for-linux-next-fixes linus/master v6.9-rc5] [If your

[PATCH v4 12/16] ASoC: codecs: add MT6357 support

2024-04-26 Thread amergnat
From: Nicolas Belin Add the support of MT6357 PMIC audio codec. Signed-off-by: Nicolas Belin Signed-off-by: Alexandre Mergnat --- sound/soc/codecs/Kconfig |7 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/mt6357.c | 1898 +

[PATCH v4 09/16] ASoC: mediatek: mt8365: Add PCM DAI support

2024-04-26 Thread Alexandre Mergnat
Add Pulse Code Modulation Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-pcm.c | 293 + 1 file changed, 293 insertions(+) diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-pcm.c

[PATCH v4 13/16] ASoC: mediatek: Add MT8365 support

2024-04-26 Thread Alexandre Mergnat
- Add specific config to enable: - MT8365 sound support - MT6357 audio codec support - Add the mt8365 directory and all drivers under it. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/Kconfig | 20 sound/soc/mediatek/Makefile| 1 +

[PATCH v4 14/16] arm64: defconfig: enable mt8365 sound

2024-04-26 Thread Alexandre Mergnat
Enable the MediaTek MT8365-EVK sound support. The audio feature is handled by the MT8365 SoC and the MT6357 PMIC codec audio. Signed-off-by: Alexandre Mergnat --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig

[PATCH v4 15/16] arm64: dts: mediatek: add afe support for mt8365 SoC

2024-04-26 Thread Alexandre Mergnat
Add audio front end support of MT8365 SoC. Update the file header. Signed-off-by: Alexandre Mergnat --- arch/arm64/boot/dts/mediatek/mt8365.dtsi | 43 ++-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi

[PATCH v4 08/16] ASoC: mediatek: mt8365: Add DMIC DAI support

2024-04-26 Thread Alexandre Mergnat
Add Digital Micro Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-dmic.c | 347 1 file changed, 347 insertions(+) diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-dmic.c

[PATCH v4 11/16] ASoC: mediatek: mt8365: Add platform driver

2024-04-26 Thread Alexandre Mergnat
Add mt8365 platform driver. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-afe-pcm.c | 2275 1 file changed, 2275 insertions(+) diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c new file

[PATCH v4 16/16] arm64: dts: mediatek: add audio support for mt8365-evk

2024-04-26 Thread Alexandre Mergnat
Add the sound node which is linked to the MT8365 SoC AFE and the MT6357 audio codec. Update the file header. Signed-off-by: Alexandre Mergnat --- arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 89 + 1 file changed, 89 insertions(+) diff --git

[PATCH v4 10/16] ASoc: mediatek: mt8365: Add a specific soundcard for EVK

2024-04-26 Thread amergnat
From: Nicolas Belin Add a specific soundcard for mt8365-evk. It supports audio jack in/out, dmics, the amic and lineout. Signed-off-by: Nicolas Belin Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-mt6357.c | 348 ++ 1 file changed, 348

[PATCH v4 04/16] ASoC: mediatek: mt8365: Add common header

2024-04-26 Thread Alexandre Mergnat
Add header files for register definition and structure. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-afe-common.h | 491 + sound/soc/mediatek/mt8365/mt8365-reg.h| 991 ++ 2 files changed, 1482 insertions(+) diff --git

[PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control

2024-04-26 Thread Alexandre Mergnat
Add audio clock wrapper and audio tuner control. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-afe-clk.c | 443 + sound/soc/mediatek/mt8365/mt8365-afe-clk.h | 49 2 files changed, 492 insertions(+) diff --git

[PATCH v4 07/16] ASoC: mediatek: mt8365: Add ADDA DAI support

2024-04-26 Thread Alexandre Mergnat
Add ADDA Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-adda.c | 315 1 file changed, 315 insertions(+) diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-adda.c

[PATCH v4 06/16] ASoC: mediatek: mt8365: Add I2S DAI support

2024-04-26 Thread Alexandre Mergnat
Add I2S Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 854 + 1 file changed, 854 insertions(+) diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c

[PATCH v4 01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-04-26 Thread Alexandre Mergnat
Add MT8365 audio front-end bindings Signed-off-by: Alexandre Mergnat --- .../bindings/sound/mediatek,mt8365-afe.yaml| 130 + 1 file changed, 130 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8365-afe.yaml

[PATCH v4 02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document

2024-04-26 Thread Alexandre Mergnat
Add soundcard bindings for the MT8365 SoC with the MT6357 audio codec. Signed-off-by: Alexandre Mergnat --- .../bindings/sound/mediatek,mt8365-mt6357.yaml | 107 + 1 file changed, 107 insertions(+) diff --git

[PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-04-26 Thread Alexandre Mergnat
Add the audio codec sub-device. This sub-device is used to set required and optional voltage needed according to the hardware. The properties are: - phandle of the required power supply. - Setup of microphone bias voltage. - Setup of the speaker pin pull-down. Signed-off-by: Alexandre

[PATCH v4 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-04-26 Thread Alexandre Mergnat
This serie aim to add the following audio support for the Genio 350-evk: - Playback - 2ch Headset Jack (Earphone) - 1ch Line-out Jack (Speaker) - 8ch HDMI Tx - Capture - 1ch DMIC (On-board Digital Microphone) - 1ch AMIC (On-board Analogic Microphone) - 1ch Headset Jack (External

Re: [PATCH v3 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-04-26 Thread Conor Dooley
On Thu, Apr 25, 2024 at 02:03:24PM +0800, cong yang wrote: > Conor Dooley 于2024年4月25日周四 00:55写道: > > On Wed, Apr 24, 2024 at 10:30:04AM +0800, Cong Yang wrote: > > > +++ b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml > > > > Filename matching a compatible please. What

Re: [PATCH v2 00/28] sparc32: sunset sun4m and sun4d

2024-04-26 Thread Sam Ravnborg
Hi Andreas. On Fri, Apr 26, 2024 at 06:31:12PM +0200, Andreas Larsson wrote: > On 2024-04-23 20:02, Sam Ravnborg wrote: > > Please let me know if you expect me to rebase this on for-next. > > I have not yet tried if there are merge conflicts but can take a look in > > a some days if required. >

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-26 Thread Jason Gunthorpe
On Fri, Apr 26, 2024 at 04:49:26PM +0200, Thomas Hellström wrote: > On Fri, 2024-04-26 at 09:00 -0300, Jason Gunthorpe wrote: > > On Fri, Apr 26, 2024 at 11:55:05AM +0200, Thomas Hellström wrote: > > > First, the gpu_vma structure is something that partitions the > > > gpu_vm > > > that holds

Re: [PATCH v2 00/28] sparc32: sunset sun4m and sun4d

2024-04-26 Thread Andreas Larsson
On 2024-04-23 20:02, Sam Ravnborg wrote: > Please let me know if you expect me to rebase this on for-next. > I have not yet tried if there are merge conflicts but can take a look in > a some days if required. My local testing branch for this patchset rebased with trivial fixups, so no immediate

Re: [PATCH] drm/i915/gt: Disarm breadcrumbs if engines are already idle

2024-04-26 Thread Nirmoy Das
On 4/23/2024 6:23 PM, Janusz Krzysztofik wrote: From: Chris Wilson The breadcrumbs use a GT wakeref for guarding the interrupt, but are disarmed during release of the engine wakeref. This leaves a hole where we may attach a breadcrumb just as the engine is parking (after it has parked its

[PATCH 1/2] drm/meson: dw-hdmi: power up phy on device init

2024-04-26 Thread Jerome Brunet
The phy is not in a useful state right after init. It will become useful, including for auxiliary function such as CEC or ARC, after the first mode is set. This is a problem on systems where the display is using another interface like DSI or CVBS. This change refactor the init and mode change

[PATCH 2/2] drm/meson: dw-hdmi: add bandgap setting for g12

2024-04-26 Thread Jerome Brunet
When no mode is set, the utility pin appears to be grounded. No signal is getting through. This is problematic because ARC and eARC use this line and may do so even if no display mode is set. This change enable the bandgap setting on g12 chip, which fix the problem with the utility pin. This is

[PATCH 0/2] drm/meson: fix hdmi auxiliary system operation without display

2024-04-26 Thread Jerome Brunet
CEC and ARC should work even when HDMI is not actively used for the display but it is not the case with Amlogic HDMI. This is important for devices such as sound bars which may use DSI to display a UI and HDMI for CEC/ARC. A display is not required for these functions This patchset fixes the

Re: [PATCH] MAINTAINERS: Move the drm-intel repo location to fd.o GitLab

2024-04-26 Thread Tvrtko Ursulin
On 26/04/2024 16:47, Lucas De Marchi wrote: On Wed, Apr 24, 2024 at 01:41:59PM GMT, Ryszard Knop wrote: The drm-intel repo is moving from the classic fd.o git host to GitLab. Update its location with a URL matching other fd.o GitLab kernel trees. Signed-off-by: Ryszard Knop Acked-by:

Re: [PATCH 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor()

2024-04-26 Thread Timur Tabi
On Fri, 2024-04-26 at 11:41 -0400, Lyude Paul wrote: > We hit this because when initializing firmware of type > NVKM_FIRMWARE_IMG_DMA we allocate coherent memory and then attempt to > include that coherent memory in a scatterlist. I'm sure this patch is a good one, and I will try to test it

Re: [PATCH] MAINTAINERS: Move the drm-intel repo location to fd.o GitLab

2024-04-26 Thread Lucas De Marchi
On Wed, Apr 24, 2024 at 01:41:59PM GMT, Ryszard Knop wrote: The drm-intel repo is moving from the classic fd.o git host to GitLab. Update its location with a URL matching other fd.o GitLab kernel trees. Signed-off-by: Ryszard Knop Acked-by: Lucas De Marchi Also Cc'ing maintainers ---

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Dmitry Baryshkov
On Fri, 26 Apr 2024 at 18:41, Doug Anderson wrote: > > Hi, > > On Thu, Apr 25, 2024 at 8:03 PM Dmitry Baryshkov > wrote: > > > > On Thu, Apr 25, 2024 at 10:04:49AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula > > > wrote: > > > > > > > > > @@

[PATCH 2/2] drm/nouveau/gsp: Use the sg allocator for level 2 of radix3

2024-04-26 Thread Lyude Paul
Currently we allocate all 3 levels of radix3 page tables using nvkm_gsp_mem_ctor(), which uses dma_alloc_coherent() for allocating all of the relevant memory. This can end up failing in scenarios where the system has very high memory fragmentation, and we can't find enough contiguous memory to

[PATCH 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor()

2024-04-26 Thread Lyude Paul
Currently, enabling SG_DEBUG in the kernel will cause nouveau to hit a BUG() on startup: kernel BUG at include/linux/scatterlist.h:187! invalid opcode: [#1] PREEMPT SMP NOPTI CPU: 7 PID: 930 Comm: (udev-worker) Not tainted 6.9.0-rc3Lyude-Test+ #30 Hardware name: MSI MS-7A39/A320M

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Doug Anderson
Hi, On Thu, Apr 25, 2024 at 8:03 PM Dmitry Baryshkov wrote: > > On Thu, Apr 25, 2024 at 10:04:49AM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula > > wrote: > > > > > > > @@ -279,6 +281,8 @@ enum mipi_dsi_dcs_tear_mode { > > > > > > > > ssize_t

Re: (subset) [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-26 Thread Thierry Reding
On Fri Apr 26, 2024 at 5:32 PM CEST, Thierry Reding wrote: > From: Thierry Reding > > > On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote: > > Add support for Tegra Security Engine which can accelerates various > > crypto algorithms. The Engine has two separate instances within for > > AES and

Re: (subset) [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-26 Thread Thierry Reding
From: Thierry Reding On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote: > Add support for Tegra Security Engine which can accelerates various > crypto algorithms. The Engine has two separate instances within for > AES and HASH algorithms respectively. > > The driver registers two crypto

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 3:09 AM Jani Nikula wrote: > > > 2. Accept that a slightly less efficient handling of the error case > > and perhaps a less intuitive API, but avoid the goto. > > > > Essentially you could pass in "ret" and have the function be a no-op > > if an error is already

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-26 Thread Thomas Hellström
On Fri, 2024-04-26 at 09:00 -0300, Jason Gunthorpe wrote: > On Fri, Apr 26, 2024 at 11:55:05AM +0200, Thomas Hellström wrote: > > First, the gpu_vma structure is something that partitions the > > gpu_vm > > that holds gpu-related range metadata, like what to mirror, desired > > gpu > > caching

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-04-26 Thread Mario Limonciello
On 4/13/2024 03:51, Gergo Koteles wrote: Hi> ABM will reduce the backlight and compensate by adjusting brightness and contrast of the image. It has 5 levels: 0, 1, 2, 3, 4. 0 means off. 4 means maximum backlight reduction. IMO, 1 and 2 look okay. 3 and 4 can be quite impactful, both to

Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

2024-04-26 Thread Noralf Trønnes
On 4/24/24 08:45, Krzysztof Kozlowski wrote: > On 27/03/2024 18:48, Krzysztof Kozlowski wrote: >> Core in spi_register_driver() already sets the .owner, so driver >> does not need to. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/gpu/drm/tiny/ili9225.c | 1 - >> 1 file changed, 1

[PATCH v2] drm: move DRM-related CONFIG options into DRM submenu

2024-04-26 Thread Masahiro Yamada
rgmann --- Changes in v2: - Rebased onto next-20240426 drivers/gpu/drm/Kconfig | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 959b19a04101..7df15543a70a 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/g

Re: [PATCH][next] drm/xe: Fix spelling mistake "forcebly" -> "forcibly"

2024-04-26 Thread Lucas De Marchi
On Fri, 26 Apr 2024 10:49:04 +0100, Colin Ian King wrote: > There is a spelling mistake in a drm_dbg message. Fix it. > > Applied, thanks! [1/1] drm/xe: Fix spelling mistake "forcebly" -> "forcibly" (no commit info) Best regards, -- Lucas De Marchi

Re: [PATCH] drm/i915/gt: Automate CCS Mode setting during engine resets

2024-04-26 Thread Andi Shyti
Hi, On Fri, Apr 26, 2024 at 02:07:23AM +0200, Andi Shyti wrote: > We missed setting the CCS mode during resume and engine resets. > Create a workaround to be added in the engine's workaround list. > This workaround sets the XEHP_CCS_MODE value at every reset. > > The issue can be reproduced by

[PATCH RESEND] Revert "drm/bridge: ti-sn65dsi83: Fix enable error path"

2024-04-26 Thread Luca Ceresoli
This reverts commit 8a91b29f1f50ce7742cdbe5cf11d17f128511f3f. The regulator_disable() added by the original commit solves one kind of regulator imbalance but adds another one as it allows the regulator to be disabled one more time than it is enabled in the following scenario: 1. Start video

[PATCH] drm/fb_dma: Add checks in drm_fb_dma_get_scanout_buffer()

2024-04-26 Thread Jocelyn Falempe
plane->state and plane->state->fb can be NULL, so add a check before dereferencing them. Found by testing with the imx driver. Fixes: 879b3b6511fe9 ("drm/fb_dma: Add generic get_scanout_buffer() for drm_panic") Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 3 +++ 1

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-26 Thread Jason Gunthorpe
On Fri, Apr 26, 2024 at 11:55:05AM +0200, Thomas Hellström wrote: > First, the gpu_vma structure is something that partitions the gpu_vm > that holds gpu-related range metadata, like what to mirror, desired gpu > caching policies etc. These are managed (created, removed and split) > mainly from

Re: [PATCH] drm/panthor: Kill the faulty_slots variable in panthor_sched_suspend()

2024-04-26 Thread Liviu Dudau
On Thu, Apr 25, 2024 at 12:39:20PM +0200, Boris Brezillon wrote: > We can use upd_ctx.timedout_mask directly, and the faulty_slots update > in the flush_caches_failed situation is never used. > > Suggested-by: Suggested-by: Steven Price > Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau

Re: [PATCH v2 3/6] drm/xe: Add helper to accumulate exec queue runtime

2024-04-26 Thread Tvrtko Ursulin
On 24/04/2024 00:56, Lucas De Marchi wrote: From: Umesh Nerlige Ramappa Add a helper to accumulate per-client runtime of all its exec queues. Currently that is done in 2 places: 1. when the exec_queue is destroyed 2. when the sched job is completed Signed-off-by: Umesh

Re: [PATCH v2 6/6] drm/xe/client: Print runtime to fdinfo

2024-04-26 Thread Tvrtko Ursulin
On 24/04/2024 00:56, Lucas De Marchi wrote: Print the accumulated runtime for client when printing fdinfo. Each time a query is done it first does 2 things: 1) loop through all the exec queues for the current client and accumulate the runtime, per engine class. CTX_TIMESTAMP is used for

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-26 Thread Sui Jingfeng
Hi, On 2024/4/26 14:23, Maxime Ripard wrote: Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Jani Nikula
On Thu, 25 Apr 2024, Doug Anderson wrote: > Hi, > > On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula > wrote: >> >> > @@ -279,6 +281,8 @@ enum mipi_dsi_dcs_tear_mode { >> > >> > ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi, >> > const void *data,

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-26 Thread Thomas Hellström
Hi, Jason. I've quickly read through the discussion here and have a couple of questions and clarifications to hopefully help moving forward on aligning on an approach for this. Let's for simplicity initially ignore migration and assume this is on integrated hardware since it seems like it's

[PATCH][next] drm/xe: Fix spelling mistake "forcebly" -> "forcibly"

2024-04-26 Thread Colin Ian King
There is a spelling mistake in a drm_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/xe/xe_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index bb4fbae5edb6..b61f8356e23e 100644

Re: [PATCH] drm: zynqmp_dpsub: Always register bridge

2024-04-26 Thread Laurent Pinchart
On Fri, Mar 22, 2024 at 08:01:44AM +0200, Tomi Valkeinen wrote: > On 08/03/2024 22:47, Sean Anderson wrote: > > We must always register the DRM bridge, since zynqmp_dp_hpd_work_func > > calls drm_bridge_hpd_notify, which in turn expects hpd_mutex to be > > initialized. We do this before

Re: [PATCH] drm: xlnx: zynqmp_dpsub: Fix missing drm_bridge_add() call

2024-04-26 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Mar 12, 2024 at 10:51:15AM +0200, Tomi Valkeinen wrote: > The driver creates a bridge, but never calls drm_bridge_add() when > non-live input is used. This leaves the bridge's hpd_mutex > uninitialized, leading to: > > WARNING: CPU: 0 PID: 9 at

Re: [PATCH 2/2] drm/print: drop include seq_file.h

2024-04-26 Thread Jani Nikula
On Fri, 26 Apr 2024, Noralf Trønnes wrote: > I used the defconfigs from drm-tip:rerere-cache which caught this. Odd. This is what my configs are based on too. I can only assume a 'make olddefconfig' down the line has defaulted something to n at some point. BR, Jani. -- Jani Nikula, Intel

Re: [PATCH 2/2] drm/print: drop include seq_file.h

2024-04-26 Thread Noralf Trønnes
On 4/26/24 09:28, Jani Nikula wrote: > On Thu, 25 Apr 2024, Noralf Trønnes wrote: >> On 4/22/24 14:10, Jani Nikula wrote: >>> Never include where a forward declaration will suffice. >>> >>> Reviewed-by: Andrzej Hajda >>> Acked-by: Maxime Ripard >>> Link: >>>

Re: [PATCH] drm/vmwgfx: Fix invalid reads in fence signaled events

2024-04-26 Thread Martin Krastev
LGTM! Reviewed-by: Martin Krastev Regards, Martin On Thu, Apr 25, 2024 at 10:27 PM Zack Rusin wrote: > > Correctly set the length of the drm_event to the size of the structure > that's actually used. > > The length of the drm_event was set to the parent structure instead of > to the

Re: [PATCH] drm/vmwgfx: Fix Legacy Display Unit

2024-04-26 Thread Martin Krastev
Good catch! Reviewed-by: Martin Krastev Regards, Martin On Thu, Apr 25, 2024 at 11:07 PM Ian Forbes wrote: > > Legacy DU was broken by the referenced fixes commit because the placement > and the busy_placement no longer pointed to the same object. This was later > fixed indirectly by commit

Re: [PATCH v6 00/10] Make PCI's devres API more consistent

2024-04-26 Thread Philipp Stanner
On Wed, 2024-04-24 at 15:12 -0500, Bjorn Helgaas wrote: > On Mon, Apr 08, 2024 at 10:44:12AM +0200, Philipp Stanner wrote: > > ... > > PCI's devres API suffers several weaknesses: > > > > 1. There are functions prefixed with pcim_. Those are always > > managed > >    counterparts to never-managed

Re: [PATCH v3 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-04-26 Thread kernel test robot
://download.01.org/0day-ci/archive/20240426/202404261542.p0fckhhm-...@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240426/202404261542.p0fckhhm-...@intel.com/reproduce) If you fix the issue in a separate

Re: [PATCH v6 04/10] PCI: Make devres region requests consistent

2024-04-26 Thread Philipp Stanner
On Wed, 2024-04-24 at 15:12 -0500, Bjorn Helgaas wrote: > On Mon, Apr 08, 2024 at 10:44:16AM +0200, Philipp Stanner wrote: > > Now that pure managed region request functions are available, the > > implementation of the hybrid-functions which are only sometimes > > managed > > can be made more

Re: [PATCH 2/2] drm/print: drop include seq_file.h

2024-04-26 Thread Jani Nikula
On Thu, 25 Apr 2024, Noralf Trønnes wrote: > On 4/22/24 14:10, Jani Nikula wrote: >> Never include where a forward declaration will suffice. >> >> Reviewed-by: Andrzej Hajda >> Acked-by: Maxime Ripard >> Link: >>

[PULL] drm-intel-gt-next

2024-04-26 Thread Joonas Lahtinen
Hi Dave & Sima, Here's the drm-intel-gt-next PR for v6.10 in one shot. We are adding a new uAPI for Mesa to request higher GT frequency for compute contexts on GuC platform. Then there is a W/A for DG2 to move to fixed CCS load balancing and make all DG2 SKUs appear with single CCS with all the

Re: [RFC 5/7] drm/virtio: Ensure that bo's backing store is valid while updating plane

2024-04-26 Thread Weifeng Liu
On Thu, 2024-03-28 at 01:32 -0700, Vivek Kasireddy wrote: > To make sure that the imported bo's backing store is valid, we first > pin the associated dmabuf, import the sgt if need be and then unpin > it after the update is complete. Note that we pin/unpin the dmabuf > even when the backing store

Re: [PATCH] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-04-26 Thread Sebastian Andrzej Siewior
On 2024-04-04 12:25:36 [+0200], To dri-devel@lists.freedesktop.org wrote: > PREEMPT_RT has a different locking implementation for ww_mutex. The > base mutex of struct ww_mutex is declared as struct WW_MUTEX_BASE. The > latter is defined as `mutex' for non-PREEMPT_RT builds and `rt_mutex' > for

Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

2024-04-26 Thread Tomi Valkeinen
On 26/04/2024 04:46, Anatoliy Klymenko wrote: Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats(). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4ozxvhd2-...@intel.com/ --- This is missing your signed-off-by. Tomi

Re: [RFC PATCH 02/18] drm/ttm: Add per-BO eviction tracking

2024-04-26 Thread Christian König
Am 25.04.24 um 21:02 schrieb Matthew Brost: On Thu, Apr 25, 2024 at 08:18:38AM +0200, Christian König wrote: Am 24.04.24 um 18:56 schrieb Friedrich Vock: Make each buffer object aware of whether it has been evicted or not. That reverts some changes we made a couple of years ago. In general

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-26 Thread Maxime Ripard
Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > On 2024/4/26 03:10, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > > > On 2024/4/25 22:26, Andy Shevchenko wrote: > > > > It seems driver missed the point of proper use of device

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-26 Thread Tomeu Vizoso
On Thu, Apr 25, 2024 at 8:59 PM Jeffrey Hugo wrote: > > On 4/24/2024 12:37 AM, Tomeu Vizoso wrote: > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > rendering, which of course won't work. > > > >