[PATCH] drm: Wrap direct calls to driver->gem_free_object from CMA

Verified working on rpi2. Tested-by: Robert Foss On 2016-05-31 05:25 PM, Chris Wilson wrote: > Since the introduction of (struct_mutex) lockless GEM bo freeing, there > are a pair of driver vfuncs for freeing the GEM bo, of which the driver > may choose to only impleme

[PATCH v8 0/3] drm: add explict fencing

I tested this series on the db410c platform and I've seen no regressions from previous versions of this series. Tested-by: Robert Foss

[PATCH v10 3/3] drm/fence: add out-fences support

Tested on db410c running android + drm_hwcomposer, confirmed to be working. Tested-by: Robert Foss

[Intel-gfx] [PATCH 02/12] tests/kms_atomic_transition: don't assume max pipes

On Tue, 2016-11-15 at 14:25 +0100, Tomeu Vizoso wrote: > On 15 November 2016 at 09:01, Daniel Vetter wrote: > > > > On Mon, Nov 14, 2016 at 06:59:16PM +0900, Gustavo Padovan wrote: > > > > > > From: Gustavo Padovan > > > > > > Signed-off-by: Gustavo Padovan > > > --- > > >  

[PATCH v13 0/3] New debugfs API for capturing CRC of frames

Hey Tomeu, This series looks good to me, I'm not seeing anything out of order. Rob. On 2016-12-14 08:34 AM, Tomeu Vizoso wrote: > Hi, > > here are the patches that remain to be merged in this series. > > I have only rebased them since last time. > > Thanks, > > Tomeu > > > Tomeu Vizoso (3): >

[PATCH] drm/vc4: Return -EBUSY if there's already a pending flip event.

On 05/02/2016 08:57 PM, Eric Anholt wrote: > robert.foss at collabora.com writes: > >> From: Robert Foss >> >> As per the docs, atomic_commit should return -EBUSY "if an asycnhronous >> update is requested and there is an earlier update pending".

[PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.

On 2016-05-03 03:22 PM, Eric Anholt wrote: > robert.foss at collabora.com writes: > >> From: Robert Foss >> >> As per the documentation in drm_crtc.h, atomic_commit should return >> -EBUSY if an asycnhronous update is requested and there is an earlier >> up

[PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.

Thanks Eric! On 2016-05-10 01:06 PM, Eric Anholt wrote: > Robert Foss writes: > >> On 2016-05-03 03:22 PM, Eric Anholt wrote: >>> robert.foss at collabora.com writes: >>> >>>> From: Robert Foss >>>> >>>> As per the do

[PATCH libdrm] Header: Add rotation property fields

From: Sean Paul <seanp...@chromium.org> From drm_crtc.h, for use with the plane "rotation" property. Signed-off-by: Sean Paul <seanp...@chromium.org> Signed-off-by: Robert Foss <robert.f...@collabora.com> --- include/drm/drm.h | 8 1 file changed, 8 inserti

[PATCH libdrm v2] Header: Add rotation property fields

From: Sean Paul <seanp...@chromium.org> From drm_crtc.h, for use with the plane "rotation" property. Signed-off-by: Sean Paul <seanp...@chromium.org> Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org>

[PATCH v1] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

these defines are provided purely as a convenience to userspace applications. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drivers/gpu/drm/drm_rect.c | 1 + include/drm/drm_blend.h| 18 include/uapi/drm/drm.h

Re: [PATCH v1] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

On 2017-05-15 09:23 AM, Emil Velikov wrote: Hi Rob, On 14 May 2017 at 18:26, Robert Foss <robert.f...@collabora.com> wrote: Add DRM_ROTATE_ and DRM_REFLECT_ defines to the UAPI as a convenience. Ideally the DRM_ROTATE_ and DRM_REFLECT_ property ids are looked up through the atom

[PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

. As a result these defines are provided purely as a convenience to userspace applications. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- Changes since v2: - Changed define prefix from DRM_MODE_PROP_ to DRM_MODE_ - Fix compilation errors - Changed comment formatting - Dedupl

[PATCH v2] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

these defines are provided purely as a convenience to userspace applications. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- Changes since v1: - Moved defines from drm.h to drm_mode.h - Changed define prefix from DRM_ to DRM_MODE_PROP_ - Updated uses of the defines to the new

Re: [PATCH v1] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

On 2017-05-16 06:58 AM, Emil Velikov wrote: On 15 May 2017 at 18:13, Robert Foss <robert.f...@collabora.com> wrote: On 2017-05-15 09:23 AM, Emil Velikov wrote: Hi Rob, On 14 May 2017 at 18:26, Robert Foss <robert.f...@collabora.com> wrote: Add DRM_ROTATE_ and DRM_REFL

Re: [PATCH v2] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

Hey Ville, On 2017-05-16 12:20 PM, Ville Syrjälä wrote: On Tue, May 16, 2017 at 11:55:00AM -0400, Robert Foss wrote: Add DRM_ROTATE_ and DRM_REFLECT_ defines to the UAPI as a convenience. I just noticed this line using the wrong define names. Will fix in v3. Ideally the DRM_ROTATE_

Re: [RFC 7/7] drm/vc4: update cursors asynchronously through atomic

Hey, I ran the series on a RPi2 and the cursor seems to behave correctly. Tested-by: Robert Foss <robert.f...@collabora.com> On 2017-04-09 08:24 PM, Gustavo Padovan wrote: From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using th

Re: [RFC 7/7] drm/vc4: update cursors asynchronously through atomic

Sorry about the spam, but the previous reply was intended for [RFC v3 7/8] drm/vc4: update cursors asynchronously through atomic On 2017-05-18 06:52 PM, Robert Foss wrote: Hey, I ran the series on a RPi2 and the cursor seems to behave correctly. Tested-by: Robert Foss <rober

Re: [RFC v3 7/8] drm/vc4: update cursors asynchronously through atomic

Hey, I just tested this patch on a RPi2, and the cursor behaves correctly with no unexpected errors. Tested-by: Robert Foss <robert.f...@collabora.com> On 2017-05-12 03:10 PM, Gustavo Padovan wrote: From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to a

[PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

. As a result these defines are provided purely as a convenience to userspace applications. Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Sinclair Yeh <s...@vmware.com> Acked-by: Liviu Dudau <liviu.du...

[PATCH v4 1/2] drm/blend: Fix comment typ-o

Fix DRM_REFELCT_Y -> DRM_REFLECT_Y. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drivers/gpu/drm/drm_blend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index a0d0d6843288..dee67ef6c6

Re: [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

On 2017-05-18 05:49 AM, Ville Syrjälä wrote: On Wed, May 17, 2017 at 09:39:11PM -0400, Robert Foss wrote: +/* + * DRM_MODE_REFLECT_ + * + * Signals that the contents of a drm plane has been reflected in + * the axis. Still vague. Ack, I'll add some verbiage. Also you didn't respond

Re: [hwc PATCH] drm_hwcomposer: Remove OWNERS

Pushed. On Thu, 2017-09-21 at 14:55 -0700, Zach Reizner wrote: > On Thu, Sep 21, 2017 at 2:49 PM, Robert Foss <robert.foss@collabora.c > om> wrote: > > Hey Sean, > > > > Wonderful! > > > > Feel free to add my r-b. > > > > Reviewed-by: R

drm_hwcomposer moving to fd.o

tive implementation. Regarding contributions, they are accepted on the dri-devel list, using the patch prefix "hwc". Currently Sean Paul, Zach Reizner, Rob Clark, Rob Herring and Robert Foss have commit access. This is just the initial set, any contributor with a few commits under their b

Re: [hwc PATCH] drm_hwcomposer: Remove OWNERS

Hey Sean, Wonderful! Feel free to add my r-b. Reviewed-by: Robert Foss <robert.f...@collabora.com> On Thu, 2017-09-21 at 14:46 -0700, Sean Paul wrote: > Where we're going, we don't need no stickin' OWNERS. > > Now that drm_hwcomposer is hosted on fdo, we're going to s

[PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

Some basic guidelines for contributions could come in handy. These are copied from IGT and modified to be suitable. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- CONTRIBUTING | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 CONTRI

Re: drm_hwcomposer moving to fd.o

Hey Jani, On Fri, 2017-09-22 at 14:21 +0300, Jani Nikula wrote: > On Fri, 22 Sep 2017, Robert Foss <robert.f...@collabora.com> wrote: > > After talking to Liviu Dudau at LPC and Sean Paul & Kaveh Nasri at > > XDC > > it seems that we all could benefi

Re: drm_hwcomposer moving to fd.o

Hey Chih-Wei, On Fri, 2017-09-22 at 10:40 +0800, Chih-Wei Huang wrote: > Great news! > Thanks a lot to make it happen. > > I hope I am wrong. > From my understanding most x86 GPUs still > cannot work with drm_hwcomposer since > they lack of atomic mode-setting API support > required by

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

Pushed! On Fri, 2017-09-22 at 09:23 -0700, Sean Paul wrote: > On Fri, Sep 22, 2017 at 02:37:18AM +0200, Robert Foss wrote: > > Some basic guidelines for contributions could come in handy. > > > > These are copied from IGT and modified to be suitable. > > > > Sig

Re: [PATCH hwc] drm_hwcomposer: remove NVIDIA importer

Hey Thierry, On Mon, 2017-10-09 at 15:07 +0200, Thierry Reding wrote: > On Fri, Oct 06, 2017 at 05:02:03PM -0500, Rob Herring wrote: > > There's no opensource implementation for the NVIDIA gralloc > > implementation, > > so remove it as it is not testable. > > > > As all of the gralloc perform()

Re: [PATCH hwc] drm_hwcomposer: use upstream DRM_MODE_{ROTATE, REFLECT} defines

Hey Thierry, On Sat, 2017-10-07 at 01:29 +0200, Thierry Reding wrote: > On Fri, Oct 06, 2017 at 04:46:48PM -0500, Rob Herring wrote: > > The DRM_REFLECT_* and DRM_ROTATE_* defines were not upstream, but > > now > > they are. Convert to using the upstream version which are defined > > as a > > bit

Re: [PATCH hwc] drm_hwcomposer: remove NVIDIA importer

Hey again, Just pushed this patch. Rob. On Mon, 2017-10-09 at 15:58 +0200, Robert Foss wrote: > Hey Thierry, > > On Mon, 2017-10-09 at 15:07 +0200, Thierry Reding wrote: > > On Fri, Oct 06, 2017 at 05:02:03PM -0500, Rob Herring wrote: > > > There's no opensource imple

Re: [PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

On Wed, 2017-09-27 at 15:12 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss <robert.foss@collabora.c > om> wrote: > > This GetCrtrcCount helper functions enables convenient > > fetching of the number of Crtcs from DrmResources. > > > >

Re: [PATCH hwc v2 6/6] drm_hwcomposer: Add out-fence support

On Wed, 2017-09-27 at 15:11 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss <robert.foss@collabora.c > om> wrote: > > Add support for out-fences through the OUT_FENCE_PTR property. > > Out-fences signal when their associated buffer may

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

On Wed, 2017-09-27 at 15:14 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss <robert.foss@collabora.c > om> wrote: > > From: Sean Paul <seanp...@chromium.org> > > > > Since HWC2 doesn't require the use of threads to implement corr

[PATCH hwc v3 6/6] drm_hwcomposer: Remove threading

From: Sean Paul <seanp...@chromium.org> Since HWC2 doesn't require the use of threads to implement correct synchronization, remove some of these threads. Signed-off-by: Sean Paul <seanp...@chromium.org> Signed-off-by: Robert Foss <robert.f...@collabora.com> --- Changes since v

[PATCH hwc v3 1/6] drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane

Add support for the IN_FENCE_FD property to DrmPlane. Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes since v2: Sean Paul: - Added r-b drmplane.cpp | 8 drmplane.h | 2 ++ 2 files changed, 10 inserti

[PATCH hwc v3 0/6] Implement fencing

This series removes the old thread-based synchronization utilities and replaces them with fences. It has been tested on various platforms, including etnaviv/freedreno/virgl. Robert Foss (5): drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane drm_hwcomposer: Submit in-fence

[PATCH hwc v3 5/6] drm_hwcomposer: Add out-fence support

Add support for out-fences through the OUT_FENCE_PTR property. Out-fences signal when their associated buffer may be read by a device. Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes since v2: Sean Paul: -

[PATCH hwc v3 4/6] drm_hwcomposer: Add crtc() fetcher to DrmResources

This is a fetcher for getting the vector of DrmCrtc objects in DrmResources. Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes since v2: Sean Paul: - Replaced GetCrtcCount() with crtr() - Added r-b drmresou

[PATCH hwc v3 2/6] drm_hwcomposer: Submit in-fence to DRM

Add support for in-fences through the IN_FENCE_FD property. In-fences signal when their associated buffer may be read by DRM/KMS. Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- drmdisplaycomposi

[PATCH hwc v3 3/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

Add support for handling the FENCE_OUT_PTR property to DrmCrtc Signed-off-by: Robert Foss <robert.f...@collabora.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes since v2: Sean Paul: - Added r-b drmcrtc.cpp | 10 ++ drmcrtc.h | 2 ++ 2 files

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

Hey Emil, On Wed, 2017-09-27 at 14:34 +0100, Emil Velikov wrote: > On 27 September 2017 at 12:58, Robert Foss <robert.f...@collabora.com > > wrote: > > >  16 files changed, 93 insertions(+), 724 deletions(-) > > Holly smokes, that's some amazing stat. > P

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

On Fri, 2017-09-29 at 13:49 +0800, Chih-Wei Huang wrote: > 2017-09-29 5:29 GMT+08:00 Rob Herring <r...@kernel.org>: > > On Thu, Sep 28, 2017 at 11:43 AM, Chih-Wei Huang > > <cwhu...@android-x86.org> wrote: > > > 2017-09-27 19:58 GMT+08:00 Ro

Re: [PATCH hwc v3 0/6] Implement fencing

Series pushed. On Thu, 2017-09-28 at 18:40 +0200, Robert Foss wrote: > This series removes the old thread-based synchronization utilities > and > replaces them with fences. > > It has been tested on various platforms, including > etnaviv/freedreno/virgl. > > Robert Foss

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

On Fri, 2017-09-29 at 17:07 +0800, Chih-Wei Huang wrote: > 2017-09-29 16:44 GMT+08:00 Robert Foss <robert.f...@collabora.com>: > > On Fri, 2017-09-29 at 13:49 +0800, Chih-Wei Huang wrote: > > > 2017-09-29 5:29 GMT+08:00 Rob Herring <r...@kernel.org>: > > >

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

Hey Emil, On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: > Hi Rob, > > Glad to see this. There's a couple of suggestions that I hope you'll > find worth while. > > On 22 September 2017 at 01:37, Robert Foss <robert.f...@collabora.com > > wrote

Re: [PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

Hey Sean, On Wed, 2017-09-27 at 14:55 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss <robert.foss@collabora.c > om> wrote: > > Add support for in-fences through the IN_FENCE_FD property. In- > > fences signal > > when their associated

[PATCH hwc v1 1/6] drm_hwcomposer: Remove threading

From: Sean Paul <seanp...@chromium.org> Since HWC2 doesn't require the use of threads to implement correct synchronization, remove some of these threads. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- Android.mk| 3 - drmcomposition.cpp

[PATCH hwc v1 5/6] drm_hwcomposer: Add GetCrtcCount function

This GetCrtrcCount helper functions enables convenient fetching of the number of Crtcs from DrmResources. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmresources.cpp | 4 drmresources.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drmresources

[PATCH hwc v1 0/6] Implement fencing

This series removes the old thread-based synchronization utilities and replaces them with fences. It has been tested on various platforms, including etnaviv/freedreno/virgl. Robert Foss (5): drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane drm_hwcomposer: Submit in-fence

[PATCH hwc v1 6/6] drm_hwcomposer: Add out-fence support

Add support for out-fences through the OUT_FENCE_PTR property. Out-fences signal when their associated buffer may be read by a device. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmdisplaycomposition.h | 9 + drmdisplaycompositor.cpp | 16 drmhwct

[PATCH hwc v1 3/6] drm_hwcomposer: Submit in-fence to DRM

Add support for in-fences through the IN_FENCE_FD property. In-fences signal when their associated buffer may be read by DRM/KMS. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmdisplaycompositor.cpp | 35 --- 1 file changed, 16 insertions(

[PATCH hwc v1 4/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

Add support for handling the FENCE_OUT_PTR property to DrmCrtc Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmcrtc.cpp | 10 ++ drmcrtc.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drmcrtc.cpp b/drmcrtc.cpp index 1fbdc12..c139869 100644 --- a/drmcr

[PATCH hwc v1 2/6] drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane

Add support for the IN_FENCE_FD property to DrmPlane. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmplane.cpp | 8 drmplane.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drmplane.cpp b/drmplane.cpp index c4ea722..1f739ae 100644 --- a/drmplane.cpp

[PATCH hwc v2 4/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

Add support for handling the FENCE_OUT_PTR property to DrmCrtc Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmcrtc.cpp | 10 ++ drmcrtc.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drmcrtc.cpp b/drmcrtc.cpp index 1fbdc12..c139869 100644 --- a/drmcr

[PATCH hwc v2 6/6] drm_hwcomposer: Add out-fence support

Add support for out-fences through the OUT_FENCE_PTR property. Out-fences signal when their associated buffer may be read by a device. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- Changes since v1: Sergi Granell - Set atomic property to be out_fences[crtc

[PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

This GetCrtrcCount helper functions enables convenient fetching of the number of Crtcs from DrmResources. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmresources.cpp | 4 drmresources.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drmresources

[PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

Add support for in-fences through the IN_FENCE_FD property. In-fences signal when their associated buffer may be read by DRM/KMS. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmdisplaycompositor.cpp | 35 --- 1 file changed, 16 insertions(

[PATCH hwc v2 0/6] Implement fencing

This series removes the old thread-based synchronization utilities and replaces them with fences. It has been tested on various platforms, including etnaviv/freedreno/virgl. Robert Foss (5): drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane drm_hwcomposer: Submit in-fence

[PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

From: Sean Paul <seanp...@chromium.org> Since HWC2 doesn't require the use of threads to implement correct synchronization, remove some of these threads. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- Android.mk| 3 - drmcomposition.cpp

[PATCH hwc v2 2/6] drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane

Add support for the IN_FENCE_FD property to DrmPlane. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- drmplane.cpp | 8 drmplane.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drmplane.cpp b/drmplane.cpp index c4ea722..1f739ae 100644 --- a/drmplane.cpp

Re: [PATCH libdrm] headers: sync DRM_MODE_ROTATE/REFLECT defines from kernel v4.14-rc1

Hey Rob, This looks good to me, feel free to add my r-b. Rob. On Fri, 2017-10-06 at 16:31 -0500, Rob Herring wrote: > Add the new DRM_MODE_ROTATE_* and DRM_MODE_REFLECT_* defines from > v4.14-rc1 > kernel. > > Signed-off-by: Rob Herring > --- >  include/drm/drm_mode.h | 47 >

Re: [PATCH hwc] drm_hwcomposer: use upstream DRM_MODE_{ROTATE,REFLECT} defines

Hey Rob, This looks good to me, added r-b and pushed. Rob. On Fri, 2017-10-06 at 16:46 -0500, Rob Herring wrote: > The DRM_REFLECT_* and DRM_ROTATE_* defines were not upstream, but now > they are. Convert to using the upstream version which are defined as > a > bit mask rather than a bit

Re: [PATCH hwc] drm_hwcomposer: remove NVIDIA importer

Hey Rob, +Thierry This looks good to me, does anyone have a strong opinion the other way? I'll let this one soak for a day or two more. Rob. On Fri, 2017-10-06 at 17:02 -0500, Rob Herring wrote: > There's no opensource implementation for the NVIDIA gralloc > implementation, > so remove it as

Re: [PATCH hwc] platformdrmgeneric: get the gralloc usage directly from the handle

Hey Rob, I tested the patch on the imx6/etnaviv platform, and it all works. So I pushed the patch with t-b && r-b tags attached. Rob. On Fri, 2017-10-06 at 17:20 -0500, Rob Herring wrote: > There's no point in using a gralloc perform() op to retrieve the > usage as > it is already stored in

Re: [PATCH hwc] drm_hwcomposer: make sure primary plane is allocated for squash

Hey Adrian, This looks good to me. Pushed! Sorry about the late reply, I was under the weather for a bit. Would you be interested in commit rights to this project? Rob. On Mon, 2017-10-02 at 11:31 -0700, Adrian Salido wrote: > There are instances where the primary plane may have been

Re: [PATCH hwc] drm_hwcomposer: fix warnings on unused variables and parameters

Hey Rob, I applied and tested this patch, and it looks good to me. Feel free to add my SB/TB. Rob. On Wed, 2017-11-29 at 10:21 -0600, Rob Herring wrote: > AOSP master now builds by default with -Werror, so fix all the > warnings. > All the warnings are related to unused variables and

Re: Android i.mx6 drm_hwcomposer

t; already > opened the device. > > Adding a patch similar to: > > commit 4f4cb902517f5caacea075fb9724e4ce0c435e3d > Author: Robert Foss <robert.f...@collabora.com> > Date: Wed May 17 18:08:14 2017 -0400 > > drm_hwcomposer: Get KMS FD from gbm_gralloc > &

Re: [PATCH hwc] Android: add CleanSpec.mk

Hey Rob, On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote: > On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang org> wrote: > > The file contains rules that are executed on incremental builds. > > Since commit 4f7dc9b6 the library was moved to /vendor so > > the old file

Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

Hi Rob, On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring wrote: > > If the rotation property is supported for a plane, then the > > rotation > > value must be non-zero. For the case of 0 degree rotation, > > DRM_MODE_ROTATE_0

Re: [PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type

Hi Rob, Pushed to master. Rob. On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > From: Robert Foss <robert.f...@collabora.com> > > Accept DRM_MODE_CONNECTOR_HDMIA connector type. > > Look for primary DrmConnector amongst external connectors > after looking for

Re: [PATCH v2 hwc] drm_hwcomposer: provide a common gralloc handle definition

On Tue, 2017-10-31 at 17:44 +0100, Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 09:59:20AM -0500, Rob Herring wrote: > > EGL, gralloc, and HWC must all have a common definition of fd's and > > int's > > in native_handle_t to share the fd and width, height, format, etc. > > of a > > dmabuf. > >

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

Hey Sean, On 2018-05-03 17:04, Sean Paul wrote: Hey all, Apologies for the direct ping. I've harvested your emails from drm_hwc git logs, and didn't want to leave anyone out. The good news is that your email address will forever be remembered in the annals of drm_hwcomposer! Anyways, back to

Re: [PATCH hwc 4/4] drm_hwcomposer: Fall back to client compositon if the gl precompostior fails

This patch is: Acked-by: Robert Foss <robert.f...@collabora.com> I'll push this series upstream in a few minutes. On 04/26/2018 09:05 PM, John Stultz wrote: If the gl precompositor isn't being used, we cannot accept every layer as a device composited layer. Thus this patch adds some

[PATCH v1] xf86drm: Add drmHandleMatch func

filter based on anything. But for the sake of convenience a few other simple filters have been included. If the function pointer filter ends up being called with a boilerplate fp by mutliple libdrm users, perhaps that funtion could be moved into libdrm at a future date. Signed-off-by: Robert Foss

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

Heya, On 2018-05-04 12:51, Daniel Stone wrote: Hi, On 3 May 2018 at 20:12, Sean Paul wrote: On Thu, May 03, 2018 at 08:30:18PM +0200, Daniel Vetter wrote: On Thu, May 3, 2018 at 5:04 PM, Sean Paul wrote: If you're still reading, I'll point out

Re: [PATCH v1] xf86drm: Add drmHandleMatch func

Hey Emil, On 27.04.2018 15:48, Emil Velikov wrote: On 27 April 2018 at 12:31, Robert Foss <robert.f...@collabora.com> wrote: drmHandleMatch is intended to allow for userspace to filter out devices that it does not want to open. Opening specific devices using paths alone is not a reliab

Re: [RFC PATCH hwc] drm_hwcomposer: provide a common gralloc handle definition

Hey Rob, On Tue, 2017-10-24 at 18:40 -0500, Rob Herring wrote: > EGL, gralloc, and HWC must all have a common definition of fd's and > int's > in native_handle_t to share the fd and width, height, format, etc. > of a dmabuf. > > Move the definition into HWC so we aren't dependent on a specific >

Re: [drm_hwcomposer] [PATCH] Take Connection state into account. (v2)

Hey Mauro! Thanks for the v2, I would like to merge this, but the commit message is a little bit wonky still :) Let me clean it up for you, and if you're fine with me adding your S-o-B I'll push it. Also, if you want to avoid the slow mailing list back and forth, I would happily help out

Re: [drm_hwcomposer] [PATCH] Update external connectors list

Hey Mauro, This patch looks good to me apart from the commit message formatting. If you tell me I can add your SOB, I'll merge it with the below commit message. On 1/6/18 12:59 AM, Mauro Rossi wrote: > DVID, DVII and VGA are required by discrete and integrated GPUs I would expect something

Re: [RFC][PATCH 2/4 v2] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

gt; wrote: On Tue, Jan 23, 2018 at 03:16:37PM -0800, John Stultz wrote: This allows for importing buffers allocated from the hikey and hikey960 gralloc implelementations. Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...@google.com> Cc: Dmitry Shmidt <dimitr...@goog

Re: [PATCH] drm_hwcomposer: fix check for valid fence fd for in fences

Hey Rob, This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss <robert.f...@collabora.com> Rob. On 02/13/2018 11:11 PM, Rob Herring wrote: The check for a valid fence fd is inverted, so we're failing to pass IN_FENCE_FD's to the kernel when we have a valid fence. Re

Re: [PATCH libdrm 0/4] gralloc handle fixes

Hey Rob, Thanks for ironing out the kinks, and the new helper. If you need reviews for any of the related changes, CC me. This all looks good to me. Feel free to add my r-b. Rob. On 02/15/2018 02:59 PM, Rob Herring wrote: The recently committed gralloc handle definition has a few issues

Re: [RFC PATCH hwc] drm_hwcomposer: set CRTC background color when available

Hey Stefan, On 02/22/2018 04:54 AM, Stefan Schake wrote: Android assumes an implicit black background layer is always present behind all layers it specifies for composition. drm_hwcomposer currently punts responsibility for this to the kernel/DRM platform and puts layers with per-pixel alpha

Re: [drm_hwcomposer PATCH] Take Connection state into account. (v2)

Hey Mauro, Thanks for the patch! It builds and looks good to me, but I have some suggestions however. On Wed, 2018-01-03 at 11:10 +0100, Mauro Rossi wrote: > These changes avoid following logcat error on integrated and > dedicated GPUs: > > ... 2245 2245 E hwc-drm-resources: Could not find a

Re: [drm_hwcomposer PATCH] Take Connection state into account. (v2)

Hey Mauro, On Wed, 2018-01-03 at 13:40 +0100, Mauro Rossi wrote: > > > 2018-01-03 12:16 GMT+01:00 Robert Foss <robert.f...@collabora.com>: > > Hey Mauro, > > / > > Thanks for the patch! It builds and looks good to me, but I have > > some > > suggesti

[RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

simplifies the stack. Signed-off-by: Tomasz Figa Reviewed-by: Zach Reizner Signed-off-by: Nicolas Norvez Reviewed-by: Tomasz Figa Signed-off-by: Robert Foss --- I've been looking into enabling a kms_swrast based driver for mesa on the Android platform[1]. But have come up against the issue

Re: [RFC][PATCH 2/2 v4] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

tions" -> "implementations" Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...@google.com> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Robert Foss <robert.f...@collabora.com> Cc: Matt Szczesiak <matt.szczes...@arm.com> Cc: Liviu Du

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

ConvertHALFormatToDrm and checking it's return code. So this patch tries to do this. Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...@google.com> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Robert Foss <robert.f...@collabora.com> Cc: Matt Szczesiak <matt.szczes.

Re: [RFC][PATCH 2/2 v4] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

Hey John, Feel free to add my ACK. Rob. On 03/08/2018 11:08 PM, John Stultz wrote: On Thu, Mar 8, 2018 at 3:16 AM, Robert Foss <robert.f...@collabora.com> wrote: Hey John, This patch looks good to me. I have yet to build it, and I haven't brought my HiKey960 up for testing qui

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

Hey, On 03/09/2018 10:55 AM, Alexandru-Cosmin Gheorghe wrote: Hi Daniel, On Fri, Mar 09, 2018 at 09:29:24AM +, Daniel Stone wrote: Hi John, On 8 March 2018 at 19:43, John Stultz <john.stu...@linaro.org> wrote: On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss <robert.f...@coll

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

(rather then returning the gralloc_handle_t's embadedded native_handle_t ptr). But it seems something like this is needed. Cc: Robert Foss <robert.f...@collabora.com> Cc: Rob Herring <r...@kernel.org> Signed-off-by: John Stultz <john.stu...@linaro.org> --- android/gralloc_ha

Re: [PATCH v5] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

min.gheor...@arm.com> Cc: Alistair Strachan <astrac...@google.com> Acked-by: Robert Foss <robert.f...@collabora.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Make platformhisi and the generic importer exclusive in the build * Fixup vendor check v3: * Unify form

[RFC 0/1] DRM Node Probing functionality

list of properties that are interesting and their values. In terms of long-term maintainership this might be less pleasant than the approach of the current implementation. Robert Foss (1): xf86drm: Add drmHandleMatch func xf86drm.h | 2 ++ xf86drmMode.c

[RFC 0/1] DRM Node Probing functionality

ties and allowing the caller to supply a list of properties that are interesting and their values. In terms of long-term maintainership this might be less pleasant than the approach of the current implementation. Robert Foss (1): xf86drm: Add drmHandleMatch func xf86drm.h | 2 ++ xf86drmMode.c

[RFC 1/1] xf86drm: Add drmHandleMatch func

the already existing drmVersion and drmDevice structs. Most fields of drmVersion and drmDevice can be used for comparing between the target device and the actual FD that has been provided. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- xf86drm.h | 2 ++ xf86drmMode.

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible for detecting all kms devices and allocates unique display numbers for every detected display. This is controlled by the value of

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

On 04/18/2018 12:12 PM, Alexandru-Cosmin Gheorghe wrote: On Tue, Apr 17, 2018 at 06:08:06PM +0200, Robert Foss wrote: Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible

Re: [PATCH hwc v2 01/18] drm_hwcomposer: vsyncworker: Fix uninitialized enabled_ field

Hey Alexandru, Feel free to add: Signed-off-by: Robert Foss <robert.f...@collabora.com> Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com> --- vsyncworker.cpp | 1 + 1 file changed, 1 insertion(+)

  1   2   3   4   5   6   7   8   9   >