Re: [PATCH] drm: rename u32 in __u32 in uapi

elikov <emil.l.veli...@gmail.com> I'm sure it was fixed at some point. v5: Rename modifiers to modifiers_property (Ville) Use sizeof(__u32) instead to reflect UAPI nature (Ville) Make BUILD_BUG_ON for blob header size Reviewed-by: Ben Widawsky <b...@bwidaws

Re: [PATCH] i915,drm/fourcc: Improve the CCS modifier documentation

y know how it works yet. Trying to fully describe it is premature. Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: Ben Widawsky <b...@bwidawsk.net> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- include/uapi/drm/drm_fourcc.h | 35 ++- 1

Re: [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

On 17-08-03 12:00:56, Daniel Stone wrote: Hi, On 1 August 2017 at 17:58, Ben Widawsky <b...@bwidawsk.net> wrote: @@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private *dev_priv, plane_formats = skl_plane_formats; num_plane_f

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

On 17-08-03 10:08:51, Daniel Vetter wrote: On Wed, Aug 2, 2017 at 5:43 PM, Ben Widawsky <b...@bwidawsk.net> wrote: On 17-08-02 12:14:15, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: On 17-07-31 10:29:55, Daniel Vetter wrote: > On Sat, Jul 29, 2

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

On 17-08-02 12:14:15, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: On 17-07-31 10:29:55, Daniel Vetter wrote: > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: > > On 17-07-29 13:53:10, Daniel Stone wrote: > > > Hi Ben, >

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

On 17-08-01 15:43:50, Kenneth Graunke wrote: On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote: v2: - Support sprite plane. - Support pipe C/D limitation on GEN9. v3: - Rename structure (Ville) - Handle GLK (Ville) v4: - Fix PIPE_C check, introduced in v2 (Daniel

[PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

lanet.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 30 +++--- drivers/gpu/drm/i915/intel_sprite.c | 28 +++- 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/

[PATCH 3/6] [v7] drm: Plumb modifiers through plane init

ent adjustments (Liviu) v5: Some new platforms added due to rebase v6: Add some missed plane inits (or maybe they're new - who knows at this point) (Daniel) v7: Add sun8i (Daniel) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-

[PATCH 5/6] [v10] drm/i915: Add format modifiers for Intel

gmail.com> Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> (v8) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 127 +-- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i9

[PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

paring the pointers. But that does sound a bit wasteful space wise. v2: Drop the 'dev' argument from the hook v3: Include the description of the CCS surface layout v4: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason) Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Ben

[PATCH 4/6] [v5] drm: Create a format/modifier blob

(Ville) Make BUILD_BUG_ON for blob header size Cc: Rob Clark <robdcl...@gmail.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-by: Liviu Dudau <li...@du

[PATCH 2/6] drm/i915: Add render decompression support

etter <dan...@ffwll.ch> * Ben Widawsky <b...@bwidawsk.net> v2: Deal with display workarounds 0390, 0531, 1125 (Paulo) v3: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason) Put the AUX register defines to the correct place Fix up the slightly bo

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

On 17-07-31 10:29:55, Daniel Vetter wrote: On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: On 17-07-29 13:53:10, Daniel Stone wrote: > Hi Ben, > > On 26 July 2017 at 19:08, Ben Widawsky <b...@bwidawsk.net> wrote: > > + } else if (INT

Re: [PATCH 6/6] drm/i915: Add support for CCS modifiers

On 17-07-29 13:53:10, Daniel Stone wrote: Hi Ben, On 26 July 2017 at 19:08, Ben Widawsky <b...@bwidawsk.net> wrote: + } else if (INTEL_GEN(dev_priv) >= 9) { intel_primary_formats = skl_primary_formats; num_formats = ARRAY_SIZE(skl_primar

[PATCH 5/6] drm/i915: Add format modifiers for Intel

<emil.l.veli...@gmail.com> (v8) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 127 +-- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_sprite.c | 141 +

[PATCH 6/6] drm/i915: Add support for CCS modifiers

v2: Support sprite plane. Support pipe C/D limitation on GEN9. v3: Rename structure (Ville) Handle GLK (Ville) This requires rebase on the correct Ville patches Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian Høgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b.

[PATCH 4/6] drm: Create a format/modifier blob

(Ville) Make BUILD_BUG_ON for blob header size Cc: Rob Clark <robdcl...@gmail.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-by: Liviu Dudau <li...@du

[PATCH 3/6] drm: Plumb modifiers through plane init

ent adjustments (Liviu) v5: Some new platforms added due to rebase v6: Add some missed plane inits (or maybe they're new - who knows at this point) (Daniel) v7: Add sun8i (Daniel) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-

[PATCH 2/6] drm/i915: Add render decompression support

etter <dan...@ffwll.ch> * Ben Widawsky <b...@bwidawsk.net> v2: Deal with display workarounds 0390, 0531, 1125 (Paulo) v3: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason) Put the AUX register defines to the correct place Fix up the slightly bo

[PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

paring the pointers. But that does sound a bit wasteful space wise. v2: Drop the 'dev' argument from the hook v3: Include the description of the CCS surface layout v4: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason) Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Ben

[PATCH 2/4] drm: Create a format/modifier blob

(Ville) Make BUILD_BUG_ON for blob header size Cc: Rob Clark <robdcl...@gmail.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-by: Liviu Dudau <li...@du

[PATCH 3/4] drm/i915: Add format modifiers for Intel

<emil.l.veli...@gmail.com> (v8) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 127 +-- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_sprite.c | 141 +

[PATCH 1/4] drm: Plumb modifiers through plane init

ent adjustments (Liviu) v5: Some new platforms added due to rebase v6: Add some missed plane inits (or maybe they're new - who knows at this point) (Daniel) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-by: Liviu Dudau <l

[PATCH 4/4] drm/i915: Add support for CCS modifiers

v2: Support sprite plane. Support pipe C/D limitation on GEN9. v3: Rename structure (Ville) Handle GLK (Ville) This requires rebase on the correct Ville patches Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian Høgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b.

[PATCH 0/4] [v2] Blobifiers (FKA GET_PLANE2)

. This interface will allow clients to create buffers for scanout with a good set of modifiers, and later import those buffers (through EGL already, and Vulkan WSI later) into a graphics runtime. EGL/WSI will provide similar interfaces for rendering - modifiers which can be used for rendering. Ben Widawsky (4

Re: [PATCH 4/4] drm/i915: Add support for CCS modifiers

On 17-06-29 23:02:08, Ville Syrjälä wrote: On Fri, Jun 23, 2017 at 09:45:44AM -0700, Ben Widawsky wrote: v2: Support sprite plane. Support pipe C/D limitation on GEN9. This requires rebase on the correct Ville patches Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian Høgsb

Re: [Intel-gfx] [PATCH 2/4] drm: Create a format/modifier blob

On 17-07-14 22:10:15, Ville Syrjälä wrote: On Fri, Jul 14, 2017 at 11:41:49AM -0700, Ben Widawsky wrote: On 17-06-29 22:49:44, Ville Syrjälä wrote: [snip] > >... but here it's ALIGN(formats_offset+formats_size). I think we should >be aligning the same thing in both cases,

Re: [Intel-gfx] [PATCH 2/4] drm: Create a format/modifier blob

what you want. BUILD_BUG_ON sounds good to me regardless. [snip] -- Ben Widawsky, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/4] drm: Create a format/modifier blob

viu) * Fix data types (Ben) * Make the blob part of uapi (Daniel) v3: Remove unused ret field. Change i, and j to unsigned int (Emil) v4: Use plane->modifier_count instead of recounting (Daniel) Cc: Rob Clark <robdcl...@gmail.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com>

[PATCH v4 0/4] Blobifiers (FKA GET_PLANE2)

of things came up and it took a while to spin this rev. Nothing was missing intentionally. [1] The bitmask is used to show the connection between which modifiers are supported by which formats. Ben Widawsky (4): drm: Plumb modifiers through plane init drm: Create a format/modifier blob drm

[PATCH 3/4] drm/i915: Add format modifiers for Intel

com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 136 +-- drivers/gpu/drm/i915/intel_sprite.c | 82 - 2 files changed, 211 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_

[PATCH 4/4] drm/i915: Add support for CCS modifiers

v2: Support sprite plane. Support pipe C/D limitation on GEN9. This requires rebase on the correct Ville patches Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian Høgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/in

[PATCH 1/4] drm: Plumb modifiers through plane init

ent adjustments (Liviu) v5: Some new platforms added due to rebase v6: Add some missed plane inits (or maybe they're new - who knows at this point) (Daniel) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Reviewed-by: Liviu Dudau <l

Re: [PATCH v5 3/3] drm/i915: Add format modifiers for Intel

On 17-05-17 01:20:50, Emil Velikov wrote: Hi Ben, A couple of small questions/suggestions that I hope you find useful. Please don't block any of this work based on my comments. On 16 May 2017 at 22:31, Ben Widawsky <b...@bwidawsk.net> wrote: +stati

Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob

On 17-05-17 01:06:16, Emil Velikov wrote: Hi Ben, On 16 May 2017 at 22:31, Ben Widawsky <b...@bwidawsk.net> wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) v2: * Removed __packed, and alignment (.+) * Fix indent in drm_format_modifier fields (Liviu) * Remove duplicated modifie

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On 17-05-17 13:31:44, Daniel Vetter wrote: On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: On 17-05-03 17:08:27, Daniel Vetter wrote: > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > > +struct drm_format_modifier_blob { > > +#define FORMAT

[PATCH v3 1/3] drm: Plumb modifiers through plane init

viu.du...@arm.com> Reviewed-by: Daniel Stone <dani...@collabora.com> (v2) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/arc/arcpgu_crtc.c | 1 + drivers/gpu/drm/arm/hdlcd_crtc.c| 1 + drivers/gpu/drm/arm/malidp_planes.c |

[PATCH v2 2/3] drm: Create a format/modifier blob

viu) * Fix data types (Ben) * Make the blob part of uapi (Daniel) Cc: Rob Clark <robdcl...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Cc: Liviu Dudau <li...@dudau.co.uk> Signed-off-by: Ben Widawsky <b...@bwidawsk.

[PATCH v5 3/3] drm/i915: Add format modifiers for Intel

yrj...@linux.intel.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 131 +-- drivers/gpu/drm/i915/intel_sprite.c | 76 +++- 2 files changed, 20

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On 17-05-03 17:08:27, Daniel Vetter wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark <robdcl...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.

Re: [PATCH 2/3] drm: Create a format/modifier blob

On 17-05-03 14:15:15, Liviu Dudau wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark <robdcl...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.

Re: [Intel-gfx] [PATCH 1/3] drm: Plumb modifiers through plane init

On 17-05-10 18:24:52, Liviu Dudau wrote: On Wed, May 10, 2017 at 09:34:40AM -0700, Ben Widawsky wrote: On 17-05-03 18:30:07, Liviu Dudau wrote: > On Wed, May 03, 2017 at 06:45:05PM +0200, Daniel Vetter wrote: > > On Wed, May 03, 2017 at 03:52:23PM +0100, Liviu Dudau wrote: > > &

Re: [Intel-gfx] [PATCH 1/3] drm: Plumb modifiers through plane init

f producing AFBC data, so there might be another driver in the making that will be open source. Best regards, Liviu But besides that, it works perfectly fine for arm render compression format too. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- So are

Re: [Intel-gfx] [PATCH 1/3] drm: Plumb modifiers through plane init

On 17-05-03 14:45:26, Daniel Stone wrote: Hi Liviu, On 3 May 2017 at 11:34, Liviu Dudau <liviu.du...@arm.com> wrote: On Tue, May 02, 2017 at 10:14:26PM -0700, Ben Widawsky wrote: v2: A minor addition from Daniel You are *really* pushing your luck by not Cc-ing *any* of the maint

[PATCH 2/3] drm: Create a format/modifier blob

Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark <robdcl...@gmail.com> Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/drm_mode_config.c |

[PATCH 1/3] drm: Plumb modifiers through plane init

v2: A minor addition from Daniel Cc: Daniel Stone <dani...@collabora.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/arc/arcpgu_crtc.c | 1 + drivers/gpu/drm/arm/hdlcd_crtc.c| 1 + drivers/gpu/drm/arm/malidp_planes.c

[PATCH 3/3] drm/i915: Add format modifiers for Intel

yrj...@linux.intel.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 131 +-- drivers/gpu/drm/i915/intel_sprite.c | 76 +++- 2 files changed, 20

Re: [PATCH 1/2] drm: Add new DRM_IOCTL_MODE_GETPLANE2

On 17-04-28 14:11:56, Lucas Stach wrote: Hi Ben, Am Dienstag, den 04.04.2017, 12:41 -0700 schrieb Ben Widawsky: On 17-04-04 11:07:26, Daniel Stone wrote: >Hi, > >On 1 April 2017 at 19:47, Rob Clark <robdcl...@gmail.com> wrote: >> On Tue, Dec 20, 2016 at 7:12 PM, K

Re: [PATCH 1/2] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2. I'm a bit new to the binary blob props, so if anyone has a strong opinion on how it should look, please speak now. Otherwise, I'll just wire up something. -- Ben Widawsky, Intel Open Source Technology Center ___ dri-devel mailing li

[PATCH 3/3] [v5] drm/i915: Add format modifiers for Intel

yrj...@linux.intel.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 132 +-- drivers/gpu/drm/i915/intel_sprite.c | 76 +++- 2 files changed, 20

[PATCH] squash! drm/i915: Add format modifiers for Intel

make sprite and cursor have separate functions --- Ville, I think this addresses most of your comments. I'm guessing you're going to ask for separate gen sprite plane functions, but I think this looks pretty decent as is. --- drivers/gpu/drm/i915/intel_display.c | 26 --

Re: [PATCH 3/3] drm/i915: Add format modifiers for Intel

On 17-03-29 23:17:13, Ville Syrjälä wrote: On Fri, Mar 24, 2017 at 02:29:50PM -0700, Ben Widawsky wrote: This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. v2: - Add LINEAR and Yf modifiers to list (Ville

[PATCH 1/3] drm/i915: Use LINEAR modifier instead of NONE

They're the same, so use the one which makes more sense. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drive

[PATCH 3/3] drm/i915: Add format modifiers for Intel

) v3: - Handle cursor formats (Ville) - Put handling for LINEAR in the mod_support functions (Ville) Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/int

[PATCH 2/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

ntel.com> Cc: Daniel Stone <dan...@fooishbar.org> Cc: "Kristian H. Kristensen" <hoegsb...@gmail.com> References: https://patchwork.kernel.org/patch/9482393/ Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/arc/arcpgu_crtc.c

Re: [PATCH 2/5] drm: Remove fb hsub/vsub alignment requirement

upport. So let's just lift the restriction. Let's start to round up when computing the color plane dimesions so that we'll not end up with too low an estimate for the memory requirements and whatnot. Cc: Ben Widawsky <b...@bwidawsk.net> Cc: Jason Ekstrand <ja...@jlekstrand.net> Si

Re: [PATCH v2 9/9] drm/i915: Add render decompression support

On 17-03-01 12:51:17, Ville Syrjälä wrote: On Tue, Feb 28, 2017 at 03:20:38PM -0800, Ben Widawsky wrote: On 17-02-28 12:18:39, Jason Ekstrand wrote: >I've said it before but reading through Ben's patches again make me want to >be peskier about it. I would really like the UABI to

Re: [PATCH v2 9/9] drm/i915: Add render decompression support

. Also not all planes will be capable of scanning out compressed surfaces, and eg. 90/270 degree rotation is not supported in combination with decompression either. This patch may contain work from at least the following people: * Vandana Kannan <vandana.kan...@intel.com> * Daniel Vetter <

Re: [PATCH v2 9/9] drm/i915: Add render decompression support

. Also not all planes will be capable of scanning out compressed surfaces, and eg. 90/270 degree rotation is not supported in combination with decompression either. This patch may contain work from at least the following people: * Vandana Kannan <vandana.kan...@intel.com> * Daniel Vetter <

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS

it wasteful space wise. > > v2: Drop the 'dev' argument from the hook > v3: Include the description of the CCS surface layout > > Cc: Vandana Kannan <vandana.kan...@intel.com> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Ben Widawsky <b...@bwidawsk.net> >

[PATCH 1/3] [v3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

n...@fooishbar.org> Cc: "Kristian H. Kristensen" <hoegsb...@gmail.com> References: https://patchwork.kernel.org/patch/9482393/ Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/arc/arcpgu_crtc.c | 1 + drivers/gpu/drm/arm/hdlcd_crtc.c

[PATCH 1/3] [v2] drm: Add new DRM_IOCTL_MODE_GETPLANE2

oishbar.org> Cc: "Kristian H. Kristensen" <hoegsb...@gmail.com> References: https://patchwork.kernel.org/patch/9482393/ Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/arc/arcpgu_crtc.c | 1 + drivers/gpu/drm/arm/hdlcd_crtc.c|

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

On 17-01-12 20:32:07, Ville Syrjälä wrote: On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote: On 17-01-12 12:51:20, Ville Syrjälä wrote: >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: >> This was based on a patch originally by Kristian. It has been modified

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

On 17-01-12 12:51:20, Ville Syrjälä wrote: On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. Cc: Kristian H. Kristensen <hoegsb...@gmail.

[PATCH 3/3] drm/i915: Add support for GET_PLANE2 CCS modifiers

Cc: Kristian Høgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_display.c | 10 -- drivers/gpu/drm/i915/intel_sprite.c | 2 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/int

[PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

array a sentinel based structure instead of a sized one. Upon discussion on IRC, it was determined that having an invalid modifier might make sense in general as well. References: https://patchwork.kernel.org/patch/9482393/ Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/d

[PATCH 2/3] drm/i915: Add format modifiers for Intel

This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- drivers/gpu/drm/i915/intel_dis

[PATCH 0/3] GET_PLANE2 w/ i915 implementation

ube) https://github.com/bwidawsk/kmscube/commit/55519640f5a1a21983e267fb39e4cf48f6312ef9 References: (libdrm) https://lists.freedesktop.org/archives/dri-devel/2016-December/127942.html Ben Widawsky (3): drm: Add new DRM_IOCTL_MODE_GETPLANE2 drm/i915: Add format modifiers for Intel

Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

On 17-01-11 17:05:04, Ville Syrjälä wrote: On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote: Am 05.01.2017 um 12:37 schrieb Ville Syrjälä: > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote: >> From: Rainer Hochecker >> >> This adds fourcc

[PATCH 0/9] drm/i915: SKL+ render decompression support

o figure out which parts came from where. > >Entire series available here: >git://github.com/vsyrjala/linux.git fb_format_dedup_4_ccs > >Cc: Vandana Kannan >Cc: Daniel Vetter >Cc: Ben Widawsky >Cc: Jason Ekstrand >Cc: Laurent Pinchart > In addition to revie

[Intel-gfx] [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS

gt; >>v2: Drop the 'dev' argument from the hook >>v3: Include the description of the CCS surface layout >> >>Cc: Vandana Kannan >>Cc: Daniel Vetter >>Cc: Ben Widawsky >>Cc: Jason Ekstrand >>Reviewed-by: Ben Widawsky >>Signed-off-by: Ville SyrjÃ

[PATCH 9/9] drm/i915: Add render decompression support

nes will be capable of scanning out compressed surfaces, >and eg. 90/270 degree rotation is not supported in combination with >decompression either. > >This patch may contain work from at least the following people: >* Vandana Kannan >* Daniel Vetter >* Ben Widawsky > >Cc:

[PATCH 1/9] drm: Add mode_config .get_format_info() hook

t;Don't pass 'dev' to the new hook (Laurent) > >Cc: Laurent Pinchart >Cc: Ben Widawsky >Signed-off-by: Ville Syrjälä >--- > drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- > drivers/gpu/drm/drm_fourcc.c | 25 + > drivers/gpu/drm/drm_fram

[PATCH 2/2] modetest: Teach modetest about format info

On 16-12-20 16:13:33, Kristian H. Kristensen wrote: >From: "Kristian H. Kristensen" > >BUG=chrome-os-partner:56407 >TEST=modetest on a KMS driver that exposes modifiers should print those > >Change-Id: I91b2a408b1c8f112d7ba5d0998119b3c800b199c >--- > tests/modetest/modetest.c | 40

[PATCH 1/2] Add DRM_IOCTL_MODE_GETPLANE2 ioctl wrapper

} > > err_allocs: > drmFree(U642VOID(ovr.format_type_ptr)); >+ drmFree(U642VOID(ovr.format_modifier_ptr)); > > return r; > } > >+drmModePlanePtr drmModeGetPlane2(int fd, uint32_t plane_id) >+{ >+ drmModePlanePtr r = get_plane(DRM_IOCTL_MODE_GETPL

[PATCH 37/37] drm/i915: Implement .get_format_info() hook for CCS

bit wasteful space wise. > >Cc: Ben Widawsky >Cc: intel-gfx at lists.freedesktop.org >Signed-off-by: Ville Syrjälä I have a comment below however, you can consider it: Reviewed-by: Ben Widawsky >--- > drivers/gpu/drm/i915/intel_display.c | 37 ++

[RFC][PATCH] drm: Nuke modifier[1-3]

Acked-by: Ben Widawsky On 16-11-16 13:33:16, Ville Syrjälä wrote: >From: Ville Syrjälä > >It has been suggested that having per-plane modifiers is making life >more difficult for userspace, so let's just retire modifier[1-3] and >use modifier[0] to apply to the ent

[PATCH] intel: Add Geminilake PCI IDs

From: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 514f659..41fc0da 100644 --- a/intel/intel_chipset.h +++ b

[Mesa-dev] [PATCH] [v2] intel: Add missing SKL device IDs

On Tue, Feb 16, 2016 at 03:42:45PM -0800, Ben Widawsky wrote: > A new list yielded new devices that apparently have shipped, or will ship. > > v2: I can't read. 0x192d is GT3 > > Signed-off-by: Ben Widawsky > --- > intel/intel_chipset.h | 11 --- > 1 file cha

[PATCH] [v2] intel: Add missing SKL device IDs

A new list yielded new devices that apparently have shipped, or will ship. v2: I can't read. 0x192d is GT3 Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index

[PATCH] intel: Add missing SKL device IDs

A new list yielded new devices that apparently have shipped, or will ship. Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 35148e5..392f7ba 100644 --- a/intel

[PATCH 2/2] intel: Cleanup SKL PCI ID definitions.

This removes ones which aren't used 0x190b, 192a), and adds some new ones. I kept the original names where possible. Cc: Kristian Høgsberg Cc: Damien Lespiau Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 46 ++ 1 file changed, 26

[PATCH 1/2] intel: Add SKL GT4 PCI IDs

Cc: Kristian Høgsberg Cc: Damien Lespiau Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 253ea71..6c8dc73 100644 --- a/intel/intel_chipset.h +++ b/intel

[PATCH v2] drm/vgem: implement virtual GEM

ing them to userspace. The mmap is done using the mmap > > operation exported by other drivers. > > > > v2: remove platform_device and do not attach to dma bufs > > > > Reviewed-by: Stéphane Marchesin > > Signed-off-by: Adam Jackson > > Signed-off-by: B

[PATCH v2] drm/vgem: implement virtual GEM

ion exported by other drivers. > > v2: remove platform_device and do not attach to dma bufs > > Reviewed-by: Stéphane Marchesin > Signed-off-by: Adam Jackson > Signed-off-by: Ben Widawsky > Signed-off-by: Zach Reizner Looks good to me. [snip]

[Intel-gfx] [PATCH 4/4] drm/i915: Opportunistically reduce flushing at execbuf

On Tue, Dec 16, 2014 at 07:57:39AM +, Chris Wilson wrote: > On Mon, Dec 15, 2014 at 01:06:40PM -0800, Ben Widawsky wrote: > > On Mon, Dec 15, 2014 at 08:39:35PM +, Chris Wilson wrote: > > > On Mon, Dec 15, 2014 at 11:56:05AM -0800, Ben Widawsky wrote: > > > >

[PATCH 2/4] drm/cache: Try to be smarter about clflushing on x86

On Sat, Dec 13, 2014 at 08:15:22PM -0800, Matt Turner wrote: > On Sat, Dec 13, 2014 at 7:08 PM, Ben Widawsky > wrote: > > Any GEM driver which has very large objects and a slow CPU is subject to > > very > > long waits simply for clflushing incoherent objects. General

[Intel-gfx] [PATCH 4/4] drm/i915: Opportunistically reduce flushing at execbuf

On Mon, Dec 15, 2014 at 08:39:35PM +, Chris Wilson wrote: > On Mon, Dec 15, 2014 at 11:56:05AM -0800, Ben Widawsky wrote: > > On Mon, Dec 15, 2014 at 08:20:50AM +, Chris Wilson wrote: > > > On Mon, Dec 15, 2014 at 08:55:32AM +0100, Daniel Vetter wrote: > > > >

[PATCH] [v2] drm/cache: Use wbinvd helpers

From: Ben Widawsky <b...@bwidawsk.net> When the original drm code was written there were no centralized functions for doing a coordinated wbinvd across all CPUs. Now (since 2010) there are, so use them instead of rolling a new one. v2: On x86 UP systems the wbinvd_on_all_cpus() is d

[Intel-gfx] [PATCH 4/4] drm/i915: Opportunistically reduce flushing at execbuf

On Mon, Dec 15, 2014 at 08:20:50AM +, Chris Wilson wrote: > On Mon, Dec 15, 2014 at 08:55:32AM +0100, Daniel Vetter wrote: > > On Sun, Dec 14, 2014 at 03:37:36PM -0800, Ben Widawsky wrote: > > > On Sun, Dec 14, 2014 at 03:12:21PM +0200, Ville Syrjälä wrote: > > > &

[Intel-gfx] [PATCH 2/4] drm/cache: Try to be smarter about clflushing on x86

On Sun, Dec 14, 2014 at 08:06:20PM -0800, Jesse Barnes wrote: > On 12/14/2014 4:59 AM, Chris Wilson wrote: > >One of the things wbinvd is considered evil for is that it blocks the > >CPU for an indeterminate amount of time - upsetting latency critcial > >aspects of the OS. For example, the x86/mm

[Intel-gfx] [PATCH 4/4] drm/i915: Opportunistically reduce flushing at execbuf

On Sun, Dec 14, 2014 at 03:12:21PM +0200, Ville Syrjälä wrote: > On Sat, Dec 13, 2014 at 07:08:24PM -0800, Ben Widawsky wrote: > > If we're moving a bunch of buffers from the CPU domain to the GPU domain, > > and > > we've already blown out the entire cache via a wbi

[PATCH 4/4] drm/i915: Opportunistically reduce flushing at execbuf

to flush it first, the results would be even more desirable. Cc: DRI Development Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.h| 3 ++- drivers/gpu/drm/i915/i915_gem.c| 12 +--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +--- drivers/gpu

[PATCH 3/4] drm/cache: Return what type of cache flush occurred

minimally considered for the sake of getting the data for the profile. Cc: Intel GFX Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_cache.c | 34 +- include/drm/drmP.h | 13 ++--- 2 files changed, 35 insertions(+), 12 deletions(-) diff --git

[PATCH 2/4] drm/cache: Try to be smarter about clflushing on x86

be nice to hear what other developers who depend on this code think. Cc: Intel GFX Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_cache.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index

[PATCH 1/4] drm/cache: Use wbinvd helpers

When the original drm code was written there were no centralized functions for doing a coordinated wbinvd across all CPUs. Now (since 2010) there are, so use them instead of rolling a new one. Cc: Intel GFX Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_cache.c | 12 +++- 1 file

[PATCH 0/4] [RFC] Sometimes opt for wbinvd over clflush

compile tested. Thanks. Ben Widawsky (4): drm/cache: Use wbinvd helpers drm/cache: Try to be smarter about clflushing on x86 drm/cache: Return what type of cache flush occurred drm/i915: Opportunistically reduce flushing at execbuf drivers/gpu/drm/drm_cache.c| 54

[Intel-gfx] [PATCH] drm/mm: Don't WARN if drm_mm_reserve_node

On Wed, Apr 09, 2014 at 07:25:37AM +0100, Chris Wilson wrote: > On Tue, Apr 08, 2014 at 10:21:44AM -0700, Ben Widawsky wrote: > > I am not convinced this is the correct solution. At least the way we > > used this interface, it isn't meant to ever fail. I also didn't look > >

[PATCH] drm/mm: Don't WARN if drm_mm_reserve_node

gt; always when lighting up more than one screen). All this fanciness > > happens in intel_alloc_plane_obj in intel_display.c. > > > > Since no one else uses this we can savely remove the WARN without > > repercursions. > > > > Reported-by: Ben Widawsky

[PATCH 20/34] drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c

crydee kernel: [] > __pci_register_driver+0x5b/0x5e > Mar 20 01:14:21 crydee kernel: [] ? 0xa01c0fff > Mar 20 01:14:21 crydee kernel: [] > drm_pci_init+0x69/0xec [drm] > Mar 20 01:14:21 crydee kernel: [] ? 0xa01c0fff > Mar 20 01:14:21 crydee kernel: [] > radeon_init+0x97/0xb5 [radeon] > > Dave. i915 gets 3 distinct WARNs from this patch. -- Ben Widawsky, Intel Open Source Technology Center

  1   2   3   4   >