Re: [PATCH 3/9] drm: Make sure every ioctl structure has a typedef

2013-09-08 Thread Daniel Vetter
On Fri, Sep 06, 2013 at 07:57:19PM +0100, Damien Lespiau wrote: Just for consistency. Signed-off-by: Damien Lespiau damien.lesp...@intel.com Afaik kernel coding style is to echew typdefs for normal structures as much as possible. The only exception is for truly opaque types used in

Re: [PATCH 3/9] drm: Make sure every ioctl structure has a typedef

2013-09-08 Thread Damien Lespiau
On Sun, Sep 08, 2013 at 01:58:29PM +0200, Daniel Vetter wrote: On Fri, Sep 06, 2013 at 07:57:19PM +0100, Damien Lespiau wrote: Just for consistency. Signed-off-by: Damien Lespiau damien.lesp...@intel.com Afaik kernel coding style is to echew typdefs for normal structures as much as

Re: [PATCH 3/9] drm: Make sure every ioctl structure has a typedef

2013-09-08 Thread Daniel Vetter
On Sun, Sep 8, 2013 at 9:36 PM, Damien Lespiau damien.lesp...@intel.com wrote: On Sun, Sep 08, 2013 at 01:58:29PM +0200, Daniel Vetter wrote: On Fri, Sep 06, 2013 at 07:57:19PM +0100, Damien Lespiau wrote: Just for consistency. Signed-off-by: Damien Lespiau damien.lesp...@intel.com Afaik

[PATCH 3/9] drm: Make sure every ioctl structure has a typedef

2013-09-06 Thread Damien Lespiau
Just for consistency. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- include/uapi/drm/drm.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index b8604d2..0430fab 100644 --- a/include/uapi/drm/drm.h