Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-17 Thread Damien Lespiau
On Mon, Sep 16, 2013 at 06:35:12PM +0100, Damien Lespiau wrote: On Fri, Sep 13, 2013 at 04:10:24PM +, Joakim Plate wrote: Damien Lespiau damien.lespiau at intel.com writes: +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = { + { 1920, 1080, 24, 0, +

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Ville Syrjälä
On Mon, Sep 16, 2013 at 06:35:12PM +0100, Damien Lespiau wrote: On Fri, Sep 13, 2013 at 04:10:24PM +, Joakim Plate wrote: Damien Lespiau damien.lespiau at intel.com writes: +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = { + { 1920, 1080, 24, 0, +

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Damien Lespiau
On Fri, Sep 13, 2013 at 04:10:24PM +, Joakim Plate wrote: Damien Lespiau damien.lespiau at intel.com writes: +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = { + { 1920, 1080, 24, 0, + DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING }, + {

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Daniel Vetter
On Mon, Sep 16, 2013 at 7:56 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: Oh and now that vactive is actually part of the framebuffer as well, we need to be more careful in the kernel how we adjust the mode. I can't recall if we have special hardware needs wrt. the vertical timings,

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Daniel Vetter
On Mon, Sep 16, 2013 at 7:35 PM, Damien Lespiau damien.lesp...@intel.com wrote: I think it makes quite a bit of sense to have the underlying 2D mode in the mode structure as this 2d mode is relevant to the 3d mode: - HDMI stereo modes are defined based on the unerdlying 2D mode. (eg the

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-13 Thread Daniel Vetter
On Fri, Sep 13, 2013 at 6:10 PM, Joakim Plate elu...@ecce.se wrote: Also, some logic aught to indicate pixel aspect ratio for the modes since they are non square for the half res modes. Atm we completely ignore pixel aspect ratio, also for flatworld CEA modes. So I don't think we need to

Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-13 Thread Joakim Plate
Damien Lespiau damien.lespiau at intel.com writes: +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = { + { 1920, 1080, 24, 0, + DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING }, + { 1920, 1080, 50, DRM_MODE_FLAG_INTERLACE, +

[PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-06 Thread Damien Lespiau
For now, let's just look at the 3D_present flag of the CEA HDMI vendor block to detect if the sink supports a small list of then mandatory 3D formats. See the HDMI 1.4a 3D extraction for detail: http://www.hdmi.org/manufacturer/specification.aspx Signed-off-by: Damien Lespiau