Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Miguel Ojeda
On Thu, Apr 6, 2023 at 5:45 PM Daniel Vetter wrote: > > Yeah this all looks great and very hyperlinked. > > I think the only nit I have is that for types with two or more type > variables (like the rbtree) what each of them should represent in the top > intro. I can guess it's and not the other

Re: [Linaro-mm-sig] Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Asahi Lina
On 07/04/2023 01.13, Daniel Vetter wrote: On Fri, Apr 07, 2023 at 12:53:47AM +0900, Asahi Lina wrote: On 06/04/2023 23.15, Daniel Vetter wrote: On Tue, Mar 07, 2023 at 11:25:32PM +0900, Asahi Lina wrote: drm_mm provides a simple range allocator, useful for managing virtual address ranges. Add

Re: [Linaro-mm-sig] Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Daniel Vetter
On Fri, Apr 07, 2023 at 12:53:47AM +0900, Asahi Lina wrote: > On 06/04/2023 23.15, Daniel Vetter wrote: > > On Tue, Mar 07, 2023 at 11:25:32PM +0900, Asahi Lina wrote: > > > drm_mm provides a simple range allocator, useful for managing virtual > > > address ranges. Add a Rust abstraction to expose

Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Asahi Lina
On 06/04/2023 23.15, Daniel Vetter wrote: On Tue, Mar 07, 2023 at 11:25:32PM +0900, Asahi Lina wrote: drm_mm provides a simple range allocator, useful for managing virtual address ranges. Add a Rust abstraction to expose this module to Rust drivers. Signed-off-by: Asahi Lina In the cover

Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Daniel Vetter
On Thu, Apr 06, 2023 at 05:28:59PM +0200, Miguel Ojeda wrote: > On Thu, Apr 6, 2023 at 4:15 PM Daniel Vetter wrote: > > > > Documentation: > > > > In drm we try to document all the interfaces that drivers use with formal > > docs. Yes there's some areas that are not great for historical reasons,

Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Miguel Ojeda
On Thu, Apr 6, 2023 at 4:15 PM Daniel Vetter wrote: > > Documentation: > > In drm we try to document all the interfaces that drivers use with formal > docs. Yes there's some areas that are not great for historical reasons, > but for new stuff and new wrappers we're really trying: > > - This helps

Re: [PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-04-06 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:32PM +0900, Asahi Lina wrote: > drm_mm provides a simple range allocator, useful for managing virtual > address ranges. Add a Rust abstraction to expose this module to Rust > drivers. > > Signed-off-by: Asahi Lina In the cover letter you mentioned the design open

[PATCH RFC 07/18] rust: drm: mm: Add DRM MM Range Allocator abstraction

2023-03-07 Thread Asahi Lina
drm_mm provides a simple range allocator, useful for managing virtual address ranges. Add a Rust abstraction to expose this module to Rust drivers. Signed-off-by: Asahi Lina --- rust/kernel/drm/mm.rs | 309 + rust/kernel/drm/mod.rs | 1 + 2