[PATCH] staging: fbtft: convert sysfs snprintf to sysfs_emit

2021-04-03 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/staging/fbtft//fbtft-sysfs.c:202:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang --- drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: fbtft: change snprintf() to scnprintf()

2021-04-02 Thread Carlis
From: Xuezhi Zhang show() must not use snprintf() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang --- drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c

[PATCH v15] staging: fbtft: add tearing signal detect

2021-02-07 Thread Carlis
From: Carlis For st7789v IC, when we need continuous full screen refresh, it is best to wait for the tearing effect line signal to arrive to avoid screen tearing. Signed-off-by: Carlis --- v15: change ret value return logic in write_vmem. v14: change to define TE completion and TE irq only

[PATCH v14] staging: fbtft: add tearing signal detect

2021-02-04 Thread Carlis
From: Carlis For st7789v IC, when we need continuous full screen refresh, it is best to wait for the tearing effect line signal to arrive to avoid screen tearing. Signed-off-by: Carlis --- v14: change to define TE completion and TE irq only in st7789v. v13: change TE completion to par data

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-02-01 Thread Carlis
On Mon, 1 Feb 2021 19:40:21 +0200 Andy Shevchenko wrote: > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote: > > On Fri, 29 Jan 2021 16:26:12 +0200 > > Andy Shevchenko wrote: > > > On Fri, Jan 29, 2021 at 3:56 PM carlis > > > wrote: > > > > On

[PATCH v13] staging: fbtft: add tearing signal detect

2021-02-01 Thread Carlis
From: Carlis For st7789v IC, when we need continuous full screen refresh, it is best to wait for the tearing effect line signal to arrive to avoid screen tearing. Signed-off-by: Carlis --- v13: change TE completion to par data struct member and add a new function to deal te gpio request

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-29 Thread carlis
On Fri, 29 Jan 2021 16:26:12 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote: > > On Fri, 29 Jan 2021 12:23:08 +0200 > > Andy Shevchenko wrote: > > We are almost there, I have no idea what Noralf or others are going to > say thoug

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-29 Thread carlis
On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > &

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-29 Thread carlis
On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > &

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-29 Thread carlis
On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > &

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 16:33:02 +0200 Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote: > > Thanks for your contribution, my comments below. > > > From: zhangxuezhi > > You probably have to configure your Git to use the same account for > au

[PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread Carlis
From: zhangxuezhi For st7789v ic,when we need continuous full screen refresh, it is best to wait for the TE signal arrive to avoid screen tearing Signed-off-by: zhangxuezhi --- v12: change dev_err to dev_err_probe and add space in comments start, and delete te_mutex, change te wait logic

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 12:15:28 +0100 Geert Uytterhoeven wrote: > Hi Carlis, > > On Thu, Jan 28, 2021 at 12:03 PM carlis > wrote: > > On Thu, 28 Jan 2021 10:42:54 +0100 > > Geert Uytterhoeven wrote: > > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander >

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 10:42:54 +0100 Geert Uytterhoeven wrote: > Hi Kari, > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander > wrote: > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > > On Thu, 28 Jan 2021 00:32:22 +0200 > > > Kari Argil

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 08:52:33 +0200 Kari Argillander wrote: > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > On Thu, 28 Jan 2021 00:32:22 +0200 > > Kari Argillander wrote: > > > > #include "fbtft.h" > > > > > > > >

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Thu, 28 Jan 2021 00:32:22 +0200 Kari Argillander wrote: > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > For st7789v ic,when we need continuous full screen refresh, it is > > best to wait for the TE signal arrive to avoid screen tearing > > > diff

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 16:02:35 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote: > > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > > > On W

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 15:13:05 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > On Wed, 27 Jan 2021 14:51:55 +0100 > > Greg KH wrote: > > > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > > From: zh

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 14:51:55 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > From: zhangxuezhi > > > > For st7789v ic,when we need continuous full screen refresh, it is > > best to wait for the TE signal arrive to avoid screen

Re: [PATCH v9] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 14:47:04 +0100 Geert Uytterhoeven wrote: > Hi Carlis, > > On Wed, Jan 27, 2021 at 2:03 PM Carlis wrote: > > From: zhangxuezhi > > > > For st7789v ic,add tearing signal detect to avoid screen tearing > > > > Signed-off-by: zhangxuez

[PATCH v11] staging: fbtft: add tearing signal detect

2021-01-27 Thread Carlis
From: zhangxuezhi For st7789v ic,when we need continuous full screen refresh, it is best to wait for the TE signal arrive to avoid screen tearing Signed-off-by: zhangxuezhi --- v11: remove devm_gpio_put and change a dev_err to dev_info v10: additional notes v9: change pr_* to dev_* v8: delete

Re: [PATCH v9] staging: fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 14:11:31 +0100 Greg KH wrote: > On Wed, Jan 27, 2021 at 08:57:37PM +0800, Carlis wrote: > > From: zhangxuezhi > > > > For st7789v ic,add tearing signal detect to avoid screen tearing > > I need a much better changelog description here ple

[PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Carlis
From: zhangxuezhi For st7789v ic,when we need continuous full screen refresh, it is best to wait for the TE signal arrive to avoid screen tearing Signed-off-by: zhangxuezhi --- v10: additional notes v9: change pr_* to dev_* v8: delete a log line v7: return error value when request fail v6: add

[PATCH v9] staging: fbtft: add tearing signal detect

2021-01-27 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v9: change pr_* to dev_* --- drivers/staging/fbtft/fb_st7789v.c | 132 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 132

[PATCH v8] fbtft: add tearing signal detect

2021-01-27 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v8: delete a log line --- drivers/staging/fbtft/fb_st7789v.c | 132 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 132

Re: [PATCH v6] fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 11:59:51 +0300 Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:28:22PM +0800, Carlis wrote: > > static int init_display(struct fbtft_par *par) > > { > > + int rc; > > + struct device *dev = par->info->device; > > + > > +

[PATCH v7] fbtft: add tearing signal detect

2021-01-27 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v7: request fail to return error value --- drivers/staging/fbtft/fb_st7789v.c | 133 - drivers/staging/fbtft/fbtft.h | 1 + 2 files

Re: [PATCH v6] fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 10:00:13 +0100 Geert Uytterhoeven wrote: > Hi Carlis, > > On Wed, Jan 27, 2021 at 9:52 AM Carlis wrote: > > From: zhangxuezhi > > > > For st7789v ic,add tearing signal detect to avoid screen tearing > > > > Signed-off-by: zh

[PATCH v6] fbtft: add tearing signal detect

2021-01-26 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v6: add te gpio request fail deal logic --- drivers/staging/fbtft/fb_st7789v.c | 133 - drivers/staging/fbtft/fbtft.h | 1 + 2 files

Re: [PATCH v5] fbtft: add tearing signal detect

2021-01-26 Thread carlis
On Wed, 27 Jan 2021 08:45:23 +0300 Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 09:32:20AM +0800, Carlis wrote: > > @@ -82,6 +111,29 @@ enum st7789v_command { > > */ > > static int init_display(struct fbtft_par *par) > > { > > + int rc; > > +

[PATCH v5] fbtft: add tearing signal detect

2021-01-26 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v5:fix log print --- drivers/staging/fbtft/fb_st7789v.c | 128 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 128

Re: [PATCH v4] fbtft: add tearing signal detect

2021-01-26 Thread carlis
On Tue, 26 Jan 2021 20:51:41 +0300 Dan Carpenter wrote: > On Tue, Jan 26, 2021 at 08:40:35PM +0800, Carlis wrote: > > @@ -82,6 +111,29 @@ enum st7789v_command { > > */ > > static int init_display(struct fbtft_par *par) > > { > > + int rc; > > +

Re: [PATCH v2] fbtft: add tearing signal detect

2021-01-26 Thread carlis
On Tue, 26 Jan 2021 11:17:45 +0300 Dan Carpenter wrote: > On Mon, Jan 25, 2021 at 04:44:12PM +0800, Carlis wrote: > > From: "carlis.zhang_cp" > > I was really expecting that you would fix this and Signed-off-by as > well. > > regards, > dan carpenter >

Re: [PATCH] fbtft: add tearing signal detect

2021-01-26 Thread carlis
On Tue, 26 Jan 2021 10:54:41 +0300 Dan Carpenter wrote: > On Sun, Jan 24, 2021 at 11:35:37PM +0800, Carlis wrote: > > +static irqreturn_t spi_panel_te_handler(int irq, void *data) > > +{ > > + complete(_panel_te); > > + return IRQ_HANDLED; &g

[PATCH v4] fbtft: add tearing signal detect

2021-01-26 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v4:modify some code style and change te irq set function name --- drivers/staging/fbtft/fb_st7789v.c | 128 - drivers/staging/fbtft/fbtft.h

[PATCH v3] fbtft: add tearing signal detect

2021-01-25 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v3:modify author name --- drivers/staging/fbtft/fb_st7789v.c | 134 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 134

[PATCH v2] fbtft: add tearing signal detect

2021-01-25 Thread Carlis
From: "carlis.zhang_cp" For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: carlis.zhang_cp --- v2:add release te gpio after irq request fail --- drivers/staging/fbtft/fb_st7789v.c | 134 - drivers/staging/fbtft/fbtft.h |

[PATCH] fbtft: add tearing signal detect

2021-01-24 Thread Carlis
From: "carlis.zhang_cp" For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: carlis.zhang_cp --- drivers/staging/fbtft/fb_st7789v.c | 133 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 133 insertions(+), 1