On 09.07.20 11:32, Martin Kepplinger wrote:
> hi linux-media people,
>
> TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?
>
>
> I try to use the camera on our librem5-devkit (imx8mq): I try to use
> only mainline drivers except for "mx
hi linux-media people,
TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?
I try to use the camera on our librem5-devkit (imx8mq): I try to use
only mainline drivers except for "mxc-mipi-csi2_yav" taken from
linux-imx (which we can prepare to submit if a PoC works. This is the
realloc() returns NULL in case it fails. Since we don't save the
pointer in question elsewhere, we leak memory by assigning NULL
to the original memory in the heap.
realloc() doesn't free memory in case of failure, so let's do
it manually.
Signed-off-by: Martin Kepplinger <mart...@posteo
This fixes typos in vboxvideo's help text. Most notably, "to builtin
this module" becomes "to build this driver built-in to the kernel".
Signed-off-by: Martin Kepplinger <mart...@posteo.de>
---
revision history
v3: Avoid a repetition of "t
This fixes typos in vboxvideo's help text. Most notably, "to builtin
this module" becomes "to build this driver built-in to the kernel".
Signed-off-by: Martin Kepplinger <mart...@posteo.de>
---
Thanks Dan. I actually also had the feeling that even though it's
This fixes typos in vboxvideo's help text.
Signed-off-by: Martin Kepplinger <mart...@posteo.de>
---
drivers/staging/vboxvideo/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vboxvideo/Kconfig
b/drivers/staging/vboxvideo/Kconfig
index a52746
From: Martin Kepplinger martin.kepplin...@theobroma-systems.com
The MMA8653FC is a low-power, three-axis, capacitive micromachined
accelerometer with 10 bits of resolution with flexible user-programmable
options.
Embedded interrupt functions enable overall power savings, by relieving the
host
;
+ goto free_fw;
for (ii = 0; ii fw-size; ii += FIRMWARE_CHUNK_SIZE) {
length = min_t(int, fw-size - ii, FIRMWARE_CHUNK_SIZE);
looks good to me, although somebody else should review it too. feel free
to add
Reviewed-by: Martin Kepplinger mart...@posteo.de
if applicable
remove a typedef that is not even really used.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
builds in next-20140905.
drivers/staging/rtl8192u/r8192U_core.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
at it.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Yes, there were changes in the meantime. This applies to -next20140808
and builds. thanks.
drivers/staging/rtl8192u/r8192U_core.c | 757 +---
1 file changed, 408 insertions(+), 349 deletions(-)
diff --git a/drivers
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Thanks Dan. And since it continues to succeed if (dev == NULL),
differntiate if (dev) or not.
drivers/staging/media/as102/as102_drv.c | 15
remove dprintk() and replace it with dev_dbg() or pr_debug()
in order to use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Thanks for looking at it. So this doesn't add anything and actually does
what it says. If I haven't understood what you meant
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I don't have the device but this builds.
I think this is ok when it gets reviewed.
applies to -next20140801
drivers/staging/media/as102
-by: Martin Kepplinger mart...@posteo.de
---
This changes only a part of rtl8192u's comments. When this is desired,
one can go about and change the rest of the driver.
build-tested. applies to -next20140801
drivers/staging/rtl8192u/r8180_93cx6.c | 12 +-
drivers/staging/rtl8192u/r8192U_core.c | 757
This fixes sparse errors where 0 is used for non-integers.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
applies to -next20140802
drivers/staging/lustre/lnet/lnet/api-ni.c |4 +-
drivers/staging/lustre/lustre/fld/fld_request.c|2 +-
drivers/staging/lustre/lustre
Fix the sparse error: cast removes address space of expression and
add __user annotation to the driver's ethtool_ioctl().
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Beyond that, how would you include socket.c's ethtool_ioctl() here?
thanks for looking at these tiny changes.
drivers
Fix the sparse error: cast removes address space of expression and
add __user annotation to the driver's ethtool_ioctl().
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I think I forgot to change the declaration on top.
drivers/staging/vt6655/device_main.c |6 +++---
1 file changed
Remove a totally unnecessary typedef and rename it to lowercase.
This is more readable now.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
so in that way, one could change the more heavily used typedefs as well.
thanks for your review.
drivers/staging/vt6655/card.c |2 +-
drivers
Remove a totally unnecessary typedef. This is more readable now.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
applies to next-20140611
drivers/staging/vt6655/card.c |2 +-
drivers/staging/vt6655/device.h |6 +++---
drivers/staging/vt6655/wmgr.c |2 +-
3 files changed
For obvious error messages, use dev_err() in order to provide userspace
with more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
i just waited a week or so. this applies to next-20140516.
greetings from Linuxdays Vienna, Austria
don't reinvent dev_dbg(). use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to next-20140516.
drivers/staging/media/as102/as102_drv.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to next-20140516. any more suggestions?
more cleanup can be done when dprintk() is completely gone.
drivers/staging/media/as102
For obvious error messages, use dev_err() in order to provide userspace
with more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to v3.15-rc4
greetings from Linuxdays Vienna, Austria
drivers/staging/winbond
Don't list elements to initialize. Remaining elements of a partly
initialized array are set to zero. Sparse complained here.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
fix following warning by dynamically allocating memory:
dgnc_tty.c:583:1: warning: the frame size of 1060 bytes is larger than 1024
bytes [-Wframe-larger-than=]
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is more of a question. Is this a desired solution to fixing such a
frame
Am 2014-05-06 15:33, schrieb Dan Carpenter:
On Tue, May 06, 2014 at 02:41:37PM +0200, Martin Kepplinger wrote:
fix following warning by dynamically allocating memory:
dgnc_tty.c:583:1: warning: the frame size of 1060 bytes is larger than 1024
bytes [-Wframe-larger-than=]
Signed-off
Use dev_err() instead of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion
Am 2014-05-05 13:35, schrieb Dan Carpenter:
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
Use dev_err() instead of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Whenever I
Am 2014-05-05 14:36, schrieb Dan Carpenter:
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
Am 2014-05-05 13:35, schrieb Dan Carpenter:
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
Use dev_err() instead of printk() and remove dgnc: from the message
Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
Thus do all locking in main_usb.c and hold it for a insignificantly
shorter period of time. This makes the affected area significantly more
readable though.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I resend https
Shared addresses can be marked as such.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I guess that's what you meant. Thanks for your feedback!
drivers/staging/rtl8821ae/wifi.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/wifi.h b
pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
fixes sparse warnings.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/rtl8821ae/pci.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers
Use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
noise from the eudyptula challenge. applies to next-20140408 as well as
linus' current tree.
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions
33 matches
Mail list logo
