Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
Dan Carpenter writes: > On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: >> @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 >> flags, bool *changed) >> vg->num_vlans++; >> *changed = true; >> } >> +

Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Dan Carpenter
On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: > @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 > flags, bool *changed) > vg->num_vlans++; > *changed = true; > } > + ret =

[PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-28 Thread Petr Machata
A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge