Re: 'C-x 4 a' broken in diff buffer

2007-02-08 Thread Nick Roberts
Hmm... are you sure it worked in Emacs-21? Yes. There has been changes in this part of the code, but IIRC they're fairly minor. And in any case we've never made use of the text added by the -p flag. No, but maybe the text is inadvertantly used in trying to match up the function. If

Re: 'C-x 4 a' broken in diff buffer

2007-02-08 Thread Stefan Monnier
Hmm... are you sure it worked in Emacs-21? Yes. Sure, sure, sure, in the very same circumstances? There has been changes in this part of the code, but IIRC they're fairly minor. And in any case we've never made use of the text added by the -p flag. No, but maybe the text is inadvertantly

Re: 'C-x 4 a' broken in diff buffer

2007-02-08 Thread Nick Roberts
Stefan Monnier writes: Hmm... are you sure it worked in Emacs-21? Yes. Sure, sure, sure, in the very same circumstances? You seem sceptical. There has been changes in this part of the code, but IIRC they're fairly minor. And in any case we've never made use of the text added by

Re: 'C-x 4 a' broken in diff buffer

2007-02-08 Thread Nick Roberts
PS: There was still a bug that I just fixed, which may explain what you were seeing, although in my case it manifested itself by signalling an error rather than silently ignoring the function name. Could be due to local changes. It looks good now. I think this last change

'C-x 4 a' broken in diff buffer

2007-02-07 Thread Nick Roberts
This change breaks 'C-x 4 a' (add-change-log-entry-other-window) when used in a diff (*vc-diff*) buffer: revision 1.94 date: 2007-01-11 16:52:59 +; author: monnier; state: Exp; lines: +83 -1 (diff-sanity-check-context-hunk-half, diff-sanity-check-hunk): New functions.

Re: 'C-x 4 a' broken in diff buffer

2007-02-07 Thread Stefan Monnier
This change breaks 'C-x 4 a' (add-change-log-entry-other-window) when used in a diff (*vc-diff*) buffer: revision 1.94 date: 2007-01-11 16:52:59 +; author: monnier; state: Exp; lines: +83 -1 (diff-sanity-check-context-hunk-half, diff-sanity-check-hunk): New functions.

Re: 'C-x 4 a' broken in diff buffer

2007-02-07 Thread Nick Roberts
ISTR it also fails for changed functions (not just added ones). I believe Per has fixed this very bug earlier today. Well it doesn't seem to supply a function with -cp any longer. Also I notice that when it does find a function e.g with -c, it's often the wrong one, but I think this

Re: 'C-x 4 a' broken in diff buffer

2007-02-07 Thread Nick Roberts
ISTR it also fails for changed functions (not just added ones). I believe Per has fixed this very bug earlier today. Well it doesn't seem to supply a function with -cp any longer. Also I notice that when it does find a function e.g with -c, it's often the wrong one, but I think

Re: 'C-x 4 a' broken in diff buffer

2007-02-07 Thread Stefan Monnier
*** With arg, use separate IO iff arg is pos which, as we've said before, is not reliable for languages other than C. I find that, with the above value of diff-switches, 'C-x 4 a' fails to identify a function to put in