Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check both vendor and PCI IDs

On Vr, 2024-03-08 at 15:13 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Otherwise the derived device and the source device might have different > PCI ID or vendor ID in a multiple-device system. > > Signed-off-by: Haihao Xiang > --- >  libavutil/hwcontext_vulkan.c | 31

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/get_buffer: Add a warning on failed allocation from a fixed pool

On So, 2024-03-17 at 20:51 +, Mark Thompson wrote: > For hardware cases where we are forced to have a fixed pool of frames > allocated up-front (such as array textures on decoder output), suggest > a possible workaround to the user if an allocation fails because the > pool is exhausted. > ---

Re: [FFmpeg-devel] [PATCH v3 1/2] ffmpeg: set extra_hw_frames to account for frames held in queues

On So, 2024-03-17 at 20:49 +, Mark Thompson wrote: > Since e0da916b8f5b079a4865eef7f64863f50785463d the ffmpeg utility has > held multiple frames output by the decoder in internal queues without > telling the decoder that it is going to do so.  When the decoder has a > fixed-size pool of

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

Mar 17, 2024, 16:36 by s...@jkqxz.net: > On 13/03/2024 16:38, Lynne wrote: > >> Tested by multiple users on multiple operating systems, >> driver implementations and test samples to work. >> >> Co-Authored-by: Dave Airlie >> >> From e2d31951f46fcc10e1263b8603e486e111e9578c Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile

On Fri, 2024-03-15 at 02:22 +, Xiang, Haihao wrote: > On Vr, 2024-03-08 at 16:47 +0800, fei.w.wang-at-intel@ffmpeg.org > wrote: > > From: Fei Wang > > > > According to Table A.2 in spec. > > > > Signed-off-by: Fei Wang > > --- > > libavcodec/vaapi_encode_h265.c | 181

[FFmpeg-devel] [PATCH v3 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile

From: Fei Wang According to Table A.2 in spec. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_h265.c | 176 +++-- 1 file changed, 123 insertions(+), 53 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index

[FFmpeg-devel] [PATCH v3 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile

From: Fei Wang There is no Main8/10 profile defined in HEVC REXT profiles. Use Main12 which is compatible with 8/10bit. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_h265.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

Le 17 mars 2024 18:21:23 GMT-07:00, Timo Rothenpieler a écrit : >On 18.03.2024 01:32, Rémi Denis-Courmont wrote: >> >> >> Le 17 mars 2024 14:13:18 GMT-07:00, Timo Rothenpieler >> a écrit : >>> On 17.03.2024 18:37, Rémi Denis-Courmont wrote: Le 17 mars 2024 10:29:39

Re: [FFmpeg-devel] [RFC PATCH] avformat/rtpdec: Audio level RTP extension RFC6464

On Sat, Feb 10, 2024, at 9:30 PM, j...@jonb.org wrote: > From: Jonathan Baudanza > > libwebrtc will add audio level (in decibels) and VAD status to each RTP > packet. > > This patch will add both values to the packet sidedata. > > I've been using this patch in production for about a year on

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

On 18.03.2024 01:32, Rémi Denis-Courmont wrote: Le 17 mars 2024 14:13:18 GMT-07:00, Timo Rothenpieler a écrit : On 17.03.2024 18:37, Rémi Denis-Courmont wrote: Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt a écrit : Rémi Denis-Courmont: Le 16 mars 2024 13:58:23 GMT-07:00,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/aeadec: Export title

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aeadec.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/aeadec.c b/libavformat/aeadec.c > index 4cb2da6639..20170a89b3 100644 > --- a/libavformat/aeadec.c > +++

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

Le 17 mars 2024 14:13:18 GMT-07:00, Timo Rothenpieler a écrit : >On 17.03.2024 18:37, Rémi Denis-Courmont wrote: >> >> >> Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt >> a écrit : >>> Rémi Denis-Courmont: Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a

Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: respect channel order when parsing and creating chan atom

On Mon, 18 Mar 2024, Andreas Rheinhardt wrote: Marton Balint: Previously we always assumed that the channels are in native order, even if they were not. The new channel layout API allows us to signal the proper channel order, so let's do so. Fixes ticket #98. --- libavformat/mov_chan.c |

Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: respect channel order when parsing and creating chan atom

Marton Balint: > Previously we always assumed that the channels are in native order, even if > they were not. The new channel layout API allows us to signal the proper > channel order, so let's do so. > > Fixes ticket #98. > --- > libavformat/mov_chan.c | 464

Re: [FFmpeg-devel] [PATCH] change av_ts_make_time_string precision

On Wed, 13 Mar 2024, Allan Cady via ffmpeg-devel wrote: On Tuesday, March 12, 2024 at 02:24:47 PM PDT, Marton Balint wrote: On Tue, 12 Mar 2024, Allan Cady via ffmpeg-devel wrote: On Monday, March 11, 2024 at 12:11:45 PM PDT, Marton Balint wrote: On Mon, 11 Mar 2024, Andreas Rheinhardt

[FFmpeg-devel] [PATCH] avutil/timestamp: keep microsecond precision in av_ts_make_time_string

av_ts_make_time_string() used "%.6g" format in the past, but this format was losing precision even when the timestamp to be printed was not that large. For example for 3 hours (10800) seconds, only 1 decimal digit was printed, which made this format inaccurate when it was used in e.g. the

Re: [FFmpeg-devel] [PATCH v4 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

On Sun, Mar 17, 2024 at 11:38 PM Andreas Rheinhardt wrote: > > Matthieu Bouron: > > This will allow users to pass the Android ApplicationContext which is > > mandatory > > to retrieve the ContentResolver responsible to resolve/open Android > > content-uri. > > --- > > doc/APIchanges | 3 +++

Re: [FFmpeg-devel] [PATCH v4 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

Matthieu Bouron: > This will allow users to pass the Android ApplicationContext which is > mandatory > to retrieve the ContentResolver responsible to resolve/open Android > content-uri. > --- > doc/APIchanges | 3 +++ > libavcodec/jni.c | 42 ++ >

Re: [FFmpeg-devel] [PATCH v2 2/6] avformat: add Android content resolver protocol support

On Sun, Mar 17, 2024 at 12:33:04PM +0800, Zhao Zhili wrote: > Sorry for the long delay of review. > > > On Mar 5, 2024, at 03:37, Matthieu Bouron wrote: > > > > On Tue, Feb 27, 2024 at 03:50:38PM +0100, Matthieu Bouron wrote: > >> Handles Android content-uri starting with content://. > >> --- >

[FFmpeg-devel] [PATCH v4 6/6] avcodec/mediacodec_wrapper: remove unnecessary NULL checks before calling Delete{Global, Local}Ref()

Delete{Global,Local}Ref already handle NULL. --- libavcodec/mediacodec_wrapper.c | 189 1 file changed, 47 insertions(+), 142 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 78cd28f53d..306359071e 100644 ---

[FFmpeg-devel] [PATCH v4 5/6] avcodec/mediacodec_wrapper: use an OFFSET() macro where relevant

Reduces a bit the horizontal spacing. --- libavcodec/mediacodec_wrapper.c | 138 +--- 1 file changed, 72 insertions(+), 66 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 0880ddd3ef..78cd28f53d 100644 ---

[FFmpeg-devel] [PATCH v4 4/6] avcodec/jni: remove unnecessary NULL checks before calling DeleteLocalRef()

Delete{Global,Local}Ref() already handle NULL. --- libavcodec/ffjni.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavcodec/ffjni.c b/libavcodec/ffjni.c index e3cf24d3e2..69d9a9faa3 100644 --- a/libavcodec/ffjni.c +++ b/libavcodec/ffjni.c @@ -236,17 +236,9

[FFmpeg-devel] [PATCH v4 3/6] avcodec/jni: use size_t to store structure offsets

--- libavcodec/ffjni.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffjni.h b/libavcodec/ffjni.h index 6027bac0ab..d1e86f8329 100644 --- a/libavcodec/ffjni.h +++ b/libavcodec/ffjni.h @@ -24,6 +24,7 @@ #define AVCODEC_FFJNI_H #include +#include /* *

[FFmpeg-devel] [PATCH v4 2/6] avformat: add Android content resolver protocol support

Handles Android content-uri starting with content://. --- configure | 2 + libavcodec/jni.c| 1 + libavformat/Makefile| 1 + libavformat/file.c | 160 libavformat/protocols.c | 1 + 5 files changed, 165 insertions(+)

[FFmpeg-devel] [PATCH v4 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

This will allow users to pass the Android ApplicationContext which is mandatory to retrieve the ContentResolver responsible to resolve/open Android content-uri. --- doc/APIchanges | 3 +++ libavcodec/jni.c | 42 ++ libavcodec/jni.h | 17 +

[FFmpeg-devel] Add protocol for Android content providers (v4)

Diff with previous iteration: - rebaed on latest master - applied feedback from Zhao (removed HAVE_SETMODE block, use a typedef struct, check that the fd is seekable, moved doc/APIChanges changes to the right commit) ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

I fixed it on my dev machine by renaming the function in libbluray and creating a new lib. I still think that this is a temporary hack and should be fixed properly. I've opened an issue with libbluray, so I hope that I'll get a reply at one point. I'm still not entirely sure who actually

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

On 17.03.2024 18:37, Rémi Denis-Courmont wrote: Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt a écrit : Rémi Denis-Courmont: Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : Seems the conflict comes from

[FFmpeg-devel] [PATCH v3 2/2] lavc/get_buffer: Add a warning on failed allocation from a fixed pool

For hardware cases where we are forced to have a fixed pool of frames allocated up-front (such as array textures on decoder output), suggest a possible workaround to the user if an allocation fails because the pool is exhausted. --- Perhaps helpful; any thoughts? The warning comes out before any

[FFmpeg-devel] [PATCH v3 1/2] ffmpeg: set extra_hw_frames to account for frames held in queues

Since e0da916b8f5b079a4865eef7f64863f50785463d the ffmpeg utility has held multiple frames output by the decoder in internal queues without telling the decoder that it is going to do so. When the decoder has a fixed-size pool of frames (common in some hardware APIs where the output frames must

[FFmpeg-devel] [PATCH v9 14/14] avcodec/libx265: add support for writing out CLL and MDCV

The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89

[FFmpeg-devel] [PATCH v9 13/14] avcodec/libx264: add support for writing out CLL and MDCV

Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v9 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v9 11/14] ffmpeg: pass first video AVFrame's side data to encoder

This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v9 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 31 +++ libavcodec/avcodec.h | 21 + 2 files changed, 52 insertions(+) diff --git

[FFmpeg-devel] [PATCH v9 09/14] avcodec: add frame side data array to AVCodecContext

This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 12 libavcodec/options.c | 2 ++ 2 files changed, 14 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 554501aa44..550df0e589 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH v9 08/14] avutil/frame: add helper for getting side data from array

--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 30db83a5e5..47ecd964b8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@

[FFmpeg-devel] [PATCH v9 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 46f976a3ed..30db83a5e5

[FFmpeg-devel] [PATCH v9 06/14] avutil/frame: add helper for adding existing side data to array

--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4074391a92..46f976a3ed 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v9 05/14] avutil/frame: add helper for adding side data to array

Additionally, add an API test to check that the no-duplicates addition works after duplicates have been inserted. --- libavutil/Makefile | 1 + libavutil/frame.c | 17 ++ libavutil/frame.h | 22 +++ libavutil/tests/side_data_set.c | 103

[FFmpeg-devel] [PATCH v9 04/14] avutil/frame: split side data removal out to non-AVFrame function

This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9ebe830c5c..dd27456031 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v9 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..9ebe830c5c 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef

[FFmpeg-devel] [PATCH v9 02/14] avutil/frame: add helper for freeing arrays of side data

--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void

[FFmpeg-devel] [PATCH v9 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v9 00/14] encoder AVCodecContext configuration side data

Differences to v8: 1. rebased on top of current master 2. Applied changes based on comments done regarding the AVCodecContext, such as added details to the docstring as well as renaming the variable to `encoder_side_data` (ref:

[FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts

- Only parse the defined masks in dwChannelMask, unless strict_std_compliance is less than normal. This matches with the behaviour of the wav muxer. - Ignore additional bits in dwChannelMasks as the MS documentation suggests [1] - Assume UNKNOWN channels for missing bits as the MS documentation

[FFmpeg-devel] [PATCH 1/2] avformat/riff: pass an AVFormatContext explicitly to ff_get_wav_header

Will be useful later. --- libavformat/riff.h| 2 +- libavformat/riffdec.c | 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/riff.h b/libavformat/riff.h index a93eadfeca..719fd7a17d 100644 --- a/libavformat/riff.h +++ b/libavformat/riff.h @@

[FFmpeg-devel] [PATCH] avformat/mov_chan: respect channel order when parsing and creating chan atom

Previously we always assumed that the channels are in native order, even if they were not. The new channel layout API allows us to signal the proper channel order, so let's do so. Fixes ticket #98. --- libavformat/mov_chan.c | 464 +++-- 1 file changed, 211

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

On 2024-03-17 08:10, Timo Rothenpieler wrote It only breaks when statically linking. The symbol is not exported by libbr. In this case the only fix is to use a prefix in libbr, and who knows whether they will do that. I opened an issue with them but haven't received a reply yet. Just

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt a écrit : >Rémi Denis-Courmont: >> >> >> Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : Seems the conflict comes from

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

Mar 17, 2024, 16:36 by s...@jkqxz.net: > On 13/03/2024 16:38, Lynne wrote: > >> Tested by multiple users on multiple operating systems, >> driver implementations and test samples to work. >> >> Co-Authored-by: Dave Airlie >> >> From e2d31951f46fcc10e1263b8603e486e111e9578c Mon Sep 17 00:00:00

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

Rémi Denis-Courmont: > > > Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : >>> Seems the conflict comes from >>> https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 >>> and >>>

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : >> Seems the conflict comes from >> https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 >> and >> https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c15f1239f1f16816749a7fd3b6 >>

Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Update AMF encoder options

On 14/03/2024 10:51, Araz Iusubov wrote: The encoder options have been updated to the current version of the AMF. Signed-off-by: Araz Iusubov --- libavcodec/amfenc.c | 1 + libavcodec/amfenc.h | 4 + libavcodec/amfenc_av1.c | 154 +-

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h

ping flow gg 于2024年3月3日周日 23:03写道： > Sorry since I did not send the emails all at once, so cannot apply all 4 > patches together with git am *.patch. Instead, it needs to first apply the > patch with 'git am '[PATCH] lavc/vp8dsp: R-V V put_vp8_pixels'', and then > apply the patches 1-3 in the

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

On 13/03/2024 16:38, Lynne wrote: Tested by multiple users on multiple operating systems, driver implementations and test samples to work. Co-Authored-by: Dave Airlie > From e2d31951f46fcc10e1263b8603e486e111e9578c Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Fri, 19 Jan 2024 10:49:02

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dem_fuzzer: add libavformat/demux.h

Michael Niedermayer: > needed for FFInputFormat > > Signed-off-by: Michael Niedermayer > --- > tools/target_dem_fuzzer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c > index 76eed9f6a2..fe69eb9be0 100644 > ---

Re: [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d11va: add logging to dxgi debug interfaces

On 14.03.2024 22:26, Timo Rothenpieler wrote: --- libavutil/hwcontext_d3d11va.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 1b96c38d25..e30c8fc238 100644 --- a/libavutil/hwcontext_d3d11va.c

Re: [FFmpeg-devel] [PATCH 1/3] fate/lavf-audio: Test writing AIFF-native tags

Andreas Rheinhardt: > In particular, test writing tags with odd strlen. > (These tags are zero-padded to even size.) > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate/lavf-audio.mak | 1 + > tests/ref/lavf/aiff | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] avutil/hash: Avoid relocations for hash names

Andreas Rheinhardt: > These strings are so short (longest takes 11B) that using > pointers is wasteful. Avoiding them also moves hashdesc > into .rodata (from .data.rel.ro). > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/hash.c | 71 +++- > 1

Re: [FFmpeg-devel] [PATCH] avcodec/mips/aaccoder_mips: Remove MIPS-specific aaccoder

Andreas Rheinhardt: > ff_aac_coder_init_mips() modifies a static const structure of > function pointers. This will crash if the binary uses relro > and is a data race in any case. > > Furthermore it points to a maintainability issue: The > AACCoefficientsEncoder structures have been constified >

Re: [FFmpeg-devel] [PATCH] avformat/crypto: Avoid cast, use proper printf specifier

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/crypto.c b/libavformat/crypto.c > index 75b00020bc..4393fb6399 100644 > --- a/libavformat/crypto.c > +++

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Use static_assert instead of _Static_assert

Andreas Rheinhardt: > The latter is not supported by MSVC 19.27. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ccaption_dec.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index

Re: [FFmpeg-devel] [PATCH] avformat/aeaenc: Fix printf-specifier

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aeaenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/aeaenc.c b/libavformat/aeaenc.c > index 65d018c844..495e98c6a2 100644 > --- a/libavformat/aeaenc.c > +++

Re: [FFmpeg-devel] [PATCH] avutil/x86util: Fix broken pre-SSE4.1 PMINSD emulation

On Sun, Mar 17, 2024 at 1:44 PM James Almer wrote: > LGTM. I wonder why we even added a float based fallback for this. Thanks, pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH v2 9/9] avformat/pcm: decrease target audio frame per sec to 10

On Thu, Mar 14, 2024 at 11:30 PM Marton Balint wrote: > > > On Thu, 14 Mar 2024, Paul B Mahol wrote: > > > This is just ugly hack for workaround around broken ffmpeg threading. > > This actually improves single threaded performance as well, check it with > ffprobe if you want. Sure, the reason I

Re: [FFmpeg-devel] [PATCH] avutil/x86util: Fix broken pre-SSE4.1 PMINSD emulation

On 3/17/2024 9:27 AM, Henrik Gramner via ffmpeg-devel wrote: Fixes yadif-16 which allows FATE to pass. Broken since 2904db90458a1253e4aea6844ba9a59ac11923b6 (2017). LGTM. I wonder why we even added a float based fallback for this. ___ ffmpeg-devel

[FFmpeg-devel] [PATCH] avutil/x86util: Fix broken pre-SSE4.1 PMINSD emulation

Fixes yadif-16 which allows FATE to pass. Broken since 2904db90458a1253e4aea6844ba9a59ac11923b6 (2017). pminsd_emulation.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

On 17.03.2024 09:05, Gnattu OC via ffmpeg-devel wrote: Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? It only breaks when statically

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? > On Mar 17, 2024, at 05:09, Helmut K. C. Tessarek wrote: > > Hi, > > On 2024-03-16 10:26,