[FFmpeg-devel] [PATCH] avcodec/proresdec2: Rename to proresdec

2024-03-29 Thread Andreas Rheinhardt
Once upon a time, there used to be a LGPL and a GPL ProRes decoder in FFmpeg; the current decoder evolved from the second of these. But given that it is now the only ProRes decoder we have, it's file should simply be named proresdec.c (which also brings it in line with its header). Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Don't free AVOpt-strings manually, fix crash

2024-03-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Besides being redundant, freeing manually is actually harmful here, > as rtmp_close() may call gen_fcunpublish_stream() which dereferences > rt->playpath. > > Reported-by: Armin Hasitzka > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rtmpproto.c | 3 --- > 1 file

[FFmpeg-devel] [PATCH v2 12/12] avcodec/vlc: Use union of uint8_t and uint16_t in VLC_MULTI_ELEM

2024-03-29 Thread Andreas Rheinhardt
It is more natural and simplifies writing these arrays. Signed-off-by: Andreas Rheinhardt --- libavcodec/bitstream_template.h | 2 +- libavcodec/vlc.c| 10 +- libavcodec/vlc.h| 5 - 3 files changed, 10 insertions(+), 7 deletions(-) diff --git

[FFmpeg-devel] [PATCH 12/12] avcodec/vlc: Use union of uint8_t and uint16_t in VLC_MULTI_ELEM

2024-03-29 Thread Andreas Rheinhardt
It is more natural and simplifies writing these arrays. Signed-off-by: Andreas Rheinhardt --- libavcodec/bitstream_template.h | 2 +- libavcodec/vlc.c| 8 libavcodec/vlc.h| 5 - 3 files changed, 9 insertions(+), 6 deletions(-) diff --git

[FFmpeg-devel] [PATCH 11/12] avcodec/vlc, bitstream: Fix multi VLC with uint8_t syms on BE

2024-03-29 Thread Andreas Rheinhardt
VLC_MULTI_ELEM contains an uint8_t array that is supposed to be treated as an array of uint16_t when the used symbols have a size of two; otherwise it should be treated as just an array of uint8_t, but it was not always treated that way: vlc_multi_gen() initialized the first entry of the array by

[FFmpeg-devel] [PATCH 10/12] fate/fits: Fix tests on BE

2024-03-29 Thread Andreas Rheinhardt
The fits decoder decodes to native pixel formats; so the fitsdec-gbrap16be fate test failed on BE despite its name because the reference file is LE. This patch fixes this by forcing a pixel format; the forced pixel format is BE, causing a change in the reference file. The fitsdec-gbrp16be test was

Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR

2024-03-29 Thread Michael Niedermayer
On Fri, Mar 29, 2024 at 09:35:09AM +0100, Anton Khirnov wrote: > --- > libavformat/movenc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) can you add a fate test for this ? its odd we have no single test that changes from this thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-29 Thread Michael Niedermayer
On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote: [...] > +static int rcwt_probe(const AVProbeData *p) > +{ > +return p->buf_size > RCWT_HEADER_SIZE && > + AV_RB16(p->buf) == 0x&& > + AV_RB8(p->buf + 2) == 0xED && > + AV_RB16(p->buf +

[FFmpeg-devel] [PATCH 1/2] lavf/subtitles: Add ff_text_peek_r16(), only accept \r, \n, \r\n and \r\r\n line endings

2024-03-29 Thread Tomas Härdin
Here's an alternative first patch that rolls patch 1+3 into one. I'd like some feedback on this before I continue hacking on patch 2. While I don't like that we accept any old broken srt file, especially without knowing what software made it, I'm not completely opposed to compromising in this

Re: [FFmpeg-devel] [PATCH 2/3] lavf/srtdec: Permit streaming input

2024-03-29 Thread Tomas Härdin
lör 2024-03-30 klockan 00:35 +0100 skrev Michael Niedermayer: > On Thu, Mar 28, 2024 at 11:57:57PM +0100, Tomas Härdin wrote: > > Here as well > > >  libavformat/srtdec.c |  211 -- > > - > >  tests/ref/fate/sub-srt-rrn-remux |    4 > >  2 files

Re: [FFmpeg-devel] [PATCH] doc/muxers: add stub for iamf

2024-03-29 Thread Michael Niedermayer
On Fri, Mar 29, 2024 at 12:47:53PM +0100, Stefano Sabatini wrote: > --- > doc/muxers.texi | 16 > 1 file changed, 16 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index f300f8c45f..23506e2ab7 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@

Re: [FFmpeg-devel] [PATCH 2/3] lavf/srtdec: Permit streaming input

2024-03-29 Thread Michael Niedermayer
On Thu, Mar 28, 2024 at 11:57:57PM +0100, Tomas Härdin wrote: > Here as well > libavformat/srtdec.c | 211 > --- > tests/ref/fate/sub-srt-rrn-remux |4 > 2 files changed, 116 insertions(+), 99 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: fix overriding unknown channel layouts with negotiated one

2024-03-29 Thread Marton Balint
On Sat, 23 Mar 2024, Marton Balint wrote: Fixes ffplay playback of unknown layouts, when SDL directly supports the audio format, such as: ffplay -f lavfi anullsrc=cl=2C,aformat=s16 Without the patch, "Channel layout change is not supported" errors are generated because buffersrc (unknown 2

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_refs: Rewrite code to make control flow clearer

2024-03-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > While this change IMO makes the control flow clearer > for the human reader, it is especially important for > GCC: It erroneously believes that it is possible to > enter the SHORT2(UNUSED|LONG) cases without having > entered the preceding block that initializes pic, >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-29 Thread Michael Niedermayer
On Fri, Mar 29, 2024 at 12:39:31PM +0100, Anton Khirnov wrote: > [...] if you have not voted yet please do so ASAP. +1 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater

[FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Check first case of offset_temp computation for overflow

2024-03-29 Thread Michael Niedermayer
This is kind of ugly Fixes: signed integer overflow: 255 * 1157565362826411919 cannot be represented in type 'long' Fixes: 67313/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6250434245230592 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000htdec: warn about non zero roi shift

2024-03-29 Thread Michael Niedermayer
Suggested-by: Tomas Härdin Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000htdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index 6b9898d3ff2..4f0b10b4293 100644 --- a/libavcodec/jpeg2000htdec.c +++

[FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Check magp before using it in a shift

2024-03-29 Thread Michael Niedermayer
Fixes: shift exponent -1 is negative Fixes: 65378/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5457678193197056 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-29 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > With free licensed code, I don't think that will happen; the core algorithm > is the same. > LC3 is like a subset of LC3plus, but also adds 7.5ms frame duration. > I acknowledged the use of only one Codec Id, because it makes sense to me > to distinguish both as

[FFmpeg-devel] [PATCH v2 9/9] fate/filter-video: Insert scale, format filters in filter-yadif, bwdif10

2024-03-29 Thread Andreas Rheinhardt
The format and the first scale filter ensures that the filter processing actually happens in high bit depth; the second scale filter is only necessary for big endian arches. Signed-off-by: Andreas Rheinhardt --- tests/fate/filter-video.mak | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-29 Thread Antoine Soulier via ffmpeg-devel
With free licensed code, I don't think that will happen; the core algorithm is the same. LC3 is like a subset of LC3plus, but also adds 7.5ms frame duration. I acknowledged the use of only one Codec Id, because it makes sense to me to distinguish both as different profiles / feature sets.

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-03-29 Thread Jan Ekström
On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi > Profile 5. Profile 5 can thus now be represented in VUI as > {AVCOL_RANGE_JPEG, AVCOL_PRI_BT2020, AVCOL_TRC_SMPTE2084, >AVCOL_SPC_IPT_C2, AVCHROMA_LOC_LEFT} (although

[FFmpeg-devel] [PATCH 9/9] fate/filter-video: Insert scale, format filters in filter-yadif tests

2024-03-29 Thread Andreas Rheinhardt
The format and the first scale filter ensures that the filter processing actually happens in high bit depth; the second scale filter is only necessary for big endian arches. Signed-off-by: Andreas Rheinhardt --- tests/fate/filter-video.mak | 4 ++-- 1 file changed, 2 insertions(+), 2

[FFmpeg-devel] [PATCH 8/8] fate/filter-video: Always use little endian pixel format

2024-03-29 Thread Andreas Rheinhardt
Fixes filter-metadata-signalstats-yuv420p10 on BE arches. Signed-off-by: Andreas Rheinhardt --- tests/fate/filter-video.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index ee9f0f5e40..681cddc33e 100644 ---

[FFmpeg-devel] [PATCH 7/7] fate/video: Only use bitexact IDCT in avid meridian

2024-03-29 Thread Andreas Rheinhardt
Precludes the usage of the altivec IDCT which fixes the avid-meridian FATE test on ppc64be here. Signed-off-by: Andreas Rheinhardt --- tests/fate/video.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/video.mak b/tests/fate/video.mak index

Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-29 Thread Marth64
Tomas Härdin : > once I get my srtdec patchset through there will > be something to follow. I see the patch now. I agree, this looks like a good step. Thank you! > Nah it can be done at a later point as an enhancement if you prefer Yes, please. I am happy to do it, but I think will be smoother to

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-29 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > --- > Changelog | 4 + > configure | 6 ++

Re: [FFmpeg-devel] [PATCH v2] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread James Almer
On 3/29/2024 2:28 PM, Andreas Rheinhardt wrote: James Almer: Allocate it instead, and use it to compare sets instead of the parsed struct. Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 127 +++ libavcodec/hevc_ps.h | 14 +++-- 2 files

Re: [FFmpeg-devel] [PATCH 3/4] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-29 Thread Antoine Soulier via ffmpeg-devel
You're right, I was not aware at all. I have pushed a patch that does the job. PTAL, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-29 Thread Antoine Soulier via ffmpeg-devel
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for test purpose. This is the format implemented here. Signed-off-by: Antoine Soulier --- Changelog| 1 + doc/muxers.texi | 6 ++ libavformat/Makefile | 2 + libavformat/allformats.c | 2 +

[FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-29 Thread Antoine Soulier via ffmpeg-devel
The LC3 audio codec is the default codec of Bluetooth LE audio. This is a wrapper over the liblc3 library (https://github.com/google/liblc3). Signed-off-by: Antoine Soulier --- Changelog | 4 + configure | 6 ++ doc/encoders.texi | 57

Re: [FFmpeg-devel] [PATCH v2] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread Andreas Rheinhardt
James Almer: > Allocate it instead, and use it to compare sets instead of the parsed struct. > > Signed-off-by: James Almer > --- > libavcodec/hevc_ps.c | 127 +++ > libavcodec/hevc_ps.h | 14 +++-- > 2 files changed, 77 insertions(+), 64 deletions(-) >

Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-29 Thread Tomas Härdin
fre 2024-03-29 klockan 09:28 -0500 skrev Marth64: > Tomas Härdin: > > Can we please get away from this way of reading subtitles? Every > > other > > type of media (audio, video) are capable of being streamed, but not > > subtitles, precisely because all of them do all parsing in the > >

[FFmpeg-devel] [PATCH v2] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread James Almer
Allocate it instead, and use it to compare sets instead of the parsed struct. Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 127 +++ libavcodec/hevc_ps.h | 14 +++-- 2 files changed, 77 insertions(+), 64 deletions(-) diff --git

[FFmpeg-devel] [PATCH 6/6] fate/image: Fix EXR tests on big endian

2024-03-29 Thread Andreas Rheinhardt
These tests need a scale filter to convert to the prescribed pixel format (the native format is endian-dependent). Signed-off-by: Andreas Rheinhardt --- And now I will deduplicate this mess... tests/fate/image.mak | 150 +-- 1 file changed, 75

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Mark Thompson
On 29/03/2024 15:58, Andreas Rheinhardt wrote: Mark Thompson: On 29/03/2024 14:00, Andreas Rheinhardt wrote: James Almer: On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points

Re: [FFmpeg-devel] [PATCH] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread Andreas Rheinhardt
James Almer: > On 3/29/2024 1:10 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Allocate it instead, and use it to compare sets instead of the parsed >>> struct. >>> >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/hevc_ps.c | 84 ++-- >>>  

Re: [FFmpeg-devel] [PATCH] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread James Almer
On 3/29/2024 1:10 PM, Andreas Rheinhardt wrote: James Almer: Allocate it instead, and use it to compare sets instead of the parsed struct. Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 84 ++-- libavcodec/hevc_ps.h | 14 +--- 2 files

Re: [FFmpeg-devel] [PATCH] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread Andreas Rheinhardt
James Almer: > Allocate it instead, and use it to compare sets instead of the parsed struct. > > Signed-off-by: James Almer > --- > libavcodec/hevc_ps.c | 84 ++-- > libavcodec/hevc_ps.h | 14 +--- > 2 files changed, 51 insertions(+), 47 deletions(-)

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Andreas Rheinhardt
Mark Thompson: > On 29/03/2024 14:00, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > HEVCHdrParams* receives a pointer which points to a dynamically >

[FFmpeg-devel] [PATCH] avocdec/hevc_ps: don't use a fixed sized buffer for parameter set raw data

2024-03-29 Thread James Almer
Allocate it instead, and use it to compare sets instead of the parsed struct. Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 84 ++-- libavcodec/hevc_ps.h | 14 +--- 2 files changed, 51 insertions(+), 47 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Mark Thompson
On 29/03/2024 14:00, Andreas Rheinhardt wrote: James Almer: On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp

[FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_setparams: Add timeline support

2024-03-29 Thread Nicolas Gaullier
This is helpful at least for test purposes. --- libavfilter/vf_setparams.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c index c96f4d314b..1b5eb70344 100644 --- a/libavfilter/vf_setparams.c +++

[FFmpeg-devel] [PATCH v2 0/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-03-29 Thread Nicolas Gaullier
I thought the issue was fixed with b89ee26539 but it is not. Note that I have introduced timeline support in vf_setparams in order to make testing easier. v2: fixed color_range pass-through Nicolas Gaullier (2): avfilter/vf_setparams: Add timeline support avfilter/vf_colorspace: Use

[FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_colorspace: Use colorspace negotiation API

2024-03-29 Thread Nicolas Gaullier
Fixes a regression due to the fact that the colorspace filter does not use the new API introduced by 8c7934f73ab6c568acaa. The scale filter uses it since 45e09a30419cc2a7251e, and the setparams filter since 3bf80df3ccd32aed23f0. Example 1 - color_range specified and chained with scale filter:

Re: [FFmpeg-devel] [PATCH v3] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread James Almer
On 3/29/2024 12:31 PM, tong1...@intel.com wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Reviewed-by:

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of James >Almer >Sent: Friday, March 29, 2024 11:18 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >On 3/29/2024 12:13 PM, tong1.wu-at-intel@ffmpeg.org wrote: >> From:

[FFmpeg-devel] [PATCH v3] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread tong1 . wu-at-intel . com
From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Reviewed-by: James Almer Signed-off-by: Tong Wu ---

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread James Almer
On 3/29/2024 12:13 PM, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0).

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of James >Almer >Sent: Friday, March 29, 2024 8:46 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >On 3/28/2024 10:15 AM, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu

[FFmpeg-devel] [PATCH v2] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread tong1 . wu-at-intel . com
From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Signed-off-by: Tong Wu --- libavcodec/hevc_ps.c | 22

Re: [FFmpeg-devel] [PATCH 07/18] swscale/swscale_internal: Only include altivec header iff HAVE_ALTIVEC

2024-03-29 Thread Sean McGovern
Andreas: On Thu, Mar 28, 2024 at 7:11 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > libswscale/swscale_internal.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h > index abeebbb002..2f6cc70946

Re: [FFmpeg-devel] [PATCH 06/18] postproc/postprocess: Don't generally include arch-specific headers

2024-03-29 Thread Sean McGovern
Andreas: On Thu, Mar 28, 2024 at 7:11 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > libpostproc/postprocess.c | 3 ++- > libpostproc/postprocess_template.c | 5 - > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of >Andreas Rheinhardt >Sent: Friday, March 29, 2024 10:03 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >Mark Thompson: >> On 28/03/2024 13:15,

Re: [FFmpeg-devel] [PATCH 2/5] fate/ffmpeg: Explicitly set pix fmt for sub2video tests

2024-03-29 Thread Andreas Rheinhardt
Sean McGovern: > Hi, > > > On Thu, Mar 28, 2024, 23:24 Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Otherwise the test would use bgra on little endian and argb >> on big endian. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> tests/fate/ffmpeg.mak | 4 ++-- >> 1 file

Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-29 Thread Marth64
Tomas Härdin: > Can we please get away from this way of reading subtitles? Every other > type of media (audio, video) are capable of being streamed, but not > subtitles, precisely because all of them do all parsing in the > read_header() call. We have a perfectly good generic index and seeking >

Re: [FFmpeg-devel] [PATCH 2/5] fate/ffmpeg: Explicitly set pix fmt for sub2video tests

2024-03-29 Thread Sean McGovern
Hi, On Thu, Mar 28, 2024, 23:24 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Otherwise the test would use bgra on little endian and argb > on big endian. > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate/ffmpeg.mak | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Andreas Rheinhardt
Mark Thompson: > On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu >> >> HEVCHdrParams* receives a pointer which points to a dynamically >> allocated memory block. It causes the memcmp always returning 1. >> Add a function to do the comparision. A condition is also

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Andreas Rheinhardt
James Almer: > On 3/29/2024 10:10 AM, Mark Thompson wrote: >> On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: >>> From: Tong Wu >>> >>> HEVCHdrParams* receives a pointer which points to a dynamically >>> allocated memory block. It causes the memcmp always returning 1. >>> Add a

Re: [FFmpeg-devel] [PATCH v11 3/8] avcodec/bsf: Add awebp2webp bitstream filter

2024-03-29 Thread Andreas Rheinhardt
Thilo Borgmann via ffmpeg-devel: > Am 28.03.24 um 19:11 schrieb Stefano Sabatini: >> On date Thursday 2024-03-28 15:08:53 +0100, ffmpeg-devel Mailing List >> wrote: >>> Splits a packet containing a webp animations into >>> one non-compliant packet per frame of the animation. >>> Skips RIFF and

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread James Almer
On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A

[FFmpeg-devel] [PATCH] doc/muxers: add ircam

2024-03-29 Thread Stefano Sabatini
Most of the content copy from: http://fileformats.archiveteam.org/wiki/Berkeley/IRCAM/Carl_Sound_Format --- doc/muxers.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 5cce26a43f..39597e000b 100644 --- a/doc/muxers.texi +++

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Mark Thompson
On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0).

[FFmpeg-devel] [PATCH] doc/muxers/image2: add mention to image2pipe

2024-03-29 Thread Stefano Sabatini
Clarify the difference with regards to the image2 muxer. --- doc/muxers.texi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 05a0c302cf..5cce26a43f 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -2569,10 +2569,10 @@

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread James Almer
On 3/28/2024 10:15 AM, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0).

[FFmpeg-devel] [PATCH] doc/muxers: add ilbc

2024-03-29 Thread Stefano Sabatini
--- doc/muxers.texi | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 450f72a73c..b8404c274c 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -2563,6 +2563,11 @@ If a BMP image is used, it must use the BITMAPINFOHEADER DIB header If a PNG

Re: [FFmpeg-devel] [PATCH 3/3] lavf/subtitles: Unfix ticket #5032

2024-03-29 Thread Tomas Härdin
Here's an alternative solution which maintains support for \r\r\n by peeking two bytes into the future. /Tomas From ed6f0b2e6c8e52574fcfdac73fcfca560434c079 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Thu, 28 Mar 2024 23:30:06 +0100 Subject: [PATCH] lavf/subtitles: Add

Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-29 Thread Tomas Härdin
> +    /* demux */ > +    while (!avio_feof(avf->pb)) { Can we please get away from this way of reading subtitles? Every other type of media (audio, video) are capable of being streamed, but not subtitles, precisely because all of them do all parsing in the read_header() call. We have a perfectly

[FFmpeg-devel] [PATCH] doc/muxers: add stub for iamf

2024-03-29 Thread Stefano Sabatini
--- doc/muxers.texi | 16 1 file changed, 16 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index f300f8c45f..23506e2ab7 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -2515,6 +2515,22 @@ Ignore IO errors during open, write and delete. Useful for

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-29 Thread Anton Khirnov
This is a reminder that I'm planning to end the vote on Monday morning. We have 17 votes so far, if you have not voted yet please do so ASAP. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] doc/muxers/hls: review, apply consistency fixes

2024-03-29 Thread Stefano Sabatini
Apply misc typo fixes, consistency fixes, and reformat the layout to provide more overall internal and global consistency. --- doc/muxers.texi | 404 +++- 1 file changed, 225 insertions(+), 179 deletions(-) diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH v11 3/8] avcodec/bsf: Add awebp2webp bitstream filter

2024-03-29 Thread Thilo Borgmann via ffmpeg-devel
Am 28.03.24 um 19:11 schrieb Stefano Sabatini: On date Thursday 2024-03-28 15:08:53 +0100, ffmpeg-devel Mailing List wrote: Splits a packet containing a webp animations into one non-compliant packet per frame of the animation. Skips RIFF and WEBP chunks for those packets except for the first.

Re: [FFmpeg-devel] [PATCH v6] avformat/demux: Add duration_probesize AVOption

2024-03-29 Thread Stefano Sabatini
On date Friday 2024-03-29 10:26:19 +0100, Nicolas Gaullier wrote: > Yet another probesize used to get the durations when > estimate_timings_from_pts is required. It is aimed at users interested > in better durations probing for itself, or because using > avformat_find_stream_info indirectly and

Re: [FFmpeg-devel] [PATCH v10 0/5] RCWT Closed Captions demuxer (v10)

2024-03-29 Thread Stefano Sabatini
On date Thursday 2024-03-28 15:11:27 -0500, Marth64 wrote: > Since v7/8: > * Addresses last known feedback (about av_assert call) > * Changelog entry removed, since v7.0 is cut and there is no "next" space yet > (will make patch once available) > > Signed-off-by: Marth64 Will apply soon if I

[FFmpeg-devel] [PATCH v6] avformat/demux: Add duration_probesize AVOption

2024-03-29 Thread Nicolas Gaullier
Yet another probesize used to get the durations when estimate_timings_from_pts is required. It is aimed at users interested in better durations probing for itself, or because using avformat_find_stream_info indirectly and requiring exact values: for concatdec for example, especially if

Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR

2024-03-29 Thread Anton Khirnov
Quoting Gyan Doshi (2024-03-29 10:19:15) > LGTM. Should have been done a long time ago. > What about the other muxers in movenc? I don't know what they are used for or what constraints they have, so I left them alone for now. Can also change them if people see no problem with it. -- Anton

Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR

2024-03-29 Thread Gyan Doshi
On 2024-03-29 02:05 pm, Anton Khirnov wrote: --- libavformat/movenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index b97c479cc4..30cfbf6e74 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-03-29 Thread Steven Liu
> 在 2024年3月29日,06:51,Romain Beauxis 写道: > > On Mon, Mar 25, 2024, 19:58 Romain Beauxis wrote: > >> This patch adds support for updating HLS metadata passed as ID3 frames. >> >> This seems like a pretty straight-forward improvement. Updating the >> metadaata of the first stream seems to be

[FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR

2024-03-29 Thread Anton Khirnov
--- libavformat/movenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index b97c479cc4..30cfbf6e74 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -8230,11 +8230,11 @@ const FFOutputFormat ff_mov_muxer

[FFmpeg-devel] [PATCH v2] lavc/libopenh264: Check for noopenh264

2024-03-29 Thread Akihiko Odaki
noopenh264 is a "fake implementation of the OpenH264 library we can link from regardless of the actual library being available": https://gitlab.com/freedesktop-sdk/noopenh264 A distributor may wish to link against openh264/noopenh264 and let the decoder and encoder work only if the actual library