[FFmpeg-devel] [PATCH] libavformat/rtsp: fix a memory leak in libavformat/rtsp.c

2024-04-12 Thread LuMingYin
The pointer variable 'fds' allocates a block of dynamic memory in the function 'ffurl_get_multi_file_handle', and the dynamic memory pointed to by this pointer is not released on error paths. Signed-off-by: LuMingYin --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git

[FFmpeg-devel] [PATCH] libavfilter/vf_curves: fix a memory leak in libavfilter/vf_curves.c

2024-04-12 Thread LuMingYin
The pointer variable 'point', which is defined and dynamically allocated memory within the while loop of the 'parse_points_str' function, is not released on error paths. Signed-off-by: LuMingYin --- libavfilter/vf_curves.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix memory leak in ffmpeg_mux_init.c

2024-04-12 Thread lumingyindetect
Thank you for your patient explanation! As you pointed out, I made unnecessary modifications in the public functions in the previous patch. Now, I have rectified them and created a new patch. The patch link

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix memory leak in ffmpeg_mux_init.c

2024-04-12 Thread lumingyindetect
Thankyouforyourpatientexplanation!Asyoupointedout,Imadeunnecessarymodificationsinthepublicfunctionsinthepreviouspatch.Now,Ihaverectifiedthemandcreatedanewpatch.Thepatchlinkis:https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240413023726.1843852-1-lumingyindet...@163.com/ 在 2024-04-13

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix a memory leak in ffmpeg_mux_init.c

2024-04-12 Thread LuMingYin
Signed-off-by: LuMingYin --- fftools/ffmpeg_mux_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 6d8bd5bcdf..d2146cef8c 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -2851,8

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-12 Thread Antoine Soulier via ffmpeg-devel
Thanks. On Fri, Apr 12, 2024 at 6:05 AM Stefano Sabatini wrote: > On date Wednesday 2024-04-10 16:46:55 -0700, ffmpeg-devel Mailing List > wrote: > > Sure, I thought these warnings were disabled while looking at codec2.c > > Sorry for the bad merge of the doc. > > > From

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-04-12 Thread Thilo Borgmann via ffmpeg-devel
Hi all, We are offered to apply for a sponsorship of FFmpeg by the Sovereign Tech Fund (STF). Please read the following to get a better understanding what STF is about: (In short it is about maintenance and sustainability, not features) https://www.sovereigntechfund.de/programs/applications

Re: [FFmpeg-devel] [PATCH] ffmpeg: Carry streamid as metadata key 'id'

2024-04-12 Thread Michael Niedermayer
On Fri, Apr 12, 2024 at 11:40:47AM +0200, Tomas Härdin wrote: > This idea could be extended to other fields not presently considered to > be metadata, that would be handy to treat as such. > > I use the key "id" because ffprobe outputs id= for streamid. Another > option could be to collect these

[FFmpeg-devel] [PATCH 2/2] avutil/opt: add support for children objects in av_opt_serialize

2024-04-12 Thread James Almer
Signed-off-by: James Almer --- libavutil/opt.c | 65 +-- libavutil/opt.h | 1 + libavutil/tests/opt.c | 47 +-- tests/ref/fate/opt| 2 +- 4 files changed, 90 insertions(+), 25 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] avutil/test/opt: test the AV_OPT_SERIALIZE_SKIP_DEFAULTS flag

2024-04-12 Thread James Almer
Signed-off-by: James Almer --- The floats are set to "1.0 / 3" and the serialization prints a value that's not exact, hence them not being skipped. array_int is weird, though. Although it's the only array that doesn't set AVOption.arr libavutil/tests/opt.c | 5 + tests/ref/fate/opt| 1 +

[FFmpeg-devel] [PATCH] doc/muxers.texi: Don't use confusing variable name

2024-04-12 Thread Andreas Rheinhardt
reserve_index_space is a size, not an index. Also refer to the variable in the description. Signed-off-by: Andreas Rheinhardt --- doc/muxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 4b30970b78..489f22288b 100644 ---

[FFmpeg-devel] [PATCH v2 2/2] avcodec/nvenc: Multi NVENC Split Frame Encoding in HEVC and AV1

2024-04-12 Thread Diego Felix de Souza via ffmpeg-devel
From: Diego Felix de Souza When Split frame encoding is enabled, each input frame is partitioned into horizontal strips which are encoded independently and simultaneously by separate NVENCs, usually resulting in increased encoding speed compared to single NVENC encoding. Signed-off-by: Diego

[FFmpeg-devel] [PATCH v2 1/2] avcodec/nvenc: Multi NVENC Split Frame Encoding in HEVC and AV1

2024-04-12 Thread Diego Felix de Souza via ffmpeg-devel
From: Diego Felix de Souza When Split frame encoding is enabled, each input frame is partitioned into horizontal strips which are encoded independently and simultaneously by separate NVENCs, usually resulting in increased encoding speed compared to single NVENC encoding. Signed-off-by: Diego

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix memory leak in ffmpeg_mux_init.c

2024-04-12 Thread James Almer
On 4/12/2024 1:44 PM, LuMingYin wrote: Signed-off-by: LuMingYin --- fftools/ffmpeg_mux_init.c | 7 --- libavutil/mem.c | 5 - 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 6d8bd5bcdf..e7e2281bd0

Re: [FFmpeg-devel] [PATCH 2/2] Add fate test for hls metadata update.

2024-04-12 Thread Andreas Rheinhardt
Romain Beauxis: > Le jeu. 11 avr. 2024 à 09:17, Andreas Rheinhardt < > andreas.rheinha...@outlook.com> a écrit : > >> Romain Beauxis: >>> This patch adds a FATE test for the new HLS metadata update. The fate >>> sample consists of a two segment AAC hls stream. The first segment has >>> test title

Re: [FFmpeg-devel] [PATCH 2/2] Add fate test for hls metadata update.

2024-04-12 Thread Romain Beauxis
Le jeu. 11 avr. 2024 à 09:17, Andreas Rheinhardt < andreas.rheinha...@outlook.com> a écrit : > Romain Beauxis: > > This patch adds a FATE test for the new HLS metadata update. The fate > > sample consists of a two segment AAC hls stream. The first segment has > > test title 1 as title metadata

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix a memory leak in ffmpeg_mux_init.c

2024-04-12 Thread lumingyindetect
Thank you for your patient response! I have submitted the new patch as requested. The link is https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240412164441.1727089-1-lumingyindet...@163.com/ At 2024-04-12 21:41:25, "James Almer" wrote: >On 4/12/2024 10:09 AM, LuMingYin

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix memory leak in ffmpeg_mux_init.c

2024-04-12 Thread LuMingYin
Signed-off-by: LuMingYin --- fftools/ffmpeg_mux_init.c | 7 --- libavutil/mem.c | 5 - 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 6d8bd5bcdf..e7e2281bd0 100644 --- a/fftools/ffmpeg_mux_init.c +++

Re: [FFmpeg-devel] [RFC] Bump minimum required version of Android to 5.0

2024-04-12 Thread Matthieu Bouron
On Thu, Apr 11, 2024 at 2:17 PM Zhao Zhili wrote: > > We don’t have a minimum required version of Android in FFmpeg. > libavdevice/android_camera requires Android 7, Java MediaCodec > requires Android 4.1, and NDK MediaCodec requires Android 5.0. > > Without an explicit version, it’s unclear for

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix a memory leak in ffmpeg_mux_init.c

2024-04-12 Thread James Almer
On 4/12/2024 10:09 AM, LuMingYin wrote: In the file ffmpeg_mux_init.c located at /FFmpeg/fftools/, a pointer variable named pts is defined at line 2830. At line 2836, this pointer is allocated a dynamic memory area using the function av_malloc_array. When the if statement at line 2852

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix a memory leak in ffmpeg_mux_init.c

2024-04-12 Thread LuMingYin
In the file ffmpeg_mux_init.c located at /FFmpeg/fftools/, a pointer variable named pts is defined at line 2830. At line 2836, this pointer is allocated a dynamic memory area using the function av_malloc_array. When the if statement at line 2852 evaluates to true, there are two possible

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-12 Thread Stefano Sabatini
On date Wednesday 2024-04-10 16:46:55 -0700, ffmpeg-devel Mailing List wrote: > Sure, I thought these warnings were disabled while looking at codec2.c > Sorry for the bad merge of the doc. > From 975040408f32431efc3fae0a0b8c048f02159515 Mon Sep 17 00:00:00 2001 > From: Antoine SOULIER > Date:

Re: [FFmpeg-devel] cannot compile the ffmpeg latest on local

2024-04-12 Thread B-2014 Ariyan Kashyap
Hey, thank you for the help If it's possible, could you give me a roadmap to set up the ffmpeg source code in my local. I think i might be missing something Thank you On Thu, Apr 11, 2024 at 8:05 PM wrote: > > > On 11 Apr 2024, at 15:59, B-2014 Ariyan Kashyap wrote: > > > I was trying to

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: fix memory leak on error path

2024-04-12 Thread LuMingYin
In the file ffmpeg_demux.c located at /FFmpeg/fftools/, a pointer variable named ic is defined at line 1531. At line 1589, the program allocates a dynamic memory area for it using the function avformat_alloc_context. When the if statement at line 1668 evaluates to true, the function returns at

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-12 Thread Michael Niedermayer
On Thu, Apr 11, 2024 at 06:55:58PM -0400, Sean McGovern wrote: > Hi, > > On Wed, Apr 10, 2024, 19:32 Michael Niedermayer > wrote: > > > On Wed, Apr 10, 2024 at 03:47:48PM +0200, Niklas Haas wrote: > > > On Wed, 10 Apr 2024 15:18:52 +0200 Michael Niedermayer < > > mich...@niedermayer.cc> wrote:

Re: [FFmpeg-devel] [RFC] Bump minimum required version of Android to 5.0

2024-04-12 Thread Tomas Härdin
fre 2024-04-12 klockan 19:23 +0800 skrev Zhao Zhili: > > > > On Apr 12, 2024, at 18:50, Tomas Härdin wrote: > > > > tor 2024-04-11 klockan 21:57 +0800 skrev Zhao Zhili: > > > > > > > > > > On Apr 11, 2024, at 21:17, Tomas Härdin wrote: > > > > > > > > tor 2024-04-11 klockan 20:16 +0800

[FFmpeg-devel] [PATCH v3 07/13] avcodec/dovi_rpuenc: add ff_dovi_configure()

2024-04-12 Thread Niklas Haas
From: Niklas Haas We need to set up the configuration struct appropriately based on the codec type, colorspace metadata, and presence/absence of an EL (though, we currently don't support an EL). When present, we use the signalled RPU data header to help infer (and validate) the right values.

[FFmpeg-devel] [PATCH v3 08/13] avcodec/dovi_rpudec: make `enable` also affect decoding

2024-04-12 Thread Niklas Haas
From: Niklas Haas This could be used by codecs to selectively disable parsing Dolby Vision RPUs, and is cheap to support. --- libavcodec/av1dec.c | 1 + libavcodec/dovi_rpu.h| 2 ++ libavcodec/dovi_rpudec.c | 6 ++ libavcodec/hevcdec.c | 1 + libavcodec/libdav1d.c| 1 + 5

[FFmpeg-devel] [PATCH v3 06/13] avcodec/dovi_rpu: split into dovi_rpu.c and dovi_rpudec.c

2024-04-12 Thread Niklas Haas
From: Niklas Haas To allow compiling the decoding objects without the encoding objects and vice versa. Common helpers that users of both APIs need are put into the shared dovi_rpu.c. --- libavcodec/Makefile | 2 +- libavcodec/dovi_rpu.c| 624 +-

[FFmpeg-devel] [PATCH v3 05/13] configure: rename dovi_rpu subsystem to dovi_rpudec

2024-04-12 Thread Niklas Haas
From: Niklas Haas To distinguish it from the to-be-added dovi_rpuenc. --- configure | 10 +- libavcodec/Makefile | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 55f1fc354d..c1e1ece1e2 100755 --- a/configure +++ b/configure @@

[FFmpeg-devel] [PATCH v3 11/13] avcodec/libaomenc: implement dolby vision coding

2024-04-12 Thread Niklas Haas
From: Niklas Haas --- configure | 2 +- libavcodec/libaomenc.c | 28 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/configure b/configure index d25d0f6907..bf63c831af 100755 --- a/configure +++ b/configure @@ -3485,7 +3485,7 @@

[FFmpeg-devel] [PATCH v3 04/13] avcodec/dovi_rpu: expose guess_profile(), clarify semantics

2024-04-12 Thread Niklas Haas
From: Niklas Haas To allow internally re-using it for both the encoder and decoder. This is based on HEVC only, H.264/AV1 use their own (hopefully correctly signalled) profiles (and in particular, the AV1 decoders implicitly default the correct profile in the absence of a configuration record).

[FFmpeg-devel] [PATCH v3 13/13] avcodec/libsvtav1: implement dolby vision coding

2024-04-12 Thread Niklas Haas
From: Niklas Haas --- configure | 1 + libavcodec/libsvtav1.c | 34 ++ 2 files changed, 35 insertions(+) diff --git a/configure b/configure index cce37bb32e..6fbd0e44ff 100755 --- a/configure +++ b/configure @@ -3534,6 +3534,7 @@

[FFmpeg-devel] [PATCH v3 03/13] avcodec/dovi_rpu: clarify error on missing RPU VDR

2024-04-12 Thread Niklas Haas
From: Niklas Haas The code was written under the misguided assumption that these fields would only be present when the value changes, however this does not match the actual patent specification, which says that streams are required to either always signal this metadata, or never signal it. That

[FFmpeg-devel] [PATCH v3 12/13] avcodec/libx265: implement dolby vision coding

2024-04-12 Thread Niklas Haas
From: Niklas Haas libx265 supports these natively, we just need to attach the generated NALs to the x265picture, as well as setting the appropriate DV profile. --- configure| 2 +- libavcodec/libx265.c | 40 2 files changed, 41

[FFmpeg-devel] [PATCH v3 10/13] avformat/movenc: warn if dovi cfg ignored

2024-04-12 Thread Niklas Haas
From: Niklas Haas Since this is guarded behind strict unofficial, we should warn if the user feeds a dolby vision stream to this muxer, as it will otherwise result in a broken file. --- libavformat/movenc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 09/13] avcodec/dovi_rpuenc: add ff_dovi_rpu_generate()

2024-04-12 Thread Niklas Haas
From: Niklas Haas This function takes a decoded AVDOVIMetadata struct and turns it back into a binary RPU. Verified using existing tools, and matches the bitstream in official reference files. I decided to just roll the EMDF and NAL encapsulation into this function because the end user will

[FFmpeg-devel] [PATCH v3 02/13] avcodec/dovi_rpu: properly replace context header

2024-04-12 Thread Niklas Haas
From: Niklas Haas This was never set in ff_dovi_ctx_replace(), leading to possibly out-of-date when copying from one thread to another. --- libavcodec/dovi_rpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c index d95c7e03af..bfb7b9fe66 100644

[FFmpeg-devel] [PATCH v3 01/13] avcodec/dovi_rpu: store entire config record

2024-04-12 Thread Niklas Haas
From: Niklas Haas And make it public. For encoding, users may also be interested in the configured level and compatibility ID. So generalize the dv_profile field and just expose the whole configuration record. This makes the already rather reductive ff_dovi_update_cfg() function almost wholly

[FFmpeg-devel] [PATCH v3 00/13] avcodec: add Dolby Vision encoding

2024-04-12 Thread Niklas Haas
Changes since v2: - Split up dovi_rpu.c into dovi_rpudec.c and dovi_rpueenc. - Added missing dependencies of encoders onto dovi_rpueenc - Clarified and documented semantics of guess_profile() - Changed misleading commit message ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [RFC] Bump minimum required version of Android to 5.0

2024-04-12 Thread Zhao Zhili
> On Apr 12, 2024, at 18:50, Tomas Härdin wrote: > > tor 2024-04-11 klockan 21:57 +0800 skrev Zhao Zhili: >> >> >>> On Apr 11, 2024, at 21:17, Tomas Härdin wrote: >>> >>> tor 2024-04-11 klockan 20:16 +0800 skrev Zhao Zhili: We don’t have a minimum required version of Android in

Re: [FFmpeg-devel] [RFC] Bump minimum required version of Android to 5.0

2024-04-12 Thread Nicolas George
Tomas Härdin (12024-04-12): > Makes me wonder what kind of devices people run that haven't been > updated in 10+ years.. The kind of devices that no longer get software updates but the owner cannot afford to replace. -- Nicolas George ___

Re: [FFmpeg-devel] [RFC] Bump minimum required version of Android to 5.0

2024-04-12 Thread Tomas Härdin
tor 2024-04-11 klockan 21:57 +0800 skrev Zhao Zhili: > > > > On Apr 11, 2024, at 21:17, Tomas Härdin wrote: > > > > tor 2024-04-11 klockan 20:16 +0800 skrev Zhao Zhili: > > > We don’t have a minimum required version of Android in FFmpeg. > > > libavdevice/android_camera requires Android 7,

Re: [FFmpeg-devel] [PATCH v2] avcodec/libx264: bump minimum required version to 155

2024-04-12 Thread Niklas Haas
On Tue, 09 Apr 2024 15:12:05 +0200 Niklas Haas wrote: > From: Niklas Haas > > This version is seven years old, and present in Debian oldoldstable, > Ubuntu 20.04 and Leap 15.0. > > Allows cleaning up the file substantially. In particular, this is > motivated by the desire to stop relying on

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-12 Thread Tomas Härdin
tor 2024-04-11 klockan 18:55 -0400 skrev Sean McGovern: > Hi, > > On Wed, Apr 10, 2024, 19:32 Michael Niedermayer > > wrote: > > > On Wed, Apr 10, 2024 at 03:47:48PM +0200, Niklas Haas wrote: > > > On Wed, 10 Apr 2024 15:18:52 +0200 Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > > >

[FFmpeg-devel] [TC] Technical decision on S302M non-PCM decoding

2024-04-12 Thread Niklas Haas
On Sat, 17 Feb 2024 17:15:43 +0530 Gyan Doshi wrote: > Issue: > > Patch: avcodec/s302m: enable non-PCM decoding > URL: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ > > The issue needing resolution is whether the patch should be added to the >

Re: [FFmpeg-devel] [PATCH v1] libavfilter/af_channelsplit.c:fix memory leak

2024-04-12 Thread Zhao Zhili
> On Apr 12, 2024, at 17:19, LuMingYin wrote: > > Signed-off-by: LuMingYin > --- > libavfilter/af_channelsplit.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c > index d18d91dcb6..2cfac19cd3 100644 >

[FFmpeg-devel] [PATCH] ffmpeg: Carry streamid as metadata key 'id'

2024-04-12 Thread Tomas Härdin
This idea could be extended to other fields not presently considered to be metadata, that would be handy to treat as such. I use the key "id" because ffprobe outputs id= for streamid. Another option could be to collect these types of metadata that go into AVStream fields under a namespace like

[FFmpeg-devel] [PATCH v1] libavfilter/af_channelsplit.c:fix memory leak

2024-04-12 Thread LuMingYin
Signed-off-by: LuMingYin --- libavfilter/af_channelsplit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c index d18d91dcb6..2cfac19cd3 100644 --- a/libavfilter/af_channelsplit.c +++

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-12 Thread Lynne
Apr 12, 2024, 00:45 by mich...@niedermayer.cc: > On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: > >> Apr 10, 2024, 23:57 by mich...@niedermayer.cc: >> >> > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: >> > >> >> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne

Re: [FFmpeg-devel] [PATCH] Multi NVENC Split Frame Encoding in HEVC and AV1

2024-04-12 Thread Diego Felix de Souza via ffmpeg-devel
Hi Timo, Thank you for your review. Sorry for both superfulous spaces. Thank you for pointing them out, I will be more careful on the next patches. Please check my answers below. Best regards, Diego From: Timo Rothenpieler Date: Thursday, 11. April 2024 at 15:50 To: FFmpeg development

Re: [FFmpeg-devel] [PATCH] ffmpeg: Add -copystreamid

2024-04-12 Thread Tomas Härdin
fre 2024-04-12 klockan 00:32 +0200 skrev Michael Niedermayer: > On Thu, Apr 11, 2024 at 05:41:48PM +0200, Tomas Härdin wrote: > > Hi > > > > Patch attached allows preserving PIDs when remuxing MPEG-TS. James > > suggested we could generalize this to allow copying from specific > > streams, but I