Re: [FFmpeg-devel] [PATCH 1/4] lavc/vvc_parser: Remove max_b_frames setting

2024-04-19 Thread Nuo Mi
LGTM On Fri, Apr 19, 2024 at 9:47 PM Jun Zhao wrote: > From: Jun Zhao > > We don't used the max_b_frames field in decoder normally > > Signed-off-by: Jun Zhao > --- > libavcodec/vvc_parser.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/vvc_parser.c

Re: [FFmpeg-devel] [PATCH 3/4] lavc/vvc_parser: Fixed the has_b_frames setting

2024-04-19 Thread Nuo Mi
On Fri, Apr 19, 2024 at 9:55 PM Jun Zhao wrote: > From: Jun Zhao > > has_b_frames used in decoder for size of the frame reordering > buffer, setting this field from dpb_max_num_reorder_pics. > > Signed-off-by: Jun Zhao > --- > libavcodec/vvc_parser.c | 4 ++-- > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output

2024-04-19 Thread Nuo Mi
Hi Barry and Eliny, LGTM. Thank you for the patch. Is it possible to provide the clip so we can add it to our CI? ci like https://github.com/ffvvc/FFmpeg/actions On Fri, Apr 19, 2024 at 9:48 PM Jun Zhao wrote: > From: Jun Zhao > > Use dpb_max_num_reorder_pics to control output instead of >

Re: [FFmpeg-devel] [PATCH] tools: add target_enc_fuzzer.c

2024-04-19 Thread James Almer
On 4/19/2024 10:10 PM, Michael Niedermayer wrote: Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_enc_fuzzer.c | 213 ++ 3 files changed, 219

[FFmpeg-devel] [PATCH] tools: add target_enc_fuzzer.c

2024-04-19 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_enc_fuzzer.c | 213 ++ 3 files changed, 219 insertions(+) create mode 100644 tools/target_enc_fuzzer.c

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Paul B Mahol
On Sat, Apr 20, 2024 at 12:31 AM James Almer wrote: > On 4/19/2024 7:28 PM, Paul B Mahol wrote: > > On Fri, Apr 19, 2024 at 11:58 PM Vittorio Giovara < > > vittorio.giov...@gmail.com> wrote: > > > >> On Fri, Apr 19, 2024 at 12:48 PM Ronald S. Bultje > >> wrote: > >> > >>> Hi, > >>> > >>> On

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Ronald S. Bultje
Hi, On Fri, Apr 19, 2024 at 5:58 PM Vittorio Giovara wrote: > On Fri, Apr 19, 2024 at 12:48 PM Ronald S. Bultje > wrote: > > > Hi, > > > > On Fri, Apr 19, 2024 at 2:06 PM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Fri, Apr 19, 2024 at 11:00 AM Diederick C.

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread James Almer
On 4/19/2024 7:28 PM, Paul B Mahol wrote: On Fri, Apr 19, 2024 at 11:58 PM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: On Fri, Apr 19, 2024 at 12:48 PM Ronald S. Bultje wrote: Hi, On Fri, Apr 19, 2024 at 2:06 PM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: On Fri, Apr

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Paul B Mahol
On Fri, Apr 19, 2024 at 11:58 PM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Fri, Apr 19, 2024 at 12:48 PM Ronald S. Bultje > wrote: > > > Hi, > > > > On Fri, Apr 19, 2024 at 2:06 PM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Fri, Apr 19, 2024 at

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Vittorio Giovara
On Fri, Apr 19, 2024 at 12:48 PM Ronald S. Bultje wrote: > Hi, > > On Fri, Apr 19, 2024 at 2:06 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Fri, Apr 19, 2024 at 11:00 AM Diederick C. Niehorster < > > dcni...@gmail.com> > > wrote: > > > > > If i recall correctly, there

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Paul B Mahol
On Fri, Apr 19, 2024 at 9:45 PM James Almer wrote: > On 4/19/2024 4:05 PM, Paul B Mahol wrote: > > On Fri, Apr 19, 2024 at 8:06 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > > wrote: > > > >> On Fri, Apr 19, 2024 at 11:00 AM Diederick C. Niehorster < > >> dcni...@gmail.com> > >> wrote: >

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Ronald S. Bultje
Hi, On Fri, Apr 19, 2024 at 2:06 PM Vittorio Giovara wrote: > On Fri, Apr 19, 2024 at 11:00 AM Diederick C. Niehorster < > dcni...@gmail.com> > wrote: > > > If i recall correctly, there was a conversation not too long ago about > what > > to do with all the SPI money. This seems to be a perfect

[FFmpeg-devel] [PATCH v3 3/3] avformat/avformat: Document return codes for av_format_(de)init

2024-04-19 Thread Andrew Sayers
--- libavformat/avformat.h | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 8afdcd9fd0..f624fb1e2e 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1944,12 +1944,16 @@ const char *avformat_license(void); * This

[FFmpeg-devel] [PATCH v3 2/3] avformat/network: Return 0/AVERROR from ff_network_init()

2024-04-19 Thread Andrew Sayers
--- libavformat/avio.c| 4 ++-- libavformat/network.c | 7 +++ libavformat/rtsp.c| 12 ++-- libavformat/rtspdec.c | 4 ++-- libavformat/sapdec.c | 4 ++-- libavformat/sapenc.c | 4 ++-- 6 files changed, 17 insertions(+), 18 deletions(-) diff --git a/libavformat/avio.c

[FFmpeg-devel] [PATCH v3 1/3] avformat/network: add ff_neterrno2() for cases where we already have an errno

2024-04-19 Thread Andrew Sayers
For example, WSAStartup()'s documentation says: "A call to the WSAGetLastError function is not needed and should not be used" --- libavformat/network.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/network.c b/libavformat/network.c index

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Paul B Mahol
On Fri, Apr 19, 2024 at 8:06 PM Vittorio Giovara wrote: > On Fri, Apr 19, 2024 at 11:00 AM Diederick C. Niehorster < > dcni...@gmail.com> > wrote: > > > If i recall correctly, there was a conversation not too long ago about > what > > to do with all the SPI money. This seems to be a perfect use

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Vittorio Giovara
On Fri, Apr 19, 2024 at 11:00 AM Diederick C. Niehorster wrote: > If i recall correctly, there was a conversation not too long ago about what > to do with all the SPI money. This seems to be a perfect use for it. > 1. Set up and manage a gitlab instance > 2. Move tickets from trac to there

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Diederick C. Niehorster
On Fri, Apr 19, 2024, 19:35 Zhao Zhili wrote: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > Niklas Haas > > Sent: 2024年4月19日 22:50 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation > > > > On Thu, 18 Apr

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/network: Return a proper negative error code from ff_network_init()

2024-04-19 Thread James Almer
On 4/19/2024 2:23 PM, Andrew Sayers wrote: --- libavformat/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/network.c b/libavformat/network.c index f752efc411..d518bb0541 100644 --- a/libavformat/network.c +++ b/libavformat/network.c @@ -63,7 +63,7 @@

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Niklas Haas > Sent: 2024年4月19日 22:50 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation > > On Thu, 18 Apr 2024 22:53:51 +0200 Michael Niedermayer > wrote: > > A plugin

[FFmpeg-devel] [PATCH v2 2/2] avformat/avformat: Document return codes for av_format_(de)init

2024-04-19 Thread Andrew Sayers
--- libavformat/avformat.h | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 8afdcd9fd0..ea816a0b22 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1944,12 +1944,16 @@ const char *avformat_license(void); * This

[FFmpeg-devel] [PATCH v2 1/2] avformat/network: Return a proper negative error code from ff_network_init()

2024-04-19 Thread Andrew Sayers
--- libavformat/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/network.c b/libavformat/network.c index f752efc411..d518bb0541 100644 --- a/libavformat/network.c +++ b/libavformat/network.c @@ -63,7 +63,7 @@ int ff_network_init(void) if

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: handle errors > 0 in avformat_network_init()

2024-04-19 Thread James Almer
On 4/19/2024 1:59 PM, Andrew Sayers wrote: --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 4dded7aea4..855723a406 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -560,7 +560,7 @@ int

[FFmpeg-devel] [PATCH 2/2] avformat/avformat: Document return codes for av_format_(de)init

2024-04-19 Thread Andrew Sayers
--- libavformat/avformat.h | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 8afdcd9fd0..0feaeded0e 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1944,12 +1944,16 @@ const char *avformat_license(void); * This

[FFmpeg-devel] [PATCH 1/2] avformat/utils: handle errors > 0 in avformat_network_init()

2024-04-19 Thread Andrew Sayers
--- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 4dded7aea4..855723a406 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -560,7 +560,7 @@ int avformat_network_init(void) { #if CONFIG_NETWORK

[FFmpeg-devel] [PATCH 5/5] avcodec/vaapi_av1: Use ProgressFrames

2024-04-19 Thread Andreas Rheinhardt
The rationale here is exactly the same as for using them for AV1: It avoids av_frame_ref() when putting the same frame into multiple reference slots. (In case av_frame_ref() failed, the context would be left in an inconsistent state that claimed that an AVFrame was valid (i.e. not blank), when in

[FFmpeg-devel] [PATCH 4/5] avcodec/av1dec: Make av1_frame_replace() out of av1_frame_ref()

2024-04-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/av1dec.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 2a1a249bc4..21ba9d475d 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -683,16

[FFmpeg-devel] [PATCH 3/5] avcodec/av1dec: Use ProgressFrames

2024-04-19 Thread Andreas Rheinhardt
AV1 can put a frame into multiple reference slots; up until now, this involved creating a new reference to the underlying AVFrame; therefore av1_frame_ref() could fail. This commit changes this by using the ProgressFrame API to share the underlying AVFrames. (Hint: vaapi_av1_surface_id() checked

[FFmpeg-devel] [PATCH 2/5] avcodec/hevcdec: Use union for AVFrame* and ProgressFrame

2024-04-19 Thread Andreas Rheinhardt
It avoids having to sync ProgressFrame.f and the pointer typically used to access the AVFrame. Signed-off-by: Andreas Rheinhardt --- libavcodec/hevc_refs.c | 2 -- libavcodec/hevcdec.c | 1 - libavcodec/hevcdec.h | 8 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/5] avcodec/progressframe: Explain how unnamed union can simplify accesses

2024-04-19 Thread Andreas Rheinhardt
This relies on the common initial seqence guarantee (and on C11 support for unnamed members). Signed-off-by: Andreas Rheinhardt --- Alternatively, we could rely on type punning via unions and even use union { AVFrame *const f; ProgressFrame pf; };

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: Fix precedence, bogus film grain warning

2024-04-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/hevcdec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index a2c967cf09..1974bf9cb3 100644 > --- a/libavcodec/hevcdec.c > +++

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread epirat07
On 19 Apr 2024, at 16:50, Niklas Haas wrote: > On Thu, 18 Apr 2024 22:53:51 +0200 Michael Niedermayer > wrote: >> A plugin system moves this patch-management to people who actually >> care, that is the authors of the codecs and (de)muxers. > > A plugin system will only solve this insomuch as

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Niklas Haas
On Thu, 18 Apr 2024 22:53:51 +0200 Michael Niedermayer wrote: > A plugin system moves this patch-management to people who actually > care, that is the authors of the codecs and (de)muxers. A plugin system will only solve this insomuch as plugin authors will just host their plugin code on GitHub

[FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output

2024-04-19 Thread Jun Zhao
From: Jun Zhao Use dpb_max_num_reorder_pics to control output instead of dpb_max_dec_pic_buffering, when dpb_max_dec_pic_buffering is much larger than dpb_max_num_reorder_pics, it may cause dpb overflow error. Signed-off-by: Jun Zhao Signed-off-by: elinyhuang --- libavcodec/vvc/refs.c | 2 +-

[FFmpeg-devel] [PATCH 3/4] lavc/vvc_parser: Fixed the has_b_frames setting

2024-04-19 Thread Jun Zhao
From: Jun Zhao has_b_frames used in decoder for size of the frame reordering buffer, setting this field from dpb_max_num_reorder_pics. Signed-off-by: Jun Zhao --- libavcodec/vvc_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc_parser.c

[FFmpeg-devel] [PATCH 2/4] lavc/libxevd: Fixed the has_b_frames setting

2024-04-19 Thread Jun Zhao
From: Jun Zhao has_b_frames used in decoder for size of the frame reordering buffer, and we don't used the max_b_frames in decoder. Signed-off-by: Jun Zhao --- libavcodec/libxevd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/libxevd.c

[FFmpeg-devel] [PATCH 1/4] lavc/vvc_parser: Remove max_b_frames setting

2024-04-19 Thread Jun Zhao
From: Jun Zhao We don't used the max_b_frames field in decoder normally Signed-off-by: Jun Zhao --- libavcodec/vvc_parser.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vvc_parser.c b/libavcodec/vvc_parser.c index e3501fa139..a0e10e1a7c 100644 --- a/libavcodec/vvc_parser.c

[FFmpeg-devel] [PATCH] avcodec/hevcdec: Fix precedence, bogus film grain warning

2024-04-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index a2c967cf09..1974bf9cb3 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -2898,10 +2898,10 @@

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: High bit depth encoding for HEVC

2024-04-19 Thread Timo Rothenpieler
On 19/04/2024 13:29, Lynne wrote: Apr 19, 2024, 10:39 by ffmpeg-devel@ffmpeg.org: From: Diego Felix de Souza Adding 10-bit encoding support for HEVC if the input is 8-bit. In case of 8-bit input content, NVENC performs an internal CUDA 8 to 10-bit conversion of the input prior to encoding.

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: High bit depth encoding for HEVC

2024-04-19 Thread Lynne
Apr 19, 2024, 10:39 by ffmpeg-devel@ffmpeg.org: > From: Diego Felix de Souza > > Adding 10-bit encoding support for HEVC if the input is 8-bit. In > case of 8-bit input content, NVENC performs an internal CUDA 8 to > 10-bit conversion of the input prior to encoding. Currently, only > AV1

Re: [FFmpeg-devel] [PATCH v3] avformat: enable UDP IPv6 multicast interface selection using zone index

2024-04-19 Thread RS
This message has been marked as Public on 04/19/2024 10:23Z. On Thursday, April 11, 2024 3:01 PM Ignjatović, Lazar (RS) wrote: > avformat: enable UDP IPv6 multicast interface selection using zone index > > Enabled IPv6 interface selection using zone index. Properly resolved > interface index in

[FFmpeg-devel] [PATCH v2] avcodec/nvenc: High bit depth encoding for HEVC

2024-04-19 Thread Diego Felix de Souza via ffmpeg-devel
From: Diego Felix de Souza Adding 10-bit encoding support for HEVC if the input is 8-bit. In case of 8-bit input content, NVENC performs an internal CUDA 8 to 10-bit conversion of the input prior to encoding. Currently, only AV1 supports encoding 8-bit content as 10-bit. Signed-off-by: Diego

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: High bit depth encoding for HEVC

2024-04-19 Thread Diego Felix de Souza via ffmpeg-devel
Hi Roman and Timo, Timo is right. As a general rule, hybrid video coding standards allow encoders to take advantage of encoding a 8-bit input as 10-bit due to the interpolation filters (inter and intra) and transform coding at 10-bit depth. This can generate a better prediction and reduced

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: High bit depth encoding for HEVC

2024-04-19 Thread Roman Arzumanyan
Thanks for the explanation, Timo! I was hoping that 8>10 bit up-conversion which happens in the driver may bring some goodness like SDR > HDR conversion, recently presented by NV. Or some other algo which is easier to keep proprietary. Otherwise, although it is convenient in some use cases, it

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Paul B Mahol
On Fri, Apr 19, 2024 at 1:19 AM Michael Niedermayer wrote: > On Thu, Apr 18, 2024 at 06:13:40PM -0300, James Almer wrote: > > On 4/18/2024 5:53 PM, Michael Niedermayer wrote: > > > On Thu, Apr 18, 2024 at 04:02:07PM +0200, Niklas Haas wrote: > > > > On Wed, 17 Apr 2024 15:58:32 +0200 Michael