Re: [FFmpeg-devel] [PATCH] checkasm/blockdsp: don't randomize the buffers for fill_block_tab

2024-05-06 Thread Martin Storsjö
On Mon, 6 May 2024, James Almer wrote: It ignores and overwrites the previous values. Fixes running the test under ubsan. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) The change is probably correct, but what issue is ubsan

Re: [FFmpeg-devel] [PATCH v4 1/5] configure: Remove libva 1.x support

2024-05-06 Thread Xiang, Haihao
On So, 2024-05-05 at 20:01 +0100, Mark Thompson wrote: > libva 2.0 was released in 2017 and the 2.x versions are included in all > supported distributions nowadays.  Various features no longer need any > configure check after this command, including all codecs except AV1. > Note that the libva

Re: [FFmpeg-devel] [PATCH v3 6/9] lavc/vp8dsp: R-V V put_epel hv

2024-05-06 Thread flow gg
> IMO, passing a complete register name, if you really need to vary it, would be simpler and more flexible than an ABI register type prefix. If the full register name is passed here, some require four parameters, some require six parameters, and there is often repetition. I feel it's easy to get

[FFmpeg-devel] [PATCH 6/9] lavc/vp8dsp: R-V V put_epel hv

2024-05-06 Thread uk7b
From: sunyuechi C908: vp8_put_epel4_h4v4_c: 20.0 vp8_put_epel4_h4v4_rvv_i32: 11.0 vp8_put_epel4_h4v6_c: 25.2 vp8_put_epel4_h4v6_rvv_i32: 13.5 vp8_put_epel4_h6v4_c: 22.2 vp8_put_epel4_h6v4_rvv_i32: 14.5 vp8_put_epel4_h6v6_c: 29.0 vp8_put_epel4_h6v6_rvv_i32: 15.7 vp8_put_epel8_h4v4_c: 73.0

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

2024-05-06 Thread Michael Niedermayer
On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > Use the machdep.altivec sysctl on NetBSD for AltiVec detection > as is done with OpenBSD. > > Signed-off-by: Brad Smith > --- > libavutil/ppc/cpu.c | 6 +++--- > 1

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-06 Thread Nuo Mi
Hi Christian, Thank you for the patch. Let us review and merge the encoder part. On Tue, May 7, 2024 at 1:05 AM Christian Bartnik wrote: > From: Thomas Siedel > > Add external encoder VVenC for H266/VVC encoding. > Register new encoder libvvenc. > Add libvvenc to wrap the vvenc interface. >

[FFmpeg-devel] [PATCH] checkasm/blockdsp: don't randomize the buffers for fill_block_tab

2024-05-06 Thread James Almer
It ignores and overwrites the previous values. Fixes running the test under ubsan. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/blockdsp.c b/tests/checkasm/blockdsp.c index 19d69b8687..ab87fc8fa4

Re: [FFmpeg-devel] [PATCH 25/28] avcodec/x86/mpegvideoencdsp_init: Remove bits_per_raw_sample check

2024-05-06 Thread Michael Niedermayer
On Mon, May 06, 2024 at 11:52:24PM +0200, Andreas Rheinhardt wrote: > This check has been added in 19a0729b4cfacfd90b8ee84ab0c093ff7e397e65; > this commit added high bit-depth versions of draw_edges > and added the check to indicate that the mmx version only > supports eight bits. > Yet there is

Re: [FFmpeg-devel] [PATCH 26/28] avcodec/mpegvideoencdsp: Factor draw_edges out in its own context

2024-05-06 Thread Lynne
May 6, 2024, 23:53 by andreas.rheinha...@outlook.com: > This allows to remove a dependency of the dirac decoder (!) > on mpegvideoenc. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 7 +- > libavcodec/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH v3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Lynne
May 7, 2024, 00:38 by andreas.rheinha...@outlook.com: > This is achieved by using function pointers for AAC SBR functions. > This unfortunately necessitated to use void* in > ff_aac_sbr_apply(_fixed). > Fixes ticket #10999. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aac/aacdec.c

[FFmpeg-devel] [PATCH v3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Andreas Rheinhardt
This is achieved by using function pointers for AAC SBR functions. This unfortunately necessitated to use void* in ff_aac_sbr_apply(_fixed). Fixes ticket #10999. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 35 ++- libavcodec/aac/aacdec.h

[FFmpeg-devel] [PATCH 28/28] avcodec/diracdec: Don't use EDGE_WIDTH from mpegpicture.h

2024-05-06 Thread Andreas Rheinhardt
There is nothing that forces us to use the same value as mpegvideo_enc.c, so define our own constant. Signed-off-by: Andreas Rheinhardt --- libavcodec/diracdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index

[FFmpeg-devel] [PATCH 27/28] avcodec/mpegvideoencdsp: Pass bitexact flag directly

2024-05-06 Thread Andreas Rheinhardt
Don't pass an AVCodecContext*. This avoids inclusions of avcodec.h and makes it clearer which parameter affect the returned function pointers. Signed-off-by: Andreas Rheinhardt --- libavcodec/arm/mpegvideoencdsp_init_arm.c | 3 +-- libavcodec/dnxhdenc.c | 2 +-

[FFmpeg-devel] [PATCH 26/28] avcodec/mpegvideoencdsp: Factor draw_edges out in its own context

2024-05-06 Thread Andreas Rheinhardt
This allows to remove a dependency of the dirac decoder (!) on mpegvideoenc. Signed-off-by: Andreas Rheinhardt --- configure | 7 +- libavcodec/Makefile | 1 + libavcodec/diracdec.c | 14 +-- libavcodec/drawedgesdsp.c

[FFmpeg-devel] [PATCH 25/28] avcodec/x86/mpegvideoencdsp_init: Remove bits_per_raw_sample check

2024-05-06 Thread Andreas Rheinhardt
This check has been added in 19a0729b4cfacfd90b8ee84ab0c093ff7e397e65; this commit added high bit-depth versions of draw_edges and added the check to indicate that the mmx version only supports eight bits. Yet there is no high bit depth draw_edges function any more since

[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: av1 decoding not copying the sequence header obu into the bitstream

2024-05-06 Thread Черненко Руслан
Signed-off-by: Chernenko Ruslan --- libavcodec/videotoolbox_av1.c | 102 -- 1 file changed, 72 insertions(+), 30 deletions(-) diff --git a/libavcodec/videotoolbox_av1.c b/libavcodec/videotoolbox_av1.c index 7f7270c466..736f2548db 100644 ---

[FFmpeg-devel] [PATCH 1/2] WIP avcodec/videotoolbox: add AV1 hardware acceleration

2024-05-06 Thread Черненко Руслан
This patch adds support for hw accelerated AV1 decoding on new Apple Silicon M3 CPUs. It's registered on the trac [1] The first patch is the patch I used to proceed working on this feature from Jan Ekström . I took his commit from his branch on github [2]. This is my first patch into ffmpeg.

Re: [FFmpeg-devel] [PATCH 2/2] lavu/riscv: add hwprobe() for CPU detection

2024-05-06 Thread Martin Storsjö
On Fri, 3 May 2024, Rémi Denis-Courmont wrote: This adds the Linux-specific function call to detect CPU features. Unlike the more portable auxillary vector, this supports extensions other than single lettered ones. At this point, FFmpeg already needs this to detect Zba and Zbb at run-time, and

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/h265_profile_level: Expand profile compatibility checking

2024-05-06 Thread Mark Thompson
On 06/05/2024 20:56, Andreas Rheinhardt wrote: > Mark Thompson: >> Replace existing get_profile() with find_profile(), which finds the >> lowest compatible profile rather than requiring an exact match. >> --- >> Series changes since v1: >> * Added H265_PROFILE_INVALID with value zero because it

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Andreas Rheinhardt
Lynne: > May 6, 2024, 21:39 by andreas.rheinha...@outlook.com: > >> Lynne: >> >>> May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: >>> The approach used here has the advantage not to rely on any DCE. Also improve certain the checks from

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Lynne
May 6, 2024, 21:39 by andreas.rheinha...@outlook.com: > Lynne: > >> May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: >> >>> The approach used here has the advantage not to rely >>> on any DCE. >>> Also improve certain the checks from >>> 3390693bfb907765f833766f370e0ba8c7894f44 a bit. >>>

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/h265_profile_level: Expand profile compatibility checking

2024-05-06 Thread Andreas Rheinhardt
Mark Thompson: > Replace existing get_profile() with find_profile(), which finds the > lowest compatible profile rather than requiring an exact match. > --- > Series changes since v1: > * Added H265_PROFILE_INVALID with value zero because it simplifies some code > (and the values don't matter).

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h264: Don't try to merge fields in DPB for non-field pics

2024-05-06 Thread Mark Thompson
On 05/05/2024 17:36, David Rosca wrote: > This path can be hit when there are missing references while decoding > progressive stream and would completely break the DPB contents. > --- > libavcodec/vaapi_h264.c | 30 -- > 1 file changed, 16 insertions(+), 14

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Andreas Rheinhardt
Lynne: > May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: > >> The approach used here has the advantage not to rely >> on any DCE. >> Also improve certain the checks from >> 3390693bfb907765f833766f370e0ba8c7894f44 a bit. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>

Re: [FFmpeg-devel] [PATCH 4/6] nvdec_av1: Use av1dec force_integer_mv value

2024-05-06 Thread Mark Thompson
On 06/05/2024 18:19, Timo Rothenpieler wrote: > On 27.04.2024 17:30, Mark Thompson wrote: >> --- >>   libavcodec/nvdec_av1.c | 4 +--- >>   1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/libavcodec/nvdec_av1.c b/libavcodec/nvdec_av1.c >> index 4efa420e66..8a46db1ed5 100644 >> ---

Re: [FFmpeg-devel] [PATCH v3 6/9] lavc/vp8dsp: R-V V put_epel hv

2024-05-06 Thread Rémi Denis-Courmont
Le maanantaina 6. toukokuuta 2024, 6.38.06 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp8_put_epel4_h4v4_c: 20.0 > vp8_put_epel4_h4v4_rvv_i32: 11.0 > vp8_put_epel4_h4v6_c: 25.2 > vp8_put_epel4_h4v6_rvv_i32: 13.5 > vp8_put_epel4_h6v4_c: 22.2 > vp8_put_epel4_h6v4_rvv_i32: 14.5 >

[FFmpeg-devel] [PATCH v2 3/3] lavc/vaapi_hevc: Don't require exact profiles

2024-05-06 Thread Mark Thompson
Rather than turning the constraint flags into a single profile and then searching for that profile (and failing if it doesn't match any profile exactly), instead search all supported profiles and use the first one which supports the given set of constraint flags. --- libavcodec/vaapi_decode.c |

[FFmpeg-devel] [PATCH v2 2/3] lavc: Add test for H.265 profile handling

2024-05-06 Thread Mark Thompson
--- libavcodec/Makefile | 2 +- libavcodec/tests/.gitignore | 1 + libavcodec/tests/h265_profiles.c | 440 +++ tests/fate/libavcodec.mak| 5 + 4 files changed, 447 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH v2 1/3] lavc/h265_profile_level: Expand profile compatibility checking

2024-05-06 Thread Mark Thompson
Replace existing get_profile() with find_profile(), which finds the lowest compatible profile rather than requiring an exact match. --- Series changes since v1: * Added H265_PROFILE_INVALID with value zero because it simplifies some code (and the values don't matter). * Fixed the h265-levels

Re: [FFmpeg-devel] [PATCH 12/12] avcodec/aac/aacdec_(fixed|float): Set AACDecDSP, AACDecProc directly

2024-05-06 Thread Lynne
May 6, 2024, 14:16 by andreas.rheinha...@outlook.com: > This is more in line with how we initialize DSP functions > and avoids tables of function pointers as well as relocations > for these. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aac/aacdec_dsp_template.c | 43

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Fix type mismatch

2024-05-06 Thread Lynne
May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: > ff_aac_sbr_apply() and ff_aac_sbr_apply_fixed() still used > pointers to INTFLOAT which is float or int depending upon > whether USE_FIXED is set or not; in particular, according > to these declarations both functions have the same type. >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Lynne
May 6, 2024, 11:31 by andreas.rheinha...@outlook.com: > The approach used here has the advantage not to rely > on any DCE. > Also improve certain the checks from > 3390693bfb907765f833766f370e0ba8c7894f44 a bit. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aac/aacdec.c | 62

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-06 Thread Rémi Denis-Courmont
Le maanantaina 6. toukokuuta 2024, 20.18.11 EEST Ramiro Polla a écrit : > I'll send a similar patch to fix checkasm/idctdsp after this is merged. The idctdsp test does not actually test the iDCT, but only the trivial-ish add/put helpers, so it does not care about the context. You're welcome to

Re: [FFmpeg-devel] [PATCH v4 1/2] checkasm: add test for fdct

2024-05-06 Thread Rémi Denis-Courmont
Le maanantaina 6. toukokuuta 2024, 20.18.39 EEST Ramiro Polla a écrit : > Reviewed-by: Martin Storsjö > Reviewed-by: Rémi Denis-Courmont > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/checkasm/fdctdsp.c | 71

Re: [FFmpeg-devel] [PATCH 4/6] nvdec_av1: Use av1dec force_integer_mv value

2024-05-06 Thread Timo Rothenpieler
On 27.04.2024 17:30, Mark Thompson wrote: --- libavcodec/nvdec_av1.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/nvdec_av1.c b/libavcodec/nvdec_av1.c index 4efa420e66..8a46db1ed5 100644 --- a/libavcodec/nvdec_av1.c +++ b/libavcodec/nvdec_av1.c @@ -106,9

[FFmpeg-devel] [PATCH v4 1/2] checkasm: add test for fdct

2024-05-06 Thread Ramiro Polla
Reviewed-by: Martin Storsjö Reviewed-by: Rémi Denis-Courmont --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/fdctdsp.c | 71 +++ tests/fate/checkasm.mak | 1 + 5 files changed, 77

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-06 Thread Ramiro Polla
On Thu, May 2, 2024 at 8:05 PM Rémi Denis-Courmont wrote: > Le keskiviikkona 17. huhtikuuta 2024, 21.01.37 EEST Ramiro Polla a écrit : [...] > > +static void check_fdct(void) > > +{ > > +LOCAL_ALIGNED_16(int16_t, block0, [64]); > > +LOCAL_ALIGNED_16(int16_t, block1, [64]); > > + > > +

[FFmpeg-devel] [PATCH v2 0/2] Add support for H266/VVC encoding

2024-05-06 Thread Christian Bartnik
This patchset is based on the latest patchset from Thomas Siedel (thomas...@spin-digital.com). Since almost all changes from the patchset but libvvenc and libvvdec has been merged this patch only implements the libvvenc and libvvdec wrapper implementation. As ffmpeg already has it´s own vvc

[FFmpeg-devel] [PATCH v2 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-06 Thread Christian Bartnik
From: Thomas Siedel Add external encoder VVenC for H266/VVC encoding. Register new encoder libvvenc. Add libvvenc to wrap the vvenc interface. libvvenc implements encoder option: preset,qp,period,subjopt, vvenc-params,levelidc,tier. Enable encoder by adding --enable-libvvenc in configure step.

[FFmpeg-devel] [PATCH v2 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-06 Thread Christian Bartnik
From: Thomas Siedel Add external decoder VVdeC for H266/VVC decoding. Register new decoder libvvdec. Add vvc_parse_extradata to support parse/probe of vvcC stream input. Add vvc_paramset that implements the parser of vvcC configuration boxes. Add libvvdec to wrap the vvdec interface. Enable

Re: [FFmpeg-devel] [PATCH 1/3][GSoC 2024] libavcodec/vvc: convert (*sad) to (*sad[6]) to prepare for AVX2 funcs

2024-05-06 Thread Stone Chen
On Wed, May 1, 2024 at 6:59 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Stone Chen: > > To prepare for adding AVX2 functions for different block widths, change > VVCInterDSPContext to contain (*sad[6]) instead of (*sad). This also > default initializes the pointer array with

Re: [FFmpeg-devel] [PATCH 1/3] avutil/opt: add a note about the av_opt_set_chlayout() behavior

2024-05-06 Thread Andreas Rheinhardt
James Almer: > Based on the one for av_opt_set_dict_val(). > > Signed-off-by: James Almer > --- > libavutil/opt.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 2d76ec6105..1b30a32317 100644 > --- a/libavutil/opt.h > +++ b/libavutil/opt.h

[FFmpeg-devel] [PATCH 4/4] avutil/opt: free the temporary layout in av_opt_is_set_to_default()

2024-05-06 Thread James Almer
Signed-off-by: James Almer --- libavutil/opt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 23bc8c887c..2c5f422bd6 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -2309,7 +2309,9 @@ int av_opt_is_set_to_default(void *obj,

[FFmpeg-devel] [PATCH] tests/checkasm/svq1enc: Use proper range for input

2024-05-06 Thread Andreas Rheinhardt
ssd_int8_vs_int16 is only called from encode_block() in svq1enc.c; it calls it in stages: At stage 0, the int16_t array contains the difference of two uint16_t. At each of the following stages, the int16_t array is filled by subtracting an int8_t from the current stage's int16_t array. The maximum

[FFmpeg-devel] [PATCH 3/3] avutil/opt: propagate av_dict_copy() errors in av_opt_{get, set}_dict_val()

2024-05-06 Thread James Almer
Signed-off-by: James Almer --- libavutil/opt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 60b0c2a946..23bc8c887c 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -934,9 +934,8 @@ int av_opt_set_dict_val(void *obj, const

[FFmpeg-devel] [PATCH 2/3] avutil/opt: don't set a channel layout if the option is flagged as read only

2024-05-06 Thread James Almer
Signed-off-by: James Almer --- libavutil/opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index a892e056cb..60b0c2a946 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -949,6 +949,8 @@ int av_opt_set_chlayout(void *obj, const char *name,

[FFmpeg-devel] [PATCH 1/3] avutil/opt: add a note about the av_opt_set_chlayout() behavior

2024-05-06 Thread James Almer
Based on the one for av_opt_set_dict_val(). Signed-off-by: James Almer --- libavutil/opt.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 2d76ec6105..1b30a32317 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -797,6 +797,10 @@ int

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

2024-05-06 Thread Sean McGovern
Hi Brad, On Sun, May 5, 2024 at 11:22 PM Brad Smith wrote: > > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > Use the machdep.altivec sysctl on NetBSD for AltiVec detection > as is done with OpenBSD. > > Signed-off-by: Brad Smith > --- > libavutil/ppc/cpu.c | 6 +++--- > 1

[FFmpeg-devel] [PATCH v2 3/12] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Andreas Rheinhardt
The approach used here has the advantage not to rely on any DCE. Also improve certain the checks from 3390693bfb907765f833766f370e0ba8c7894f44 a bit. Signed-off-by: Andreas Rheinhardt --- Now also avoiding the casts in ff_aac_sbr_apply(). libavcodec/aac/aacdec.c | 63

Re: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-06 Thread Zhao Zhili
> On May 6, 2024, at 19:48, Guo, Yejun > wrote: > >> -Original Message- >> From: ffmpeg-devel > > On Behalf Of Zhao >> Zhili >> Sent: Tuesday, April 30, 2024 3:12 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao

Re: [FFmpeg-devel] [PATCH v2 4/4] tests/checkasm/vvc_alf: add check_alf_classify

2024-05-06 Thread Nuo Mi
On Wed, May 1, 2024 at 7:06 PM wrote: > From: Wu Jianhua > > Perforamnce Test (fps): > clip before after delta > Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36% > RitualDance_1920x1080_60_10_420_32_LD.266 272 481 76.83% >

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-05-06 Thread Nuo Mi
On Thu, Apr 25, 2024 at 10:02 PM Nuo Mi wrote: > For some error bitstreams, a CTU belongs to two slices/entry points. > If the decoder initializes and submmits the CTU task twice, it may crash > the program > or cause it to enter an infinite loop. > > Reported-by: Frank Plowman > > Applied.

[FFmpeg-devel] [PATCH 12/12] avcodec/aac/aacdec_(fixed|float): Set AACDecDSP, AACDecProc directly

2024-05-06 Thread Andreas Rheinhardt
This is more in line with how we initialize DSP functions and avoids tables of function pointers as well as relocations for these. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec_dsp_template.c | 43 ++- libavcodec/aac/aacdec_fixed.c | 4 +--

[FFmpeg-devel] [PATCH 11/12] avcodec/aac/aacdec: Move init functions to aacdec_fixed/float

2024-05-06 Thread Andreas Rheinhardt
This allows to merge it with AACDecDSP.init and remove the latter (it is called only once anyway); it also allows to make the fixed/float AACDecDSP and AACDecProc implementations internal to aacdec_fixed/float.c (which also fixes a violation of our naming conventions). And it avoids a

[FFmpeg-devel] [PATCH 10/12] avcodec/aac/aacdec: Avoid compiling latm decoder if disabled

2024-05-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 07dcc2672a..cd80dd1d7a 100644 --- a/libavcodec/aac/aacdec.c +++ b/libavcodec/aac/aacdec.c @@ -2510,7 +2510,9 @@ static int

[FFmpeg-devel] [PATCH 09/12] avcodec/aac/aacdec: Mark flush as cold

2024-05-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 1dc4af8a0d..07dcc2672a 100644 --- a/libavcodec/aac/aacdec.c +++ b/libavcodec/aac/aacdec.c @@ -539,7 +539,7 @@

[FFmpeg-devel] [PATCH 08/12] avcodec/aac/aacdec_(fixed|float): Avoid AAC_RENAME, INTFLOAT

2024-05-06 Thread Andreas Rheinhardt
Unnecessary now that this has been detemplatized. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec_fixed.c | 20 ++-- libavcodec/aac/aacdec_float.c | 18 +- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/libavcodec/aac/aacdec_fixed.c

[FFmpeg-devel] [PATCH 07/12] avcodec/aac/aacdec_float: Call ff_aac_float_common_init() only once

2024-05-06 Thread Andreas Rheinhardt
That's enough. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec_float.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aac/aacdec_float.c b/libavcodec/aac/aacdec_float.c index 5c4eec1204..511db1a604 100644 --- a/libavcodec/aac/aacdec_float.c +++

[FFmpeg-devel] [PATCH 06/12] avcodec/aac/aacdec: Avoid branch to set sample_fmt

2024-05-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index a78a669602..1dc4af8a0d 100644 --- a/libavcodec/aac/aacdec.c +++ b/libavcodec/aac/aacdec.c @@

[FFmpeg-devel] [PATCH 05/12] avcodec/aac/aacdec: Move channel number check out of init_dsp()

2024-05-06 Thread Andreas Rheinhardt
Also move initializing random_state. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index f6a7266123..a78a669602 100644 ---

[FFmpeg-devel] [PATCH 04/12] avcodec/aac/aacdec: Remove unnecessary ff_thread_once()

2024-05-06 Thread Andreas Rheinhardt
ff_aacdec_common_init_once() already uses its own AVOnce. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 6a74b05168..f6a7266123 100644 ---

Re: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-06 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Zhao > Zhili > Sent: Tuesday, April 30, 2024 3:12 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili > Subject: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN > parameter configuration system > > From: Zhao Zhili > >

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: only check index_edit_rate when calculating the index tables

2024-05-06 Thread Tomas Härdin
lör 2024-05-04 klockan 03:49 +0200 skrev Marton Balint: > > > On Fri, 3 May 2024, Tomas Härdin wrote: > > > tor 2024-05-02 klockan 23:01 +0200 skrev Marton Balint: > > > > > > > > > On Mon, 29 Apr 2024, Tomas Härdin wrote: > > > > > > > mån 2024-04-15 klockan 21:34 +0200 skrev Marton Balint:

[FFmpeg-devel] [PATCH 3/3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled

2024-05-06 Thread Andreas Rheinhardt
The approach used here has the advantage not to rely on any DCE. Also improve certain the checks from 3390693bfb907765f833766f370e0ba8c7894f44 a bit. Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 62 - 1 file changed, 31 insertions(+),

[FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Fix type mismatch

2024-05-06 Thread Andreas Rheinhardt
ff_aac_sbr_apply() and ff_aac_sbr_apply_fixed() still used pointers to INTFLOAT which is float or int depending upon whether USE_FIXED is set or not; in particular, according to these declarations both functions have the same type. But that is wrong and given that aacdec.c sets USE_FIXED, it sees

[FFmpeg-devel] [PATCH 1/3] avcodec/aactab: Provide ff_ltp_coef, ff_tns_tmp2_map unconditionally

2024-05-06 Thread Andreas Rheinhardt
The fixed point decoder needs it since 905fdb06010e554262fca3c12b362bb69a11de85. Signed-off-by: Andreas Rheinhardt --- libavcodec/aactab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 3cef9c5d2b..3718b81a07 100644 ---

Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe

2024-05-06 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: środa, 17 kwietnia 2024 14:39 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the > AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet > contains a