[FFmpeg-devel] [PATCH 3/3] avformat/img2dec: assert no pipe on ts_from_file

2024-05-07 Thread Michael Niedermayer
Help coverity with CID500302 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/img2dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index a40675d4341..6220003fb4d 100644 ---

[FFmpeg-devel] [PATCH 2/3] avformat/sdp: Check before appending ", "

2024-05-07 Thread Michael Niedermayer
Found by reviewing code related to CID1500301 String not null terminated Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/sdp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 7e11a759185..ccfaa8aff58 100644

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_jpeg: Assert that cbs_jpeg_assemble_fragment() stays within the array

2024-05-07 Thread Michael Niedermayer
Inspired by: CID1473561 Untrusted pointer write Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/cbs_jpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cbs_jpeg.c b/libavcodec/cbs_jpeg.c index b1b58dcd65e..628841c5f37 100644 ---

Re: [FFmpeg-devel] [PATCH v2 1/1] libavdevice/decklink: extend available actions on signal loss

2024-05-07 Thread Marton Balint
On Tue, 23 Apr 2024, Michael Riedl wrote: Deprecate the option 'draw_bars' in favor of the new option 'signal_loss_action', which controls the behavior when the input signal is not available (including the behavior previously available through draw_bars). The default behavior remains

Re: [FFmpeg-devel] Fixes #10509

2024-05-07 Thread Marton Balint
On Wed, 1 May 2024, Poorva wrote: On Fri, Apr 5, 2024 at 2:08 AM Marton Balint wrote: On Mon, 1 Apr 2024, Poorva wrote: >> >> >> > On Sun, Mar 31, 2024 at 8:35 PM Marton Balint wrote: > >> >> >> On Fri, 29 Mar 2024, Poorva wrote: >> >>> >>> On Tue, Mar 26, 2024 at 2:36 AM Poorva

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's

2024-05-07 Thread Marton Balint
On Sun, 5 May 2024, Brad Smith wrote: lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's The proper type was used until 73251678c83cbe24d08264da693411b166239bc7. This covers all of the OS's that currently have V4L2 support, permutations of Linux glibc/musl, Android

Re: [FFmpeg-devel] [PATCH 14/24] avfilter/Makefile: Add scale(2ref)->framesync dependency

2024-05-07 Thread Frank Plowman
On 05/05/2024 14:40, Andreas Rheinhardt wrote: > Forgotten in e82a3997cdd6c0894869b33ba42430ac3c57fb3b. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/Makefile b/libavfilter/Makefile >

Re: [FFmpeg-devel] [PATCH] lavf/vf_scale: Add framesync dependency to Makefile

2024-05-07 Thread Frank Plowman
On 07/05/2024 22:04, Frank Plowman wrote: > Since e82a3997cdd6c0894869b33ba42430ac3c57fb3b, the scale filter has > depended on FFFrameSync. Reflect this in the Makefile, fixing compile > errors under some configurations. > > Signed-off-by: Frank Plowman > --- > libavfilter/Makefile | 2 +- > 1

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/network: add ff_neterrno2() for cases where we already have an errno

2024-05-07 Thread Marton Balint
On Tue, 7 May 2024, Andrew Sayers wrote: On Sun, May 05, 2024 at 09:59:28PM +0200, Marton Balint wrote: On Fri, 19 Apr 2024, Andrew Sayers wrote: For example, WSAStartup()'s documentation says: "A call to the WSAGetLastError function is not needed and should not be used" ---

[FFmpeg-devel] [PATCH] lavf/vf_scale: Add framesync dependency to Makefile

2024-05-07 Thread Frank Plowman
Since e82a3997cdd6c0894869b33ba42430ac3c57fb3b, the scale filter has depended on FFFrameSync. Reflect this in the Makefile, fixing compile errors under some configurations. Signed-off-by: Frank Plowman --- libavfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/3] riscv: add Zvbb vector bit manipulation extension

2024-05-07 Thread Martin Storsjö
On Tue, 7 May 2024, Rémi Denis-Courmont wrote: --- Makefile | 2 +- configure | 3 +++ doc/APIchanges| 3 +++ ffbuild/arch.mak | 1 + libavutil/cpu.h | 1 + libavutil/tests/cpu.c | 1 + tests/checkasm/checkasm.c | 1 + 7 files

Re: [FFmpeg-devel] [PATCH] lavu/riscv: fix build without

2024-05-07 Thread Martin Storsjö
On Tue, 7 May 2024, Rémi Denis-Courmont wrote: --- libavutil/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/riscv/cpu.c b/libavutil/riscv/cpu.c index c3683b06d0..69d1afe853 100644 --- a/libavutil/riscv/cpu.c +++ b/libavutil/riscv/cpu.c @@ -29,14

Re: [FFmpeg-devel] [PATCH v4 1/5] configure: Remove libva 1.x support

2024-05-07 Thread Mark Thompson
On 07/05/2024 06:27, Xiang, Haihao wrote: > On So, 2024-05-05 at 20:01 +0100, Mark Thompson wrote: >> libva 2.0 was released in 2017 and the 2.x versions are included in all >> supported distributions nowadays.  Various features no longer need any >> configure check after this command, including

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h264: Fix merging fields in DPB with missing references

2024-05-07 Thread Mark Thompson
On 07/05/2024 07:00, David Rosca wrote: > If there are missing references, h264 decode does error concealment > by copying previous refs which means there will be duplicated surfaces > and this code would try to merge them instead of correctly appending > to DPB. Make sure the fields were actually

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_av1: Avoid sending the same slice buffer multiple times

2024-05-07 Thread Mark Thompson
On 28/04/2024 08:26, David Rosca wrote: > When there are multiple tiles in one slice buffer, use multiple slice > params to avoid sending the same slice buffer multiple times and thus > increasing the bitstream size the driver will need to upload to hw. > --- > libavcodec/vaapi_av1.c | 37

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/vp8dsp: R-V put_vp8_pixels

2024-05-07 Thread Lynne
May 7, 2024, 20:25 by r...@remlab.net: > Le tiistaina 7. toukokuuta 2024, 20.41.30 EEST Lynne a écrit : > >> May 7, 2024, 18:54 by u...@foxmail.com: >> > From: sunyuechi >> > >> > C908: >> > vp8_put_pixels4_c: 78.0 >> > vp8_put_pixels4_rvi: 33.7 >> > vp8_put_pixels8_c: 278.0 >> >

[FFmpeg-devel] [PATCH 3/3] lavc/ac3dsp: add R-V Zvbb extract_exponents

2024-05-07 Thread Rémi Denis-Courmont
--- libavcodec/riscv/Makefile | 1 + libavcodec/riscv/ac3dsp_init.c | 5 libavcodec/riscv/ac3dsp_rvvb.S | 43 ++ 3 files changed, 49 insertions(+) create mode 100644 libavcodec/riscv/ac3dsp_rvvb.S diff --git a/libavcodec/riscv/Makefile

[FFmpeg-devel] [PATCH 2/3] lavu/riscv: add Zvbb CPU capability detection

2024-05-07 Thread Rémi Denis-Courmont
This requires Linux kernel version 6.8 or later. --- libavutil/riscv/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavutil/riscv/cpu.c b/libavutil/riscv/cpu.c index 69d1afe853..3cf4e25bc9 100644 --- a/libavutil/riscv/cpu.c +++ b/libavutil/riscv/cpu.c @@ -54,6 +54,10 @@ int

[FFmpeg-devel] [PATCH 1/3] riscv: add Zvbb vector bit manipulation extension

2024-05-07 Thread Rémi Denis-Courmont
--- Makefile | 2 +- configure | 3 +++ doc/APIchanges| 3 +++ ffbuild/arch.mak | 1 + libavutil/cpu.h | 1 + libavutil/tests/cpu.c | 1 + tests/checkasm/checkasm.c | 1 + 7 files changed, 11 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH v2 3/9] lavc/vp9dsp: R-V V ipred hor

2024-05-07 Thread flow gg
> Do you gain much by unrolling all the way to 16x? Given that you have the > counter value already in t0, it should not make much difference to just unroll > 2x or maybe 4x and then loop. I chose this simple method because I think the effect is about the same.. Do I need to change it? > It

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/vp8dsp: R-V put_vp8_pixels

2024-05-07 Thread Rémi Denis-Courmont
Le tiistaina 7. toukokuuta 2024, 20.41.30 EEST Lynne a écrit : > May 7, 2024, 18:54 by u...@foxmail.com: > > From: sunyuechi > > > > C908: > > vp8_put_pixels4_c: 78.0 > > vp8_put_pixels4_rvi: 33.7 > > vp8_put_pixels8_c: 278.0 > > vp8_put_pixels8_rvi: 55.0 > > vp8_put_pixels16_c: 999.0 > >

[FFmpeg-devel] [PATCH 3/4] swscale/riscv: explicitly require Zbb for MIN

2024-05-07 Thread Rémi Denis-Courmont
--- libswscale/riscv/rgb2rgb_rvv.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv/rgb2rgb_rvv.S index 21e30ab8bb..19f7aaf67d 100644 --- a/libswscale/riscv/rgb2rgb_rvv.S +++ b/libswscale/riscv/rgb2rgb_rvv.S @@ -165,10

[FFmpeg-devel] [PATCH 4/4] lavu/riscv: remove bespoke assembler for MIN

2024-05-07 Thread Rémi Denis-Courmont
This is no longer necessary as Zbb is now always explicitly required. --- libavutil/riscv/asm.S | 5 - 1 file changed, 5 deletions(-) diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S index 9d76ab5617..14be5055f5 100644 --- a/libavutil/riscv/asm.S +++ b/libavutil/riscv/asm.S @@

[FFmpeg-devel] [PATCH 1/4] lavu/riscv: allow requesting a second extension

2024-05-07 Thread Rémi Denis-Courmont
--- libavutil/riscv/asm.S | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S index 0a9e2e0d3f..9d76ab5617 100644 --- a/libavutil/riscv/asm.S +++ b/libavutil/riscv/asm.S @@ -36,13 +36,16 @@ #define HWD #endif -

[FFmpeg-devel] [PATCH 2/4] lavc/riscv: explicitly require Zbb for MIN

2024-05-07 Thread Rémi Denis-Courmont
--- libavcodec/riscv/aacpsdsp_rvv.S | 2 +- libavcodec/riscv/opusdsp_rvv.S | 2 +- libavcodec/riscv/sbrdsp_rvv.S | 8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/riscv/aacpsdsp_rvv.S b/libavcodec/riscv/aacpsdsp_rvv.S index a79d7d7818..2d6858688a 100644

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/signature_lookup: fix possible division by zero

2024-05-07 Thread Michael Niedermayer
On Mon, May 06, 2024 at 12:30:39AM +0200, Gerion Entrup wrote: > --- > libavfilter/signature_lookup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c > index a0ca818a9b..b39a3e225b 100644 > ---

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/vp8dsp: R-V put_vp8_pixels

2024-05-07 Thread Lynne
May 7, 2024, 18:54 by u...@foxmail.com: > From: sunyuechi > > C908: > vp8_put_pixels4_c: 78.0 > vp8_put_pixels4_rvi: 33.7 > vp8_put_pixels8_c: 278.0 > vp8_put_pixels8_rvi: 55.0 > vp8_put_pixels16_c: 999.0 > vp8_put_pixels16_rvi: 86.7 > --- > libavcodec/riscv/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH v4 2/9] lavc/vp8dsp: R-V V put_bilin_h v

2024-05-07 Thread flow gg
> h is not a number so that's not a valid condition. Fixed two of this issue 于2024年5月8日周三 00:55写道: > From: sunyuechi > > C908: > vp8_put_bilin4_h_c: 367.0 > vp8_put_bilin4_h_rvv_i32: 137.7 > vp8_put_bilin4_v_c: 377.0 > vp8_put_bilin4_v_rvv_i32: 137.7 > vp8_put_bilin8_h_c: 1431.0 >

[FFmpeg-devel] [PATCH v4 9/9] lavc/vp8dsp: R-V V loop_filter

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_loop_filter8uv_v_c: 745.5 vp8_loop_filter8uv_v_rvv_i32: 467.2 vp8_loop_filter16y_h_c: 674.2 vp8_loop_filter16y_h_rvv_i32: 553.0 vp8_loop_filter16y_v_c: 732.7 vp8_loop_filter16y_v_rvv_i32: 324.5 --- libavcodec/riscv/vp8dsp_init.c | 4 +++ libavcodec/riscv/vp8dsp_rvv.S

[FFmpeg-devel] [PATCH v4 8/9] lavc/vp8dsp: R-V V loop_filter_inner

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_loop_filter8uv_inner_v_c: 738.2 vp8_loop_filter8uv_inner_v_rvv_i32: 455.2 vp8_loop_filter16y_inner_h_c: 685.0 vp8_loop_filter16y_inner_h_rvv_i32: 497.0 vp8_loop_filter16y_inner_v_c: 743.7 vp8_loop_filter16y_inner_v_rvv_i32: 295.7 --- libavcodec/riscv/vp8dsp_init.c |

[FFmpeg-devel] [PATCH v4 7/9] lavc/vp8dsp: R-V V loop_filter_simple

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_loop_filter_simple_h_c: 416.0 vp8_loop_filter_simple_h_rvv_i32: 187.5 vp8_loop_filter_simple_v_c: 429.7 vp8_loop_filter_simple_v_rvv_i32: 104.0 --- libavcodec/riscv/vp8dsp_init.c | 5 ++ libavcodec/riscv/vp8dsp_rvv.S | 85 ++ 2 files

[FFmpeg-devel] [PATCH v4 3/9] lavc/vp8dsp: R-V V put_bilin_hv

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_put_bilin4_hv_c: 561.0 vp8_put_bilin4_hv_rvv_i32: 232.7 vp8_put_bilin8_hv_c: 2162.7 vp8_put_bilin8_hv_rvv_i32: 506.7 vp8_put_bilin16_hv_c: 4769.7 vp8_put_bilin16_hv_rvv_i32: 556.7 --- libavcodec/riscv/vp8dsp_init.c | 13 + libavcodec/riscv/vp8dsp_rvv.S |

[FFmpeg-devel] [PATCH v4 6/9] lavc/vp8dsp: R-V V put_epel hv

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_put_epel4_h4v4_c: 20.0 vp8_put_epel4_h4v4_rvv_i32: 11.0 vp8_put_epel4_h4v6_c: 25.2 vp8_put_epel4_h4v6_rvv_i32: 13.5 vp8_put_epel4_h6v4_c: 22.2 vp8_put_epel4_h6v4_rvv_i32: 14.5 vp8_put_epel4_h6v6_c: 29.0 vp8_put_epel4_h6v6_rvv_i32: 15.7 vp8_put_epel8_h4v4_c: 73.0

[FFmpeg-devel] [PATCH v4 5/9] lavc/vp8dsp: R-V V put_epel v

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_put_epel4_v4_c: 11.0 vp8_put_epel4_v4_rvv_i32: 5.0 vp8_put_epel4_v6_c: 16.5 vp8_put_epel4_v6_rvv_i32: 6.2 vp8_put_epel8_v4_c: 43.7 vp8_put_epel8_v4_rvv_i32: 11.2 vp8_put_epel8_v6_c: 68.7 vp8_put_epel8_v6_rvv_i32: 13.2 vp8_put_epel16_v4_c: 92.5 vp8_put_epel16_v4_rvv_i32:

[FFmpeg-devel] [PATCH v4 4/9] lavc/vp8dsp: R-V V put_epel h

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_put_epel4_h4_c: 10.7 vp8_put_epel4_h4_rvv_i32: 5.0 vp8_put_epel4_h6_c: 15.0 vp8_put_epel4_h6_rvv_i32: 6.2 vp8_put_epel8_h4_c: 43.2 vp8_put_epel8_h4_rvv_i32: 11.2 vp8_put_epel8_h6_c: 57.5 vp8_put_epel8_h6_rvv_i32: 13.5 vp8_put_epel16_h4_c: 92.5 vp8_put_epel16_h4_rvv_i32:

[FFmpeg-devel] [PATCH v4 2/9] lavc/vp8dsp: R-V V put_bilin_h v

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_put_bilin4_h_c: 367.0 vp8_put_bilin4_h_rvv_i32: 137.7 vp8_put_bilin4_v_c: 377.0 vp8_put_bilin4_v_rvv_i32: 137.7 vp8_put_bilin8_h_c: 1431.0 vp8_put_bilin8_h_rvv_i32: 297.5 vp8_put_bilin8_v_c: 1449.0 vp8_put_bilin8_v_rvv_i32: 297.5 vp8_put_bilin16_h_c: 2839.0

[FFmpeg-devel] [PATCH v4 1/9] lavc/vp8dsp: R-V put_vp8_pixels

2024-05-07 Thread uk7b
From: sunyuechi C908: vp8_put_pixels4_c: 78.0 vp8_put_pixels4_rvi: 33.7 vp8_put_pixels8_c: 278.0 vp8_put_pixels8_rvi: 55.0 vp8_put_pixels16_c: 999.0 vp8_put_pixels16_rvi: 86.7 --- libavcodec/riscv/Makefile | 1 + libavcodec/riscv/vp8dsp.h | 75 ++

Re: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-07 Thread Zhao Zhili
On 2024/5/6 21:42, Zhao Zhili wrote: On May 6, 2024, at 19:48, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel On Behalf Of Zhao Zhili Sent: Tuesday, April 30, 2024 3:12 PM To: ffmpeg-devel@ffmpeg.org Cc: Zhao Zhili Subject: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn:

Re: [FFmpeg-devel] [PATCH v3 2/9] lavc/vp8dsp: R-V V put_bilin_h v

2024-05-07 Thread Rémi Denis-Courmont
Le tiistaina 7. toukokuuta 2024, 19.07.46 EEST flow gg a écrit : > I didn't understand what you mean... What does judging whether the type is > 'h' or 'v' have to do with the number? == is only valid over numeric values, not identifiers. -- レミ・デニ-クールモン http://www.remlab.net/

[FFmpeg-devel] [PATCH v4 10/11] avfilter/dnn: Remove a level of dereference

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19

Re: [FFmpeg-devel] [PATCH v2 3/9] lavc/vp9dsp: R-V V ipred hor

2024-05-07 Thread Rémi Denis-Courmont
Le tiistaina 7. toukokuuta 2024, 10.36.07 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp9_hor_8x8_8bpp_c: 74.7 > vp9_hor_8x8_8bpp_rvv_i32: 35.7 > vp9_hor_16x16_8bpp_c: 175.5 > vp9_hor_16x16_8bpp_rvv_i32: 80.2 > vp9_hor_32x32_8bpp_c: 510.2 > vp9_hor_32x32_8bpp_rvv_i32: 264.0 >

[FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null pointer dereference

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/vf_dnn_detect.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index b4eee06fe7..2a277d4169 100644 --- a/libavfilter/vf_dnn_detect.c +++

[FFmpeg-devel] [PATCH v4 05/11] avfilter/dnn_backend_openvino: simplify memory allocation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index ba79eba73f..1a5ed6383a

[FFmpeg-devel] [PATCH v4 06/11] avfilter/dnn_backend_tf: Remove one level of indentation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 0ab3bd13ed..eb4a2a5289 100644 ---

[FFmpeg-devel] [PATCH v4 09/11] avfilter/dnn_backend_torch: Simplify memory allocation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index b70e4db600..0aa0b95269

[FFmpeg-devel] [PATCH v4 08/11] avfilter/dnn_backend_tf: Simplify memory allocation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 8b53a3b87a..583ebd7c13 100644 ---

[FFmpeg-devel] [PATCH v4 07/11] avfilter/dnn_backend_tf: Fix free context at random place

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index eb4a2a5289..8b53a3b87a 100644

[FFmpeg-devel] [PATCH v4 01/11] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_STRING

[FFmpeg-devel] [PATCH v4 04/11] avfilter/dnn_backend_openvino: Fix free context at random place

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 5ea8fb8d1f..ba79eba73f

[FFmpeg-devel] [PATCH v4 03/11] avfilter/dnn: Don't show backends which are not supported by a filter

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_interface.c | 11 --- libavfilter/dnn_filter_common.h | 11 +-- libavfilter/dnn_interface.h | 8 ++-- libavfilter/vf_derain.c | 2 +- libavfilter/vf_dnn_classify.c | 2 +- libavfilter/vf_dnn_detect.c | 2 +-

[FFmpeg-devel] [PATCH v4 00/11] Refactor DNN

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili v4: 1. Move [patch v3 9/10] to [patch v4 2/11], since patch 3 depends on it. 2. Don't show backends which are not supported by a filter (patch 3). v3: 1. Init class with ff_dnn_filter_init_child_class and called by AVFilter preinit. 2. Fix crash in vf_dnn_detect (patch 10/10).

[FFmpeg-devel] [PATCH v4 02/11] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h

Re: [FFmpeg-devel] [PATCH v3 2/9] lavc/vp8dsp: R-V V put_bilin_h v

2024-05-07 Thread flow gg
I didn't understand what you mean... What does judging whether the type is 'h' or 'v' have to do with the number? Rémi Denis-Courmont 于2024年5月8日周三 00:00写道: > Le maanantaina 6. toukokuuta 2024, 6.38.02 EEST u...@foxmail.com a écrit : > > From: sunyuechi > > > > C908: > > vp8_put_bilin4_h_c:

Re: [FFmpeg-devel] [PATCH v3 2/9] lavc/vp8dsp: R-V V put_bilin_h v

2024-05-07 Thread Rémi Denis-Courmont
Le maanantaina 6. toukokuuta 2024, 6.38.02 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp8_put_bilin4_h_c: 367.0 > vp8_put_bilin4_h_rvv_i32: 137.7 > vp8_put_bilin4_v_c: 377.0 > vp8_put_bilin4_v_rvv_i32: 137.7 > vp8_put_bilin8_h_c: 1431.0 > vp8_put_bilin8_h_rvv_i32: 297.5 >

[FFmpeg-devel] [PATCH] lavc/vp9dsp: fix compilation with llvm-as

2024-05-07 Thread Rémi Denis-Courmont
--- libavcodec/riscv/vp9_intra_rvv.S | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/riscv/vp9_intra_rvv.S b/libavcodec/riscv/vp9_intra_rvv.S index db9774c263..40e38ba83e 100644 --- a/libavcodec/riscv/vp9_intra_rvv.S +++ b/libavcodec/riscv/vp9_intra_rvv.S

[FFmpeg-devel] [PATCH] lavu/riscv: fix build without

2024-05-07 Thread Rémi Denis-Courmont
--- libavutil/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/riscv/cpu.c b/libavutil/riscv/cpu.c index c3683b06d0..69d1afe853 100644 --- a/libavutil/riscv/cpu.c +++ b/libavutil/riscv/cpu.c @@ -29,14 +29,14 @@ #include #define HWCAP_RV(letter) (1ul

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests

2024-05-07 Thread James Almer
On 5/7/2024 12:14 PM, Andreas Rheinhardt wrote: James Almer: The requirement is either 8 or 16 bytes alignment, not 32. This should help finding bugs in asm implementations. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 23 +-- 1 file changed, 9

Re: [FFmpeg-devel] [PATCH 3/3] x86/blockdsp: add sse2 and avx2 versions of fill_block_tab

2024-05-07 Thread James Almer
On 5/7/2024 12:10 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/x86/blockdsp.asm| 33 + libavcodec/x86/blockdsp_init.c | 13 + 2 files changed, 46 insertions(+) diff --git a/libavcodec/x86/blockdsp.asm

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests

2024-05-07 Thread Andreas Rheinhardt
James Almer: > The requirement is either 8 or 16 bytes alignment, not 32. > This should help finding bugs in asm implementations. > > Signed-off-by: James Almer > --- > tests/checkasm/blockdsp.c | 23 +-- > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 3/3] x86/blockdsp: add sse2 and avx2 versions of fill_block_tab

2024-05-07 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/x86/blockdsp.asm| 33 + > libavcodec/x86/blockdsp_init.c | 13 + > 2 files changed, 46 insertions(+) > > diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm > index

[FFmpeg-devel] [PATCH 3/3] x86/blockdsp: add sse2 and avx2 versions of fill_block_tab

2024-05-07 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/blockdsp.asm| 33 + libavcodec/x86/blockdsp_init.c | 13 + 2 files changed, 46 insertions(+) diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm index e380308d4a..9a801a 100644

[FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests

2024-05-07 Thread James Almer
The requirement is either 8 or 16 bytes alignment, not 32. This should help finding bugs in asm implementations. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/tests/checkasm/blockdsp.c

Re: [FFmpeg-devel] [PATCH 1/2] tests/checkasm/blockdsp: Fix unaligned stores

2024-05-07 Thread James Almer
On 5/7/2024 7:29 AM, Andreas Rheinhardt wrote: Fixes this test with UBSan (and maybe also on arches on which unaligned stores trap). Signed-off-by: Andreas Rheinhardt --- tests/checkasm/blockdsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-07 Thread Christian
> On 7. May 2024, at 03:53, Nuo Mi wrote: > > Hi Christian, > Thank you for the patch. > Let us review and merge the encoder part. > > On Tue, May 7, 2024 at 1:05 AM Christian Bartnik > > wrote: > >> From: Thomas Siedel >> >> Add external encoder VVenC for

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/network: add ff_neterrno2() for cases where we already have an errno

2024-05-07 Thread Andrew Sayers
On Sun, May 05, 2024 at 09:59:28PM +0200, Marton Balint wrote: > > > On Fri, 19 Apr 2024, Andrew Sayers wrote: > > > For example, WSAStartup()'s documentation says: > > > >"A call to the WSAGetLastError function is not needed and should not be > > used" > > --- > > libavformat/network.c |

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/network: Return 0/AVERROR from ff_network_init()

2024-05-07 Thread Andrew Sayers
On Sun, May 05, 2024 at 10:05:36PM +0200, Marton Balint wrote: > > > On Sat, 20 Apr 2024, Andrew Sayers wrote: > > > --- > > libavformat/avio.c| 4 ++-- > > libavformat/network.c | 7 +++ > > libavformat/rtsp.c| 12 ++-- > > libavformat/rtspdec.c | 4 ++-- > >

Re: [FFmpeg-devel] [PATCH 1/2] tests/checkasm/blockdsp: Fix unaligned stores

2024-05-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes this test with UBSan (and maybe also on arches on which > unaligned stores trap). > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/blockdsp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/checkasm/blockdsp.c

Re: [FFmpeg-devel] [PATCH] checkasm/blockdsp: don't randomize the buffers for fill_block_tab

2024-05-07 Thread James Almer
On 5/7/2024 7:49 AM, Andreas Rheinhardt wrote: Martin Storsjö: On Mon, 6 May 2024, James Almer wrote: It ignores and overwrites the previous values. Fixes running the test under ubsan. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] checkasm/blockdsp: don't randomize the buffers for fill_block_tab

2024-05-07 Thread Martin Storsjö
On Tue, 7 May 2024, Andreas Rheinhardt wrote: Martin Storsjö: On Mon, 6 May 2024, James Almer wrote: It ignores and overwrites the previous values. Fixes running the test under ubsan. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] checkasm/blockdsp: don't randomize the buffers for fill_block_tab

2024-05-07 Thread Andreas Rheinhardt
Martin Storsjö: > On Mon, 6 May 2024, James Almer wrote: > >> It ignores and overwrites the previous values. >> Fixes running the test under ubsan. >> >> Signed-off-by: James Almer >> --- >> tests/checkasm/blockdsp.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > The change is

[FFmpeg-devel] [PATCH 2/2] tests/checkasm/blockdsp: Speed up randomizing buffer

2024-05-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/checkasm/blockdsp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/blockdsp.c b/tests/checkasm/blockdsp.c index f6f25f773e..4cd0fa3c82 100644 --- a/tests/checkasm/blockdsp.c +++ b/tests/checkasm/blockdsp.c @@

[FFmpeg-devel] [PATCH 1/2] tests/checkasm/blockdsp: Fix unaligned stores

2024-05-07 Thread Andreas Rheinhardt
Fixes this test with UBSan (and maybe also on arches on which unaligned stores trap). Signed-off-by: Andreas Rheinhardt --- tests/checkasm/blockdsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/checkasm/blockdsp.c b/tests/checkasm/blockdsp.c index

Re: [FFmpeg-devel] [PATCH 1/9] configure: Add missing dirac_decoder->qpeldsp dependency

2024-05-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in fd0e37f126b3dc2d0c352869cb8e5f568e5906f3. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ed74583a6f..61049017d8 100755 > --- a/configure > +++

Re: [FFmpeg-devel] [PATCH 25/28] avcodec/x86/mpegvideoencdsp_init: Remove bits_per_raw_sample check

2024-05-07 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, May 06, 2024 at 11:52:24PM +0200, Andreas Rheinhardt wrote: >> This check has been added in 19a0729b4cfacfd90b8ee84ab0c093ff7e397e65; >> this commit added high bit-depth versions of draw_edges >> and added the check to indicate that the mmx version only >> supports

Re: [FFmpeg-devel] [PATCH v2 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-07 Thread flow gg
Fixed issues similar to vp8 于2024年5月7日周二 15:36写道: > From: sunyuechi > > C908: > vp9_vert_8x8_8bpp_c: 22.0 > vp9_vert_8x8_8bpp_rvi: 15.7 > vp9_vert_16x16_8bpp_c: 71.2 > vp9_vert_16x16_8bpp_rvi: 39.0 > vp9_vert_32x32_8bpp_c: 300.2 > vp9_vert_32x32_8bpp_rvi: 135.2 > --- >

[FFmpeg-devel] [PATCH v2 5/9] lavc/vp9dsp: R-V V mc avg

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_avg4_8bpp_c: 1.2 vp9_avg4_8bpp_rvv_i64: 1.0 vp9_avg8_8bpp_c: 3.7 vp9_avg8_8bpp_rvv_i64: 1.5 vp9_avg16_8bpp_c: 14.7 vp9_avg16_8bpp_rvv_i64: 3.5 vp9_avg32_8bpp_c: 57.7 vp9_avg32_8bpp_rvv_i64: 10.0 vp9_avg64_8bpp_c: 229.0 vp9_avg64_8bpp_rvv_i64: 31.7 ---

[FFmpeg-devel] [PATCH v2 9/9] lavc/vp9dsp: R-V V mc tap hv

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_avg_8tap_smooth_4hv_8bpp_c: 32.0 vp9_avg_8tap_smooth_4hv_8bpp_rvv_i64: 15.0 vp9_avg_8tap_smooth_8hv_8bpp_c: 114.5 vp9_avg_8tap_smooth_8hv_8bpp_rvv_i64: 40.5 vp9_avg_8tap_smooth_16hv_8bpp_c: 338.7 vp9_avg_8tap_smooth_16hv_8bpp_rvv_i64: 46.5

[FFmpeg-devel] [PATCH v2 8/9] lavc/vp9dsp: R-V V mc bilin hv

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_avg_bilin_4hv_8bpp_c: 11.0 vp9_avg_bilin_4hv_8bpp_rvv_i64: 3.7 vp9_avg_bilin_8hv_8bpp_c: 38.7 vp9_avg_bilin_8hv_8bpp_rvv_i64: 7.2 vp9_avg_bilin_16hv_8bpp_c: 147.0 vp9_avg_bilin_16hv_8bpp_rvv_i64: 14.2 vp9_avg_bilin_32hv_8bpp_c: 574.5 vp9_avg_bilin_32hv_8bpp_rvv_i64:

[FFmpeg-devel] [PATCH v2 7/9] lavc/vp9dsp: R-V V mc tap h v

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_avg_8tap_smooth_4h_8bpp_c: 13.0 vp9_avg_8tap_smooth_4h_8bpp_rvv_i64: 5.0 vp9_avg_8tap_smooth_4v_8bpp_c: 13.7 vp9_avg_8tap_smooth_4v_8bpp_rvv_i64: 5.0 vp9_avg_8tap_smooth_8h_8bpp_c: 48.7 vp9_avg_8tap_smooth_8h_8bpp_rvv_i64: 9.5 vp9_avg_8tap_smooth_8v_8bpp_c: 50.0

[FFmpeg-devel] [PATCH v2 6/9] lavc/vp9dsp: R-V V mc bilin h v

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_avg_bilin_4h_8bpp_c: 5.2 vp9_avg_bilin_4h_8bpp_rvv_i64: 2.2 vp9_avg_bilin_4v_8bpp_c: 5.5 vp9_avg_bilin_4v_8bpp_rvv_i64: 2.2 vp9_avg_bilin_8h_8bpp_c: 20.0 vp9_avg_bilin_8h_8bpp_rvv_i64: 4.5 vp9_avg_bilin_8v_8bpp_c: 21.0 vp9_avg_bilin_8v_8bpp_rvv_i64: 4.2

[FFmpeg-devel] [PATCH v2 4/9] lavc/vp9dsp: R-V V ipred tm

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_tm_4x4_8bpp_c: 116.5 vp9_tm_4x4_8bpp_rvv_i32: 43.5 vp9_tm_8x8_8bpp_c: 416.2 vp9_tm_8x8_8bpp_rvv_i32: 86.0 vp9_tm_16x16_8bpp_c: 1665.5 vp9_tm_16x16_8bpp_rvv_i32: 187.2 vp9_tm_32x32_8bpp_c: 6974.2 vp9_tm_32x32_8bpp_rvv_i32: 625.7 --- libavcodec/riscv/vp9_intra_rvv.S |

[FFmpeg-devel] [PATCH v2 3/9] lavc/vp9dsp: R-V V ipred hor

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_hor_8x8_8bpp_c: 74.7 vp9_hor_8x8_8bpp_rvv_i32: 35.7 vp9_hor_16x16_8bpp_c: 175.5 vp9_hor_16x16_8bpp_rvv_i32: 80.2 vp9_hor_32x32_8bpp_c: 510.2 vp9_hor_32x32_8bpp_rvv_i32: 264.0 --- libavcodec/riscv/vp9_intra_rvv.S | 56

[FFmpeg-devel] [PATCH v2 2/9] lavc/vp9dsp: R-V mc copy

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_put4_8bpp_c: 0.7 vp9_put4_8bpp_rvi: 0.5 vp9_put8_8bpp_c: 2.5 vp9_put8_8bpp_rvi: 0.5 vp9_put16_8bpp_c: 16.7 vp9_put16_8bpp_rvi: 1.5 vp9_put32_8bpp_c: 37.2 vp9_put32_8bpp_rvi: 5.7 vp9_put64_8bpp_c: 107.5 vp9_put64_8bpp_rvi: 21.7 --- libavcodec/riscv/Makefile | 3

[FFmpeg-devel] [PATCH v2 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-07 Thread uk7b
From: sunyuechi C908: vp9_vert_8x8_8bpp_c: 22.0 vp9_vert_8x8_8bpp_rvi: 15.7 vp9_vert_16x16_8bpp_c: 71.2 vp9_vert_16x16_8bpp_rvi: 39.0 vp9_vert_32x32_8bpp_c: 300.2 vp9_vert_32x32_8bpp_rvi: 135.2 --- libavcodec/riscv/Makefile| 1 + libavcodec/riscv/vp9_intra_rvi.S | 61

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: Make it possible to send multiple slice params buffers

2024-05-07 Thread Xiang, Haihao
On So, 2024-04-28 at 09:26 +0200, David Rosca wrote: > --- >  libavcodec/vaapi_av1.c    | 2 +- >  libavcodec/vaapi_decode.c | 3 ++- >  libavcodec/vaapi_decode.h | 1 + >  libavcodec/vaapi_h264.c   | 2 +- >  libavcodec/vaapi_hevc.c   | 4 ++-- >  libavcodec/vaapi_mjpeg.c  | 2 +- >  

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h264: Don't try to merge fields in DPB for non-field pics

2024-05-07 Thread David Rosca
On Mon, May 6, 2024 at 9:55 PM Mark Thompson wrote: > > On 05/05/2024 17:36, David Rosca wrote: > > This path can be hit when there are missing references while decoding > > progressive stream and would completely break the DPB contents. > > --- > > libavcodec/vaapi_h264.c | 30

[FFmpeg-devel] [PATCH] lavc/vaapi_h264: Fix merging fields in DPB with missing references

2024-05-07 Thread David Rosca
If there are missing references, h264 decode does error concealment by copying previous refs which means there will be duplicated surfaces and this code would try to merge them instead of correctly appending to DPB. Make sure the fields were actually merged before early return. ---