Re: [FFmpeg-devel] [PATCH v3 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-13 Thread flow gg
I am locally using: if (bpp == 8 && (flags & AV_CPU_FLAG_RVI) && (flags & AV_CPU_FLAG_RVB_ADDR)) { this performs better on k230/banana_f3 than C. For email, refer to [FFmpeg-devel] [PATCH 2/2] lavc/vp8dsp: restrict RVI optimisations and change it to if (bpp == 8 && (flags &

Re: [FFmpeg-devel] [PATCH v3 2/9] lavc/vp9dsp: R-V mc copy

2024-05-13 Thread flow gg
I am locally using: if (bpp == 8 && (flags & AV_CPU_FLAG_RVI)) { this performs better on k230/banana_f3 than C. For email, refer to [FFmpeg-devel] [PATCH 2/2] lavc/vp8dsp: restrict RVI optimisations and change it to if (bpp == 8 && (flags & AV_CPU_FLAG_RV_MISALIGNED)) { So no output, but I

[FFmpeg-devel] [PATCH v2 3/3] avfilter/af_volumedetect.c: reindent after last commit

2024-05-13 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 68 +-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index dbbcd037a5..b78b073c09 100644 --- a/libavfilter/af_volumedetect.c +++

[FFmpeg-devel] [PATCH v2 2/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-05-13 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 159 -- 1 file changed, 133 insertions(+), 26 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 327801a7f9..dbbcd037a5 100644 --- a/libavfilter/af_volumedetect.c +++

[FFmpeg-devel] [PATCH v2 1/3] avfilter/af_volumedetect.c: Move logdb function

2024-05-13 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 8b001d1cf2..327801a7f9 100644 --- a/libavfilter/af_volumedetect.c +++ b/libavfilter/af_volumedetect.c @@

[FFmpeg-devel] [WIP] False positives on Coverity

2024-05-13 Thread Michael Niedermayer
Hi all To keep people updated (and as this is not vissible on the ML) heres my current list of issues marked as false positives / intentional in Mai & April 2024 (in case anyone wants to review, i presume noone wants but just in case) 1409917 Unintentional integer overflow No overflow happens

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/flac_parser: Assert that we do not overrun the link_penalty array

2024-05-13 Thread Michael Niedermayer
On Mon, May 13, 2024 at 10:45:16PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1454676 Out-of-bounds read > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/flac_parser.c | 2 ++ > > 1 file changed, 2 insertions(+) >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread James Almer
On 5/13/2024 7:49 PM, Michael Niedermayer wrote: On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote: On Mon, 13 May 2024, 02:32 Michael Niedermayer, wrote: On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: Fixes: CID1439574 Dereference after null check

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread Michael Niedermayer
On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote: > On Mon, 13 May 2024, 02:32 Michael Niedermayer, > wrote: > > > On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: > > > Fixes: CID1439574 Dereference after null check > > > > > > Sponsored-by: Sovereign Tech Fund

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case

2024-05-13 Thread Michael Niedermayer
On Mon, May 13, 2024 at 10:35:44AM +0200, Tomas Härdin wrote: > fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer: > > Fixes: CID1460979 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > >  libavcodec/jpeg2000dec.c | 3 --- >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/flac_parser: Assert that we do not overrun the link_penalty array

2024-05-13 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1454676 Out-of-bounds read > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/flac_parser.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/flac_parser.c b/libavcodec/flac_parser.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/flac_parser: Assert that we do not overrun the link_penalty array

2024-05-13 Thread Michael Niedermayer
Hi On Mon, May 13, 2024 at 09:07:50AM +0300, Rémi Denis-Courmont wrote: > > > Le 5 mai 2024 02:51:59 GMT+03:00, Michael Niedermayer > a écrit : > >Fixes: CID1454676 Out-of-bounds read > > It's a stretch to call this "fixing". It just asserts that the situation > doesn't happen, yes > in

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread Michael Niedermayer
On Mon, May 13, 2024 at 09:04:34AM +0300, Rémi Denis-Courmont wrote: > > > Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer > a écrit : > >Fixes: CID1439574 Dereference after null check > > If SPS is guaranteed to be non-NULL, there should probably be an assertion to > document it, and

Re: [FFmpeg-devel] [PATCH v3 2/9] lavc/vp9dsp: R-V mc copy

2024-05-13 Thread Rémi Denis-Courmont
Le maanantaina 13. toukokuuta 2024, 19.59.19 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp9_put4_8bpp_c: 0.7 > vp9_put4_8bpp_rvi: 0.5 > vp9_put8_8bpp_c: 2.5 > vp9_put8_8bpp_rvi: 0.5 > vp9_put16_8bpp_c: 16.7 > vp9_put16_8bpp_rvi: 1.5 > vp9_put32_8bpp_c: 37.2 >

Re: [FFmpeg-devel] [PATCH v3 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-13 Thread Rémi Denis-Courmont
Le maanantaina 13. toukokuuta 2024, 19.59.18 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp9_vert_8x8_8bpp_c: 22.0 > vp9_vert_8x8_8bpp_rvi: 15.7 > vp9_vert_16x16_8bpp_c: 71.2 > vp9_vert_16x16_8bpp_rvi: 39.0 > vp9_vert_32x32_8bpp_c: 300.2 > vp9_vert_32x32_8bpp_rvi: 135.2 Not

Re: [FFmpeg-devel] [PATCH v3 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-13 Thread Rémi Denis-Courmont
Le maanantaina 13. toukokuuta 2024, 19.59.18 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp9_vert_8x8_8bpp_c: 22.0 > vp9_vert_8x8_8bpp_rvi: 15.7 > vp9_vert_16x16_8bpp_c: 71.2 > vp9_vert_16x16_8bpp_rvi: 39.0 > vp9_vert_32x32_8bpp_c: 300.2 > vp9_vert_32x32_8bpp_rvi: 135.2 > --- >

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_geq: fix interpolation with 1 pixel width/height

2024-05-13 Thread Marton Balint
On Sat, 11 May 2024, Michael Niedermayer wrote: On Thu, May 09, 2024 at 08:49:18AM +0200, Marton Balint wrote: Fixes ticket #9740. Signed-off-by: Marton Balint --- libavfilter/vf_geq.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-13 Thread Ramiro Polla
On Mon, May 13, 2024 at 6:49 PM James Almer wrote: > On 5/6/2024 2:49 PM, Rémi Denis-Courmont wrote: > > Le maanantaina 6. toukokuuta 2024, 20.18.11 EEST Ramiro Polla a écrit : > >> I'll send a similar patch to fix checkasm/idctdsp after this is merged. > > > > The idctdsp test does not actually

Re: [FFmpeg-devel] [PATCH] Revert "lavc/sbrdsp: R-V V neg_odd_64"

2024-05-13 Thread Rémi Denis-Courmont
Le 13 mai 2024 20:06:34 GMT+03:00, Lynne via ffmpeg-devel a écrit : >On 13/05/2024 18:43, Rémi Denis-Courmont wrote: >> While this function can easily be written with vectors, it just fails to >> get any performance improvement. >> >> For reference, this is a simpler loop-free implementation

Re: [FFmpeg-devel] [PATCH] Revert "lavc/sbrdsp: R-V V neg_odd_64"

2024-05-13 Thread Lynne via ffmpeg-devel
On 13/05/2024 18:43, Rémi Denis-Courmont wrote: While this function can easily be written with vectors, it just fails to get any performance improvement. For reference, this is a simpler loop-free implementation that does get better performance than the current one depending on hardware, but

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/decode: Set KEY flag+pict_type generically for intra-only codecs

2024-05-13 Thread Tomas Härdin
mån 2024-05-13 klockan 17:55 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > mån 2024-05-13 klockan 10:54 +0200 skrev Andreas Rheinhardt: > > > Tomas Härdin: > > > > tor 2024-05-09 klockan 04:04 +0200 skrev Andreas Rheinhardt: > > > > > This commit is the analog of > > > > >

Re: [FFmpeg-devel] [PATCH v3 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-13 Thread flow gg
just rebase 于2024年5月14日周二 01:00写道: > From: sunyuechi > > C908: > vp9_vert_8x8_8bpp_c: 22.0 > vp9_vert_8x8_8bpp_rvi: 15.7 > vp9_vert_16x16_8bpp_c: 71.2 > vp9_vert_16x16_8bpp_rvi: 39.0 > vp9_vert_32x32_8bpp_c: 300.2 > vp9_vert_32x32_8bpp_rvi: 135.2 > --- > libavcodec/riscv/Makefile| 1

[FFmpeg-devel] [PATCH v3 7/9] lavc/vp9dsp: R-V V mc tap h v

2024-05-13 Thread uk7b
From: sunyuechi C908 X60 vp9_avg_8tap_smooth_4h_8bpp_c : 13.0 11.2 vp9_avg_8tap_smooth_4h_8bpp_rvv_i32:5.04.2 vp9_avg_8tap_smooth_4v_8bpp_c : 13.7 12.5

[FFmpeg-devel] [PATCH v3 8/9] lavc/vp9dsp: R-V V mc bilin hv

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_avg_bilin_4hv_8bpp_c: 11.0 vp9_avg_bilin_4hv_8bpp_rvv_i64: 3.7 vp9_avg_bilin_8hv_8bpp_c: 38.7 vp9_avg_bilin_8hv_8bpp_rvv_i64: 7.2 vp9_avg_bilin_16hv_8bpp_c: 147.0 vp9_avg_bilin_16hv_8bpp_rvv_i64: 14.2 vp9_avg_bilin_32hv_8bpp_c: 574.5 vp9_avg_bilin_32hv_8bpp_rvv_i64:

[FFmpeg-devel] [PATCH v3 6/9] lavc/vp9dsp: R-V V mc bilin h v

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_avg_bilin_4h_8bpp_c: 5.2 vp9_avg_bilin_4h_8bpp_rvv_i64: 2.2 vp9_avg_bilin_4v_8bpp_c: 5.5 vp9_avg_bilin_4v_8bpp_rvv_i64: 2.2 vp9_avg_bilin_8h_8bpp_c: 20.0 vp9_avg_bilin_8h_8bpp_rvv_i64: 4.5 vp9_avg_bilin_8v_8bpp_c: 21.0 vp9_avg_bilin_8v_8bpp_rvv_i64: 4.2

[FFmpeg-devel] [PATCH v3 9/9] lavc/vp9dsp: R-V V mc tap hv

2024-05-13 Thread uk7b
From: sunyuechi C908 X60 vp9_avg_8tap_smooth_4hv_8bpp_c : 32.0 28.2 vp9_avg_8tap_smooth_4hv_8bpp_rvv_i32 : 15.0 13.2 vp9_avg_8tap_smooth_8hv_8bpp_c : 98.0 86.2

[FFmpeg-devel] [PATCH v3 5/9] lavc/vp9dsp: R-V V mc avg

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_avg4_8bpp_c: 1.2 vp9_avg4_8bpp_rvv_i64: 1.0 vp9_avg8_8bpp_c: 3.7 vp9_avg8_8bpp_rvv_i64: 1.5 vp9_avg16_8bpp_c: 14.7 vp9_avg16_8bpp_rvv_i64: 3.5 vp9_avg32_8bpp_c: 57.7 vp9_avg32_8bpp_rvv_i64: 10.0 vp9_avg64_8bpp_c: 229.0 vp9_avg64_8bpp_rvv_i64: 31.7 ---

[FFmpeg-devel] [PATCH v3 4/9] lavc/vp9dsp: R-V V ipred tm

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_tm_4x4_8bpp_c: 116.5 vp9_tm_4x4_8bpp_rvv_i32: 43.5 vp9_tm_8x8_8bpp_c: 416.2 vp9_tm_8x8_8bpp_rvv_i32: 86.0 vp9_tm_16x16_8bpp_c: 1665.5 vp9_tm_16x16_8bpp_rvv_i32: 187.2 vp9_tm_32x32_8bpp_c: 6974.2 vp9_tm_32x32_8bpp_rvv_i32: 625.7 --- libavcodec/riscv/vp9_intra_rvv.S |

[FFmpeg-devel] [PATCH v3 1/9] lavc/vp9dsp: R-V ipred vert

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_vert_8x8_8bpp_c: 22.0 vp9_vert_8x8_8bpp_rvi: 15.7 vp9_vert_16x16_8bpp_c: 71.2 vp9_vert_16x16_8bpp_rvi: 39.0 vp9_vert_32x32_8bpp_c: 300.2 vp9_vert_32x32_8bpp_rvi: 135.2 --- libavcodec/riscv/Makefile| 1 + libavcodec/riscv/vp9_intra_rvi.S | 71

[FFmpeg-devel] [PATCH v3 3/9] lavc/vp9dsp: R-V V ipred hor

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_hor_8x8_8bpp_c: 74.7 vp9_hor_8x8_8bpp_rvv_i32: 35.7 vp9_hor_16x16_8bpp_c: 175.5 vp9_hor_16x16_8bpp_rvv_i32: 80.2 vp9_hor_32x32_8bpp_c: 510.2 vp9_hor_32x32_8bpp_rvv_i32: 264.0 --- libavcodec/riscv/vp9_intra_rvv.S | 56

[FFmpeg-devel] [PATCH v3 2/9] lavc/vp9dsp: R-V mc copy

2024-05-13 Thread uk7b
From: sunyuechi C908: vp9_put4_8bpp_c: 0.7 vp9_put4_8bpp_rvi: 0.5 vp9_put8_8bpp_c: 2.5 vp9_put8_8bpp_rvi: 0.5 vp9_put16_8bpp_c: 16.7 vp9_put16_8bpp_rvi: 1.5 vp9_put32_8bpp_c: 37.2 vp9_put32_8bpp_rvi: 5.7 vp9_put64_8bpp_c: 107.5 vp9_put64_8bpp_rvi: 21.7 --- libavcodec/riscv/Makefile | 3

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-13 Thread James Almer
On 5/6/2024 2:49 PM, Rémi Denis-Courmont wrote: Le maanantaina 6. toukokuuta 2024, 20.18.11 EEST Ramiro Polla a écrit : I'll send a similar patch to fix checkasm/idctdsp after this is merged. The idctdsp test does not actually test the iDCT, but only the trivial-ish add/put helpers, so it

[FFmpeg-devel] [PATCH] Revert "lavc/sbrdsp: R-V V neg_odd_64"

2024-05-13 Thread Rémi Denis-Courmont
While this function can easily be written with vectors, it just fails to get any performance improvement. For reference, this is a simpler loop-free implementation that does get better performance than the current one depending on hardware, but still more or less the same metrics as the C code:

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/decode: Set KEY flag+pict_type generically for intra-only codecs

2024-05-13 Thread Andreas Rheinhardt
Tomas Härdin: > mån 2024-05-13 klockan 10:54 +0200 skrev Andreas Rheinhardt: >> Tomas Härdin: >>> tor 2024-05-09 klockan 04:04 +0200 skrev Andreas Rheinhardt: This commit is the analog of 3f11eac75741888c7b2b6f93c458766f2613bab5 for decoding: It sets the AV_FRAME_FLAG_KEY and (for

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/decode: Set KEY flag+pict_type generically for intra-only codecs

2024-05-13 Thread Tomas Härdin
mån 2024-05-13 klockan 10:54 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > tor 2024-05-09 klockan 04:04 +0200 skrev Andreas Rheinhardt: > > > This commit is the analog of > > > 3f11eac75741888c7b2b6f93c458766f2613bab5 > > > for decoding: It sets the AV_FRAME_FLAG_KEY and (for video > > >

[FFmpeg-devel] [PATCH] area changed: scdet filter

2024-05-13 Thread radu.taraibuta
Previous observations: - Inconsistent code style with other filters. (Mostly using AVFilterLink* link instead of AVFilterLink *link). I hope it's fine now. - Unrelated changes, please split trivial unrelated changes into separate patches. Removed trivial changes from this patch. - Can't

[FFmpeg-devel] [PATCH] lavc/flacdsp: fix CPU requirement for 32-bit LPC

2024-05-13 Thread Rémi Denis-Courmont
--- libavcodec/riscv/flacdsp_init.c | 13 ++--- libavcodec/riscv/flacdsp_rvv.S | 4 ++-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/riscv/flacdsp_init.c b/libavcodec/riscv/flacdsp_init.c index 0d7cff8bfe..77ffd09244 100644 ---

[FFmpeg-devel] [PATCH 2/2] lavc/speedhqdec: Reindent

2024-05-13 Thread Tomas Härdin
From 17aceef1c1a1bb25d651610cd52bc94dbdf20e0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 13 May 2024 17:01:28 +0200 Subject: [PATCH 2/2] lavc/speedhqdec: Reindent --- libavcodec/speedhqdec.c | 152 1 file changed, 76

[FFmpeg-devel] [PATCH 1/2] lavc/speedhqdec: Add AV_CODEC_CAP_SLICE_THREADS

2024-05-13 Thread Tomas Härdin
On a 36 core Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz command: /usr/bin/time ./ffmpeg -t 30 -thread_type slice -threads $THREADS -i $INPUT.mov -vcodec rawvideo -f null - before: frame= 1500 fps=160 q=-0.0 Lsize=N/A time=00:00:30.00 bitrate=N/A speed= 3.2x 10.54user 0.37system

Re: [FFmpeg-devel] [PATCH] avformat/data_uri: Fix base64 decode buffer size calculation

2024-05-13 Thread Kacper Michajlow
On Sat, 11 May 2024 at 03:45, Michael Niedermayer wrote: > > On Thu, May 09, 2024 at 04:02:09PM +0200, Kacper Michajłow wrote: > > Also reject input if it is too short. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavformat/data_uri.c | 4 ++-- > > 1 file

[FFmpeg-devel] [PATCH v2] avformat/data_uri: Fix base64 decode buffer size calculation

2024-05-13 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- libavformat/data_uri.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/data_uri.c b/libavformat/data_uri.c index 3868a19630..5991ad4ed4 100644 --- a/libavformat/data_uri.c +++ b/libavformat/data_uri.c @@ -73,7 +73,7 @@ static

Re: [FFmpeg-devel] [PATCH v3 0/2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-05-13 Thread Ramiro Polla
On Wed, Apr 17, 2024 at 10:49 PM Martin Storsjö wrote: > On Wed, 17 Apr 2024, Ramiro Polla wrote: > > This patch set adds fdct to checkasm and neon-optimized fdct for aarch64. > > > > Ramiro Polla (2): > > checkasm: add test for fdct > > lavc/aarch64/fdct: add neon-optimized fdct for aarch64 >

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: fix include for cpu.h

2024-05-13 Thread Ramiro Polla
On Mon, May 13, 2024 at 12:15 PM Martin Storsjö wrote: > On Sat, 11 May 2024, Ramiro Polla wrote: > > On Sun, Jan 21, 2024 at 10:57 PM Ramiro Polla > > wrote: > >> > >> --- > >> libavcodec/aarch64/idctdsp_init_aarch64.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff

[FFmpeg-devel] [PATCH v3 1/4] avcodec/x86/vvc: add alf filter luma and chroma avx2 optimizations

2024-05-13 Thread toqsxw
From: Wu Jianhua ff_vvc_alf_filter_luma_4x4_10_c: 135 ff_vvc_alf_filter_luma_4x4_10_avx2: 54 ff_vvc_alf_filter_luma_4x8_10_c: 268 ff_vvc_alf_filter_luma_4x8_10_avx2: 106 ff_vvc_alf_filter_luma_4x12_10_c: 400 ff_vvc_alf_filter_luma_4x12_10_avx2: 160 ff_vvc_alf_filter_luma_4x16_10_c: 535

[FFmpeg-devel] [PATCH v3 4/4] tests/checkasm/vvc_alf: add check_alf_classify

2024-05-13 Thread toqsxw
From: Wu Jianhua Perforamnce Test (fps): clip before after delta Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36% RitualDance_1920x1080_60_10_420_32_LD.266 272 481 76.83% RitualDance_1920x1080_60_10_420_37_RA.266 303 426 40.59%

[FFmpeg-devel] [PATCH v3 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

2024-05-13 Thread toqsxw
From: Wu Jianhua Signed-off-by: Wu Jianhua --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 3 +- tests/checkasm/checkasm.h | 1 + tests/checkasm/vvc_alf.c | 133 ++ 4 files changed, 137 insertions(+), 2 deletions(-) create mode

Re: [FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

2024-05-13 Thread Lynne via ffmpeg-devel
On 13/05/2024 12:13, Martin Storsjö wrote: On Sat, 11 May 2024, Lynne via ffmpeg-devel wrote: Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538. Untested, but its assumed that unlike most of the old ARM code, this one was still working. ---

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: fix include for cpu.h

2024-05-13 Thread Martin Storsjö
On Sat, 11 May 2024, Ramiro Polla wrote: On Sun, Jan 21, 2024 at 10:57 PM Ramiro Polla wrote: --- libavcodec/aarch64/idctdsp_init_aarch64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/idctdsp_init_aarch64.c

Re: [FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

2024-05-13 Thread Martin Storsjö
On Sat, 11 May 2024, Lynne via ffmpeg-devel wrote: Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538. Untested, but its assumed that unlike most of the old ARM code, this one was still working. --- libavcodec/aac/aacdec_float.c | 5 + 1 file changed, 5 insertions(+)

[FFmpeg-devel] [PATCH 06/10] tests/checkasm/vvc_mc: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/checkasm/vvc_mc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c index 97f57cb401..71087dc3dd 100644 --- a/tests/checkasm/vvc_mc.c +++ b/tests/checkasm/vvc_mc.c @@ -121,7

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/bsf/dts2pts: Fix shadowing

2024-05-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/bsf/dts2pts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/bsf/dts2pts.c b/libavcodec/bsf/dts2pts.c > index 53a54fb1cc..ba4dc43f84 100644 > --- a/libavcodec/bsf/dts2pts.c > +++

[FFmpeg-devel] [PATCH 10/10] tests/checkasm/sw_gbrp: Use correct function types for calls

2024-05-13 Thread Andreas Rheinhardt
E.g. f2de911818fbd7e73343803626b697fd0c968121 forgot to add the unused void* here. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/sw_gbrp.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/tests/checkasm/sw_gbrp.c

[FFmpeg-devel] [PATCH 09/10] tests/checkasm/vf_blend: Add missing function parameter

2024-05-13 Thread Andreas Rheinhardt
Forgotten in 5b8faaad6c71bbb90951ca1642391e11cf6f5f91. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/vf_blend.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vf_blend.c b/tests/checkasm/vf_blend.c index b5a96ee4bc..5ebfc11fed 100644 ---

[FFmpeg-devel] [PATCH 08/10] tests/checkasm/vf_bwdif: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Forgotten in fa06f48371ba2b73c139810db5bb893dc27eda7a. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/vf_bwdif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index fae61b62e4..222e6aa4fa 100644 ---

[FFmpeg-devel] [PATCH 07/10] tests/checkasm/vf_colorspace: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Forgotten in 9b26a8077f1c0139fdcc236d3de08cd2bdc4ec0f. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/vf_colorspace.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vf_colorspace.c b/tests/checkasm/vf_colorspace.c index 31efa671f9..1b0d202ce6

[FFmpeg-devel] [PATCH 05/10] tests/checkasm/vp8dsp: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Forgotten in a54e53a1c428299b19c7b4e2b66d01c0482c41dd. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/vp8dsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/vp8dsp.c b/tests/checkasm/vp8dsp.c index 4cd0f8ac4f..6e989819ef 100644 ---

[FFmpeg-devel] [PATCH 04/10] tests/checkasm/motion: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Forgotten in abb85429f3424375f21bdd135656c2d88357b3d5. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/motion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/motion.c b/tests/checkasm/motion.c index 71a0ee3fc0..e7a36bbbda 100644 ---

[FFmpeg-devel] [PATCH 03/10] tests/checkasm/llviddsp: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/checkasm/llviddsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/llviddsp.c b/tests/checkasm/llviddsp.c index 00ad21a7cc..b75c0ea099 100644 --- a/tests/checkasm/llviddsp.c +++ b/tests/checkasm/llviddsp.c @@

[FFmpeg-devel] [PATCH 02/10] tests/checkasm/huffyuvdsp: Use correct function pointer type

2024-05-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/checkasm/huffyuvdsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/huffyuvdsp.c b/tests/checkasm/huffyuvdsp.c index a08f5a8391..7491a8f14c 100644 --- a/tests/checkasm/huffyuvdsp.c +++ b/tests/checkasm/huffyuvdsp.c

[FFmpeg-devel] [PATCH 01/10] tests/checkasm/hevc_*: Fix funtion pointer types

2024-05-13 Thread Andreas Rheinhardt
Forgotten in b314d0685c8c1fbcf8455e59c7f444290c7c. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/hevc_add_res.c | 2 +- tests/checkasm/hevc_deblock.c | 6 -- tests/checkasm/hevc_pel.c | 28 ++-- tests/checkasm/hevc_sao.c | 8 4 files

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case

2024-05-13 Thread Tomas Härdin
mån 2024-05-13 klockan 10:51 +0200 skrev Tomas Härdin: > fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer: > > Fixes: CID1460979 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > >  libavcodec/jpeg2000dec.c | 3 --- > >  1

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/decode: Set KEY flag+pict_type generically for intra-only codecs

2024-05-13 Thread Andreas Rheinhardt
Tomas Härdin: > tor 2024-05-09 klockan 04:04 +0200 skrev Andreas Rheinhardt: >> This commit is the analog of 3f11eac75741888c7b2b6f93c458766f2613bab5 >> for decoding: It sets the AV_FRAME_FLAG_KEY and (for video decoders) >> also pict_type to AV_PICTURE_TYPE_I. It furthermore stops setting >>

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case

2024-05-13 Thread Tomas Härdin
fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer: > Fixes: CID1460979 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  libavcodec/jpeg2000dec.c | 3 --- >  1 file changed, 3 deletions(-) > > diff --git a/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH] tests/checkasm/svq1enc: Use proper range for input

2024-05-13 Thread Tomas Härdin
mån 2024-05-06 klockan 17:41 +0200 skrev Andreas Rheinhardt: > ssd_int8_vs_int16 is only called from encode_block() > in svq1enc.c; it calls it in stages: At stage 0, > the int16_t array contains the difference of two > uint16_t. At each of the following stages, the > int16_t array is filled by

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case

2024-05-13 Thread Tomas Härdin
fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer: > Fixes: CID1460979 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  libavcodec/jpeg2000dec.c | 3 --- >  1 file changed, 3 deletions(-) > > diff --git a/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/decode: Set KEY flag+pict_type generically for intra-only codecs

2024-05-13 Thread Tomas Härdin
tor 2024-05-09 klockan 04:04 +0200 skrev Andreas Rheinhardt: > This commit is the analog of 3f11eac75741888c7b2b6f93c458766f2613bab5 > for decoding: It sets the AV_FRAME_FLAG_KEY and (for video decoders) > also pict_type to AV_PICTURE_TYPE_I. It furthermore stops setting > audio frames as always

[FFmpeg-devel] [PATCH v2] lavc/vaapi_decode: Reject decoding of frames with no slices

2024-05-13 Thread David Rosca
Matches other hwaccels. --- v2: AVERROR libavcodec/vaapi_decode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 8e9f647c20..7c91d50f7b 100644 --- a/libavcodec/vaapi_decode.c +++ b/libavcodec/vaapi_decode.c @@ -157,6 +157,11

Re: [FFmpeg-devel] [PATCH 3/3] lavc/speedhqdec: Set AV_PICTURE_TYPE_I

2024-05-13 Thread Tomas Härdin
sön 2024-05-12 klockan 01:07 +0200 skrev Tomas Härdin: > fre 2024-05-10 klockan 14:48 +0200 skrev Andreas Rheinhardt: > > Tomas Härdin: > > > ons 2024-05-08 klockan 17:06 -0300 skrev James Almer: > > > > On 5/8/2024 5:01 PM, Marton Balint wrote: > > > > > > > > > > > > > > > On Wed, 8 May 2024,

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-13 Thread Tomas Härdin
tor 2024-05-02 klockan 13:44 -0400 skrev Vittorio Giovara: > I believe the path forward would be designing a system that can > accommodate > both workflows, a main git{hub,lab} interface which can send and > mirror the > discussion happening on the mailing list for those who prefer emails. > Such

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: Reject decoding of frames with no slices

2024-05-13 Thread Xiang, Haihao
On Vr, 2024-05-10 at 11:55 +0200, David Rosca wrote: > Matches other hwaccels. > --- >  libavcodec/vaapi_decode.c | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index 8e9f647c20..3c4030c073 100644 > ---

Re: [FFmpeg-devel] [PATCH v2 9/9] lavfi/qsvvpp: require a dynamic frame pool for output if possible

2024-05-13 Thread Xiang, Haihao
On Wo, 2024-05-08 at 14:03 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Signed-off-by: Haihao Xiang > --- >  libavfilter/qsvvpp.c | 52 >  1 file changed, 29 insertions(+), 23 deletions(-) > > diff --git a/libavfilter/qsvvpp.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/flac_parser: Assert that we do not overrun the link_penalty array

2024-05-13 Thread Rémi Denis-Courmont
Le 5 mai 2024 02:51:59 GMT+03:00, Michael Niedermayer a écrit : >Fixes: CID1454676 Out-of-bounds read It's a stretch to call this "fixing". It just asserts that the situation doesn't happen, in other words, that it is a false positive from the static analyser. The code change looks OK, but

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread Rémi Denis-Courmont
Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer a écrit : >Fixes: CID1439574 Dereference after null check If SPS is guaranteed to be non-NULL, there should probably be an assertion to document it, and it should be *before* that alleged dereference (which is not visible in the patch