Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: fix GCC 14.1 warnings

2024-05-19 Thread Wu, Tong1
>-Original Message- >From: ffmpeg-devel On Behalf Of Oleg >Tolmatcev >Sent: Saturday, May 18, 2024 3:39 AM >To: ffmpeg-devel@ffmpeg.org >Subject: [FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: fix GCC 14.1 warnings > >This patch fixes warnings produced by GCC 14.1 in hwcontext_qsv.c. It

[FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

2024-05-19 Thread Michael Niedermayer
Fixes: CID1583742 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/hwcontext_drm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_drm.c b/libavutil/hwcontext_drm.c index

[FFmpeg-devel] [PATCH v1 2/2] lavc/qsvdec: Use coded_w/h for frame resolution when use system memory

2024-05-19 Thread fei . w . wang-at-intel . com
From: Fei Wang Fix output mismatch when decode clip with crop(conf_win_*offset in syntax) info by using system memory: $ ffmpeg -c:v hevc_qsv -i conf_win_offet.bit -y out.yuv Signed-off-by: Fei Wang --- libavcodec/qsvdec.c | 16 1 file changed, 8 insertions(+), 8

[FFmpeg-devel] [PATCH v1 1/2] lavc/qsvdec: Allow decoders to export crop information

2024-05-19 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/qsvdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index a51ddace62..12cf630593 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -859,6 +859,10 @@ static

Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_decode: Reject decoding of frames with no slices

2024-05-19 Thread Xiang, Haihao
On Ma, 2024-05-13 at 09:38 +0200, David Rosca wrote: > Matches other hwaccels. > --- > v2: AVERROR > >  libavcodec/vaapi_decode.c | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index 8e9f647c20..7c91d50f7b 100644 > ---

[FFmpeg-devel] [PATCH] avformat/mov: store sample_sizes as unsigned ints

2024-05-19 Thread James Almer
As defined in Section 8.7.3.2.1 of ISO 14496-12. Any unsupported value will be rejected in mov_build_index() without outright aborting demuxing. Fixes ticket #11005. Signed-off-by: James Almer --- libavformat/isom.h | 2 +- libavformat/mov.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[FFmpeg-devel] [PATCH] avutil/hwcontext: Set proper CVBuffer colorspace

2024-05-19 Thread Marvin Scholz
Fix #10884 --- libavutil/hwcontext_videotoolbox.c | 54 +- 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 9f82b104c3..4a35bfc7ff 100644 ---

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Lynne via ffmpeg-devel
On 20/05/2024 01:19, Michael Niedermayer wrote: On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. What works: - Mono - Stereo (no prediction) - Stereo (mid/side coding) - Stereo (complex prediction)

[FFmpeg-devel] [PATCH v4 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

2024-05-19 Thread Stone Chen
Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 70.0 vvc_sad_8x8_avx2: 10.0 vvc_sad_16x16_c: 280.0 vvc_sad_16x16_avx2: 20.0 vvc_sad_32x32_c: 1020.0 vvc_sad_32x32_avx2: 70.0 vvc_sad_64x64_c: 3560.0 vvc_sad_64x64_avx2: 270.0 vvc_sad_128x128_c: 13760.0

[FFmpeg-devel] [PATCH v4 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-19 Thread Stone Chen
Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD is only calculated on even rows. This is calculated for all video bitdepths, but the values passed to the function are always

[FFmpeg-devel] [PATCH v4 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

2024-05-19 Thread Stone Chen
Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 70.0 vvc_sad_8x8_avx2: 10.0 vvc_sad_16x16_c: 280.0 vvc_sad_16x16_avx2: 20.0 vvc_sad_32x32_c: 1020.0 vvc_sad_32x32_avx2: 70.0 vvc_sad_64x64_c: 3560.0 vvc_sad_64x64_avx2: 270.0 vvc_sad_128x128_c: 13760.0

[FFmpeg-devel] [PATCH v4 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-19 Thread Stone Chen
Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD is only calculated on even rows. This is calculated for all video bitdepths, but the values passed to the function are always

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote: > This commit adds a decoder for the frequency-domain part of USAC. > > What works: > - Mono > - Stereo (no prediction) > - Stereo (mid/side coding) > - Stereo (complex prediction) > > What's left: > - Speech coding >

Re: [FFmpeg-devel] [PATCH] tests/ref/fate/source: Add exceptions for riscv startcode files

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 10:49:52AM +0200, Andreas Rheinhardt wrote: > Fixes fate-source. LGTM it can be debated after test targets are fixed what is the best solution thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/mpeg12dec: Use 64bit in bit computation

2024-05-19 Thread Michael Niedermayer
On Sun, May 12, 2024 at 02:03:46AM +0200, Michael Niedermayer wrote: > I dont think this can actually overflow but 64bit seems reasonable to use > > Fixes: CID1521983 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH] Added alpha layer support v2

2024-05-19 Thread Michael Niedermayer
On Fri, May 17, 2024 at 12:42:28AM +0200, Andrea Mastroberti via ffmpeg-devel wrote: > doc/filters.texi | 20 +++- > libavfilter/version.h |3 ++- > libavfilter/vf_smartblur.c | 43 +++ > 3 files changed, 56

[FFmpeg-devel] [PATCH 2/2] avcodec/tests/jpeg2000dwt: Use 64bit in comparission

2024-05-19 Thread Michael Niedermayer
Found while reviewing: CID1500309 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tests/jpeg2000dwt.c

[FFmpeg-devel] [PATCH 1/2] avcodec/tests/jpeg2000dwt: Use 64bit in err2 computation

2024-05-19 Thread Michael Niedermayer
This issue cannot happen with the current function parameters Fixes: CID1500309 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v2 2/5] doc/ffmpeg: document -channel_layout/ch_layout options

2024-05-19 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index da37e3ad37..f25f6192eb 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1719,12 +1719,21 @@ This is an alias for

[FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout

2024-05-19 Thread Marton Balint
The code only set the channel layout of the AVFormatContext, so the user could not override the channel layout if the demuxer did not have such parameter. This used to work via the respective AVCodecContext option, but since 639c2f00497257cb60ecaeeac1aacfa80df3be06 it no longer gets passed to the

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/qsvdec: Check av_image_get_buffer_size() for failure

2024-05-19 Thread Michael Niedermayer
On Mon, May 13, 2024 at 01:47:36AM +, Xiang, Haihao wrote: > On Ma, 2024-05-13 at 03:20 +0200, Michael Niedermayer wrote: > > Fixes: CID1477406 Improper use of negative value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > >  libavcodec/qsvdec.c | 9

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Lynne via ffmpeg-devel
On 19/05/2024 21:39, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. [...] +/* Finish later */ +static const enum AVChannel usac_ch_pos_to_av[64] = { +    [0] = AV_CHAN_FRONT_LEFT, +    [1] =

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext()

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 06:05:20PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Helps: CID1548380 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/rv34.c | 2 ++ > > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert

2024-05-19 Thread Michael Niedermayer
On Sat, May 18, 2024 at 06:33:12PM +1000, Peter Ross wrote: > On Sat, May 18, 2024 at 05:57:43AM +0200, Michael Niedermayer wrote: > > Fixes: CID1452425 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp3.c | 3 +-- > >

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/vp8: Forward return of ff_vpx_init_range_decoder()

2024-05-19 Thread Michael Niedermayer
On Sat, May 18, 2024 at 11:07:15AM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, May 17, 2024 at 11:59 PM Michael Niedermayer > wrote: > > > Fixes: CID1507483 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 10:28:49PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer > wrote: > > > This might not be needed for correctness but it could > > help general reproducability of issues > > > > Related to: CID1560037 Uninitialized scalar variable > > Related

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Marton Balint
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. [...] +/* Finish later */ +static const enum AVChannel usac_ch_pos_to_av[64] = { +[0] = AV_CHAN_FRONT_LEFT, +[1] = AV_CHAN_FRONT_RIGHT, +[2] =

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 10:31:50PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer > wrote: > > > Fixes: CID1560042 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vvc/dec.c | 5 - > >

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 01:18:09PM +1000, Peter Ross wrote: > On Sun, May 19, 2024 at 04:49:07AM +0200, Michael Niedermayer wrote: > > Fixes: CID1516090 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vqcdec.c | 5

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag

2024-05-19 Thread Michael Niedermayer
On Sun, May 19, 2024 at 10:40:57PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:49 AM Michael Niedermayer > wrote: > > > Fixes: CID1560039 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vvc/ctu.c | 23

[FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Lynne via ffmpeg-devel
This commit adds a decoder for the frequency-domain part of USAC. What works: - Mono - Stereo (no prediction) - Stereo (mid/side coding) - Stereo (complex prediction) What's left: - Speech coding Known issues: - Desync with certain sequences - Preroll crossover missing (shouldn't matter,

[FFmpeg-devel] [PATCH v2 6/8] aactab: add tables for the new USAC arithmetic coder

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 376 libavcodec/aactab.h | 6 + 2 files changed, 382 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 8ce5e43974..dfb2dfd98d 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -1193,6

[FFmpeg-devel] [PATCH v2 7/8] aactab: add new scalefactor offset tables for 96/768pt windows

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 117 libavcodec/aactab.h | 4 ++ 2 files changed, 121 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index dfb2dfd98d..18afa69bad 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -154,6

[FFmpeg-devel] [PATCH v2 5/8] aactab: add deemphasis tables for USAC

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 25 + libavcodec/aactab.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 3718b81a07..8ce5e43974 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -3377,3 +3377,28 @@ const

[FFmpeg-devel] [PATCH v2 4/8] aacdec_dsp: implement 768-point transform and windowing

2024-05-19 Thread Lynne via ffmpeg-devel
Required for USAC --- libavcodec/aac/aacdec.c | 4 ++ libavcodec/aac/aacdec.h | 5 +++ libavcodec/aac/aacdec_dsp_template.c | 67 libavcodec/aac/aacdec_fixed.c| 2 + libavcodec/aac/aacdec_float.c| 4 ++

[FFmpeg-devel] [PATCH v2 3/8] aacdec: expose decode_tns

2024-05-19 Thread Lynne via ffmpeg-devel
USAC has the same syntax, with one minor change we can check for. --- libavcodec/aac/aacdec.c | 6 +++--- libavcodec/aac/aacdec.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 40554ff9e4..a7e5b2a369 100644 ---

[FFmpeg-devel] [PATCH v2 2/8] aacdec: expose channel layout related functions

2024-05-19 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec.c | 73 - libavcodec/aac/aacdec.h | 19 +-- 2 files changed, 51 insertions(+), 41 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 35722f9b9b..40554ff9e4 100644 ---

[FFmpeg-devel] [PATCH v2 1/8] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-19 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors

[FFmpeg-devel] [PATCH v2 0/8] aacdec: add a native xHE-AAC decoder

2024-05-19 Thread Lynne via ffmpeg-devel
This patch adds support for the frequency domain part of the xHE-AAC standard (ISO/IEC 23003-3). The speech synthesis support is to be implemented with a later patch. LPD is left as a stub with most bitstream parsing complete. The DRC support is left up for discussion. The DRC system is pretty

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder

2024-05-19 Thread Pierre-Anthony Lemieux
On Sun, May 19, 2024 at 9:02 AM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Addresses https://trac.ffmpeg.org/ticket/10905 > > > > Co-authored-by: Osamu Watanabe > > Signed-off-by: Pierre-Anthony Lemieux > > --> @@ -1297,14 +1299,14 @@

Re: [FFmpeg-devel] [PATCH] area changed: scdet filter

2024-05-19 Thread radu.taraibuta
> -Original Message- > From: radu.taraib...@gmail.com > Sent: luni, 13 mai 2024 18:52 > To: ffmpeg-devel@ffmpeg.org > Subject: [PATCH] area changed: scdet filter > > Previous observations: > > - Inconsistent code style with other filters. (Mostly using AVFilterLink* > link instead of

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext()

2024-05-19 Thread Andreas Rheinhardt
Michael Niedermayer: > Helps: CID1548380 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/rv34.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c > index

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder

2024-05-19 Thread Andreas Rheinhardt
p...@sandflow.com: > From: Pierre-Anthony Lemieux > > Addresses https://trac.ffmpeg.org/ticket/10905 > > Co-authored-by: Osamu Watanabe > Signed-off-by: Pierre-Anthony Lemieux > --> @@ -1297,14 +1299,14 @@ ff_jpeg2000_decode_htj2k(const Jpeg2000DecoderContext *s, Jpeg2000CodingStyle *c >

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder

2024-05-19 Thread pal
From: Pierre-Anthony Lemieux Addresses https://trac.ffmpeg.org/ticket/10905 Co-authored-by: Osamu Watanabe Signed-off-by: Pierre-Anthony Lemieux --- libavcodec/jpeg2000htdec.c | 122 --- tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 | 2 +- 2 files changed, 63

[FFmpeg-devel] [PATCH] lavc/h263dsp: R-V V {h,v}_loop_filter

2024-05-19 Thread Rémi Denis-Courmont
Since the horizontal and vertical filters are identical except for a transposition, this uses a common subprocedure with an ad-hoc ABI. To preserve return-address stack prediction, a link register has to be used (c.f. the "Control Transfer Instructions" from the RISC-V ISA Manual). The

Re: [FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

2024-05-19 Thread Jean-Baptiste Kempf
Careful about the typo on "different" on the title of the patch. On Sun, 19 May 2024, at 13:27, Nuo Mi wrote: > For RPR, the current frame may reference a frame with a different resolution. > Therefore, we need to consider frame scaling when we wait for reference > pixels. > --- >

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 10:49 AM Michael Niedermayer wrote: > Fixes: CID1560039 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vvc/ctu.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer wrote: > Fixes: CID1560042 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vvc/dec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer wrote: > This might not be needed for correctness but it could > help general reproducability of issues > > Related to: CID1560037 Uninitialized scalar variable > Related to: CID1560044 Uninitialized scalar variable > > Sponsored-by: Sovereign

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266: read vps_ptl_max_tid before using it

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 9:28 PM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h266_syntax_template.c | 28 ++- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/cbs_h266_syntax_template.c >

Re: [FFmpeg-devel] [PATCH v3 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-19 Thread Stone Chen
On Sat, May 18, 2024 at 11:33 AM Ronald S. Bultje wrote: > Hi, > > On Tue, May 14, 2024 at 4:40 PM Stone Chen > wrote: > >> +vvc_sad_8: >> +.loop_height: >> +movu xm0, [src1q] >> +movu xm1, [src2q] >> +MIN_MAX_SAD xm2, xm0, xm1

[FFmpeg-devel] [PATCH 07/18] avcodec/vvcdec: refact out VVCRefPic from RefPicList

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.c| 10 +- libavcodec/vvc/dec.c| 4 ++-- libavcodec/vvc/dec.h| 10 +++--- libavcodec/vvc/filter.c | 22 +++--- libavcodec/vvc/inter.c | 4 ++-- libavcodec/vvc/mvs.c| 36 ++-- libavcodec/vvc/refs.c

[FFmpeg-devel] [PATCH 17/18] avcodec/vvcdec: support Reference Picture Resampling

2024-05-19 Thread Nuo Mi
passed clips: RPR_A_Alibaba_4.bit RPR_B_Alibaba_3.bit RPR_C_Alibaba_3.bit RPR_D_Qualcomm_1.bit VVC_HDR_UHDTV1_OpenGOP_Max3840x2160_50fps_HLG10_res_change_with_RPR.ts --- libavcodec/vvc/inter.c | 190 + 1 file changed, 173 insertions(+),

[FFmpeg-devel] [PATCH 15/18] avcodec/vvcdec: refact, remove hf_idx and vf_idx from mc_xxx's param list

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 23b9a8af6b..5d553708d9 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -208,6 +208,7 @@ static

[FFmpeg-devel] [PATCH 16/18] avcodec/vvcdec: increase edge_emu_buffer for RPR

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 50109154aa..a987328d81 100644 --- a/libavcodec/vvc/ctu.h +++ b/libavcodec/vvc/ctu.h @@ -46,7 +46,8 @@ #define MAX_QP 63

[FFmpeg-devel] [PATCH 13/18] avcodec/vvcdec: fix dmvr, bdof, cb_prof for RPR

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.c | 18 +- libavcodec/vvc/mvs.c | 3 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c index 242caa58f7..809510b93d 100644 --- a/libavcodec/vvc/ctu.c +++ b/libavcodec/vvc/ctu.c @@ -1689,25

[FFmpeg-devel] [PATCH 14/18] avcodec/vvcdec: refact out luma_prof from luma_prof_bi

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 52 -- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index f432a2dc3c..23b9a8af6b 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -347,40

[FFmpeg-devel] [PATCH 11/18] avcodec/vvcdec: add RPR dsp

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.h| 2 + libavcodec/vvc/dsp.h| 13 +++ libavcodec/vvc/inter_template.c | 168 3 files changed, 183 insertions(+) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 337d0e7c28..50109154aa 100644 ---

[FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

2024-05-19 Thread Nuo Mi
For RPR, the current frame may reference a frame with a different resolution. Therefore, we need to consider frame scaling when we wait for reference pixels. --- libavcodec/vvc/dec.c| 5 + libavcodec/vvc/dec.h| 17 + libavcodec/vvc/refs.c | 39

[FFmpeg-devel] [PATCH 09/18] avcodec/vvcdec: add vvc inter filters for RPR

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/data.c | 83 - libavcodec/vvc/data.h | 10 +++-- libavcodec/vvc/inter.c | 8 ++-- tests/checkasm/vvc_mc.c | 12 +++--- 4 files changed, 98 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/data.c b/libavcodec/vvc/data.c

[FFmpeg-devel] [PATCH 10/18] avcodec/vvcdec: emulated_edge, use reference frame's sps and pps

2024-05-19 Thread Nuo Mi
a preparation for Reference Picture Resampling --- libavcodec/vvc/dec.c | 3 +++ libavcodec/vvc/dec.h | 2 ++ libavcodec/vvc/inter.c | 54 ++ libavcodec/vvc/refs.c | 5 4 files changed, 38 insertions(+), 26 deletions(-) diff --git

[FFmpeg-devel] [PATCH 04/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc_bi to mc_bi

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 95 +- 1 file changed, 30 insertions(+), 65 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 6d866c1bad..9132bfaee2 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -151,6

[FFmpeg-devel] [PATCH 08/18] avcodec/vvcdec: refact, pred_get_refs return VVCRefPic instead of VVCFrame

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index cd96707c02..23d9ac05e6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -387,15 +387,15 @@

[FFmpeg-devel] [PATCH 18/18] Changelog: add DVB compatible information for VVC decoder

2024-05-19 Thread Nuo Mi
see https://dvb.org/specifications/verification-validation/vvc-test-content/ --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index dd25715d6b..12770e4296 100644 --- a/Changelog +++ b/Changelog @@ -10,6 +10,7 @@ version : - vf_scale supports secondary ref

[FFmpeg-devel] [PATCH 03/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc_uni to mc_uni

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 80 +- 1 file changed, 25 insertions(+), 55 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 8657541eaf..6d866c1bad 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -236,33

[FFmpeg-devel] [PATCH 06/18] avcodec/vvcdec: refact, unify pred_regular_{luma, chroma} to pred_regular

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.h | 3 +- libavcodec/vvc/inter.c | 133 + 2 files changed, 41 insertions(+), 95 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 4e38ecf54a..337d0e7c28 100644 --- a/libavcodec/vvc/ctu.h +++

[FFmpeg-devel] [PATCH 05/18] avcodec/vvcdec: misc, remove unused EMULATED_EDGE_{LUMA, CHROMA}, EMULATED_EDGE_DMVR_{LUAM, CHROMA}

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 9132bfaee2..cc93184ca0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -142,25 +142,13 @@ static void

[FFmpeg-devel] [PATCH 02/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc to mc

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 47 +- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 3f0718cb5a..8657541eaf 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -142,6

[FFmpeg-devel] [PATCH 01/18] avcodec/vvcdec: misc, inter, use is_chroma instead of is_luma

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 4a8d1d866a..3f0718cb5a 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -31,33

[FFmpeg-devel] [PATCH] avcodec/cbs_h266: read vps_ptl_max_tid before using it

2024-05-19 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h266_syntax_template.c | 28 ++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index 725cee5b03..38685704c5 100644 ---

[FFmpeg-devel] [PATCH] avformat/vvc: fix parsing sps_subpic_id

2024-05-19 Thread James Almer
The length of the sps_subpic_id[i] syntax element is sps_subpic_id_len_minus1 + 1 bits. Signed-off-by: James Almer --- libavformat/vvc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c index 34c0aaf58b..ac3209a01b 100644 ---

[FFmpeg-devel] [PATCH] avformat/vvc: initialize some ptl flags

2024-05-19 Thread James Almer
Otherwise they will always be 0 when ANDed in vvcc_update_ptl(). Signed-off-by: James Almer --- libavformat/vvc.c | 2 ++ tests/ref/lavf-fate/vvc.mp4 | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c index

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-19 Thread Andrew Sayers
On Sun, May 19, 2024 at 01:29:43PM +0200, Thilo Borgmann via ffmpeg-devel wrote: > > [...] > > > * Fund administrative / maintainance work (one example is the mailman > > > upgrade that is needed > > > with the next OS upgrade on one of our servers (this is not as trivial > > > as one might >

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-19 Thread Thilo Borgmann via ffmpeg-devel
[...] * Fund administrative / maintainance work (one example is the mailman upgrade that is needed with the next OS upgrade on one of our servers (this is not as trivial as one might expect). Another example here may be some git related tools if we find something that theres a broad

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-19 Thread Thilo Borgmann via ffmpeg-devel
On 17.05.24 16:43, Ronald S. Bultje wrote: Hi, On Fri, May 17, 2024 at 9:50 AM Michael Niedermayer wrote: * Fund professional real live presence on multimedia / FOSS / buisness related events. we already refund individuals but i think we are lacking on the organizational side. We

Re: [FFmpeg-devel] [PATCH] configure: enable ffnvcodec, nvenc, nvdec for FreeBSD

2024-05-19 Thread Timo Rothenpieler
On 19.05.2024 02:00, Brad Smith wrote: configure: enable ffnvcodec, nvenc, nvdec for FreeBSD Signed-off-by: Brad Smith --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b16722d83d..96b181fd21 100755 --- a/configure +++ b/configure

Re: [FFmpeg-devel] [PATCH 1/6] avformat/utils: Use static mutexes instead of ff_lock_avformat()

2024-05-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Its existence is a remnant of (libavcodec's) lock-manager API > which has been removed in a04c2c707de2ce850f79870e84ac9d7ec7aa9143. > There is no need to use the same lock for avisynth, chromaprint > or tls, so switch to ordinary static mutexes instead. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: Reorder allocations to avoid leak on error

2024-05-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes Coverity issue #1591795. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/flacdec.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c > index 3d35da5fea..3c317acaee 100644 >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_v360: Add assert to suppress Coverity false positives

2024-05-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Should fix many Coverity false positives, namely #1457947-#1457994 > as well as #1461195-#146210. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_v360.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c >

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Fix leak on error

2024-05-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes Coverity issue #1516957. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tiff.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > index 19301d9e49..111ce3ea3a 100644 > --- a/libavcodec/tiff.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ac3enc_template: Avoid always-true check

2024-05-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This might also help Coverity with issue #1596532. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ac3enc_template.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix leak on error

2024-05-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Do this by attaching the FilterGraph directly to more permanent > storage from which it will be automatically freed. > Fixes Coverity issue #1596533. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] tests/ref/fate/source: Add exceptions for riscv startcode files

2024-05-19 Thread Rémi Denis-Courmont
Le sunnuntaina 19. toukokuuta 2024, 11.49.52 EEST Andreas Rheinhardt a écrit : > Fixes fate-source. > > Signed-off-by: Andreas Rheinhardt > --- > An alternative would be to change the license header, but this would > have to be done by courmisch himself. A better alternative would be to fix the

[FFmpeg-devel] [PATCH] tests/ref/fate/source: Add exceptions for riscv startcode files

2024-05-19 Thread Andreas Rheinhardt
Fixes fate-source. Signed-off-by: Andreas Rheinhardt --- An alternative would be to change the license header, but this would have to be done by courmisch himself. tests/ref/fate/source | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ref/fate/source b/tests/ref/fate/source index

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp8dsp: R-V V put_epel hv

2024-05-19 Thread flow gg
fix .irp use 于2024年5月19日周日 16:18写道: > From: sunyuechi > > C908: > vp8_put_epel4_h4v4_c: 20.0 > vp8_put_epel4_h4v4_rvv_i32: 11.0 > vp8_put_epel4_h4v6_c: 25.2 > vp8_put_epel4_h4v6_rvv_i32: 13.5 > vp8_put_epel4_h6v4_c: 22.2 > vp8_put_epel4_h6v4_rvv_i32: 14.5 > vp8_put_epel4_h6v6_c: 29.0 >

[FFmpeg-devel] [PATCH 1/4] lavc/vp8dsp: R-V V put_epel hv

2024-05-19 Thread uk7b
From: sunyuechi C908: vp8_put_epel4_h4v4_c: 20.0 vp8_put_epel4_h4v4_rvv_i32: 11.0 vp8_put_epel4_h4v6_c: 25.2 vp8_put_epel4_h4v6_rvv_i32: 13.5 vp8_put_epel4_h6v4_c: 22.2 vp8_put_epel4_h6v4_rvv_i32: 14.5 vp8_put_epel4_h6v6_c: 29.0 vp8_put_epel4_h6v6_rvv_i32: 15.7 vp8_put_epel8_h4v4_c: 73.0