Re: [FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-06 Thread Gyan Doshi
On 2024-06-05 12:47 am, Stefano Sabatini wrote: On date Tuesday 2024-06-04 23:41:05 +0530, Gyan Doshi wrote: Similar to select filter for video - it can only pass through or drop frames --- libavfilter/trim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/trim.c b

[FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-04 Thread Gyan Doshi
Similar to select filter for video - it can only pass through or drop frames --- libavfilter/trim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/trim.c b/libavfilter/trim.c index 4c1a2b4f48..4afc4c74bb 100644 --- a/libavfilter/trim.c +++ b/libavfilter/trim.c @@ -364,6 +364,7 @@

Re: [FFmpeg-devel] [PATCH] configure: correct libopenjpeg description

2024-05-31 Thread Gyan Doshi
On 2024-05-31 09:07 pm, Pierre-Anthony Lemieux wrote: On Fri, May 31, 2024 at 8:32 AM Gyan Doshi wrote: Decoding is no longer possible as the decoder wrapper was removed in 60ccb3fe78 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure

[FFmpeg-devel] [PATCH] configure: correct libopenjpeg description

2024-05-31 Thread Gyan Doshi
Decoding is no longer possible as the decoder wrapper was removed in 60ccb3fe78 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 96b181fd21..6c5b8aab9a 100755 --- a/configure +++ b/configure @@ -253,7 +253,7 @@ External library support:

Re: [FFmpeg-devel] [PATCH] avfilter/colorize: add speed option

2024-05-01 Thread Gyan Doshi
On 2024-05-01 12:18 pm, Yannis Gerlach wrote: The speed option allows to have a constant (per frame) change of hue. This allows for an easy way of creating an color changing effect without relying on somewhat complicated expressions. Signed-off-by: Yannis Gerlach ---  

Re: [FFmpeg-devel] [PATCH 0/5] replace scale2ref by scale=rw:rh

2024-04-24 Thread Gyan Doshi
On 2024-04-24 04:21 pm, Niklas Haas wrote: As discussed in my previous series for fixing scale2ref[1], this filter is fundamentally broken, and the only real fix would be to switch to activate(), or ideally FFFrameSync. [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-March/323382.html

Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var

2024-04-17 Thread Gyan Doshi
On 2024-04-17 05:25 pm, James Almer wrote: On 4/17/2024 8:31 AM, Gyan Doshi wrote: sum_delta_pts is unused since 3b358f151d ---   libavformat/ivfenc.c | 4 +---   1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 09782eecd6

[FFmpeg-devel] [PATCH] avformat/ivfenc: remove unused var

2024-04-17 Thread Gyan Doshi
sum_delta_pts is unused since 3b358f151d --- libavformat/ivfenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 09782eecd6..9feaea3516 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -24,7 +24,7 @@

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Gyan Doshi
On 2024-04-10 02:57 pm, Stefano Sabatini wrote: On date Tuesday 2024-04-09 10:36:05 +0200, Nicolas George wrote: [...] I am pointing that for the burden, I am not offering to do the same for free for the people who are so short-sighted they feel entitled to block software-defined radio,

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-04-08 Thread Gyan Doshi
Ping x2. On 2024-04-02 10:55 am, Gyan Doshi wrote: Ping. As the TC rules matter has been concluded, this should go ahead. Regards, Gyan On 2024-02-17 05:15 pm, Gyan Doshi wrote: Issue: Patch: avcodec/s302m: enable non-PCM decoding URL: https://patchwork.ffmpeg.org/project/ffmpeg/patch

Re: [FFmpeg-devel] [PATCH 11/31] fftools/ffmpeg_filter: stop accessing encoder AVCodecContext

2024-04-05 Thread Gyan Doshi
On 2024-04-05 10:20 pm, Dennis Mungai wrote: Does this imply that down the line, with this and additional patchsets, that FFmpeg can handle tasks such as stream copy and filtering in the same invocation? What do you mean? If you map a stream twice, you already can do that now. Regards,

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-04-01 Thread Gyan Doshi
Ping. As the TC rules matter has been concluded, this should go ahead. Regards, Gyan On 2024-02-17 05:15 pm, Gyan Doshi wrote: Issue: Patch: avcodec/s302m: enable non-PCM decoding URL: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ The issue

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-04-01 Thread Gyan Doshi
On 2024-04-01 04:46 pm, Anton Khirnov wrote: Hi all, the vote has now ended with 23 votes cast, results are available at https://vote.ffmpeg.org/cgi-bin/civs/results.pl?id=E_a6be1eb156d0e589 The winning option is 'Anton', i.e. my proposal. Voting data as reported by CIVS is attached to this

Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR

2024-03-29 Thread Gyan Doshi
On 2024-03-29 02:05 pm, Anton Khirnov wrote: --- libavformat/movenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index b97c479cc4..30cfbf6e74 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-25 Thread Gyan Doshi
On 2024-03-25 03:11 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-03-22 14:05:05) Please do post the final text and options a day in advance. I have now created the poll, but not started it yet (the text and options can still be edited). It looks like this: The description, my option

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-22 Thread Gyan Doshi
On 2024-03-22 06:22 pm, Anton Khirnov wrote: Michael, following up on the previous discussion in this thread - if you, personally, would like to vote for a different option than those suggested so far, please propose one. I am not going to add a large number of options that nobody actually

Re: [FFmpeg-devel] [PATCH] doc/community: rule to avoid conflict of interest and prejudice in TC

2024-03-21 Thread Gyan Doshi
-devel/2024-February/321564.html On 2024-03-03 12:52 pm, Gyan Doshi wrote: --- doc/community.texi | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/community.texi b/doc/community.texi index 90d2b6f366..8d5722bd7f 100644 --- a/doc/community.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH] fate/lavf-container: correct operator; unbreak build

2024-03-18 Thread Gyan Doshi
On 2024-03-18 04:11 pm, Liu Steven wrote: On Mar 18, 2024, at 18:11, Gyan Doshi wrote: --- tests/fate/lavf-container.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index b18ed2362b..7a925117c3 100644

[FFmpeg-devel] [PATCH] fate/lavf-container: correct operator; unbreak build

2024-03-18 Thread Gyan Doshi
--- tests/fate/lavf-container.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index b18ed2362b..7a925117c3 100644 --- a/tests/fate/lavf-container.mak +++ b/tests/fate/lavf-container.mak @@ -80,7 +80,7 @@

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-16 Thread Gyan Doshi
On 2024-03-16 02:02 pm, Marton Balint wrote: On Sat, 16 Mar 2024, Gyan Doshi wrote: 8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-15 Thread Gyan Doshi
8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed at https://github.com/streamlink/streamlink/issues/5876 Fixes #10908 ---

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: add loopback decoding

2024-03-14 Thread Gyan Doshi
On 2024-03-14 03:46 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-03-13 08:49:52) Are there any limitations to loopback decoding e.g. would a vpx w/alpha encode be decoded back to a alpha pix fmt? I don't know how vpx alpha works, was it a separate stream in the demuxer or something

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Gyan Doshi
On 2024-03-13 05:54 pm, Niklas Haas wrote: From: Niklas Haas This filter's existing design has a number of issues: - There is no guarantee whatsoever about the order in which frames are pushed onto the main and ref link, due to this being entirely dependent on the order in which

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: mark scale2ref as supporting dynamic sizes

2024-03-13 Thread Gyan Doshi
On 2024-03-13 05:54 pm, Niklas Haas wrote: From: Niklas Haas Analogous to the "scale" filter, which this is practically identical with. --- libavfilter/avfilter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: add loopback decoding

2024-03-13 Thread Gyan Doshi
On 2024-03-13 12:57 pm, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Mon Feb 19 10:27:44 2024 +0100| [a9193f7b7d65aafa326e25571c6672636a8ee3d2] | committer: Anton Khirnov fftools/ffmpeg: add loopback decoding ... +E.g. the following example: + +@example +ffmpeg -i

Re: [FFmpeg-devel] [PATCH] configure: add threads dep for vulkan

2024-03-12 Thread Gyan Doshi
On 2024-03-12 09:15 pm, Lynne wrote: Mar 12, 2024, 05:16 by ffm...@gyani.pro: Fixes #10900 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 05f8283af9..e0b5bcf589 100755 --- a/configure +++ b/configure @@ -3076,6 +3076,7 @@

Re: [FFmpeg-devel] [PATCH] doc/muxers: add ffmetadata

2024-03-12 Thread Gyan Doshi
On 2024-03-12 04:25 pm, Stefano Sabatini wrote: --- doc/metadata.texi | 1 + doc/muxers.texi | 16 2 files changed, 17 insertions(+) diff --git a/doc/metadata.texi b/doc/metadata.texi index be91059a98..e081da7735 100644 --- a/doc/metadata.texi +++ b/doc/metadata.texi

[FFmpeg-devel] [PATCH] configure: add threads dep for vulkan

2024-03-11 Thread Gyan Doshi
Fixes #10900 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 05f8283af9..e0b5bcf589 100755 --- a/configure +++ b/configure @@ -3076,6 +3076,7 @@ nvdec_deps="ffnvcodec" vaapi_x11_deps="xlib_x11" videotoolbox_hwaccel_deps="videotoolbox pthreads"

Re: [FFmpeg-devel] [PATCH] avfilter: update filter timeline state only on main link

2024-03-11 Thread Gyan Doshi
On 2024-03-06 11:02 am, Gyan Doshi wrote: On 2024-03-01 07:41 pm, Gyan Doshi wrote: At present, consume_update evaluates timeline state on all links for a multi-input filter. This can lead to the filter being incorrectly en/dis-abled when evaluation on a frame on a secondary link leads

Re: [FFmpeg-devel] [PATCH] avfilter: update filter timeline state only on main link

2024-03-05 Thread Gyan Doshi
On 2024-03-01 07:41 pm, Gyan Doshi wrote: At present, consume_update evaluates timeline state on all links for a multi-input filter. This can lead to the filter being incorrectly en/dis-abled when evaluation on a frame on a secondary link leads to a different result than the frame

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-02 Thread Gyan Doshi
On 2024-03-03 07:04 am, Michael Niedermayer wrote: On Sat, Mar 02, 2024 at 11:07:40AM +0530, Gyan Doshi wrote: On 2024-03-01 11:03 pm, Anton Khirnov wrote: * Any member of the TC who had a strong opinion on the question raised before it was raised should recuse themselves

[FFmpeg-devel] [PATCH] doc/community: rule to avoid conflict of interest and prejudice in TC

2024-03-02 Thread Gyan Doshi
--- doc/community.texi | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/community.texi b/doc/community.texi index 90d2b6f366..8d5722bd7f 100644 --- a/doc/community.texi +++ b/doc/community.texi @@ -82,7 +82,20 @@ The TC has 2 modes of operation: a RFC one

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-01 Thread Gyan Doshi
On 2024-03-01 11:03 pm, Anton Khirnov wrote: * Any member of the TC who had a strong opinion on the question raised before it was raised should recuse themselves. In particular, must recuse themselves any member of the TC who: - participated in the discussion (on the ML, on IRC or

[FFmpeg-devel] [PATCH] avfilter: update filter timeline state only on main link

2024-03-01 Thread Gyan Doshi
At present, consume_update evaluates timeline state on all links for a multi-input filter. This can lead to the filter being incorrectly en/dis-abled when evaluation on a frame on a secondary link leads to a different result than the frame on the current main link next in line for processing. ---

[FFmpeg-devel] [PATCH] configure: select iamfenc as movenc dep

2024-02-24 Thread Gyan Doshi
Unbreaks movenc compilation in minimal configuration. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 197f762b58..2d0e6a444a 100755 --- a/configure +++ b/configure @@ -3554,7 +3554,7 @@ mlp_demuxer_select="mlp_parser"

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Gyan Doshi
On 2024-02-23 01:26 pm, Nicolas George wrote: Anton Khirnov (12024-02-22): In my updated proposal, based on comments by Niklas and Rémi, I'm leaving it up to the TC member in question, based on the assumption that TC members are honest. A "stronger" version could conceivably leave it to CC

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-21 Thread Gyan Doshi
On 2024-02-20 04:39 pm, Anton Khirnov wrote: As for determining conflict of interest in case of dishonest TC members, I don't think there is a general solution for it. This is not about dishonesty. Imagine a TC member genuinely does not self-assess or agree to a conflict of interest, does

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-20 Thread Gyan Doshi
On 2024-02-20 02:20 pm, Anton Khirnov wrote: So IMO the only case that needs to be excluded is 6) - an actual conflict of interest. I therefore propose the following wording changes: --- a/doc/community.texi +++ b/doc/community.texi -If the disagreement involves a member of the TC, that

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Gyan Doshi
On 2024-02-19 08:00 pm, Vittorio Giovara wrote: On Mon, Feb 19, 2024 at 6:11 AM Gyan Doshi wrote: The TC is invoked when there's an intractable dispute. So the dispute precedes the TC activity hence the parties to the dispute are the main opposing participants at the venue of the dispute

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-18 Thread Gyan Doshi
On 2024-02-19 03:16 am, Vittorio Giovara wrote: On Sun, Feb 18, 2024 at 8:02 PM Gyan Doshi wrote: On 2024-02-18 11:33 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-18 05:06:30) b) what "maximalist" interpretation? A non-maximalist interpretation would be that a TC memb

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-18 Thread Gyan Doshi
On 2024-02-18 11:33 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-18 05:06:30) b) what "maximalist" interpretation? A non-maximalist interpretation would be that a TC member is only excluded from voting when they authored the patch that is being disputed. If the promulga

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-18 01:25 am, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-17 13:37:38) On 2024-02-17 05:52 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-17 12:46:27) As a TC member who is part of the disagreement, I believe your participation is recused. No, I do not think &qu

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Gyan Doshi
On 2024-02-17 07:12 pm, Niklas Haas wrote: On Sat, 17 Feb 2024 18:45:57 +0530 Gyan Doshi wrote: Whilst s302m multiple substreams I haven't seen, Dolby E streams internally contain multiple programs, often 5.1 and a 2.0 downmix. That is downstream of the Dolby-E decoder and user will have

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Gyan Doshi
On 2024-02-17 05:31 pm, Kieran Kunhya wrote: On Sat, 17 Feb 2024, 11:46 Gyan Doshi, wrote: Issue: Patch: avcodec/s302m: enable non-PCM decoding URL: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ The issue needing resolution is whether

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-17 05:52 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-17 12:46:27) As a TC member who is part of the disagreement, I believe your participation is recused. No, I do not think "TC members who commented on a patch lose their right to vote" is a reasonable inte

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-16 02:33 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-15 17:47:49) This patch facilitates a certain productive use of ffmpeg with respect to processing of live inputs that wasn't possible earlier, and which currently is being used successfully by multiple people over

[FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Gyan Doshi
Issue: Patch: avcodec/s302m: enable non-PCM decoding URL: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ The issue needing resolution is whether the patch should be added to the existing s302m decoder or should that decoder be removed and all old

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-16 07:25 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2024-02-15 04:17 pm, Anton Khirnov wrote: Hi, sorry for the delay, I've been busy fixing things for the release Quoting Gyan Doshi via ffmpeg-devel (2024-01-29 05:00:33) On 2024-01-28 04:24 pm, Anton Khirnov wrote

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-15 Thread Gyan Doshi
On 2024-02-16 01:56 am, Kieran Kunhya wrote: On Thu, 15 Feb 2024 at 16:48, Gyan Doshi wrote: On 2024-02-15 09:40 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-15 13:31:59) On 2024-02-15 04:17 pm, Anton Khirnov wrote: Hi, sorry for the delay, I've been busy fixing things

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-15 Thread Gyan Doshi
On 2024-02-15 09:40 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-15 13:31:59) On 2024-02-15 04:17 pm, Anton Khirnov wrote: Hi, sorry for the delay, I've been busy fixing things for the release Quoting Gyan Doshi via ffmpeg-devel (2024-01-29 05:00:33) On 2024-01-28 04:24 pm, Anton

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-15 Thread Gyan Doshi
On 2024-02-15 04:17 pm, Anton Khirnov wrote: Hi, sorry for the delay, I've been busy fixing things for the release Quoting Gyan Doshi via ffmpeg-devel (2024-01-29 05:00:33) On 2024-01-28 04:24 pm, Anton Khirnov wrote: a) it would mean essentially inlining this decoder in the demuxer. Why

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-13 Thread Gyan Doshi
On 2024-01-27 04:08 pm, Gyan Doshi wrote: Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. Plan to push in 3 days, barring objections. Regards, Gyan --- configure | 1 + doc

Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

2024-02-04 Thread Gyan Doshi
On 2024-02-02 03:34 pm, Gyan Doshi wrote: On 2024-01-29 10:30 am, Gyan Doshi wrote: Existing use of strtoll can lead to ERANGE errors leading to incorrect storage of UMID. Plan to push tomorrow. Pushed as 7375a6ca7b4a4b223a71f85a772c64a34e60eabe Regards, Gyan

Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

2024-02-02 Thread Gyan Doshi
On 2024-01-29 10:30 am, Gyan Doshi wrote: Existing use of strtoll can lead to ERANGE errors leading to incorrect storage of UMID. Plan to push tomorrow. Regards, Gyan --- libavformat/wavenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavenc.c b

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: limit link variance logs below debug loglevel

2024-02-01 Thread Gyan Doshi
On 2024-01-31 09:49 am, Gyan Doshi wrote: On 2024-01-26 07:39 pm, Gyan Doshi wrote: The video param change check will print loglines below debug level for each frame which is different from the inlink parameters. This can spam the console. It is now printed at warning level once for each

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: limit link variance logs below debug loglevel

2024-01-30 Thread Gyan Doshi
On 2024-01-26 07:39 pm, Gyan Doshi wrote: The video param change check will print loglines below debug level for each frame which is different from the inlink parameters. This can spam the console. It is now printed at warning level once for each param change else it is kept at debug level

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-29 Thread Gyan Doshi
On 2024-01-29 02:57 pm, Nicolas Gaullier wrote: On 2024-01-28 04:24 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-01-26 05:23:50) On 2024-01-25 06:47 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2024-01-25 10:29 am, Andreas Rheinhardt wrote: Gyan Doshi: Set up framework for non-PCM

[FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

2024-01-28 Thread Gyan Doshi
Existing use of strtoll can lead to ERANGE errors leading to incorrect storage of UMID. --- libavformat/wavenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c index 82acb9ef0f..a41f40b449 100644 --- a/libavformat/wavenc.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-28 Thread Gyan Doshi via ffmpeg-devel
On 2024-01-28 04:24 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-01-26 05:23:50) On 2024-01-25 06:47 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2024-01-25 10:29 am, Andreas Rheinhardt wrote: Gyan Doshi: Set up framework for non-PCM decoding in-place and add support for Dolby-E

[FFmpeg-devel] [PATCH v2 2/2] fate: add tests for dolby_e decoding in s302m

2024-01-27 Thread Gyan Doshi
Three tests, one each for 1) 16-bit Dolby-E words in 20-bits AES3 words 2) 20-bit Dolby-E words in 20-bits AES3 words 3) 20-bit Dolby-E words in 24-bits AES3 words --- tests/fate/acodec.mak | 15 ++ tests/ref/acodec/s302m-20-dolbye-16 | 221

[FFmpeg-devel] [PATCH v2 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-27 Thread Gyan Doshi
Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. --- configure | 1 + doc/decoders.texi | 40 +++ libavcodec/s302m.c | 596 + 3 files

[FFmpeg-devel] [PATCH] avfilter/buffersrc: limit link variance logs below debug loglevel

2024-01-26 Thread Gyan Doshi
The video param change check will print loglines below debug level for each frame which is different from the inlink parameters. This can spam the console. It is now printed at warning level once for each param change else it is kept at debug level. Partially addresses #10823 ---

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-25 Thread Gyan Doshi
On 2024-01-25 06:47 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2024-01-25 10:29 am, Andreas Rheinhardt wrote: Gyan Doshi: Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. ---   configure

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-24 Thread Gyan Doshi
On 2024-01-25 10:29 am, Andreas Rheinhardt wrote: Gyan Doshi: Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. --- configure | 1 + doc/decoders.texi | 40 +++ libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-23 Thread Gyan Doshi
On 2024-01-23 03:58 pm, Nicolas Gaullier wrote: +#define IS_NONPCMSYNC_16(state) ((state & 0x00) == NONPCMSYNC_16MARKER) Is this single 32 bits marker enough to avoid a fake detection ? It will have to do. The modal number of payload packets expected in a single s302m

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-23 Thread Gyan Doshi
On 2024-01-23 01:26 pm, Kieran Kunhya wrote: On Tue, 23 Jan 2024 at 06:50, Gyan Doshi wrote: Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. Does this handle a Dolby E packet spanning

[FFmpeg-devel] [PATCH 2/2] fate: add tests for dolby_e decoding in s302m

2024-01-22 Thread Gyan Doshi
Three tests, one each for 1) 16-bit Dolby-E words in 20-bits AES3 words 2) 20-bit Dolby-E words in 20-bits AES3 words 3) 20-bit Dolby-E words in 24-bits AES3 words --- tests/fate/acodec.mak | 15 ++ tests/ref/acodec/s302m-20-dolbye-16 | 221

[FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-22 Thread Gyan Doshi
Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. --- configure | 1 + doc/decoders.texi | 40 +++ libavcodec/s302m.c | 609 + 3 files

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Gyan Doshi
On 2024-01-08 08:23 am, Zhao Zhili wrote: On Jan 7, 2024, at 20:05, Stefano Sabatini wrote: On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: [...] I'm not blocking the patch, however, I'm not sure whether the gain outweighs the effort for such large code changes. It's very

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2024-01-03 Thread Gyan Doshi
On 2024-01-03 03:46 pm, Thilo Borgmann via ffmpeg-devel wrote: Am 03.01.24 um 11:10 schrieb Gyan Doshi: On 2024-01-03 02:28 pm, Thilo Borgmann via ffmpeg-devel wrote: Am 01.12.23 um 12:37 schrieb Paul B Mahol: On Fri, Dec 1, 2023 at 12:24 PM Gyan Doshi wrote: On 2023-09-25 11:35 pm

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2024-01-03 Thread Gyan Doshi
On 2024-01-03 02:28 pm, Thilo Borgmann via ffmpeg-devel wrote: Am 01.12.23 um 12:37 schrieb Paul B Mahol: On Fri, Dec 1, 2023 at 12:24 PM Gyan Doshi wrote: On 2023-09-25 11:35 pm, Paul B Mahol wrote: On 9/11/23, Harshit Karwal wrote: 1. Replaced ring buffer ADT with AVAudioFifo from

Re: [FFmpeg-devel] [PATCH] configure: correct lensfun header function check

2024-01-01 Thread Gyan Doshi
On 2024-01-01 09:33 am, Gyan Doshi wrote: On 2023-12-31 01:03 pm, Gyan Doshi wrote: The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017 in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d but the configure check wasn't changed. lensfun removed lf_db_new

Re: [FFmpeg-devel] [PATCH] configure: correct lensfun header function check

2023-12-31 Thread Gyan Doshi
On 2023-12-31 01:03 pm, Gyan Doshi wrote: The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017 in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d but the configure check wasn't changed. lensfun removed lf_db_new declaration in lf 35c0017593 so configure fails

[FFmpeg-devel] [PATCH] configure: correct lensfun header function check

2023-12-30 Thread Gyan Doshi
The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017 in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d but the configure check wasn't changed. lensfun removed lf_db_new declaration in lf 35c0017593 so configure fails to find lensfun. --- configure | 2 +- 1 file

Re: [FFmpeg-devel] [PATCH v2] avformat/riffenc: don't force WAVEFORMATEXTENSIBLE for flt/dbl LPCM

2023-12-28 Thread Gyan Doshi
On 2023-12-26 09:25 am, Gyan Doshi wrote: Plan to push in 48h, barring objections. Pushed as c1340f3439ef4eba34e8e51e1f7c0bf789e3256a Regards, Gyan On 2023-12-21 03:31 pm, Gyan Doshi wrote: 2c2a167ca7 forced WAVEFORMATEXTENSIBLE for all LPCM streams with greater than 16 bits per sample

Re: [FFmpeg-devel] [PATCH v2] avformat/riffenc: don't force WAVEFORMATEXTENSIBLE for flt/dbl LPCM

2023-12-25 Thread Gyan Doshi
Plan to push in 48h, barring objections. On 2023-12-21 03:31 pm, Gyan Doshi wrote: 2c2a167ca7 forced WAVEFORMATEXTENSIBLE for all LPCM streams with greater than 16 bits per sample. However, WAVEFORMATEX allows IEEE Float samples or any depth where raw depth == coded depth, see Remarks section

[FFmpeg-devel] [PATCH v2] avformat/riffenc: don't force WAVEFORMATEXTENSIBLE for flt/dbl LPCM

2023-12-21 Thread Gyan Doshi
2c2a167ca7 forced WAVEFORMATEXTENSIBLE for all LPCM streams with greater than 16 bits per sample. However, WAVEFORMATEX allows IEEE Float samples or any depth where raw depth == coded depth, see Remarks section at https://learn.microsoft.com/en-us/windows/win32/api/mmreg/ns-mmreg-waveformatex and

[FFmpeg-devel] [PATCH] avformat/riffenc: don't force WAVEFORMATEXTENSIBLE for flt/dbl LPCM

2023-12-20 Thread Gyan Doshi
2c2a167ca7 forced WAVEFORMATEXTENSIBLE for all LPCM streams with greater than 16 bits per sample. However, WAVEFORMATEX allows IEEE Float samples or any depth where raw depth == coded depth, see Remarks section at https://learn.microsoft.com/en-us/windows/win32/api/mmreg/ns-mmreg-waveformatex and

Re: [FFmpeg-devel] [PATCH v3] swr/swresample: avoid reapplication of firstpts

2023-12-18 Thread Gyan Doshi
On 2023-12-18 09:31 am, Gyan Doshi wrote: On 2023-12-16 03:44 pm, Gyan Doshi wrote: During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation

Re: [FFmpeg-devel] [PATCH v3] swr/swresample: avoid reapplication of firstpts

2023-12-17 Thread Gyan Doshi
On 2023-12-16 03:44 pm, Gyan Doshi wrote: During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation) then upon first encountering a delay where a soft

[FFmpeg-devel] [PATCH] src/consulting: correct cell alignment after b7a2be0611

2023-12-16 Thread Gyan Doshi
/src/consulting @@ -106,8 +106,6 @@ E.g.: - - Steven Liu @@ -121,6 +119,8 @@ E.g.: + + Gyan Doshi -- 2.39.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH v2] swr/swresample: avoid reapplication of firstpts

2023-12-16 Thread Gyan Doshi
On 2023-12-15 11:46 pm, Michael Niedermayer wrote: On Fri, Dec 15, 2023 at 12:30:46PM +0530, Gyan Doshi wrote: During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using

[FFmpeg-devel] [PATCH v3] swr/swresample: avoid reapplication of firstpts

2023-12-16 Thread Gyan Doshi
During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation) then upon first encountering a delay where a soft compensation is required, swr_set_compensation

Re: [FFmpeg-devel] [PATCH] swr/swresample: avoid reapplication of firstpts

2023-12-14 Thread Gyan Doshi
On 2023-12-15 12:43 am, Michael Niedermayer wrote: On Tue, Dec 12, 2023 at 04:50:08PM +0530, Gyan Doshi wrote: During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using

[FFmpeg-devel] [PATCH v2] swr/swresample: avoid reapplication of firstpts

2023-12-14 Thread Gyan Doshi
During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation) then upon first encountering a delay where a soft compensation is required, swr_set_compensation

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Gyan Doshi
On 2023-12-14 04:56 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-12-14 12:22:51) On 2023-12-14 02:48 pm, Anton Khirnov wrote: On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 16:37:52 2023 +0200

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-14 Thread Gyan Doshi
On 2023-12-14 02:48 pm, Anton Khirnov wrote: On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | committer: Anton Khirnov fftools/ffmpeg: convert to a threaded

[FFmpeg-devel] [PATCH] swr/swresample: avoid reapplication of firstpts

2023-12-12 Thread Gyan Doshi
During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation) then upon first encountering a delay where a soft compensation is required, swr_set_compensation

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: fix -copy_ts typo, should be -copyts

2023-12-10 Thread Gyan Doshi
On 2023-12-11 09:13 am, Marth64 wrote: Signed-off-by: Marth64 --- doc/ffmpeg.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 6bcedd76d5..36fdaef879 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1861,7 +1861,7 @@ of

Re: [FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN

2023-12-09 Thread Gyan Doshi
On 2023-12-10 06:03 am, Stefano Sabatini wrote: On date Friday 2023-12-08 13:05:43 +0530, Gyan Doshi wrote: As per the doc, prev_selected_n should be NAN at the start. However, this was never set. --- libavfilter/f_select.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter

[FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN

2023-12-07 Thread Gyan Doshi
As per the doc, prev_selected_n should be NAN at the start. However, this was never set. --- libavfilter/f_select.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index 47e36f0014..109dae403a 100644 --- a/libavfilter/f_select.c +++

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2023-12-01 Thread Gyan Doshi
On 2023-09-25 11:35 pm, Paul B Mahol wrote: On 9/11/23, Harshit Karwal wrote: 1. Replaced ring buffer ADT with AVAudioFifo from libavutil/audio_fifo.h 2. Fixed potential freeing of uninitialised pointers in uninit 3. Minor changes like removing unused headers Will apply with more fixes

Re: [FFmpeg-devel] [PATCH 11/13] avformat/demux: support inserting bitstream filters in demuxing scenarios

2023-11-29 Thread Gyan Doshi
On 2023-11-30 03:25 am, James Almer wrote: On 11/28/2023 1:00 AM, Gyan Doshi wrote: On 2023-11-28 12:13 am, James Almer wrote: Packets will be passed to the bsf immediately after being generated by a demuxer, and no further data will be read from the input until all packets have been

Re: [FFmpeg-devel] [PATCH 11/13] avformat/demux: support inserting bitstream filters in demuxing scenarios

2023-11-27 Thread Gyan Doshi
On 2023-11-28 12:13 am, James Almer wrote: Packets will be passed to the bsf immediately after being generated by a demuxer, and no further data will be read from the input until all packets have been returned by the bsf. Do you plan to add a lib/cli option for user-specified insertions?

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Gyan Doshi
On 2023-11-27 11:38 pm, Kyle Swanson wrote: Hi, On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi wrote: Will push soon. This filter can take any number of models now, each defining their own pooling methods. Looking at the docs now, I can see that it's not clear how to do this, I'll need to send

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Gyan Doshi
Will push soon. On 2023-11-26 04:08 pm, Gyan Doshi wrote: 3d29724c00 removed the doc entry for the option pool while adding a parser function for it at the same time! The option remains available and undeprecated. --- doc/filters.texi | 4 1 file changed, 4 insertions(+) diff --git

[FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-26 Thread Gyan Doshi
3d29724c00 removed the doc entry for the option pool while adding a parser function for it at the same time! The option remains available and undeprecated. --- doc/filters.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index

Re: [FFmpeg-devel] [PATCH 2/3] doc/ffmpeg: Update the description about d3d11va

2023-11-23 Thread Gyan Doshi
On 2023-11-24 11:13 am, Xiang, Haihao wrote: From: Haihao Xiang Signed-off-by: Haihao Xiang --- doc/ffmpeg.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 68363ae045..5296b75a4e 100644 --- a/doc/ffmpeg.texi +++

Re: [FFmpeg-devel] [PATCH 1/2] doc/filters:ddagrab: elaborate on the semantics of framerate

2023-11-21 Thread Gyan Doshi
On 2023-11-19 05:19 pm, Anton Khirnov wrote: --- doc/filters.texi | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 38615e4f18..bd4e4ca8f7 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -28163,7 +28163,12 @@ Only

Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: add version guard for external param

2023-11-12 Thread Gyan Doshi
On 2023-11-12 08:27 pm, Gyan Doshi wrote: On 2023-11-08 10:25 am, Gyan Doshi wrote: Setting of external param 'force_key_frames' was added in 7bcc1b4eb8. It is available since v1.1.0 but ffmpeg allows linking against v0.9.0. Plan to push tomorrow, barring objections. Pushed

  1   2   3   4   5   6   7   8   9   10   >