[FFmpeg-devel] [PATCH v2 3/4] avcodec/mpegvideo_enc: do not use AVFrame.*_picture_number for encoding

2023-02-10 Thread Marton Balint
Move these fields to MPEGPicture instead and use that. Signed-off-by: Marton Balint --- libavcodec/mpeg12enc.c | 4 ++-- libavcodec/mpegpicture.c | 4 libavcodec/mpegpicture.h | 3 +++ libavcodec/mpegvideo_enc.c | 17 ++--- libavcodec/ratecontrol.c | 4

[FFmpeg-devel] [PATCH v2 2/4] avcodec/diracdec: do not use AVFrame.display_picture_number for decoding

2023-02-10 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/diracdec.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index a5cad29597..22a2925188 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing

2023-02-09 Thread Marton Balint
On Thu, 9 Feb 2023, Aline Gondim Santos Gondim Santos wrote: Hello Nicolas, Bellow you can find the bechmarks using `ffmpeg -benchmark` option. Utime change seems significant - as expected. In general I don't like the idea of removing shared memory support, and I don't quite see why

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc.c -- correctly re-emit extradata ahead of IDR pictures

2023-02-05 Thread Marton Balint
On Tue, 31 Jan 2023, John Coiner wrote: This replaces and obsoletes the earlier version of this patch, which had a bug. Thanks to Marton Balint for spotting it. This fixes https://trac.ffmpeg.org/ticket/10148, it ensures that each IDR frame is prefixed with SPS/PPS. Tested manually

Re: [FFmpeg-devel] [PATCH] avformat/tee: signal EOF if no more output is to be published.

2023-02-03 Thread Marton Balint
On Fri, 3 Feb 2023, Gyan Doshi wrote: On 2023-02-03 04:17 am, Marton Balint wrote: On Thu, 2 Feb 2023, Gyan Doshi wrote: Prior to 2d924b3a630, ffmpeg.c would exit if any packet write failed. tee's write_packet seemingly relied on that to enforce its abort failure policy. From

Re: [FFmpeg-devel] [PATCH] avformat/tee: signal EOF if no more output is to be published.

2023-02-02 Thread Marton Balint
On Thu, 2 Feb 2023, Gyan Doshi wrote: Prior to 2d924b3a630, ffmpeg.c would exit if any packet write failed. tee's write_packet seemingly relied on that to enforce its abort failure policy. From 2d924b3a630, ffmpeg only closes that OutputStream and keeps on sending packets of other streams.

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc.c -- correctly re-emit extradata ahead of IDR pictures

2023-01-30 Thread Marton Balint
On Mon, 30 Jan 2023, John Coiner wrote: Marton Balint wrote: This does not look right, because AFAIK you always want to insert an AUD unless it is already there. I guess that is why current code works as it is, it assumes if an AUD is already present, then IDR-s are already prefixed

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc.c -- correctly re-emit extradata ahead of IDR pictures

2023-01-29 Thread Marton Balint
On Fri, 27 Jan 2023, John Coiner wrote: From: John Coiner This is the proposed fix for https://trac.ffmpeg.org/ticket/10148 Very sorry to send the same patch 3 times; this time with `git send-email' so it should be legal :) --- libavformat/mpegtsenc.c | 18 +++--- 1 file

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2023-01-29 Thread Marton Balint
On Sun, 22 Jan 2023, Marton Balint wrote: On Wed, 28 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael

[FFmpeg-devel] [PATCH 4/4] avutil/frame: deprecate AVFrame.coded_picture_number and display_picture_number

2023-01-28 Thread Marton Balint
Their usefulness are questionable, very few decoders set them, and their type should have been int64_t. A replacement field can be added later if a valid use case is found. Signed-off-by: Marton Balint --- doc/APIchanges | 4 doc/examples/demuxing_decoding.c | 4

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo_enc: do not use AVFrame.*_picture_number for encoding

2023-01-28 Thread Marton Balint
Move these fields to MPEGPicture instead and use that. Signed-off-by: Marton Balint --- libavcodec/mpeg12enc.c | 4 ++-- libavcodec/mpegpicture.c | 4 libavcodec/mpegpicture.h | 3 +++ libavcodec/mpegvideo_enc.c | 17 ++--- libavcodec/ratecontrol.c | 4

[FFmpeg-devel] [PATCH 2/4] avcodec/diracdec: do not use AVFrame.display_picture_number for decoding

2023-01-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/diracdec.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index a5cad29597..22a2925188 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c

[FFmpeg-devel] [PATCH 1/4] avcodec: add AVCodecContext.frame_num as 64 bit variant to frame_number

2023-01-28 Thread Marton Balint
Frame counters can overflow relatively easily (INT_MAX number of frames is slightly more than 1 year for 60 fps content), so make sure we use 64 bit values for them. Also deprecate the old 32 bit frame_number attribute. Signed-off-by: Marton Balint --- doc/APIchanges | 4

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-28 Thread Marton Balint
On Fri, 27 Jan 2023, Marton Balint wrote: On Fri, 27 Jan 2023, James Almer wrote: On 1/27/2023 3:04 PM, Anton Khirnov wrote: Quoting Marton Balint (2023-01-27 18:59:39) On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread Marton Balint
On Fri, 27 Jan 2023, James Almer wrote: On 1/27/2023 3:04 PM, Anton Khirnov wrote: Quoting Marton Balint (2023-01-27 18:59:39) On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do for everything else. You mean you want

Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-27 Thread Marton Balint
On Fri, 27 Jan 2023, Anton Khirnov wrote: I still think we should do a deprecation+replacement like we do for everything else. You mean you want to introduce a new 64 bit member and deprecate the old 32 bit field? E.g. int64_t frame_num; attribute_deprcated int frame_number And

[FFmpeg-devel] [BUMP PATCH 2/2] avutil/frame: change AVFrame.*_picture_number to int64_t

2023-01-26 Thread Marton Balint
this as well. The alternative would be to introduce separate 64-bit counters for the int64 type, and keep the two values in sync, but that would be also quite ugly. So let's do what we already did for AVFormatContext.bit_rate some years ago and simply change the type. Signed-off-by: Marton Balint

[FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t

2023-01-26 Thread Marton Balint
to do this as well. The alternative would be to introduce separate 64-bit counters for the int64 type, and keep the two values in sync, but that would be also quite ugly. So let's do what we already did for AVFormatContext.bit_rate some years ago and simply change the type. Signed-off-by: Marton

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mpeg4videoenc: use MpegEncContext->picture_number instead of encode function parameter

2023-01-26 Thread Marton Balint
On Tue, 24 Jan 2023, Marton Balint wrote: They should be the same and that is what most encode functions use. Applied the series. Regards, Marton Signed-off-by: Marton Balint --- libavcodec/mpeg4videoenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 23:28, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 21:08, Marton

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: On Wed, 25 Jan 2023, James Almer wrote: On 1/24/2023 12:45 PM, Anton Khirnov wrote

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: On Wed, 25 Jan 2023, James Almer wrote: On 1/24/2023 12:45 PM, Anton Khirnov wrote: So to summarize the discussion so far: * nobody is strongly arguing for an instability period after

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, James Almer wrote: On 1/24/2023 12:45 PM, Anton Khirnov wrote: So to summarize the discussion so far: * nobody is strongly arguing for an instability period after the bump, and there are good reasons against it, therefore we should NOT have one * the bump

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-24 Thread Marton Balint
On Tue, 24 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-24 01:06:46) On Tue, 24 Jan 2023, Michael Niedermayer wrote: On Tue, Jan 24, 2023 at 12:22:52AM +0100, Marton Balint wrote: On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-23 23:41:11

[FFmpeg-devel] [PATCH 5/5] avcodec/ffv1: use 64-bit frame counter

2023-01-23 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/ffv1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index 005f308784..04869da5c9 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@ -85,7 +85,7 @@ typedef struct FFV1Context { int

[FFmpeg-devel] [PATCH 4/5] avcodec/ratecontrol: drop remnants of libxvid rate control

2023-01-23 Thread Marton Balint
--- libavcodec/ratecontrol.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/ratecontrol.h b/libavcodec/ratecontrol.h index 2a7aaec644..4de80fad90 100644 --- a/libavcodec/ratecontrol.h +++ b/libavcodec/ratecontrol.h @@ -80,9 +80,6 @@ typedef struct RateControlContext{ int

[FFmpeg-devel] [PATCH 3/5] avcodec/mpegvideo: remove picture_number parameter from encode functions

2023-01-23 Thread Marton Balint
They are unused. Signed-off-by: Marton Balint --- libavcodec/flvenc.c| 2 +- libavcodec/flvenc.h| 2 +- libavcodec/h261enc.c | 2 +- libavcodec/h261enc.h | 2 +- libavcodec/h263enc.h | 2 +- libavcodec/ituh263enc.c| 2 +- libavcodec/mpeg12enc.c

[FFmpeg-devel] [PATCH 2/5] avcodec/rv20enc: use MpegEncContext->picture_number instead of encode function parameter

2023-01-23 Thread Marton Balint
They should be the same and that is what most encode functions use. Signed-off-by: Marton Balint --- libavcodec/rv20enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rv20enc.c b/libavcodec/rv20enc.c index a6bacacb48..00f6c41e77 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 1/5] avcodec/mpeg4videoenc: use MpegEncContext->picture_number instead of encode function parameter

2023-01-23 Thread Marton Balint
They should be the same and that is what most encode functions use. Signed-off-by: Marton Balint --- libavcodec/mpeg4videoenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index a2a14afbd0..e327334d59 100644

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Marton Balint
On Tue, 24 Jan 2023, Michael Niedermayer wrote: On Tue, Jan 24, 2023 at 12:22:52AM +0100, Marton Balint wrote: On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-23 23:41:11) On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-21 23:00:52

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Marton Balint
On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-23 23:41:11) On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-21 23:00:52) AVCodecContext->frame_number should be changed to int64_t. I guess you could do something similar which was d

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Marton Balint
On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-21 23:00:52) On Sat, 21 Jan 2023, Michael Niedermayer wrote: On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-01-20 03:05:09) PS: iam not sure i fully understood

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2023-01-21 Thread Marton Balint
On Wed, 28 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marton Balint
On Sat, 21 Jan 2023, Michael Niedermayer wrote: On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-01-20 03:05:09) PS: iam not sure i fully understood the reason behind why versions should be set to "wrong" values during some period, so as

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2022-12-28 Thread Marton Balint
On Wed, 28 Dec 2022, Jeffrey CHAPUIS wrote: Updated working patch with ff_filter_process_command and no memory leaks. Signed-off-by: Ashyni --- doc/filters.texi | 13 + libavfilter/vf_cropdetect.c| 15 --

[FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: check number of index table entires more strictly

2022-12-27 Thread Marton Balint
/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 2e61e77d67..0dc61648b1 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1937,6

[FFmpeg-devel] [PATCH 2/3] avformat/mxfdec: support Avid files with an extra index entry

2022-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index ad4ee15570..2e61e77d67 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1991,11 +1991,11 @@ static int

[FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: check index entry array size

2022-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e6118e141d..ad4ee15570 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1198,11 +1198,15 @@ static int

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2022-12-27 Thread Marton Balint
On Tue, 27 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: lör 2022-12-24

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2022-12-27 Thread Marton Balint
On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2022-12-27 Thread Marton Balint
On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: index_table->nb_ptses += s->index_duration; +    // If index_duration is substantially larger than

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Remove this_partition

2022-12-23 Thread Marton Balint
On Fri, 23 Dec 2022, Michael Niedermayer wrote: Suggested-by: Tomas Härdin Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) this_partition should be == pack_ofs - run_in, not pack_ofs

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-22 Thread Marton Balint
On Mon, 19 Dec 2022, "zhilizhao(赵志立)" wrote: On Dec 19, 2022, at 21:40, Marvin Scholz wrote: On 19 Dec 2022, at 14:37, Nicolas George wrote: Marvin Scholz (12022-12-19): IIUC this means the `-mask_url` option has to be the first option passed, which seems a bit of an unfortunate

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: re-allow zero sample sizes if that is not the default

2022-12-14 Thread Marton Balint
On Mon, 12 Dec 2022, Chris Ribble wrote: On Sun, Dec 11, 2022 at 2:34 PM Chris Ribble wrote: This looks great and I've confirmed it fixes the issue. I see the warning on STDERR about ignoring the trun box: "Ignoring trun box with zero sized samples", which is great. Actually, this

[FFmpeg-devel] [PATCH v2 2/2] avformat/mov: re-allow zero sample sizes if that is not the default

2022-12-11 Thread Marton Balint
timeout issue from fuzzed files differently. Signed-off-by: Marton Balint --- libavformat/mov.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 935b2f8d9f..63e0b614df 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5121,6

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-11 Thread Marton Balint
On Tue, 6 Dec 2022, Chris Ribble wrote: On Mon, Dec 5, 2022 at 12:04 PM Marton Balint wrote: Share the sample please. If the patch I proposed does not fix it, I am not sure what is the best approach here. Sure, I will send you the URL to the file so that you can try it. Ok, thanks, I

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-05 Thread Marton Balint
On Sun, 4 Dec 2022, Chris Ribble wrote: More strict enforcement of sample size was introduced to avoid DOS/Timeout with crafted (fuzzed) files and disallow emitting zero sized packets. Invalid file support is not something that is always worth doing, there are other, more important factors,

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-04 Thread Marton Balint
On Fri, 2 Dec 2022, Gyan Doshi wrote: On 2022-12-02 06:16 am, Chris Ribble wrote: On Thu, Dec 1, 2022 at 4:51 PM Marton Balint wrote: Can you explain why those files are considered valid, or why it makes sense to generate such files? Thanks, Marton As far as I can tell

[FFmpeg-devel] [PATCH 2/2] avformat/mov: re-allow zero sample sizes if that is not the default

2022-12-04 Thread Marton Balint
and not from the trun box. This approach fixes the original timeout issue from fuzzed files differently. Signed-off-by: Marton Balint --- libavformat/mov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 935b2f8d9f..9d3a2ab830

[FFmpeg-devel] [PATCH 1/2] avformat/mov: do not emit zero sized packets

2022-12-04 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 29bd3103e3..935b2f8d9f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8772,6 +8772,10 @@ static int mov_read_packet(AVFormatContext

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-01 Thread Marton Balint
On Thu, 1 Dec 2022, Chris Ribble wrote: This reverts commit 03d81a044ad587ea83567f75dc36bc3d64278199. This change broke the ability to read mp4 files which contain a trun atom with a sample of size zero (FFmpeg exits while parsing the moof). Can you explain why those files are considered

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Always output a minimum of 32 packets.

2022-11-28 Thread Marton Balint
On Mon, 28 Nov 2022, James Almer wrote: From: Thierry Foucu Otherwise, if you just output a PAT/PMT and a single TS packets, the demuxer will not be able to detect TS. This looks like a demuxer bug, which should be fixed in the demuxer, and not in the muxer. Regards, Marton

Re: [FFmpeg-devel] [PATCH 3/3] avformat/electronicarts: add option to return alpha channel in the main video stream in VP6A codec

2022-11-22 Thread Marton Balint
On Thu, 17 Nov 2022, Peter Ross wrote: On Mon, Nov 14, 2022 at 11:05:44PM +0100, Marton Balint wrote: On Mon, 14 Nov 2022, Anton Khirnov wrote: Quoting Marton Balint (2022-11-13 19:44:41) Signed-off-by: Marton Balint --- doc/demuxers.texi| 18 libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/electronicarts: add option to return alpha channel in the main video stream in VP6A codec

2022-11-14 Thread Marton Balint
On Mon, 14 Nov 2022, Anton Khirnov wrote: Quoting Marton Balint (2022-11-13 19:44:41) Signed-off-by: Marton Balint --- doc/demuxers.texi| 18 libavformat/electronicarts.c | 42 +++- libavformat/version.h| 2 +- 3 files

[FFmpeg-devel] [PATCH 3/3] avformat/electronicarts: add option to return alpha channel in the main video stream in VP6A codec

2022-11-13 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/demuxers.texi| 18 libavformat/electronicarts.c | 42 +++- libavformat/version.h| 2 +- 3 files changed, 56 insertions(+), 6 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi

[FFmpeg-devel] [PATCH 2/3] avformat/electronicarts: set packet_read in one place

2022-11-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/electronicarts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index 0a0d6249e8..0532264f38 100644 --- a/libavformat/electronicarts.c +++ b/libavformat

[FFmpeg-devel] [PATCH 1/3] avformat/electronicarts: fix EOF check

2022-11-13 Thread Marton Balint
Similar to feof(), avio_feof() is only true after an actual overread. Signed-off-by: Marton Balint --- libavformat/electronicarts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index e7f0cb9b9e..0a0d6249e8 100644

Re: [FFmpeg-devel] [PATCH 1/3] lavc/encode: make sure frame timebase matches encoder, when set

2022-10-05 Thread Marton Balint
On Tue, 4 Oct 2022, Anton Khirnov wrote: Quoting Marton Balint (2022-09-28 21:54:11) On Wed, 28 Sep 2022, Anton Khirnov wrote: AVFrame.time_base has been added recently, but is currently not used for anything. Prepare for its use in encoders by rejecting frames where time_base is set

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegtsenc: add omit_rai flag

2022-10-02 Thread Marton Balint
On Fri, 30 Sep 2022, Zhao Zhili wrote: From: Zhao Zhili Add PCR at keyframe can be undesirable when -pcr_period is specified. Add an flag to disable this behavior. Signed-off-by: Zhao Zhili --- v2: change pcr_at_keyframe to omit_rai LGTM with libavformat micro version bump, thanks.

Re: [FFmpeg-devel] [PATCH 1/3] lavc/encode: make sure frame timebase matches encoder, when set

2022-09-28 Thread Marton Balint
On Wed, 28 Sep 2022, Anton Khirnov wrote: AVFrame.time_base has been added recently, but is currently not used for anything. Prepare for its use in encoders by rejecting frames where time_base is set, but differs from the AVCodecContext one. How is that not an API break? Users can encode

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add pcr_at_keyframe flag

2022-09-28 Thread Marton Balint
On Wed, 28 Sep 2022, Zhao Zhili wrote: From: Zhao Zhili Add PCR at keyframe can be undesirable when -pcr_period is specified. Add an flag to disable this behavior. Actually you are disabling the writing of random access indicators, not only PCRs. PCR's are just there because it is

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Marton Balint
On Wed, 21 Sep 2022, Tomas Härdin wrote: ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer: On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > sön 2022-09-18 klockan 19:13 +0200 skrev Michael Niedermayer: > >

Re: [FFmpeg-devel] [PATCH] fftools: allow decoders to set AVFrame time_base

2022-09-15 Thread Marton Balint
On Sat, 10 Sep 2022, Leo Izen wrote: This patch allows decoders to set AVFrame->time_base, which determines the units that AVFrame->pts will use. Currently no decoders do this, but it will allow it in the future. This is patch is wrong, because it implies that decoders can output frames

Re: [FFmpeg-devel] [PATCH 18/18] lavf/dv: do not continuously set stream timebase

2022-08-25 Thread Marton Balint
On Wed, 24 Aug 2022, Anton Khirnov wrote: The code will call avpriv_set_pts_info() for each video frame, possibly setting a different timebase if the stream framerate changes. This violates API conventions, as the timebase is supposed to stay constant after stream creation. Change the

Re: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-17 Thread Marton Balint
On Wed, 17 Aug 2022, Gyan Doshi wrote: On 2022-08-17 04:36 am, Stefano Sabatini wrote: On date Tuesday 2022-08-16 00:04:10 +0530, Gyan Doshi wrote: c11fb46731 led to a regression whereby the return code for missing input or input probe is overridden by writer close return code and

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Marton Balint
On Mon, 15 Aug 2022, Thilo Borgmann wrote: diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 18e768b386..22ba654bb0 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -131,6 +131,22 @@ int64_t parse_time_or_die(const char *context, const char *timestr, return us; }

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Marton Balint
On Wed, 27 Jul 2022, Hendrik Leppkes wrote: On Wed, Jul 27, 2022 at 4:03 PM Julien Vary wrote: Replaced all abort() by av_abort() in the code. On production systems, when dealing with malformed data, avcodec was sometime aborting, with no core/memory dump available to troubleshoot

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: fix return value of avdevice_list_devices()

2022-07-17 Thread Marton Balint
On Sun, 10 Jul 2022, Marton Balint wrote: According to API docs avdevice_list_devices(), avdevice_list_input_sources() and avdevice_list_input_sinks() should return the number of autodetected devices on success. This is redundant with AVDeviceInfoList->nb_devices so it was not noti

Re: [FFmpeg-devel] [PATCH] avformat/mov: h264 cenc entryption file decryption_key failed

2022-07-12 Thread Marton Balint
On Sat, 9 Jul 2022, Marton Balint wrote: On Sat, 9 Jul 2022, lishuangxi wrote: Please help review it, thanks. You should describe why the old logic of encrypting in 16 byte chunks is uneeded in the commit message. Applied with fixed commit message. Thanks, Marton Code

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_zscale: remove some unneeded initializations

2022-07-10 Thread Marton Balint
On Fri, 8 Jul 2022, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 44cb4b9c61..6861eef278 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter

[FFmpeg-devel] [PATCH] avdevice/avdevice: fix return value of avdevice_list_devices()

2022-07-10 Thread Marton Balint
ist functions work like that. Let's fix it in generic code to make it in line with the API docs. Fixes ticket #9820. Signed-off-by: Marton Balint --- libavdevice/avdevice.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavdevice/avdevice.c b/libavdevice/avdevice.c in

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/amfenc: Add missing profiles

2022-07-10 Thread Marton Balint
On Thu, 13 Jan 2022, Michael Fabian 'Xaymar' Dirks wrote: From: Michael Fabian 'Xaymar' Dirks Adds the missing profiles to the '-help encoder=xxx_amf' list, even if the user may never need these. --- libavcodec/amfenc_h264.c | 11 ++- libavcodec/amfenc_hevc.c | 1 + 2 files changed,

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/amfenc: Set all color metadata for AMF

2022-07-10 Thread Marton Balint
On Thu, 13 Jan 2022, Michael Fabian 'Xaymar' Dirks wrote: From: Michael Fabian 'Xaymar' Dirks Fixes the color information in the output from the AMD encoder being wrong, which led to weird transcoding results. This problem appeared out of thin air, and I've been unable to tie it to a

Re: [FFmpeg-devel] [PATCH] SDL2 verison for pkg_config fallback

2022-07-09 Thread Marton Balint
On Sun, 19 Jun 2022, Martin Storsjö wrote: On Mon, 20 Jun 2022, dvhh wrote: On Sun, 19 Jun 2022 17:46:58 +0200 Timo Rothenpieler wrote: On 17.06.2022 18:46, dvhh wrote: pkg_config fallback for SDL2 use 2.1.0 as max (excluded) version where the pkg_config specify 3.0.0 Correcting

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-09 Thread Marton Balint
On Mon, 4 Jul 2022, Wenbin Chen wrote: For 422 frames we should not use hard coded 8 to calculate mb size for uv plane. Chroma shift should be taken into consideration to be compatiple with different sampling format. The error is reported by fate test when av_cpu_max_align() return 64 on

Re: [FFmpeg-devel] [PATCH] avformat/mov: h264 cenc entryption file decryption_key failed

2022-07-09 Thread Marton Balint
On Sat, 9 Jul 2022, lishuangxi wrote: Please help review it, thanks. You should describe why the old logic of encrypting in 16 byte chunks is uneeded in the commit message. Code process -- Fixes ticket #9807. -- Fixes ticket #9777. The file in linked

Re: [FFmpeg-devel] [PATCH] avformat/isom: support 16:9 DV in QuickTime

2022-07-09 Thread Marton Balint
On Fri, 1 Jul 2022, Brion Vibber wrote: Attached patch adds input support for 16:9 DV video in QuickTime. I found some old files produced by Adobe Premiere and Radius SoftDV which were affected by this: 4:3 files were marked as type 'dvc ' which already worked; 16:9 files as 'dvl ' which

Re: [FFmpeg-devel] [PATCH] ffprobe: report the corrupt flag on packets

2022-07-09 Thread Marton Balint
On Sun, 19 Jun 2022, rcombs wrote: --- fftools/ffprobe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4e2fdbaec8..22a754ae44 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2491,8 +2491,9 @@ static void

Re: [FFmpeg-devel] FFmpeg 5.1

2022-07-07 Thread Marton Balint
On Sun, 19 Jun 2022, Neal Gompa wrote: On Sun, Jun 19, 2022 at 4:59 PM Marton Balint wrote: On Thu, 9 Jun 2022, Neal Gompa wrote: > On Tue, Jun 7, 2022 at 7:35 AM Michael Niedermayer > wrote: >> >> Hi all >> >> As was discussed previously the 5.1

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_zscake: enable AVX512 zscale functions

2022-07-07 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 8e50457c6b..91166dcbcb 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -837,7 +837,7

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_zscale: simplify and fix slice_params calculations

2022-07-07 Thread Marton Balint
Do not insist on a fixed slice height, because that can still cause overflows in corner cases as described in this comment: https://github.com/sekrit-twc/zimg/issues/177#issuecomment-1157734233 Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 18 -- 1 file changed, 4

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_zscale: remove some unneeded initializations

2022-07-07 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 44cb4b9c61..6861eef278 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -149,12 +149,6 @@ static av_cold

Re: [FFmpeg-devel] [PATCH 2/2] avformat/img2enc: use unmatched filename for an invalid or missing sequence pattern

2022-07-07 Thread Marton Balint
On Mon, 20 Jun 2022, Marton Balint wrote: On Mon, 13 Jun 2022, Marton Balint wrote: Also warn the user that for single images -update should be used, for sequences a proper pattern should be specified. Fixes ticket #9748. Ping for this. Note that this patch will show a warning

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: disallow a zero sample size in trun atoms

2022-07-06 Thread Marton Balint
On Tue, 28 Jun 2022, "zhilizhao(赵志立)" wrote: On Jun 28, 2022, at 4:02 AM, Marton Balint wrote: In order to not generate 0 sized packets or create a huge index table needlessly. Fixes: Timeout Fixes: 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-520600828733

[FFmpeg-devel] [PATCH 3/3] avformat/mov: disallow a zero sample size in trun atoms

2022-06-27 Thread Marton Balint
In order to not generate 0 sized packets or create a huge index table needlessly. Fixes: Timeout Fixes: 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5206008287330304 Fixes: 45738/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6142535657979904 Signed-off-by: Marton

[FFmpeg-devel] [PATCH 2/3] Revert "avformat/demux: Make read_frame_internal() return AVERREOR(EAGAIN) on stuck empty input parser"

2022-06-27 Thread Marton Balint
Hides the underlying real problem with a demuxer returning 0 sized packets. This reverts commit 02699490c14e86105104940c009953081f69432c. --- libavformat/demux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index 57720f4311..1620716716 100644

[FFmpeg-devel] [PATCH 1/3] Revert "avformat/demux: Count EAGAIN as 100 bytes in relation to read limit in avformat_find_stream_info()"

2022-06-27 Thread Marton Balint
Modifying avformat_find_stream_info() behaviour based on the number of EAGAINs it encounters is a hack which usually only hides the real issue if such thing happen. This reverts commit b0cac7082d8a3ff2d4f039af01b45c48bb578de7. --- libavformat/demux.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: change frame counters to 64 bit

2022-06-27 Thread Marton Balint
On Mon, 20 Jun 2022, Marton Balint wrote: Frame counters can overflow relatively easily (INT_MAX number of frames is slightly more than 1 year for 60 fps content), so make sure we are always using 64 bit values for them. A live stream can easily run for more than a year and the framedup

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: read PCM audio configuration box ('pcmC') if available

2022-06-27 Thread Marton Balint
On Sun, 19 Jun 2022, Marton Balint wrote: From: Ivan Baykalov <4ru...@gmail.com> For ipcm and fpcm streams, big-endian format is the default, but it can be changed with additional 'pcmC' sub-atom of audio sample description. Details can be found in ISO/IEC 23003-5:2020 Fixes ticket

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: report avio errors

2022-06-20 Thread Marton Balint
On Mon, 13 Jun 2022, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffprobe.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Will apply. Regards, Marton diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4e2fdbaec8..5020ba484c 100644

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: remove obsolate hacks for detecting streams with bad PMTs

2022-06-20 Thread Marton Balint
On Wed, 15 Jun 2022, Marton Balint wrote: Ffmpeg/ffprobe/ffplay sets scan_all_pmts to 1 when finding the streams, that should be enough to handle files for which some early PMTs miss some streams. Fixes ticket #9782. Will apply. Regards, Marton Signed-off-by: Marton Balint

Re: [FFmpeg-devel] [PATCH 2/2] avformat/img2enc: use unmatched filename for an invalid or missing sequence pattern

2022-06-20 Thread Marton Balint
On Mon, 13 Jun 2022, Marton Balint wrote: Also warn the user that for single images -update should be used, for sequences a proper pattern should be specified. Fixes ticket #9748. Ping for this. Note that this patch will show a warning for any non-sequence image filename (unless

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/v210dec: properly support odd widths

2022-06-20 Thread Marton Balint
On Sun, 12 Jun 2022, Marton Balint wrote: Fixes ticket #5195. Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 49 +--- 1 file changed, 33 insertions(+), 16 deletions(-) Will apply the series. Regards, Marton diff --git a/libavcodec

[FFmpeg-devel] [PATCH] fftools/ffmpeg: change frame counters to 64 bit

2022-06-20 Thread Marton Balint
Frame counters can overflow relatively easily (INT_MAX number of frames is slightly more than 1 year for 60 fps content), so make sure we are always using 64 bit values for them. A live stream can easily run for more than a year and the framedup logic breaks on an overflow. Signed-off-by: Marton

[FFmpeg-devel] [PATCH 2/2] avformat/mov: read PCM audio configuration box ('pcmC') if available

2022-06-19 Thread Marton Balint
lified by Marton Balint. Signed-off-by: Marton Balint --- libavformat/mov.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 0660a51492..c6fbe511c0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1553,6 +1553,9 @@ stati

[FFmpeg-devel] [PATCH 1/2] avformat/mov: factorize setting little endian PCM streams

2022-06-19 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mov.c | 51 +-- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3ec0ea2361..0660a51492 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] avformat/mov: read PCM audio configuration box ('pcmC') if available

2022-06-19 Thread Marton Balint
On Tue, 7 Jun 2022, Ivan Baykalov wrote: For ipcm and fpcm streams, big-endian format is the default, but it can be changed with additional 'pcmC' sub-atom of audio sample description. Details can be found in ISO/IEC 23003-5:2020 Fixes ticket #9763 Fixes ticket #9790 Thanks for this, I

Re: [FFmpeg-devel] FFmpeg 5.1

2022-06-19 Thread Marton Balint
On Thu, 9 Jun 2022, Neal Gompa wrote: On Tue, Jun 7, 2022 at 7:35 AM Michael Niedermayer wrote: Hi all As was discussed previously the 5.1 release should be in june/july That means in the next weeks probably! If you know of any regressions, security issues or other major bugs, please

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-06-19 Thread Marton Balint
On Sun, 12 Jun 2022, Steven Hartland wrote: Remove return after copying extradata as this prevents metadata being duplicated correctly. The return there originated from commit b24d6c5303720fbd59cbd25c392229450660 and seems very much intentional to not overwrite stream parameters

Re: [FFmpeg-devel] [PATCH] oss: account for sample size when computing timestamp

2022-06-19 Thread Marton Balint
On Wed, 15 Jun 2022, Matt Jacobson wrote: Hi, On Jun 1, 2022, at 5:06 AM, Matt Jacobson wrote: Don't assume each sample is one byte in size. Doing so results in wrong and occasionally non-monotonically-increasing timestamps. Fix nearby cosmetic typo. Friendly ping on this patch.

<    1   2   3   4   5   6   7   8   9   10   >