[FFmpeg-devel] [PATCH 3/4] avfilter/vf_zscale: properly check return value of slice threads

2022-03-14 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index bab87b0c94..ceefc95224 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -117,6

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_zscale: fix number of threads

2022-03-14 Thread Marton Balint
Make sure it is between [1, MAX_THERADS] and also take into account the outlink size in order not to request zero height output from zscale. Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_zscale.c b

[FFmpeg-devel] [PATCH 1/4] avfilter/x86/vf_blend: use unaligned movs for output

2022-03-14 Thread Marton Balint
Fixes crashes with: ffmpeg -f lavfi -i allyuv=d=1 -vf tblend=difference128,pad=5000:ih:1 -f null x Signed-off-by: Marton Balint --- libavfilter/x86/vf_blend.asm | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavfilter/x86/vf_blend.asm b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: do not write index tables with the same InstanceUID

2022-03-14 Thread Marton Balint
On Mon, 14 Mar 2022, Tomas Härdin wrote: mån 2022-03-14 klockan 20:54 +0100 skrev Marton Balint: On Mon, 14 Mar 2022, Tomas Härdin wrote: > mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint: > > Only index tables repeating previous index tables should use the > > same

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: allow more bits for variable part in uuid generation

2022-03-14 Thread Marton Balint
On Mon, 14 Mar 2022, Tomas Härdin wrote: mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint: Also make sure we do not change the product UID. Signed-off-by: Marton Balint ---  libavformat/mxfenc.c    | 9 +  tests/ref/fate/copy-trac4914    | 2 +-  tests

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: do not write index tables with the same InstanceUID

2022-03-14 Thread Marton Balint
On Mon, 14 Mar 2022, Tomas Härdin wrote: mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint: Only index tables repeating previous index tables should use the same InstaceUID. Use the index start position when generating the InstanceUID to fix this. Signed-off-by: Marton Balint

[FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: do not write index tables with the same InstanceUID

2022-03-14 Thread Marton Balint
Only index tables repeating previous index tables should use the same InstaceUID. Use the index start position when generating the InstanceUID to fix this. Signed-off-by: Marton Balint --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: allow more bits for variable part in uuid generation

2022-03-14 Thread Marton Balint
Also make sure we do not change the product UID. Signed-off-by: Marton Balint --- libavformat/mxfenc.c| 9 + tests/ref/fate/copy-trac4914| 2 +- tests/ref/fate/mxf-d10-user-comments| 6 +++--- tests/ref/fate/mxf-opatom-user-comments | 2 +- tests/ref

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Check for avio_read() failure in mxf_read_strong_ref_array()

2022-03-14 Thread Marton Balint
On Mon, 14 Mar 2022, Michael Niedermayer wrote: On Sun, Mar 13, 2022 at 04:52:25PM +0100, Marton Balint wrote: On Sun, 13 Mar 2022, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfdec: Do not clear array in mxf_read_strong_ref_array() before writing

2022-03-13 Thread Marton Balint
On Sun, 13 Mar 2022, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 828fc0f9f1..f088712494 100644 --- a/libavformat/mxfdec.c +++

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Check for avio_read() failure in mxf_read_strong_ref_array()

2022-03-13 Thread Marton Balint
On Sun, 13 Mar 2022, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index d7cdd22c8a..828fc0f9f1 100644 --- a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: fix muxing pcm-bluray

2022-02-27 Thread Marton Balint
On Sun, 27 Feb 2022, Paul B Mahol wrote: On Sun, Feb 27, 2022 at 6:47 PM Marton Balint wrote: On Sat, 26 Feb 2022, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: fix muxing pcm-bluray

2022-02-27 Thread Marton Balint
On Sat, 26 Feb 2022, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 971b3f55d8..48cd54c770 100644 --- a/libavformat/mpegtsenc.c +++

Re: [FFmpeg-devel] Playback issue on Sony TVs caused by btrt box

2022-02-21 Thread Marton Balint
On Mon, 21 Feb 2022, Eran Kornblau wrote: On Mon, Feb 21, 2022 at 5:07 PM Eran Kornblau wrote: Hi all, We've recently upgraded our ffmpeg version, and we got a playback issue on some Sony TV models that are playing HBBTV/DASH+DRM - video plays fine, audio doesn't play at all. Listing

Re: [FFmpeg-devel] [PATCH v3 5/5] fftools: Enable long path support on Windows (fixes #8885)

2022-02-17 Thread Marton Balint
On Wed, 16 Feb 2022, nihil-admirari wrote: --- fftools/Makefile | 5 + fftools/long_paths_utf8.manifest | 12 fftools/long_paths_utf8.rc | 3 +++ 3 files changed, 20 insertions(+) create mode 100644 fftools/long_paths_utf8.manifest create mode 100644

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/udp: Fix IP_MULTICAST_TTL for BSD compatibility

2022-02-11 Thread Marton Balint
On Sat, 5 Feb 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Suggested by zhilizhao, vlc project has solved the compatibility by the same way, so I borrowed the comments from vlc project. Fix #ticket9449 Signed-off-by: Limin Wang --- libavformat/udp.c | 15 +-- 1 file

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: initialize max_packet_size when sub-demuxer

2022-02-06 Thread Marton Balint
On Sat, 5 Feb 2022, Gyan Doshi wrote: bca30570d2 added a user option to set max_packet_size replacing a hardcoded value. This had a side-effect of leaving the field set to 0 when packet demuxing is carried out from another demuxer using avpriv functions, which could lead to demux failure.

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: Fix IP_MULTICAST_TTL for BSD compatibility

2022-02-06 Thread Marton Balint
On Sun, 6 Feb 2022, lance.lmw...@gmail.com wrote: On Sat, Feb 05, 2022 at 01:26:18PM -0800, Chad Fraleigh wrote: Since any [valid] value over 255 is impossible in the IPv4 protocol (the TTL field is only 8-bits), it should always be capped at 255 (for consistency) or return an invalid

Re: [FFmpeg-devel] [PATCH 1/2] lavf/udp: set ttl upper bound to 255

2022-02-06 Thread Marton Balint
On Thu, 27 Jan 2022, myp...@gmail.com wrote: On Thu, Jan 27, 2022 at 1:09 PM "zhilizhao(赵志立)" wrote: > On Jan 27, 2022, at 12:22 AM, Zhao Zhili wrote: > > --- > libavformat/udp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/udp.c

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: Fix IP_MULTICAST_TTL for BSD compatibility

2022-02-05 Thread Marton Balint
On Sat, 5 Feb 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Suggested by zhilizhao, vlc project has solved the compatibility by the same way, so I borrowed the comments from vlc project. Fix #ticket9449 Signed-off-by: Limin Wang --- libavformat/udp.c | 15 +-- 1 file

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/udp: use one setsockopt for ipv4/ipv6

2022-02-05 Thread Marton Balint
On Sat, 5 Feb 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 83c042d..3dc79eb 100644 ---

[FFmpeg-devel] [PATCH] avformat/imf_cpl: do not use filesize when reading XML file

2022-01-31 Thread Marton Balint
Similar to the earlier patch applied to imfdec. Signed-off-by: Marton Balint --- libavformat/imf_cpl.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c index f2ad9c05d6..102a6b4549 100644 --- a/libavformat/imf_cpl.c

Re: [FFmpeg-devel] [PATCH] libRIST: allow setting fifo size and fail on overflow.

2022-01-31 Thread Marton Balint
On Tue, 11 Jan 2022, Gijs Peskens wrote: Introduce fifo_size and overrun_nonfatal params to configure fifo buffer behavior. Use newly introduced RIST_DATA_FLAGS_OVERFLOW flag to check for overrun and error out in that case. --- doc/protocols.texi| 9 + libavformat/librist.c | 37

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

2022-01-26 Thread Marton Balint
On Wed, 26 Jan 2022, Brad Smith wrote: On Wed, Jan 12, 2022 at 12:13:14AM -0500, Brad Smith wrote: Fix setsockopt() usage on OpenBSD with IP_MULTICAST_TTL. The field type should be an unsigned char on anything but Linux. Based on feedback so far. Here is a much simpler approach to this

Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API

2022-01-24 Thread Marton Balint
On Mon, 24 Jan 2022, James Almer wrote: From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just

Re: [FFmpeg-devel] [PATCH 001/293 v7] Add a new channel layout API

2022-01-23 Thread Marton Balint
On Thu, 20 Jan 2022, James Almer wrote: From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

2022-01-23 Thread Marton Balint
On Sun, 23 Jan 2022, Michael Niedermayer wrote: On Wed, Jan 12, 2022 at 12:13:13AM -0500, Brad Smith wrote: Fix setsockopt() usage on OpenBSD with IP_MULTICAST_TTL. The field type should be an unsigned char on anything but Linux. diff --git a/libavformat/udp.c b/libavformat/udp.c index

Re: [FFmpeg-devel] [PATCH 001/289 v6] Add a new channel layout API

2022-01-19 Thread Marton Balint
On Tue, 18 Jan 2022, James Almer wrote: From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just

Re: [FFmpeg-devel] [RFC] Next release and regressions

2022-01-17 Thread Marton Balint
On Mon, 17 Jan 2022, Michael Niedermayer wrote: Hi Trac lists 162 non closed bugs with keyword regression https://trac.ffmpeg.org/query?status=new=open=reopened=~regression Our next major release maybe will be next december I suggest we try to reduce the number of regression bugs, and

Re: [FFmpeg-devel] [PATCH 001/289 v4] Add a new channel layout API

2022-01-17 Thread Marton Balint
On Mon, 17 Jan 2022, James Almer wrote: [...] -static const char *get_channel_name(int channel_id) +static const char *get_channel_name(enum AVChannel channel_id) { -if (channel_id < 0 || channel_id >= FF_ARRAY_ELEMS(channel_names)) +if ((unsigned) channel_id >=

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Marton Balint
On Mon, 17 Jan 2022, James Almer wrote: You're still thinking there's a distinction, when i already told you that there is none. I added the name field because people wanted to give non standard channel names, and maybe also change the standard ones too. It's not a label to go alongside

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-16 Thread Marton Balint
On Sun, 16 Jan 2022, Nicolas George wrote: James Almer (12022-01-12): From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate

[FFmpeg-devel] AVFrame data alignment issues

2022-01-15 Thread Marton Balint
Hi, I wonder if there are strict requirements for alignment of AVFrame buffers. Yes, it is usually aligned by default, but there are filters, like crop or pad which tries to avoid copying data even at the cost of breaking the alignment. This unfortunately causes crashes for code which

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegts: add option max_packet_size

2022-01-15 Thread Marton Balint
On Sat, 15 Jan 2022, Gyan Doshi wrote: Plan to push tomorrow. On 2022-01-12 08:57 pm, Gyan Doshi wrote: Makes maximum size of emitted packet user-tunable. --- doc/demuxers.texi| 4 libavformat/mpegts.c | 9 ++--- 2 files changed, 10 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] avformat/imfdec: do not use filesize when reading XML file

2022-01-10 Thread Marton Balint
On Sun, 9 Jan 2022, Pierre-Anthony Lemieux wrote: On Sat, Jan 8, 2022 at 10:49 AM Marton Balint wrote: On Sat, 1 Jan 2022, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/imfdec.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avformat/imfdec: do not use filesize when reading XML file

2022-01-08 Thread Marton Balint
On Sat, 1 Jan 2022, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/imfdec.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index f17064cfcd..ef1e7cf206 100644 --- a/libavformat/imfdec.c +++ b

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: support MCA audio information

2022-01-08 Thread Marton Balint
On Sun, 2 Jan 2022, Marton Balint wrote: On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote: On Sat, Jan 1, 2022 at 5:11 PM Marton Balint wrote: On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote: Minor suggestion below. In addition, will sample file(s) be added to FATE? Below

Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define

2022-01-07 Thread Marton Balint
On Fri, 7 Jan 2022, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Friday, January 7, 2022 8:57 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images

Re: [FFmpeg-devel] [PATCH 13/14] configure: Let decklink indev suggest libzvbi

2022-01-07 Thread Marton Balint
On Thu, 6 Jan 2022, Andreas Rheinhardt wrote: Fixes build errors if libzvbi is enabled while libzvbi_teletextdec is disabled. Signed-off-by: Andreas Rheinhardt --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 1225faf15a..11342d5cec 100755 ---

Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define

2022-01-07 Thread Marton Balint
On Fri, 7 Jan 2022, ffmpegagent wrote: It's annoying and unexpected, but still useful at times (as I've realized just recently). This is a follow-up to the earlier submission here: https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html There has been a comment from Anton,

Re: [FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: set AVIOContext->error on bprint buffer ENOMEM

2022-01-03 Thread Marton Balint
On Mon, 3 Jan 2022, Andreas Rheinhardt wrote: Marton Balint: On Fri, 31 Dec 2021, Marton Balint wrote: On Fri, 31 Dec 2021, Andreas Rheinhardt wrote:  Marton Balint:  This makes sure the error condition is kept in AVIOContext even if the  user  does not check the return value

Re: [FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: set AVIOContext->error on bprint buffer ENOMEM

2022-01-02 Thread Marton Balint
On Fri, 31 Dec 2021, Marton Balint wrote: On Fri, 31 Dec 2021, Andreas Rheinhardt wrote: Marton Balint: This makes sure the error condition is kept in AVIOContext even if the user does not check the return value of avio_read_to_bprint or ff_read_line_to_bprint. Signed-off

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: support MCA audio information

2022-01-02 Thread Marton Balint
On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote: On Sat, Jan 1, 2022 at 5:35 PM Andreas Rheinhardt wrote: Pierre-Anthony Lemieux: Minor suggestion below. In addition, will sample file(s) be added to FATE? Below are two examples:

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: support MCA audio information

2022-01-02 Thread Marton Balint
On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote: On Sat, Jan 1, 2022 at 5:11 PM Marton Balint wrote: On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote: Minor suggestion below. In addition, will sample file(s) be added to FATE? Below are two examples: http://ffmpeg-imf-samples

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: support MCA audio information

2022-01-01 Thread Marton Balint
On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote: Minor suggestion below. In addition, will sample file(s) be added to FATE? Below are two examples: http://ffmpeg-imf-samples-public.s3.us-west-1.amazonaws.com/callout_51_l_r_c_lfe_ls_rs.mxf

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2022-01-01 Thread Marton Balint
On Wed, 22 Dec 2021, Pierre-Anthony Lemieux wrote: On Wed, Dec 22, 2021 at 4:38 AM Tomas Härdin wrote: tis 2021-12-21 klockan 21:24 +0100 skrev Marton Balint: > > > It is not matter of performance, we should not introduce a hack such > as > reordering PCM channe

[FFmpeg-devel] [PATCH] avformat/mxfdec: support MCA audio information

2022-01-01 Thread Marton Balint
From: Marc-Antoine Arnaud Channel reordering is removed from this patch because the new channel layout API will support it properly. Signed-off-by: Marton Balint --- libavformat/mxf.h| 3 + libavformat/mxfdec.c | 286 ++- 2 files changed, 283

[FFmpeg-devel] [PATCH 2/2] avformat/dashdec: do not use filesize when reading XML file

2022-01-01 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/dashdec.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 797fe74157..0d21989e42 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -30,8

[FFmpeg-devel] [PATCH 1/2] avformat/imfdec: do not use filesize when reading XML file

2022-01-01 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/imfdec.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index f17064cfcd..ef1e7cf206 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -73,8 +73,6

Re: [FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: set AVIOContext->error on bprint buffer ENOMEM

2021-12-31 Thread Marton Balint
On Fri, 31 Dec 2021, Andreas Rheinhardt wrote: Marton Balint: This makes sure the error condition is kept in AVIOContext even if the user does not check the return value of avio_read_to_bprint or ff_read_line_to_bprint. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 8

[FFmpeg-devel] [PATCH 5/5] avformat/utils: propagate return value of ff_format_io_close in ff_format_shift_data

2021-12-26 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index a78797ef57..23e81bda9d 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2085,7 +2085,7 @@ int

[FFmpeg-devel] [PATCH 4/5] avformat/segafilmenc: use ff_format_shift_data for shifting

2021-12-26 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/segafilmenc.c | 51 --- 1 file changed, 5 insertions(+), 46 deletions(-) diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c index ff8cb66aca..737805faa6 100644 --- a/libavformat/segafilmenc.c +++ b

[FFmpeg-devel] [PATCH 3/5] avformat/flvenc: use ff_format_shift_data for data shifting

2021-12-26 Thread Marton Balint
add_keyframe_index seems to generate a corrupted index even before this change. Signed-off-by: Marton Balint --- libavformat/flvenc.c | 59 +--- 1 file changed, 6 insertions(+), 53 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c

[FFmpeg-devel] [PATCH 2/5] avformat/movenc: factorize data shifting

2021-12-26 Thread Marton Balint
And move data shift function from movenc to utils. Signed-off-by: Marton Balint --- libavformat/internal.h | 7 ++ libavformat/movenc.c | 55 ++--- libavformat/utils.c| 56 ++ 3 files changed, 65 insertions

[FFmpeg-devel] [PATCH 1/5] avformat/aviobuf: set AVIOContext->error on bprint buffer ENOMEM

2021-12-26 Thread Marton Balint
This makes sure the error condition is kept in AVIOContext even if the user does not check the return value of avio_read_to_bprint or ff_read_line_to_bprint. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: fix DNxHD GC container_ul

2021-12-26 Thread Marton Balint
On Thu, 16 Dec 2021, Tomas Härdin wrote: tis 2021-12-14 klockan 16:27 +0100 skrev Nicolas Gaullier: Signed-off-by: Nicolas Gaullier ---  libavformat/mxfenc.c  | 2 +-  tests/ref/lavf/mxf_opatom | 2 +-  2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfenc.c

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: add use_hoov option

2021-12-25 Thread Marton Balint
On Sat, 25 Dec 2021, Zhao Zhili wrote: Fix #8883. --- doc/demuxers.texi | 6 ++ libavformat/isom.h | 1 + libavformat/mov.c | 9 +++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index cab8a7072c..276b536ac5 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2021-12-21 Thread Marton Balint
On Tue, 21 Dec 2021, Tomas Härdin wrote: tis 2021-12-21 klockan 11:44 +0100 skrev Marc-Antoine ARNAUD: Le ven. 17 déc. 2021 à 19:12, Marton Balint a écrit : > > > On Fri, 17 Dec 2021, Marc-Antoine ARNAUD wrote: > > > Hi all, > > > > Can I have an u

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-19 Thread Marton Balint
On Sat, 18 Dec 2021, Michael Niedermayer wrote: On Sat, Dec 18, 2021 at 02:36:12PM +0100, Michael Niedermayer wrote: On Fri, Dec 17, 2021 at 07:04:08PM +0100, Marton Balint wrote: On Fri, 17 Dec 2021, Michael Niedermayer wrote: On Fri, Dec 17, 2021 at 01:04:19AM +0100, Marton Balint

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-17 Thread Marton Balint
On Thu, 16 Dec 2021, James Almer wrote: On 12/16/2021 9:04 PM, Marton Balint wrote: On Thu, 16 Dec 2021, James Almer wrote: Resending the first two patches only, since this is meant to show the implementation of one of the several suggestions made in the previous set that need

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2021-12-17 Thread Marton Balint
On Fri, 17 Dec 2021, Marc-Antoine ARNAUD wrote: Hi all, Can I have an update on this patch submission ? Is something required to be done before it can be merged ? New channel layout API is on its way, which makes in-demuxer channel reordering uneeded. Therefore the reordering option

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-17 Thread Marton Balint
On Fri, 17 Dec 2021, Michael Niedermayer wrote: On Fri, Dec 17, 2021 at 01:04:19AM +0100, Marton Balint wrote: On Thu, 16 Dec 2021, James Almer wrote: Resending the first two patches only, since this is meant to show the implementation of one of the several suggestions made

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-16 Thread Marton Balint
On Thu, 16 Dec 2021, James Almer wrote: Resending the first two patches only, since this is meant to show the implementation of one of the several suggestions made in the previous set that need to be discussed and hopefully resolved in a call. Can you push the full branch somewhere? The

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread Marton Balint
On Thu, 16 Dec 2021, James Almer wrote: - Added a 16 byte fixed array to AVChannelCustom to give custom labels to channels in Custom order layouts. These labes will be used by the helpers when querying channels by name or describing the layout. I don't think this is a good idea to use

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-15 Thread Marton Balint
On Wed, 15 Dec 2021, James Almer wrote: On 12/15/2021 6:32 PM, Marton Balint wrote: On Wed, 15 Dec 2021, James Almer wrote: On 12/15/2021 7:24 AM, Marton Balint wrote:  On Tue, 14 Dec 2021, James Almer wrote:  On 12/14/2021 3:54 PM, Nicolas George wrote:   James Almer

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-15 Thread Marton Balint
On Wed, 15 Dec 2021, James Almer wrote: On 12/15/2021 7:24 AM, Marton Balint wrote: On Tue, 14 Dec 2021, James Almer wrote: On 12/14/2021 3:54 PM, Nicolas George wrote:  James Almer (12021-12-14):  We add a const uint8_t* field to AVChannelCustom. If the user wants to  allocate

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-15 Thread Marton Balint
On Tue, 14 Dec 2021, James Almer wrote: On 12/14/2021 3:54 PM, Nicolas George wrote: James Almer (12021-12-14): We add a const uint8_t* field to AVChannelCustom. If the user wants to allocate the strings instead, and not worry about their lifetime, they can provide the layout with a

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-15 Thread Marton Balint
On Wed, 15 Dec 2021, Marton Balint wrote: On Tue, 14 Dec 2021, James Almer wrote: return channel_names[channel_id].name;  }  -static const struct {  +static inline void get_channel_str(AVBPrint *bp, const char *str,  +   enum AVChannel

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-15 Thread Marton Balint
On Tue, 14 Dec 2021, James Almer wrote: return channel_names[channel_id].name;  }  -static const struct {  +static inline void get_channel_str(AVBPrint *bp, const char *str,  +   enum AVChannel channel_id)  +{  +    if (str)  +   

Re: [FFmpeg-devel] 5.0 release

2021-12-14 Thread Marton Balint
On Tue, 14 Dec 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-12-13 22:30:25) On Mon, 13 Dec 2021, Jean-Baptiste Kempf wrote: On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: If you know of any major issues which need to be done before the release do them now. If you

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Marton Balint
On Tue, 14 Dec 2021, Lynne wrote: 14 Dec 2021, 02:13 by c...@passwd.hu: On Tue, 7 Dec 2021, James Almer wrote: I would like to attach some extendable, possibly per-channel metadata to the channel layout. I'd rather put it into AVChannelLayout, so native layouts could also have

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Marton Balint
On Mon, 13 Dec 2021, James Almer wrote: On 12/13/2021 10:13 PM, Marton Balint wrote: On Tue, 7 Dec 2021, James Almer wrote: From: Anton Khirnov [...] -static const char *get_channel_name(int channel_id) +static const char *get_channel_name(enum AVChannel channel_id

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-13 Thread Marton Balint
On Tue, 7 Dec 2021, James Almer wrote: From: Anton Khirnov [...] -static const char *get_channel_name(int channel_id) +static const char *get_channel_name(enum AVChannel channel_id) { -if (channel_id < 0 || channel_id >= FF_ARRAY_ELEMS(channel_names)) -return NULL; +if

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-13 Thread Marton Balint
On Sun, 12 Dec 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-12-10 01:04:57) On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Nicolas George (2021-12-09 11:31:54) Anton Khirnov (12021-12-09): I disagree. Technical limitations that were overcome 10 years ago should not guide

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Marton Balint
On Mon, 13 Dec 2021, Jean-Baptiste Kempf wrote: On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: If you know of any major issues which need to be done before the release do them now. If you know of any issues which are release-blocking list them in a reply here please. Maybe the

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-10 Thread Marton Balint
On Sat, 4 Dec 2021, Marton Balint wrote: Otherwise there is no way to detect an error returned by avio_close() because ff_format_io_close cannot get the return value. Checking the return value of the close function is important in order to check if all data was successfully written

Re: [FFmpeg-devel] [PATCH v2 1/4] lavu/frame: Add Dolby Vision metadata side data type

2021-12-10 Thread Marton Balint
On Thu, 9 Dec 2021, Niklas Haas wrote: On Thu, 09 Dec 2021 17:21:58 + Derek Buitenhuis wrote: On 12/8/2021 10:12 AM, Niklas Haas wrote: +/* based on guesswork, see mkvtoolnix and dovi_tool */ +int av_dovi_profile(const AVDOVIRpuDataHeader *hdr) +{ The correct way to find the

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-09 Thread Marton Balint
On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Nicolas George (2021-12-09 11:31:54) Anton Khirnov (12021-12-09): I disagree. Technical limitations that were overcome 10 years ago should not guide new API design. In the case of amerge, it was not a technical limitation, merging several

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-09 Thread Marton Balint
On Fri, 10 Dec 2021, Hendrik Leppkes wrote: On Fri, Dec 10, 2021 at 12:06 AM Marton Balint wrote: On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Lynne (2021-12-08 13:57:45) 8 Dec 2021, 13:16 by an...@khirnov.net: Quoting Lynne (2021-12-08 10:02:34) 8 Dec 2021, 02:06 by jamr

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-09 Thread Marton Balint
On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Lynne (2021-12-08 13:57:45) 8 Dec 2021, 13:16 by an...@khirnov.net: Quoting Lynne (2021-12-08 10:02:34) 8 Dec 2021, 02:06 by jamr...@gmail.com: From: Anton Khirnov The new API is more extensible and allows for custom layouts. More

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-08 Thread Marton Balint
On Wed, 8 Dec 2021, Lynne wrote: 8 Dec 2021, 11:06 by c...@passwd.hu: On Wed, 8 Dec 2021, Lynne wrote: 8 Dec 2021, 10:22 by h.lepp...@gmail.com: On Wed, Dec 8, 2021 at 10:14 AM Lynne wrote: 8 Dec 2021, 02:06 by jamr...@gmail.com: +enum AVChannel { +///< Invalid channel

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-08 Thread Marton Balint
On Wed, 8 Dec 2021, Lynne wrote: 8 Dec 2021, 02:06 by jamr...@gmail.com: +enum AVChannel { +///< Invalid channel index +AV_CHAN_NONE = -1, +AV_CHAN_FRONT_LEFT, No, not the pixfmt mistake again. Set AV_CHAN_NONE to 0, the rest can follow. Or keep AV_CHAN_NONE to -1 and add a

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-08 Thread Marton Balint
On Wed, 8 Dec 2021, Lynne wrote: 8 Dec 2021, 10:22 by h.lepp...@gmail.com: On Wed, Dec 8, 2021 at 10:14 AM Lynne wrote: 8 Dec 2021, 02:06 by jamr...@gmail.com: +enum AVChannel { +///< Invalid channel index +AV_CHAN_NONE = -1, +AV_CHAN_FRONT_LEFT, No, not the pixfmt

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: fix DNxHD GC ULs

2021-12-07 Thread Marton Balint
On Wed, 8 Dec 2021, Tomas Härdin wrote: fre 2021-12-03 klockan 09:38 + skrev Nicolas Gaullier: > Please add a reference to the relevant SMPTE document in the > comment, or perhaps at the list of references at the start of the > file > > /Tomas I have added the reference to ST2019-4

Re: [FFmpeg-devel] [PATCH 3/6] avformat/rtsp: prefer to return EOF for incomplete read

2021-12-05 Thread Marton Balint
On Sun, 5 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 5cffe0b..2ee2463 100644 --- a/libavformat/rtsp.c +++

[FFmpeg-devel] [PATCH v3 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-04 Thread Marton Balint
ose callback. Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 13 + libavformat/dashenc.c | 1 + libavformat/fifo.c | 1 + libavformat/hlsenc.c | 1 + libavformat/internal.h | 10 +- libavformat/options.c |

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-04 Thread Marton Balint
On Sat, 4 Dec 2021, Hendrik Leppkes wrote: On Sat, Dec 4, 2021 at 9:00 PM Marton Balint wrote: Otherwise there is no way to detect any error during avio_close(). Returning errors is nice and all, but whats the expected reaction to an error here, since we're already trying to close

[FFmpeg-devel] [PATCH v2 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-04 Thread Marton Balint
Otherwise there is no way to detect any error during avio_close(). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 13 + libavformat/dashenc.c | 1 + libavformat/fifo.c | 1 + libavformat/hlsenc.c | 1 + libavformat/internal.h

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Marton Balint
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: On Fri, Dec 03, 2021 at 10:47:00AM +0100, Marton Balint wrote: On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Marton Balint
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I don't think this is needed, after all we want to read all data, there is no point in reading it in smaller chunks, no?

Re: [FFmpeg-devel] [PATCH 1/5] avformat/rtsp: make use of avio_get_str() to load the sdp

2021-12-01 Thread Marton Balint
On Wed, 1 Dec 2021, lance.lmw...@gmail.com wrote: On Wed, Dec 01, 2021 at 05:17:08PM +0200, Martin Storsjö wrote: On Wed, 1 Dec 2021, lance.lmw...@gmail.com wrote: > On Wed, Dec 01, 2021 at 03:55:37PM +0200, Martin Storsjö wrote: > > On Wed, 1 Dec 2021, lance.lmw...@gmail.com wrote: > > >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: rework MCA channel layout parsing

2021-11-30 Thread Marton Balint
On Mon, 29 Nov 2021, Pierre-Anthony Lemieux wrote: On Mon, Nov 29, 2021 at 11:20 AM Marton Balint wrote: On Sun, 28 Nov 2021, Pierre-Anthony Lemieux wrote: On Sun, Nov 28, 2021 at 5:00 PM Marton Balint wrote: Setting the channel layout was based on SoundfieldGroupLabelSubDescriptor

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: Add blurriness filter

2021-11-30 Thread Marton Balint
On Tue, 30 Nov 2021, Thilo Borgmann wrote: Hi, $subject Can you name this blurdetect to be more in line with existing similar filters? (blackdetect, freezedetect) Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 4/5] avformat: make AVFormatContext io_close return an int

2021-11-30 Thread Marton Balint
On Tue, 30 Nov 2021, Andreas Rheinhardt wrote: Marton Balint: Otherwise there is no way to detect any error during avio_close(). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 6 +- libavformat/internal.h | 6 +- libavformat/options.c

[FFmpeg-devel] [PATCH 5/5] avformat/img2enc: do not ignore IO errors

2021-11-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 62202de9f4..ce23f38efb 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c

[FFmpeg-devel] [PATCH 4/5] avformat: make AVFormatContext io_close return an int

2021-11-29 Thread Marton Balint
Otherwise there is no way to detect any error during avio_close(). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 6 +- libavformat/internal.h | 6 +- libavformat/options.c | 4 ++-- libavformat/utils.c| 6 -- libavformat/version.h

[FFmpeg-devel] [PATCH 3/5] fftools/ffmpeg: close output files before cleanup

2021-11-29 Thread Marton Balint
This allows us to check the return value of avio_closep(). Signed-off-by: Marton Balint --- fftools/ffmpeg.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 25360423b5..ea75fad637 100644 --- a/fftools/ffmpeg.c +++ b

[FFmpeg-devel] [PATCH 2/5] avformat/aviobuf: return stored AVIO context error on avio_close

2021-11-29 Thread Marton Balint
Otherwise IO errors at avio_flush() before closing may be lost. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 5da4dea7b6..d65c7b535d 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 1/5] avformat/file: use proper return value in file_close

2021-11-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/file.c b/libavformat/file.c index 9c23f680cd..7001750c80 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -266,7 +266,8 @@ static int64_t file_seek

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: avoid repeated failure and recovery

2021-11-29 Thread Marton Balint
On Mon, 22 Nov 2021, Ryoji Gyoda wrote: If fifo_thread_recover() succeeds immediately after fifo_thread_dispatch_message() fails, the dts of the packet is scaled twice, causing cur_dts to be abnormally large and "Application provided invalid, non monotonically increasing dts to muxer in

<    2   3   4   5   6   7   8   9   10   11   >