Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Marton Balint
On Tue, 8 Jun 2021, Valerii Zapodovnikov wrote: You are **very** wrong. This is YCbCr 101: 420 has all the same colors as 444 does. Just if one pixel is fixated the entagled pixels have less than all possible colors. This is also not corners issues, it is reproducable on one color all over

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Marton Balint
On Mon, 7 Jun 2021, Valerii Zapodovnikov wrote: I cannot clarify it further, the issue is there on trac. And that ticket is bogus, because comparison is made between 4:2:0 and 4:4:4. And when the reporter says the colors are muddy, he means the pixel format diffrerence, not the color

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Marton Balint
On Mon, 7 Jun 2021, Valerii Zapodovnikov wrote: Signed-off-by: Valerii Zapodovnikov --- fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 0be1d90bf9..53bd9362fa 100644 --- a/fftools/ffplay.c +++

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-06 Thread Marton Balint
On Sun, 6 Jun 2021, Valerii Zapodovnikov wrote: I am sorry, what? It converts to 420 always? Wow? But you are right. Yes, because ffplay uses the default SDL renderer (may it be opengl/directx or anything else), and ffplay queries the hardware acccelerated pixel formats supported by that

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-05 Thread Marton Balint
patch subject has a type (ffplay v.s. ffprobe) On Wed, 26 May 2021, Valerii Zapodovnikov wrote: --- fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 0be1d90bf9..53bd9362fa 100644 --- a/fftools/ffplay.c +++

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fixed jp2k_rsiz and 240M matrix

2021-06-05 Thread Marton Balint
On Sat, 5 Jun 2021, Marton Balint wrote: On Sat, 5 Jun 2021, Valerii Zapodovnikov wrote: -static const uint8_t mxf_jp2k_rsiz[] = { 0x06,0x0e,0x2b,0x34,0x02,0x05,0x01,0x01,0x0d,0x01,0x02,0x01,0x01,0x02,0x01,0x00 }; +static const uint8_t mxf_jp2k_rsiz

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fixed jp2k_rsiz and 240M matrix

2021-06-05 Thread Marton Balint
On Sat, 5 Jun 2021, Valerii Zapodovnikov wrote: Again. 240M matrix is different from BT.601! And 170M is the same as BT.601. It is primaries that are the same in 240M and 170M, as for jp2k_rsiz see page 10 of S422M-2006. Yes, IT IS THERE. --- libavformat/mxf.c| 2 +- libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/libsrt: add tsbpd option

2021-06-05 Thread Marton Balint
On Fri, 4 Jun 2021, Zhao Zhili wrote: From: Zhao Zhili --- v2: update doc LGTM for the set. Thanks, Marton doc/protocols.texi | 5 + libavformat/libsrt.c | 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index

Re: [FFmpeg-devel] [PATCH] Rename SRT's streamid to srt_streamid to avoid a conflict with standard streamid option

2021-06-05 Thread Marton Balint
On Thu, 3 Jun 2021, Sergey Ilinykh wrote: Default streamid is some numeric value and not used by SRT code. Instead SRT has its own string streamid. Current code has the same option name for both and this causes a conflict when ffmpeg is started from a terminal. The attached patch fixes it

Re: [FFmpeg-devel] [PATCH] ffprobe: add decode_error_flags

2021-05-27 Thread Marton Balint
On Thu, 27 May 2021, Tobias Rapp wrote: On 25.05.2021 13:27, Nicolas George wrote: Michael Niedermayer (12021-05-25): Signed-off-by: Michael Niedermayer --- doc/ffprobe.xsd| 1 + fftools/ffprobe.c | 2 + tests/ref/fate/exif-image-embedded | 22

Re: [FFmpeg-devel] [PATCH] Add nit flag support v.2

2021-05-20 Thread Marton Balint
On Tue, 18 May 2021, Ubaldo Porcheddu wrote: Signed-off-by: Ubaldo Porcheddu --- doc/muxers.texi | 7 +++- libavformat/mpegtsenc.c | 100 +--- 2 files changed, 101 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH v2] avformat/flvdec: use milisecond precision for parsing timestamps

2021-05-20 Thread Marton Balint
On Sun, 16 May 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-05-14 21:28:06) Also use helper function to set the timestamp. Maybe we could also use nanosecond precision, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 11

Re: [FFmpeg-devel] [PATCH] Add nit flag support

2021-05-17 Thread Marton Balint
On Mon, 17 May 2021, Ubaldo Porcheddu wrote: Signed-off-by: Ubaldo Porcheddu --- doc/muxers.texi | 2 ++ libavformat/mpegtsenc.c | 96 ++--- 2 files changed, 93 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH v5 3/3] avcodec/nvenc: write out user data unregistered SEI

2021-05-17 Thread Marton Balint
On Mon, 17 May 2021, Timo Rothenpieler wrote: On 17.05.2021 10:19, Brad Hards wrote: Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 64 ++ 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/libavcodec/nvenc.c

Re: [FFmpeg-devel] [PATCH 3/3] avformat/fifo: check for flushed packets and timeshift

2021-05-16 Thread Marton Balint
On Sun, 16 May 2021, Michael Niedermayer wrote: Fixes: CID1464151 Dereference after null check Signed-off-by: Michael Niedermayer --- libavformat/fifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 620fffa032..50656f78b7

Re: [FFmpeg-devel] [PATCH v3 1/3] libavcodec: write out user data unregistered SEI for x264

2021-05-16 Thread Marton Balint
On Sat, 15 May 2021, Brad Hards wrote: Signed-off-by: Brad Hards --- libavcodec/libx264.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) Please designate the name of the touched component in the prefix of the commit message, e.g:

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-16 Thread Marton Balint
On Fri, 14 May 2021, Dominguez Bonini, David wrote: Hi, Hi Marton, Il 2021-05-12 19:18 Marton Balint ha scritto: On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q

[FFmpeg-devel] [PATCH v2] avformat/flvdec: use milisecond precision for parsing timestamps

2021-05-14 Thread Marton Balint
Also use helper function to set the timestamp. Maybe we could also use nanosecond precision, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 11 ++- tests/ref/fate/flv-demux | 2 +- 2 files changed, 3 insertions(+), 10 deletions

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-14 Thread Marton Balint
On Fri, 14 May 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-05-12 20:55:45) Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 13

Re: [FFmpeg-devel] Encode user data unregistered SEI (H.264/H.265)

2021-05-14 Thread Marton Balint
On Fri, 14 May 2021, Brad Hards wrote: On Friday, 14 May 2021 1:59:13 AM AEST Marton Balint wrote: On Tue, 11 May 2021, Brad Hards wrote: On Saturday, 1 May 2021 12:23:00 PM AEST Brad Hards wrote: MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps

Re: [FFmpeg-devel] [PATCH] avformat/utils: Fix NPD when allocating AVStreamInternal fails

2021-05-13 Thread Marton Balint
On Thu, 13 May 2021, Andreas Rheinhardt wrote: Regression since b9c5fdf6027010d15ee90a43aa023e45a5189097; fixes Coverity ID #1484786. Signed-off-by: Andreas Rheinhardt --- Checking for st->internal->parser is btw unnecessary as av_parser_close(NULL) is safe. I think it is fine if you

Re: [FFmpeg-devel] Encode user data unregistered SEI (H.264/H.265)

2021-05-13 Thread Marton Balint
On Tue, 11 May 2021, Brad Hards wrote: On Saturday, 1 May 2021 12:23:00 PM AEST Brad Hards wrote: MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps and sensor identifiers) to be included. That currently isn't supported. This series adds encoding for

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread Marton Balint
On Wed, 12 May 2021, James Almer wrote: On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone

[FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread Marton Balint
Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 13 ++--- tests/ref/fate/flv-demux | 2 +- 2 files changed, 3 insertions(+), 12 deletions

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-12 Thread Marton Balint
On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(, 40); What are these? I didn't find any official document about it but this seems to be the way

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Marton Balint
On Mon, 10 May 2021, Anton Khirnov wrote: Export them in UTC, not the local timezone. This way the output is the same everywhere. The timezone information stored in the file is still ignored, since there seems to be no simple way to export it correctly. Format them according to ISO 8601,

Re: [FFmpeg-devel] [PATCH 2/2] lavf/mpegts: fix av_log use the uninitialized stream id

2021-05-09 Thread Marton Balint
On Fri, 7 May 2021, Jun Zhao wrote: From: Jun Zhao fix av_log use the uninitialized stream id Actually i is not the correct value even if it is initialized because the loop is executed in full. Either remove remove logging the stream index, it is not super useful anyway, or rework

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-03 Thread Marton Balint
On Mon, 3 May 2021, Steinar H. Gunderson wrote: Support wrapping the output format in Metacube, as used by the Cubemap stream reflector (originally designed for VLC). This is nominally meant to run over HTTP, but longer-term would probably also be useful for pipe output as a subprocess of

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-02 Thread Marton Balint
On Tue, 27 Apr 2021, Ubaldo Porcheddu wrote: Signed-off-by: Ubaldo Porcheddu --- libavformat/mpegtsenc.c | 110 ++-- 1 file changed, 106 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index

Re: [FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-04-30 Thread Marton Balint
On Mon, 26 Apr 2021, Lynne wrote: Apr 26, 2021, 02:36 by c...@passwd.hu: On Sun, 25 Apr 2021, Lynne wrote: This is the same patch sent in January, rebased on top of the ABI bump patchset. Two additions mirror exactly what AVFrame has - an opaque field and an opaque_ref for user-side

Re: [FFmpeg-devel] [PATCH 1/5] libavutil: add convenience accessors for frame side data

2021-04-30 Thread Marton Balint
On Fri, 30 Apr 2021, Lynne wrote: Apr 30, 2021, 13:34 by br...@frogmouth.net: Signed-off-by: Brad Hards --- libavutil/frame.c | 31 +++ libavutil/frame.h | 23 +++ 2 files changed, 54 insertions(+) diff --git a/libavutil/frame.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: move is_dvb_subtitle/is_dvb_teletext initialization upwards

2021-04-28 Thread Marton Balint
On Sat, 24 Apr 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index a357f3a6aa..8ff834be4e 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-28 Thread Marton Balint
On Sun, 25 Apr 2021, zheng qian wrote: On Sun, Apr 25, 2021 at 2:13 AM Marton Balint wrote: The order of the patches seems wrong. Patch/3 (or similar) should be applied first, otherwise you are checking the stream_id provided via side data, not the stream id actually used. Also note

Re: [FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-04-25 Thread Marton Balint
On Sun, 25 Apr 2021, Lynne wrote: This is the same patch sent in January, rebased on top of the ABI bump patchset. Two additions mirror exactly what AVFrame has - an opaque field and an opaque_ref for user-side private data. For justification on the void *opaque field, you can read the

[FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: factorize determining pes stream id

2021-04-24 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 60 - 1 file changed, 35 insertions(+), 25 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 8ff834be4e..9a387419bf 100644 --- a/libavformat/mpegtsenc.c +++ b

[FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: move is_dvb_subtitle/is_dvb_teletext initialization upwards

2021-04-24 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index a357f3a6aa..8ff834be4e 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1300,8

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-24 Thread Marton Balint
On Thu, 22 Apr 2021, zheng qian wrote: Changes since v2: Fix PES_packet_length mismatch bug According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_id meets the condition: if

Re: [FFmpeg-devel] [PATCH] avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD

2021-04-24 Thread Marton Balint
On Mon, 19 Apr 2021, Brad Smith wrote: Can this please be back ported to the 4.4 branch? Ok, done. Regards, Marton On 4/18/2021 4:50 PM, Marton Balint wrote: On Fri, 16 Apr 2021, Brad Smith wrote: ping. Will apply, thanks. Marton On 4/3/2021 2:49 PM, Brad Smith wrote: avutil

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-19 Thread Marton Balint
On Mon, 19 Apr 2021, zheng qian wrote: Is there anyone who could review this patch? Jan was interested in this, so preferably he should also comment, but it looks fine to me. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-19 Thread Marton Balint
On Tue, 20 Apr 2021, zheng qian wrote: According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_id meets the condition: if (stream_id != 0xBC && // program_stream_map stream_id

Re: [FFmpeg-devel] [PATCH] avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD

2021-04-18 Thread Marton Balint
On Fri, 16 Apr 2021, Brad Smith wrote: ping. Will apply, thanks. Marton On 4/3/2021 2:49 PM, Brad Smith wrote: avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD Signed-off-by: Brad Smith --- libavutil/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-18 Thread Marton Balint
On Sat, 17 Apr 2021, Mao Hata wrote: According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. Which section describes this? Also keep in mind that code was added so that AV_CODEC_ID_SMPTE_KLV is handled in mpegts, and

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-18 Thread Marton Balint
On Sat, 10 Apr 2021, Marton Balint wrote: On Sat, 10 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: Fixes the only remaining part of ticket #8931. Signed-off-by: Marton Balint --- libavfilter/af_mcompand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/muxers: add entries for raw muxers

2021-04-11 Thread Marton Balint
On Sun, 11 Apr 2021, Anton Khirnov wrote: Quoting Gyan Doshi (2021-04-11 12:52:18) On 2021-04-11 15:27, Carl Eugen Hoyos wrote: > Am So., 11. Apr. 2021 um 08:41 Uhr schrieb Gyan Doshi : >> ffmpeg | branch: master | Gyan Doshi | Sat Apr 10 16:35:53 2021 +0530|

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread Marton Balint
On Sat, 10 Apr 2021, zheng qian wrote: Changes since v1: If desc_len < 3, break the switch statement instead of return AVERROR_INVALIDDATA to make it more robust. For arib_caption, data_component_descriptor should contains at least 3 bytes: data_component_id: uint16,

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: check return value of new_init_section()

2021-04-10 Thread Marton Balint
On Sat, 10 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: Fixes part of ticket #8931. Signed-off-by: Marton Balint --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 597bea7f25..b589ad2870 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-10 Thread Marton Balint
On Sat, 10 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: Fixes the only remaining part of ticket #8931. Signed-off-by: Marton Balint --- libavfilter/af_mcompand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index

[FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-10 Thread Marton Balint
Fixes the only remaining part of ticket #8931. Signed-off-by: Marton Balint --- libavfilter/af_mcompand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index ce4f366ad7..d1a3dc123a 100644 --- a/libavfilter/af_mcompand.c +++ b

[FFmpeg-devel] [PATCH 1/2] avformat/hls: check return value of new_init_section()

2021-04-10 Thread Marton Balint
Fixes part of ticket #8931. Signed-off-by: Marton Balint --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 597bea7f25..b589ad2870 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -842,6 +842,10 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2] avformat/url: fix ff_make_absolute_url with Windows file paths

2021-04-07 Thread Marton Balint
On Tue, 6 Apr 2021, Marton Balint wrote: Ugly, but a lot less broken than it was. Fixes ticket #9166. Ok, it seems there were no interest, so I just applied the series, so maybe this can make it into 4.4 as well. Regards, Marton Signed-off-by: Marton Balint --- libavformat/url.c

[FFmpeg-devel] [PATCH 2/2] avformat/url: add ff_make_absolulte_url2 to be able to test windows path cases

2021-04-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/tests/url.c | 33 ++--- libavformat/url.c | 12 +--- libavformat/url.h | 10 ++ tests/ref/fate/url | 20 4 files changed, 69 insertions(+), 6 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] avformat/url: fix ff_make_absolute_url with Windows file paths

2021-04-05 Thread Marton Balint
Ugly, but a lot less broken than it was. Fixes ticket #9166. Signed-off-by: Marton Balint --- libavformat/url.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/libavformat/url.c b/libavformat/url.c index 77d610d95f..222d7d8a10 100644

Re: [FFmpeg-devel] [PATCH 01/17] lavu: postpone child_class_next API removal

2021-04-05 Thread Marton Balint
On Mon, 5 Apr 2021, Anton Khirnov wrote: It has only been deprecated a year ago. Considering that this API has limited public usage, I don't think we have to be strict about the 2 years here, so IMHO it is fine to remove it at the bump. Regards, Marton --- libavutil/version.h | 6

Re: [FFmpeg-devel] [PATCH] avformat/url: fix ff_make_absolute_url with Windows file paths

2021-04-05 Thread Marton Balint
On Fri, 2 Apr 2021, Marton Balint wrote: Ugly, but a lot less broken than it was. Fixes ticket #9166. Ping for this, if there is no disapproval of this fix then I plan to extend fate and backport this to 4.4/4.3. Thanks, Marton Signed-off-by: Marton Balint --- libavformat/url.c | 25

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-04 Thread Marton Balint
On Sun, 4 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: On Sat, 3 Apr 2021, Andreas Rheinhardt wrote: Implements ticket #9113. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-04 Thread Marton Balint
On Sat, 3 Apr 2021, Andreas Rheinhardt wrote: Implements ticket #9113. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index

[FFmpeg-devel] [PATCH] avformat/url: fix ff_make_absolute_url with Windows file paths

2021-04-02 Thread Marton Balint
Ugly, but a lot less broken than it was. Fixes ticket #9166. Signed-off-by: Marton Balint --- libavformat/url.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavformat/url.c b/libavformat/url.c index 77d610d95f..90fd41e810 100644

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: PAL DV files with dsf flag 0 - detect via pal flag and buf_size

2021-03-30 Thread Marton Balint
On Tue, 30 Mar 2021, Mark Plomer wrote: ping ;-) Applied, thanks. Marton Am 18.03.21 um 21:55 schrieb Marton Balint: It looks good to me, I will apply in a couple of days if nobody comments until then. Also Cc'd Dave, as he got probably the most experience with dv. Regards, Marton

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add missing dispositions

2021-03-30 Thread Marton Balint
On Tue, 30 Mar 2021, Andreas Rheinhardt wrote: Andreas Rheinhardt: Signed-off-by: Andreas Rheinhardt --- diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 11e3cbd6c2..38462e1ff3 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2770,6 +2770,11 @@ static int

Re: [FFmpeg-devel] [PATCH] avformat: add apic to AVStream

2021-03-28 Thread Marton Balint
On Sun, 28 Mar 2021, James Almer wrote: As a replacement for attached_pic, which is in turn deprecated and scheduled for removal. Signed-off-by: James Almer --- TODO: APIChanges entry and version bump. Decided to use the name apic for the field, since it's how id3v2 and other formats call

Re: [FFmpeg-devel] [PATCH] avformat/rtpenc_mpegts: stop leaks

2021-03-28 Thread Marton Balint
On Sun, 28 Mar 2021, Gyan Doshi wrote: Fixes CID 1474460 & 1474461 --- libavformat/rtpenc_mpegts.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) LGTM, thanks. Marton diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c index f7ee5a4448..9f95b3a4e8

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread Marton Balint
On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 3:37 PM, James Almer wrote: On 3/21/2021 3:15 PM, Marton Balint wrote: On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov

Re: [FFmpeg-devel] [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

2021-03-21 Thread Marton Balint
On Sun, 21 Mar 2021, James Almer wrote: On 3/21/2021 11:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-21 14:54:22) On 3/21/2021 9:28 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-05 17:32:52) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: RTP support buffer_size_size option

2021-03-19 Thread Marton Balint
On Wed, 10 Mar 2021, Marton Balint wrote: On Tue, 9 Mar 2021, gaojiang...@live.com wrote: From: Jiangjie Gao And forward it to udp. issue: https://trac.ffmpeg.org/ticket/7517 Could you add the buffer_size option to the documentation of the RTP protocol? Did it, and applied. Thanks

Re: [FFmpeg-devel] Patch for ticket #9151

2021-03-19 Thread Marton Balint
On Fri, 19 Mar 2021, Dominic Mayers wrote: Here is the updated patch in attachment. Thanks, will apply. Regards, Marton Dominic On 3/19/21 5:05 AM, Moritz Barsnick wrote: Hi Dominic, On Thu, Mar 18, 2021 at 16:15:59 -0400, Dominic Mayers wrote: Hello, Ticket #9151 Applies to:

Re: [FFmpeg-devel] [PATCH 1/2] avformat/libsrt: fix setsockopt() typo

2021-03-19 Thread Marton Balint
On Tue, 16 Mar 2021, myp...@gmail.com wrote: On Mon, Mar 15, 2021 at 5:06 PM Zhao Zhili wrote: --- libavformat/libsrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 233e9096fa..ac865c5658 100644 ---

Re: [FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

2021-03-19 Thread Marton Balint
On Sun, 14 Mar 2021, Moritz Barsnick wrote: On Sun, Aug 23, 2020 at 22:50:18 +0300, Martin Storsjö wrote: > On Fri, Aug 21, 2020 at 12:19:06 +0300, Martin Storsjö wrote: > > LGTM, with one small nit: > [...] > > > {"listen", "Listen for incoming connections", offsetof(pstruct,

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: PAL DV files with dsf flag 0 - detect via pal flag and buf_size

2021-03-18 Thread Marton Balint
On Thu, 18 Mar 2021, Mark Plomer wrote: Okay cool, I added the check for the PAL flag - this still works fine for my test-videos. I also looked at the old hack above with the codec_tag check - changed in 2013 for ticket #2177 (patch by Michael Niedermayer). I removed that more specific

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-18 Thread Marton Balint
On Wed, 17 Mar 2021, Pavel Koshevoy wrote: Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop the packet. LGTM, but Michael was against it last time: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20181009233214.8785-2-...@passwd.hu/ Regards, Marton ---

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-03-16 Thread Marton Balint
On Tue, 16 Mar 2021, Marton Balint wrote: On Tue, 16 Mar 2021, Mark Plomer wrote: Unfortunately it is not possible to move the hack to the bottom, because the "normal processing" (dv_profiles lookup loop) will catch it otherwise (with a wrong profile), because it does

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-03-16 Thread Marton Balint
t the new hack after all other "pre-normal-processing" hacks ;-) Regards Mark Am 13.03.21 um 17:48 schrieb Marton Balint: On Sat, 16 Jan 2021, Mark Plomer wrote: Trying to fix https://trac.ffmpeg.org/ticket/8333 Some of my old DV AVI files have the DSF-Flag of frames set to 0, alth

Re: [FFmpeg-devel] [PATCH] avcodec/wrapped_avframe: stop using sizeof(AVFrame)

2021-03-14 Thread Marton Balint
On Sun, 14 Mar 2021, James Almer wrote: On 3/14/2021 3:25 PM, Marton Balint wrote: On Sun, 14 Mar 2021, James Almer wrote: I guess the fundamental problem of WRAPPED_AVFRAME is that deep copying it is not supported, but you don't exactly disallow that by using a size of 0, because

Re: [FFmpeg-devel] [PATCH] avcodec/wrapped_avframe: stop using sizeof(AVFrame)

2021-03-14 Thread Marton Balint
On Sun, 14 Mar 2021, James Almer wrote: Is using sizeof(AVFrame) an issue apart from that it is not part of ABI? Is there an actual issue this patch fix? It doesn't fix a current issue, it ensures an issue doesn't arise in the future when a new field is added to AVFrame and it's lost when

Re: [FFmpeg-devel] [PATCH] avcodec/wrapped_avframe: stop using sizeof(AVFrame)

2021-03-14 Thread Marton Balint
On Sat, 13 Mar 2021, James Almer wrote: Signed-off-by: James Almer --- Setting pkt->size to 0 but leaving pkt->data pointing to the frame ensures that the packet isn't mistaken for an empty one, and prevents wrong use of the data pointer in case av_packet_make_writable() is called on it (The

[FFmpeg-devel] [PATCH 8/8] avformat/assenc: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/assenc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index 68c3396e5a..265b5996ac 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -156,16 +156,23

[FFmpeg-devel] [PATCH 7/8] avcodec/srtdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/srtdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/srtdec.c b/libavcodec/srtdec.c index 98f84ac673..37fb0d3173 100644 --- a/libavcodec/srtdec.c +++ b/libavcodec/srtdec.c @@ -62,6 +62,7 @@ static int

[FFmpeg-devel] [PATCH 6/8] avcodec/webvttdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/webvttdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c index 7b2d1750de..43caf3edbd 100644 --- a/libavcodec/webvttdec.c +++ b/libavcodec/webvttdec.c @@ -42,23 +42,23

[FFmpeg-devel] [PATCH 5/8] avcodec/subviewerdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/subviewerdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/subviewerdec.c b/libavcodec/subviewerdec.c index 805c7dd547..1016ac7ada 100644 --- a/libavcodec/subviewerdec.c +++ b/libavcodec/subviewerdec.c

[FFmpeg-devel] [PATCH 4/8] avcodec/realtextdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/realtextdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/realtextdec.c b/libavcodec/realtextdec.c index 5084781123..bdd9659235 100644 --- a/libavcodec/realtextdec.c +++ b/libavcodec/realtextdec.c @@ -29,11

[FFmpeg-devel] [PATCH 3/8] avcodec/mpl2dec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/mpl2dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpl2dec.c b/libavcodec/mpl2dec.c index 409e4b3708..efeecb0d64 100644 --- a/libavcodec/mpl2dec.c +++ b/libavcodec/mpl2dec.c @@ -29,15 +29,15

[FFmpeg-devel] [PATCH 2/8] avcodec/samidec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/samidec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index e32f238c62..f03b5db958 100644 --- a/libavcodec/samidec.c +++ b/libavcodec/samidec.c @@ -38,12 +38,12 @@ typedef

[FFmpeg-devel] [PATCH 1/8] avcodec/assdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/assdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/assdec.c b/libavcodec/assdec.c index f0b1069cd2..655fc1365c 100644 --- a/libavcodec/assdec.c +++ b/libavcodec/assdec.c @@ -54,7 +54,7 @@ static int ass_decode_frame

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-13 Thread Marton Balint
On Fri, 12 Mar 2021, James Almer wrote: I get a packet from a demuxer. It contains two independent portions (NALUs, OBUs, etc) i want to separate in order to feed them to something like a multi threaded decoder. And so I create a new reference to it, resulting in two packets pointing to

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Marton Balint
On Sat, 13 Mar 2021, Paul B Mahol wrote: On Sat, Mar 13, 2021 at 5:56 PM Marton Balint wrote: On Fri, 12 Mar 2021, Paul B Mahol wrote: > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: > >> >> >> On Sun, 7 Mar 2021, Marton Balint wrote: >> >>

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Marton Balint
On Fri, 12 Mar 2021, Paul B Mahol wrote: On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: On Sun, 7 Mar 2021, Marton Balint wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: >> >>> >>

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-03-13 Thread Marton Balint
On Sat, 16 Jan 2021, Mark Plomer wrote: Trying to fix https://trac.ffmpeg.org/ticket/8333 Some of my old DV AVI files have the DSF-Flag of frames set to 0, although it is PAL (I think they were rendered with Ulead Media Studio Pro) ... this causes ffmpeg/VLC-player to produce/play

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-12 Thread Marton Balint
On Wed, 10 Mar 2021, Marton Balint wrote: On Sat, 6 Mar 2021, Marton Balint wrote: On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-12 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 7:40 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-11 Thread Marton Balint
On Sun, 7 Mar 2021, Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add missing include for buffer_size_t

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:40 PM, James Almer wrote: Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + 2 files changed, 2

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not correctly handle non-writable packets. I don't think this is a good idea, av_shrink_packet

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: RTP support buffer_size_size option

2021-03-10 Thread Marton Balint
On Tue, 9 Mar 2021, gaojiang...@live.com wrote: From: Jiangjie Gao And forward it to udp. issue: https://trac.ffmpeg.org/ticket/7517 Could you add the buffer_size option to the documentation of the RTP protocol? Thanks, Marton Signed-off-by: Jiangjie Gao --- libavformat/rtsp.c | 5

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/gopher: Add support for Gopher over TLS.

2021-03-10 Thread Marton Balint
On Mon, 8 Mar 2021, Ivan J. wrote: Bump for review. Will apply the series. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-10 Thread Marton Balint
On Tue, 9 Mar 2021, Stephen Hutchinson wrote: On 3/9/2021 3:47 PM, Michael Niedermayer wrote: Hi all I will branch release/4.4 soon then like always leave some time for testing, bugfixes, ... and then make FFmeg 4.4 from release/4.4, its too long since 4.3 These three AviSynth demuxer

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-10 Thread Marton Balint
On Sat, 6 Mar 2021, Marton Balint wrote: On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest of the series. Note that the approach

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-10 Thread Marton Balint
On Mon, 8 Mar 2021, Michael Niedermayer wrote: On Mon, Mar 08, 2021 at 09:56:38PM +0100, Marton Balint wrote: On Sun, 7 Mar 2021, Michael Niedermayer wrote: On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote: If the window is resized it was possible that xpos pointed outside

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-08 Thread Marton Balint
On Sun, 7 Mar 2021, Michael Niedermayer wrote: On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote: If the window is resized it was possible that xpos pointed outside the visualization texture. By rearranging the overflow check we make sure this (and a crash) does not happen

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-07 Thread Marton Balint
On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> > On Sun, Mar 7, 2021 at 1:35 AM

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-07 Thread Marton Balint
On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: On 3/6/2021 9:51 PM, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint wrote: > >> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >>> How

<    4   5   6   7   8   9   10   11   12   13   >