> On Jun 10, 2024, at 19:59, Martin Storsjö wrote:
>
> On Fri, 7 Jun 2024, Zhao Zhili wrote:
>
>> From: Zhao Zhili
>>
>
> No further comments from me, on this patchset. (Rémi had a comment on 2/4
> though - I don't have a strong opinion on that matter eith
From: Zhao Zhili
Test on Apple M1:
rgb24_to_uv_8_c: 0.0
rgb24_to_uv_8_neon: 0.2
rgb24_to_uv_128_c: 1.0
rgb24_to_uv_128_neon: 0.5
rgb24_to_uv_1080_c: 7.0
rgb24_to_uv_1080_neon: 5.7
rgb24_to_uv_1920_c: 12.5
rgb24_to_uv_1920_neon: 9.5
rgb24_to_uv_half_8_c: 0.2
rgb24_to_uv_half_8_neon: 0.2
From: Zhao Zhili
B0 is defined by system header, see f0f596dbc6b for ref.
---
v3: add f0f596dbc6b as ref.
tests/checkasm/llviddsp.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/checkasm/llviddsp.c b/tests/checkasm/llviddsp.c
index b75c0ea099
From: Zhao Zhili
---
v3: add ff_read_time() rather than use av_gettime_relative() to get
nanosecond precision.
libavutil/timer.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libavutil/timer.h b/libavutil/timer.h
index 2cd299eca3..3e5d5ef23f 100644
--- a/libavutil/timer.h
From: Zhao Zhili
It will fallback to mach_absolute_time inside libavutil/timer.h
---
libavutil/aarch64/timer.h | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h
index 8b28fd354c..fadc9568f8 100644
--- a/libavutil
> On Jun 7, 2024, at 17:09, Martin Storsjö wrote:
>
> On Fri, 7 Jun 2024, Zhao Zhili wrote:
>
>> Note both tests use clang as compiler, which has vectorization
>> enabled by default with -O3.
>
> FWIW, for more interesting benchmarks, you can configure the buil
> On Jun 7, 2024, at 17:09, Martin Storsjö wrote:
>
> On Fri, 7 Jun 2024, Zhao Zhili wrote:
>
>> Note both tests use clang as compiler, which has vectorization
>> enabled by default with -O3.
>
> FWIW, for more interesting benchmarks, you can configure the buil
> On Jun 7, 2024, at 16:38, Martin Storsjö wrote:
>
> On Fri, 7 Jun 2024, Martin Storsjö wrote:
>
>> On Fri, 7 Jun 2024, Zhao Zhili wrote:
>>
>>> From: Zhao Zhili
>>> B0 is defined by system header.
>>
>> Can you add more details ab
> On Jun 7, 2024, at 16:21, Martin Storsjö wrote:
>
> On Fri, 7 Jun 2024, Zhao Zhili wrote:
>
>> From: Zhao Zhili
>>
>> B0 is defined by system header.
>
> Can you add more details about which header defines this? (I did a quick grep
> in a copy
> On Jun 7, 2024, at 10:12, Hiccup Zhu wrote:
>
> On Thu, 6 Jun 2024 at 20:20, Zhao Zhili wrote:
>>
>>
>> On Jun 6, 2024, at 19:51, Shiqi Zhu wrote:
>>
>>
>> I’m afraid this has the same issue as libavdevice/sdl[1].
>>
>>
From: Zhao Zhili
Test on Apple M1:
rgb24_to_uv_8_c: 0.0
rgb24_to_uv_8_neon: 0.2
rgb24_to_uv_128_c: 1.0
rgb24_to_uv_128_neon: 0.5
rgb24_to_uv_1080_c: 7.0
rgb24_to_uv_1080_neon: 5.7
rgb24_to_uv_1920_c: 12.5
rgb24_to_uv_1920_neon: 9.5
rgb24_to_uv_half_8_c: 0.2
rgb24_to_uv_half_8_neon: 0.2
From: Zhao Zhili
B0 is defined by system header.
---
tests/checkasm/llviddsp.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/checkasm/llviddsp.c b/tests/checkasm/llviddsp.c
index b75c0ea099..9f8de65df4 100644
--- a/tests/checkasm/llviddsp.c
+++ b
From: Zhao Zhili
---
libavutil/timer.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavutil/timer.h b/libavutil/timer.h
index 2cd299eca3..74c4d84e69 100644
--- a/libavutil/timer.h
+++ b/libavutil/timer.h
@@ -46,6 +46,8 @@
#include "macos_kperf.h"
#elif HAVE_MACH_ABS
From: Zhao Zhili
It will fallback to mach_absolute_time inside libavutil/timer.h
---
libavutil/aarch64/timer.h | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h
index 8b28fd354c..fadc9568f8 100644
--- a/libavutil
> On Jun 6, 2024, at 19:51, Shiqi Zhu wrote:
I’m afraid this has the same issue as libavdevice/sdl[1].
[1]
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230918063728.198377-1-haihao.xi...@intel.com/
>
> Signed-off-by: Shiqi Zhu
> ---
> configure| 1 +
>
From: Zhao Zhili
The line width 8 is supposed to test corner case, while the
performance doesn't matter. Width 1080 is also a case of
unaligned to 16.
Width 1920 meant for benchmark (together with --runs options).
---
v2: add bgr24 support
Feel free to remove 128 and/or 1280 from input_sizes
> On Jun 5, 2024, at 14:29, Rémi Denis-Courmont wrote:
>
>
>
> Le 4 juin 2024 16:55:01 GMT+03:00, Zhao Zhili <mailto:quinkbl...@foxmail.com>> a écrit :
>> From: Zhao Zhili
>>
>> Test on Apple M1:
>>
>> rgb24_to_uv_1080_c: 7.2
&g
> On Jun 4, 2024, at 21:58, James Almer wrote:
>
> On 6/4/2024 10:55 AM, Zhao Zhili wrote:
>> From: Zhao Zhili
>> ---
>> tests/checkasm/sw_rgb.c | 103
>> 1 file changed, 103 insertions(+)
>> diff --git a/t
From: Zhao Zhili
Test on Apple M1:
rgb24_to_uv_1080_c: 7.2
rgb24_to_uv_1080_neon: 5.5
rgb24_to_uv_1280_c: 8.2
rgb24_to_uv_1280_neon: 6.2
rgb24_to_uv_1920_c: 12.5
rgb24_to_uv_1920_neon: 9.5
rgb24_to_uv_half_540_c: 6.5
rgb24_to_uv_half_540_neon: 3.0
rgb24_to_uv_half_640_c: 7.5
From: Zhao Zhili
---
libavutil/timer.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavutil/timer.h b/libavutil/timer.h
index 2cd299eca3..74c4d84e69 100644
--- a/libavutil/timer.h
+++ b/libavutil/timer.h
@@ -46,6 +46,8 @@
#include "macos_kperf.h"
#elif HAVE_MACH_ABS
From: Zhao Zhili
The inline asm doesn't work on Android.
---
libavutil/aarch64/timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h
index fadc9568f8..13a58b48e4 100644
--- a/libavutil/aarch64/timer.h
+++ b/libavutil
From: Zhao Zhili
---
tests/checkasm/sw_rgb.c | 103
1 file changed, 103 insertions(+)
diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c
index 7cd815e5be..cc9b957461 100644
--- a/tests/checkasm/sw_rgb.c
+++ b/tests/checkasm/sw_rgb.c
@@ -24,6
From: Zhao Zhili
It will fallback to mach_absolute_time inside libavutil/timer.h
---
libavutil/aarch64/timer.h | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h
index 8b28fd354c..fadc9568f8 100644
--- a/libavutil
> On Jun 3, 2024, at 22:17, Rémi Denis-Courmont wrote:
>
> Le maanantaina 3. kesäkuuta 2024, 16.11.15 EEST Zhao Zhili a écrit :
>>> See https://github.com/mstorsjo/FFmpeg/actions/runs/9346228714 for one
>>> example run of these actions with your patches
> On Jun 3, 2024, at 16:07, Martin Storsjö wrote:
>
> On Mon, 3 Jun 2024, Zhao Zhili wrote:
>
>> diff --git a/libswscale/aarch64/input.S b/libswscale/aarch64/input.S
>> new file mode 100644
>> index 00..0a46475723
>> --- /dev/null
>> +++ b/li
From: Zhao Zhili
Test on Apple M1:
rgb24_to_uv_1080_c: 7.0
rgb24_to_uv_1080_neon: 5.5
rgb24_to_uv_1280_c: 8.2
rgb24_to_uv_1280_neon: 6.0
rgb24_to_uv_4096_c: 26.2
rgb24_to_uv_4096_neon: 20.7
rgb24_to_uv_half_540_c: 6.5
rgb24_to_uv_half_540_neon: 3.0
rgb24_to_uv_half_640_c: 8.0
From: Zhao Zhili
---
The test still failed on x86, but success on arm64 and longarch.
I have tried to call rgb24ToY_c and ff_rgb24ToY_avx directly and
compare the results, they don't match.
https://github.com/quink-black/FFmpeg/actions/runs/9347753270
https://patchwork.ffmpeg.org/project
From: Zhao Zhili
Test on Apple M1:
rgb24_to_uv_1080_c: 7.0
rgb24_to_uv_1080_neon: 5.5
rgb24_to_uv_1280_c: 8.2
rgb24_to_uv_1280_neon: 6.0
rgb24_to_uv_4096_c: 26.2
rgb24_to_uv_4096_neon: 20.7
rgb24_to_uv_half_540_c: 6.5
rgb24_to_uv_half_540_neon: 3.0
rgb24_to_uv_half_640_c: 8.0
From: Zhao Zhili
---
I need help on the test. It succeed with the following patch on ARM64,
but failed with x86. I'm not sure whether the issue is in the test, or
hidden in x86 asm, and I don't know x86 asm.
tests/checkasm/sw_rgb.c | 126
1 file changed
ose(AVCodecContext *avctx)
> {
> MediaCodecEncContext *s = avctx->priv_data;
> +
> +#if __ANDROID_API__ >= 26
> +if (strlen(s->bitrate_ctrl_socket) != 0) {
> +mediacodecenc_ctrl_deinit(avctx);
> +}
> +#endif //__ANDROID_API__ >= 26
> +
>
> On May 27, 2024, at 23:22, Rémi Denis-Courmont wrote:
>
> The generally expected behaviour is for software to append from the
> current position, not to keep resetting. See also how shell works:
> # (foo && bar) > file
> ...would normally concatenate the output of both commands to file.
>
>
> On May 24, 2024, at 02:41, epira...@gmail.com wrote:
>
>
> On 23 May 2024, at 18:05, Zhao Zhili wrote:
>
>>> On May 21, 2024, at 09:56, Gnattu OC via ffmpeg-devel
>>> wrote:
>>>
>>>>
>>>> On May 20, 2024, at 09:12, M
> On May 21, 2024, at 09:56, Gnattu OC via ffmpeg-devel
> wrote:
>
>>
>> On May 20, 2024, at 09:12, Marvin Scholz wrote:
>>
>> Fix #10884
>> ---
>> libavutil/hwcontext_videotoolbox.c | 54 +-
>> 1 file changed, 38 insertions(+), 16 deletions(-)
>>
>> diff --git
> On May 23, 2024, at 15:08, Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> Signed-off-by: Zhao Zhili
> ---
> libavcodec/mediacodecenc.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/mediacodecenc.c b/libavcodec/medi
From: Zhao Zhili
---
The patchset for master branch isn't suitable for release branch, since it
implement a new feature in bsf.
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11882
libavcodec/mediacodecenc.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff
From: Zhao Zhili
There is no bsf for other codecs to modify crop info except H.265.
For H.265, the assumption that FFALIGN(width, 16)xFFALIGN(height, 16)
is the video resolution can be wrong, since the encoder can use CTU
larger than 16x16. In that case, use FFALIGN(width, 16) - width
From: Zhao Zhili
There is no bsf for other codecs to modify crop info except H.265.
For H.265, the assumption that FFALIGN(width, 16)xFFALIGN(height, 16)
is the video resolution can be wrong, since the encoder can use CTU
larger than 16x16. In that case, use FFALIGN(width, 16) - width
From: Zhao Zhili
It's a common usecase to request a video size after crop. Before
this patch, user must know the video size before crop, then set
crop_right/crop_bottom accordingly. Since HEVC can have different
CTU size, it's not easy to get/deduce the video size before crop.
With the new width
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavcodec/mediacodecenc.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c
index bfff149039..a42270551b 100644
--- a/libavcodec/mediacodecenc.c
+++ b
From: Zhao Zhili
It's a common usecase to request a video size after crop. Before
this patch, user must know the video size before crop, then set
crop_right/crop_bottom accordingly. Since HEVC can have different
CTU size, it's not easy to get/deduce the video size before crop.
With the new width
> On May 20, 2024, at 09:12, Marvin Scholz wrote:
>
> Fix #10884
LGTM except the commit subject should mention videotoolbox or vt in short.
> ---
> libavutil/hwcontext_videotoolbox.c | 54 +-
> 1 file changed, 38 insertions(+), 16 deletions(-)
>
> diff --git
> On May 10, 2024, at 16:57, Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> Fix crash with
> ./ffplay -f lavfi -i movie=foo.mp4,drawtext=text=bar
This is an RFC because I’m not sure whether it’s a valid use case or not to call
ff_default_get_video_buffer2 from multiple th
From: Zhao Zhili
Fix crash with
./ffplay -f lavfi -i movie=foo.mp4,drawtext=text=bar
---
libavfilter/avfilter.c | 2 ++
libavfilter/avfilter_internal.h | 2 ++
libavfilter/video.c | 14 --
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git
From: Zhao Zhili
The alignment is handled by ff_default_get_video_buffer2. We
shouldn't use the aligned width/height as FFFramePool width/height.
It cause recreate FFFramePool inside ff_default_get_video_buffer2.
The recreate of FFFramePool together with multi-threads decoding
leading to data
On 2024/5/6 21:42, Zhao Zhili wrote:
On May 6, 2024, at 19:48, Guo, Yejun
wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of Zhao
Zhili
Sent: Tuesday, April 30, 2024 3:12 PM
To: ffmpeg-devel@ffmpeg.org
Cc: Zhao Zhili
Subject: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn
From: Zhao Zhili
For code such as 'model->model = ov_model' is confusing. We can
just drop the member variable and use cast to get the subclass.
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 17 -
libavfilter/dnn/dnn_backend_tf.c |
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavfilter/vf_dnn_detect.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c
index b4eee06fe7..2a277d4169 100644
--- a/libavfilter/vf_dnn_detect.c
+++ b
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 47 +++---
1 file changed, 20 insertions(+), 27 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index ba79eba73f..1a5ed6383a
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 63
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 0ab3bd13ed..eb4a2a5289 100644
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_torch.cpp | 31 +++
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_torch.cpp
b/libavfilter/dnn/dnn_backend_torch.cpp
index b70e4db600..0aa0b95269
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 33 +---
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 8b53a3b87a..583ebd7c13 100644
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index eb4a2a5289..8b53a3b87a 100644
From: Zhao Zhili
This patch trying to resolve mulitiple issues related to parameter
configuration:
Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should
be the common options of backend.
Secondly, backend options are hidden behind the scene. It's a
AV_OPT_TYPE_STRING
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index 5ea8fb8d1f..ba79eba73f
From: Zhao Zhili
---
libavfilter/dnn/dnn_interface.c | 11 ---
libavfilter/dnn_filter_common.h | 11 +--
libavfilter/dnn_interface.h | 8 ++--
libavfilter/vf_derain.c | 2 +-
libavfilter/vf_dnn_classify.c | 2 +-
libavfilter/vf_dnn_detect.c | 2
From: Zhao Zhili
v4:
1. Move [patch v3 9/10] to [patch v4 2/11], since patch 3 depends on it.
2. Don't show backends which are not supported by a filter (patch 3).
v3:
1. Init class with ff_dnn_filter_init_child_class and called by AVFilter
preinit.
2. Fix crash in vf_dnn_detect (patch 10/10
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 1 +
libavfilter/dnn/dnn_backend_tf.c | 1 +
libavfilter/dnn/dnn_backend_torch.cpp | 1 +
libavfilter/dnn/dnn_interface.c| 26 --
libavfilter/dnn_interface.h
> On May 6, 2024, at 19:48, Guo, Yejun
> wrote:
>
>> -Original Message-
>> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of Zhao
>> Zhili
>> Sent: Tuesday, April 30, 2024 3:12 PM
>> To: ffmpeg-devel@ffmp
> 在 2024年5月5日，上午5:51，epira...@gmail.com 写道：
>
>
>
>> On 4 May 2024, at 23:25, Andrew Sayers wrote:
>>
>>> On Sat, May 04, 2024 at 09:28:03PM +0200, Michael Niedermayer wrote:
>>> Hi
>>>
On Fri, May 03, 2024 at 03:45:20PM +, Cosmin Stejerean via
ffmpeg-devel wrote:
>>> [...]
> -Original Message-
> From: ffmpeg-devel On Behalf Of Ondřej Fiala
> Sent: 2024年5月2日 22:25
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation
>
> On Wed May 1, 2024 at 7:27 AM CEST, Rémi Denis-Courmont wrote:
> > Le 30 avril
> On May 2, 2024, at 21:27, Andrew Sayers wrote:
>
> On Thu, May 02, 2024 at 09:00:42PM +0800, Zhao Zhili wrote:
>>
>>
>>> On May 2, 2024, at 19:01, Lynne wrote:
>>>
>>> Apr 29, 2024, 11:24 by ffmpeg-de...@pileofstuff.org:
>>>
> On May 2, 2024, at 19:01, Lynne wrote:
>
> Apr 29, 2024, 11:24 by ffmpeg-de...@pileofstuff.org:
>
>> Some headings needed to be rewritten to accomodate the text,
>> (hopefully) without changing the meaning.
>> ---
>> libavcodec/aac/aacdec.h| 2 +-
>> libavcodec/aacenc.h
> On Apr 30, 2024, at 13:54, Chen, Wenbin
> wrote:
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Zhao
>> Zhili
>> Sent: Sunday, April 28, 2024 2:47 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Zhao Zhili
>> Subject: [FFmp
From: Zhao Zhili
---
libavfilter/vf_dnn_detect.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c
index 926966368a..1830bae181 100644
--- a/libavfilter/vf_dnn_detect.c
+++ b/libavfilter/vf_dnn_detect.c
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 1 +
libavfilter/dnn/dnn_backend_tf.c | 1 +
libavfilter/dnn/dnn_backend_torch.cpp | 1 +
libavfilter/dnn/dnn_interface.c| 26 --
libavfilter/dnn_interface.h| 1 +
5 files
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_torch.cpp | 31 +++
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_torch.cpp
b/libavfilter/dnn/dnn_backend_torch.cpp
index abdef1f178..818ec5b713 100644
--- a/libavfilter/dnn
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
---
libavfilter/dnn/dnn_backend_tf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 60f9e57fb7..3b4de6d13f 100644
--- a/libavfilter/dnn
From: Zhao Zhili
For code such as 'model->model = ov_model' is confusing. We can
just drop the member variable and use cast to get the subclass.
---
libavfilter/dnn/dnn_backend_openvino.c | 17 -
libavfilter/dnn/dnn_backend_tf.c | 19 +--
libavfilter/
From: Zhao Zhili
This patch trying to resolve mulitiple issues related to parameter
configuration:
Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should
be the common options of backend.
Secondly, backend options are hidden behind the scene. It's a
AV_OPT_TYPE_STRING
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 33 +---
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 3b4de6d13f..c7716e696d 100644
--- a/libavfilter/dnn
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
---
libavfilter/dnn/dnn_backend_openvino.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index c4b0682f11..769ba0a54b 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 63
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index d24591b90b..60f9e57fb7 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 47 +++---
1 file changed, 20 insertions(+), 27 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index 769ba0a54b..1acc54b791 100644
--- a/libavfilter/dnn
From: Zhao Zhili
v3:
1. Init class with ff_dnn_filter_init_child_class and called by AVFilter
preinit.
2. Fix crash in vf_dnn_detect (patch 10/10).
Zhao Zhili (10):
avfilter/dnn: Refactor DNN parameter configuration system
avfilter/dnn_backend_openvino: Fix free context at random place
> On Apr 29, 2024, at 18:29, Guo, Yejun
> wrote:
>
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Zhao
>> Zhili
>> Sent: Sunday, April 28, 2024 6:55 PM
>> To: FFmpeg development discussions and patches > de...@ffmpeg.or
> On Apr 28, 2024, at 18:58, Paul B Mahol wrote:
>
> Extremely low quality filters, both in source code quality and
> performance/security and output quality should be queued for removal.
I don’t think there is any replacement for the function provided by dnn_detect,
which is very important
> On Apr 28, 2024, at 18:34, Guo, Yejun
> wrote:
>
>> -Original Message-
>> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of Zhao
>> Zhili
>> Sent: Sunday, April 28, 2024 12:42 AM
>> To: ffmpeg-devel@ffmp
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 33 +---
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 3b4de6d13f..c7716e696d 100644
--- a/libavfilter/dnn
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
---
libavfilter/dnn/dnn_backend_tf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 60f9e57fb7..3b4de6d13f 100644
--- a/libavfilter/dnn
From: Zhao Zhili
This patch trying to resolve mulitiple issues related to parameter
configuration:
Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should
be the common options of backend.
Secondly, backend options are hidden behind the scene. It's a
AV_OPT_TYPE_STRING
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
---
libavfilter/dnn/dnn_backend_openvino.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index c4b0682f11..769ba0a54b 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 1 +
libavfilter/dnn/dnn_backend_tf.c | 1 +
libavfilter/dnn/dnn_backend_torch.cpp | 1 +
libavfilter/dnn/dnn_interface.c| 26 --
libavfilter/dnn_interface.h| 1 +
5 files
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 63
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index d24591b90b..60f9e57fb7 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 47 +++---
1 file changed, 20 insertions(+), 27 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index 769ba0a54b..1acc54b791 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_torch.cpp | 31 +++
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_torch.cpp
b/libavfilter/dnn/dnn_backend_torch.cpp
index abdef1f178..818ec5b713 100644
--- a/libavfilter/dnn
From: Zhao Zhili
For code such as 'model->model = ov_model' is confusing. We can
just drop the member variable and use cast to get the subclass.
---
libavfilter/dnn/dnn_backend_openvino.c | 17 -
libavfilter/dnn/dnn_backend_tf.c | 19 +--
libavfilter/
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 1 +
libavfilter/dnn/dnn_backend_tf.c | 1 +
libavfilter/dnn/dnn_backend_torch.cpp | 1 +
libavfilter/dnn/dnn_interface.c| 26 --
libavfilter/dnn_interface.h| 1 +
5 files
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_torch.cpp | 31 +++
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_torch.cpp
b/libavfilter/dnn/dnn_backend_torch.cpp
index abdef1f178..818ec5b713 100644
--- a/libavfilter/dnn
From: Zhao Zhili
For code such as 'model->model = ov_model' is confusing. We can
just drop the member variable and use cast to get the subclass.
---
libavfilter/dnn/dnn_backend_openvino.c | 17 -
libavfilter/dnn/dnn_backend_tf.c | 19 +--
libavfilter/
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 63
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index d24591b90b..60f9e57fb7 100644
--- a/libavfilter/dnn
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
---
libavfilter/dnn/dnn_backend_tf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 60f9e57fb7..3b4de6d13f 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_openvino.c | 47 +++---
1 file changed, 20 insertions(+), 27 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index 769ba0a54b..1acc54b791 100644
--- a/libavfilter/dnn
From: Zhao Zhili
---
libavfilter/dnn/dnn_backend_tf.c | 33 +---
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 3b4de6d13f..c7716e696d 100644
--- a/libavfilter/dnn
From: Zhao Zhili
This patch trying to resolve mulitiple issues related to parameter
configuration:
Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should
be the common options of backend.
Secondly, backend options are hidden behind the scene. It's a
AV_OPT_TYPE_STRING
From: Zhao Zhili
It will be freed again by ff_dnn_uninit.
---
libavfilter/dnn/dnn_backend_openvino.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index c4b0682f11..769ba0a54b 100644
--- a/libavfilter/dnn
From: Zhao Zhili
During the refactor progress, I have found some serious issues, which
is not resolved by the patchset:
1. Tensorflow backend is broken.
I think it doesn't work since 2021 at least. For example, it destroy a
thread and create a new thread for each frame, and it destroy
From: Zhao Zhili
Avoid leaving any data inside bsf while also avoid keep bsf in
EOF state.
---
libavcodec/mediacodecenc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c
index c87a0d86c5..bbf570e7be 100644
--- a/libavcodec
> -Original Message-
> From: ffmpeg-devel On Behalf Of Niklas Haas
> Sent: 2024年4月19日 22:50
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation
>
> On Thu, 18 Apr 2024 22:53:51 +0200 Michael Niedermayer
> wrote:
> > A plugin
From: Zhao Zhili
---
fftools/cmdutils.c | 2 +-
fftools/ffmpeg_opt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 2120fc7935..a8f5c6d89b 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -311,7 +311,7 @@ static
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavcodec/mediacodecenc.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c
index 64816ccf0a..c87a0d86c5 100644
--- a/libavcodec/mediacodecenc.c
+++ b
1 - 100 of 972 matches
Mail list logo
