Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-04-03 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-29 16:58:48) > This does not change that I consider it crazy to remove the parameter > sets referencing a parameter set that is removed. What's crazy about it? A PPS is parsed for a given SPS. If the SPS is gone, then the PPS must be either removed or re-parsed

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Mark Thompson
On 29/03/2024 15:58, Andreas Rheinhardt wrote: Mark Thompson: On 29/03/2024 14:00, Andreas Rheinhardt wrote: James Almer: On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Andreas Rheinhardt
Mark Thompson: > On 29/03/2024 14:00, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > HEVCHdrParams* receives a pointer which points to a dynamically >

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Mark Thompson
On 29/03/2024 14:00, Andreas Rheinhardt wrote: James Almer: On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of James >Almer >Sent: Friday, March 29, 2024 8:46 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >On 3/28/2024 10:15 AM, tong1.wu-at-intel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of >Andreas Rheinhardt >Sent: Friday, March 29, 2024 10:03 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >Mark Thompson: >> On 28/03

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Andreas Rheinhardt
Mark Thompson: > On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu >> >> HEVCHdrParams* receives a pointer which points to a dynamically >> allocated memory block. It causes the memcmp always returning 1. >> Add a function to do the comparision. A condition is also

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Andreas Rheinhardt
James Almer: > On 3/29/2024 10:10 AM, Mark Thompson wrote: >> On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: >>> From: Tong Wu >>> >>> HEVCHdrParams* receives a pointer which points to a dynamically >>> allocated memory block. It causes the memcmp always returning 1. >>> Add a

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread James Almer
On 3/29/2024 10:10 AM, Mark Thompson wrote: On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread Mark Thompson
On 28/03/2024 13:15, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0).

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-29 Thread James Almer
On 3/28/2024 10:15 AM, tong1.wu-at-intel@ffmpeg.org wrote: From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0).

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of >Hendrik Leppkes >Sent: Thursday, March 28, 2024 5:43 PM >To: FFmpeg development discussions and patches de...@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >On Th

[FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread tong1 . wu-at-intel . com
From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Signed-off-by: Tong Wu --- libavcodec/hevc_ps.c | 20

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread Hendrik Leppkes
On Thu, Mar 28, 2024 at 10:12 AM wrote: > > From: Tong Wu > > HEVCHdrParams* receives a pointer which points to a dynamically > allocated memory block. It causes the memcmp always returning 1. > Add a function to do the comparision. A condition is also added to > avoid malloc(0). > >

[FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread tong1 . wu-at-intel . com
From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Signed-off-by: Tong Wu --- libavcodec/hevc_ps.c | 20