Hi,
On Mon, Sep 25, 2023 at 9:10 AM Timo Rothenpieler
wrote:
> lgtm
>
Pushed.
Thanks,
Kyle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
On 25.09.2023 14:18, Kyle Swanson wrote:
Hi,
On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler
wrote:
On 23.09.2023 11:50, Kyle Swanson wrote:
Hi,
On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler <
t...@rothenpieler.org>
wrote:
Or it needs to be a sub-feature of libvmaf, where if
Hi,
On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler
wrote:
> On 23.09.2023 11:50, Kyle Swanson wrote:
> > Hi,
> >
> > On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler <
> t...@rothenpieler.org>
> > wrote:
> >> Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled,
> >>
On 23.09.2023 11:50, Kyle Swanson wrote:
Hi,
On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler
wrote:
Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled,
support for CUDA is checked for, and then the vmaf_cuda filter needs to
depend on that check.
This previous patch
Hi,
On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler
wrote:
> Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled,
> support for CUDA is checked for, and then the vmaf_cuda filter needs to
> depend on that check.
This previous patch should do just that [0]. What's missing?
On 20.09.2023 22:06, Kyle Swanson wrote:
Hi,
On Mon, Sep 18, 2023 at 2:39 PM Kyle Swanson wrote:
Hi,
On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler
wrote:
On 18.09.2023 21:21, Marvin Scholz wrote:
I am far from an expert with the configure script but won't that cause
Hi,
On Mon, Sep 18, 2023 at 2:39 PM Kyle Swanson wrote:
>
> Hi,
>
> On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler
> wrote:
> > On 18.09.2023 21:21, Marvin Scholz wrote:
> > > I am far from an expert with the configure script but won't that cause
> > > --enable-libvmaf to fail when
> > >
Hi,
On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler
wrote:
> On 18.09.2023 21:21, Marvin Scholz wrote:
> > I am far from an expert with the configure script but won't that cause
> > --enable-libvmaf to fail when
> > libvmaf is built without cuda support? Which seems undesirable to me…
>
>
On 18.09.2023 21:21, Marvin Scholz wrote:
enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 2.0.0"
libvmaf.h vmaf_init
+enabled libvmaf && require_pkg_config libvmaf_cuda "libvmaf >=
2.0.0" libvmaf_cuda.h vmaf_cuda_state_init
enabled libvo_amrwbenc&& require
> enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 2.0.0"
> libvmaf.h vmaf_init
> +enabled libvmaf && require_pkg_config libvmaf_cuda "libvmaf >=
> 2.0.0" libvmaf_cuda.h vmaf_cuda_state_init
> enabled libvo_amrwbenc&& require libvo_amrwbenc vo-amrwbenc/enc_if.h
Hi,
On Fri, Sep 15, 2023 at 3:34 PM Timo Rothenpieler wrote:
> I don't see why it wouldn't work. It doesn't matter what it is, it's
> just the name of the dependency.
Patch attached.
Thanks,
Kyle
0001-avfilter-add-libvmaf_cuda.patch
Description: Binary data
On 15.09.2023 22:31, Kyle Swanson wrote:
Hi,
On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler
wrote:
This looks more complicated than necessary to me.
My idea would have been to change, in the previous original patch,
> libvmaf_cuda_filter_deps="libvmaf ffnvcodec"
to
>
Hi,
On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler
wrote:
> This looks more complicated than necessary to me.
>
> My idea would have been to change, in the previous original patch,
>
> > libvmaf_cuda_filter_deps="libvmaf ffnvcodec"
>
> to
>
> > libvmaf_cuda_filter_deps="libvmaf
On 14.09.2023 20:59, Kyle Swanson wrote:
Problem was slightly different, there is no `libvmaf_cuda`, just
`libvmaf` built with the cuda apis optionally enabled. `./configure`
is fixed now and I've tested all the possible combinations, updated
patch attached.
This looks more complicated than
Hi,
On Mon, Sep 11, 2023 at 11:51 AM Timo Rothenpieler
wrote:
>
> On 11.09.2023 19:53, Kyle Swanson wrote:
> > Hi,
> >
> > On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote:
> >> I'll merge this in a few days.
> >
> > Not merged yet because I noticed a bug in the configure script.
> > Setting
On 11.09.2023 19:53, Kyle Swanson wrote:
Hi,
On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote:
I'll merge this in a few days.
Not merged yet because I noticed a bug in the configure script.
Setting only `--enable-libvmaf` will enable both `libvmaf` and
`libvmaf_cuda`. Anyone familiar with
Hi,
On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote:
> I'll merge this in a few days.
Not merged yet because I noticed a bug in the configure script.
Setting only `--enable-libvmaf` will enable both `libvmaf` and
`libvmaf_cuda`. Anyone familiar with the configure script know why
this is
Hi,
On Thu, Aug 31, 2023 at 11:39 AM Kyle Swanson wrote:
> On Wed, Aug 30, 2023 at 9:44 AM Kyle Swanson wrote:
> > Fixed in the attached patch.
>
> Any other reviews, or is this one OK to merge now?
I'll merge this in a few days.
Thanks,
Kyle
___
Hi,
On Wed, Aug 30, 2023 at 9:44 AM Kyle Swanson wrote:
> Fixed in the attached patch.
Any other reviews, or is this one OK to merge now?
Thanks,
Kyle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Hi,
On Tue, Aug 29, 2023 at 3:13 PM Andreas Rheinhardt
wrote:
> The CONFIG_* variables are always defined; you need to check via "#if",
> not "#ifdef".
Fixed in the attached patch.
Thanks,
Kyle
0001-avfilter-add-libvmaf_cuda.patch
Description: Binary data
Kyle Swanson:
> +#ifdef CONFIG_LIBVMAF_CUDA
> +#include
> +
> +#include "libavutil/hwcontext.h"
> +#include "libavutil/hwcontext_cuda_internal.h"
> +#endif
> +
The CONFIG_* variables are always defined; you need to check via "#if",
not "#ifdef".
- Andreas
Hi,
On Mon, Aug 28, 2023 at 1:16 PM Kyle Swanson wrote:
> Ah, you're right, I think ffnvcodec is the right option to use, I'll
> switch this in the next patch version.
Patch attached.
Thanks,
Kyle
0001-avfilter-add-libvmaf_cuda.patch
Description: Binary data
Hi,
On Mon, Aug 28, 2023 at 11:59 AM Timo Rothenpieler
wrote:
> > +libvmaf_cuda_filter_deps="libvmaf cuda_nvcc"
>
> Does this really depend on nvcc?
> Does it not work with only ffnvcodec?
>
Ah, you're right, I think ffnvcodec is the right option to use, I'll
switch this in the next patch
From f6f0afffadfc5fae97b11b0feb7c1d740b7c86ab Mon Sep 17 00:00:00 2001
From: Kyle Swanson
Date: Mon, 28 Aug 2023 11:49:34 -0700
Subject: [PATCH] avfilter: add libvmaf_cuda
---
configure| 4 +
doc/filters.texi | 26 +
libavfilter/Makefile | 1 +
On Mon, Aug 28, 2023 at 8:54 PM Kyle Swanson wrote:
> Hi,
>
> Added filter docs, new patch attached. Unless there are any other
> reviews I will plan on pushing this in a few days.
>
Only after at least two main devs reviews and agree to merge.
New policy.
> Thanks,
> Kyle
>
Hi,
Added filter docs, new patch attached. Unless there are any other
reviews I will plan on pushing this in a few days.
Thanks,
Kyle
0001-avfilter-add-libvmaf_cuda.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Hi,
Thank you Timo for the review. Took your suggestions, updated patch attached.
Thanks,
Kyle
0001-avfilter-add-libvmaf_cuda.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
From 2665b7ddaefe6739bfeef4573183981582bdb995 Mon Sep 17 00:00:00 2001
From: Kyle Swanson
Date: Mon, 7 Aug 2023 10:38:12 -0700
Subject: [PATCH] avfilter: add libvmaf_cuda
---
configure| 4 +
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
Hi,
On Mon, Aug 7, 2023 at 10:50 AM Kyle Swanson wrote:
> Adds the new avfilter `libvmaf_cuda`, integrating the new vmaf_cuda_*
> apis in libvmaf. Patch attached.
Anyone interested in reviewing this? Would be appreciated.
Thanks,
Kyle
___
Hi,
Adds the new avfilter `libvmaf_cuda`, integrating the new vmaf_cuda_*
apis in libvmaf. Patch attached.
Thanks,
Kyle
0001-avfilter-add-libvmaf_cuda.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
30 matches
Mail list logo
