[FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-12-03 Thread Lynne
This is a convenience function, which is required to be called by decoders needing to skip samples every time. It automatically creates and increments side data. This function is a simplified version of an earlier patch. It is only able to add additional delay, rather than insert or override any.

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Lynne
Nov 5, 2023, 00:02 by mar...@martin.st: > Hi, > > Just following up on this - I'm sorry I haven't been able to look at the > proposed patchset myself quite in detail yet. > > My prime concern is about the requests to have this merged into the upcoming > 6.1 release; that's way too soon IMO. > >

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Martin Storsjö
Hi, Just following up on this - I'm sorry I haven't been able to look at the proposed patchset myself quite in detail yet. My prime concern is about the requests to have this merged into the upcoming 6.1 release; that's way too soon IMO. These patches do change aspects of how these things b

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Lynne
Nov 4, 2023, 17:22 by derek.buitenh...@gmail.com: > Hi, > > I'm going to opine a bit here, and also comment on the mov/MP4 patch[0] that > accompanies > this set. > > This is for both historical purposes, and to distill IRC logs into something > more > digestible for others on the list to gain c

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2023 at 04:22:11PM +, Derek Buitenhuis wrote: [...] > I am almost certain I missed even more nuance, and hopefully Martin or Anton > can chime in, or I remember more. > > But also, given all of this, I think we need to deeply consider how we > approach this, so we don't end u

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Derek Buitenhuis
On 11/4/2023 4:22 PM, Derek Buitenhuis wrote: > the sample duration of the last packet in the stts box. Pre-roll is > store in the sgpb Bah. Please try and ignore my various typos of 'sgpd'. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Derek Buitenhuis
Hi, I'm going to opine a bit here, and also comment on the mov/MP4 patch[0] that accompanies this set. This is for both historical purposes, and to distill IRC logs into something more digestible for others on the list to gain context on the issue, so apologies for re-treading ground. On 10/30

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Anton Khirnov
Quoting Lynne (2023-10-30 06:09:28) > This is a convenience function, which is required to be called by decoders > needing to skip samples every time. > It automatically creates and increments side data. > > The idea is to get rid of skip_samples eventually and replace it with this > function. >

[FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-10-29 Thread Lynne
This is a convenience function, which is required to be called by decoders needing to skip samples every time. It automatically creates and increments side data. The idea is to get rid of skip_samples eventually and replace it with this function. Patch attached. >From 41dfcbbacfa9232d2308d0229dc