Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

2024-05-27 Thread Anton Khirnov
Quoting Anton Khirnov (2024-05-27 09:51:49) > I don't like modifying OptionsContext in its consumers (it's const for a > reason), and it's probably not even necessary - if the semantics of the > option is "override demuxer-reported channel layout", then you can just > override the demuxer-reported

Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

2024-05-27 Thread Anton Khirnov
Quoting Marton Balint (2024-05-18 18:11:12) > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > index cba63dab5f..6e23079ceb 100644 > --- a/fftools/ffmpeg_demux.c > +++ b/fftools/ffmpeg_demux.c > @@ -1524,6 +1524,33 @@ static Demuxer *demux_alloc(void) > return d; > } > >

Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

2024-05-18 Thread Michael Niedermayer
On Sat, May 18, 2024 at 06:11:12PM +0200, Marton Balint wrote: > The code only set the channel layout of the AVFormatContext, so the user could > not override the channel layout if the demuxer did not have such parameter. > Let's set the specified channel layouts as codec options as well. > >

[FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

2024-05-18 Thread Marton Balint
The code only set the channel layout of the AVFormatContext, so the user could not override the channel layout if the demuxer did not have such parameter. Let's set the specified channel layouts as codec options as well. Fixes ticket #11016. A regression since