Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-09 Thread Kevin Wheatley
On Fri, Feb 9, 2024 at 11:22 AM Dominik 'Rathann' Mierzejewski wrote: > Even so, a C17-supporting compiler (gcc 11.2.1) is available for CentOS 7 > in the devtoolset-11-gcc package (from > http://mirror.centos.org/centos/7/sclo/x86_64/rh/). As a 'User' of the FFmpeg project, we have a lot of

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-09 Thread Dominik 'Rathann' Mierzejewski
On Monday, 05 February 2024 at 21:53, Niklas Haas wrote: > On Mon, 05 Feb 2024 15:13:22 -0500 Devin Heitmueller > wrote: > > On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > > > > > It should be available in all relevant modern compilers and will > > > allow us to use features like

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-08 Thread Lynne
Feb 8, 2024, 20:05 by jamr...@gmail.com: > On 2/8/2024 3:52 PM, Sean McGovern wrote: > >> Hi developers, >> >> On Wed, Feb 7, 2024, 23:30 Jean-Baptiste Kempf wrote: >> >>> Hello, >>> >>> On Thu, 8 Feb 2024, at 01:36, Cosmin Stejerean via ffmpeg-devel wrote: >>> > There were simply no

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-08 Thread James Almer
On 2/8/2024 3:52 PM, Sean McGovern wrote: Hi developers, On Wed, Feb 7, 2024, 23:30 Jean-Baptiste Kempf wrote: Hello, On Thu, 8 Feb 2024, at 01:36, Cosmin Stejerean via ffmpeg-devel wrote: There were simply no objections to moving to C11. The C17 plan came about later because it has

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-08 Thread Sean McGovern
Hi developers, On Wed, Feb 7, 2024, 23:30 Jean-Baptiste Kempf wrote: > Hello, > > On Thu, 8 Feb 2024, at 01:36, Cosmin Stejerean via ffmpeg-devel wrote: > >> There were simply no objections to moving to C11. > >> The C17 plan came about later because it has important bugfixes. > >> It doesn't

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-08 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > > > Le 7 février 2024 23:19:41 GMT+02:00, James Almer a écrit  > : >> On 2/7/2024 6:10 PM, Cosmin Stejerean via ffmpeg-devel wrote: >>> >>> On Feb 7, 2024, at 11:27 AM, Lynne wrote: >> >> As a compromise, we could start requiring C11 now, and C17 in

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Rémi Denis-Courmont
Le 7 février 2024 23:19:41 GMT+02:00, James Almer a écrit : >On 2/7/2024 6:10 PM, Cosmin Stejerean via ffmpeg-devel wrote: >> >> >>> On Feb 7, 2024, at 11:27 AM, Lynne wrote: >>> > > As a compromise, we could start requiring C11 now, and C17 in 7.1. > Or does anyone still care

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Jean-Baptiste Kempf
Hello, On Thu, 8 Feb 2024, at 01:36, Cosmin Stejerean via ffmpeg-devel wrote: >> There were simply no objections to moving to C11. >> The C17 plan came about later because it has important bugfixes. >> It doesn't really matter as compilers backported the new behaviour to C11 >> (or rather, they

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 7, 2024, at 1:48 PM, Lynne wrote: > > Feb 7, 2024, 22:11 by ffmpeg-devel@ffmpeg.org: > >> >> >>> On Feb 7, 2024, at 11:27 AM, Lynne wrote: >>> > > As a compromise, we could start requiring C11 now, and C17 in 7.1. > Or does anyone still care about compilers without

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Lynne
Feb 7, 2024, 22:11 by ffmpeg-devel@ffmpeg.org: > > >> On Feb 7, 2024, at 11:27 AM, Lynne wrote: >> As a compromise, we could start requiring C11 now, and C17 in 7.1. Or does anyone still care about compilers without even c11 support? >>> >>> How about C11 now and C17 in a

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread James Almer
On 2/7/2024 6:10 PM, Cosmin Stejerean via ffmpeg-devel wrote: On Feb 7, 2024, at 11:27 AM, Lynne wrote: As a compromise, we could start requiring C11 now, and C17 in 7.1. Or does anyone still care about compilers without even c11 support? How about C11 now and C17 in a year with ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 7, 2024, at 11:27 AM, Lynne wrote: > >>> >>> As a compromise, we could start requiring C11 now, and C17 in 7.1. >>> Or does anyone still care about compilers without even c11 support? >>> >> >> How about C11 now and C17 in a year with ffmpeg 8? >> > > Do you have setups and

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Lynne
Feb 7, 2024, 19:52 by ffmpeg-devel@ffmpeg.org: > > >> On Feb 7, 2024, at 1:55 AM, Anton Khirnov wrote: >> >> As a compromise, we could start requiring C11 now, and C17 in 7.1. >> Or does anyone still care about compilers without even c11 support? >> > > How about C11 now and C17 in a year with

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 7, 2024, at 1:55 AM, Anton Khirnov wrote: > > As a compromise, we could start requiring C11 now, and C17 in 7.1. > Or does anyone still care about compilers without even c11 support? How about C11 now and C17 in a year with ffmpeg 8? - Cosmin

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Anton Khirnov
Quoting Devin Heitmueller (2024-02-07 17:15:30) > On Wed, Feb 7, 2024 at 4:50 AM Anton Khirnov wrote: > > Not to mention anonymous unions were standardized in C11 and widely > > available for many years (possibly decades) before that, so it's hardly > > a 'latest whizbang feature'. > > Yeah, I

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Devin Heitmueller
Hello Anton, On Wed, Feb 7, 2024 at 4:50 AM Anton Khirnov wrote: > > Now I know that developers *LOVE* to use the latest whizbang language > > features, > > Could we please not have these kinds of caricatures in here? It's not > helpful. Permit me to rephrase: In my 25+ years of experience as

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-05 21:45:10) > On Mon, Feb 05, 2024 at 09:31:45PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-02-05 21:27:27) > > > please wait a bit with applying this so we understand better what it > > > affects > > > > Sure, but I'd like it to go in

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Anton Khirnov
Quoting Niklas Haas (2024-02-05 21:55:04) > On Mon, 05 Feb 2024 21:31:45 +0100 Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-02-05 21:27:27) > > > please wait a bit with applying this so we understand better what it > > > affects > > > > Sure, but I'd like it to go in before 7.0. >

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Anton Khirnov
Quoting Devin Heitmueller (2024-02-05 21:40:43) > On Mon, Feb 5, 2024 at 3:31 PM Anton Khirnov wrote: > > > > Quoting Devin Heitmueller (2024-02-05 21:13:22) > > > On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > > > > > > > It should be available in all relevant modern compilers and will

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-06 Thread Lynne
Feb 6, 2024, 07:51 by dcni...@gmail.com: > On Mon, Feb 5, 2024 at 8:59 PM Anton Khirnov wrote: > >> diff --git a/configure b/configure >> index f72533b7d2..1bb9e23f19 100755 >> --- a/configure >> +++ b/configure >> @@ -5517,21 +5517,20 @@ if test "$?" != 0; then >> die "C compiler test failed."

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Diederick C. Niehorster
On Mon, Feb 5, 2024 at 8:59 PM Anton Khirnov wrote: > diff --git a/configure b/configure > index f72533b7d2..1bb9e23f19 100755 > --- a/configure > +++ b/configure > @@ -5517,21 +5517,20 @@ if test "$?" != 0; then > die "C compiler test failed." > fi > > -add_cppflags -D_ISOC99_SOURCE >

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Stefano Sabatini
On date Monday 2024-02-05 21:55:04 +0100, Niklas Haas wrote: > On Mon, 05 Feb 2024 21:31:45 +0100 Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-02-05 21:27:27) > > > please wait a bit with applying this so we understand better what it > > > affects > > > > Sure, but I'd like it to

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Niklas Haas
On Mon, 05 Feb 2024 21:31:45 +0100 Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-02-05 21:27:27) > > please wait a bit with applying this so we understand better what it affects > > Sure, but I'd like it to go in before 7.0. What is the advantage to having it in 7.0?

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Niklas Haas
On Mon, 05 Feb 2024 15:13:22 -0500 Devin Heitmueller wrote: > On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > > > It should be available in all relevant modern compilers and will allow > > us to use features like anonymous unions. > > Is everybody on board with the implications for

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Michael Niedermayer
On Mon, Feb 05, 2024 at 09:31:45PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-02-05 21:27:27) > > please wait a bit with applying this so we understand better what it affects > > Sure, but I'd like it to go in before 7.0. This seems to break my stuff I will upgarde my stuff

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Devin Heitmueller
On Mon, Feb 5, 2024 at 3:31 PM Anton Khirnov wrote: > > Quoting Devin Heitmueller (2024-02-05 21:13:22) > > On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > > > > > It should be available in all relevant modern compilers and will allow > > > us to use features like anonymous unions. > > >

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread James Almer
On 2/5/2024 5:30 PM, Anton Khirnov wrote: Quoting Devin Heitmueller (2024-02-05 21:13:22) On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: It should be available in all relevant modern compilers and will allow us to use features like anonymous unions. Is everybody on board with the

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-05 21:27:27) > please wait a bit with applying this so we understand better what it affects Sure, but I'd like it to go in before 7.0. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Anton Khirnov
Quoting Devin Heitmueller (2024-02-05 21:13:22) > On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > > > It should be available in all relevant modern compilers and will allow > > us to use features like anonymous unions. > > Is everybody on board with the implications for this patch in

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Michael Niedermayer
On Mon, Feb 05, 2024 at 08:54:40PM +0100, Anton Khirnov wrote: > It should be available in all relevant modern compilers and will allow > us to use features like anonymous unions. > > Note that stdatomic.h is still emulated on MSVC, as current versions > require the /experimental:c11atomics, and

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Lynne
Feb 5, 2024, 20:59 by an...@khirnov.net: > It should be available in all relevant modern compilers and will allow > us to use features like anonymous unions. > > Note that stdatomic.h is still emulated on MSVC, as current versions > require the /experimental:c11atomics, and do not support >

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Devin Heitmueller
On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > It should be available in all relevant modern compilers and will allow > us to use features like anonymous unions. Is everybody on board with the implications for this patch in terms of platforms we allow building on? For example, the gcc

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Anton Khirnov
Quoting James Almer (2024-02-05 21:12:00) > Does SunCC support this? Does anyone use SunCC at all? I do not know, but if it doesn't then we can drop it. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread James Almer
On 2/5/2024 4:54 PM, Anton Khirnov wrote: It should be available in all relevant modern compilers and will allow us to use features like anonymous unions. Note that stdatomic.h is still emulated on MSVC, as current versions require the /experimental:c11atomics, and do not support

[FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Anton Khirnov
It should be available in all relevant modern compilers and will allow us to use features like anonymous unions. Note that stdatomic.h is still emulated on MSVC, as current versions require the /experimental:c11atomics, and do not support ATOMIC_VAR_INIT() anyway. --- Now moving to C17 rather