Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-05 Thread Michael Niedermayer
On Sat, May 04, 2024 at 10:54:59PM -0300, James Almer wrote: > On 5/4/2024 10:45 PM, Michael Niedermayer wrote: > > On Sat, May 04, 2024 at 06:02:25PM -0300, James Almer wrote: > > > > > > > > > On 5/4/2024 5:58 PM, Michael Niedermayer wrote: > > > > On Sat, May 04, 2024 at 12:16:00PM -0300,

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread James Almer
On 5/4/2024 10:45 PM, Michael Niedermayer wrote: On Sat, May 04, 2024 at 06:02:25PM -0300, James Almer wrote: On 5/4/2024 5:58 PM, Michael Niedermayer wrote: On Sat, May 04, 2024 at 12:16:00PM -0300, James Almer wrote: On 5/4/2024 5:34 AM, Marton Balint wrote: On Thu, 2 May 2024, James

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread Michael Niedermayer
On Sat, May 04, 2024 at 06:02:25PM -0300, James Almer wrote: > > > On 5/4/2024 5:58 PM, Michael Niedermayer wrote: > > On Sat, May 04, 2024 at 12:16:00PM -0300, James Almer wrote: > > > On 5/4/2024 5:34 AM, Marton Balint wrote: > > > > > > > > > > > > On Thu, 2 May 2024, James Almer wrote: > >

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread James Almer
On 5/4/2024 5:58 PM, Michael Niedermayer wrote: On Sat, May 04, 2024 at 12:16:00PM -0300, James Almer wrote: On 5/4/2024 5:34 AM, Marton Balint wrote: On Thu, 2 May 2024, James Almer wrote: On 5/2/2024 6:23 PM, Marton Balint wrote:  On Wed, 1 May 2024, Michael Niedermayer wrote:  

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread Michael Niedermayer
On Sat, May 04, 2024 at 12:16:00PM -0300, James Almer wrote: > On 5/4/2024 5:34 AM, Marton Balint wrote: > > > > > > On Thu, 2 May 2024, James Almer wrote: > > > > > On 5/2/2024 6:23 PM, Marton Balint wrote: > > > > > > > > > > > >  On Wed, 1 May 2024, Michael Niedermayer wrote: > > > > > >

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread Marton Balint
On Sat, 4 May 2024, James Almer wrote: On 5/4/2024 5:34 AM, Marton Balint wrote: On Thu, 2 May 2024, James Almer wrote: On 5/2/2024 6:23 PM, Marton Balint wrote:  On Wed, 1 May 2024, Michael Niedermayer wrote:  This allows detecting issues in side data related code, same as what

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread James Almer
On 5/4/2024 5:34 AM, Marton Balint wrote: On Thu, 2 May 2024, James Almer wrote: On 5/2/2024 6:23 PM, Marton Balint wrote:  On Wed, 1 May 2024, Michael Niedermayer wrote:  This allows detecting issues in side data related code, same as what  framecrc does for before already for packet

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-04 Thread Marton Balint
On Thu, 2 May 2024, James Almer wrote: On 5/2/2024 6:23 PM, Marton Balint wrote: On Wed, 1 May 2024, Michael Niedermayer wrote: This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. This basically reverts

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-02 Thread Michael Niedermayer
Hi On Thu, May 02, 2024 at 11:23:13PM +0200, Marton Balint wrote: [...] > surely some users depend on it behaving in a certain > way... who ? I dont think you should assume something without evidence especially for framecrc, which isnt that usefull except for testing the output is changed vs

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

2024-05-02 Thread James Almer
On 5/2/2024 6:23 PM, Marton Balint wrote: On Wed, 1 May 2024, Michael Niedermayer wrote: This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. This basically reverts c6ae560a18d67b9ddaa25a0338b7fb55e3312e57. Can you