Re: [FFmpeg-devel] [RFC] Channels

2024-03-28 Thread Tomas Härdin
fre 2024-03-22 klockan 03:25 +0100 skrev Michael Niedermayer: > Hi all > > we have code like > st->codecpar->ch_layout.nb_channels = avio_rb32(pb); > > and then somewhere there is some code that uses this by first > allocating > an array and that then hits OOM > (it was this here: >     map =

Re: [FFmpeg-devel] [RFC] Channels

2024-03-28 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-27 22:54:14) > On Fri, Mar 22, 2024 at 11:29:31AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-03-22 03:25:25) > [...] > > > alternative is "wont fix" for all such cases, > > > > IMO it's not, in general, a bug, so EWONTFIX is the

Re: [FFmpeg-devel] [RFC] Channels

2024-03-27 Thread Michael Niedermayer
On Fri, Mar 22, 2024 at 11:29:31AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-22 03:25:25) [...] > > alternative is "wont fix" for all such cases, > > IMO it's not, in general, a bug, so EWONTFIX is the appropriate > response. If the user does not want us to do arbitrarily

Re: [FFmpeg-devel] [RFC] Channels

2024-03-22 Thread Michael Niedermayer
On Thu, Mar 21, 2024 at 11:59:17PM -0300, James Almer wrote: > On 3/21/2024 11:25 PM, Michael Niedermayer wrote: > > Hi all > > > > we have code like > > st->codecpar->ch_layout.nb_channels = avio_rb32(pb); > > > > and then somewhere there is some code that uses this by first allocating > > an

Re: [FFmpeg-devel] [RFC] Channels

2024-03-22 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-22 03:25:25) > Hi all > > we have code like > st->codecpar->ch_layout.nb_channels = avio_rb32(pb); > > and then somewhere there is some code that uses this by first allocating > an array and that then hits OOM > (it was this here: > map =

Re: [FFmpeg-devel] [RFC] Channels

2024-03-21 Thread James Almer
On 3/21/2024 11:25 PM, Michael Niedermayer wrote: Hi all we have code like st->codecpar->ch_layout.nb_channels = avio_rb32(pb); and then somewhere there is some code that uses this by first allocating an array and that then hits OOM (it was this here: map = av_calloc(nb_channels,

[FFmpeg-devel] [RFC] Channels

2024-03-21 Thread Michael Niedermayer
Hi all we have code like st->codecpar->ch_layout.nb_channels = avio_rb32(pb); and then somewhere there is some code that uses this by first allocating an array and that then hits OOM (it was this here: map = av_calloc(nb_channels, sizeof(*channel_layout->u.map));) is anyone against adding a