Re: [FFmpeg-devel] [PATCH v27 2/2] avcodec/evc_decoder: Provided support for EVC decoder

2023-09-10 Thread James Almer
On 8/16/2023 8:11 AM, Dawid Kozinski wrote: +/** + * Initialize decoder + * Create a decoder instance and allocate all the needed resources + * + * @param avctx codec context + * @return 0 on success, negative error code on failure + */ +static av_cold int libxevd_init(AVCodecContext *avctx) +{

Re: [FFmpeg-devel] Trac spam

2023-09-10 Thread Michael Niedermayer
On Sun, Sep 10, 2023 at 11:20:23AM +0200, Michael Koch wrote: > new spammer in ticket 2104 i added you to the spam fighters group that gives you the following powers: SPAM_CHECKREPORTS SPAM_MONITOR SPAM_REPORT SPAM_TRAIN SPAM_USER TICKET_EDIT_COMMENT WIKI_ADMIN permissions sadly are not

[FFmpeg-devel] [PATCH] avcodec/8bps: switch to planar RGB formats

2023-09-10 Thread Paul B Mahol
Attached. From 8ee65119916a849a37b39b3a8c12ca8af3b456c5 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 10 Sep 2023 22:42:11 +0200 Subject: [PATCH 2/2] avcodec/8bps: always decode to planar formats directly Signed-off-by: Paul B Mahol --- libavcodec/8bps.c | 60

Re: [FFmpeg-devel] [PATCH v2 2/2] hevc_ps: fix fixed_rate check

2023-09-10 Thread Derek Buitenhuis
On 9/10/2023 4:32 PM, Lynne wrote: > Both patches lgtm Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

[FFmpeg-devel] [PATCH] avfilter/x86/af_afir: add FMA3 SIMD

2023-09-10 Thread Paul B Mahol
Attached. From 7735a84fd0fdae731955f50bddba8dfef395713b Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 10 Sep 2023 19:25:20 +0200 Subject: [PATCH] avfilter/x86/af_afir: add FMA3 SIMD Signed-off-by: Paul B Mahol --- libavfilter/x86/af_afir.asm| 27 +++

Re: [FFmpeg-devel] [PATCH 01/21] avformat/avio: Don't use incompatible function pointer type for call

2023-09-10 Thread Andreas Rheinhardt
Marton Balint: > > > On Sun, 10 Sep 2023, Andreas Rheinhardt wrote: > >> Marton Balint: >>> >>> >>> On Sat, 9 Sep 2023, Tomas Härdin wrote: >>> fre 2023-09-08 klockan 22:38 +0200 skrev Marton Balint: > > > On Thu, 7 Sep 2023, Andreas Rheinhardt wrote: > > > It is

Re: [FFmpeg-devel] [PATCH 01/21] avformat/avio: Don't use incompatible function pointer type for call

2023-09-10 Thread Marton Balint
On Sun, 10 Sep 2023, Andreas Rheinhardt wrote: Marton Balint: On Sat, 9 Sep 2023, Tomas Härdin wrote: fre 2023-09-08 klockan 22:38 +0200 skrev Marton Balint: On Thu, 7 Sep 2023, Andreas Rheinhardt wrote: > It is undefined behaviour even in cases where it works > (it works because it

Re: [FFmpeg-devel] [PATCH 3/7] proresdec2: use VLC for level instead of EC switch

2023-09-10 Thread Christophe Gisquet
Hello Le dim. 10 sept. 2023 à 17:40, Andreas Rheinhardt a écrit : > Another solution would be to use void* instead of GetBitContext* in the > header and in the implementation and then convert this void* to > GetBitContext* in the function. The forward declaration will be enough. > I do not

Re: [FFmpeg-devel] [PATCH 3/7] proresdec2: use VLC for level instead of EC switch

2023-09-10 Thread Andreas Rheinhardt
Christophe Gisquet: > Hello, > > Le ven. 8 sept. 2023 à 11:57, Andreas Rheinhardt > a écrit : +#define CACHED_BITSTREAM_READER 1 >>> >>> This should be in the commit switching to the cached bitstream reader. >> >> Correction: This header is included in videotoolbox.c and there is other >>

Re: [FFmpeg-devel] [PATCH v2 2/2] hevc_ps: fix fixed_rate check

2023-09-10 Thread Lynne
Sep 10, 2023, 17:26 by llyyr.pub...@gmail.com: > Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb > > Since fc429d785e9e24c5520ce716d4bc3b5547e581eb splits the fixed_rate > flag into general and within_cvs, check for both. > --- > libavcodec/hevc_ps.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 3/7] proresdec2: use VLC for level instead of EC switch

2023-09-10 Thread Christophe Gisquet
Hello, Le ven. 8 sept. 2023 à 11:57, Andreas Rheinhardt a écrit : > >> +#define CACHED_BITSTREAM_READER 1 > > > > This should be in the commit switching to the cached bitstream reader. > > Correction: This header is included in videotoolbox.c and there is other > stuff that also includes

[FFmpeg-devel] [PATCH v2 2/2] hevc_ps: fix fixed_rate check

2023-09-10 Thread llyyr
Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb Since fc429d785e9e24c5520ce716d4bc3b5547e581eb splits the fixed_rate flag into general and within_cvs, check for both. --- libavcodec/hevc_ps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc_ps.c

[FFmpeg-devel] [PATCH v2 1/2] hevc_ps: fix cpb_cnt_minus1 initialization

2023-09-10 Thread llyyr
Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb cpb_cnt used to be initialized to 1 before fc429d785e9e24c5520ce716d4bc3b5547e581eb so cpb_cnt_minus1 should be initialized to 0. Also add +1 to the decode_sublayer_hrd call to account for the change to the offset --- libavcodec/hevc_ps.c | 6

Re: [FFmpeg-devel] A build error occurs when adding vaporsynth to ffmpeg.

2023-09-10 Thread あんこ
Thank you for quick response! I can now build successfully. 2023年9月10日(日) 23:50 Andreas Rheinhardt : > あんこ: > > There is a problem with commit 0c6e5f3. Missing changes in > > libavformat/vapoursynth.c. > > Thanks for the info (and sorry for the inconvenience). Does >

Re: [FFmpeg-devel] [PATCH] hevc_ps: fix cpb_cnt_minus1 initialization and fixed_rate check

2023-09-10 Thread Derek Buitenhuis
On 9/10/2023 4:00 PM, llyyr wrote: > Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb > > cpb_cnt was initialized to 1 before > fc429d785e9e24c5520ce716d4bc3b5547e581eb, so cpb_cnt_minus1 should be > initialized to 0 instead of 1. > > Since we split fixed_rate into a general flag and a

[FFmpeg-devel] [PATCH] hevc_ps: fix cpb_cnt_minus1 initialization and fixed_rate check

2023-09-10 Thread llyyr
Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb cpb_cnt was initialized to 1 before fc429d785e9e24c5520ce716d4bc3b5547e581eb, so cpb_cnt_minus1 should be initialized to 0 instead of 1. Since we split fixed_rate into a general flag and a within_cvs_flag now, check for both in conditional. ---

Re: [FFmpeg-devel] A build error occurs when adding vaporsynth to ffmpeg.

2023-09-10 Thread Andreas Rheinhardt
あんこ: > There is a problem with commit 0c6e5f3. Missing changes in > libavformat/vapoursynth.c. Thanks for the info (and sorry for the inconvenience). Does http://ffmpeg.org/pipermail/ffmpeg-devel/2023-September/314262.html fix it? - Andreas ___

[FFmpeg-devel] [PATCH] avformat/vapoursynth, avdevice/decklink_enc: Add missing includes

2023-09-10 Thread Andreas Rheinhardt
Broken in 0c6e5f321bf5c4054e8b98232692465b342b42b4. Signed-off-by: Andreas Rheinhardt --- libavdevice/decklink_enc.cpp | 1 + libavformat/vapoursynth.c| 1 + 2 files changed, 2 insertions(+) diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index

[FFmpeg-devel] A build error occurs when adding vaporsynth to ffmpeg.

2023-09-10 Thread あんこ
There is a problem with commit 0c6e5f3. Missing changes in libavformat/vapoursynth.c. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avcodec/cscd: Check for CamStudio Lossless Codec 1.0 behavior in end check

2023-09-10 Thread Michael Niedermayer
On Wed, Mar 08, 2023 at 11:43:38PM +0100, Michael Niedermayer wrote: > Alternatively the check could be simply made more tolerant > Fixes: Ticket10227 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/cscd.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) will apply [...]

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Paul B Mahol
On Sun, Sep 10, 2023 at 3:13 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Sun, Sep 10, 2023 at 2:54 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Sun, Sep 10, 2023 at 2:18 PM Andreas Rheinhardt < > >>>

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Sun, Sep 10, 2023 at 2:54 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Sun, Sep 10, 2023 at 2:18 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > On Sun, Sep 10, 2023 at 2:06 PM Andreas

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Paul B Mahol
On Sun, Sep 10, 2023 at 2:54 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Sun, Sep 10, 2023 at 2:18 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Sun, Sep 10, 2023 at 2:06 PM Andreas Rheinhardt < > >>>

[FFmpeg-devel] [PATCH 3/3] avcodec/thread: Remove ff_thread_get_format define

2023-09-10 Thread Andreas Rheinhardt
Unnecessary since FF_API_THREAD_SAFE_CALLBACKS is no more. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1dec.c | 2 +- libavcodec/h264_slice.c | 2 +- libavcodec/hevcdec.c| 2 +- libavcodec/mpeg12dec.c | 2 +- libavcodec/proresdec2.c | 2 +- libavcodec/thread.h | 2 --

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Sun, Sep 10, 2023 at 2:18 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Sun, Sep 10, 2023 at 2:06 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > On Sun, Sep 10, 2023 at 1:59 PM Andreas

[FFmpeg-devel] [PATCH 2/3] avcodec/av1dec: Don't rely on AV_PIX_FMT_NONE == -1

2023-09-10 Thread Andreas Rheinhardt
Since fb548fba04193a418f118d21b261ba05db4f480b, this return -1 is in a function returning enum AVPixelFormat whose caller checks for AV_PIX_FMT_NONE for failure. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Pass AVCodecContext* as logctx in get_sw_pixel_format()

2023-09-10 Thread Andreas Rheinhardt
It indicates to the reader that said function does not modify any state. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 8f9c2dfefb..8f6c4f732e 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Paul B Mahol
On Sun, Sep 10, 2023 at 2:18 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Sun, Sep 10, 2023 at 2:06 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Sun, Sep 10, 2023 at 1:59 PM Andreas Rheinhardt < > >>>

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Sun, Sep 10, 2023 at 2:06 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Sun, Sep 10, 2023 at 1:59 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > On Wed, Sep 6, 2023 at 1:30 PM Andreas

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Paul B Mahol
On Sun, Sep 10, 2023 at 2:06 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Sun, Sep 10, 2023 at 1:59 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Wed, Sep 6, 2023 at 1:30 PM Andreas Rheinhardt < > >>>

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Sun, Sep 10, 2023 at 1:59 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Wed, Sep 6, 2023 at 1:30 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > On Wed, Sep 6, 2023 at 11:26 AM Andreas

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Paul B Mahol
On Sun, Sep 10, 2023 at 1:59 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Wed, Sep 6, 2023 at 1:30 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Wed, Sep 6, 2023 at 11:26 AM Andreas Rheinhardt < > >>>

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Wed, Sep 6, 2023 at 1:30 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Wed, Sep 6, 2023 at 11:26 AM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > > +chunk_type = avio_rb32(pb);

Re: [FFmpeg-devel] [PATCH] avformat: add CRI USM demuxer

2023-09-10 Thread Paul B Mahol
New version attached: - fixed VP9 demuxing - added support for alpha streams - added support for subtitle streams - numerous fixes and improvements Can't get seeking to behave correctly with ADPCM_ADX audio streams. Once one seek to start of file audio is no longer demuxed and video packets

Re: [FFmpeg-devel] [PATCH v2 16/22] avutil/imgutils: Constify some pointees

2023-09-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is done immediately without waiting for the next major bump > just as in 9546b3a1cbcd94e9107f85c8f1d2175efc6cf083 and > 4eaaa38d3dfb8863a62f3646a62e4098b1c078d5. > > Signed-off-by: Andreas Rheinhardt > --- > doc/APIchanges | 4 > libavutil/imgutils.c | 14

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: Avoid reading multiple times in get_bits_long

2023-09-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Due to non-byte-alignment a read of 32 bits guarantees only > 25 usable bits; therefore get_bits_long() (which is used to > potentially read more than 25 bits) performs two reads in case > it needs to read more than 25 bits and combines the result. > > Yet this is not

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: add interleaved_read option

2023-09-10 Thread Derek Buitenhuis
Hi, On 9/10/2023 6:51 AM, Zhao Zhili wrote: > From: Zhao Zhili > > For bad interleaved files, manually interleave multiple tracks at the > demuxer level can trigger seeking back and forth, which can be > dramatically slow depending on the protocol. Demuxer level interleave > can be useless

Re: [FFmpeg-devel] [PATCH v2 01/22] fate/demux, lavf-container: Workaround for AV1-aspect ratio issue

2023-09-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is a workaround for an issue introduced in commit > 1652f2492f88434010053289d946dab6a57e4d58. It is not meant to be applied > to the tree. > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate-run.sh | 2 +- > tests/fate/demux.mak | 2 +- >

[FFmpeg-devel] [PATCH v2] avformat/avio: Don't use incompatible function pointer type for call

2023-09-10 Thread Andreas Rheinhardt
It is undefined behaviour even in cases where it works (it works because it is only a const uint8_t* vs. uint8_t* difference). Instead use a macro to produce two functions with the required types to be const-correct and type-safe. Signed-off-by: Andreas Rheinhardt --- libavformat/avio.c | 98

Re: [FFmpeg-devel] [PATCH 01/21] avformat/avio: Don't use incompatible function pointer type for call

2023-09-10 Thread Andreas Rheinhardt
Tomas Härdin: > tor 2023-09-07 klockan 02:23 +0200 skrev Andreas Rheinhardt: >> It is undefined behaviour even in cases where it works >> (it works because it is only a const uint8_t* vs. uint8_t* >> difference). >> >> Signed-off-by: Andreas Rheinhardt >> --- >>  libavformat/avio.c | 25

[FFmpeg-devel] Trac spam

2023-09-10 Thread Michael Koch
new spammer in ticket 2104 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/21] avformat/avio: Don't use incompatible function pointer type for call

2023-09-10 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 9 Sep 2023, Tomas Härdin wrote: > >> fre 2023-09-08 klockan 22:38 +0200 skrev Marton Balint: >>> >>> >>> On Thu, 7 Sep 2023, Andreas Rheinhardt wrote: >>> >>> > It is undefined behaviour even in cases where it works >>> > (it works because it is only a const

Re: [FFmpeg-devel] [PATCH 01/21] avformat/avio: Don't use incompatible function pointer type for call

2023-09-10 Thread Marton Balint
On Sat, 9 Sep 2023, Tomas Härdin wrote: fre 2023-09-08 klockan 22:38 +0200 skrev Marton Balint: On Thu, 7 Sep 2023, Andreas Rheinhardt wrote: > It is undefined behaviour even in cases where it works > (it works because it is only a const uint8_t* vs. uint8_t* > difference). > >

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/proresdec: Include required headers directly

2023-09-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Do not rely on an indirect inclusion of avcodec.h in proresdsp.h. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/proresdec.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/proresdec.h b/libavcodec/proresdec.h > index