Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-03-09 Thread Marth64
Hi, If there is still interest I can refine this to match the latest ffmpeg branch. Thank you! On Mon, Feb 20, 2023 at 10:57 AM Marth64 wrote: > Thank you, > It’s done in v2 set > > On Mon, Feb 20, 2023 at 10:41 Anton Khirnov wrote: > >> Quoting Marth64 (2023-02-17 15

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-03-10 Thread Marth64
I didn't know that. Thank you so much for your guidance along the way! Cheers On Fri, Mar 10, 2023 at 5:53 AM Hendrik Leppkes wrote: > On Fri, Mar 10, 2023 at 3:18 AM Marth64 wrote: > > > > Hi, > > > > If there is still interest I can refine this to match the late

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-20 Thread Marth64
Thank you, It’s done in v2 set On Mon, Feb 20, 2023 at 10:41 Anton Khirnov wrote: > Quoting Marth64 (2023-02-17 15:51:09) > > I can do the doc update, just not sure how to do the version. Is there an > > example? (Or is this not something I can do). Thank you! > > Ju

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Marth64
I can do the doc update, just not sure how to do the version. Is there an example? (Or is this not something I can do). Thank you! On Fri, Feb 17, 2023 at 04:59 Anton Khirnov wrote: > Quoting Marth64 (2023-02-12 01:31:41) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Marth64
Yes will take care of it, np On Fri, Feb 17, 2023 at 4:42 PM James Almer wrote: > On 2/17/2023 4:46 PM, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > Update doc/APIchanges and update libavcodec minor version > > > > doc/APIchanges |

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- Update doc/APIchanges and update libavcodec minor version doc/APIchanges | 4 libavcodec/ac3dec.c| 4 libavcodec/ac3dec.h| 1 + libavcodec/avcodec.h | 18 -- libavcodec/codec_desc.c| 2 ++ libavcodec

[FFmpeg-devel] [PATCH v2 2/4] avcodec/mlpdec: add detection of Atmos spatial extension profile in TrueHD

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 1 + libavcodec/mlpdec.c | 11 +++ libavcodec/profiles.c | 5 + libavcodec/profiles.h | 1 + 5 files changed, 20 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH v2 3/4] avcodec/dca_xll: add detection of DTS:X and DTS:X IMAX

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- libavcodec/avcodec.h | 15 +-- libavcodec/dca_syncwords.h | 3 +++ libavcodec/dca_xll.c | 26 +- libavcodec/dca_xll.h | 3 +++ libavcodec/profiles.c | 14 -- 5 files changed, 48 insertions(+), 13

[FFmpeg-devel] [PATCH v2 4/4] avcodec/version: bump minor version to accommodate spatial audio detection

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- doc/APIchanges | 6 ++ libavcodec/version.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 29161e30bf..35ff906662 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,12 @@ The last version

[FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- libavcodec/ac3dec.c | 3 +++ libavcodec/ac3dec.h | 1 + libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 1 + libavcodec/eac3dec.c| 11 ++- libavcodec/profiles.c | 5 + libavcodec/profiles.h | 1 + 7 files changed, 23

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-16 Thread Marth64
Hi Hendrik, Thank you for taking the time to help me test this. I will verify this as well on my corpus of 15 or so titles and commit/sign if it passes there too. Will update within 24. Respectfully, Marth64 On Thu, Feb 16, 2023 at 06:37 Hendrik Leppkes wrote: > On Sun, Feb 12, 2023 at 1

[FFmpeg-devel] [PATCH v2 2/4] avcodec/mlpdec: add detection of Atmos spatial extension profile in TrueHD

2023-02-18 Thread Marth64
Signed-off-by: Marth64 --- Tidied up formatting in mlpdec.c libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 1 + libavcodec/mlpdec.c | 10 ++ libavcodec/profiles.c | 5 + libavcodec/profiles.h | 1 + 5 files changed, 19 insertions(+) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mlpdec: add detection of Atmos spatial extension profile in TrueHD

2023-02-18 Thread Marth64
Good nit. Fix on the way, On Sat, Feb 18, 2023 at 10:50 AM Hendrik Leppkes wrote: > On Sat, Feb 18, 2023 at 2:15 AM Marth64 wrote: > > > > Signed-off-by: Marth64 > > --- > > libavcodec/avcodec.h| 2 ++ > > libavcodec/codec_desc.c | 1 +

[FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile

2023-02-18 Thread Marth64
Signed-off-by: Marth64 --- - Missed adding the profiles to actual codec descriptor in ac3dec_float - Formatting tidyness libavcodec/ac3dec.c | 3 +++ libavcodec/ac3dec.h | 1 + libavcodec/ac3dec_float.c | 2 ++ libavcodec/avcodec.h | 2 ++ libavcodec/codec_desc.c | 1

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-16 Thread Marth64
Signed-off-by: Marth64 --- - Align to dword and use more exact syncwords for DTS:X detection libavcodec/ac3dec.c| 4 libavcodec/ac3dec.h| 1 + libavcodec/avcodec.h | 18 -- libavcodec/codec_desc.c| 2 ++ libavcodec/dca_syncwords.h | 3

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile

2023-02-18 Thread Marth64
Embarrassing, good eye. Fixing now! On Sat, Feb 18, 2023 at 12:59 PM Hendrik Leppkes wrote: > On Sat, Feb 18, 2023 at 6:50 PM Marth64 wrote: > > > > Signed-off-by: Marth64 > > --- > > - Missed adding the profiles to actual codec descriptor in ac3dec_floa

[FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile

2023-02-18 Thread Marth64
Signed-off-by: Marth64 --- - Fix if() statement oversight libavcodec/ac3dec.c | 1 + libavcodec/ac3dec.h | 1 + libavcodec/ac3dec_float.c | 2 ++ libavcodec/avcodec.h | 2 ++ libavcodec/codec_desc.c | 1 + libavcodec/eac3dec.c | 11 ++- libavcodec/profiles.c

[FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category

2023-02-06 Thread Marth64
Since at least 4.4.3, -ab/-b:a help text was in the video section of ffmpeg -h, but these are audio options. Signed-off-by: Marth64 --- fftools/ffmpeg_opt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 204be38c94

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-11 Thread Marth64
Signed-off-by: Marth64 --- - Signed the commit libavcodec/ac3dec.c| 4 libavcodec/ac3dec.h| 1 + libavcodec/avcodec.h | 18 -- libavcodec/codec_desc.c| 2 ++ libavcodec/dca_syncwords.h | 3 +++ libavcodec/dca_xll.c | 24

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category

2023-02-08 Thread Marth64
Thank you On Wed, Feb 8, 2023 at 9:13 PM Anton Khirnov wrote: > Quoting Marth64 (2023-02-06 19:12:15) > > Since at least 4.4.3, -ab/-b:a help text was in the video section > > of ffmpeg -h, but these are audio options. > > > > Signed-off-by: Marth64 > >

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-08 Thread Marth64
Signed-off-by: Marth64 --- Adds detection of spatial/object-based audio extensions in E-AC-3, TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. Please let me know what I could improve, I'm learning still. Thank you. doc/ffprobe.xsd| 1 + fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-09 Thread Marth64
Leppkes wrote: > On Thu, Feb 9, 2023 at 5:42 AM Marth64 wrote: > > > > Signed-off-by: Marth64 > > --- > > Adds detection of spatial/object-based audio extensions in E-AC-3, > > TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. > > Pleas

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-09 Thread Marth64
Ack'd. Nice catch. Thank you! On Thu, Feb 9, 2023 at 4:35 PM Michael Niedermayer wrote: > On Wed, Feb 08, 2023 at 10:41:00PM -0600, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > Adds detection of spatial/object-based audio extensions in E-AC-3, > &g

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-11 Thread Marth64
--- - Switched to using profiles for presentation - Updated IMAX DTS:X syncword for earlier detection libavcodec/ac3dec.c| 4 libavcodec/ac3dec.h| 1 + libavcodec/avcodec.h | 18 -- libavcodec/codec_desc.c| 2 ++ libavcodec/dca_syncwords.h | 3

[FFmpeg-devel] [PATCH] avformat/avlanguage: add the 6 deprecated DVD languages

2024-01-23 Thread Marth64
oatian, no modern inclusive code so it is left alone All of this can be verified from several sources including: https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes I split this off from the DVD demuxer patch to simplify it a bit. Sent with git send-email and passes fate, pls let me know if t

Re: [FFmpeg-devel] [PATCH v3] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-23 Thread Marth64
Thank you Stefano, I will send updated version soon with also several bug fixes and improvements. On Tue, Jan 23, 2024 at 18:17 Stefano Sabatini wrote: > On date Wednesday 2024-01-10 21:46:38 -0600, Marth64 wrote: > > Fixes for several authoring styles/discs. > > ffmpeg CLI m

[FFmpeg-devel] [PATCH v7 1/2] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-04 Thread Marth64
uch, Signed-off-by: Marth64 --- Changelog |2 + configure |8 + doc/demuxers.texi | 129 libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/dvdvideodec.c | 1410 + 6 fi

[FFmpeg-devel] [PATCH v6] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-04 Thread Marth64
is missing Overall it's in pretty good working shape. Subtitle palette support remains in a separate patch set. Signed-off-by: Marth64 --- Changelog |2 + configure |8 + doc/demuxers.texi | 135 libavformat/Makefile |1 + libavformat

[FFmpeg-devel] [PATCH v7 2/2] libavformat/dvdvideo: add DVD CLUT utilities and enable palette support

2024-02-04 Thread Marth64
) enable usable palette support for DVD demuxer if it is merged and (2) start the process of consolidating the related conversions in MOV muxer/demuxer and eventually find a way to properly tag the colorspace. Signed-off-by: Marth64 --- doc/demuxers.texi | 5 ++ libavformat/Makefile

Re: [FFmpeg-devel] [PATCH v6] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-04 Thread Marth64
Gah, just realized a minor issue in the documentation only. The -clut_rgb option documentation is meant for the accompanying subtitle patchset, and can be ignored. I'll remove it, but will buffer the update in case there is more feedback. Thanks! On Sun, Feb 4, 2024 at 6:06 PM Marth64 wrote

Re: [FFmpeg-devel] [PATCH v9 1/2] libavformat: add dvdvideo demuxer, powered by libdvdnav and libdvdread

2024-02-08 Thread Marth64
Please ignore, see v10. On Fri, Feb 9, 2024 at 1:17 AM Marth64 wrote: > Thank you to all the reviewers for your time. > > [Remaining Questions] > > Andreas R: > > This makes this code add an AVStream to the child AVFormatContext. This > > is not how it is supp

[FFmpeg-devel] [PATCH v10 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-08 Thread Marth64
RAOKE. Thanks - added the disposition and also cleared up the point of the message, which is to say that karaoke tracks have additional extension metadata located in the IFO headers. I have not studied how to parse it at this time. Signed-off-by: Marth64 --- Changelog |2

[FFmpeg-devel] [PATCH v10 2/2] libavformat/dvdvideo: add DVD CLUT utilities and subtitle palette support

2024-02-08 Thread Marth64
) enable usable palette support for DVD demuxer if it is merged and (2) start the process of consolidating the related conversions in MOV muxer/demuxer and eventually find a way to properly tag the colorspace. Signed-off-by: Marth64 --- doc/demuxers.texi | 5 ++ libavformat/Makefile

[FFmpeg-devel] [PATCH v9 1/2] libavformat: add dvdvideo demuxer, powered by libdvdnav and libdvdread

2024-02-08 Thread Marth64
Why not? We have AV_DISPOSITION_KARAOKE. Thanks - added the disposition and also cleared up the point of the message, which is to say that karaoke tracks have additional extension metadata located in the IFO headers. I have not studied how to parse it at this time. Signed-off-by: Ma

[FFmpeg-devel] [PATCH v9 2/2] DVD subtitle palettes, which are natively YUV, are currently carried as a hex string in their respective subtitle streams and have no concept of colorspace tagging. In fa

2024-02-08 Thread Marth64
/demuxer and eventually find a way to properly tag the colorspace. Signed-off-by: Marth64 --- doc/demuxers.texi | 5 ++ libavformat/Makefile | 2 +- libavformat/dvdclut.c | 103 ++ libavformat/dvdclut.h | 37 ++ libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/rcwtenc: Pass RCWTContext directly in rcwt_init_cluster()

2024-02-08 Thread Marth64
v2 set LGTM. I verified with ATSC and DVD sources. Thank you. On Thu, Feb 8, 2024 at 9:08 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > It does not use the AVFormatContext at all. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rcwtenc.c | 8 +++- > 1 file

[FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-11 Thread Marth64
No critical changes since v12. - Removes unused context variable - Removes unnecessary if statement - Whitespace cleanup - Rebase with master Signed-off-by: Marth64 --- Changelog |2 + configure |8 + doc/demuxers.texi | 130 libavformat

[FFmpeg-devel] [PATCH v13 2/2] libavformat/dvdvideo: add CLUT utilities and enable subtitle palette support

2024-02-11 Thread Marth64
Signed-off-by: Marth64 --- doc/demuxers.texi | 5 +++ libavformat/Makefile | 2 +- libavformat/dvdclut.c | 76 +++ libavformat/dvdclut.h | 37 +++ libavformat/dvdvideodec.c | 14 5 files changed, 133 insertions

Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-16 Thread Marth64
I will take care of it, thanks On Fri, Feb 16, 2024 at 05:38 Anton Khirnov wrote: > Quoting Marth64 (2024-02-11 19:09:16) > > +static int dvdvideo_video_stream_add(AVFormatContext *s, > > + DVDVideoVTSVideoStr

[FFmpeg-devel] [PATCH v14 1/2] libavformat/dvdvideo: add DVD-Video demuxer, powered by libdvdread and libdvdnav

2024-02-18 Thread Marth64
in chapter functions * Fix timestamp overflow bug introduced in v11 Signed-off-by: Marth64 --- Changelog |2 + configure |8 + doc/demuxers.texi | 130 libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat

[FFmpeg-devel] [PATCH v14 2/2] libavformat/dvdvideo: add CLUT utilities and enable subtitle palette support

2024-02-18 Thread Marth64
Signed-off-by: Marth64 --- doc/demuxers.texi | 5 +++ libavformat/Makefile | 2 +- libavformat/dvdclut.c | 76 +++ libavformat/dvdclut.h | 37 +++ libavformat/dvdvideodec.c | 14 5 files changed, 133 insertions

Re: [FFmpeg-devel] [PATCH v7 2/2] libavformat/dvdvideo: add DVD CLUT utilities and enable palette support

2024-02-07 Thread Marth64
Thank you, Andreas. This was very helpful. I will clean it up this evening. On Wed, Feb 7, 2024 at 12:07 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Marth64: > > DVD subtitle palettes, which are natively YUV, are currently carried as > > a hex strin

Re: [FFmpeg-devel] [PATCH v10 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-09 Thread Marth64
Solution is on the way. Thanks! On Fri, Feb 9, 2024 at 4:43 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Marth64: > > Please ignore v9, I screwed up the email subject (contents are the > same). Sorry folks. > > > > Addresses all prior feedb

[FFmpeg-devel] [PATCH v11 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-09 Thread Marth64
Addresses the last round of feedback. Fingers crossed. - Resolves maintainability concern - Some more formatting nits - Removes the YUV-RGB lookup table Signed-off-by: Marth64 --- Changelog |2 + configure |8 + doc/demuxers.texi | 130

[FFmpeg-devel] [PATCH v11 2/2] libavformat/dvdvideo: add DVD CLUT utilities and enable subtitle palette support

2024-02-09 Thread Marth64
) enable usable palette support for DVD demuxer if it is merged and (2) start the process of consolidating the related conversions in MOV muxer/demuxer and eventually find a way to properly tag the colorspace. Signed-off-by: Marth64 --- doc/demuxers.texi | 5 +++ libavformat/Makefile

Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-12 Thread Marth64
Thank you Stefano for your patience and reviews. I am working on refinements that can go in after initial patch. Cheers On Mon, Feb 12, 2024 at 09:47 Stefano Sabatini wrote: > On date Sunday 2024-02-11 12:09:16 -0600, Marth64 wrote: > > No critical changes since v12. > > -

[FFmpeg-devel] [PATCH v12 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-09 Thread Marth64
- Fixes anticipated feedback about bprint_finalize() - Fixes anticipated documentation typo - Removes unnecessary constant Signed-off-by: Marth64 --- Changelog |2 + configure |8 + doc/demuxers.texi | 130 libavformat/Makefile |1

[FFmpeg-devel] [PATCH v12 2/2] libavformat/dvdvideo: add DVD CLUT utilities and enable subtitle palette support

2024-02-09 Thread Marth64
) enable usable palette support for DVD demuxer if it is merged and (2) start the process of consolidating the related conversions in MOV muxer/demuxer and eventually find a way to properly tag the colorspace. Signed-off-by: Marth64 --- doc/demuxers.texi | 5 +++ libavformat/Makefile

[FFmpeg-devel] [PATCH] avformat/avformat.h: elaborate documentation for avformat_open_input() on error condition

2024-02-09 Thread Marth64
Signed-off-by: Marth64 --- libavformat/avformat.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 5d0fe82250..070ed7023d 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2175,7 +2175,7 @@ int

Re: [FFmpeg-devel] [PATCH v2] doc/formats: clarify meaning of igndts as per definition in avformat.h

2024-02-06 Thread Marth64
Glad to see this one fixed. Thank you! On Tue, Feb 6, 2024 at 5:58 PM Stefano Sabatini wrote: > On date Monday 2024-02-05 01:27:07 +0100, Stefano Sabatini wrote: > > On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > > > This updates the documentation to be more

Re: [FFmpeg-devel] [PATCH v7 1/2] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-06 Thread Marth64
Thank you for your time and detailed review. I will clean all this up and send v9 On Tue, Feb 6, 2024 at 6:53 PM Stefano Sabatini wrote: > On date Sunday 2024-02-04 23:48:25 -0600, Marth64 wrote: > > Sorry for the quick follow-up to v6, I wanted to get this update out now > hopefull

[FFmpeg-devel] [PATCH] doc/ffmpeg: fix -copy_ts typo, should be -copyts

2023-12-10 Thread Marth64
Signed-off-by: Marth64 --- doc/ffmpeg.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 6bcedd76d5..36fdaef879 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1861,7 +1861,7 @@ of seconds. The timestamp discontinuity

[FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
Hello, I am happy to share a DVD demuxer for ffmpeg powered by libdvdread and libdvdnav. I have been working on this on/off throughout the year and think it is in a good spot to share at the ML now. This was a major learning experience for me in many ways and am open to any feedback on how I

[FFmpeg-devel] [PATCH v2] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-11 Thread Marth64
Added v2 label and signed off as per proper procedure. Signed-off-by: Marth64 --- doc/bitstream_filters.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index dc4f85bac0..7c36c5346d 100644 --- a/doc

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index c63c20370f..d2ad6e78ff 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -213,6 +213,24 @@ To remove all

[FFmpeg-devel] [PATCH] ffmpeg_opt: clarify that -ab is deprecated

2023-12-09 Thread Marth64
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 304471dd03..837bef8161 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1722,7 +1722,7 @@ const OptionDef options[] = { OPT_SPEC | OPT_OUTPUT, { .off =

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
will send a request to relicense as LGPL and update here. I will then give credit in the header. My apologies for mixing this. In the mean time I will also fix some aforementioned bugs. On Sat, Dec 9, 2023 at 4:06 AM Marth64 wrote: > Hello, I am happy to share a DVD demuxer for ffmpeg powe

[FFmpeg-devel] [PATCH] doc/ffprobe: add a useful one-liner example to get essential input information as JSON

2023-12-09 Thread Marth64
Signed-off-by: Marth64 This could be useful for folks who are just learning ffmpeg or have simple needs for parsing input information as JSON. --- doc/ffprobe.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi index b74ff650ac..ed88e619f6 100644

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
EG PS packet but I guess there is no value to your point. On Sat, Dec 9, 2023 at 9:03 PM Leo Izen wrote: > On 12/9/23 05:06, Marth64 wrote: > > Hello, I am happy to share a DVD demuxer for ffmpeg powered by > libdvdread and libdvdnav. > > I have been working on this on/off throu

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
Thank you! On Sat, Dec 9, 2023 at 9:06 PM Leo Izen wrote: > On 12/9/23 20:35, Marth64 wrote: > > --- > > doc/bitstream_filters.texi | 18 ++ > > 1 file changed, 18 insertions(+) > > > > Make sure when you generate the second version of a patch

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
Appreciate the good feedback, will update. Thank you. On Sat, Dec 9, 2023 at 6:53 PM Stefano Sabatini wrote: > On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote: > > --- > > doc/bitstream_filters.texi | 17 + > > 1 file changed, 17 insertions(+) >

[FFmpeg-devel] [PATCH] avformat/options_table, doc/formats: clarify meaning of igndts as per definition in avformat.h

2023-12-09 Thread Marth64
This confused me for a long time, hopefully this is helpful to others. The definition in avformat.h says "Ignore DTS on frames that contain both DTS & PTS" Signed-off-by: Marth64 --- doc/formats.texi| 2 +- libavformat/options_table.h | 2 +- 2 files changed, 2 in

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
ning the MPEG-PS subdemuxer with custom IO flag. It seems to expect this according to the documentation. I can try without. On Sat, Dec 9, 2023 at 9:03 PM Leo Izen wrote: > On 12/9/23 05:06, Marth64 wrote: > > Hello, I am happy to share a DVD demuxer for ffmpeg powered by > libdvdre

[FFmpeg-devel] [PATCH v2] ffmpeg_opt: clarify that -ab is deprecated

2023-12-11 Thread Marth64
Added v2 flag and signoff to follow process. Adjusted based on feedback. Signed-off-by: Marth64 --- fftools/ffmpeg_opt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 304471dd03..837bef8161 100644 --- a/fftools

[FFmpeg-devel] [PATCH v2] doc/filters: add example for idet filter

2023-12-11 Thread Marth64
Cleaned up mistake of outputting with rawvideo format Signed-off-by: Marth64 --- doc/filters.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 6d00ba2c3f..e595f7d152 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -15919,6

[FFmpeg-devel] [PATCH] doc/filters: add example for idet filter

2023-12-11 Thread Marth64
Signed-off-by: Marth64 --- doc/filters.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 6d00ba2c3f..1250685bc7 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -15919,6 +15919,13 @@ further computations. This allows inserting

[FFmpeg-devel] [PATCH v3] doc/filters: add example for idet filter

2023-12-11 Thread Marth64
Clean up the example further. Sorry. Signed-off-by: Marth64 --- doc/filters.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 6d00ba2c3f..bf59352ba0 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -15919,6 +15919,13 @@ further

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add setts example

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index c63c20370f..145aa8684e 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -882,6 +882,11 @@ The sample rate of stream

[FFmpeg-devel] [PATCH] ffmpeg_opt: inform user about -b:a and -b:v instead of legacy form

2023-12-09 Thread Marth64
--- fftools/ffmpeg_opt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 304471dd03..5e50e5efa2 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1721,8 +1721,8 @@ const OptionDef options[] = { {

[FFmpeg-devel] [PATCH] doc/ffmpeg: AV_FMT_DISCONT typo should be AVFMT_TS_DISCONT

2023-12-09 Thread Marth64
--- doc/ffmpeg.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 145cbb1032..6bcedd76d5 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1860,7 +1860,7 @@ of seconds. The timestamp discontinuity correction enabled by this

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: inform user about -b:a and -b:v instead of legacy form

2023-12-09 Thread Marth64
Roger, will update. Thanks! On Sat, Dec 9, 2023 at 1:25 PM James Almer wrote: > On 12/9/2023 4:10 PM, Marth64 wrote: > > --- > > fftools/ffmpeg_opt.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/fftools/ffmpeg_opt.c

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 145aa8684e..b01ede0c93 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -213,6 +213,23 @@ To remove all

Re: [FFmpeg-devel] [PATCH] doc/faq: replace non-breaking spaces (0xA0) with normal space

2024-01-04 Thread Marth64
I understand now and that makes sense. If no objections, I am happy to make a patch to revert! On Thu, Jan 4, 2024 at 1:46 AM Jean-Baptiste Kempf wrote: > > > On Wed, 3 Jan 2024, at 23:21, Marth64 wrote: > > Hi, > > I felt that it was strange in all of documentat

[FFmpeg-devel] [PATCH] doc/codecs: fix missing guidance in channel_layout item and remove decomissioned request_channel_layout

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/codecs.texi | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index 5b950b4560..98482ff8bf 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -767,15 +767,9 @@ Set rate-distortion optimal

[FFmpeg-devel] [PATCH] doc/encoders: libxeve doc typo, baselie->baseline

2024-01-03 Thread Marth64
--- doc/encoders.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 93586e1aae..f65389f2a0 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -2972,7 +2972,7 @@ Set the encoder preset value to determine encoding speed

[FFmpeg-devel] [PATCH] doc/faq: fix scaling question typo

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/faq.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/faq.texi b/doc/faq.texi index 8b165eb436..39f28eef08 100644 --- a/doc/faq.texi +++ b/doc/faq.texi @@ -467,7 +467,7 @@ point acceptable for your tastes. The most common options to do

[FFmpeg-devel] [PATCH] doc/ffmpeg: add missing comma

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/ffmpeg.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 145cbb1032..bb57aeaef4 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -118,7 +118,7 @@ Encoded packets are then passed to the decoder

Re: [FFmpeg-devel] [PATCH] doc/faq: replace non-breaking spaces (0xA0) with normal space

2024-01-03 Thread Marth64
2 PM Jean-Baptiste Kempf wrote: > Why this change? > > On Wed, 3 Jan 2024, at 19:47, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > doc/faq.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/doc/faq.texi b/doc

[FFmpeg-devel] [PATCH] doc/faq: replace non-breaking spaces (0xA0) with normal space

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/faq.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/faq.texi b/doc/faq.texi index 39f28eef08..5998e0d000 100644 --- a/doc/faq.texi +++ b/doc/faq.texi @@ -450,7 +450,7 @@ work with streams that were detected during the initial scan

[FFmpeg-devel] [PATCH] doc/codecs: add missing comma to introduction

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/codecs.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index 5b950b4560..6c6f16a2c8 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -3,7 +3,7 @@ @c man begin CODEC OPTIONS libavcodec provides some

[FFmpeg-devel] [PATCH] doc/filter: fix typos in introduction with the word 'unlabelled'

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/filters.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index f4084ff494..eff2256fef 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -195,7 +195,7 @@ filtergraph, a link between

[FFmpeg-devel] [PATCH] doc/filters: fix minterpolate vsbmc option typos

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 6d00ba2c3f..215cb966ce 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -17887,7 +17887,7 @@ Macroblock size. Default @code{16

Re: [FFmpeg-devel] [PATCH] doc/filter: fix typos in introduction with the word 'unlabelled'

2024-01-03 Thread Marth64
Kindly disregard. This is not actually a typo, it is valid regional English. Sorry. Just ignore this one. On Wed, Jan 3, 2024 at 4:51 PM Marth64 wrote: > Signed-off-by: Marth64 > --- > doc/filters.texi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] doc/faq: fix scaling question typo

2024-01-03 Thread Marth64
Thank you! On Wed, Jan 3, 2024 at 6:15 PM Stefano Sabatini wrote: > On date Wednesday 2024-01-03 12:45:51 -0600, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > doc/faq.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > d

[FFmpeg-devel] [PATCH] doc/filter: remove duplicate word 'with' in QR filters

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/filters.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 264b363642..f4084ff494 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -20101,7 +20101,7 @@ Generate a QR code using

[FFmpeg-devel] [PATCH] doc/muxers: fix duplicate word 'that' for image2 summary

2024-01-03 Thread Marth64
Signed-off-by: Marth64 --- doc/muxers.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f6071484ff..7b705b6a9e 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1397,7 +1397,7 @@ form @file{img%-1.jpg}, @file{img%-2.jpg

Re: [FFmpeg-devel] [PATCH 1/2] doc/muxers: extend documentation for MOV muxers

2024-01-06 Thread Marth64
+This section covers formats belonging to the QuickTime / MOV family, +also named after the MPEG-4 Part 14 format, also named after the ISO +base media file format (ISOBMFF). + +The MOV format was originally developed for the Apple QuickTime +container format. Then it was later used as basis for

[FFmpeg-devel] [PATCH] web/index: fix invalid line-break (BR) tags

2024-01-08 Thread Marth64
Signed-off-by: Marth64 --- src/index | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/index b/src/index index 98cc516..a949270 100644 --- a/src/index +++ b/src/index @@ -113,11 +113,11 @@ Internally, we have had a number of changes too. The FFT

[FFmpeg-devel] [PATCH] web/index: fix dangling/improper paragraph (P) tag

2024-01-08 Thread Marth64
--- src/index | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index b/src/index index a949270..1d74e8c 100644 --- a/src/index +++ b/src/index @@ -147,7 +147,7 @@ The functionality will be included in stable branches with the release of version 6.1, due to be

[FFmpeg-devel] [PATCH] web/template_head2: fix broken anchor on 'Contribute' link

2024-01-08 Thread Marth64
Signed-off-by: Marth64 --- src/template_head2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/template_head2 b/src/template_head2 index 7ba634b..102fac0 100644 --- a/src/template_head2 +++ b/src/template_head2 @@ -34,7 +34,7 @@ Developers

[FFmpeg-devel] [PATCH] web/index: fix unclosed SMALL tag

2024-01-08 Thread Marth64
Signed-off-by: Marth64 --- src/template_footer1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/template_footer1 b/src/template_footer1 index 4fce551..6722421 100644 --- a/src/template_footer1 +++ b/src/template_footer1 @@ -1,5 +1,5 @@ - Hosting provided

[FFmpeg-devel] [PATCH] web/README: add missing dependency clean-css

2024-01-08 Thread Marth64
Signed-off-by: Marth64 --- README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 5076719..4b1ce67 100644 --- a/README +++ b/README @@ -4,7 +4,7 @@ ffmpeg.org official website GENERATE THE WEBSITE -`lessc` is required

[FFmpeg-devel] [PATCH] web/index: fix dangling/improper paragraph (P) tag (2)

2024-01-08 Thread Marth64
Signed-off-by: Marth64 --- src/index | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index b/src/index index 1d74e8c..4b01f55 100644 --- a/src/index +++ b/src/index @@ -146,7 +146,7 @@ https://git.videolan.org/?p=ffmpeg.git;a=summary;>repository is requi

Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
in the blanks. If anyone can think of a better way, please let me know. Right now, it works well. On Wed, Jan 10, 2024 at 2:47 AM Marth64 wrote: > Dust off those old DVD discs! > > This version is greatly simplified and improved from the patch submitted > in December. > Discontinuity issu

[FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
-by: Marth64 --- Changelog |1 + configure |8 + libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/avlanguage.c | 10 +- libavformat/dvdvideodec.c | 1022 + 6 files changed, 1041 insertions

Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
To elaborate slightly: GENPTS is working within each segment, whose start and end times I have from NAV packets On Wed, Jan 10, 2024 at 10:25 Marth64 wrote: > Thank you, Nicolas. I had tinkered with concat this way in the past as > PGCs are indeed just a bunch of segments mushed together,

Re: [FFmpeg-devel] [PATCH v2] dvdvideo: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-01-10 Thread Marth64
issue with concatenation/handling the gaps, and I am flushing the subdemuxer when they occur. Just the GENPTS sticks out as being a non-ideal thing to do. That said, I will take another look and see if I misunderstood at the time. Best, On Wed, Jan 10, 2024 at 04:17 Nicolas George wrote: > Marth64 (12

[FFmpeg-devel] [PATCH v2] web/index: fix invalid line breaks (BR)

2024-01-10 Thread Marth64
Uses preferred convention for ffmpeg Signed-off-by: Marth64 --- src/index | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/index b/src/index index 98cc516..edf8100 100644 --- a/src/index +++ b/src/index @@ -113,11 +113,11 @@ Internally, we have had

[FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-06 Thread Marth64
This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. A valid point was made, that the non-breaking space will cause this text to render better by ensuring the unit never seperates from the number. Signed-off-by: Marth64 --- doc/faq.texi | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2024-01-06 Thread Marth64
Thank you, for the feedback and encouragement. I have made progress fixing the timestamp issues and will follow up once I am more confident about the solution. On Wed, Dec 13, 2023 at 2:45 PM Nicolas George wrote: > Marth64 (12023-12-09): > > I am hoping and willing t

  1   2   3   >