Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat,
and add a stub ffjni.c to libavformat, which allows the symbols to be
duplicated for shared builds but not static builds.
Signed-off-by: Leo Izen
---
libavcodec/Makefile | 1 +
libavformat/Makefile | 1 +
libavformat
Changes since v1:
- Rebased onto master
I was unable to credit the original reporter with a Reported-by because
the name used Chinese characters (and it translated to 'admin').
Leo Izen (1):
avcodec,avformat/ffjni: fix duplicate JNI symbols
libavcodec/Makefile | 1 +
libavformat/Makefile
in commit message, you want libtorch, not libtoch.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
to
alphabetize it.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
The continue statement will break out of the do/while loop, not the
outer loop as intended. This is one (compound) statement anyway, so we
can remove the do/while entirely.
Signed-off-by: Leo Izen
---
libavutil/film_grain_params.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
These variables are never read from, so they trigger -Wunused-variables
Signed-off-by: Leo Izen
---
libavutil/film_grain_params.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavutil/film_grain_params.c b/libavutil/film_grain_params.c
index fff7252f2f..b3fa37f527 100644
A few minor tweaks to libavutil/film_grain_params.c.
Leo Izen (2):
avutil/film_grain_params: remove unused variables
avutil/film_grain_params: remove do loop in CHECK macro
libavutil/film_grain_params.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
--
2.44.0
avpkt->pos needs to be set for generic indexing or features such as the
stream_loop option will not work.
Co-authored-by: Andreas Rheinhardt
Signed-off-by: Leo Izen
---
libavformat/jpegxl_anim_dec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/jpegxl_anim_dec.
On 3/11/24 17:48, Marth64 wrote:
This breaks fate
Looking into it - thanks.
It is possible that the change is correct, and that the fate test needs
to be changed to reflect the correct behavior. Not necessarily, but
possibly.
- Leo Izen (Traneptora)
OpenPGP_signature.asc
Description
summaries/counts on the left, could you please elaborate on
how you generated this data? I'm not super familiar with the trac user
interface, but iirc you can embed the search in a query string.
- Leo Izen (Traneptora)
OpenPGP_signature.asc
Description: OpenPGP digital
On 3/9/24 13:27, Marth64 wrote:
Signed-off-by: Marth64
---
doc/demuxers.texi | 43 +-
libavformat/dvdvideodec.c | 314 --
2 files changed, 339 insertions(+), 18 deletions(-)
diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index
become widely used if it was in
someones personal repository and main FFmpeg did not support it
thx
This is true, but also the code hasn't been touched in more than ten
years, which makes it a bit different than, say, ffv1 which was actively
developed for a while and still is.
- Leo Izen
On 3/9/24 15:49, Poorva wrote:
I have attached the git patch containing the changes for your review.
This patch is submitted as part of my qualification task for Google Summer
of Code (GSoC)
Your editor appears to have stripped the newline at the end of the file.
- Leo Izen (Traneptora
On 2/14/24 13:53, Andreas Rheinhardt wrote:
Leo Izen:
Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk
to PNG files, if present.
Signed-off-by: Leo Izen
---
libavcodec/pngenc.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk
to PNG files, if present.
Signed-off-by: Leo Izen
---
libavcodec/pngenc.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 50689cb50c..a302c879da 100644
--- a/libavcodec
Add support to parse eXIf chunks using the new EXIF framework.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 026da30c25..e7951d1802 100644
--- a/libavcodec
be
applied during a major version bump.
Signed-off-by: Leo Izen
---
fftools/ffprobe.c | 27 ++-
libavcodec/Makefile| 1 +
libavcodec/exif.c | 267 +++--
libavcodec/exif.h | 21 ++-
libavcodec/exif_internal.h
as that would be.
[1] https://exiv2.org/makernote.html
[2] http://www.exif.org/samples.html
Leo Izen (3):
various: change EXIF metadata into AVFrameSideData
avcodec/pngdec: parse eXIf chunk
avcodec/pngenc: write eXIf chunks
fftools/ffprobe.c | 27 ++-
libavcodec/Makefile
Add an AVOption to the libjxl encoder wrapper, which exposes the flag
uses_original_profile in libjxl. For highly unusual ICC profiles where
the target needs to stay in the original space, this can be useful.
Signed-off-by: Leo Izen
---
libavcodec/libjxlenc.c | 5 -
libavcodec/version.h
Changes since v1:
- bump micro version, per policy
- rebase onto master
Leo Izen (1):
avcodec/libjxlenc: add option to disable xyb encoding
libavcodec/libjxlenc.c | 5 -
libavcodec/version.h | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
--
2.43.0
On 1/31/24 14:37, Leo Izen wrote:
The function signature for bytestream2_seek is (gb, offset, whence);
Before this patch, the code passed (gb, SEEK_SET, offset), which is
incorrect.
Siged-off-by: Leo Izen
---
libavcodec/tiff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 2/4/24 04:35, Leo Izen wrote:
This adds support for cLLi and mDVc chunks in the PNG specification[1].
[1]: https://www.w3.org/TR/png-3/
Changes from v1:
- fix regression in cHRM writing, causing fate failure
Leo Izen (2):
avcodec/pngdec: read cLLi and mDVc chunks
avcodec/pngenc
On 2/7/24 13:56, Andreas Rheinhardt wrote:
Leo Izen:
On 1/23/24 14:22, Michael Niedermayer wrote:
Hi all
As it was a little difficult for me to not loose track of what is
blocking a release. I suggest that for all release blocking issues
open a ticket and set Blocking to 7.0
that way
* data loss
* privacy issues
* anything the commuity agrees should be in the release
thx
My EXIF overhaul is going to be an ABI break so I'd like to get it in,
if and only if we are doing an ABI break with the release.
- Leo Izen (Traneptora)
OpenPGP_signature.asc
Description: OpenPGP digital
These chunks contain the Content Light Level Information and the
Mastering Display Color Volume information that FFmpeg already supports
as AVFrameSideData. This patch adds support for the png encoder to save
this metadata as the corresponding chunks in the PNG stream.
Signed-off-by: Leo Izen
.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 63 +
1 file changed, 63 insertions(+)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index d1aae4c70e..026da30c25 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -29,6 +29,7
This adds support for cLLi and mDVc chunks in the PNG specification[1].
[1]: https://www.w3.org/TR/png-3/
Changes from v1:
- fix regression in cHRM writing, causing fate failure
Leo Izen (2):
avcodec/pngdec: read cLLi and mDVc chunks
avcodec/pngenc: write cLLi and mDVc chunks
libavcodec
On 2/3/24 14:20, Andreas Rheinhardt wrote:
Forgotten after 82beb46e65e5f820b187355bf757725c22a59c45.
Also use loop-scope for iterators while at it.
Signed-off-by: Andreas Rheinhardt
---
libavformat/nutenc.c | 30 +++---
1 file changed, 15 insertions(+), 15
On 2/1/24 03:29, Anton Khirnov wrote:
Replace it with recreating the codec context.
This is the last remaining blocker for deprecating avcodec_close().
---
libavformat/demux.c | 53 -
1 file changed, 48 insertions(+), 5 deletions(-)
diff --git
These chunks contain the Content Light Level Information and the
Mastering Display Color Volume information that FFmpeg already supports
as AVFrameSideData. This patch adds support for the png encoder to save
this metadata as the corresponding chunks in the PNG stream.
Signed-off-by: Leo Izen
.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 63 +
1 file changed, 63 insertions(+)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index d1aae4c70e..026da30c25 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -29,6 +29,7
This adds support for cLLi and mDVc chunks in the PNG specification[1].
[1]: https://www.w3.org/TR/png-3/
Leo Izen (2):
avcodec/pngdec: read cLLi and mDVc chunks
avcodec/pngenc: write cLLi and mDVc chunks
libavcodec/pngdec.c | 63 +
libavcodec
The function signature for bytestream2_seek is (gb, offset, whence);
Before this patch, the code passed (gb, SEEK_SET, offset), which is
incorrect.
Siged-off-by: Leo Izen
---
libavcodec/tiff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/tiff.c b/libavcodec
On 1/30/24 10:24, Leo Izen wrote:
+jxl_fmt.align = -frame->linesize[0];
+data = frame->data[0] + frame->linesize[0] * (info.ysize - 1);
+}
Something like this ^ is what you're requesting, right?
- Leo Izen (Traneptora)
OpenPGP_signature.asc
Description
-flip orientation.
Signed-off-by: Leo Izen
---
libavcodec/libjxlenc.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c
index 67be8a01ca..5f5f9751dc 100644
--- a/libavcodec/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
On 1/30/24 09:57, Andreas Rheinhardt wrote:
Please don't rely on the type of jxl_fmt.align here (which is out of our
control). E.g. in the future it may be that libjxl supports only 32bit
align values (i.e. uses uint32_t or so for it), but that we support
64bit (ptrdiff_t) linesizes and
On 1/30/24 09:46, Leo Izen wrote:
libjxl doesn't support negative strides, but JPEG XL has an orientation
flag inside the codestream. We can use this to work around the library
limitation, by taking the absolute value of the negative row stride,
sending the image up-side-down, and telling
-flip orientation.
Signed-off-by: Leo Izen
---
libavcodec/libjxlenc.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c
index 67be8a01ca..4ddd5f9f2c 100644
--- a/libavcodec/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
-flip orientation.
Signed-off-by: Leo Izen
---
libavcodec/libjxlenc.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c
index 67be8a01ca..49020b1036 100644
--- a/libavcodec/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
Add an AVOption to the libjxl encoder wrapper, which exposes the flag
uses_original_profile in libjxl. For highly unusual ICC profiles where
the target needs to stay in the original space, this can be useful.
Signed-off-by: Leo Izen
---
libavcodec/libjxlenc.c | 5 -
1 file changed, 4
that you obtained the file from. You can also host the
sample elsewhere, such as your own website, or on a site like 0x0.st, if
you are concerned about Videolan's jurisdiction.
- Leo Izen (Traneptora)
OpenPGP_signature.asc
Description: OpenPGP digital signature
are also
present in that file, so we no longer need to redefine them.
Signed-off-by: Leo Izen
---
libavcodec/libjxl.h | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/libavcodec/libjxl.h b/libavcodec/libjxl.h
index e305b6e758..0b983a122f 100644
--- a/libavcodec
Produces a -Wunused-variables warning with -Wall.
Signed-off-by: Leo Izen
---
libavformat/mxfenc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 685c11b3a5..febc1ccf8c 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
Patch attached, this email signed with my previous key.
- Leo Izen (Traneptora)
From 09ee68f816d1d2c39097515cedca69031251aa4f Mon Sep 17 00:00:00 2001
From: Leo Izen
Date: Mon, 8 Jan 2024 14:01:59 -0500
Subject: [PATCH] MAINTAINERS: add my new PGP key
Adding my new gpg key that I will be using
On 12/25/23 15:09, Michael Niedermayer wrote:
On Mon, Dec 25, 2023 at 12:04:17PM -0500, Leo Izen wrote:
The specification doesn't mention that clusters cannot have alphabet
sizes greater than 1 << bundle->log_alphabet_size, but the reference
implementation rejects these entrop
module
has to be maintained, and removing that module removes the maintenance
burden. An international obfuscated C contest entry isn't really on-topic.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org
be large enough otherwise.
Fixes #10738.
Found-by: Zeng Yunxiang and Li Zeyuan
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parser.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c
index 0
/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
@@ -85,8 +85,8 @@ static float quality_to_distance(float quality)
}
Both of these LGTM.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
be large enough otherwise.
Fixes #10738.
Reported-by: Michael Niedermayer
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parser.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c
index 006eb6b295..c9832e43
On 12/15/23 16:31, Zsolt Vadász via ffmpeg-devel wrote:
On Friday, December 15th, 2023 at 10:12 PM, Leo Izen wrote:
On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote:
On Friday, December 15th, 2023 at 12:20 AM, Leo Izen leo.i...@gmail.com wrote:
+ AVFrame *last;
I don't see
On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote:
On Friday, December 15th, 2023 at 12:20 AM, Leo Izen wrote:
+ AVFrame *last;
I don't see the purpose of keeping this here.
The name is misleading, I should have named it `previous`, since it always
contains the previous frame.
I
the PTS information those containers provide to work as
expected.
Signed-off-by: Leo Izen
---
libavcodec/libjxldec.c | 57 +-
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c
index 002740d9c1
On 12/14/23 03:28, Anton Khirnov wrote:
Quoting Leo Izen (2023-12-08 18:31:06)
If a sequence of JXL images is encapsulated in a container that has PTS
information, we should use the PTS information from the container. At
this time there is no container that does this, but if JPEG XL support
On 12/13/23 15:53, Zsolt Vadász via ffmpeg-devel wrote:
---
configure | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/libjxlenc.c | 214 +
3 files changed, 177 insertions(+), 39 deletions(-)
diff --git a/configure b/configure
index
--- a/libavcodec/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
If this is necessary for adding an animated encoder it needs to be in
the commit, because this commit by itself doesn't do anything.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel
On 12/11/23 12:05, Zsolt Vadász via ffmpeg-devel wrote:
---
libavcodec/libjxlenc.c | 45 +-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c
index d707f3a61b..92a458d51a 100644
Why?
as it should.
Also, PNG doesn't support nonzero matrices but we only warn and ignore
in that case, so we have no reason to error out for illegal cICP ranges
either (i.e. greater than 1).
Signed-off-by: Leo Izen
Reported-by: Kacper Michajłow
---
libavcodec/pngdec.c | 23 ---
1 file
These pixel formats have always been supported by libjxl, but at the
time this plugin was written, they were not in FFmpeg yet. Now that
they are in FFmpeg, we should support them.
Signed-off-by: Leo Izen
---
libavcodec/libjxlenc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec
These pixel formats have always been supported by libjxl, but at the
time this plugin was written, they were not in FFmpeg yet. Now that
they are in FFmpeg, we should support them.
Signed-off-by: Leo Izen
---
libavcodec/libjxldec.c | 17 +
1 file changed, 9 insertions(+), 8
On 12/10/23 23:20, Kacper Michajlow wrote:
On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote:
On 2/27/23 11:34, Leo Izen wrote:
On 2/21/23 17:35, Leo Izen wrote:
These chunks are lightweight and it's useful information to have when
running ffmpeg -i or ffprobe, for example.
---
libavcodec
On 12/10/23 09:07, Andreas Rheinhardt wrote:
Leo Izen:
This patch requires a sample that hasn't been uploaded yet. It can be found
at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k,
which is not very large, but large enough that I did not want to attach it
to this email
it can get a little bit difficult for reviewers to track the
versions. I have no comments on the patch itself, in either direction.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg
On 12/9/23 05:06, Marth64 wrote:
Hello, I am happy to share a DVD demuxer for ffmpeg powered by libdvdread and
libdvdnav.
I have been working on this on/off throughout the year and think it is in a
good spot
to share at the ML now. This was a major learning experience for me in many
ways and
This test verifies the parser's handling of multiframe JXL files that
have an entropy-encoded permuted table of contents for each frame. The
testcase is actually six JXL codestreams concatenated together, and the
parser needs to be able to find the boundaries.
Signed-off-by: Leo Izen
---
tests
:
9288337dc0d37effd1f539d4e20083a8ffed757e486f4098121520c74e8de6f6
sample signature: https://buzo.us/A.asc
Leo Izen (1):
fate/jpegxl: add multiframe permuted TOC image parser test
tests/fate/jxl.mak | 3 +++
tests/ref/fate/jxl-multiframe-permuted-toc | 11 +++
2 files
the PTS information those containers provide to work as
expected.
Signed-off-by: Leo Izen
---
libavcodec/libjxldec.c | 77 +++---
1 file changed, 57 insertions(+), 20 deletions(-)
diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c
index 002740d9c1
On 11/23/23 10:31, Leo Izen wrote:
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy. Additionally, prints a warning to the log context if this
truncation occurred.
Signed-off-by: Leo Izen
---
Bump, thanks.
- Leo Izen (Traneptora
On 12/7/23 11:32, Nicolas George wrote:
Leo Izen (12023-12-07):
I believe the question was directed at Paul
That does not make my answer any less relevant.
I'm not going to have an argument with you about why a question to Paul
about a decision Paul made should be answered by Paul
not answered yet
(as of writing this).
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
On 11/27/23 09:10, Leo Izen wrote:
Two bug fixes related to the JPEG XL parser. They're not exactly related and
don't need to be applied in sequence.
v2 change: patches themselves are identical, but now there's a FATE test.
Leo Izen (3):
avcodec/jpegxl_parse{,r}: use correct ISOBMFF
Add a fate test for the above commits fixing extremely small files or
files with extended box sizes.
Signed-off-by: Leo Izen
---
tests/fate/jxl.mak | 8
tests/ref/fate/jxl-small-ext-box | 9 +
2 files changed, 17 insertions(+)
create mode 100644 tests/ref/fate
This patch allows the JXL parser to parse sequences of extremely small
files concatenated together. (e.g. smaller than the parser buffer)
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parser.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/libavcodec
According to ISO/IEC 14996-12, size == 1 means a 64-bit extended-size
field occurs *after* the 32-bit box type, not before. This fix should
allow correct parsing of JXL files with extended-size boxes.
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parse.c | 6 +++---
libavcodec/jpegxl_parser.c
Two bug fixes related to the JPEG XL parser. They're not exactly related and
don't need to be applied in sequence.
v2 change: patches themselves are identical, but now there's a FATE test.
Leo Izen (3):
avcodec/jpegxl_parse{,r}: use correct ISOBMFF extended size location
avcodec
On 11/26/23 13:07, Thilo Borgmann wrote:
Am 26.11.2023 um 14:47 schrieb Leo Izen :
On 11/26/23 05:56, Anton Khirnov wrote:
Would be nice to have tests for these.
I have a sample at: https://buzo.us/l.jxl
It would test both of these patches. I can send a fate test for these to the ML
On 11/26/23 05:56, Anton Khirnov wrote:
Would be nice to have tests for these.
I have a sample at: https://buzo.us/l.jxl
It would test both of these patches. I can send a fate test for these to
the ML if the sample gets uploaded. I CC'd samples-requ...@ffmpeg.org as
well.
- Leo Izen
, why do this (and the avio version) have to be global?
What are they used for other than the iamf demuxer? Would it make sense
to have a static inline read_leb function defined in iamf.c?
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel
This patch allows the JXL parser to parse sequences of extremely small
files concatenated together. (e.g. smaller than the parser buffer)
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parser.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/libavcodec
Two bug fixes related to the JPEG XL parser. They're not exactly related and
don't need to be applied in sequence.
Leo Izen (2):
avcodec/jpegxl_parse{,r}: use correct ISOBMFF extended size location
avcodec/jpegxl_parser: fix parsing sequences of extremely small files
libavcodec
According to ISO/IEC 14996-12, size == 1 means a 64-bit extended-size
field occurs *after* the 32-bit box type, not before. This fix should
allow correct parsing of JXL files with extended-size boxes.
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parse.c | 6 +++---
libavcodec/jpegxl_parser.c
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy. Additionally, prints a warning to the log context if this
truncation occurred.
Signed-off-by: Leo Izen
---
libavformat/hls.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
Declaring the function argument as const fixes a warning down the line
that the const parameter is stripped. We don't modify this argument.
Signed-off-by: Leo Izen
---
fftools/ffplay_renderer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffplay_renderer.c b
have no issues with
the commit itself.)
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
On 10/30/23 09:55, Nicolas George wrote:
Leo Izen (12023-10-30):
difference: user data should not be silently truncated.
There isn't really a bug here, just an extraneous compiler warning.
Truncating user data silently is a bug. The warning is right and needs
proper fix.
Regards
On 10/30/23 03:51, Nicolas George wrote:
Leo Izen (12023-10-29):
But it will be nul-terminated in either case, so
there's no real difference between the old and new code, other than the
warning.
No real difference = you are not fixing the bug. There should
On 10/29/23 21:22, Lynne wrote:
it can be argued that the error margins are small enough to permit bitexactness
For what it's worth, the error margins for compliance are specified in
18181-3 and they're definitely within one pixel value for the various
bit depths supported by the codestream
On 10/29/23 20:23, Andreas Rheinhardt wrote:
Leo Izen:
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy.
Signed-off-by: Leo Izen
---
libavformat/hls.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b/libavformat
what you mean - JPEG XL is fully specified.
Are you thinking of mjpeg?
- Leo Izen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ
On 10/29/23 08:47, Leo Izen wrote:
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy.
Changes from v1:
- changed the length attribute, so now it has similar semantics to earlier.
This patch has the same semantics with regard to the null-termination
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy.
Signed-off-by: Leo Izen
---
libavformat/hls.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index f5f549b24d..39440176c9 100644
--- a/libavformat/hls.c
a warning.
It seems the appropriate fix here is to change strncpy to av_strlcpy but
also change the -2 to a -1. This will produce identical behavior to
before, but it won't cause the compiler to produce a warning that the
string might not be nul-terminated (cause it will always be).
On 10/26/23 06:54, Andreas Rheinhardt wrote:
Leo Izen:
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy.
Signed-off-by: Leo Izen
---
libavformat/hls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of
strncpy.
Signed-off-by: Leo Izen
---
libavformat/hls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index f5f549b24d..076f92ecfb 100644
--- a/libavformat/hls.c
Various parts of this file are restructured slightly for readability,
such as spacing in arithmetic operations, and putting `if (ret < 0)`
clauses on separate lines.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 241 +++-
1 file changed,
On 10/23/23 12:04, Michael Niedermayer wrote:
On Mon, Oct 23, 2023 at 02:10:35AM -0400, Leo Izen wrote:
On 10/22/23 17:51, Michael Niedermayer wrote:
This makes the code more testable as uninitialized fields are 0
and not random values from the last call
Signed-off-by: Michael Niedermayer
, 0, sizeof(*info))?
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 10/15/23 08:06, Leo Izen wrote:
On 10/7/23 21:36, Leo Izen wrote:
At various points through the function librsvg_decode_frame, errors are
returned from immediately without deallocating any allocated structs.
This patch both fixes those leaks, and also fixes the use of functions
On 10/14/23 20:49, Leo Izen wrote:
In f7ac3512f5b5cb8eb149f37300b43461d8e93af3 the size of the dynamically
allocated buffer was shrunk, but it was made too small for very small
alphabet sizes. This patch restores the size to prevent an OOB read.
Reported-by: Cole Dilorenzo
Signed-off-by: Leo
On 10/15/23 09:11, Lynne wrote:
Oct 15, 2023, 14:14 by leo.i...@gmail.com:
Adding myself for jpegxl* in avcodec as I'm the maintainer of this
parser.
Signed-off-by: Leo Izen
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Adding myself for jpegxl* in avcodec as I'm the maintainer of this
parser.
Signed-off-by: Leo Izen
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b5c116c3d4..b66c3d09a6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -181,6
1 - 100 of 529 matches
Mail list logo
