Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-05-01 Thread Yigithan Yigit
Included mem.h and made some changes about readability. v8-avfilter-af_volumedetect.c-Add-32bit-float-audio-sup.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-27 Thread Yiğithan Yiğit
According to Paul's private remarks I made this last patch. I would greatly appreciate it if anyone could take the time to review these changes. From 9d9ebcde761ce83c82c40f7537e7644f0c8d753b Mon Sep 17 00:00:00 2001 From: yigithanyigit Date: Tue, 12 Mar 2024 01:27:59 +0300 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-24 Thread Yiğithan Yiğit
Fixed some bugs that I not realized on previous commits. v2-0001-avfilter-af_volumedetect.c-Add-32bit-float-audio-sup.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-23 Thread Yiğithan Yiğit
Fixes #9613 --- libavfilter/af_volumedetect.c | 234 +- 1 file changed, 172 insertions(+), 62 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 8b001d1cf2..d13d043f88 100644 --- a/libavfilter/af_volumedetect.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-23 Thread Paul B Mahol
On Sat, Mar 23, 2024 at 3:28 PM Yiğithan Yiğit wrote: > Hi, > > According to your advices, I made some changes of mine last patch. I feel > like this one way more better. I removed trivial calculations but I want to > say I am not proud of how I handled histogram in float despite 16 bit >

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-23 Thread Yiğithan Yiğit
Hi, According to your advices, I made some changes of mine last patch. I feel like this one way more better. I removed trivial calculations but I want to say I am not proud of how I handled histogram in float despite 16 bit integer histogram. I am storing dB values instead of storing samples.

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-21 Thread Paul B Mahol
On Wed, Mar 20, 2024 at 11:55 PM Yiğithan Yiğit wrote: > > > On Mar 21, 2024, at 12:10 AM, Paul B Mahol wrote: > > > > Why? This is pointless. > > > > volumedetect have histogram output, float patch does not have it at all. > > Use astats filter. > > > > On Wed, Mar 20, 2024 at 9:47 PM Yiğithan

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-20 Thread Yiğithan Yiğit
> On Mar 21, 2024, at 12:10 AM, Paul B Mahol wrote: > > Why? This is pointless. > > volumedetect have histogram output, float patch does not have it at all. > Use astats filter. > > On Wed, Mar 20, 2024 at 9:47 PM Yiğithan Yiğit > wrote: > >> ___

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-20 Thread Paul B Mahol
Why? This is pointless. volumedetect have histogram output, float patch does not have it at all. Use astats filter. On Wed, Mar 20, 2024 at 9:47 PM Yiğithan Yiğit wrote: > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

[FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-20 Thread Yiğithan Yiğit
0001-avfilter-af_volumedetect.c-Add-32bit-float-audio-sup.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email