Re: NFS exports of ZFS snapshots broken

2023-11-23 Thread Rick Macklem
In any case, > > >> it seems to me that mnt_exjail should be set properly, e.g. by duping > > >> the one in the original mount structure. Probably ZFS is the only > > >> file system type that would need this added. > > > I've created a patch that I think does

Re: NFS exports of ZFS snapshots broken

2023-11-23 Thread Rick Macklem
d it here (this diff doesn't use -U99, so it might be > > easier to apply). > > It works for me in 13-stable, and looks plausible. The patch has now been fixed so that there is no race between vfs_exjail_clone() and a jail dying. I believe the current patch fixes the problem. The patch can be fou

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Mike Karels
t structure, >> it should be responsible for setting it up correctly. That could >> involve a vfs-level routine to do some of the cloning. In any case, >> it seems to me that mnt_exjail should be set properly, e.g. by duping >> the one in the original mount structure. Pr

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Rick Macklem
sn't use -U99, so it might be easier to apply). Hopefully this fixes the problem. Sorry for the breakage. rick > > Mike > > > rick > > ps: I added all the cc's back in because I want the > > ZFS folk to hopefully chime in. > > > >> > >

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Mike Karels
Mike >> >>> Do I need to search mountlist for it? >>> >>> rick >>> ps: The hack patch attached should fix the problem, but can only be >>> safely used if mountd/nfsd are not run in any jails. >>> >>>> >>>>

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Rick Macklem
've never done a snapshot.) > >> > >> Although this problem is not in 13.2, it will have shipped in 14.0. > >> > >> Any help with be appreciated, rick > >> > >>> > >>> Mike > >>>> > >>>>&

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Rick Macklem
ognize the > >>>>> sender and know the content is safe. If in doubt, forward suspicious > >>>>> emails to ith...@uoguelph.ca. > >>>>> > >>>>> > >>>>> Rick, have you been following this thread on freebsd-stable? I

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Rick Macklem
suspicious > > >>> emails to ith...@uoguelph.ca. > > >>> > > >>> > > >>> Rick, have you been following this thread on freebsd-stable? I have > > >>> been able > > >>> to reproduce this using a 13-stable server fr

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Ronald Klop
: freebsd-sta...@freebsd.org Subject: Re: NFS exports of ZFS snapshots broken Date: Fri, 17 Nov 2023 17:35:04 -0500 < said: I have not run into this, so I tried it just now. I had no problem. The server is 13.2, fully patched, the client is up-to-date -current, and the mount is v4. On

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Mark Millard
Rick Macklem wrote on Date: Sat, 18 Nov 2023 16:09:34 UTC: > . . . > I will try and get a test setup going here, which leads me to.. > how do I create a ZFS snapshot? (I do have a simple ZFS pool running > on a test machine, but I've never done a snapshot.) > . . . There is: "man zfs-snapshot"

Re: NFS exports of ZFS snapshots broken

2023-11-18 Thread Rick Macklem
ith a 13.2 server. > >>> The > >>> client was running 13.2. Any ideas? A full bisect seems fairly painful, > >>> but > >>> maybe you have an idea of points to try. Fortunately, these are all test > >>> systems that I can reboot at will.