> The variable, gxvalid->statetable.entry_glyphoffset_fmt, it is set
> by gxv module internally not imported from external font file (thus,
> malicious input data cannot set the value to the undefined
> value). So it is OK to remove the default case.
Done.
Werner
Sorry for lated response about this issue.
Yes, about this case, I agree with the removal of redundant
default case after the complete list of possible enum values.
The variable, gxvalid->statetable.entry_glyphoffset_fmt,
it is set by gxv module internally not imported from external
font file
On Wed, 20 Jan 2016 13:36:06 +0100, Werner LEMBERG said:
>
>>> The `default' case is redundant, since all possible enum values are
>>> covered in the `switch' statement.
>>
>> I personally prefer having code in front of me that I can prove
>> correct, than having to go fish for all the places
On 16-01-20 12:03 PM, Werner LEMBERG wrote:
>
>>> +#if 0
>>>default:
>>> GXV_SET_ERR_IF_PARANOID( FT_INVALID_FORMAT );
>>> goto Exit;
>>> +#endif
>>
>> What's this?!
>
> The `default' case is redundant, since all possible enum values are
> covered in the `switch'
On 16-01-19 07:16 PM, Werner LEMBERG wrote:
> +#if 0
>default:
> GXV_SET_ERR_IF_PARANOID( FT_INVALID_FORMAT );
> goto Exit;
> +#endif
What's this?!
___
Freetype-devel mailing list
Freetype-devel@nongnu.org
>> +#if 0
>>default:
>> GXV_SET_ERR_IF_PARANOID( FT_INVALID_FORMAT );
>> goto Exit;
>> +#endif
>
> What's this?!
The `default' case is redundant, since all possible enum values are
covered in the `switch' statement.
Toshiya-san, shall I completely remove this code?
>> The `default' case is redundant, since all possible enum values are
>> covered in the `switch' statement.
>
> I personally prefer having code in front of me that I can prove
> correct, than having to go fish for all the places that value in the
> switch statement is set to convince myself
