Re: [ft-devel] Error Description Strings

2018-08-30 Thread armin
>> Cross referencing the other thread: should I change 'error_string' >> to `error_string`? > > For consistency with the rest of the API documentation: Please no. Applied, woohoo :) ___ Freetype-devel mailing list Freetype-devel@nongnu.org

Re: [ft-devel] Error Description Strings

2018-08-29 Thread Werner LEMBERG
> Cross referencing the other thread: should I change 'error_string' > to `error_string`? For consistency with the rest of the API documentation: Please no. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org

Re: [ft-devel] Error Description Strings

2018-08-29 Thread armin
>> Please find pitch #2 attached. > > Excellent, thanks! Attached is my version with slight whitespace fixes; > please apply (together with a proper ChangeLog entry). Wonderful, thanks, will do :) Cross referencing the other thread: should I change 'error_string' to `error_string`? > Ah, and

Re: [ft-devel] Error Description Strings

2018-08-29 Thread Werner LEMBERG
> Please find pitch #2 attached. Excellent, thanks! Attached is my version with slight whitespace fixes; please apply (together with a proper ChangeLog entry). Ah, and `fterrors.c' should be added to the `_sources' string in `src/base/Jamfile' also. Werner diff --git

Re: [ft-devel] Error Description Strings

2018-08-28 Thread armin
Please find pitch #2 attached. > We now use our special Markdown flavour for documentation (in particular no > longer `xxx' but either `xxx` or 'xxx', depending on the intended use); please > update your patch accordingly. Oh right, sorry I forgot that, changed now (if I understand the new

Re: [ft-devel] Error Description Strings

2018-08-28 Thread Werner LEMBERG
> Please find my first proposal for `FT_Error_String' attached. Nice, thanks! > Feel free to request any changes; not only but especially regarding > documentation. We now use our special Markdown flavour for documentation (in particular no longer `xxx' but either `xxx` or 'xxx', depending on

Re: [ft-devel] Error Description Strings

2018-08-21 Thread Werner LEMBERG
> However, I am not sure if I completely understand the other thing: > do you prefer the solution by `N. Yoda' on StackOverflow (1) or the > solution presented in `fterrors.h' (2)? (the latter uses the array, > the former uses a switch/case) I don't care. What I dislike is that the #... lines

Re: [ft-devel] Error Description Strings

2018-08-21 Thread armin
https://stackoverflow.com/questions/31161284/how-can-i-get-the-corre sponding-error-string-from-an-ft-error-code is the best solution >>> >>> It is, but the code formatting in the link is extremely ugly and thus >>> hard to read and understand. >> >> What don't you like

Re: [ft-devel] Error Description Strings

2018-08-21 Thread Werner LEMBERG
>>> https://stackoverflow.com/questions/31161284/how-can-i-get-the-corresponding-error-string-from-an-ft-error-code >>> >>> is the best solution >> >> It is, but the code formatting in the link is extremely ugly and >> thus hard to read and understand. > > What don't you like about the

Re: [ft-devel] Error Description Strings

2018-08-20 Thread armin
>> I wonder what's the best solution to get FreeType's error strings from >> its error numbers? E.g. "cannot open resource" from `FT_THROW( >> Cannot_Open_Resource )'. Since I cannot locate anything in the docs > > This must be an oversight on your side, since FreeType comes with a complete >

Re: [ft-devel] Error Description Strings

2018-08-20 Thread Werner LEMBERG
> I wonder what's the best solution to get FreeType's error strings > from its error numbers? E.g. "cannot open resource" from > `FT_THROW( Cannot_Open_Resource )'. Since I cannot locate anything > in the docs This must be an oversight on your side, since FreeType comes with a complete

[ft-devel] Error Description Strings

2018-08-20 Thread armin
I wonder what's the best solution to get FreeType's error strings from its error numbers? E.g. "cannot open resource" from `FT_THROW( Cannot_Open_Resource )'. Since I cannot locate anything in the docs I wonder if https://stackoverflow.com/questions/31161284/how-can-i-get-the-corresponding