RFA: fix libstdc++ regression, simulator timeout from r205810

2013-12-19 Thread Hans-Peter Nilsson
Here's a patch that splits up 20_util/hash/chi2_quality.cc *and* increases some of the iteration numbers for simulator targets to something that passes for all working targets mentioned below. I am a bit worried about the stability of these tests and the implementation, seeing this amount of

Re: RFA: revert libstdc++ r205810: simulator workload increase caused regression

2013-12-15 Thread Hans-Peter Nilsson
From: Jonathan Wakely jwakely@gmail.com Date: Sun, 15 Dec 2013 11:38:43 +0100 On Dec 15, 2013 6:57 AM, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: From the revision range 205803:205810 (excluding:including) an on, my autotester for cris-elf reports a regression

Re: RFA: revert libstdc++ r205810: simulator workload increase caused regression

2013-12-15 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Sun, 15 Dec 2013 15:20:48 +0100 +// { dg-options -std=gnu++0x -DSAMPLES=3 { target { { arm*-* } simulator } } } +// { dg-options -std=gnu++0x -DSAMPLES=1 { target simulator } } JFTR, I managed to have two bugs here: 1 - the target tuple

RFA: revert libstdc++ r205810: simulator workload increase caused regression

2013-12-14 Thread Hans-Peter Nilsson
From the revision range 205803:205810 (excluding:including) an on, my autotester for cris-elf reports a regression: Running /tmp/hpautotest-gcc1/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ... WARNING: program timed out. FAIL: 20_util/hash/chi2_quality.cc execution test This appears

Re: Implement C11 _Atomic

2013-11-22 Thread Hans-Peter Nilsson
On Fri, 22 Nov 2013, Andrew MacLeod wrote: The target hook patch is checked into mainline, revision 205273. Thanks! The target patch is there too now; tested with the previous version of the hook-patch. I'm confident my autotester will yell at me if I goofed. gcc: * config/cris/cris.c

Re: [SH] PR 30807 - Add test case

2013-11-21 Thread Hans-Peter Nilsson
On Tue, 5 Nov 2013, Mike Stump wrote: On Nov 5, 2013, at 1:45 PM, Oleg Endo oleg.e...@t-online.de wrote: You're right, it's redundant. It should be just /* { dg-do compile } */ shouldn't it? Yup, that's my take. Or nothing at all, as compile seems to be the default here. (grep for

Re: Implement C11 _Atomic

2013-11-21 Thread Hans-Peter Nilsson
On Tue, 5 Nov 2013, Joseph S. Myers wrote: Thanks for doing this! However, without examples I have trouble reading out the bits I need as a target maintainer, and I can't read out the answers from the patch, so pardon a few questions. This patch, relative to trunk and based on work done on the

Re: Implement C11 _Atomic

2013-11-21 Thread Hans-Peter Nilsson
On Thu, 21 Nov 2013, Andrew MacLeod wrote: Or is that part also required for anything-other-than-ordinary-C-type alignment for the target; say, natural 4-byte alignment of 4-byte-types for targets where alignment is otherwise packed; where only 1-byte alignment of the basic type is

Re: Implement C11 _Atomic

2013-11-21 Thread Hans-Peter Nilsson
On Thu, 21 Nov 2013, Andrew MacLeod wrote: I can bootstrap and check this on x86 to make sure it doesnt affect anything, and you can fool with it and see if you can get your desired results with your port. Success! For the record, tested together with the attached patch for the CRIS ports,

Re: Implement C11 _Atomic

2013-11-21 Thread Hans-Peter Nilsson
On Thu, 21 Nov 2013, Hans-Peter Nilsson wrote: with this/these patches at least I'll be able to tell people that _Atomic for C11 works. Oh right, gcc still doesn't remove target-introduced manual alignment checks (when expanding atomic intrinsics), but at least gcc makes sure it's aligned

Re: Implement C11 _Atomic

2013-11-21 Thread Hans-Peter Nilsson
On Thu, 21 Nov 2013, Andrew MacLeod wrote: If we add the hook for atomic_align_for_mode, and change the initalizers in tree.c, any target which doesnt need/use the hook should be unaffected. So everything remains as it is today. So Putting the hook in shouldn't be an issue. Then you can

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-18 Thread Hans-Peter Nilsson
From: Ian Lance Taylor i...@google.com Date: Tue, 19 Nov 2013 02:11:29 +0100 2013-11-18 Ian Lance Taylor i...@google.com * configure.ac: Check for support of __atomic extensions. * internal.h: Declare or #define atomic functions for use in backtrace code. *

RE: [PATCH 1/n] Add conditional compare support

2013-10-30 Thread Hans-Peter Nilsson
On Wed, 30 Oct 2013, Zhenqiang Chen wrote: -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Hans-Peter Nilsson One thing I don't see other people mentioning, is that this patch has just too much code inside #ifdef

ICE with [PATCH, PR 10474] Split live-ranges of function arguments to help shrink-wrapping

2013-10-30 Thread Hans-Peter Nilsson
From: Jakub Jelinek ja...@redhat.com Date: Thu, 31 Oct 2013 00:16:41 +0100 On Fri, Oct 25, 2013 at 05:19:06PM +0200, Martin Jambor wrote: 2013-10-23 Martin Jambor mjam...@suse.cz PR rtl-optimization/10474 * ira.c (find_moveable_pseudos): Do not calculate dominance info

RE: [PATCH 1/n] Add conditional compare support

2013-10-28 Thread Hans-Peter Nilsson
On Tue, 22 Oct 2013, Zhenqiang Chen wrote: ChangeLog: 2013-10-22 Zhenqiang Chen zhenqiang.c...@linaro.org * config/arm/arm.c (arm_fixed_condition_code_regs, arm_ccmode_to_code, arm_select_dominance_ccmp_mode): New functions. (arm_select_dominance_cc_mode_1): New function

Re: Where does the gcc_tg.o linked in tests come from?

2013-10-27 Thread Hans-Peter Nilsson
On Fri, 11 Oct 2013, Brooks Moses wrote: I'm trying to reproduce a test failure outside the Dejagnu testsuite, and I noticed that the file I'm trying to recompile is linked with a gcc_tg.o file. Based on the missing-symbol errors I get when I don't include it, it seems to provide things like

Fix for cris-elf breakage from mudflap removal, take 2

2013-10-27 Thread Hans-Peter Nilsson
PRED_NORETURN seems a better match; not that I see anything in the current source that actually treats them differently other than generating them, but my grep-fu may be weak and certainly my crystall-ball-fu is. After testing (no regressions compared to r204080 before the breakage), committed.

Re: Minor mudflap fallout

2013-10-26 Thread Hans-Peter Nilsson
On Sat, 26 Oct 2013, Jeff Law wrote: It appears that mudflap creeped into one additional file (targhooks) between the time I bootstrapped the final change and committed the change. This also elimiantes PRED_MUDFLAP which I missed the first time around. Given this is currently breaking

Fixing cris-* breakage (was: Minor mudflap fallout)

2013-10-26 Thread Hans-Peter Nilsson
On Sat, 26 Oct 2013, Hans-Peter Nilsson wrote: Yeah, cris-elf is broken too. I use PRED_MUDFLAP in cris_emit_trap_for_misalignment, which should explain its use. Is there a replacement? Actually looking at predict.def, I see PRED_COLD_LABEL, which wasn't there when I worked with this code

Re: Minor mudflap fallout

2013-10-26 Thread Hans-Peter Nilsson
On Sat, 26 Oct 2013, Andrew Pinski wrote: I think you could use PRED_NORETURN which should be a reasonable replacement. I've totally missed that one, thanks. brgds, H-P

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-25 Thread Hans-Peter Nilsson
On Fri, 25 Oct 2013, Mike Stump wrote: On Oct 24, 2013, at 7:33 PM, Hans-Peter Nilsson h...@bitrange.com wrote: On Thu, 24 Oct 2013, Hans-Peter Nilsson wrote: I too would like to include this change on those branches, as recent generic newlib changes has caused these tests to break

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Hans-Peter Nilsson
On Mon, 21 Oct 2013, Mike Stump wrote: On Oct 21, 2013, at 3:28 AM, Vidya Praveen vidyaprav...@arm.com wrote: Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can be a issue especially since they define uint32_t. OK for 4.7, 4.8? For release branches, you'd

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Hans-Peter Nilsson
On Thu, 24 Oct 2013, Hans-Peter Nilsson wrote: On Mon, 21 Oct 2013, Mike Stump wrote: On Oct 21, 2013, at 3:28 AM, Vidya Praveen vidyaprav...@arm.com wrote: Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can be a issue especially since they define uint32_t

Committed: fix more testsuite fallout from cost model patch.

2013-10-17 Thread Hans-Peter Nilsson
For cris-elf (no SIMD), the following tests regressed just as for the similar tests mentioned in PR58556. These apparently don't fail for the targets mentioned there for some reason, but I see in the mail thread with the quoted subject there was no conscious adjustment to the test-suite. Thus I

Committed: CRIS: new multilib for v8, libgcc improvements and move to soft-fp.

2013-10-15 Thread Hans-Peter Nilsson
There's a page-full or two of numbers reported here with the background, but maintainers of software-floating-point ports used with a microcontroller may find that of use, if they're on a cycle or size budget and consider fp-bit vs. soft-fp. For an on-chip controller subsystem with a CRIS CPU,

Re: [PATCH] Portable Volatility Warning

2013-09-04 Thread Hans-Peter Nilsson
On Tue, 3 Sep 2013, Richard Biener wrote: I think the warning can be completely implemented inside struct-layout.c for example in finish_bitfield_representative (if you pass that the first field in the group, too). Of course that is at the expense of warning for struct declarations rather

Re: [patch 4/4] -fstrict-volatile-bitfields cleanup v3: remove from defaults on all targets

2013-09-04 Thread Hans-Peter Nilsson
From: Bernd Edlinger bernd.edlin...@hotmail.de Date: Wed, 4 Sep 2013 10:15:22 +0200 Even driver code rarely uses bit-fields for register access, because that is inherently non-portabe. Reason: the bit positions are completely different on little- and big-endian targets. Most drivers I have

Re: [PATCH] Add atomic type qualifier

2013-07-26 Thread Hans-Peter Nilsson
On Fri, 26 Jul 2013, Andrew MacLeod wrote: This patch adds an atomic type qualifier to GCC. It can be accessed via __attribute__((atomic)) or in C11 mode via the _Atomic keyword. HP, you might want to give this a try and see if you can get the alignment correct for the cris port finally :-)

RE: [ping] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-07-23 Thread Hans-Peter Nilsson
On Tue, 23 Jul 2013, Bernd Edlinger wrote: H-P: I hope you can approve my little patch for trunk now, although it turned out to be less trivial than I'd have expected. Sorry, I'm not an approver. (People who are not approvers are welcome to review any gcc patch where they might say something

Re: [patch 4/4] -fstrict-volatile-bitfields cleanup v3: remove from defaults on all targets

2013-07-05 Thread Hans-Peter Nilsson
On Mon, 1 Jul 2013, Andrew Pinski wrote: On Sun, Jun 30, 2013 at 8:32 PM, DJ Delorie d...@redhat.com wrote: Given how much trouble I went through to make it the default, I'd rather not revert all that work... especially since the flag is *required* for proper operation of the hardware

Committed: fix for frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2013-07-03 Thread Hans-Peter Nilsson
Eric Botcazou asked that I re-apply this previously reverted patch, so here goes. Bootstrapped+regression-test x86_64-unknown-linux-gnu at r200585 with and without -m32. The 32-bit i686-* aka. -m32 previously exposed PR55030. Though that PR was originally about the regression causing the

Re: [PATCH] Fix for PR 57692

2013-07-02 Thread Hans-Peter Nilsson
On Wed, 26 Jun 2013, Iyer, Balaji V wrote: Hello Everyone, This patch will fix a FAIL in one of the test cases for array notations. The reason for fail is that the array sizes were huge and thus it was causing a stack overflow. This patch should fix the issue. I am committing this

Re: new port: msp430-elf, revision 3

2013-06-19 Thread Hans-Peter Nilsson
On Wed, 19 Jun 2013, DJ Delorie wrote: Third revision, mostly the same as the last, haven't heard any additional feedback in the last few weeks. Ok to commit yet? [libgcc] * config.host (msp*-*-elf): New. * config/msp430/: New port. A random spotting; copyright header

Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)

2013-06-07 Thread Hans-Peter Nilsson
On Fri, 7 Jun 2013, Richard Henderson wrote: I've had a brief look over the instances of D_A within the tree atm. Most of them carry the cut-n-paste comment for the same reasons. These I believe never intended an ABI change, and were really only interested in optimization. But these I think

Re: Symtab cleanups 4/17

2013-06-06 Thread Hans-Peter Nilsson
From: Jan Hubicka hubi...@ucw.cz Date: Wed, 5 Jun 2013 16:18:52 +0200 * class.c (emit_register_classes_in_jcr_section): Use DECL_PRESERVE_P instead of mark_decl_referenced. * decl2.c (maybe_make_one_only): Use forced_by_abi instad of mark_decl_referenced.

Re: Delay slot filling - what still matters, and what doesn't matter so much anymore?

2013-05-21 Thread Hans-Peter Nilsson
(People, please don't use my @gcc.gnu.org address if you need to ping me; not sure why Steven used that. I also changed the other CC'ed addresses to the corresponding relevant one from MAINTAINERS. Looks like I'm month+ behind on reading the lists again... On the plus side, maybe a reply-bump

Re: More vector folding

2013-05-17 Thread Hans-Peter Nilsson
From: Marc Glisse marc.gli...@inria.fr Date: Tue, 14 May 2013 13:47:23 +0200 Here is what I tested during the night, I'll just rename the function. I took the chance to remove an unnecessary alternative in TRUTH_XOR_EXPR. Passes bootstrap+testsuite on x86_64-linux-gnu. 2013-05-14 Marc

Breakage with your libstdc++ allocator patch

2013-04-22 Thread Hans-Peter Nilsson
For cris-elf at r198164: ... libtool: compile: /tmp/hpautotest-gcc0/cris-elf/gccobj/./gcc/xgcc -shared-libgcc -B/tmp/hpautotest-gcc0/cris-elf/gccobj/./gcc -nostdinc++ -L/tmp/hpautotest-gcc0/cris-elf/gccobj/cris-elf/libstdc++-v3/src

Re: [wwwdocs] ftp.axis.se only works via http these days

2013-03-31 Thread Hans-Peter Nilsson
for + lia href=http://ftp.axis.se/pub/users/hp/pgccfd/;Porting GCC for Dunces/a by Hans-Peter Nilsson lt;a href=mailto:hans-peter.nils...@axis.com;hans-peter.nils...@axis.com/agt;./li lia href=http://cobolforgcc.sourceforge.net/cobol_toc.html;Using, brgds, H-P

RE: Modeling predicate registers with more than one bit

2013-03-26 Thread Hans-Peter Nilsson
On Tue, 26 Mar 2013, Paulo Matos wrote: -Original Message- From: Hans-Peter Nilsson [mailto:h...@bitrange.com] Sent: 05 March 2013 01:45 To: Paulo Matos Cc: gcc@gcc.gnu.org Subject: Re: Modeling predicate registers with more than one bit Except for CCmodes being dependent

Re: Confusion about delay slots and using condition-code register

2013-03-14 Thread Hans-Peter Nilsson
On Wed, 6 Mar 2013, Alan Lehotsky wrote: So, am I constructing my RTL incorrectly? No. Do I need to be making the clobbers inside a parallel instead of just emitting them sequentially? Exactly. (define_insn *addsi [(set (match_operand:SI 0 nonimmediate_operand =rm,rm,rS,rm)

Re: Modeling predicate registers with more than one bit

2013-03-04 Thread Hans-Peter Nilsson
On Thu, 28 Feb 2013, Paulo Matos wrote: Hello, I am looking at how to correctly model in GCC predicate registers that have more than one bit and the value set into to the predicate register after a comparison depends on the size of the comparison. I have looked into GCC backends but

vec_concat, vec_duplicate doc updated (was: Re: question about section 10.12)

2013-02-21 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Mon, 28 Jan 2013 23:14:21 +0100 * doc/rtl.texi (vec_concat, vec_duplicate): Mention that scalars are valid operands. Finally committed as obvious after brief check of generated dvi and info. brgds, H-P

closing PR's (was Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support)

2013-02-20 Thread Hans-Peter Nilsson
On Mon, 28 Jan 2013, nick clifton wrote: Also, could you close its duplicates, bugs 36798 and 36966? Sorry no. I do not actually own these PRs, so I cannot close them. :-( Sorry if I misinterpret, but it seems a reminder is in order: magic powers are attached to whome...@gcc.gnu.org accounts

Re: question about section 10.12

2013-01-26 Thread Hans-Peter Nilsson
From: Kenneth Zadeck zad...@naturalbridge.com Date: Sat, 26 Jan 2013 16:19:40 +0100 the definition of vec_duplicate in section 10.12 seems to restrictive. i have seen examples where the small vector is really a scalar. Should the doc be small vector or scalar? Yes. This patch has been

Re: [RFA:] fix failing gfortran.dg/inquire_10.f90 for newlib targets

2013-01-20 Thread Hans-Peter Nilsson
From: Janne Blomqvist blomqvist.ja...@gmail.com Date: Sun, 20 Jan 2013 20:14:11 +0100 On Sun, Jan 20, 2013 at 2:29 AM, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: Ever since it was changed to a run test (from the default compile, i.e. just producing assembly code), the test

[RFA:] fix failing gfortran.dg/inquire_10.f90 for newlib targets

2013-01-19 Thread Hans-Peter Nilsson
Ever since it was changed to a run test (from the default compile, i.e. just producing assembly code), the test gfortran.dg/inquire_10.f90 has failed for newlib targets while linking, because (besides cygwin and some linux support), newlib doesn't have getcwd: /tmp/ccNhxU2l.o: In function

Re: [testsuite] add option to LTO flags for c-torture/execute/builtins tests

2013-01-15 Thread Hans-Peter Nilsson
On Tue, 15 Jan 2013, Janis Johnson wrote: Most of the tests in gcc.c-torture/execute/builtins that use LTO torture options -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects fail to link on EABI and ELF targets with multiple definitions for either memset or strlen. I filed PR testsuite/55994

Re: [RFA:] fix group-loads of VOIDmode constants, expr.c:emit_group_load_1

2012-12-02 Thread Hans-Peter Nilsson
On Sat, 1 Dec 2012, Eric Botcazou wrote: Of course this matters only to 64bit (i.e. registersize) values like TImode, alias __int128. The problem here is that group-loading a constant for a function return-value doesn't work; it's passed to simplify_gen_subreg which horks on the VOIDmode

[RFA:] fix group-loads of VOIDmode constants, expr.c:emit_group_load_1

2012-11-30 Thread Hans-Peter Nilsson
(No cans of worms opened here, I believe...) For MMIX with the default, Knuth's ABI (returning values in register $0, through the register stack), function return values are prepared in a register-swapped fashion due to the way the register stack works, which has to be expressed as: (parallel [

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-28 Thread Hans-Peter Nilsson
On Tue, 27 Nov 2012, Jakub Jelinek wrote: 2012-11-26 Jakub Jelinek ja...@redhat.com PR debug/36728 PR debug/55467 * cselib.c (cselib_process_insn): If cselib_preserve_constants, don't reset table and exit early on volatile insns and setjmp. Reset table

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-27 Thread Hans-Peter Nilsson
I quoted the whole discussion, see a single line below. On Mon, 19 Nov 2012, Eric Botcazou wrote: Unfortunately, it causes regressions; read on for a very brief analysis. For x86_64-linux (base multilib): Running

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-27 Thread Hans-Peter Nilsson
On Tue, 27 Nov 2012, Jakub Jelinek wrote: On Tue, Nov 27, 2012 at 06:44:23AM -0500, Hans-Peter Nilsson wrote: JFTR: No I didn't, Eric wrote the below. But, it made sense to me. :) We apparently have a small conflict between the meaning of volatile asms with operands at the source

Re: [Patch,testsuite] ad PR52641: More fixes for not-so-common targets

2012-11-26 Thread Hans-Peter Nilsson
On Mon, 26 Nov 2012, Georg-Johann Lay wrote: Hans-Peter Nilsson wrote: On Fri, 23 Nov 2012, Georg-Johann Lay wrote: Here are some more fixes for 16-bit int and similar. * gcc.c-torture/execute/20120919-1.x: New file (int32plus). No, you should be able to use dg-directives

Re: r193821 - in /trunk/gcc: ChangeLog common.opt d...

2012-11-26 Thread Hans-Peter Nilsson
I don't see this posted on gcc-patches@, but... On Mon, 26 Nov 2012, ste...@gcc.gnu.org wrote: testsuite/ * testsuite/gcc.dg/20050811-1.c: Change -dv option to -graph option to -fdump-rtl-all. * testsuite/gcc.dg/pr37858.c: Remove -dv option. ...looks like you missed:

Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN

2012-11-25 Thread Hans-Peter Nilsson
On Sun, 25 Nov 2012, Steven Bosscher wrote: stop_search_p will reach the default case on DEBUG_INSN, and the default case is gcc_unreachable(). I suppose this means nobody is using DWARF3+ on a dbr_sched target, it can't possibly ever have worked. Eric? There must be something else

Committed: handle negative numbers in gcc-gdb-test.exp

2012-11-24 Thread Hans-Peter Nilsson
Without this, I got weird ERRORs and those Tcl backtraces you come to hate, instead of the expected FAILs. Committed as obvious after running a failing guality test and obvserving the intended change. (Well ok, *adding an explanatory comment* is apparently not obvious, but I'll take that

Re: [Patch,testsuite] ad PR52641: More fixes for not-so-common targets

2012-11-24 Thread Hans-Peter Nilsson
On Fri, 23 Nov 2012, Georg-Johann Lay wrote: Here are some more fixes for 16-bit int and similar. * gcc.c-torture/execute/20120919-1.x: New file (int32plus). No, you should be able to use dg-directives in the main file these days. (The .x files are obsolete since a few years, IIRC.)

Re: [PATCH] Allocate extra 16 bytes for -fsanitize=address

2012-11-24 Thread Hans-Peter Nilsson
On Fri, 23 Nov 2012, H.J. Lu wrote: On Fri, Nov 23, 2012 at 9:38 AM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Nov 23, 2012 at 09:23:37AM -0800, H.J. Lu wrote: This patch allocates extra 16 bytes for -fsanitize=address so that asan won't report read beyond memory buffer. It is used by

Re: [PATCH] Remove unused DELAY_SLOTS_FOR_EPILOGUE target macro

2012-11-24 Thread Hans-Peter Nilsson
On Sat, 24 Nov 2012, Steven Bosscher wrote: Hello, The DELAY_SLOTS_FOR_EPILOGUE target macro, and the related ELIGIBLE_FOR_EPILOGUE_DELAY macro, are unused. The attached patch removes them. OK for trunk? Obviously; Jeff Law preapproved their removal long ago. (I forgot about it.) But

Re: Reduce complette unrolling peeling limits

2012-11-23 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Jan Hubicka wrote: this patch reduces max-peeled-insns and max-completely-peeled-insns from 400 to 100. The reason why I am doing this is that I want to reduce code bloat caused by my cunroll work that enabled a lot more unrolling then previously

Re: [PATCH, RFC] Dumping expanded MD files

2012-11-23 Thread Hans-Peter Nilsson
On Thu, 22 Nov 2012, Kirill Yukhin wrote: Hi folks, This patch adds an utility for dumping MD-files after iterators and define_substs expanding. The new utility is named genmddump and is built along with other gen* programs. I also added new target to Makefile to invoke this utility.

Re: [RFC PATCH] Masked load/store vectorization

2012-11-20 Thread Hans-Peter Nilsson
On Tue, 20 Nov 2012, Jakub Jelinek wrote: 2012-11-20 Jakub Jelinek ja...@redhat.com * Makefile.in (tree-if-conv.o): Depend on $(TARGET_H), $(EXPR_H) and $(OPTABS_H). * config/i386/sse.md (maskloadmode, maskstoremode): New expanders. (etc., new patterns, but nothing for

Re: RFC - Alternatives to gengtype

2012-11-19 Thread Hans-Peter Nilsson
On Mon, 19 Nov 2012, Lawrence Crowl wrote: On 11/17/12, Hans-Peter Nilsson h...@bitrange.com wrote: On Thu, 15 Nov 2012, Diego Novillo wrote: === Approach: Move GTY to cc1plus. Instead of a separate weak parser, we would make cc1plus understand GTY attributes. The compiler would

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, H.J. Lu wrote: On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini bonz...@gnu.org wrote: Il 18/11/2012 00:54, H.J. Lu ha scritto: +@if gcc-bootstrap +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sat, 17 Nov 2012, Diego Novillo wrote: I have now committed all 25 parts of this patch as rev 193595. Please CC me on any problems that you think may be related to this rewrite. That seems to have trigged some bug in gcc-4.4-era. See PR55381. There are a lot of suspicious warnings from

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Diego Novillo wrote: My cris-elf builds worked fine, but config-list.mk only builds stage 1, it does not build libgfortran. Can you give me instructions on how to build your target on my x86 workstation? Better see the PR for cc1 command-line and preprocessed C-file.

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Andreas Tobler wrote: Is there a minimum gcc to bootstrap current trunk? I currently fail to bootstrap trunk with a 4.2.1 gcc, but a 4.6 succeeds. A gcc-4.1.2 has worked for me in the past, before this recent vec.h change. I think that's the minimum version reportedly

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Andreas Tobler wrote: On 18.11.12 20:11, Hans-Peter Nilsson wrote: On Sun, 18 Nov 2012, Andreas Tobler wrote: Is there a minimum gcc to bootstrap current trunk? I currently fail to bootstrap trunk with a 4.2.1 gcc, but a 4.6 succeeds. A gcc-4.1.2 has worked

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Paolo Bonzini wrote: Il 18/11/2012 16:59, Hans-Peter Nilsson ha scritto: Nice, but I agree with the other poster that this'd IMHO be better as --enable-checking=asan (or actually, --enable-checking=all,asan). Yeah, that's a good thing to support too. However, you

Re: RFC - Alternatives to gengtype

2012-11-17 Thread Hans-Peter Nilsson
On Thu, 15 Nov 2012, Diego Novillo wrote: === Approach: Move GTY to cc1plus. Instead of a separate weak parser, we would make cc1plus understand GTY attributes. The compiler would emit IL in the object files instead of generating source. This solution would require a first boot stage that

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-17 Thread Hans-Peter Nilsson
On Wed, 14 Nov 2012, Jakub Jelinek wrote: Which brings us to the question of what to do with the patch for 4.8. It's true that you made the deadline for stage1 closure. But there will be no users of this feature, so it begs the question of why we should apply it now. Have you a

Re: [COMMITTED] Move libsanitizer configure logic to subdirectory

2012-11-16 Thread Hans-Peter Nilsson
On Tue, 13 Nov 2012, Richard Henderson wrote: As discussed elsewhere. Tested on x86_64-linux. +2012-11-13 Richard Henderson r...@redhat.com + + * configure.ac: Move libsanitizer logic to subdirectory. + * configure: Regenerate. + Thanks and sorry for copypasting the wrong

Re: [Committed] Add testcase

2012-11-15 Thread Hans-Peter Nilsson
On Fri, 9 Nov 2012, Andrew Pinski wrote: Committed the testcase as obvious after a quick test to make sure it works. Note someone might need to mark the testcase as only executable on targets which have 32bit ints. Someone like you? There are plenty of greppable effective-target attributes

Regression with [C++11] PR54413 Option for turning off compiler extensions for numeric literals.

2012-11-14 Thread Hans-Peter Nilsson
From: Ed Smith-Rowland 3dw...@verizon.net Date: Fri, 9 Nov 2012 05:55:16 +0100 libcpp 2012-11-09 Ed Smith-Rowland 3dw...@verizon.net PR c++/54413 * include/cpplib.h (cpp_interpret_float_suffix): Add cpp_reader* arg. (cpp_interpret_int_suffix): Add cpp_reader*

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
From: Dodji Seketeli do...@redhat.com Date: Tue, 13 Nov 2012 16:04:12 +0100 I guess when the issue of the missing files is resolved, we can enable building libsanitizer on Darwin proper. Here is the patchlet I am proposing so far http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00993.html.

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
From: Richard Henderson r...@redhat.com Date: Tue, 13 Nov 2012 21:38:40 +0100 On 11/13/2012 05:24 AM, Jakub Jelinek wrote: Yes. And it shouldn't be just based on target CPU, but also based on target OS, I don't think libsanitizer supports anything but linux (glibc + maybe android) right

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
From: Richard Henderson r...@redhat.com Date: Wed, 14 Nov 2012 02:34:32 +0100 On 11/13/2012 05:20 PM, Hans-Peter Nilsson wrote: Right. And, I think it's worth to repeat ;) that IMHO best to there simply check that -faddress-sanitizer can compile error-free (i.e

Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-12 Thread Hans-Peter Nilsson
While the fallout(*) from the libsanitizer commit is handled, it's obvious it should have a noconfigdirs= section in toplevel/configure.ac like the other target libs. Here's what I committed after observing that a cris-elf build passed, where it previously failed building libsanitizer which

Committed: Fix PR55257: g++.dg/debug/dwarf2/non-virtual-thunk.C and heads-up target maintainers

2012-11-12 Thread Hans-Peter Nilsson
...those of you who don't have the equivalent of the patch below in your ports, that is. You'll likely only notice through a slightly reduced debugging experience and g++.dg/debug/dwarf2/non-virtual-thunk.C failing. Yes, the docs should mention these functions need to be called IMHO obviously,

[RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-11 Thread Hans-Peter Nilsson
The problem exposed in PR55030 (repeatable on x86_64-linux with -m32 at r192676) is that the fake-frame-pointer frame is replaced with the actual-frame-pointer bp in cse1, around the critical insn in __builtin_setjmp_receiver that restores their defined offset. The patch in PR55030/r192676

Re: patch fixing a test for PR55151

2012-11-08 Thread Hans-Peter Nilsson
On Wed, 7 Nov 2012, Vladimir Makarov wrote: On 12-11-07 5:27 PM, H.J. Lu wrote: You should check !ia32 target: /* { dg-do compile { target { ! { ia32 } } } } */ Thanks, H.J. I've just fixed it. Index: testsuite/ChangeLog

Re: [RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-05 Thread Hans-Peter Nilsson
From: Eric Botcazou ebotca...@adacore.com Date: Mon, 5 Nov 2012 15:29:11 +0100 But, for cris-elf (and reasonably the same for other targets) there might not be such a constant-pool entry in the first place: the vectors are too short to rule out piecewise initialization as optimal for

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-04 Thread Hans-Peter Nilsson
On Sun, 4 Nov 2012, Kirill Yukhin wrote: Hi, But... I don't really understand it, so here's some feedback on the documentation: Regarding the language, a definite article is Patch with fixed doc is attached. Changelog is the same Is it OK? The structure is much improved and quite

[RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-02 Thread Hans-Peter Nilsson
Due to weird circumstances detailed in the PR, this test briefly passed (it has always failed before), so technically I'm fixing a regression. :) The test checks that a certain label is mentioned twice; being mentioned once infers that there are two identical initializer vectors in the

Re: [PATCH] Fix CDDCE miscompilation (PR tree-optimization/55018)

2012-11-01 Thread Hans-Peter Nilsson
From: Steven Bosscher stevenb@gmail.com Date: Sun, 28 Oct 2012 19:33:29 +0100 On Mon, Oct 22, 2012 at 11:09 PM, Jakub Jelinek wrote: On Mon, Oct 22, 2012 at 10:51:43PM +0200, Steven Bosscher wrote: Wouldn't it be way cheaper to just export dfs_find_deadend from cfganal.c and call it

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-10-31 Thread Hans-Peter Nilsson
(CC list trimmed.) On Wed, 31 Oct 2012, Kirill Yukhin wrote: Hi, This patch introduces a new RTL expression called define_subst and required by it define_subst_attr. The new feature allows to make MD-files more compact - it defines a rule by which a parser could generate modified versions

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-29 Thread Hans-Peter Nilsson
On Wed, 24 Oct 2012, Dodji Seketeli wrote: Jakub Jelinek ja...@redhat.com writes: On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote: * asan.c (insert_if_then_before_iter) (instrument_mem_region_access) (maybe_instrument_builtin_call, maybe_instrument_call): New

Re: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-22 Thread Hans-Peter Nilsson
On Tue, 23 Oct 2012, Dominique Dhumieres wrote: This patch (r192676) is probably causing FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os

Committed: fix gcc.dg/webizer.c (the trivial part :)

2012-10-21 Thread Hans-Peter Nilsson
Committed as obvious. Without this, mmix-knuth-mmixware exited with 2256, likely a return-address left over in the return-value-register. I used __builtin_exit just to avoid declarations or includes; the default implicit declaration apparently incompatible with this use. I saw nothing in the

Re: Committed: fix gcc.dg/webizer.c (the trivial part :)

2012-10-21 Thread Hans-Peter Nilsson
On Sun, 21 Oct 2012, Andreas Schwab wrote: Hans-Peter Nilsson h...@bitrange.com writes: I used __builtin_exit just to avoid declarations or includes; A return 0 would have worked just as well. It's not the preferred method. Fail: abort(). Pass: exit(0). Don't remember where I read

Committed, libgcc MMIX: implement static marking of program and data memory

2012-10-20 Thread Hans-Peter Nilsson
- PUSHJ $2,_init #ifdef __MMIX_ABI_GNU__ brgds, H-PCopyright 2012 Hans-Peter Nilsson. This file may be freely copied and distributed, provided that no changes whatsoever are made. Ah, just kidding: you may change it as you like, except that this paragraph, including the above attribution

Ping: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-20 Thread Hans-Peter Nilsson
CC:ing middle-end maintainers this time. I was a bit surprised when Eric Botcazou wrote in his review, quoted below, that he's not one of you. Maybe approve that too? On Mon, 15 Oct 2012, Hans-Peter Nilsson wrote: On Fri, 12 Oct 2012, Eric Botcazou wrote: (insn 168 49 51 3 (set (reg/f:DI

Committed: skip testsuite/23_containers/bitset/45713.cc for mmix-*-*.

2012-10-20 Thread Hans-Peter Nilsson
For mmix-knuth-mmixware, MAX_FIXED_MODE_SIZE is the default, GET_MODE_BITSIZE (DImode), which of course isn't larger than the size-type, the same size on this 64-bit target. I don't think making it larger (i.e. TImode) would help: that seems instead likely to introduce awkward spurious

breakage with [v3] (almost) finish scoped_allocator

2012-10-19 Thread Hans-Peter Nilsson
From: Jonathan Wakely jwakely@gmail.com Date: Fri, 19 Oct 2012 18:16:51 +0200 This adds support for piecewise construction of std::pair by scoped_allocator_adaptor. The only thing missing from scoped_allocator_adaptor now is that my definition of OUTERMOST isn't recursive so doesn't

Committed, MMIX: fix */builtin-apply-2.c for an instrumented setup.

2012-10-15 Thread Hans-Peter Nilsson
When running the test-suite for these tests on an instrumented mmix simulator (plus gcc and newlib patches to match) that, instead of silently allocating zeros, barfs on accesses beyond the defined stack, these tests fail because of that check. There are no stack parameters to copy, so there's

Re: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-15 Thread Hans-Peter Nilsson
On Fri, 12 Oct 2012, Eric Botcazou wrote: (insn 168 49 51 3 (set (reg/f:DI 253 $253) (plus:DI (reg/f:DI 253 $253) (const_int 24 [0x18]))) /tmp/mmiximp2/gcc/gcc/testsuite/gcc.c-torture/execute/built-in-setjmp.c:21 -1 (nil)) (insn 51 168 52 3 (clobber (reg/f:DI 253

Committed, MMIX: fix INCOMING_REGNO / OUTGOING_REGNO for return-value

2012-10-14 Thread Hans-Peter Nilsson
Back then, I must've missed that INCOMING_REGNO / OUTGOING_REGNO are used to map return-value-register/s too. Fixes: FAIL: gcc.dg/builtin-apply4.c execution test ... FAIL: gcc.dg/builtin-return-1.c execution test ... FAIL: gcc.dg/torture/stackalign/builtin-apply-4.c -O0 execution test FAIL:

Committed, PR54897 (was: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2))

2012-10-11 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Thu, 11 Oct 2012 02:13:32 +0200 There's now an excess error: x/libstdc++-v3/testsuite/23_containers/bitset/45713.cc:24:55: error: size of array 'test' is not an integral constant-expression int test[sizeof(std::bitset0x) != 1 ? 1 : -1

[RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-11 Thread Hans-Peter Nilsson
The md.texi entry for nonlocal_goto_receiver says A typical reason why you might need this pattern is if some value, such as a pointer to a global table, must be restored when the frame pointer is restored. Note that a nonlocal goto only occurs within a unit-of-translation, so a global table

<    4   5   6   7   8   9   10   11   12   13   >