Re: Question on patch -fprofile-partial-training

2023-05-09 Thread Martin Liška
On 5/4/23 15:37, Qing Zhao wrote: On May 4, 2023, at 9:05 AM, Martin Liška wrote: On 5/4/23 14:54, Qing Zhao wrote: On May 4, 2023, at 4:30 AM, Martin Liška wrote: On 5/3/23 21:10, Qing Zhao via Gcc-patches wrote: Hi, Jan, You added the following patch into gcc10: From

Re: Question on patch -fprofile-partial-training

2023-05-04 Thread Martin Liška
On 5/4/23 14:54, Qing Zhao wrote: > > >> On May 4, 2023, at 4:30 AM, Martin Liška wrote: >> >> On 5/3/23 21:10, Qing Zhao via Gcc-patches wrote: >>> Hi, Jan, >>> >>> You added the following patch into gcc10: >>> >>> From 34fbe

Re: [PATCH] gcov: add info about "calls" to JSON output format

2023-05-04 Thread Martin Liška
Hello. After discussion with the consumers of the format: https://github.com/gcovr/gcovr/issues/282#issuecomment-1534239536 I'm going to push a patch that prints JSON version in gcov -v. Thanks, MartinFrom d879d68eb309561d266ddf734ab8c69f4fef3874 Mon Sep 17 00:00:00 2001 From: Martin Liska

Re: Question on patch -fprofile-partial-training

2023-05-04 Thread Martin Liška
On 5/3/23 21:10, Qing Zhao via Gcc-patches wrote: > Hi, Jan, > > You added the following patch into gcc10: > > From 34fbe3f0946f88828765184ed6581bda62cdf49f Mon Sep 17 00:00:00 2001 > From: Jan Hubicka > Date: Thu, 5 Dec 2019 19:12:51 +0100 > Subject: [PATCH] cgraphclones.c (localize_profile):

[PATCH (pushed)] riscv: fix error: control reaches end of non-void function

2023-05-03 Thread Martin Liška
It's pre-approved by Jakub. Cheers, Martin Fixes: gcc/config/riscv/sync.md:66:1: error: control reaches end of non-void function [-Werror=return-type] 66 | [(set (attr "length") (const_int 4))]) | ^ PR target/109713 gcc/ChangeLog: * config/riscv/sync.md: Add

Re: [PATCH v5 09/11] RISC-V: Weaken mem_thread_fence

2023-05-03 Thread Martin Liška
On 5/3/23 14:18, Andreas Schwab via Gcc-patches wrote: > ../../gcc/config/riscv/sync.md: In function 'const char* > output_479(rtx_def**, rtx_insn*)': > ../../gcc/config/riscv/sync.md:66:1: error: control reaches end of non-void > function [-Werror=return-type] >66 | [(set (attr "length")

[PATCH (pushed)] clang warning: warning: private field 'm_gc' is not used [-Wunused-private-field]

2023-05-03 Thread Martin Liška
Pushed to master as obvious. Martin PR tree-optimization/109693 gcc/ChangeLog: * value-range-storage.cc (vrange_allocator::vrange_allocator): Remove unused field. * value-range-storage.h: Likewise. --- gcc/value-range-storage.cc | 1 - gcc/value-range-storage.h

[PATCH (pushed)] docs: port documentation of VRP params

2023-05-02 Thread Martin Liška
gcc/ChangeLog: * doc/invoke.texi: Update documentation based on param.opt file. --- gcc/doc/invoke.texi | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 2f40c58b21c..b92b8576027 100644 ---

[PATCH (pushed)] hwasan: adjust wording in expected output in tests

2023-04-30 Thread Martin Liška
gcc/testsuite/ChangeLog: * c-c++-common/hwasan/asan-pr70541.c: Adjust wording of expected output. * c-c++-common/hwasan/heap-overflow.c: Likewise. * c-c++-common/hwasan/sanity-check-pure-c.c: Likewise. * c-c++-common/hwasan/use-after-free.c: Likewise. ---

[PATCH (pushed)] libsanitizer: link hwasan against lsan library

2023-04-30 Thread Martin Liška
Similarly to libasan.so, libhwasan.so also utilizes some of the symbols from lsan library. PR sanitizer/109674 libsanitizer/ChangeLog: * hwasan/Makefile.am: Depend on liblsan. * hwasan/Makefile.in: Re-generate. --- libsanitizer/hwasan/Makefile.am | 2 +-

Re: libsanitizer: sync from master

2023-04-30 Thread Martin Liška
On 4/28/23 11:23, Florian Weimer wrote: > * Martin Liška: > >> On 4/26/23 20:31, Florian Weimer wrote: >>> * Martin Liška: >>> >>>> On 11/15/22 16:47, Martin Liška wrote: >>>>> Hi. >>>>> >>>>> I've just push

Re: libsanitizer: sync from master

2023-04-30 Thread Martin Liška
On 4/28/23 11:23, Florian Weimer wrote: > * Martin Liška: > >> On 4/26/23 20:31, Florian Weimer wrote: >>> * Martin Liška: >>> >>>> On 11/15/22 16:47, Martin Liška wrote: >>>>> Hi. >>>>> >>>>> I've just push

[PATCH (pushed)] contrib: port doxygen script to Python3

2023-04-28 Thread Martin Liška
Pushed to master as obvious. Martin contrib/ChangeLog: * filter_gcc_for_doxygen: Use python3 and not python2. * filter_params.py: Likewise. --- contrib/filter_gcc_for_doxygen | 2 +- contrib/filter_params.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] libsanitizer: cherry-pick commit 05551c658269 from upstream

2023-04-27 Thread Martin Liška
On 4/27/23 04:32, H.J. Lu via Gcc-patches wrote: > cherry-pick: Can you please wait a few days before it? I'm going to merge again in the near future after https://reviews.llvm.org/D144073 got handled. Martin > > 05551c658269 [sanitizer] Correct alignment of x32 __sanitizer_siginfo > >

Re: [COMMITTED 3/5] Add sbr_lazy_vector and adjust (e)vrp sparse cache

2023-04-27 Thread Martin Liška
On 4/26/23 21:26, Andrew MacLeod via Gcc-patches wrote: > This implements a sparse vector class for rangers cache and uses it bey > default except when the CFG is very small, in qhich case the original full > vectors are faster.  It works like a normal vector cache (in fact it inherits > from

Re: libsanitizer: sync from master

2023-04-26 Thread Martin Liška
On 4/26/23 20:31, Florian Weimer wrote: > * Martin Liška: > >> On 11/15/22 16:47, Martin Liška wrote: >>> Hi. >>> >>> I've just pushed libsanitizer update that was tested on x86_64-linux and >>> ppc64le-linux systems. >>> Moreover, I

Re: libsanitizer: sync from master

2023-04-26 Thread Martin Liška
On 4/26/23 20:31, Florian Weimer wrote: > * Martin Liška: > >> On 11/15/22 16:47, Martin Liška wrote: >>> Hi. >>> >>> I've just pushed libsanitizer update that was tested on x86_64-linux and >>> ppc64le-linux systems. >>> Moreover, I

Re: libsanitizer: sync from master

2023-04-26 Thread Martin Liška
On 4/26/23 21:23, H.J. Lu wrote: > On Wed, Apr 26, 2023 at 6:52 AM Martin Liška wrote: >> >> On 11/15/22 16:47, Martin Liška wrote: >>> Hi. >>> >>> I've just pushed libsanitizer update that was tested on x86_64-linux and >>> ppc64le-linux sys

Re: libsanitizer: sync from master

2023-04-26 Thread Martin Liška
On 4/26/23 21:23, H.J. Lu wrote: > On Wed, Apr 26, 2023 at 6:52 AM Martin Liška wrote: >> >> On 11/15/22 16:47, Martin Liška wrote: >>> Hi. >>> >>> I've just pushed libsanitizer update that was tested on x86_64-linux and >>> ppc64le-linux sys

Re: libsanitizer: sync from master

2023-04-26 Thread Martin Liška
On 11/15/22 16:47, Martin Liška wrote: > Hi. > > I've just pushed libsanitizer update that was tested on x86_64-linux and > ppc64le-linux systems. > Moreover, I run bootstrap on x86_64-linux and checked ABI difference with > abidiff. Hello. And I've done the same now a

Re: libsanitizer: sync from master

2023-04-26 Thread Martin Liška
On 11/15/22 16:47, Martin Liška wrote: > Hi. > > I've just pushed libsanitizer update that was tested on x86_64-linux and > ppc64le-linux systems. > Moreover, I run bootstrap on x86_64-linux and checked ABI difference with > abidiff. Hello. And I've done the same now a

Re: [PATCH] gcov: add info about "calls" to JSON output format

2023-04-25 Thread Martin Liška
On 4/14/23 14:34, Jan Hubicka wrote: >> On 4/11/23 11:23, Richard Biener wrote: >>> On Thu, Apr 6, 2023 at 3:58 PM Martin Liška wrote: >>>> >>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >>>> >>>> R

[PATCH (pushed)] MAINTAINERS: fix sorting of names

2023-04-24 Thread Martin Liška
ChangeLog: * MAINTAINERS: Fix sorting. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8822d9642f7..b76e1a131d9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -319,6 +319,7 @@ from other maintainers or reviewers.

[PATCH (pushed)] ada: bump Library_Version to 14.

2023-04-17 Thread Martin Liška
gcc/ada/ChangeLog: * gnatvsn.ads: Bump Library_Version to 14. --- gcc/ada/gnatvsn.ads | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ada/gnatvsn.ads b/gcc/ada/gnatvsn.ads index b6edc9dabed..a0e61e1b189 100644 --- a/gcc/ada/gnatvsn.ads +++ b/gcc/ada/gnatvsn.ads

Re: [PATCH] gcov: add info about "calls" to JSON output format

2023-04-12 Thread Martin Liška
On 4/11/23 11:23, Richard Biener wrote: > On Thu, Apr 6, 2023 at 3:58 PM Martin Liška wrote: >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed after stage1 opens? > > Did we release a compiler with version

[PATCH] gcov: add info about "calls" to JSON output format

2023-04-06 Thread Martin Liška
Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed after stage1 opens? Thanks, Martin gcc/ChangeLog: * doc/gcov.texi: Document the new "calls" field and document the API bump. * gcov.cc (output_intermediate_json_line): Output

[PATCH] ipa: propagate attributes for target attribute clones

2023-04-03 Thread Martin Liška
Hi. The patch propagates noreturn attribute for MV functions. However, I noticed we've got the following ICE when we do the same for TREE_READONLY attr: $ cat tc.c double bar() __attribute__((target_clones("avx,avx2,avx512f,default"))); double bar() { return 1.2f; } int foo() { return

[PATCH][stage1] gcov: respect -fprofile-prefix-map when it comes to output of .gcda file

2023-04-03 Thread Martin Liška
Respect the profile prefix map and save .gcda files to a path that is also translated with -fprofile-prefix-map option (if provided). It's a stage 1 material, if you are interested in the fix, please install it, I won't be able to take care of it at that time. Patch can bootstrap on

[PATCH] driver: drop flag_var_tracking_assignments flag

2023-04-03 Thread Martin Liška
The revision r13-259-g76db543db88727 moved a condition from one file to another, but now we do not drop x_flag_var_tracking_assignments as it was done before the mentioned revision. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin

[PATCH (pushed)] param: document ranger-recompute-depth

2023-04-03 Thread Martin Liška
gcc/ChangeLog: * doc/invoke.texi: Document new param. --- gcc/doc/invoke.texi | 4 1 file changed, 4 insertions(+) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index def2df4584b..c9482886c5a 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -16170,6 +16170,10

Re: [PATCH] configure: deprecate --enable-link-mutex option

2023-03-29 Thread Martin Liška
On 3/29/23 15:05, Richard Biener wrote: > I wonder if we can simply alias --enable-link-mutex to > --enable-link-serialization though. Sure, we can. Do you want it for gcc-13 as well? Cheers, Martin

Re: [PATCH] configure: deprecate --enable-link-mutex option

2023-03-29 Thread Martin Liška
On 3/29/23 15:02, Andreas Schwab wrote: > On Mär 29 2023, Martin Liška wrote: > >> diff --git a/gcc/configure.ac b/gcc/configure.ac >> index 120151c474a..13c1a85851c 100644 >> --- a/gcc/configure.ac >> +++ b/gcc/configure.ac >> @@ -7013,6 +7013,7 @@ AC_MSG_RES

[PATCH] configure: deprecate --enable-link-mutex option

2023-03-29 Thread Martin Liška
Ready to be installed? Thanks, Martin PR bootstrap/109310 gcc/ChangeLog: * configure.ac: Emit a warning for deprecated option --enable-link-mutex. * configure: Regenerate. --- gcc/configure| 1 + gcc/configure.ac | 1 + 2 files changed, 2 insertions(+) diff

[PATCH (pushed)] fix: pytest error

2023-03-27 Thread Martin Liška
Fixes: gcc/testsuite/lib/verify-sarif-file.py:10:27: Q000 Double quotes found but single quotes preferred gcc/testsuite/ChangeLog: * lib/verify-sarif-file.py: Use apostrophes instead of double quotes. --- gcc/testsuite/lib/verify-sarif-file.py | 2 +- 1 file changed, 1

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-03-16 Thread Martin Liška
PING^5 On 2/27/23 10:49, Martin Liška wrote: > PING^4 > > On 2/17/23 15:52, Martin Liška wrote: >> PING^3 >> >> On 2/1/23 14:13, Martin Liška wrote: >>> PING^2 >>> >>> On 1/24/23 14:34, Martin Liška wrote: >>>> PING^1 >>&g

Re: [PATCH] -Wdangling-pointer: don't mark SSA lhs sets as stores

2023-03-08 Thread Martin Liška
On 3/3/23 12:12, Richard Biener via Gcc-patches wrote: > On Fri, Mar 3, 2023 at 9:30 AM Alexandre Oliva wrote: >> >> On Feb 17, 2023, Richard Biener wrote: >> * gimple-ssa-warn-access.cc (pass_waccess::check_dangling_stores): Skip non-stores. for gcc/testsuite/ChangeLog

Re: Stepping down as gcov maintainer and callgraph reviewer

2023-03-07 Thread Martin Liška
On 2/16/23 20:46, Jan Hubicka wrote: > I am sad to hear this news and will definitely miss you as coleague > and co-maintaner. Thank you for all the work on GCC! Thank you all for the nice words! And especially to Honza, who was my diploma thesis supervisor and showed me the community. Actually

Re: Ping: [PATCH 1/2] testsuite: Provide means to regexp in multiline patterns

2023-03-07 Thread Martin Liška
On 3/7/23 01:32, Hans-Peter Nilsson wrote: >> From: Mike Stump >> Date: Mon, 6 Mar 2023 02:05:35 -0800 > >> Ok > > Thanks! The server-side hook didn't like my ChangeLog > entry: > > * lib/multiline.exp (_build_multiline_regex): Map > "{re:" to "(", ":re}" to ")" and

Re: [wwwdocs] gcc-13/porting_to.html: Document C++ -fexcess-precision=standard

2023-03-02 Thread Martin Liška
On 3/2/23 11:32, Jakub Jelinek wrote: > Hi! > > On Fri, Feb 10, 2023 at 10:06:03AM +0100, Gerald Pfeifer wrote: >> Yes, thank you! Two minor suggestions/questions below: >> >>> --- a/htdocs/gcc-13/changes.html >>> +++ b/htdocs/gcc-13/changes.html >>> + -fexcess-precision=fast. The option

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-02-27 Thread Martin Liška
PING^4 On 2/17/23 15:52, Martin Liška wrote: PING^3 On 2/1/23 14:13, Martin Liška wrote: PING^2 On 1/24/23 14:34, Martin Liška wrote: PING^1 On 1/10/23 16:10, Martin Liška wrote: On 1/6/23 14:21, David Malcolm wrote: On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote: Patch can

Re: [PATCH] asan: adjust module name for global variables

2023-02-24 Thread Martin Liška
On 2/24/23 10:07, Jakub Jelinek wrote: > On Fri, Feb 24, 2023 at 10:00:01AM +0100, Martin Liška wrote: >> As mentioned in the PR, when we use LTO, we wrongly use ltrans output >> file name as a module name of a global variable. That leads to a >> non-reproducible output. >

[PATCH] asan: adjust module name for global variables

2023-02-24 Thread Martin Liška
As mentioned in the PR, when we use LTO, we wrongly use ltrans output file name as a module name of a global variable. That leads to a non-reproducible output. After the suggested change, we emit context name of normal global variables. And for artificial variables (like .Lubsan_data3), we use

[PATCH (pushed)] libsanitizer: cherry-pick commit 8f5962b1ccb5fcd4d4544121d43efb860ac3cc6d from upstream

2023-02-24 Thread Martin Liška
ASAN: keep support for Global::location We as GCC still emit __asan_global_source_location for global variables and we would like to use it in the future. On other hand, we don't support llvm-symbolizer and the default libbacktraace symbolizer does not support location info. ---

Re: Using __gnu_lto_slim to detect -fno-fat-lto-objects

2023-02-23 Thread Martin Liška
On 2/22/23 09:28, Florian Weimer via Gcc wrote: > * Richard Biener: > >> On Wed, Feb 22, 2023 at 9:19 AM Florian Weimer via Gcc >> wrote: >>> >>> Can we use the COMMON symbol __gnu_lto_slim to detect >>> -fno-fat-lto-objects on contemporary GNU/Linux (with the LTO linker >>> plugin)? >> >> Yes.

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-02-17 Thread Martin Liška
PING^3 On 2/1/23 14:13, Martin Liška wrote: > PING^2 > > On 1/24/23 14:34, Martin Liška wrote: >> PING^1 >> >> On 1/10/23 16:10, Martin Liška wrote: >>> On 1/6/23 14:21, David Malcolm wrote: >>>> On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrot

Stepping down as gcov maintainer and callgraph reviewer

2023-02-16 Thread Martin Liška
Hello GCC community. After spending last decade (including my diploma thesis even more) of my life working on GCC, I decided to leave the project and try a different job. I would like to thank all the community members I had change to interact with, I learned so much and enjoyed the journey! I'll

Re: Git 'hooks/post_receive.py': UnicodeDecodeError: 'utf8' codec can't decode byte 0xff in position 2766: invalid start byte

2023-02-16 Thread Martin Liška
On 2/16/23 13:26, Thomas Schwinge wrote: > Hi! > > The following is not an actual problem for me or GCC/Rust; just for your > information: Hello. Thanks for letting me know. > > I've just pushed to GCC devel/rust/master branch > Git commits cc23831ec66..74913f718b0, which

[PATCH (pushed)] docs: document new --param=asan-kernel-mem-intrinsic-prefix

2023-02-15 Thread Martin Liška
gcc/ChangeLog: * doc/invoke.texi: Document --param=asan-kernel-mem-intrinsic-prefix. --- gcc/doc/invoke.texi | 4 1 file changed, 4 insertions(+) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 26de582e41e..0a43720f614 100644 --- a/gcc/doc/invoke.texi +++

Re: realpath() patch to fix symlinks resolution for win32

2023-02-13 Thread Martin Liška
On 2/11/23 22:14, Gerald Pfeifer wrote: On Sat, 11 Feb 2023, NightStrike wrote: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108350 I would have expected the PR to have been automatically updated based on the commit email. Any idea why that didn't happen? Not to change the state to closed, but

[PATCH (pushed)] docs: document new param

2023-02-13 Thread Martin Liška
gcc/ChangeLog: * doc/invoke.texi: Document ira-simple-lra-insn-threshold. --- gcc/doc/invoke.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 51447a78584..26de582e41e 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@

Re: [PATCH] docs: add cavear for __builtin_cpu_supports

2023-02-09 Thread Martin Liška
On 2/9/23 11:43, Gerald Pfeifer wrote: > On Thu, 9 Feb 2023, Martin Liška wrote: >> Document that the function does not work correctly for old VIA >> processors. > > Thanks for doing this, Martin! > >> +Caveat: The built-in function does not work correctly on o

[PATCH] docs: add cavear for __builtin_cpu_supports

2023-02-09 Thread Martin Liška
Document that the function does not work correctly for old VIA processors. Ready to be installed? Thanks, Martin PR target/100758 gcc/ChangeLog: * doc/extend.texi: Document that the function does not work correctly for old VIA processors. --- gcc/doc/extend.texi | 3

Re: [PATCH] ipa: silent -Wodr notes with -w

2023-02-08 Thread Martin Liška
On 2/9/23 01:10, Jan Hubicka wrote: >>> On 2/1/23 15:26, Martin Jambor wrote: >>>> Hi, >>>> >>>> On Fri, Dec 02 2022, Martin Liška wrote: >>>>> If -w is used, warn_odr properly sets *warned = false and >>>>> so i

Re: [PATCH] ipa: silent -Wodr notes with -w

2023-02-01 Thread Martin Liška
On 2/1/23 15:26, Martin Jambor wrote: Hi, On Fri, Dec 02 2022, Martin Liška wrote: If -w is used, warn_odr properly sets *warned = false and so it should be preserved when calling warn_types_mismatch. Noticed that during a LTO reduction where I used -w. Patch can bootstrap on x86_64-linux

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-02-01 Thread Martin Liška
PING^2 On 1/24/23 14:34, Martin Liška wrote: PING^1 On 1/10/23 16:10, Martin Liška wrote: On 1/6/23 14:21, David Malcolm wrote: On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote: Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Thanks for the patch. I noticed

Re: [PATCH] ipa: silent -Wodr notes with -w

2023-02-01 Thread Martin Liška
PING^5 On 1/24/23 14:34, Martin Liška wrote: PING^4 On 1/13/23 10:09, Martin Liška wrote: PING^3 On 12/22/22 13:15, Martin Liška wrote: PING^2 On 12/9/22 09:27, Martin Liška wrote: PING^1 On 12/2/22 12:27, Martin Liška wrote: If -w is used, warn_odr properly sets *warned = false and so

[PATCH (pushed)] libsanitizer: Regenerate configure

2023-01-31 Thread Martin Liška
libsanitizer/ChangeLog: * configure: Regenerate. --- libsanitizer/configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libsanitizer/configure b/libsanitizer/configure index d4ee0fac3e7..e7984f96615 100755 --- a/libsanitizer/configure +++

[PATCH] driver: fix -gz=none error message with missing zstd

2023-01-27 Thread Martin Liška
We wrongly report: $ echo "int main () {}" | gcc -xc -gz=none - gcc: error: -gz=zstd is not supported in this configuration if zstd compression is not supported by binutils. We should emit the error message only if -gz=zstd. PR driver/108572 Ready to be installed? Thanks, Martin

[PATCH] ipa: check if cache_token != NULL before hash_set::add call

2023-01-24 Thread Martin Liška
We should not insert an empty value to the container. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR ipa/108509 gcc/ChangeLog: * cgraphunit.cc (walk_polymorphic_call_targets): Insert ony non-null values.

Re: [PATCH] ipa: silent -Wodr notes with -w

2023-01-24 Thread Martin Liška
PING^4 On 1/13/23 10:09, Martin Liška wrote: > PING^3 > > On 12/22/22 13:15, Martin Liška wrote: >> PING^2 >> >> On 12/9/22 09:27, Martin Liška wrote: >>> PING^1 >>> >>> On 12/2/22 12:27, Martin Liška wrote: >>>> If -w is

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-01-24 Thread Martin Liška
PING^1 On 1/10/23 16:10, Martin Liška wrote: > On 1/6/23 14:21, David Malcolm wrote: >> On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote: >>> Patch can bootstrap on x86_64-linux-gnu and survives regression >>> tests. >> >> Thanks for the patch. &g

Re: git out-of-order commit (was Re: [PATCH] Fortran: Remove unused declaration)

2023-01-23 Thread Martin Liška
On 1/20/23 18:33, Jason Merrill wrote: > Martin, I wonder about having the hooks reject out-of-order CommitDate > in future? Yes, I would do that. Looking at the last 30K commmits I see just a few violations of the order: UNIXTS hash 1668298622 30d77d49628 1630019619 5889e842ae4 1626967834

[PATCH (pushed)] Ignore test_patches.txt in update-copyright.py.

2023-01-17 Thread Martin Liška
contrib/ChangeLog: * update-copyright.py: Ignore test_patches.txt. --- contrib/update-copyright.py | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/update-copyright.py b/contrib/update-copyright.py index ac7a94743cf..f3691dc11cc 100755 --- a/contrib/update-copyright.py +++

[PATCH] contrib: ignore CR in update-copyright.py

2023-01-17 Thread Martin Liška
When opening files, preserve CR characters. By default, open accepts universal newlines, but I think we should only split with '\n'. Ready to be installed? Thanks, Martin contrib/ChangeLog: * update-copyright.py: Split lines only with '\n'. --- contrib/update-copyright.py | 4 ++-- 1

[PATCH (pushed)] contrib: revert removal of CR character

2023-01-17 Thread Martin Liška
contrib/ChangeLog: * gcc-changelog/test_patches.txt: The CR character was removed with ./contrib/update-copyright.py which I'm going to change. --- contrib/gcc-changelog/test_patches.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH (pushed)] Regenerate Makefile.in files.

2023-01-17 Thread Martin Liška
libbacktrace/ChangeLog: * Makefile.in: Regenerate. libgomp/ChangeLog: * Makefile.in: Regenerate. * configure: Regenerate. libphobos/ChangeLog: * Makefile.in: Regenerate. * libdruntime/Makefile.in: Regenerate. libstdc++-v3/ChangeLog: *

Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678]

2023-01-16 Thread Martin Liška
On 1/12/23 19:57, Jakub Jelinek via Gcc-patches wrote: > On Tue, Jan 10, 2023 at 04:33:59PM +, Wilco Dijkstra via Gcc-patches > wrote: >> Hi Szabolcs, >> >>> i would keep the assert: how[reg] must be either UNSAVED or UNDEFINED >>> here, other how[reg] means the toggle cfi instruction is

Re: [PATCH] IPA: do not release body if still needed

2023-01-16 Thread Martin Liška
On 1/14/23 22:36, Jan Hubicka wrote: >> Hi. >> >> Noticed during building of libbackend.a with the LTO partial linking. >> >> The function release_body is called even if clone_of is a clone >> of a another function and thus it shares tree declaration. We should >> preserve it in that situation. >>

Re: [PATCH] ipa: silent -Wodr notes with -w

2023-01-13 Thread Martin Liška
PING^3 On 12/22/22 13:15, Martin Liška wrote: PING^2 On 12/9/22 09:27, Martin Liška wrote: PING^1 On 12/2/22 12:27, Martin Liška wrote: If -w is used, warn_odr properly sets *warned = false and so it should be preserved when calling warn_types_mismatch. Noticed that during a LTO reduction

Re: [PATCH] tree-optimization/107767 - not profitable switch conversion

2023-01-11 Thread Martin Liška
On 1/9/23 12:09, Richard Biener wrote: > |Martin, OK with you?| Yes, thanks for handling that. Martin

Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678]

2023-01-11 Thread Martin Liška
On 1/10/23 19:12, Jakub Jelinek via Gcc-patches wrote: > Anyway, the sooner this makes it into gcc trunk, the better, it breaks quite > a lot of stuff. Yep, please, we're also waiting for this patch for pushing to our gcc13 package. Cheers, Martin

[gcc-12 backport] strlen: do not use cond_expr for boundaries

2023-01-11 Thread Martin Liška
Tested, I'm going to push it. Martin PR tree-optimization/108137 gcc/ChangeLog: * tree-ssa-strlen.cc (get_range_strlen_phi): Reject anything different from INTEGER_CST. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr108137.c: New test. (cherry picked from

[PATCH] switch expansion: limit JT growth param values

2023-01-11 Thread Martin Liška
Currently, one can request a huge jump table creation which leads to a non-sensual huge output. Moreover, use auto_vec rather than a stack-allocated array. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR middle-end/107976

Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-01-10 Thread Martin Liška
On 1/6/23 14:21, David Malcolm wrote: > On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote: >> Patch can bootstrap on x86_64-linux-gnu and survives regression >> tests. > > Thanks for the patch. > > I noticed that you marked PR 108307 as a dup of this, which co

Re: [PATCH] Remove legacy pre-C++ 11 definitions

2023-01-10 Thread Martin Liška
On 1/9/23 16:19, Jonathan Wakely wrote: > On Mon, 9 Jan 2023 at 15:17, Martin Liška wrote: >> >> On 1/6/23 19:23, Jonathan Wakely wrote: >>> Seems to me that GCC code should just use nullptr directly not redefine >>> NULL. >> >> Sure, but that would

Re: [PATCH][pushed] contrib: add 'contrib' to default dirs in update-copyright.py

2023-01-09 Thread Martin Liška
> However, I noticed when I run ./contrib/update-copyright.py --this-year > I get much more modifications out of contrib folder: @Jakub? Martin

Re: [PATCH] ipa: Sort ipa_param_body_adjustments::m_replacements (PR 108110)

2023-01-09 Thread Martin Liška
On 1/6/23 17:50, Martin Jambor wrote: Hi, On Fri, Jan 06 2023, Martin Liška wrote: Hi Martin + key.unit_offset = unit_offset; + ipa_param_body_replacement *res += std::lower_bound (m_replacements.begin (), m_replacements.end (), key, + [] (const

Re: [PATCH] Remove legacy pre-C++ 11 definitions

2023-01-09 Thread Martin Liška
On 1/6/23 19:23, Jonathan Wakely wrote: Seems to me that GCC code should just use nullptr directly not redefine NULL. Sure, but that would lead to a huge patch which would rename NULL to nullptr, right? Martin

[PATCH] hash: do not insert deleted value to a hash_set

2023-01-09 Thread Martin Liška
Hi. After the new hash_set checking code, we face an issue where deleted value is added to a hash_set. Fix it. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR lto/108330 gcc/ChangeLog: * lto-cgraph.cc

[PATCH] Remove legacy pre-C++ 11 definitions

2023-01-06 Thread Martin Liška
As mentioned in the PRs, both are defined in C++ 11 which is a version we depend on. Ready to be installed now? Thanks, Martin PR middle-end/108311 PR middle-end/108312 gcc/ChangeLog: * system.h (va_copy): Remove as it is defined in C++ 11. (NULL): Likewise.

Re: [PATCH] ipa: Sort ipa_param_body_adjustments::m_replacements (PR 108110)

2023-01-06 Thread Martin Liška
Hi Martin > + key.unit_offset = unit_offset; > + ipa_param_body_replacement *res > += std::lower_bound (m_replacements.begin (), m_replacements.end (), key, > + [] (const ipa_param_body_replacement , > + const ipa_param_body_replacement ) > +

[PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

2023-01-06 Thread Martin Liška
Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR middle-end/106133 gcc/ChangeLog: * diagnostic.cc (diagnostic_output_format_init): If -fdiagnostics-format=json-file and -E is used, then

[PATCH][pushed] contrib: add 'contrib' to default dirs in update-copyright.py

2023-01-05 Thread Martin Liška
Hi. I forgot to include contrib folder in default dir, thus the copyright in the folder haven't been updated by Jakub. However, I noticed when I run ./contrib/update-copyright.py --this-year I get much more modifications out of contrib folder: $ git diff --stat ... 951 files changed, 976

Re: [PATCH] contrib: add contrib to update-copyright.py script

2022-12-28 Thread Martin Liška
On 12/14/22 14:13, Jakub Jelinek wrote: > s/Filder/Filter/g ? Yep. Pushed with the fix as there hasn't been any comments on this. Martin

Re: [PATCH] IPA: do not release body if still needed

2022-12-28 Thread Martin Liška
PING^2 On 12/9/22 09:28, Martin Liška wrote: > PING^1 > > On 12/1/22 10:59, Martin Liška wrote: >> Hi. >> >> Noticed during building of libbackend.a with the LTO partial linking. >> >> The function release_body is called even if clone_of is a clone >

[PATCH] docs: fix Var documentation for .opt files

2022-12-28 Thread Martin Liška
The Var documentation was somehow wrongly split into 2 pieces. PR middle-end/107966 gcc/ChangeLog: * doc/options.texi: Fix Var documentation in internal manual. --- gcc/doc/options.texi | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff

Re: Document how to build PGO-optimized GCC version

2022-12-28 Thread Martin Liška
On 12/28/22 06:48, Andrew Pinski via Gcc wrote: > But distros do provide more recent prebuilt binaries, you could ask > them to build using PGO (some do already I think). Yes, I can confirm that the openSUSE gccX pacakges utlize both PGO and LTO during the compiler bootstrap. So, you can use:

Re: [00/13] check hash table counts

2022-12-28 Thread Martin Liška
On 12/27/22 05:07, Alexandre Oliva via Gcc-patches wrote: > > While looking into another issue that corrupted hash tables, I added > code to check consistency of element counts, and hit numerous issues > that were concerning, of three kinds: insertion of entries that seem > empty, dangling

[PATCH] c: check if target_clone attrs are all string

2022-12-28 Thread Martin Liška
Hi. The patch checks all attribute arguments if they are string. If not, an error message is emitted. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR c/107993 gcc/c-family/ChangeLog: * c-attribs.cc

[PATCH] strlen: do not use cond_expr for boundaries

2022-12-23 Thread Martin Liška
Hi. We reach cond_expr and then we get an ICE in tree_int_cst_lt. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR tree-optimization/108137 gcc/ChangeLog: * tree-ssa-strlen.cc (get_range_strlen_phi): Reject

Re: [PATCH] ipa: silent -Wodr notes with -w

2022-12-22 Thread Martin Liška
PING^2 On 12/9/22 09:27, Martin Liška wrote: > PING^1 > > On 12/2/22 12:27, Martin Liška wrote: >> If -w is used, warn_odr properly sets *warned = false and >> so it should be preserved when calling warn_types_mismatch. >> >> Noticed that during a LTO reduction

Re: [PATCH] Backport gcc-12: jobserver FIFO support

2022-12-22 Thread Martin Liška
On 12/12/22 13:05, Martin Liška wrote: > On 12/12/22 12:42, Jakub Jelinek wrote: >> On Mon, Dec 12, 2022 at 12:39:36PM +0100, Martin Liška wrote: >>>> I'm fine with backporting the whole >>>> series to GCC 12 but I wonder if earlier still maintained versio

[PATCH] go: fix clang warnings

2022-12-21 Thread Martin Liška
The patch fixes the following Clang warnings: gcc/go/gofrontend/escape.cc:1290:17: warning: private field 'fn_' is not used [-Wunused-private-field] gcc/go/gofrontend/escape.cc:3478:19: warning: private field 'context_' is not used [-Wunused-private-field] gcc/go/gofrontend/lex.h:564:15:

[PATCH (pushed)] libgccjit: silent 2 Clang warnings

2022-12-21 Thread Martin Liška
The make silent the following 2 warnings: jit/jit-playback.h:785:16: warning: private field 'm_source_file' is not used [-Wunused-private-field] jit/jit-playback.h:804:16: warning: private field 'm_line' is not used [-Wunused-private-field] gcc/jit/ChangeLog: * jit-playback.h: Use

Re: new ubsan handler

2022-12-19 Thread Martin Liška
On 12/19/22 10:25, Martin Uecker wrote: Am Montag, dem 19.12.2022 um 09:44 +0100 schrieb Martin Liška: On 12/17/22 20:35, Martin Uecker wrote: Hi all, what is the process for adding a new UBsan handler? Hello. Yes, we sync the run-time library from LLVM project. So a new sanitizer should

[PATCH (pushed)] gcc-changelog: support digits in PR's component in subject

2022-12-19 Thread Martin Liška
Yes, fixed in the following patch. Martin contrib/ChangeLog: * gcc-changelog/git_commit.py: Support digits in PR's component in subject. --- contrib/gcc-changelog/git_commit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH (pushed)] gcc-changelog: allow digit in component name

2022-12-19 Thread Martin Liška
contrib/ChangeLog: * gcc-changelog/git_commit.py: Allow digit in component name. contrib/ChangeLog: * gcc-changelog/test_email.py: Add new test. * gcc-changelog/test_patches.txt: Add new patch. --- contrib/gcc-changelog/git_commit.py| 2 +-

[PATCH (pushed)] gcc-changelog: stop using --flake8

2022-12-19 Thread Martin Liška
The flake8 pytest plug-in is broken and we should not use it. contrib/ChangeLog: * gcc-changelog/setup.cfg: Do not use flake8 pytest plug-in. --- contrib/gcc-changelog/setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/gcc-changelog/setup.cfg

Re: new ubsan handler

2022-12-19 Thread Martin Liška
On 12/17/22 20:35, Martin Uecker wrote: Hi all, what is the process for adding a new UBsan handler? Hello. Yes, we sync the run-time library from LLVM project. So a new sanitizer should go there first. We have the source in the GCC tree, but I guess this should go via LLVM? And the

Re: [Patch] gcc-changelog: Add warning for auto-added files

2022-12-16 Thread Martin Liška
On 12/16/22 13:33, Tobias Burnus wrote: > Thus, the auto-add feature does not seem to be an often used feature -  > neither on > purpose nor accidentally. And glancing at the results, I think it was as  > often used > on purpose as it was used accidentally. Hello. Understood, I do support the

  1   2   3   4   5   6   7   8   9   10   >