Re: [patch] libgompd: Add thread handles

2022-07-27 Thread Mohamed Atef via Gcc-patches
Ping في الاثنين، ٤ يوليو، ٢٠٢٢ ١٠:٣٤ م Ahmed Sayed Mousse < ahmedsayedmou...@gmail.com> كتب: > *This patch is the initial implementation of OpenMP-API specs book section > **20.5.5 with title "Thread Handles".* > > *I have fixed the first version after revising the notes on it.* > >

[PATCH] libgompd: Fixed Access bug

2022-06-25 Thread Mohamed Atef via Gcc-patches
Hello, I referenced kind, nthread, and implicit as pointers in my last patch. This patch fixes this bug. We review patches and even the committed ones. Another thing, I didn't add gompd_thread_handle_access entries in the ChangeLog. libgomp/ChangeLog 2022-06-26 MohamedAtef * ompd-helper.c

Re: [PATCH] libgompd: Fix sizes in OMPD support and add local ICVs finctions.

2022-06-21 Thread Mohamed Atef via Gcc-patches
I forgot the DCO line. And I edited the commit message, but I can't push, even forced push doesn't work. Now I get the non-fast-forward error, is there any way to solve this? On Mon, Jun 20, 2022 at 9:31 AM Jakub Jelinek wrote: > On Fri, Jun 17, 2022 at 01:20:28AM +0200, Mohamed Atef wrote: > >

[PATCH] libgompd: Fix sizes in OMPD support and add local ICVs finctions.

2022-06-16 Thread Mohamed Atef via Gcc-patches
libgomp/ChangeLog 2022-06-17 Mohamed Atef * ompd-helper.h (DEREFERENCE, ACCESS_VALUE): New macros. (gompd_get_proc_bind): Change the returned value from ompd_word_t to const char *. (gompd_get_max_task_priority): Fix format. (gompd_stringize_gompd_enabled): Removed. (gompd_get_gompd_enabled):

Re: [PATCH] libgompd: Fix sizes in OMPD support and add local ICVs finctions.

2022-06-15 Thread Mohamed Atef via Gcc-patches
Ping في الجمعة، ١٠ يونيو، ٢٠٢٢ ٥:٥٦ م Mohamed Atef كتب: > > libgomp/ChangeLog > > 2022-06-10 Mohamed Atef > > * ompd-helper.h (DEREFERENCE, ACCESS_VALUE): New macros. > * ompd-helper.c (gompd_get_nthread, gompd_get_thread_limit, > gomp_get_run_shed, gompd_get_run_sched_chunk_size, >

[PATCH] libgompd: Fix sizes in OMPD support and add local ICVs finctions.

2022-06-10 Thread Mohamed Atef via Gcc-patches
libgomp/ChangeLog 2022-06-10 Mohamed Atef * ompd-helper.h (DEREFERENCE, ACCESS_VALUE): New macros. * ompd-helper.c (gompd_get_nthread, gompd_get_thread_limit, gomp_get_run_shed, gompd_get_run_sched_chunk_size, gompd_get_default_device, gompd_get_dynamic, gompd_get_max_active_levels,

Re: [PATCH]: libgompd add parallel handle functions

2022-06-06 Thread Mohamed Atef via Gcc-patches
في الاثنين، ٦ يونيو، ٢٠٢٢ ٧:١٣ م Jakub Jelinek via Gcc-patches < gcc-patches@gcc.gnu.org> كتب: > On Mon, Jun 06, 2022 at 01:48:22AM +0200, Mohamed Sayed via Gcc-patches > wrote: > > This patch adds parallel region handles specified in section 5.5.3. > > >From examining libgomp code, I found that

[PATCH] libgompd: Add ompd_get/rel_display_control_vars

2022-05-26 Thread Mohamed Atef via Gcc-patches
libgomp/ChangeLog 2022-05-27 Mohamed Atef * libgompd.map (ompd_get_display_control_vars, ompd_rel_display_control_vars): New global symbol versions. * env.c: (gompd_buffer, gompd_env_buff_size): New Variables. (dump_icvs): New function. (initialize_env): call dump_icvs. * ompd-icv.c:

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
Hi Jakub, Sorry for the rush of emails, I removed the Copyright part, I will use DCO. Note: I filled out the form. On Wed, May 18, 2022 at 2:55 PM Mohamed Atef wrote: > > > On Wed, May 18, 2022 at 2:43 PM Jakub Jelinek wrote: > >> On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
On Wed, May 18, 2022 at 2:43 PM Jakub Jelinek wrote: > On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef wrote: > > > As I said earlier, as this is just partial implementation of the > > > OMPD, I think it would be better to commit it to a git branch but > > > already in the upstream

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
by independent functions. Mohamed. On Wed, May 18, 2022 at 2:10 PM Mohamed Atef wrote: > > > On Wed, May 18, 2022 at 9:35 AM Jakub Jelinek wrote: > >> On Mon, May 16, 2022 at 07:35:17PM +0200, Mohamed Atef via Gcc-patches >> wrote: >> > libgomp/ChangeLog

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
On Wed, May 18, 2022 at 9:35 AM Jakub Jelinek wrote: > On Mon, May 16, 2022 at 07:35:17PM +0200, Mohamed Atef via Gcc-patches > wrote: > > libgomp/ChangeLog > > > > 2022-05-15 Mohamed Atef > > > > *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove (

[PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-16 Thread Mohamed Atef via Gcc-patches
libgomp/ChangeLog 2022-05-15 Mohamed Atef *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *configure: Regenerate. *Makefile.am (toolexeclib_LTLIBRARIES): Add

Re: libgompd: ADD OMPD support and global ICV functions

2022-05-15 Thread Mohamed Atef via Gcc-patches
في الأحد، ١٥ مايو، ٢٠٢٢ ٤:١٨ م Mohamed Atef كتب: > Ping > > في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef > كتب: > >> Hello Jakub, >>I am sorry, but should #ifdef __ELF__ put and separate file and also >> the actual functions (e.g. extern ompd_dll_location_valid (void)) >> I mean both in the

Re: libgompd: ADD OMPD support and global ICV functions

2022-05-15 Thread Mohamed Atef via Gcc-patches
Ping في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef كتب: > Hello Jakub, >I am sorry, but should #ifdef __ELF__ put and separate file and also > the actual functions (e.g. extern ompd_dll_location_valid (void)) > I mean both in the same files or the functions should be in the > omp-tools.h but

Re: libgompd: ADD OMPD support and global ICV functions

2022-05-13 Thread Mohamed Atef via Gcc-patches
Hello Jakub, I am sorry, but should #ifdef __ELF__ put and separate file and also the actual functions (e.g. extern ompd_dll_location_valid (void)) I mean both in the same files or the functions should be in the omp-tools.h but with #ifndef __ELF__ Mohamed On Fri, May 13, 2022 at 8:27 PM

Re: libgompd: ADD OMPD support and global ICV functions

2022-05-13 Thread Mohamed Atef via Gcc-patches
في الجمعة، ١٣ مايو، ٢٠٢٢ ٣:١٤ م Jakub Jelinek كتب: > On Tue, May 10, 2022 at 07:40:41AM +0200, Mohamed Atef wrote: > > --- a/libgomp/env.c > > +++ b/libgomp/env.c > > @@ -33,6 +33,7 @@ > > #ifndef LIBGOMP_OFFLOADED_ONLY > > #include "libgomp_f.h" > > #include "oacc-int.h" > > +#include

Re: libgompd: ADD OMPD support and global ICV functions

2022-05-09 Thread Mohamed Atef via Gcc-patches
Here is the final change. On Tue, May 10, 2022 at 7:21 AM Mohamed Atef wrote: > Resubmission. > > libgomp/ChangeLog > > 2022-05-10 Mohamed Atef > > *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. > *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. >

Re: libgompd: ADD OMPD support and global ICV functions

2022-05-09 Thread Mohamed Atef via Gcc-patches
Resubmission. libgomp/ChangeLog 2022-05-10 Mohamed Atef *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *configure: Regenerate. * Makefile.am

Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

2022-04-17 Thread Mohamed Atef via Gcc-patches
Hi, This is the second time i ping this patch. I just remind you of it. Mohamed في الأحد، ٣ أبريل، ٢٠٢٢ ٤:٤١ م Mohamed Atef كتب: > Hi, > I'd like to ping this patch. > Thanks > > Mohamed > > On Sun, Mar 20, 2022 at 11:33 AM Mohamed Atef > wrote: > >> hello, >>I know it's too much. >> we

Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

2022-04-03 Thread Mohamed Atef via Gcc-patches
Hi, I'd like to ping this patch. Thanks Mohamed On Sun, Mar 20, 2022 at 11:33 AM Mohamed Atef wrote: > hello, >I know it's too much. > we fixed the functions' names that are not part of the standard form ompd_ > * prefix to gompd_ > Thanks > > > On Wed, Mar 16, 2022 at 5:48 AM Mohamed

Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

2022-03-20 Thread Mohamed Atef via Gcc-patches
hello, I know it's too much. we fixed the functions' names that are not part of the standard form ompd_ * prefix to gompd_ Thanks On Wed, Mar 16, 2022 at 5:48 AM Mohamed Atef wrote: > Hi, >we found some typos in the ChangeLog and some wrong spaces (nightmare) > in the files. > So here's

Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

2022-03-15 Thread Mohamed Atef via Gcc-patches
Hi, we found some typos in the ChangeLog and some wrong spaces (nightmare) in the files. So here's the best we can do. and please don't be disappointed and trust us we're doing our best. I hope you could review it by Sunday night. Thanks. libgomp/ChangeLog 2022-03-15 Mohamed Atef

Re: [PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

2022-03-15 Thread Mohamed Atef via Gcc-patches
On Tue, Mar 15, 2022 at 11:32 PM Mohamed Atef wrote: > This patch added OMPD support to libgomp, api version funcitos and global > ICVs functions. > I hope you review it as soon as possible, to fix the problems. > I tried as much as I could to follow GNU standards. > We have a seminar at the

[PATCH] libgompd: add OMPD support, libgompd initialization and global ICVs functions

2022-03-15 Thread Mohamed Atef via Gcc-patches
This patch added OMPD support to libgomp, api version funcitos and global ICVs functions. I hope you review it as soon as possible, to fix the problems. I tried as much as I could to follow GNU standards. We have a seminar at the college next week, so we need this to be reviewed. Thanks

Re: [PATCH] libgomp : OMPD implementation

2022-03-14 Thread Mohamed Atef via Gcc-patches
ans a lot of us >> concentrate on fixing GCC 12 so that it can be released soon and projects >> that are clearly GCC 13 material are much lower priority. >> > Never mind, thank you anyway. > >> >> On Wed, Feb 16, 2022 at 11:04:13PM +0200, Mohamed Atef via Gcc

Re: [PATCH] libgomp : OMPD implementation

2022-03-14 Thread Mohamed Atef via Gcc-patches
and projects > that are clearly GCC 13 material are much lower priority. > Never mind, thank you anyway. > > On Wed, Feb 16, 2022 at 11:04:13PM +0200, Mohamed Atef via Gcc-patches > wrote: > > --- a/libgomp/ChangeLog > > +++ b/libgomp/ChangeLog > > @@ -1,3 +1

[PATCH] libgomp(OMPD PROJECT): add ICVs debugging information.

2022-03-11 Thread Mohamed Atef via Gcc-patches
Hi, This Patch contains the function that gets all global ICVs information, and prototypes of local ICVs. Notes: 1) gomp_affinity_format_len doesn't have a value so I assumed that gomp_affinity_format has length 100 for now. 2) I didn't have any knowledge in OpenMP before this project, so if

Re: [PATCH] libgomp : OMPD implementation

2022-03-10 Thread Mohamed Atef via Gcc-patches
Hi all, We remind you of this patch. Thanks Mohamed في الأربعاء، ١٦ فبراير، ٢٠٢٢ ١١:٠٤ م Mohamed Atef كتب: > Sorry I forgot to uncomment 2 lines, > here's the Patch Again. > > Thanks > Mohamed > > On Wed, Feb 16, 2022 at 10:54 PM Mohamed Atef > wrote: > >> HI, >> I am sorry that the

Re: [PATCH] libgomp : OMPD implementation

2022-02-16 Thread Mohamed Atef via Gcc-patches
Sorry I forgot to uncomment 2 lines, here's the Patch Again. Thanks Mohamed On Wed, Feb 16, 2022 at 10:54 PM Mohamed Atef wrote: > HI, > I am sorry that the previous patch was buggy. > This patch contains the header files and source files of functions that > are specified in OpenMP

[PATCH] libgomp : OMPD implementation

2022-02-16 Thread Mohamed Atef via Gcc-patches
HI, I am sorry that the previous patch was buggy. This patch contains the header files and source files of functions that are specified in OpenMP Application ProgrammingInterface book from sections (5.1, 5.2, 5.3, 5.4, 5.5.1, 5.5.2) the functions are tested using the gdb plugin and the results

[PATCH] libgomp: added OMPD support to libgomp and created libgompd

2022-02-11 Thread Mohamed Atef via Gcc-patches
This patch added OMPD support for libgomp and added some OMPD functions. One of the guys is working on the gdb-plugin and two of them are trying to get familiar with DejaGnu and some of us are working on the Graduation Book which will contain everything about the project. (we will provide it if