Comment added to each file.
Tested x86_64-linux. Pushed to trunk.
On Mon, Jul 3, 2023 at 4:16 PM Jonathan Wakely wrote:
> On Mon, 3 Jul 2023 at 23:14, Thomas Rodgers via Libstdc++
> wrote:
> >
> > This testcase is causing some timeout issues. This patch splits the
> > testcase up by
This testcase is causing some timeout issues. This patch splits the
testcase up by individual set algorithm.
From 857359b72f8886b6e90db3b596d04f08559d2b51 Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Mon, 3 Jul 2023 15:04:45 -0700
Subject: [PATCH] libstdc++: Split up pstl/set.cc testcase
On Wed, May 17, 2023 at 12:32 PM Jonathan Wakely wrote:
> -template
> - _OutputIterator
> -__brick_generate_n(_OutputIterator __first, _Size __count, _Generator
> __g, /* is_vector = */ std::true_type) noexcept
> +template
>
> Missing uglification on Size.
>
> +_RandomAccessIterator
>
On Thu, May 11, 2023 at 1:52 PM Jonathan Wakely wrote:
> On Thu, 11 May 2023 at 13:42, Jonathan Wakely wrote:
>
>>
>>
>> On Thu, 11 May 2023 at 13:19, Mike Crowe wrote:
>>
>>> However, ...
>>>
>>> > > diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
>>> > > index
On Thu, May 11, 2023 at 5:21 AM Mike Crowe via Libstdc++ <
libstd...@gcc.gnu.org> wrote:
> On Wednesday 10 May 2023 at 12:31:12 +0100, Jonathan Wakely wrote:
> > On Wed, 10 May 2023 at 12:20, Jonathan Wakely via Libstdc++ <
> > libstd...@gcc.gnu.org> wrote:
> >
> > > This patch would avoid TSan
The attached (gzipped) patch brings libstdc++'s PSTL implementation up to
the current upstream version.
Tested x86_64-pc-linux-gnu, specifically with TBB 2020.3 (fedora 37 +
tbb-devel).
0001-libstdc-Synchronize-PSTL-with-upstream.patch.gz
Description: application/gzip
The second patch has now been backported and pushed to releases/gcc-12 and
releases/gcc-11.
On Mon, Feb 13, 2023 at 6:06 PM Thomas Rodgers wrote:
> Tested x86_64-pc-linux-gnu. Pushed to trunk.
>
> The first patch has also been backported and pushed to releases/gcc-12 and
> releases/gcc-11
>
>
Tested x86_64-pc-linux-gnu. Pushed to trunk.
The first patch has also been backported and pushed to releases/gcc-12 and
releases/gcc-11
The second patch fails to cleanly cherry-pick. Will resolve and push
shortly.
On Fri, Feb 10, 2023 at 4:41 PM Jonathan Wakely wrote:
> On Fri, 10 Feb 2023 at
This patch did not get committed in a timely manner after it was OK'd. In
revisiting the patch some issues were found that have lead me to resubmit
for review -
Specifically -
The original commit to add C++20 atomic_flag::test did not include the free
functions for atomic_flag_test[_explicit]
I agree with this change.
On Thu, Jan 5, 2023 at 4:22 PM Jonathan Wakely wrote:
> How about this?
>
> I don't think we should worry about targets without atomic int, so don't
> bother using types smaller than int.
>
>
> -- >8 --
>
> For non-futex targets the __platform_wait_t type is currently
s/__weak/__is_weak/g perhaps?
On Fri, Sep 9, 2022 at 11:46 AM Iain Sandoe via Libstdc++ <
libstd...@gcc.gnu.org> wrote:
>
>
> > On 9 Sep 2022, at 19:36, Rainer Orth
> wrote:
> >
>
> >> Here's a complete patch that combines the various incremental patches
> >> that have been going around. I'm
Looks good to me.
Tom.
On Wed, Sep 7, 2022 at 4:56 AM Jonathan Wakely wrote:
> Here's a complete patch that combines the various incremental patches
> that have been going around. I'm testing this now.
>
> Please take a look.
>
Looks good to me.
Tom.
On Wed, Sep 7, 2022 at 12:27 PM Jonathan Wakely via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:
> Tested powerpc64le-linux, pushed to trunk.
>
> Backports to gcc-11 and gcc-12 needed too.
>
> -- >8 --
>
> This file is missing the GCC Runtime Library Exception text in
Sorry for the delay in getting to this.
I am currently working on moving the bulk of the atomic wait implementation
into the .so. I'd like to get that work to a stable state before revisiting
this patch, but obviously if we want this to make it into GCC13, it needs
to happen sooner rather than
This is now committed to trunk, backported to releases/gcc-12 and
releases/gcc-11.
Apologies for the delay, it's been a wild couple of weeks.
Tom.
On Thu, Jul 7, 2022 at 2:31 AM Jonathan Wakely wrote:
> On Wed, 6 Jul 2022 at 22:42, Thomas Rodgers wrote:
> >
> > Ok for trunk? backport?
>
>
Ok for trunk? backport?
On Wed, Jul 6, 2022 at 1:56 PM Jonathan Wakely wrote:
> On Wed, 6 Jul 2022 at 02:05, Thomas Rodgers via Libstdc++
> wrote:
> >
> > This patch merges the spin loops in the atomic wait implementation which
> is
> > a
> > minor codegen improvement.
> >
> >
This patch merges the spin loops in the atomic wait implementation which is
a
minor codegen improvement.
libstdc++-v3/ChangeLog:
* include/bits/atomic_wait.h (__atomic_spin): Merge spin loops.
0001-libstdc-Minor-codegen-improvement-for-atomic-wait-sp.patch
Description: Binary data
Committed to trunk, backported to releases/gcc-11.
On Fri, Feb 11, 2022 at 12:22 PM Jonathan Wakely wrote:
> On Fri, 11 Feb 2022 at 17:40, Thomas Rodgers via Libstdc++
> wrote:
> >
> >
> > PR102994 "atomics: std::atomic::wait is not marked const" raises the
> > issue that the current
Looks ok to me. I just am curious, does the change to src/c++17/fs_path.cc
need to be part of this change (It's not obvious to me that it is related
to the other changes in the patch).
On Thu, Mar 17, 2022 at 12:01 PM Jonathan Wakely wrote:
> Tested x86_64-linux. Tom, any objection?
>
> -- >8
PR102994 "atomics: std::atomic::wait is not marked const" raises the
issue that the current libstdc++ implementation marks the notify members
const, the implementation strategy used by libstdc++, as well as libc++
and the Microsoft STL, do not require the atomic to be mutable (it is hard
to
Committed to trunk, backported to gcc-11.
On Wed, Feb 9, 2022 at 12:37 PM Jonathan Wakely wrote:
> On Wed, 9 Feb 2022 at 17:35, Thomas Rodgers via Libstdc++
> wrote:
> >
> > This patch changes the memory order used in the spin wait code to match
> > that of libc++.
>
> OK for trunk (and gcc-11
Tested x86_64-pc-linux-gnu, committed to master, backported to gcc-11.
On Wed, Feb 9, 2022 at 9:14 AM Jonathan Wakely wrote:
> On Wed, 9 Feb 2022 at 17:10, Thomas Rodgers wrote:
> >
> > Updated patch. I reverted the memory order change (and will submit that
> as another patch) and fixed some
This patch changes the memory order used in the spin wait code to match
that of libc++.
From 92caa08b272520ec4a272b302b37d8fb47afb2ab Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Wed, 9 Feb 2022 09:26:00 -0800
Subject: [PATCH] libstdc++: Strengthen memory order for atomic::wait/notify
Updated patch. I reverted the memory order change (and will submit that as
another patch) and fixed some spelling and grammar errors.
On Wed, Feb 9, 2022 at 2:43 AM Jonathan Wakely wrote:
> On Wed, 9 Feb 2022 at 00:57, Thomas Rodgers via Libstdc++
> wrote:
> >
> > This issue was observed as a
Excessively enthusiastic refactoring. I expect to rewrite most of this as
part of the work I'm starting now for GCC13 stage1.
On Wed, Feb 9, 2022 at 2:43 AM Jonathan Wakely wrote:
> On Wed, 9 Feb 2022 at 00:57, Thomas Rodgers via Libstdc++
> wrote:
> >
> > This issue was observed as a
This issue was observed as a deadloack in
29_atomics/atomic/wait_notify/100334.cc on vxworks. When a wait is
"laundered" (e.g. type T* does not suffice as a waitable address for the
platform's native waiting primitive), the address waited is that of the
_M_ver member of __waiter_pool_base, so
Tested x86_64-pc-linux-gnu, committed to master.
Backported to GCC-11.
On Sun, Jan 16, 2022 at 12:31 PM Jonathan Wakely wrote:
>
>
> On Sun, 16 Jan 2022 at 01:48, Thomas Rodgers via Libstdc++ <
> libstd...@gcc.gnu.org> wrote:
>
>> This patch updates the memory order of atomic accesses to the
This patch updates the memory order of atomic accesses to the waiter's
count to match libc++'s usage. It should be backported to GCC11.
Tested x86_64-pc-linux-gnu.
From f5ed7674f86283db4f4ff49a2cc65d4f852413a1 Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Sat, 15 Jan 2022 17:40:49 -0800
From c2b74fd7cf2668d288f46da42565e5eb954e5e1f Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Fri, 14 Jan 2022 18:30:27 -0800
Subject: [PATCH] libstdc++: Add missing free functions for atomic_flag
[PR103934]
libstdc++-v3/ChangeLog:
PR103934
* include/std/atomic: Add missing free
Tested uild-x86_64-pc-linux-gnu, pushed to trunk and gcc-11.
On Thu, Nov 25, 2021 at 1:24 PM Jonathan Wakely wrote:
> On Wed, 24 Nov 2021 at 01:27, Thomas Rodgers wrote:
> >
> > const qualification was also missing in the free functions for
> wait/wait_explicit/notify_one/notify_all. Revised
const qualification was also missing in the free functions for
wait/wait_explicit/notify_one/notify_all. Revised patch attached.
On Tue, Nov 9, 2021 at 11:40 AM Jonathan Wakely wrote:
> On Tue, 9 Nov 2021 at 18:09, Thomas Rodgers wrote:
>
>> Revised patch attached.
>>
>
> OK for trunk and
Revised patch attached.
On Fri, Nov 5, 2021 at 4:46 PM Jonathan Wakely
wrote:
> On Fri, 5 Nov 2021 at 21:51, Jonathan Wakely via Libstdc++
> wrote:
> >
> > OK, thanks.
>
> Actually, we should really have a test to verify it can be called on a
> const object. Please add something when you
From 360c094a0725bb0cc444115c0377db10e5e9ae1f Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Fri, 5 Nov 2021 14:30:24 -0700
Subject: [PATCH] libstdc++: Make atomic::wait() const [PR102994]
This was an oversight in the original commit adding wait/notify
to atomic.
libstdc++-v3/ChangeLog:
This should address Jonathan's feedback and adds support for atomic_ref
On Wed, Sep 29, 2021 at 5:14 AM Jonathan Wakely wrote:
> On Mon, 27 Sept 2021 at 15:11, Thomas Rodgers
> wrote:
> >
> > From: Thomas Rodgers
> >
> > Now with checks for __has_builtin(__builtin_clear_padding)
> >
> > This
On Wed, Sep 29, 2021 at 5:14 AM Jonathan Wakely wrote:
> On Mon, 27 Sept 2021 at 15:11, Thomas Rodgers
> wrote:
> >
> > From: Thomas Rodgers
> >
> > Now with checks for __has_builtin(__builtin_clear_padding)
> >
> > This change implements P0528 which requires that padding bits not
> >
Agreed, I'll revise the patch to do so.
On Thu, Sep 23, 2021 at 12:07 PM Jakub Jelinek wrote:
> On Thu, Sep 23, 2021 at 11:08:37AM -0700, Thomas Rodgers wrote:
> > From: Thomas Rodgers
> >
> > This change implements P0528 which requires that padding bits not
> > participate in atomic compare
Agreed.
On Thu, Sep 2, 2021 at 10:58 AM Jonathan Wakely wrote:
> Signed-off-by: Jonathan Wakely
>
> libstdc++-v3/ChangeLog:
>
> * include/bits/atomic_wait.h (_GLIBCXX_HAVE_PLATFORM_WAIT):
> Define before first attempt to check it.
>
> Tested x86_64-linux and powerpc64-linux,
Tested x86_64-pc-linux-gnu.
Committed to master, backported to releases/gcc-11.
On Thu, Jun 17, 2021 at 9:46 AM Jonathan Wakely
wrote:
> On Wed, 16 Jun 2021 at 20:53, Thomas Rodgers
> wrote:
> >
> > Same as previous version except removing the copyright notice from the
> > test.
> >
> >
Pretty sure I know this is, I'll work on a fix today.
On Wed, Jun 9, 2021 at 7:30 AM Christophe Lyon
wrote:
> Hi,
>
>
> On Wed, 9 Jun 2021 at 01:05, Thomas Rodgers via Gcc-patches
> wrote:
> >
> > Tested x86_64-pc-linux-gnu, committed to master, backpo
Tested x86_64-pc-linux-gnu, committed to master, backported to
releases/gcc-11.
On Fri, Jun 4, 2021 at 1:30 PM Jonathan Wakely wrote:
>
>
> On Fri, 4 Jun 2021 at 20:54, Thomas Rodgers wrote:
>
>> This is a remnant of poorly executed refactoring.
>>
>
> OK for trunk and gcc-11, thanks.
>
>
>
>>
Tested x86_64-pc-linux-gnu, committed to master, backported to
releases/gcc-11.
On Tue, Jun 8, 2021 at 8:44 AM Jonathan Wakely wrote:
> On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote:
>
>> This time without the repeatred [PR] in the subject line.
>>
>> Fixes libstdc++/100889
>>
>
> This
- Original Message -
> Hi!
>
> In GCC 10, parallel_backend.h just included parallel_backend_{serial,tbb}.h
> and
> did nothing beyond that, and parallel_backend_tbb.h provided directly
> namespace __pstl { namespace __par_backend { ... } }
> and defined everything in there, while
Tested x86_64-pc-linux-gnu, committed to master.
Jonathan Wakely writes:
> On 17/12/20 15:37 -0800, Thomas Rodgers wrote:
>>From: Thomas Rodgers
>>
>>Cleans up a few things mentioned on IRC.
>>
>>Adds
>>
>>libstdc++/ChangeLog:
>>
>> * doc/doxygen/user.cfg.in: Add new header.
>> *
Tested x86_64-pc-linux-gnu, committed to trunk.
Jonathan Wakely writes:
> On 30/11/20 10:17 -0800, Thomas Rodgers wrote:
>>From: Thomas Rodgers
>>
>>Adds __cpp_lib_atomic_wait feature test macro which was overlooked in
>>the initial commit of this feature. Replaces uses of
Testsed x86_64-pc-linux-gnu, committed to master.
Jonathan Wakely writes:
> On 02/11/20 08:10 -0800, Thomas Rodgers wrote:
>>From: Thomas Rodgers
>>
>>IGNORE the previous patch.
>>
>>Changes implementation to use a private __mutex type as discussed on
>>IRC.
>>
>>libstdc++/ChangeLog:
>>
Jonathan Wakely writes:
> On 07/10/20 18:15 -0700, Thomas Rodgers wrote:
>>@@ -500,6 +576,40 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
>> }
>> #endif
>>
>>+#if __cplusplus > 201703L && _GLIBCXX_USE_CXX11_ABI
>>+ basic_istringstream(ios_base::openmode __mode, const allocator_type&
>>__a)
>>+
Jonathan Wakely writes:
> On 11/09/20 16:58 -0700, Thomas Rodgers wrote:
>>From: Thomas Rodgers
>>
>>This patch supercedes both the Add C++2a synchronization support patch
>>being replied to *and* the patch adding wait/notify_* to atomic_flag.
>>
>>Add support for -
>> *
Thanks, I'll apply locally (and sync those changes to the patch I'm
preparing for upstream).
Jonathan Wakely writes:
> On 21/09/20 08:19 -0700, Thomas Rodgers wrote:
>>
>>
>>> On Sep 21, 2020, at 7:40 AM, Jonathan Wakely wrote:
>>>
>>> On 15/09/20 20:35 -0700, Thomas Rodgers wrote:
From:
libstdc++-v3/ChangeLog:
* include/std/memory: Move #include inside C++11
conditional includes.
Tested x86_64-pc-linux-gnu, committed to master.
---
libstdc++-v3/include/std/memory | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
I *think* I have addressed everything in the attached patch.
commit 24a989d2bf2158bdbe2511310d0583d0c6226f71
Author: Thomas Rodgers
Date: Mon Apr 6 17:58:47 2020 -0700
Add C++2a synchronization support
Add support for -
atomic wait/notify_one/notify_all
Jonathan Wakely writes:
> On 09/05/20 17:01 -0700, Thomas Rodgers via Libstdc++ wrote:
>>+#include
>
> shouldn't be here (it adds runtime cost, as well as
> compile-time).
>
Oversight, not removed after debugging it.
>
> Can't this just be __old instead of *std::__addressof(__old) ?
>
* Note, this patch supersedes my previous atomic wait and semaphore
patches.
Add support for -
atomic wait/notify_one/notify_all
counting_semaphore
binary_semaphore
latch
* include/Makefile.am (bits_headers): Add new header.
* include/Makefile.in:
Tested x86_64_linux.
Commited to master, backported to releases/gcc-9.
Jonathan Wakely writes:
> On 23/04/20 13:09 -0700, Thomas Rodgers via Libstdc++ wrote:
>>
>> * include/experimental/net/executor: Mark
>> system_context::system_context() = default.
>
> s/default/delete/ :-)
>
> But
* include/experimental/net/executor: Mark
system_context::system_context() = default.
* testsuite/experimental/net/executor/1.cc: Add new
test for deleted system_context ::system_context().
---
libstdc++-v3/include/experimental/executor| 2 +-
Updated patch, fixes some whitespace issues along with ensuring that
libstdc++-v3/include/Makefile.in is regenerated.
>From 2f707faab97abde776bc7c6e06f7a7c471711962 Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Thu, 12 Mar 2020 17:50:09 -0700
Subject: [PATCH] Add C++2a
Updated patch attached, addresses some minor issues I found after
sending the original version.
>From 0c677da72a058e37d0ea1975dc70e53c4308963c Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Thu, 12 Mar 2020 17:50:09 -0700
Subject: [PATCH] Add C++2a wait/notify_one/notify_all support to
From f650ed07ed13c40624b72b7b4bebd967fa33f917 Mon Sep 17 00:00:00 2001
From: Thomas Rodgers
Date: Thu, 12 Mar 2020 17:50:09 -0700
Subject: [PATCH] Add C++2a wait/notify_one/notify_all support to std::atomic<>
* include/Makefile.am (bits_headers): Add new header.
* include/Mamefile.in:
57 matches
Mail list logo
