Re: New ThreadSanitizer runtime (v3)

2021-12-23 Thread Dmitry Vyukov via Gcc
On Thu, 23 Dec 2021 at 13:10, Martin Liška wrote: > >> On 11/22/21 20:01, Dmitry Vyukov wrote: > >>> I've already reverted the change. So I will include a fix into the next > >>> version. > >>> Thanks for notifying. > >> > >> Hello. > >> > >> Am I correct that the patch set is installed again?

Re: New ThreadSanitizer runtime (v3)

2021-12-23 Thread Martin Liška
On 11/30/21 05:17, Dmitry Vyukov wrote: On Mon, 29 Nov 2021 at 19:16, Martin Liška wrote: On 11/22/21 20:01, Dmitry Vyukov wrote: I've already reverted the change. So I will include a fix into the next version. Thanks for notifying. Hello. Am I correct that the patch set is installed

Re: New ThreadSanitizer runtime (v3)

2021-11-29 Thread Dmitry Vyukov via Gcc
On Mon, 29 Nov 2021 at 19:16, Martin Liška wrote: > > On 11/22/21 20:01, Dmitry Vyukov wrote: > > I've already reverted the change. So I will include a fix into the next > > version. > > Thanks for notifying. > > Hello. > > Am I correct that the patch set is installed again? Any near future

Re: New ThreadSanitizer runtime (v3)

2021-11-29 Thread Martin Liška
On 11/22/21 20:01, Dmitry Vyukov wrote: I've already reverted the change. So I will include a fix into the next version. Thanks for notifying. Hello. Am I correct that the patch set is installed again? Any near future plans for another revert of the patch? Do you think it's the right time to

Re: New ThreadSanitizer runtime (v3)

2021-11-23 Thread Dmitry Vyukov via Gcc
On Tue, 23 Nov 2021 at 17:16, Florian Weimer wrote: > > * Dmitry Vyukov: > > > On Tue, 23 Nov 2021 at 14:59, Florian Weimer wrote: > >> > >> * Dmitry Vyukov: > >> > >> > Or what kind of integration do you mean? Tsan did not have any direct > >> > integration and worked with unmodified glibc. >

Re: New ThreadSanitizer runtime (v3)

2021-11-23 Thread Florian Weimer via Gcc
* Dmitry Vyukov: > On Tue, 23 Nov 2021 at 14:59, Florian Weimer wrote: >> >> * Dmitry Vyukov: >> >> > Or what kind of integration do you mean? Tsan did not have any direct >> > integration and worked with unmodified glibc. >> >> I thought there is a false-positive data race report if an

Re: New ThreadSanitizer runtime (v3)

2021-11-23 Thread Dmitry Vyukov via Gcc
On Tue, 23 Nov 2021 at 14:59, Florian Weimer wrote: > > * Dmitry Vyukov: > > > Or what kind of integration do you mean? Tsan did not have any direct > > integration and worked with unmodified glibc. > > I thought there is a false-positive data race report if an initial-exec > or local-exec TLS

Re: New ThreadSanitizer runtime (v3)

2021-11-23 Thread Florian Weimer via Gcc
* Dmitry Vyukov: > Or what kind of integration do you mean? Tsan did not have any direct > integration and worked with unmodified glibc. I thought there is a false-positive data race report if an initial-exec or local-exec TLS variable is reused (whose memory is not managed by malloc). Thanks,

Re: New ThreadSanitizer runtime (v3)

2021-11-23 Thread Dmitry Vyukov via Gcc
On Tue, 23 Nov 2021 at 14:49, Florian Weimer wrote: > > * Dmitry Vyukov via Gcc: > > > I wanted to give heads up regarding a significant re-design of the > > ThreadSanitizer runtime: > > https://reviews.llvm.org/D112603 > > Currently it's submitted: > >

Re: New ThreadSanitizer runtime (v3)

2021-11-23 Thread Florian Weimer via Gcc
* Dmitry Vyukov via Gcc: > I wanted to give heads up regarding a significant re-design of the > ThreadSanitizer runtime: > https://reviews.llvm.org/D112603 > Currently it's submitted: > https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027 > but can well be rolled

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Marco Elver via Gcc
On Mon, 22 Nov 2021 at 20:08, Martin Liška wrote: > > On 11/22/21 20:00, Dmitry Vyukov wrote: > > Not sure about gcc, but in clang the old no_sanitize_thread attribute > > disabled only part of instrumentation (only memory accesses, but not > > atomics and function entry/exit). The new attribute

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Jakub Jelinek via Gcc
On Mon, Nov 22, 2021 at 08:00:38PM +0100, Dmitry Vyukov wrote: > Not sure about gcc, but in clang the old no_sanitize_thread attribute > disabled only part of instrumentation (only memory accesses, but not > atomics and function entry/exit). The new attribute disables all > instrumentation. In

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Martin Liška
On 11/22/21 20:00, Dmitry Vyukov wrote: Not sure about gcc, but in clang the old no_sanitize_thread attribute disabled only part of instrumentation (only memory accesses, but not atomics and function entry/exit). The new attribute disables all instrumentation. And what about

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Dmitry Vyukov via Gcc
On Mon, 22 Nov 2021 at 19:38, Martin Liška wrote: > > On 11/22/21 16:22, Dmitry Vyukov wrote: > > I wanted to give heads up regarding a significant re-design of the > > ThreadSanitizer runtime: > > https://reviews.llvm.org/D112603 > > Currently it's submitted: > >

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Dmitry Vyukov via Gcc
On Mon, 22 Nov 2021 at 19:31, Martin Liška wrote: > > On 11/22/21 16:22, Dmitry Vyukov wrote: > > Hi gcc developers, > > Hello. > > > > > I wanted to give heads up regarding a significant re-design of the > > Thanks for it. > > > ThreadSanitizer runtime: > > https://reviews.llvm.org/D112603 > >

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Martin Liška
On 11/22/21 16:22, Dmitry Vyukov wrote: I wanted to give heads up regarding a significant re-design of the ThreadSanitizer runtime: https://reviews.llvm.org/D112603 Currently it's submitted: https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027 And I noticed the

Re: New ThreadSanitizer runtime (v3)

2021-11-22 Thread Martin Liška
On 11/22/21 16:22, Dmitry Vyukov wrote: Hi gcc developers, Hello. I wanted to give heads up regarding a significant re-design of the Thanks for it. ThreadSanitizer runtime: https://reviews.llvm.org/D112603 Currently it's submitted:

New ThreadSanitizer runtime (v3)

2021-11-22 Thread Dmitry Vyukov via Gcc
Hi gcc developers, I wanted to give heads up regarding a significant re-design of the ThreadSanitizer runtime: https://reviews.llvm.org/D112603 Currently it's submitted: https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027 but can well be rolled back if too many