Re: [PATCH 0/7] ira/lra: Support subreg coalesce

2023-11-09 Thread Richard Biener
On Thu, Nov 9, 2023 at 9:25 PM Vladimir Makarov wrote: > > > On 11/7/23 22:47, Lehua Ding wrote: > > > > Lehua Ding (7): > >ira: Refactor the handling of register conflicts to make it more > > general > >ira: Add live_subreg problem and apply to ira pass > >ira: Support subreg

Fwd: [PING][PATCH V15 4/4] ree: Improve ree pass using defined abi interfaces

2023-11-09 Thread Ajit Agarwal
Ping! Ok for trunk. Thanks & Regards Ajit Forwarded Message Subject: [PATCH V15 4/4] ree: Improve ree pass using defined abi interfaces Date: Sun, 29 Oct 2023 16:14:17 +0530 From: Ajit Agarwal To: gcc-patches , Jeff Law , Vineet Gupta , Bernhard Reutner-Fischer CC: Richard

[Bug tree-optimization/112464] [14 Regression] ICE avx512 with -ftrapv since r14-5076

2023-11-09 Thread rdapp at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112464 --- Comment #2 from Robin Dapp --- I tested diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index a544bc9b059..257fd40793e 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -7084,7 +7084,7 @@

[Bug tree-optimization/112468] [14 Regression] Missed phi-opt after recent change

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112468 --- Comment #4 from Andrew Pinski --- (In reply to Tamar Christina from comment #3) > Hmm I rather think PHI ops should handle that null like other passes do. The > folding is supposed to already test and only happen if it succeeds. It

Re: [PATCH, expand] Call misaligned memory reference in expand_builtin_return [PR112417]

2023-11-09 Thread HAO CHEN GUI
Hi Richard, Thanks so much for your comments. 在 2023/11/9 19:41, Richard Biener 写道: > I'm not sure if the testcase is valid though? > > @defbuiltin{{void} __builtin_return (void *@var{result})} > This built-in function returns the value described by @var{result} from > the containing function.

[Bug c++/91023] Unification Fails for parameter pack

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91023 Andrew Pinski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug c++/86426] g++ ICE at on valid code in tree_operand_check, at tree.h:3615

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86426 Andrew Pinski changed: What|Removed |Added CC||christoph.hoeger@celeraone.

[Bug c++/91023] Unification Fails for parameter pack

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91023 --- Comment #5 from Andrew Pinski --- The current ICE is: ``` t.cc:10:11: internal compiler error: tree check: expected type_argument_pack or nontype_argument_pack, have record_type in unify_pack_expansion, at cp/pt.cc:23947 0x979320

[Bug c++/91023] Unification Fails for parameter pack

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91023 Andrew Pinski changed: What|Removed |Added Keywords|needs-reduction | --- Comment #4 from Andrew Pinski ---

[Bug target/112374] [14 Regression] `--with-arch=skylake-avx512 --with-cpu=skylake-avx512` causes a comparison failure

2023-11-09 Thread crazylht at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112374 --- Comment #9 from Hongtao.liu --- When I remove all cond_ patterns, it passed bootstrap. continue to rootcause the exact pattern which cause the bootstrapped failure

[Bug tree-optimization/112468] [14 Regression] Missed phi-opt after recent change

2023-11-09 Thread tnfchris at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112468 Tamar Christina changed: What|Removed |Added CC||tnfchris at gcc dot gnu.org ---

[Bug c++/110961] internal compiler error: segmentation fault

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110961 Andrew Pinski changed: What|Removed |Added Last reconfirmed||2023-11-10 Ever confirmed|0

[PATCH] RISC-V: Fix bug that XTheadMemPair extension caused fcsr not to be saved and restored before and after interrupt.

2023-11-09 Thread Jin Ma
The t0 register is used as a temporary register for interrupts, so it needs special treatment. It is necessary to avoid using "th.ldd" in the interrupt program to stop the subsequent operation of the t0 register, so they need to exchange positions in the function "riscv_for_each_saved_reg".

[PING ^1] [PATCH v2 3/4] Improve functionality of ree pass with various constants with AND operation.

2023-11-09 Thread Ajit Agarwal
ping! Forwarded Message Subject: [PING ^0] [PATCH v2 3/4] Improve functionality of ree pass with various constants with AND operation. Date: Sun, 15 Oct 2023 18:28:51 +0530 From: Ajit Agarwal To: gcc-patches CC: Jeff Law , Vineet Gupta , Richard Biener , Segher Boessenkool

[PING ^2][PATCH v2] rs6000: Add new pass for replacement of contiguous addresses vector load lxv with lxvp

2023-11-09 Thread Ajit Agarwal
Ping ^2. On 23/10/23 2:02 pm, Ajit Agarwal wrote: > > > Ping ^1. > > Forwarded Message > Subject: [PING ^0][PATCH v2] rs6000: Add new pass for replacement of > contiguous addresses vector load lxv with lxvp > Date: Sun, 15 Oct 2023 17:43:24 +0530 > From: Ajit Agarwal > To:

[PING][PATCH v3] rs6000/p8swap: Fix incorrect lane extraction by vec_extract() [PR106770]

2023-11-09 Thread Surya Kumari Jangala
Ping On 03/11/23 1:14 pm, Surya Kumari Jangala wrote: > Hi Segher, > I have incorporated changes in the code as per the review comments provided > by you > for version 2 of the patch. Please review. > > Regards, > Surya > > > rs6000/p8swap: Fix incorrect lane extraction by vec_extract()

Re: [PATCH] tree-ssa-loop-ivopts : Add live analysis in regs used in decision making

2023-11-09 Thread Ajit Agarwal
Hello Richard: On 09/11/23 6:21 pm, Richard Biener wrote: > On Wed, Nov 8, 2023 at 4:00 PM Ajit Agarwal wrote: >> >> tree-ssa-loop-ivopts : Add live analysis in regs used in decision making. >> >> Add live anaysis in regs used calculation in decision making of >> selecting ivopts candidates. >>

RE: [PATCH v1] RISC-V: Support vec_init for trailing same element

2023-11-09 Thread Li, Pan2
Committed, thanks Juzhe. Pan From: juzhe.zhong Sent: Friday, November 10, 2023 2:32 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; Li, Pan2 ; Wang, Yanzhang ; kito.ch...@gmail.com Subject: Re: [PATCH v1] RISC-V: Support vec_init for trailing same element lgtm Replied Message From

Re: [PATCH v1] RISC-V: Support vec_init for trailing same element

2023-11-09 Thread juzhe.zhong
lgtm Replied Message Frompan2...@intel.comDate11/10/2023 14:22 Togcc-patches@gcc.gnu.org Ccjuzhe.zh...@rivai.ai,pan2...@intel.com,yanzhang.w...@intel.com,kito.ch...@gmail.comSubject[PATCH v1] RISC-V: Support vec_init for trailing same element

[PATCH] Simplify vector ((VCE?(a cmp b ? -1 : 0)) < 0) ? c : d to just VCE:((a cmp b) ? (VCE c) : (VCE d)).

2023-11-09 Thread liuhongt
When I'm working on PR112443, I notice there's some misoptimizations: after we fold _mm{,256}_blendv_epi8/pd/ps into gimple, the backend fails to combine it back to v{,p}blendv{v,ps,pd} since the pattern is too complicated, so I think maybe we should hanlde it in the gimple level. The dump is

Re: RFA: make scan-assembler* ignore LTO sections (Was: Re: committed [RISC-V]: Harden test scan patterns)

2023-11-09 Thread Jeff Law
On 11/8/23 09:00, Joern Rennecke wrote: On Fri, 29 Sept 2023 at 14:54, Jeff Law wrote: ... Joern can you post a follow-up manual twiddle so that other ports can follow your example and avoid this problem? THanks, jeff The attached patch makes the scan-assembler* directives ignore the

Re: [PATCH v4 1/2] c++: Initial support for P0847R7 (Deducing this) [PR102609]

2023-11-09 Thread waffl3x
Ahh, I should have updated my progress last night after all, it would have saved us some time. Regardless, it's nice to see we independently came to the same conclusions. Side note, would you prefer I compile the lambda and by-value fixes into a new version of this patch? Or as a separate patch?

[Bug libstdc++/112473] integer_sequence accepts non-integer types

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112473 Andrew Pinski changed: What|Removed |Added Last reconfirmed||2023-11-10

[Bug libstdc++/112473] New: integer_sequence accepts non-integer types

2023-11-09 Thread hewillk at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112473 Bug ID: 112473 Summary: integer_sequence accepts non-integer types Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component:

[Bug c++/69372] GCC allows array and function types to be caught by reference.

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69372 Andrew Pinski changed: What|Removed |Added CC||arthur.j.odwyer at gmail dot com ---

[Bug c++/112471] catch handler of type "reference to array" should be unreachable, but is reached

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112471 Andrew Pinski changed: What|Removed |Added Resolution|--- |DUPLICATE

[Bug c++/112471] catch handler of type "reference to array" should be unreachable, but is reached

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112471 Andrew Pinski changed: What|Removed |Added See Also||https://gcc.gnu.org/bugzill

Re: [PATCH v3 1/2] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-09 Thread waffl3x
> > I'm unfortunately going down a rabbit hole again. > > > > --function.h:608 > > `/* If pointers to member functions use the least significant bit to > > indicate whether a function is virtual, ensure a pointer to this function > > will have that bit clear. */ #define MINIMUM_METHOD_BOUNDARY

[Bug tree-optimization/112472] New: (trunc)copysign((extend)x, CST) is not optimized to just copysign(x, CST')

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112472 Bug ID: 112472 Summary: (trunc)copysign((extend)x, CST) is not optimized to just copysign(x, CST') Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords:

[Bug c++/112471] New: catch handler of type "reference to array" should be unreachable, but is reached

2023-11-09 Thread arthur.j.odwyer at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112471 Bug ID: 112471 Summary: catch handler of type "reference to array" should be unreachable, but is reached Product: gcc Version: 14.0 Status: UNCONFIRMED

[Bug tree-optimization/112468] [14 Regression] Missed phi-opt after recent change

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112468 --- Comment #2 from Andrew Pinski --- new_stmt = build_call_internal (ifn, res_op); static gcall * build_call_internal (internal_fn fn, gimple_match_op *res_op) { if (direct_internal_fn_p (fn)) { tree_pair types =

Re: [PATCH 2/3] attribs: Consider namespaces when comparing attributes

2023-11-09 Thread Jeff Law
On 11/6/23 05:24, Richard Sandiford wrote: decl_attributes and comp_type_attributes both had code that iterated over one list of attributes and looked for coresponding attributes in another list. This patch makes those lookups namespace-aware. Tested on aarch64-linux-gnu & x86_64-linux-gnu.

Re: [PATCH v3] libiberty: Use posix_spawn in pex-unix when available.

2023-11-09 Thread Jeff Law
On 10/4/23 12:28, Brendan Shanks wrote: Hi, This patch implements pex_unix_exec_child using posix_spawn when available. This should especially benefit recent macOS (where vfork just calls fork), but should have equivalent or faster performance on all platforms. In addition, the

[Bug tree-optimization/112468] [14 Regression] Missed phi-opt after recent change

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112468 Andrew Pinski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-09 Thread Jeff Law
On 11/9/23 18:57, Kewen.Lin wrote: Hi Maxim and Alexander, Thanks a lot for the review comments! on 2023/11/10 01:40, Alexander Monakov wrote: On Thu, 9 Nov 2023, Maxim Kuvyrkov wrote: Hi Kewen, Below are my comments. I don't want to override Alexander's review, and if the patch looks

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-09 Thread Jeff Law
On 11/9/23 10:40, Alexander Monakov wrote: On Thu, 9 Nov 2023, Maxim Kuvyrkov wrote: Hi Kewen, Below are my comments. I don't want to override Alexander's review, and if the patch looks good to him, it's fine to ignore my concerns. My main concern is that this adds a new entity --

[PATCH] Support vec_set/vec_extract/vec_init for V4HF/V2HF.

2023-11-09 Thread liuhongt
Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ready push to trunk. gcc/ChangeLog: * config/i386/i386-expand.cc (ix86_expand_vector_init_duplicate): Handle V4HF/V4BF and V2HF/V2BF. (ix86_expand_vector_init_one_nonzero): Ditto.

[PATCH] RISC-V: Add combine optimization by slideup for vec_init vectorization

2023-11-09 Thread Juzhe-Zhong
This patch is a small optimization for vector initialization. Discovered when I am evaluating benchmarks. Consider this following case: void foo3 (int8_t *out, int8_t x, int8_t y) { v16qi v = {y, y, y, y, y, y, y, x, x, x, x, x, x, x, x, x}; *(v16qi*)out = v; } Before this patch:

[PATCH] RISC-V: Robustify vec_init pattern[NFC]

2023-11-09 Thread Juzhe-Zhong
Although current GCC didn't cause ICE when I create FP16 vec_init case with -march=rv64gcv (no ZVFH), current vec_init pattern looks wrong. Since V_VLS FP16 predicate is TARGET_VECTOR_ELEN_FP_16, wheras vec_init needs vfslide1down/vfslide1up. It makes more sense to robustify the vec_init

[Bug target/112470] New: [AARCH64]stack-protector vulnerability fixing solution impact code size and performance.

2023-11-09 Thread dongjianqiang2 at huawei dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112470 Bug ID: 112470 Summary: [AARCH64]stack-protector vulnerability fixing solution impact code size and performance. Product: gcc Version: 13.1.0 Status: UNCONFIRMED

[Bug c/112463] ternary operator / -Wsign-compare inconsistency

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112463 --- Comment #2 from Andrew Pinski --- So digging through the history and I find this: https://gcc.gnu.org/pipermail/gcc-patches/1999-December/024572.html Which added the original place for the warning. There has been improvements to it later

[Bug c/112463] ternary operator / -Wsign-compare inconsistency

2023-11-09 Thread egallager at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112463 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org

Re: [PATCH] Simplify vector ((VCE?(a cmp b ? -1 : 0)) < 0) ? c : d to just (VCE:a cmp VCE:b) ? c : d.

2023-11-09 Thread Hongtao Liu
On Fri, Nov 10, 2023 at 10:11 AM Andrew Pinski wrote: > > On Thu, Nov 9, 2023 at 5:52 PM liuhongt wrote: > > > > When I'm working on PR112443, I notice there's some misoptimizations: after > > we > > fold _mm{,256}_blendv_epi8/pd/ps into gimple, the backend fails to combine > > it > > back to

Re: [PATCH] Simplify vector ((VCE?(a cmp b ? -1 : 0)) < 0) ? c : d to just (VCE:a cmp VCE:b) ? c : d.

2023-11-09 Thread Andrew Pinski
On Thu, Nov 9, 2023 at 5:52 PM liuhongt wrote: > > When I'm working on PR112443, I notice there's some misoptimizations: after we > fold _mm{,256}_blendv_epi8/pd/ps into gimple, the backend fails to combine it > back to v{,p}blendv{v,ps,pd} since the pattern is too complicated, so I think > maybe

Re: [PATCH-2v2, rs6000] Enable vector mode for by pieces equality compare [PR111449]

2023-11-09 Thread Kewen.Lin
Hi, on 2023/11/9 09:31, HAO CHEN GUI wrote: > Hi, > This patch enables vector mode for by pieces equality compare. It > adds a new expand pattern - cbrnachv16qi4 and set MOVE_MAX_PIECES > and COMPARE_MAX_PIECES to 16 bytes when P8 vector enabled. The compare > relies both move and compare

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-09 Thread Kewen.Lin
Hi Maxim and Alexander, Thanks a lot for the review comments! on 2023/11/10 01:40, Alexander Monakov wrote: > > On Thu, 9 Nov 2023, Maxim Kuvyrkov wrote: > >> Hi Kewen, >> >> Below are my comments. I don't want to override Alexander's review, and if >> the patch looks good to him, it's fine

[PATCH] Simplify vector ((VCE?(a cmp b ? -1 : 0)) < 0) ? c : d to just (VCE:a cmp VCE:b) ? c : d.

2023-11-09 Thread liuhongt
When I'm working on PR112443, I notice there's some misoptimizations: after we fold _mm{,256}_blendv_epi8/pd/ps into gimple, the backend fails to combine it back to v{,p}blendv{v,ps,pd} since the pattern is too complicated, so I think maybe we should hanlde it in the gimple level. The dump is

[PATCH] Initial support for AVX10.1

2023-11-09 Thread Haochen Jiang
gcc/ChangeLog: * common/config/i386/cpuinfo.h (get_available_features): Add avx10_set and version and detect avx10.1. (cpu_indicator_init): Handle avx10.1-512. * common/config/i386/i386-common.cc (OPTION_MASK_ISA2_AVX10_1_256_SET): New.

[RFC] Intel AVX10.1 Compiler Design and Support

2023-11-09 Thread Haochen Jiang
Hi all, This RFC patch aims to add AVX10.1 options. After we added -m[no-]evex512 support, it makes a lot easier to add them comparing to the August version. Detail for AVX10 is shown below: Intel Advanced Vector Extensions 10 (Intel AVX10) Architecture Specification It describes the Intel

Re: [PATCH 1/3] attribs: Cache the gnu namespace

2023-11-09 Thread Jeff Law
On 11/6/23 05:23, Richard Sandiford wrote: Later patches add more calls to get_attribute_namespace. For scoped attributes, this is a simple operation on tree pointers. But for normal GNU attributes (the vast majority), it involves a call to get_identifier ("gnu"). This patch caches the

Re: [PATCH] g++: Add require-effective-target to multi-input file testcase pr95401.cc

2023-11-09 Thread Jeff Law
On 11/3/23 00:18, Patrick O'Neill wrote: On non-vector targets dejagnu attempts dg-do compile for pr95401.cc. This produces a command like this: g++ pr95401.cc pr95401a.cc -S -o pr95401.s which isn't valid (gcc does not accept multiple input files when using -S with -o). This patch adds

Re: [committed] RISC-V: Fix INSN costing and more zicond tests

2023-11-09 Thread Maciej W. Rozycki
On Thu, 9 Nov 2023, Jeff Law wrote: > > Can we have the insn costing reverted to correct calculation? > What needs to happen is that code needs to be extended, not reverted. Many > codes have to be synthesized based on the condition and the true/false arms. > That's not currently accounted for.

Re: Re: [PATCH V3] test: Fix FAIL of pr97428.c for RVV

2023-11-09 Thread juzhe.zh...@rivai.ai
Thanks Jeff. Committed. juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-11-10 09:26 To: Juzhe-Zhong; gcc-patches CC: rguenther Subject: Re: [PATCH V3] test: Fix FAIL of pr97428.c for RVV On 11/7/23 08:18, Juzhe-Zhong wrote: > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/pr97428.c: Add

Re: [PATCH V3] test: Fix FAIL of pr97428.c for RVV

2023-11-09 Thread Jeff Law
On 11/7/23 08:18, Juzhe-Zhong wrote: gcc/testsuite/ChangeLog: * gcc.dg/vect/pr97428.c: Add additional compile option for riscv. I don't guess we know if other targets would benefit from this option. The only reference in gcc-testresults to pr97428.c is an armv7 run from 2022. So

Re: [PATCH] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets

2023-11-09 Thread Jeff Law
On 11/2/23 17:45, Patrick O'Neill wrote: Testcases in g++.dg/vect rely on check_vect_support_and_set_flags to set dg-do-what-default and avoid running vector tests on non-vector targets. The three testcases in this patch overwrite the default with dg-do run. Removing the dg-do run directive

Re: Re: [PATCH] RISC-V/testsuite: Fix zvfh tests.

2023-11-09 Thread juzhe.zh...@rivai.ai
I am using --with-arch=rv32gcv --with-abi=ilp32d I change dg-additional-option into dg-option of all those tests. Issues gone. juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-11-10 09:15 To: juzhe.zh...@rivai.ai; Robin Dapp; gcc-patches; palmer; kito.cheng Subject: Re: [PATCH]

Re: [PATCH 12/12] mode-switching: Add a backprop hook

2023-11-09 Thread Jeff Law
On 11/5/23 11:50, Richard Sandiford wrote: This patch adds a way for targets to ask that selected mode changes be brought forward, through a combination of: (1) requiring a mode in blocks where the entity was previously transparent (2) pushing the transition at the head of a block onto

Re: [PATCH] RISC-V/testsuite: Fix zvfh tests.

2023-11-09 Thread Jeff Law
On 11/9/23 18:12, juzhe.zh...@rivai.ai wrote: How to fix it ? I am pretty noob on testing CI. Can Robin fix that? It's most likely a problem on your side with how you've configured the toolchain. I don't think this is somethign Robin can fix for you. jeff

Re: Re: [PATCH] RISC-V/testsuite: Fix zvfh tests.

2023-11-09 Thread juzhe.zh...@rivai.ai
How to fix it ? I am pretty noob on testing CI. Can Robin fix that? juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-11-10 09:11 To: juzhe.zh...@rivai.ai; Robin Dapp; gcc-patches; palmer; kito.cheng Subject: Re: [PATCH] RISC-V/testsuite: Fix zvfh tests. On 11/9/23 18:09,

Re: [PATCH] RISC-V/testsuite: Fix zvfh tests.

2023-11-09 Thread Jeff Law
On 11/9/23 18:09, juzhe.zh...@rivai.ai wrote: I am already using master branch. The FAIL is: xgcc: fatal error: Cannot find suitable multilib set for '-march=rv64imafdcv_zicsr_zifencei_zfhmin_zve32f_zve32x_zve64d_zve64f_zve64x_zvfh_zvl128b_zvl32b_zvl64b'/'-mabi=lp64d' That's an multilib

Re: Re: [PATCH] RISC-V/testsuite: Fix zvfh tests.

2023-11-09 Thread juzhe.zh...@rivai.ai
I am already using master branch. The FAIL is: xgcc: fatal error: Cannot find suitable multilib set for '-march=rv64imafdcv_zicsr_zifencei_zfhmin_zve32f_zve32x_zve64d_zve64f_zve64x_zvfh_zvl128b_zvl32b_zvl64b'/'-mabi=lp64d' I will update binutils again today to see whether it can fix the issue.

Re: [PATCH 2/3] RISC-V: Update XCValu constraints to match other vendors

2023-11-09 Thread Jeff Law
On 11/8/23 04:09, Mary Bennett wrote: gcc/ChangeLog: * config/riscv/constraints.md: CVP2 -> CV_alu_pow2. * config/riscv/corev.md: Likewise. Bikeshedding alert... Usually we keep constraint names pretty small. It helps when you've got patterns that may have many constraints.

Re: Re: [PATCH] RISC-V: Move cond_copysign from combine pattern to autovec pattern

2023-11-09 Thread juzhe.zh...@rivai.ai
Yes. No regression. Committed. juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-11-10 07:56 To: Juzhe-Zhong; gcc-patches CC: kito.cheng; kito.cheng; rdapp.gcc Subject: Re: [PATCH] RISC-V: Move cond_copysign from combine pattern to autovec pattern On 11/9/23 16:33, Juzhe-Zhong wrote: >

[Bug c/112432] Internal-fn: The [i|l|ll]rint family don't support FLOATN

2023-11-09 Thread pan2.li at intel dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112432 Li Pan changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

RE: [PATCH v1] Internal-fn: Add FLOATN support for l/ll round and rint [PR/112432]

2023-11-09 Thread Li, Pan2
Committed, thanks Richard. Pan -Original Message- From: Richard Biener Sent: Thursday, November 9, 2023 11:12 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang Subject: Re: [PATCH v1] Internal-fn: Add FLOATN support for l/ll

[Bug c/112432] Internal-fn: The [i|l|ll]rint family don't support FLOATN

2023-11-09 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112432 --- Comment #6 from CVS Commits --- The master branch has been updated by Pan Li : https://gcc.gnu.org/g:907603d4b117e82dbbde2d58a04e33f3021908e7 commit r14-5307-g907603d4b117e82dbbde2d58a04e33f3021908e7 Author: Pan Li Date: Thu Nov 9

[committed] Improve single bit zero extraction on H8.

2023-11-09 Thread Jeff Law
When zero extracting a single bit bitfield from bits 16..31 on the H8 we currently generate some pretty bad code. The fundamental issue is we can't shift efficiently and there's no trivial way to extract a single bit out of the high half word of an SImode value. What usually happens is we

Re: [PATCH] c++: fix tf_decltype manipulation for COMPOUND_EXPR

2023-11-09 Thread Jason Merrill
On 11/7/23 10:08, Patrick Palka wrote: bootstrapped and regtested on x86_64-pc-linxu-gnu, does this look OK for trunk? -- >8 -- In the COMPOUND_EXPR case of tsubst_expr, we were redundantly clearing the tf_decltype flag when substituting the LHS and also neglecting to propagate it when

Re: [PATCH] c++: decltype of capture proxy [PR79378, PR96917]

2023-11-09 Thread Jason Merrill
On 11/7/23 14:52, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? OK. -- >8 -- We usually don't see capture proxies in finish_decltype_type because process_outer_var_ref is a no-op inside an unevaluated context and so a use of a capture

Re: [PATCH] libgccjit: Add ability to get CPU features

2023-11-09 Thread Antoni Boucher
Hi. See answers below. On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: > On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote: > > Hi. > > This patch adds support for getting the CPU features in libgccjit > > (bug > > 112466) > > > > There's a TODO in the test: > > I'm not sure how to

Re: [PATCH] c++: decltype of (by-value captured reference) [PR79620]

2023-11-09 Thread Jason Merrill
On 11/7/23 14:52, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- The capture decltype handling in finish_decltype_type wasn't looking through implicit INDIRECT_REF (added by convert_from_reference), which caused us to incorrectly

[Bug target/112443] [12/13/14 Regression] Misoptimization of _mm256_blendv_epi8 intrinsic on avx512bw+avx512vl

2023-11-09 Thread crazylht at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112443 --- Comment #7 from Hongtao.liu --- Should be Fixed in GCC14/GCC13/GCC12

Re: [PATCH] c++: non-dependent .* folding [PR112427]

2023-11-09 Thread Jason Merrill
On 11/8/23 16:59, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Here when building up the non-dependent .* expression, we crash from fold_convert on 'b.a' due to this (templated) COMPONENT_REF having an IDENTIFIER_NODE instead of

[Bug target/112443] [12/13/14 Regression] Misoptimization of _mm256_blendv_epi8 intrinsic on avx512bw+avx512vl

2023-11-09 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112443 --- Comment #6 from CVS Commits --- The releases/gcc-12 branch has been updated by hongtao Liu : https://gcc.gnu.org/g:1808ebfd8164cc90629b7308af3ef2b6fa965453 commit r12-9967-g1808ebfd8164cc90629b7308af3ef2b6fa965453 Author: liuhongt Date:

[Bug target/112443] [12/13/14 Regression] Misoptimization of _mm256_blendv_epi8 intrinsic on avx512bw+avx512vl

2023-11-09 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112443 --- Comment #5 from CVS Commits --- The releases/gcc-13 branch has been updated by hongtao Liu : https://gcc.gnu.org/g:5437160f4e205f991c829661f221448a97bef2d3 commit r13-8035-g5437160f4e205f991c829661f221448a97bef2d3 Author: liuhongt Date:

[Bug target/112443] [12/13/14 Regression] Misoptimization of _mm256_blendv_epi8 intrinsic on avx512bw+avx512vl

2023-11-09 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112443 --- Comment #4 from CVS Commits --- The master branch has been updated by hongtao Liu : https://gcc.gnu.org/g:9a0cc04b9c9b02426762892b88efc5c44ba546bd commit r14-5305-g9a0cc04b9c9b02426762892b88efc5c44ba546bd Author: liuhongt Date: Thu Nov

[COMMITTED] bpf: fix pseudo-c asm emitted for *mulsidi3_zeroextend

2023-11-09 Thread Jose E. Marchesi
This patch fixes the pseudo-c BPF assembly syntax used for *mulsidi3_zeroextend, which was being emitted as: rN *= wM instead of the proper way to denote a mul32 in pseudo-C syntax: wN *= wM Includes test. Tested in bpf-unknown-none-gcc target in x86_64-linux-gnu host. gcc/ChangeLog:

Re: [PATCH] c++: fix parsing with auto(x) [PR112410]

2023-11-09 Thread Jason Merrill
On 11/9/23 14:58, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- Here we are wrongly parsing int y(auto(42)); which uses the C++23 cast-to-prvalue feature, and initializes y to 42. However, we were treating the auto as an implicit template

Re: [PATCH] RISC-V/testsuite: Fix zvfh tests.

2023-11-09 Thread Jeff Law
On 11/9/23 15:43, 钟居哲 wrote: Hi. Robin. [ ... ] You may need a development version of binutils to get the zfh/zvfh support and unreleased patches to get zfb/zvfb support. Probably the easiest thing to do would be to look in the gcc.log file at those failures and see what the excess

Re: [PATCH] RISC-V: Move cond_copysign from combine pattern to autovec pattern

2023-11-09 Thread Jeff Law
On 11/9/23 16:33, Juzhe-Zhong wrote: Since cond_copysign has been support into match.pd (middle-end). We don't need to support conditional copysign by RTL combine pass. Instead, we can support it by direct explicit cond_copysign optab. conditional copysign tests are already available in the

[COMMITED] bpf: testsuite: fix expected regexp in gcc.target/bpf/ldxdw.c

2023-11-09 Thread Jose E. Marchesi
gcc/testsuite/ChangeLog: * gcc.target/bpf/ldxdw.c: Fix regexp with expected result. --- gcc/testsuite/gcc.target/bpf/ldxdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/bpf/ldxdw.c b/gcc/testsuite/gcc.target/bpf/ldxdw.c index

Re: [PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathan Sidwell
On 11/9/23 18:29, Nathaniel Shead wrote: On Thu, Nov 09, 2023 at 05:57:39PM -0500, Nathan Sidwell wrote: On 11/9/23 04:55, Nathaniel Shead wrote: I'm not sure if this is just papering over a general issue of clones not being exported/imported, or if this is just an exception to the general

Re: [PATCH v4 2/2] c++: Diagnostics for P0847R7 (Deducing this) [PR102609]

2023-11-09 Thread Jason Merrill
On 11/5/23 10:06, waffl3x wrote: I had wanted to write about some of my frustrations with trying to write a test for virtual specifiers and errors/warnings for shadowing/overloading virtual functions, but I am a bit too tired at the moment and I don't want to delay getting this up for another

[Bug rtl-optimization/112415] [14 regression] Python 3.11 miscompiled on HPPA with new RTL fold mem offset pass, since r14-4664-g04c9cf5c786b94

2023-11-09 Thread danglin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112415 --- Comment #33 from John David Anglin --- Created attachment 56549 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56549=edit ira and reload dumps for compiler_call_helper The incorrect code for insn 246 in compiler_call_helper appears

[PATCH] RISC-V: Move cond_copysign from combine pattern to autovec pattern

2023-11-09 Thread Juzhe-Zhong
Since cond_copysign has been support into match.pd (middle-end). We don't need to support conditional copysign by RTL combine pass. Instead, we can support it by direct explicit cond_copysign optab. conditional copysign tests are already available in the testsuite. No need to add tests.

Re: [PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathaniel Shead
On Thu, Nov 09, 2023 at 05:57:39PM -0500, Nathan Sidwell wrote: > On 11/9/23 04:55, Nathaniel Shead wrote: > > I'm not sure if this is just papering over a general issue of clones not > > being > > exported/imported, or if this is just an exception to the general case of > > clones being able to

Re: [PATCH 1/2] libstdc++: declare std::allocator in !HOSTED as an extension

2023-11-09 Thread Arsen Arsenović
Jonathan Wakely writes: > OK Thanks, pushed (tests did pass). Have a lovely night. -- Arsen Arsenović signature.asc Description: PGP signature

Re: [PATCH 1/2] libstdc++: declare std::allocator in !HOSTED as an extension

2023-11-09 Thread Jonathan Wakely
On Thu, 9 Nov 2023 at 19:32, Arsen Arsenović wrote: > > This allows us to add features to freestanding which allow specifying > non-default allocators (generators, collections, ...) without having to > modify them. > > libstdc++-v3/ChangeLog: > > * include/bits/memoryfwd.h: Remove HOSTED

Re: [PATCH] libgccjit: Add ability to get CPU features

2023-11-09 Thread David Malcolm
On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote: > Hi. > This patch adds support for getting the CPU features in libgccjit > (bug > 112466) > > There's a TODO in the test: > I'm not sure how to test that gcc_jit_target_info_arch returns the > correct value since it is dependant on the

RFC (V3) the proposal to resolve the missing dependency issue for counted_by attribute

2023-11-09 Thread Qing Zhao
Hi, I added the BPF related issue and the solution in the section Appendix 4 Known issues. No change to other parts. Send this V3 for record purpose. Qing Represent the missing dependence for the "counted_by" attribute and its

Re: [PATCH] c++/modules: handle templates in exported using-declarations [PR106849]

2023-11-09 Thread Nathan Sidwell
On 11/9/23 16:06, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu. -- >8 -- A TEMPLATE_DECL does not have module attachment flags associated with it, so this patch extracts the result from the template to read the flags from there instead. oh yeah. my original plan

Re: [PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathan Sidwell
On 11/9/23 04:55, Nathaniel Shead wrote: I'm not sure if this is just papering over a general issue of clones not being exported/imported, or if this is just an exception to the general case of clones being able to be freely regenerated with no other issues. Alternatively, would it be better to

yyyÿyy

2023-11-09 Thread Kelly Coleman via Gcc
Sent from my iPhone

[Bug tree-optimization/112469] [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944

2023-11-09 Thread juzhe.zhong at rivai dot ai via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112469 --- Comment #4 from JuzheZhong --- vector(8) int vect_prephitmp_11.23; is gimplified from .COND_NEG (_55, vect__29.18_40, { -1, -1, -1, -1, -1, -1, -1, -1 }) into vect_prephitmp_11.23_50 to { 4294967295, 4294967294, 4294967293,

[Bug tree-optimization/112469] [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112469 --- Comment #3 from Andrew Pinski --- I wonder if there is a type issue here ...

[Bug tree-optimization/112469] [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944

2023-11-09 Thread juzhe.zhong at rivai dot ai via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112469 --- Comment #2 from JuzheZhong --- (In reply to Andrew Pinski from comment #1) > I don't see anything wrong with that patch but just exposing a latent bug in > SCCVN/FRE: > > ``` > Value numbering stmt = vect_iftmp.22_46 = VEC_COND_EXPR 1, 1,

[Bug tree-optimization/112469] [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112469 Andrew Pinski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0

gcc-11-20231109 is now available

2023-11-09 Thread GCC Administrator via Gcc
Snapshot gcc-11-20231109 is now available on https://gcc.gnu.org/pub/gcc/snapshots/11-20231109/ and on various mirrors, see http://gcc.gnu.org/mirrors.html for details. This snapshot has been generated from the GCC 11 git branch with the following options: git://gcc.gnu.org/git/gcc.git branch

[Bug tree-optimization/112469] [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944

2023-11-09 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112469 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |14.0 Keywords|

[Bug tree-optimization/112469] New: [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944

2023-11-09 Thread patrick at rivosinc dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112469 Bug ID: 112469 Summary: [14 Regression] ICE: eliminate_stmt, at tree-ssa-sccvn.cc:6944 Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal

  1   2   3   4   >