https://gcc.gnu.org/g:a4716752fbb9eb7a06d408c98de42a2aec944713

commit a4716752fbb9eb7a06d408c98de42a2aec944713
Author: Owen Avery <powerboat9.ga...@gmail.com>
Date:   Mon Feb 12 18:20:19 2024 -0500

    Fix lookup of TuplePattern sub-pattern types
    
    gcc/rust/ChangeLog:
    
            * backend/rust-compile-pattern.cc
            (CompilePatternLet::visit):
            Lookup type of sub-pattern, not tuple pattern itself.
    
    gcc/testsuite/ChangeLog:
    
            * rust/compile/issue-2847-b.rs: New test.
    
    Signed-off-by: Owen Avery <powerboat9.ga...@gmail.com>

Diff:
---
 gcc/rust/backend/rust-compile-pattern.cc   | 12 ++++++------
 gcc/testsuite/rust/compile/issue-2847-b.rs |  4 ++++
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/gcc/rust/backend/rust-compile-pattern.cc 
b/gcc/rust/backend/rust-compile-pattern.cc
index 810cf6bff64c..df60fc01ce54 100644
--- a/gcc/rust/backend/rust-compile-pattern.cc
+++ b/gcc/rust/backend/rust-compile-pattern.cc
@@ -678,8 +678,8 @@ CompilePatternLet::visit (HIR::TuplePattern &pattern)
        for (auto &sub : items_lower)
          {
            TyTy::BaseType *ty_sub = nullptr;
-           HirId pattern_id = pattern.get_mappings ().get_hirid ();
-           bool ok = ctx->get_tyctx ()->lookup_type (pattern_id, &ty_sub);
+           HirId sub_id = sub->get_mappings ().get_hirid ();
+           bool ok = ctx->get_tyctx ()->lookup_type (sub_id, &ty_sub);
            rust_assert (ok);
 
            tree sub_init
@@ -697,8 +697,8 @@ CompilePatternLet::visit (HIR::TuplePattern &pattern)
        for (auto &sub : items_upper)
          {
            TyTy::BaseType *ty_sub = nullptr;
-           HirId pattern_id = pattern.get_mappings ().get_hirid ();
-           bool ok = ctx->get_tyctx ()->lookup_type (pattern_id, &ty_sub);
+           HirId sub_id = sub->get_mappings ().get_hirid ();
+           bool ok = ctx->get_tyctx ()->lookup_type (sub_id, &ty_sub);
            rust_assert (ok);
 
            tree sub_init
@@ -719,8 +719,8 @@ CompilePatternLet::visit (HIR::TuplePattern &pattern)
        for (auto &sub : items.get_patterns ())
          {
            TyTy::BaseType *ty_sub = nullptr;
-           HirId pattern_id = pattern.get_mappings ().get_hirid ();
-           bool ok = ctx->get_tyctx ()->lookup_type (pattern_id, &ty_sub);
+           HirId sub_id = sub->get_mappings ().get_hirid ();
+           bool ok = ctx->get_tyctx ()->lookup_type (sub_id, &ty_sub);
            rust_assert (ok);
 
            tree sub_init
diff --git a/gcc/testsuite/rust/compile/issue-2847-b.rs 
b/gcc/testsuite/rust/compile/issue-2847-b.rs
new file mode 100644
index 000000000000..ab2614210fca
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-2847-b.rs
@@ -0,0 +1,4 @@
+pub fn test() -> i32 {
+    let (a, _) = (1, 2);
+    a
+}

Reply via email to