[PATCH 4.8] libstdc++ pretty-printers: Backport Python 3 support from mainline

2014-08-13 Thread Samuel Bronson
This was a bit trickier than the backport to 4.9: but the tests pass, except this one: UNSUPPORTED: libstdc++-prettyprinters/shared_ptr.cc This is a bit puzzling, but seems unrelated to my change. 2014-08-13 Samuel Bronson naes...@gmail.com Backport r212453 from trunk

[c++-concepts] variable concepts

2014-08-13 Thread Braden Obrzut
This patch adds support for variable concepts. There is a known issue that prevents concept variables from having requires expressions that have parameters. This issue is not within the scope of this patch as it affects adhoc requires expressions as well. 2014-08-13 Braden Obrzut

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-13 Thread Bin.Cheng
On Sun, Aug 10, 2014 at 2:00 AM, Ulrich Drepper drep...@gmail.com wrote: On Sat, Aug 9, 2014 at 1:40 PM, Marc Glisse marc.gli...@inria.fr wrote: __x = result_type(2.0) * __aurng() - 1.0; You're right, we of course need the negatives as well. Assuming the 2 coordinates are

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-13 Thread Bin.Cheng
On Wed, Aug 13, 2014 at 3:36 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Sun, Aug 10, 2014 at 2:00 AM, Ulrich Drepper drep...@gmail.com wrote: On Sat, Aug 9, 2014 at 1:40 PM, Marc Glisse marc.gli...@inria.fr wrote: __x = result_type(2.0) * __aurng() - 1.0; You're right, we

Re: [PATCH, ARM] Keep constants in register when expanding

2014-08-13 Thread Zhenqiang Chen
On 12 August 2014 17:24, Richard Earnshaw rearn...@arm.com wrote: On 05/08/14 10:31, Zhenqiang Chen wrote: Hi, For some large constants, ARM will split them during expanding, which makes impossible to hoist them out the loop or shared by different references (refer the test case in the

Re: [PATCH] cygwin: fix --tsaware, add --large-address-aware

2014-08-13 Thread Kai Tietz
2014-08-13 7:14 GMT+02:00 Yaakov Selkowitz yselk...@redhat.com: This patch fixes two issues with LINK_SPEC on Cygwin targets: 1) --tsaware makes sense only for EXEs, not DLLs. 2) Under WoW64 (32-bit Cygwin on 64-bit Windows), Cygwin applications can access up to 4 GiB of address space (for

RE: [PATCH, ARM] Fix incorrect alignment of small values in minipool

2014-08-13 Thread Thomas Preud'homme
From: Richard Earnshaw Sent: Monday, August 11, 2014 4:54 PM I think this is the wrong place for this sort of fix up. HFmode values are fixed up in the consttable_4 pattern and it looks wrong to be that HImode values are then fixed up in a different place. We should be consistent and do

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-13 Thread Roman Gareev
If I’m not mistaken all tree nodes, which have pointer type, can be divided into two groups: the type is a is a pointer to data member (TYPE_PTRMEM_P is true for it), the type is a pointer type, and the pointee is not a data member (TYPE_PTR_P is true for it). I think that we’re interested in

Re: Fix libgomp crash without TLS (PR42616)

2014-08-13 Thread Varvara Rainchik
*Ping* Thanks, Varvara 2014-08-06 14:05 GMT+04:00 Varvara Rainchik varvara.s.rainc...@gmail.com: Hi, The issue was firstly observed on NDK gcc since TLS is not supported in Android bionic. I also see the same failure on gcc configured for linux with –disable-tls, libgomp make check log:

Re: [PATCH i386 AVX512] [7/n] Extend mask logic.

2014-08-13 Thread Kirill Yukhin
Hello Uroš, On 12 Aug 20:06, Uros Bizjak wrote: Please leave TARGET_AVX512F in the insn constraint, it shortcuts the pattern recognition for non AVX512F targets. Sure, removed (will bootstrap, regtest before check in). (set_attr prefix vex)]) @@ -7580,10 +7607,10 @@ }) The

RE: [PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-13 Thread Thomas Preud'homme
From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Monday, August 11, 2014 8:29 PM That's now extra compares (the operand_equal_p check now does a check that can be derived transitively). So - ok with the operand_equal_p cehck removed. Also see if this can be backported. I

Re: [PATCH AArch64 1/3] Don't disparage add/sub in SIMD registers

2014-08-13 Thread James Greenhalgh
On Tue, Aug 12, 2014 at 04:53:38PM +0100, pins...@gmail.com wrote: On Aug 12, 2014, at 7:40 AM, Alan Lawrence alan.lawre...@arm.com wrote: (It is no more expensive.) Yes on some processors it could be. Haven't we been here before [1]? This disparaging mechanism is still not going

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-13 Thread Paolo Carlini
Ulrich-- On 08/13/2014 09:36 AM, Bin.Cheng wrote: On Sun, Aug 10, 2014 at 2:00 AM, Ulrich Drepper drep...@gmail.com wrote: On Sat, Aug 9, 2014 at 1:40 PM, Marc Glisse marc.gli...@inria.fr wrote: __x = result_type(2.0) * __aurng() - 1.0; You're right, we of course need the

Re: [PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-13 Thread Jakub Jelinek
On Wed, Aug 13, 2014 at 04:21:24PM +0800, Thomas Preud'homme wrote: From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Monday, August 11, 2014 8:29 PM That's now extra compares (the operand_equal_p check now does a check that can be derived transitively). So - ok with

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-13 Thread Tobias Grosser
On 13/08/2014 16:07, Roman Gareev wrote: If I’m not mistaken all tree nodes, which have pointer type, can be divided into two groups: the type is a is a pointer to data member (TYPE_PTRMEM_P is true for it), the type is a pointer type, and the pointee is not a data member (TYPE_PTR_P is true

Re: PR tree-optimization/52904 testcase

2014-08-13 Thread Richard Biener
On Tue, Aug 12, 2014 at 2:34 PM, Kugan kugan.vivekanandara...@linaro.org wrote: Did you verify the testcase fails before the revision that fixed it? Esp. the placement of the dg-bogus looks bogus to me. I tried it on Linaro 4.9 (It should be the same in fsf gcc 4.9 branch) and the test cases

Re: [PATCH] Fix for PR62037

2014-08-13 Thread Richard Biener
On Tue, Aug 12, 2014 at 6:40 PM, Felix Yang fei.yang0...@gmail.com wrote: Hi Richard, I find that you missed the testcase with when committing the patch. I don't think so. GCC 4.8 4.9 branch also has the same issue, may be we need to fix for them too? Yeah, I'll backport it.

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-13 Thread Richard Biener
On Tue, Aug 12, 2014 at 10:40 PM, Jeff Law l...@redhat.com wrote: On 08/12/14 14:23, Richard Biener wrote: On August 12, 2014 8:31:16 PM CEST, Jeff Law l...@redhat.com wrote: On 08/12/14 11:46, Steve Ellcey wrote: After talking to Jeff Law at the GCC Cauldron I have updated my switch

Re: [patch] No allocation for empty unordered containers

2014-08-13 Thread Jonathan Wakely
On 12/08/14 21:53 +0200, François Dumont wrote: On 12/08/2014 21:39, Marc Glisse wrote: On Tue, 12 Aug 2014, François Dumont wrote: Based on your feedbacks I think we should stay with just targeting good QoI by not allocating on default construction. As I said the noexcept qualification

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-13 Thread Richard Biener
On Wed, Aug 13, 2014 at 4:54 AM, Bin.Cheng amker.ch...@gmail.com wrote: On Wed, Aug 13, 2014 at 4:40 AM, Jeff Law l...@redhat.com wrote: On 08/12/14 14:23, Richard Biener wrote: On August 12, 2014 8:31:16 PM CEST, Jeff Law l...@redhat.com wrote: On 08/12/14 11:46, Steve Ellcey wrote: After

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-13 Thread Richard Biener
On Wed, Aug 13, 2014 at 10:07 AM, Roman Gareev gareevro...@gmail.com wrote: If I’m not mistaken all tree nodes, which have pointer type, can be divided into two groups: the type is a is a pointer to data member (TYPE_PTRMEM_P is true for it), the type is a pointer type, and the pointee is

Re: [PATCH 005/236] Introduce as_a_nullable

2014-08-13 Thread Martin Jambor
Hi, On Wed, Aug 06, 2014 at 01:19:44PM -0400, David Malcolm wrote: In many circumstances, is_a_helper T::test assumes that the pointer is non-NULL, but sometimes you have a pointer of type T that can be NULL. Earlier versions of this patch kit made numerous uses of the ternary operator to

Re: [PATCH 005/236] Introduce as_a_nullable

2014-08-13 Thread Richard Biener
On Wed, Aug 13, 2014 at 12:01 PM, Martin Jambor mjam...@suse.cz wrote: Hi, On Wed, Aug 06, 2014 at 01:19:44PM -0400, David Malcolm wrote: In many circumstances, is_a_helper T::test assumes that the pointer is non-NULL, but sometimes you have a pointer of type T that can be NULL. Earlier

[PATCH] Fix for PR/62089 (enable missing Asan checks)

2014-08-13 Thread Yury Gribov
Hi all, GCC Asan may currently fail to generate checks for accesses to wide structure fields due to unfortunate intermix with code that handles bitfields. This patch fixes it and also adds a bunch of tests. Bootstrapped, regtested and asan-bootstrapped on x64. Ok to commit? -Y commit

Re: [GSoC][match-and-simplify] add few constant-folding tests

2014-08-13 Thread Richard Biener
On Tue, Aug 12, 2014 at 10:08 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: [gcc/testsuite/gcc.dg/tree-ssa] * match-constant-folding.c: New test-case. Thanks - applied. Richard. Thanks, Prathamesh

Re: [PATCH] Fix for PR/62089 (enable missing Asan checks)

2014-08-13 Thread Jakub Jelinek
On Wed, Aug 13, 2014 at 02:09:33PM +0400, Yury Gribov wrote: --- a/gcc/asan.c +++ b/gcc/asan.c @@ -1690,9 +1690,7 @@ instrument_derefs (gimple_stmt_iterator *iter, tree t, int volatilep = 0, unsignedp = 0; tree inner = get_inner_reference (t, bitsize, bitpos, offset,

Re: [PATCH] Fix some typos

2014-08-13 Thread Sylvestre Ledru
On 12/08/2014 19:38, Marc Glisse wrote: On Tue, 12 Aug 2014, Sylvestre Ledru wrote: The patch fixes some typos found by Lintian, the Debian static analyzer. Did you check them yourself? Sure (but I am not a native English speaker). We end up with these information which doesn't seem correct

Re: [PATCH] Fix some typos

2014-08-13 Thread Paolo Carlini
Hi, On 08/12/2014 07:29 PM, Sylvestre Ledru wrote: Hello The patch fixes some typos found by Lintian, the Debian static analyzer. (it is mainly the opportunity to test my commit permissions). Thanks, Sylvestre libstdc++-v3/ChangeLog: 2014-08-12 Sylvestre Ledru sylves...@debian.org

Re: [PATCH AArch64 3/3] Fix XOR_one_cmpl pattern; add SIMD-reg variants for BIC,ORN,EON

2014-08-13 Thread Alan Lawrence
So my reasoning was that the alternative is likely to be more expensive *on all cores*, as it is split to two instructions, whereas add/sub could be more expensive for *some* processors. But yes I can see the argument, by my own logic and James Greenhalgh's, for removing the '?': it still

Re: [PATCH] Fix some typos

2014-08-13 Thread Marc Glisse
On Wed, 13 Aug 2014, Sylvestre Ledru wrote: On 12/08/2014 19:38, Marc Glisse wrote: On Tue, 12 Aug 2014, Sylvestre Ledru wrote: The patch fixes some typos found by Lintian, the Debian static analyzer. Did you check them yourself? Sure (but I am not a native English speaker). I am not a

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-13 Thread Paolo Carlini
... fixed with the below. Thanks, Paolo. // 2014-08-13 Paolo Carlini paolo.carl...@oracle.com PR libstdc++/62118 * include/ext/random.tcc (uniform_on_sphere_helper2, _RealType:: operator()): Use std::hypot only when _GLIBCXX_USE_C99_MATH_TR1.

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-13 Thread Marc Glisse
On Wed, 13 Aug 2014, Paolo Carlini wrote: ... fixed with the below. Could you please use __sq instead of recomputing it? -- Marc Glisse

[wwwdocs] Update GCC5 changes.html

2014-08-13 Thread Marek Polacek
I've put together a few lines describing what I (except -fsanitize=alignment) implemented for GCC 5. It's the file wwwdocs/htdocs/gcc-5/changes.html. Ok? --- changes.html.mp 2014-08-13 12:21:57.059610612 +0200 +++ changes.html2014-08-13 13:22:00.683597815 +0200 @@ -16,11 +16,53 @@

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-13 Thread Paolo Carlini
On 08/13/2014 01:32 PM, Marc Glisse wrote: On Wed, 13 Aug 2014, Paolo Carlini wrote: ... fixed with the below. Could you please use __sq instead of recomputing it? Patch preapproved, thanks! Paolo.

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-13 Thread Roman Gareev
- I assume you verified this passes all graphite tests. Yes, I’ve found out that there is no regression. - Please add a brief comment in the source code regarding why we do not want to detect such SCoPs. Would you add anything to the following comment: “We disable the handling of

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-13 Thread Roman Gareev
Thank you for the comment! 2014-08-13 15:55 GMT+06:00 Richard Biener richard.guent...@gmail.com: On Wed, Aug 13, 2014 at 10:07 AM, Roman Gareev gareevro...@gmail.com wrote: If I’m not mistaken all tree nodes, which have pointer type, can be divided into two groups: the type is a is a pointer

Re: [PATCH 4.8] libstdc++ pretty-printers: Backport Python 3 support from mainline

2014-08-13 Thread Jonathan Wakely
On 13/08/14 02:02 -0400, Samuel Bronson wrote: This was a bit trickier than the backport to 4.9: but the tests pass, except this one: UNSUPPORTED: libstdc++-prettyprinters/shared_ptr.cc This is a bit puzzling, but seems unrelated to my change. Yes, I see that too without your change

[PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Felix Yang
Hi all, The qsort library function may have different behavior on different hosts (say Linux vs MinGW). We may have different sorting results with qsort when there are elements with the same key value. GCC uses qsort a lot. And the output of certain optimizations, such as IRA, relies

Re: [PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-13 Thread Kirill Yukhin
Hello Uroš, On 12 Aug 20:16, Uros Bizjak wrote: In a couple of places, MODE_SIZE checks are changed to GET_MODE_SIZE (GET_MODE (operands[0])) and in a similar way, MODEmode checks were changed to GET_MODE (operands[0]). The previous checks are more efficient and are preferred. Is there a

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Jakub Jelinek
On Wed, Aug 13, 2014 at 08:12:03PM +0800, Felix Yang wrote: The qsort library function may have different behavior on different hosts (say Linux vs MinGW). We may have different sorting results with qsort when there are elements with the same key value. GCC uses qsort a lot. And

[PATCH][www] Document versioning scheme for GCC 5 and up

2014-08-13 Thread Richard Biener
The release management team has aggreed to go forward with the change to bump the major with each further release. The following aims to document the details of the versioning scheme we intend to use for GCC 5 and up. Summary in non-html: Development of GCC 5 will happen as GCC 5.0.0

[PATCH] Fix wrong refactoring in cgraph_node::function_symbol

2014-08-13 Thread Ilya Enkovich
Hi, This patch is to fix wrong refactoring for cgraph_node::function_symbol introduced by this patch: https://gcc.gnu.org/ml/gcc-cvs/2014-07/msg00805.html. Here is how function was refactored: -cgraph_function_node (struct cgraph_node *node, enum availability *availability) +cgraph_node *

Re: [c++-concepts] variable concepts

2014-08-13 Thread Andrew Sutton
Committed. Andrew Sutton On Wed, Aug 13, 2014 at 3:24 AM, Braden Obrzut ad...@maniacsvault.net wrote: This patch adds support for variable concepts. There is a known issue that prevents concept variables from having requires expressions that have parameters. This issue is not within the

Re: [PATCH] Fix for PR62037

2014-08-13 Thread Felix Yang
Hi Richard, Yeah, the testcase is there. Sorry for my mistake. Thank you for back-porting this patch to 4.8 4.9 branch. Cheers, Felix On Wed, Aug 13, 2014 at 5:30 PM, Richard Biener richard.guent...@gmail.com wrote: On Tue, Aug 12, 2014 at 6:40 PM, Felix Yang fei.yang0...@gmail.com

Re: [PATCH, ARM] Set max_insns_skipped to MAX_INSN_PER_IT_BLOCK when optimize_size for THUMB2

2014-08-13 Thread Richard Earnshaw
On 25/02/14 09:34, Zhenqiang Chen wrote: Hi, Current value for max_insns_skipped is 6. For THUMB2, it needs 2 (IF-THEN) or 3 (IF-THEN-ELSE) IT blocks to hold all the instructions. The overhead of IT is 4 or 6 BYTES. If we do not generate IT blocks, for IF-THEN, the overhead of conditional

[PATCH] Fix PR62077

2014-08-13 Thread Richard Biener
The following fixes the LTO bootstrap miscompares on the branches. They happen because type_hash_canon can end up returning different types (a main variant or a variant type) dependent on whether we garbage collected before or not. The patch makes us never return a variant type from

[PATCH] PR61878

2014-08-13 Thread Ilya Tocar
Hi, This patch adds missing intrinsics and tests for them. Ok for trunk? gcc/ChangeLog: 2014-08-13 Ilya Tocar ilya.to...@intel.com * config/i386/avx512fintrin.h (_mm512_mask_cmpge_epi32_mask): New. (_mm512_mask_cmpge_epu32_mask): Ditto. (_mm512_cmpge_epu32_mask):

Re: [PATCH][www] Document versioning scheme for GCC 5 and up

2014-08-13 Thread Jakub Jelinek
On Wed, Aug 13, 2014 at 02:21:29PM +0200, Richard Biener wrote: The release management team has aggreed to go forward with the change to bump the major with each further release. The following aims to document the details of the versioning scheme we intend to use for GCC 5 and up.

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Felix Yang
Hi Jakub, I did tried to use the glibc qsort. I compared the source of the two versions. I found that the BSD one is more self-contained and easy for integration with libiberty. That's why the BSD one is preferred. And we already have several BSD functions there in libiberty

Re: [PATCH] Fix wrong refactoring in cgraph_node::function_symbol

2014-08-13 Thread Richard Biener
On Wed, Aug 13, 2014 at 2:25 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch is to fix wrong refactoring for cgraph_node::function_symbol introduced by this patch: https://gcc.gnu.org/ml/gcc-cvs/2014-07/msg00805.html. Here is how function was refactored:

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Jakub Jelinek
On Wed, Aug 13, 2014 at 08:48:52PM +0800, Felix Yang wrote: I did tried to use the glibc qsort. I compared the source of the two versions. I found that the BSD one is more self-contained and easy for integration with libiberty. Being more self-contained is not what we care about, the

Re: [PATCH][www] Document versioning scheme for GCC 5 and up

2014-08-13 Thread Richard Biener
On Wed, 13 Aug 2014, Jakub Jelinek wrote: On Wed, Aug 13, 2014 at 02:21:29PM +0200, Richard Biener wrote: The release management team has aggreed to go forward with the change to bump the major with each further release. The following aims to document the details of the versioning

Re: [PATCH] Fix wrong refactoring in cgraph_node::function_symbol

2014-08-13 Thread Ilya Enkovich
2014-08-13 16:48 GMT+04:00 Richard Biener richard.guent...@gmail.com: On Wed, Aug 13, 2014 at 2:25 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch is to fix wrong refactoring for cgraph_node::function_symbol introduced by this patch:

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Felix Yang
Hi Jakub, I got it. I will update the patch after I finished integrating the GLIBC qsort with libiberty. Cheers, Felix On Wed, Aug 13, 2014 at 8:55 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Aug 13, 2014 at 08:48:52PM +0800, Felix Yang wrote: I did tried to use the glibc qsort.

Re: [PATCH] PR61878

2014-08-13 Thread Uros Bizjak
On Wed, Aug 13, 2014 at 2:34 PM, Ilya Tocar tocarip.in...@gmail.com wrote: This patch adds missing intrinsics and tests for them. Ok for trunk? gcc/ChangeLog: 2014-08-13 Ilya Tocar ilya.to...@intel.com * config/i386/avx512fintrin.h (_mm512_mask_cmpge_epi32_mask): New.

Re: [PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-13 Thread Uros Bizjak
On Wed, Aug 13, 2014 at 2:14 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: In a couple of places, MODE_SIZE checks are changed to GET_MODE_SIZE (GET_MODE (operands[0])) and in a similar way, MODEmode checks were changed to GET_MODE (operands[0]). The previous checks are more efficient and

[C++ Patch] Remove invalid type in declaration parser error

2014-08-13 Thread Paolo Carlini
Hi, thus I have now fully tested the below. Thanks! Paolo. / /gcc/cp 2014-08-13 Paolo Carlini paolo.carl...@oracle.com * parser.c (cp_parser_init_declarator): Remove redundant check of decl_specifiers-type. /gcc/testsuite 2014-08-13 Paolo Carlini

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Jeff Law
On 08/13/14 06:12, Felix Yang wrote: Hi all, The qsort library function may have different behavior on different hosts (say Linux vs MinGW). We may have different sorting results with qsort when there are elements with the same key value. GCC uses qsort a lot. And the output of

[PATCH] Fix UB in diagnostic.c

2014-08-13 Thread Marek Polacek
This should fix an undefined behavior in diagnostics.c. Under certain circumstances, max_width is (INT_MAX - 1), and right_margin is -4 - the subtraction overflows. Changing the types to unsigned would involve changing much more code than just one cast. BTW, the diagnostics we output for the

Re: [PATCH 028/236] cfgexpand.c: Use rtx_insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * cfgexpand.c (expand_used_vars): Strengthen return type from rtx to rtx_insn *; also for local var_end_seq. (maybe_dump_rtl_for_gimple_stmt): Likewise for param since. (maybe_cleanup_end_of_block): Likewise for param

Re: [PATCH 029/236] rtl_data.x_parm_birth_insn is an insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * function.h (struct rtl_data): Strengthen field x_parm_birth_insn from rtx to rtx_insn *. * function.c (struct assign_parm_data_all): Strengthen fields first_conversion_insn and last_conversion_insn from rtx to

Re: [PATCH 031/236] emit_jump_table_data returns an rtx_jump_table_data *

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * emit-rtl.c (emit_jump_table_data): Strengthen return type from rtx to rtx_jump_table_data *. Also for local. * rtl.h (emit_jump_table_data): Likwise. OK. jeff

Re: [PATCH 005/236] Introduce as_a_nullable

2014-08-13 Thread Jeff Law
On 08/13/14 04:07, Richard Biener wrote: On Wed, Aug 13, 2014 at 12:01 PM, Martin Jambor mjam...@suse.cz wrote: Hi, On Wed, Aug 06, 2014 at 01:19:44PM -0400, David Malcolm wrote: In many circumstances, is_a_helper T::test assumes that the pointer is non-NULL, but sometimes you have a pointer

Re: [PATCH libstdc++ v3] - Add xmethods for std::vector and std::unique_ptr

2014-08-13 Thread Siva Chandra
Ping. Any update on this? On Wed, Aug 6, 2014 at 6:37 AM, Siva Chandra sivachan...@google.com wrote: On Wed, Aug 6, 2014 at 2:47 AM, Jonathan Wakely jwakely@gmail.com wrote: Some GNU/Linux distros already build GDB using Python3, so they will be unable to use these xmethods. However, I

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Felix Yang
Is this possible a Canadian build. I am afread that the qsort then is from the MinGW/Win host? Cheers, Felix On Wed, Aug 13, 2014 at 9:31 PM, Jeff Law l...@redhat.com wrote: On 08/13/14 06:12, Felix Yang wrote: Hi all, The qsort library function may have different behavior on

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Ian Lance Taylor
On Wed, Aug 13, 2014 at 6:31 AM, Jeff Law l...@redhat.com wrote: On 08/13/14 06:12, Felix Yang wrote: Hi all, The qsort library function may have different behavior on different hosts (say Linux vs MinGW). We may have different sorting results with qsort when there are elements

Re: [PATCH 000/236] Introduce rtx subclasses

2014-08-13 Thread Jeff Law
On 08/12/14 18:26, David Malcolm wrote: Essentially zero in the work-to-date. Of the 13 new subclasses of rtx, I only make major use of about half of them; here are the frequencies (as reported by grep -w in my current working copy): class rtx_def; /* ~26000 for rtx */ class

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Jeff Law
On 08/13/14 07:55, Felix Yang wrote: Is this possible a Canadian build. I am afread that the qsort then is from the MinGW/Win host? The stability of the sort is independent of the underlying qsort implementation if the comparison routine is fully specified. It's somewhat painful, but I'd

[PATCH] Fix PR62079

2014-08-13 Thread Richard Biener
It looks like RTL peep2 can leave unreachable blocks around by missing to check the currently write-only variable peep2_do_cleanup_cfg at the end and cleanup the CFG in that case. Fixed like so, bootstrap and regtest scheduled on x86_64-unknown-linux-gnu. Richard. 2014-08-13 Richard Biener

[PATCH] Fix PR62090

2014-08-13 Thread Richard Biener
The following fixes expected fallout from the move of builtins.c foldings to gimple-fold.c. Fixed by moving some more. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2014-08-13 Richard Biener rguent...@suse.de PR tree-optimization/62090 * builtins.c

[PATCH] Remove current_function_decl usage from get_polymorphic_call_info

2014-08-13 Thread Ilya Enkovich
Hi, Testing 'mpx' branch after merge with trunk I got a segfault in ipa-devirt.c. It appears that cgraph_node cloning with indirect edge causes call to get_polymorphic_call_info which uses current_function_decl. It happens in IPA pass and therefore current_function_decl is NULL which causes

Re: [PATCH] Remove current_function_decl usage from get_polymorphic_call_info

2014-08-13 Thread Richard Biener
On Wed, Aug 13, 2014 at 4:17 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, Testing 'mpx' branch after merge with trunk I got a segfault in ipa-devirt.c. It appears that cgraph_node cloning with indirect edge causes call to get_polymorphic_call_info which uses current_function_decl.

Re: [PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-13 Thread Kirill Yukhin
On 13 Aug 15:21, Uros Bizjak wrote: On Wed, Aug 13, 2014 at 2:14 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: In a couple of places, MODE_SIZE checks are changed to GET_MODE_SIZE (GET_MODE (operands[0])) and in a similar way, MODEmode checks were changed to GET_MODE (operands[0]).

Re: Patch for constexpr variable templates

2014-08-13 Thread Andrew Sutton
Oohh... I can commit to trunk? Yes, you're on the write-after-approval list in MAINTAINERS. :) True, but it's my first commit to trunk :) Incidentally, that's committed now. Andrew

Re: [PATCH] Fix PR62077

2014-08-13 Thread Richard Biener
On Wed, 13 Aug 2014, Richard Biener wrote: The following fixes the LTO bootstrap miscompares on the branches. They happen because type_hash_canon can end up returning different types (a main variant or a variant type) dependent on whether we garbage collected before or not. The patch

Re: [PATCH libstdc++ v3] - Add xmethods for std::vector and std::unique_ptr

2014-08-13 Thread Jonathan Wakely
On 13 August 2014 14:55, Siva Chandra wrote: Ping. Any update on this? No, I haven't committed it yet, but I will get round to it. On Wed, Aug 6, 2014 at 6:37 AM, Siva Chandra sivachan...@google.com wrote: On Wed, Aug 6, 2014 at 2:47 AM, Jonathan Wakely jwakely@gmail.com wrote: Some

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2014-08-13 Thread Michael Eager
On 07/06/14 03:26, Chen Gang wrote: * microblaze/mocroblaze.md (call_value_intern): Use 'SI' instead of 'VOID' for operand 1, just like 'call_internal1' has done. The related warning: ../../gcc/gcc/config/microblaze/microblaze.md:2172: warning: operand 1 missing mode?

Re: [PATCH 125/236] config/aarch64/aarch64.c: Use rtx_insn

2014-08-13 Thread Richard Earnshaw
On 06/08/14 18:21, David Malcolm wrote: gcc/ * config/aarch64/aarch64.c (aarch64_load_symref_appropriately): Strengthen local insns from rtx to rtx_insn *. (aarch64_set_frame_expr): Likewise for local insn. (aarch64_save_or_restore_fprs): Likewise.

Re: [PATCH 128/236] config/arm: Use rtx_insn and rtx_code_label

2014-08-13 Thread Richard Earnshaw
On 06/08/14 18:21, David Malcolm wrote: gcc/ * config/arm/arm-protos.h (arm_final_prescan_insn): Likewise for param. (thumb1_final_prescan_insn): Likewise. (thumb2_final_prescan_insn): Likewise. * config/arm/arm.c (emit_set_insn): Strengthen return type

Re: [PATCH, AArch64] Use MOVN to generate 64-bit negative immediates where sensible

2014-08-13 Thread Kyrill Tkachov
On 07/08/14 20:32, Richard Henderson wrote: On 08/07/2014 02:57 AM, Kyrill Tkachov wrote: + if (one_match zero_match) +{ + /* Set either first three quarters or all but the third. */ + mask = 0xll (16 - first_not__match); + emit_insn (gen_rtx_SET (VOIDmode, dest,

Re: [PATCH] gcc/config/microblaze/microblaze.md: Remove redundant '@' to avoid compiling warning

2014-08-13 Thread Michael Eager
On 07/05/14 20:59, Chen Gang wrote: * microblaze/microblaze.md: Remove redundant '@' to avoid compiling warning. The related warning: ../../gcc/gcc/config/microblaze/microblaze.md:516: '@' is redundant for output template with single alternative Signed-off-by: Chen Gang

[COMMITTED PATCH] Demangler fuzzer

2014-08-13 Thread Gary Benson
Ian Lance Taylor wrote: On Tue, Aug 12, 2014 at 10:11 AM, Gary Benson gben...@redhat.com wrote: Ian Lance Taylor wrote: I think that by default the program should stop. That will make it possible to eventually run as part of make check. Give it some number of iterations that stops it

Re: [PATCH AArch64 1/3] Don't disparage add/sub in SIMD registers

2014-08-13 Thread Vladimir Makarov
On 2014-08-13, 4:36 AM, James Greenhalgh wrote: On Tue, Aug 12, 2014 at 04:53:38PM +0100, pins...@gmail.com wrote: On Aug 12, 2014, at 7:40 AM, Alan Lawrence alan.lawre...@arm.com wrote: (It is no more expensive.) Yes on some processors it could be. Haven't we been here before [1]?

Re: [gomp4] Add tables generation

2014-08-13 Thread Ilya Verbin
Hi, Here is the updated patch. offload_funcs/vars are now declared in omp-low.h, the functions have a comment. Also it fixes the issue of offload_funcs/vars corruption by the garbage collector. OK for gomp-4_0-branch? -- Ilya --- gcc/Makefile.in|1 + gcc/gengtype.c |

Re: [PATCH 140/236] config/microblaze/microblaze.c: Use rtx_insn and rtx_code_label

2014-08-13 Thread Michael Eager
On 08/06/14 10:21, David Malcolm wrote: gcc/ * config/microblaze/microblaze.c (microblaze_call_tls_get_addr): Strengthen return type and local insns from rtx to rtx_insn *. (microblaze_legitimize_tls_address): Likewise for local insns.

Re: [C++ Patch] Remove invalid type in declaration parser error

2014-08-13 Thread Jason Merrill
OK. Jason

Re: [PATCH 029/236] rtl_data.x_parm_birth_insn is an insn

2014-08-13 Thread David Malcolm
On Wed, 2014-08-13 at 07:44 -0600, Jeff Law wrote: On 08/06/14 11:20, David Malcolm wrote: gcc/ * function.h (struct rtl_data): Strengthen field x_parm_birth_insn from rtx to rtx_insn *. * function.c (struct assign_parm_data_all): Strengthen fields first_conversion_insn

Re: [PATCH 029/236] rtl_data.x_parm_birth_insn is an insn

2014-08-13 Thread Jeff Law
On 08/13/14 11:08, David Malcolm wrote: On Wed, 2014-08-13 at 07:44 -0600, Jeff Law wrote: On 08/06/14 11:20, David Malcolm wrote: gcc/ * function.h (struct rtl_data): Strengthen field x_parm_birth_insn from rtx to rtx_insn *. * function.c (struct assign_parm_data_all):

Re: [PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-13 Thread Uros Bizjak
On Wed, Aug 13, 2014 at 4:23 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: In a couple of places, MODE_SIZE checks are changed to GET_MODE_SIZE (GET_MODE (operands[0])) and in a similar way, MODEmode checks were changed to GET_MODE (operands[0]). The previous checks are more efficient

Re: [PATCH] Fix PR62077

2014-08-13 Thread Jason Merrill
On 08/13/2014 10:28 AM, Richard Biener wrote: Sofar the patch survived building stage2 in a LTO bootstrap on the 4.9 branch, full testing is scheduled for trunk. The patch breaks a lot of C++ testcases, such as g++.old-deja/g++.other/cvt1.C; I think you need to share the set the canonical

Re: [PATCH 032/236] emit_* functions return rtx_insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: More scaffolding: strengthen the return types from the various emit_ functions from rtx to rtx_insn * (or to the rtx_barrier * subclass in a few cases). These will ultimately have their params strengthened also, but we postpone that until much later in

Re: [PATCH 033/236] emit_move et al return rtx_insn *

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * expr.h (emit_move_insn): Strengthen return type from rtx to rtx_insn *. (emit_move_insn_1): Likewise. (emit_move_complex_push): Likewise. (emit_move_complex_parts): Likewise. * expr.c

Re: [PATCH 034/236] next_cc0_user and prev_cc0_setter scaffolding

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * rtl.h (next_cc0_user): Strengthen return type from rtx to rtx_insn *. (prev_cc0_setter): Likewise. * emit-rtl.c (next_cc0_user): Strengthen return type from rtx to rtx_insn *, adding checked casts for now as

Re: [PATCH 035/236] Return types of unlink_insn_chain and duplicate_insn_chain

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * rtl.h (unlink_insn_chain): Strengthen return type from rtx to rtx_insn *. (duplicate_insn_chain): Likewise. * cfgrtl.c (unlink_insn_chain): Strengthen return type from rtx to rtx_insn *, also for locals

Re: [PATCH 036/236] get_last_bb_insn returns an rtx_insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * basic-block.h (get_last_bb_insn): Strengthen return type from rtx to rtx_insn *. * cfgrtl.c (get_last_bb_insn): Likewise, and for locals tmp and end. OK. jeff

Re: [PATCH 037/236] sel_bb_{head|end} return rtx_insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * sel-sched-ir.h (exit_insn): Strengthen from rtx to rtx_insn *. (sel_bb_head): Strengthen return type insn_t (currently just an rtx) to rtx_insn *. (sel_bb_end): Likewise. * sel-sched-ir.c (exit_insn):

Re: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Mike Stump
On Aug 13, 2014, at 5:12 AM, Felix Yang fei.yang0...@gmail.com wrote: The qsort library function may have different behavior on different hosts (say Linux vs MinGW). OK for trunk? I just have one question. Why if we want to use a stable sort, and we program in C++, would we not want to

Re: [PATCH 038/236] find_first_parameter_load returns an rtx_insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * rtl.h (find_first_parameter_load): Strengthen return type from rtx to rtx_insn *. * rtlanal.c (find_first_parameter_load): Strengthen return type from rtx to rtx_insn *. Add checked cast for now, to postpone

Re: [PATCH 039/236] create_insn_rtx_from_pattern and create_copy_of_insn_rtx return rtx_insn

2014-08-13 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * sel-sched-ir.h (create_insn_rtx_from_pattern): Strengthen return type from rtx to rtx_insn *. * sel-sched-ir.h (create_copy_of_insn_rtx): Likewise. * sel-sched-ir.c (create_insn_rtx_from_pattern): Likewise. *

Fwd: [PATCH] Add Berkeley qsort to libiberty to make GCC host-independent

2014-08-13 Thread Mike Stump
[ dup sorry ] On Aug 13, 2014, at 5:12 AM, Felix Yang fei.yang0...@gmail.com wrote: The qsort library function may have different behavior on different hosts (say Linux vs MinGW). OK for trunk? I just have one question. Why if we want to use a stable sort, and we program in C++, would we

  1   2   >