Re: [PATCH] rs6000: Use subreg for QI/HI vector init

2020-12-14 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the review! on 2020/12/15 上午2:51, Segher Boessenkool wrote: > Hi! > > On Wed, Dec 02, 2020 at 05:44:24PM +0800, Kewen.Lin wrote: >> This patch is to use paradoxical subreg instead of >> zero_extend for promoting QI/HI to SI/DI when we >> want to construct one vector with

AVR maintainership (was: [patch,avr, 1/3] Support 64-bit (long) double: The gcc part.)

2020-12-14 Thread Gerald Pfeifer
On Mon, 6 Jan 2020, Jeff Law wrote: >> p.s. You know anything about Denis Chertykov? He used to reply to avr >> patches within hours, but my latest patches (after a long period where I >> didn't propose any patches) where all approved by you; not a single mail >> from Denis. So I am concerned

[committed] doc: Update link to KernelAddressSanitizer

2020-12-14 Thread Gerald Pfeifer
A simple redirect; pushed. Gerald gcc/ChangeLog: 2020-12-15 Gerald Pfeifer * doc/invoke.texi (Instrumentation Options): Update link to KernelAddressSanitizer. --- gcc/doc/invoke.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/invoke.texi

[committed] wwwdocs: gcc-10/changes: Update two arm.com URLs

2020-12-14 Thread Gerald Pfeifer
The webmasters for arm.com appear to be a little bored (and like ever longer URLs); at least they put a redirect in place. Pushed. Gerald --- htdocs/gcc-10/changes.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/gcc-10/changes.html

[committed] wwwdocs: extensions: Update StarPU link

2020-12-14 Thread Gerald Pfeifer
A straightforward redirect resolved. Gerald --- htdocs/extensions.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/extensions.html b/htdocs/extensions.html index 76a89e1a..2e929a5b 100644 --- a/htdocs/extensions.html +++ b/htdocs/extensions.html @@ -30,7 +30,7 @@

[COMMITTED] gcc: xtensa: fix PR target/98285

2020-12-14 Thread Max Filippov via Gcc-patches
2020-12-14 Max Filippov gcc/ * config/xtensa/predicates.md (addsubx_operand): Change accepted values from 2/4/8 to 1..3. * config/xtensa/xtensa.md (*addx, *subx): Change RTL pattern to use 'ashift' instead of 'mult'. Update operands[3] value. gcc/testsuite/

Go testsuite patch committed: Retain any characters at end of ERROR line

2020-12-14 Thread Ian Lance Taylor via Gcc-patches
This patch to the Go testsuite driver retains any characters at the end of an ERROR line in a test. This is needed for at least one upcoming test. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian * go.test/go-test.exp (errchk): Retain any characters at the

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-14 Thread Nikhil Benesch via Gcc-patches
On 12/14/20 10:34 PM, Ian Lance Taylor wrote: On Mon, Dec 14, 2020 at 7:14 PM Nikhil Benesch wrote: Also godump now emits a dummy `type _u?pad128_t struct {}` entry, so we just suppress that and conditionally add it back. I don't understand this bit. Why are we seeing an empty struct

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-14 Thread Ian Lance Taylor via Gcc-patches
On Mon, Dec 14, 2020 at 7:14 PM Nikhil Benesch wrote: > > On 12/14/20 5:30 AM, Rainer Orth wrote: > > with the revised godump.c patch and this one for mk*sysinfo.sh, I still > > get failures on all of Solaris 11.3/x86, 11.4/x86, and 11.4/SPARC > > (didn't try 11.3/SPARC): > > > > * Solaris

Re: [PATCH 3/1] c++: Fix return type deduction during satisfaction

2020-12-14 Thread Jason Merrill via Gcc-patches
On 12/14/20 3:47 PM, Patrick Palka wrote: On Mon, 14 Dec 2020, Jason Merrill wrote: On 12/14/20 1:07 PM, Patrick Palka wrote: During satisfaction that's entered through the three-parameter version of satisfy_declaration_constraints, current_function_decl gets set to the dependent

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-14 Thread Nikhil Benesch via Gcc-patches
On 12/14/20 5:30 AM, Rainer Orth wrote: with the revised godump.c patch and this one for mk*sysinfo.sh, I still get failures on all of Solaris 11.3/x86, 11.4/x86, and 11.4/SPARC (didn't try 11.3/SPARC): * Solaris 11.3/x86 and 11.4/x86: runtime_sysinfo.go:5995:6: error: redefinition of

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-14 Thread abebeos via Gcc-patches
On Tue, 15 Dec 2020 at 04:01, Jeff Law wrote: > > > On 12/14/20 12:10 PM, Dimitar Dimitrov wrote: > > On четвъртък, 10 декември 2020 г. 10:24:50 EET Richard Biener wrote: > >> On Thu, Dec 10, 2020 at 6:42 AM Dimitar Dimitrov > wrote: > >>> On сряда, 9 декември 2020 г. 15:12:49 EET abebeos via

Re: V3 [PATCH 1/2] Switch to a new section if the SECTION_RETAIN bit doesn't match

2020-12-14 Thread H.J. Lu via Gcc-patches
On Mon, Dec 14, 2020 at 5:06 PM Jeff Law wrote: > > > > On 12/8/20 5:51 AM, H.J. Lu wrote: > > When definitions marked with used attribute and unmarked definitions are > > placed in the section with the same name, switch to a new section if the > > SECTION_RETAIN bit doesn't match. > > > > gcc/ >

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-14 Thread Jeff Law via Gcc-patches
On 12/14/20 12:10 PM, Dimitar Dimitrov wrote: > On четвъртък, 10 декември 2020 г. 10:24:50 EET Richard Biener wrote: >> On Thu, Dec 10, 2020 at 6:42 AM Dimitar Dimitrov wrote: >>> On сряда, 9 декември 2020 г. 15:12:49 EET abebeos via Gcc-patches wrote: Essence: I need a

Re: V3 [PATCH 1/2] Switch to a new section if the SECTION_RETAIN bit doesn't match

2020-12-14 Thread Jeff Law via Gcc-patches
On 12/8/20 5:51 AM, H.J. Lu wrote: > When definitions marked with used attribute and unmarked definitions are > placed in the section with the same name, switch to a new section if the > SECTION_RETAIN bit doesn't match. > > gcc/ > > PR target/98146 > * output.h (switch_to_section):

Re: [PATCH] libstdc++: Add C++ runtime support for new 128-bit long double format

2020-12-14 Thread Tulio Magno Quites Machado Filho via Gcc-patches
Jonathan Wakely writes: >>Hmm, yes, you pointed me to __frexpieee128 a few months ago, but for >>some reason I either didn't switch to using it, or lost a patch when >>squashing and rebasing branches. Hopefully I just forgot to change it, >>but I'll double check to make sure I haven't left any

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-14 Thread Segher Boessenkool
On Tue, Dec 15, 2020 at 12:29:45AM +0100, Gerald Pfeifer wrote: > On Mon, 14 Dec 2020, Segher Boessenkool wrote: > >> + powerpc*le-*-*) > >> + tm_file="${tm_file} rs6000/sysv4le.h" ;; > >> + esac > > What an obvious filename ;-) > > ;-) > > > The patch looks fine. Okay for trunk.

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-14 Thread Piotr Kubaj via Gcc-patches
Yes, there is, thanks for noticing that! Fixed patch attached. On 20-12-15 00:37:02, Gerald Pfeifer wrote: > On Mon, 14 Dec 2020, Piotr Kubaj via Gcc-patches wrote: > > --- gcc/configure.ac.orig 2020-12-14 15:22:23 UTC > > +++ gcc/configure.ac > > @@ -5874,6 +5874,8 @@ case

Re: [committed][wwwdocs] gcc-11/changes: "used" attribute saves decls from linker garbage collection

2020-12-14 Thread Gerald Pfeifer
On Mon, 7 Dec 2020, Jozef Lawrynowicz wrote: > Committed as obvious. Thank you! + +For ELF targets that support the GNU or FreeBSD OSABIs, the +used attribute will now save the symbol declaration it is +applied to from linker garbage collection. + +To support this behavior,

Re: [wwwdocs] Document new Hardware-assisted AddressSanitizer

2020-12-14 Thread Gerald Pfeifer
On Mon, 14 Dec 2020, Matthew Malcomson via Gcc-patches wrote: > gcc-11/changes: Document new Hardware-assisted AddressSanitizer. > > I have put it in the "general" section rather than AArch64 since the > feature does add a general framework, so I believe the news is > interesting for people

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-14 Thread Gerald Pfeifer
On Mon, 14 Dec 2020, Piotr Kubaj via Gcc-patches wrote: > --- gcc/configure.ac.orig 2020-12-14 15:22:23 UTC > +++ gcc/configure.ac > @@ -5874,6 +5874,8 @@ case "$target:$tm_file" in > *-*-linux*) > emul_name="-melf64ppc" > ;; >+ *le-*-freebsd*) >+

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-14 Thread Gerald Pfeifer
On Mon, 14 Dec 2020, Segher Boessenkool wrote: >> +powerpc*le-*-*) >> +tm_file="${tm_file} rs6000/sysv4le.h" ;; >> +esac > What an obvious filename ;-) ;-) > The patch looks fine. Okay for trunk. Also okay for any backports you > want (after waiting to see if it

Re: [PATCH 2/3] PowerPC: require IBM long double for pr70117.

2020-12-14 Thread Segher Boessenkool
Hi! On Thu, Dec 03, 2020 at 10:57:56PM -0500, Michael Meissner wrote: > --- a/gcc/testsuite/gcc.target/powerpc/pr70117.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr70117.c > @@ -1,5 +1,6 @@ > -/* { dg-do run { target { powerpc*-*-linux* powerpc*-*-darwin* > powerpc*-*-aix* rs6000-*-* } } } */ >

Re: [PATCH] correct -Wmismatched-new-delete (PR 98160, 98166)

2020-12-14 Thread Jeff Law via Gcc-patches
On 12/14/20 2:05 PM, Martin Sebor wrote: > On 12/13/20 10:23 AM, Jeff Law wrote: >> >> >> On 12/8/20 1:46 PM, Martin Sebor wrote: >>> PR 98160 reports an ICE in pretty printer code called from the newly >>> added -Wmismatched-new-delete.  The ICE is just a simple oversight, >>> but much more

[PATCH, rs6000] Don't set MMA prefixed instruction length to 8

2020-12-14 Thread Pat Haugen via Gcc-patches
Fix instruction length for MMA insns. Prefixed instructions should not have their length explicitly set to '8'. The function get_attr_length() will adjust the length appropriately based on the value of the "prefixed" attribute. Bootstrap/regtest on powerpc64le (Power8/Power10) with no new

Re: [PATCH] Fix _GLIBCXX_DEBUG tests

2020-12-14 Thread François Dumont via Gcc-patches
On 14/12/20 11:08 am, Jonathan Wakely wrote: On Mon, 14 Dec 2020, 06:51 François Dumont via Libstdc++, mailto:libstdc%2b...@gcc.gnu.org>> wrote: On 13/12/20 11:17 pm, Jonathan Wakely wrote: > On 13/12/20 15:52 +0100, François Dumont via Libstdc++ wrote: >> Some tests are XPASS

c++: module-related tweak

2020-12-14 Thread Nathan Sidwell
In manually applying a name-lookup patch, I managed to transpose two calls. That caused a test failure. Fixed thusly. gcc/cp/ * name-lookup.c (do_namespace_alias): Set originating module before pushing. pushing to trunk -- Nathan Sidwell diff --git

Re: [PATCH] ira.c: Fix ICE in ira-color [PR97092]

2020-12-14 Thread Vladimir Makarov via Gcc-patches
On 2020-12-14 11:23 a.m., Andrea Corallo wrote: Vladimir Makarov writes: On 2020-12-10 10:12 a.m., Andrea Corallo wrote: Hi all, following discussion on PR97092 I'd like to submit the following patch with a fix plus associated testcase. With this patch applied mode is recomputed at each

Re: [PATCH] correct -Wmismatched-new-delete (PR 98160, 98166)

2020-12-14 Thread Martin Sebor via Gcc-patches
On 12/13/20 10:23 AM, Jeff Law wrote: On 12/8/20 1:46 PM, Martin Sebor wrote: PR 98160 reports an ICE in pretty printer code called from the newly added -Wmismatched-new-delete.  The ICE is just a simple oversight, but much more interesting is the warning issued for the test case. It

Re: [PATCH 1/3] PowerPC: Add long double target-supports.

2020-12-14 Thread Segher Boessenkool
On Thu, Dec 03, 2020 at 11:06:12PM -0500, Michael Meissner wrote: > +proc check_effective_target_ppc_long_double_ibm { } { > +return [check_cached_effective_target ppc_long_double_ibm { > + int main() > + { > + #if !defined(_ARCH_PPC) || !defined(__LONG_DOUBLE_IBM128__) > +

Re: [PATCH 3/1] c++: Fix return type deduction during satisfaction

2020-12-14 Thread Patrick Palka via Gcc-patches
On Mon, 14 Dec 2020, Jason Merrill wrote: > On 12/14/20 1:07 PM, Patrick Palka wrote: > > During satisfaction that's entered through the three-parameter version > > of satisfy_declaration_constraints, current_function_decl gets set to > > the dependent DECL_TEMPLATE_RESULT for sake of access

Re: [PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-14 Thread Patrick Palka via Gcc-patches
On Mon, 14 Dec 2020, Jason Merrill wrote: > On 12/14/20 1:07 PM, Patrick Palka wrote: > > This makes tracking of potentially unstable satisfaction results more > > precise by recording the specific types for which completion failed > > during satisfaction. We now recompute a satisfaction result

Re: [19/23] rtlanal: Add some new helper classes

2020-12-14 Thread Jeff Law via Gcc-patches
On 12/14/20 9:37 AM, Richard Sandiford wrote: > Jeff Law writes: >> On 11/13/20 1:20 AM, Richard Sandiford via Gcc-patches wrote: >>> This patch adds some classes for gathering the list of registers >>> and memory that are read and written by an instruction, along >>> with various properties

Re: [PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-14 Thread Jason Merrill via Gcc-patches
On 12/14/20 1:07 PM, Patrick Palka wrote: This makes tracking of potentially unstable satisfaction results more precise by recording the specific types for which completion failed during satisfaction. We now recompute a satisfaction result only if one of these types has been completed since the

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-14 Thread Dimitar Dimitrov
On четвъртък, 10 декември 2020 г. 10:24:50 EET Richard Biener wrote: > On Thu, Dec 10, 2020 at 6:42 AM Dimitar Dimitrov wrote: > > On сряда, 9 декември 2020 г. 15:12:49 EET abebeos via Gcc-patches wrote: > > > Essence: > > > > > > I need a confirmation that the testsuite setup as presented in: >

Re: [Patch] varasm.c: Always output flags in merged .section for LLVM assembler compatibility [PR97827]

2020-12-14 Thread Jakub Jelinek via Gcc-patches
On Mon, Dec 14, 2020 at 07:44:12PM +0100, Tobias Burnus wrote: > Regarding this discussion, see also the comments from an LLVM reviewer > at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97827 * — to keep them > at one place, I won't quote the discussion here. I think the LLVM people must be

Re: [PATCH 3/1] c++: Fix return type deduction during satisfaction

2020-12-14 Thread Jason Merrill via Gcc-patches
On 12/14/20 1:07 PM, Patrick Palka wrote: During satisfaction that's entered through the three-parameter version of satisfy_declaration_constraints, current_function_decl gets set to the dependent DECL_TEMPLATE_RESULT for sake of access checking. This makes the predicate in_template_function

Re: [PATCH] rs6000: Use subreg for QI/HI vector init

2020-12-14 Thread Segher Boessenkool
On Wed, Dec 02, 2020 at 04:32:47PM -0600, will schmidt wrote: > On Wed, 2020-12-02 at 17:44 +0800, Kewen.Lin via Gcc-patches wrote: > > * gcc.target/powerpc/pr96933-1.c: Adjusted to check no rlwinm. > > * gcc.target/powerpc/pr96933-2.c: Likewise. > > Ok. (I'd hope a few more extend

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-14 Thread Dimitar Dimitrov
On петък, 11 декември 2020 г. 19:00:35 EET abebeos wrote: > After "digesting" a bit more your review, I need to thank you for opening > my eyes re "cherrypick" suggestion and... the missing g++ summaries. I need > to update my setup to provide the g++ test-deltas, too. Note that in my >

Re: [PATCH] rs6000: Use subreg for QI/HI vector init

2020-12-14 Thread Segher Boessenkool
Hi! On Wed, Dec 02, 2020 at 05:44:24PM +0800, Kewen.Lin wrote: > This patch is to use paradoxical subreg instead of > zero_extend for promoting QI/HI to SI/DI when we > want to construct one vector with these modes. > Since we do the gpr->vsx movement and vector merge > or pack later, the high

Re: [Patch] varasm.c: Always output flags in merged .section for LLVM assembler compatibility [PR97827]

2020-12-14 Thread Tobias Burnus
Regarding this discussion, see also the comments from an LLVM reviewer at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97827 * — to keep them at one place, I won't quote the discussion here. It would be great if this could be solved one way or the other... Tobias * for the LLVM side, see also

[PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-14 Thread Patrick Palka via Gcc-patches
This makes tracking of potentially unstable satisfaction results more precise by recording the specific types for which completion failed during satisfaction. We now recompute a satisfaction result only if one of these types has been completed since the last time we computed the satisfaction

[PATCH 3/1] c++: Fix return type deduction during satisfaction

2020-12-14 Thread Patrick Palka via Gcc-patches
During satisfaction that's entered through the three-parameter version of satisfy_declaration_constraints, current_function_decl gets set to the dependent DECL_TEMPLATE_RESULT for sake of access checking. This makes the predicate in_template_function return true during satisfaction from this

Re: rs6000: Update the processor defaults for FreeBSD

2020-12-14 Thread Segher Boessenkool
On Mon, Dec 14, 2020 at 05:29:30PM +0100, Piotr Kubaj wrote: > On 20-12-14 10:22:32, Segher Boessenkool wrote: > > On Mon, Dec 14, 2020 at 03:57:27PM +0100, Piotr Kubaj wrote: > > > > It is both, actually (-mcpu= implies -mtune=) > > > Yes, but -mtune doesn't imply -mcpu. If I set up only -mtune,

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-14 Thread Segher Boessenkool
Hi! On Mon, Dec 14, 2020 at 04:35:38PM +0100, Piotr Kubaj wrote: > this patch implements support for powerpc64le architecture on FreeBSD. Since > we don't have powerpcle (32-bit), I did not add support for powerpcle here. > This remains to be changed if there is powerpcle support in the future.

Re: [19/23] rtlanal: Add some new helper classes

2020-12-14 Thread Richard Sandiford via Gcc-patches
Jeff Law writes: > On 11/13/20 1:20 AM, Richard Sandiford via Gcc-patches wrote: >> This patch adds some classes for gathering the list of registers >> and memory that are read and written by an instruction, along >> with various properties about the accesses. In some ways it's >> similar to the

Re: rs6000: Update the processor defaults for FreeBSD

2020-12-14 Thread Piotr Kubaj via Gcc-patches
On 20-12-14 10:22:32, Segher Boessenkool wrote: > On Mon, Dec 14, 2020 at 03:57:27PM +0100, Piotr Kubaj wrote: > > > It is both, actually (-mcpu= implies -mtune=) > > Yes, but -mtune doesn't imply -mcpu. If I set up only -mtune, -mcpu is the > > generic one (ppc970 for BE) > > But that is not

Re: rs6000: Update the processor defaults for FreeBSD

2020-12-14 Thread Segher Boessenkool
On Mon, Dec 14, 2020 at 03:57:27PM +0100, Piotr Kubaj wrote: > > It is both, actually (-mcpu= implies -mtune=) > Yes, but -mtune doesn't imply -mcpu. If I set up only -mtune, -mcpu is the > generic one (ppc970 for BE) But that is not what the patch does? > > > Linux also does similarly in

Re: [PATCH] ira.c: Fix ICE in ira-color [PR97092]

2020-12-14 Thread Andrea Corallo via Gcc-patches
Vladimir Makarov writes: > On 2020-12-10 10:12 a.m., Andrea Corallo wrote: >> Hi all, >> >> following discussion on PR97092 I'd like to submit the following patch >> with a fix plus associated testcase. >> >> With this patch applied mode is recomputed at each iteration while >> looping across

Re: [PATCH]AArch64: Add NEON, SVE and SVE2 RTL patterns for Complex Addition, Multiply and FMA.

2020-12-14 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi Richard, > > Do you object to me splitting off complex add and addressing your remaining > feedback later when the rewrite of mul and fma are done. No, sounds good to me. Thanks, Richard

[PATCH] gcov: fix line output for nested functions in JSON format

2020-12-14 Thread Martin Liška
Hello. The patch fixes intermediate format for situations where we have a nested function or a lambda function. In that case, line number was wrong. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I'll install the patch if there are no objections. Martin gcc/ChangeLog:

[PATCH][pushed] gcov: Update comments.

2020-12-14 Thread Martin Liška
The patch updates comments in gcov.c file. Pushed to master. gcc/ChangeLog: * gcov.c (output_json_intermediate_file): Update comments. --- gcc/gcov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/gcov.c b/gcc/gcov.c index 36938bd0fce..daa1266db86 100644

[Ada] Small adjustments to fixed-point I/O units

2020-12-14 Thread Pierre-Marie de Rodat
The first adjustment is to the documentation contained in the units, which explains the implementation choices. The second adjustment is to the size selection mechanism, which is better done on base types. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ *

[Ada] Small cleanup in the Ada.Text_IO hierarchy

2020-12-14 Thread Pierre-Marie de Rodat
This replaces the remaining uses of Current_Input with Current_In and those of Current_Output with Current_Out for the sake of consistency. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/a-tifiio.adb (Get): Replace Current_Input with Current_In. *

[Ada] Fix compile time evaluation of shift intrinsics

2020-12-14 Thread Pierre-Marie de Rodat
Recent improvements to sem_eval.adb (Fold_Shift) do not take into account that these operations should be performed on the base type. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_eval.adb (Fold_Shift): Compute values using the base type.diff --git

[Ada] Analyze second parameter of attribute Scaling

2020-12-14 Thread Pierre-Marie de Rodat
Attribute Scaling has two parameters but only one of them has been resolved. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_attr.adb (Analyze_Attribute): Resolve second parameter of attribute Scaling just like it is resolved for a similar attribute

[Ada] Fix internal error on bit-packed array in Volatile_Full_Access record

2020-12-14 Thread Pierre-Marie de Rodat
This fixes an issue in Remove_Side_Effects, which insists that a renaming be handled by the back-end whereas Evaluation_Required says that it should be handled by the front-end (renamings involving Volatile_Full_Access must be fully expanded by the front-end). This also reinstates an earlier fix

[Ada] Process Truncation just like other floating point attributes

2020-12-14 Thread Pierre-Marie de Rodat
Analysis of attribute Truncation was first calling Resolve and then Set_Etype, while all the similar attributes had these calls in the reverse order. This inconsistency was present since the support for Truncation was added, but it had no semantics implications. Tested on x86_64-pc-linux-gnu,

[Ada] Incorrect accessibility level on type in formal package

2020-12-14 Thread Pierre-Marie de Rodat
This patch fixes an issue in the compiler whereby a class-wide allocator for a type declared within a generic formal package was not treated the same as a formal type with respect to accessibility checks - leading to spurious accessibility errors. Tested on x86_64-pc-linux-gnu, committed on trunk

[Ada] Implement part of System.Fat_Gen more efficiently

2020-12-14 Thread Pierre-Marie de Rodat
This reimplements the low-level primitives of System.Fat_Gen, i.e. Copy_Sign, Decompose and Scaling more efficiently, by using the same direct approach as the existing implementation of Valid; only the normalization of denormalized numbers and the gradual underflow are still left to the hardware.

[Ada] Adjust again previous change to System.Fat_Gen

2020-12-14 Thread Pierre-Marie de Rodat
This removes the direct declaration of the smallest denormalized number and replaces it with an overlay of the equivalent integer constant, because such a direct declaration cannot be translated into C90. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-fatgen.adb:

[Ada] Adjust previous change to System.Fat_Gen

2020-12-14 Thread Pierre-Marie de Rodat
This removes the use clause for System.Unsigned_Type and replaces it with a localized use type clause for Long_Long_Unsigned. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-fatgen.adb: Remove use clause for System.Unsigned_Types. (Scaling): Add

[Ada] Implement AI12-0398-1/03

2020-12-14 Thread Pierre-Marie de Rodat
This commit implements AI12-0398-1/03, which adds the ability to specify aspects on discriminant specifications, extended return object declarations and entry index specifications. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * par-ch3.adb (P_Discriminant_Part_Opt): Parse

[Ada] Additional fixes for Default_Initial_Condition

2020-12-14 Thread Pierre-Marie de Rodat
After the recent implementation work for the Default_Initial_Condition aspect there were still some cases where DIC checks weren't performed properly with respect to calls to Initialize in the case of array and record components of controlled types. That is now corrected. There was also an issue

[Ada] Remove double initialization of the known value cache

2020-12-14 Thread Pierre-Marie de Rodat
Global variable CV_Cache, where values known at compilation time are stored, was initialization both by elaboration and by Sem_Eval.Initialize, which is called from Gnatdrv1 and required by the GNSA (GNAT Semantic Analyzer). Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ *

[Ada] armhf-linux: symbolic tracebacks

2020-12-14 Thread Pierre-Marie de Rodat
Implement non-symbolic tracebacks as a first step towards symbolic. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * tracebak.c: Add a section for ARM Linux.diff --git a/gcc/ada/tracebak.c b/gcc/ada/tracebak.c --- a/gcc/ada/tracebak.c +++ b/gcc/ada/tracebak.c @@ -309,6

[Ada] Simplify prevention of cascaded errors for Refined_State

2020-12-14 Thread Pierre-Marie de Rodat
The condition for adding a dummy constituent is now simpler (and seems more robust) and the dummy constituent is Any_Id (which exists precisely for avoiding cascaded errors). Finally, an assertion guards against returning with an ill-formed refinement. Cleanup only; the tool behaviour is

[Ada] Fix couple of bugs in the implementation of Round attribute

2020-12-14 Thread Pierre-Marie de Rodat
The first issue is that the attribute leaks into a multiplication or a division explicitly done in another fixed-point type before being passed to the attribute. The second issue is that the attribute is ignored for simple conversions from another fixed-point type. Tested on x86_64-pc-linux-gnu,

[Ada] Compiler crash on call to function instance

2020-12-14 Thread Pierre-Marie de Rodat
This patch fixes a bug that causes the compiler to crash if a renaming-as-body renames a function that is an instance of a generic function that returns a generic formal type, and the actual type is controlled, and the instantiation is nested within a procedure. Tested on x86_64-pc-linux-gnu,

[Ada] Avoid reanalysis of malformed dependency relations

2020-12-14 Thread Pierre-Marie de Rodat
When analysis of pragma Depends/Refined_Depends returns early because of a malformed pragma, it marks the pragma as analyzed to avoid repeated work. This is now done consistently for all early returns. Cleanup only; the GNAT and GNATprove behaviours are not really affected by this patch. Tested

[Ada] Fix analysis of access objects in Depends contracts

2020-12-14 Thread Pierre-Marie de Rodat
In the Depends/Refined_Depends contracts we now accept constant objects as the dependency outputs if they are of an access-to-variable type, but not when they are of an access-to-constant or access-to-subprogram types. This needs to be implemented in two places: for checking the Depends contract

[Ada] Tidy up implementation of System.Fat_Gen.Valid and inline it again

2020-12-14 Thread Pierre-Marie de Rodat
Besides the improved commentary, the removal of superfluous subtypes and other small tweaks throughout to make it more readable, this replaces the use of T'Mantissa by the more appropriate T'Machine_Mantissa in the body of System.Fat_Gen.Valid and also removes an unnecessary trick used to

[Ada] Correctly mark subprogram as not always inlined in GNATprove mode

2020-12-14 Thread Pierre-Marie de Rodat
In GNATprove mode, a call inside a Subprogram_Variant should lead to the called subprogram being marked as not always inlined. This was not always the case, now fixed. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * inline.adb (Cannot_Inline): Add No_Info parameter to

[Ada] Adjust documentation of System.Img_Util.Set_Decimal_Digits

2020-12-14 Thread Pierre-Marie de Rodat
The routine is now used both for decimal and for ordinary fixed-point types. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-imguti.ads (Set_Decimal_Digits): Adjust documentation.diff --git a/gcc/ada/libgnat/s-imguti.ads b/gcc/ada/libgnat/s-imguti.ads ---

[Ada] Update comment for processing of pragma Assertion_Policy

2020-12-14 Thread Pierre-Marie de Rodat
The code for pragma Assertion_Policy has been recently updated to include Subprogram_Variant and change the kind of Default_Initial_Condition, but the comment was not modified. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sa_messages.ads: Reference Subprogram_Variant in

Re: [PATCH]AArch64: Add NEON, SVE and SVE2 RTL patterns for Complex Addition, Multiply and FMA.

2020-12-14 Thread Tamar Christina via Gcc-patches
Hi Richard, Do you object to me splitting off complex add and addressing your remaining feedback later when the rewrite of mul and fma are done. Thanks, Tamar From: Richard Sandiford Sent: Monday, December 14, 2020 1:30 PM To: Tamar Christina Cc:

rs6000: add support for powerpc64le-unknown-freebsd

2020-12-14 Thread Piotr Kubaj via Gcc-patches
Hello, this patch implements support for powerpc64le architecture on FreeBSD. Since we don't have powerpcle (32-bit), I did not add support for powerpcle here. This remains to be changed if there is powerpcle support in the future. Patch implements similar endian detection to what linux64.h

Re: [PATCH] testsuite: Fix various scan-assembler-symbol-section issues

2020-12-14 Thread David Edelsohn via Gcc-patches
On Mon, Dec 14, 2020 at 9:44 AM Rainer Orth wrote: > > Hi David, > > > On Fri, Dec 4, 2020 at 5:35 AM Rainer Orth > > wrote: > > > >> On AIX 7.2, there are changes like > >> > >> -PASS: g++.dg/gomp/tls-5.C -std=c++2a scan-assembler-symbol-section > >> symbol ^_?ir$ (found ir) has section

Re: [PATCH] Fix -save-temp leaking lto files in /tmp

2020-12-14 Thread Bernd Edlinger
Hi, On 2/21/20 8:35 AM, Richard Biener wrote: > > IIRC this definitely clashes with Alex work to overhaul > -auxdir/-dumpdir queued for GCC 11 where some of the above > is improved. > > So whatever we do we should do it for GCC 11 after Alex patches > land. > > Richard. > Okay, I think this

preprocessor: Deferred macro support

2020-12-14 Thread Nathan Sidwell
For deferred macros we also need a new field on the macro itself, so that the module machinery can determine the macro was imported. Also the documentation for the hashnode's deferred field was incomplete. libcpp/ * include/cpplib.h (struct cpp_macro): Add imported_p field.

[PATCH]middle-end vect: Exclude TOP permute from blend considerations

2020-12-14 Thread Tamar Christina via Gcc-patches
Hi All, Similarly to UNKNOWN permutes, TOP needs to be excluded from being considered for blends because it produces no permute to check. Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu and no issues. Committed under the GCC obvious rules. Thanks, Tamar gcc/ChangeLog:

Re: [PATCH] i386: Make -march=x86-64-v[234] behave more like other -march= options

2020-12-14 Thread H.J. Lu via Gcc-patches
On Mon, Dec 14, 2020 at 7:09 AM Uros Bizjak wrote: > > On Mon, Dec 14, 2020 at 2:13 PM Jakub Jelinek wrote: > > > > Hi! > > > > If somebody has -march=x86-64-v2 (or -v3 or -v4) in $CFLAGS, $CXXFLAGS etc., > > then -m32 or -mabi=ms stops working. > > What is worse, if one configures gcc

Re: [PATCH] i386: Make -march=x86-64-v[234] behave more like other -march= options

2020-12-14 Thread Uros Bizjak via Gcc-patches
On Mon, Dec 14, 2020 at 2:13 PM Jakub Jelinek wrote: > > Hi! > > If somebody has -march=x86-64-v2 (or -v3 or -v4) in $CFLAGS, $CXXFLAGS etc., > then -m32 or -mabi=ms stops working. > What is worse, if one configures gcc --with-arch-32=x86-64-v2 (or -v3 or -v4), > then -mabi=ms stops working. > >

Re: rs6000: Update the processor defaults for FreeBSD

2020-12-14 Thread Piotr Kubaj via Gcc-patches
On 20-12-13 09:48:35, Segher Boessenkool wrote: > Hi! > > On Sun, Dec 13, 2020 at 03:34:57PM +0100, Piotr Kubaj wrote: > > this is only default tuning (-mtune, not -mcpu). > > It is both, actually (-mcpu= implies -mtune=) Yes, but -mtune doesn't imply -mcpu. If I set up only -mtune, -mcpu is the

Re: [PATCH] testsuite: Fix various scan-assembler-symbol-section issues

2020-12-14 Thread Rainer Orth
Hi David, > On Fri, Dec 4, 2020 at 5:35 AM Rainer Orth > wrote: > >> On AIX 7.2, there are changes like >> >> -PASS: g++.dg/gomp/tls-5.C -std=c++2a scan-assembler-symbol-section >> symbol ^_?ir$ (found ir) has section ^\\.tbss|\\[TL\\] (found >> _tls5.tls_[TL],4) >> +PASS: g++.dg/gomp/tls-5.C

Re: [PATCH] testsuite: Fix various scan-assembler-symbol-section issues

2020-12-14 Thread Rainer Orth
Hi Iain, >> * Next, I ran the tests on Darwin 11 and found two failing tests: [...] >> The other failing test is >> >> FAIL: g++.dg/gomp/tls-5.C -std=c++14 scan-assembler-symbol-section >> symbol ^_?_ZGR2ir_\$ (symbol not found) has section >> ^.tdata|[TL] >> FAIL:

Re: [PATCH v2] aix: Fixinclude updates [PR98208]

2020-12-14 Thread Nathan Sidwell
On 12/14/20 7:19 AM, Ilya Leoshkevich wrote: On Fri, 2020-12-11 at 07:51 -0500, Nathan Sidwell wrote: I'm pretty sure this is wrong. I think the test_text in inclhack.def should be a pre-fixed string that the testsuite presumably checks is converted. You're right; I've added your change

Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation

2020-12-14 Thread CHIGOT, CLEMENT via Gcc-patches
Hi Ian, Yes it is. Thanks, Clément From: Ian Lance Taylor Sent: Friday, December 11, 2020 6:58 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org ; David Edelsohn ; gofrontend-dev Subject: Re: [PATCH] gcc: handle double quotes in symbol name during

Re: C++ Module Binding Vector

2020-12-14 Thread Nathan Sidwell
On 12/11/20 3:39 PM, Jason Merrill wrote: On 12/2/20 9:19 AM, Nathan Sidwell wrote: This is modified from the original patch.  firstly it contains a few more necessary bits.  But mainly I renamed the entities from +extern tree make_binding_vec    (tree, unsigned clusters); ...

Re: [PATCH]AArch64: Add NEON, SVE and SVE2 RTL patterns for Complex Addition, Multiply and FMA.

2020-12-14 Thread Richard Sandiford via Gcc-patches
Rearranging slightly… > @@ -708,6 +713,10 @@ (define_c_enum "unspec" > UNSPEC_FCMLA90 ; Used in aarch64-simd.md. > UNSPEC_FCMLA180 ; Used in aarch64-simd.md. > UNSPEC_FCMLA270 ; Used in aarch64-simd.md. > +UNSPEC_FCMUL ; Used in aarch64-simd.md. > +UNSPEC_FCMUL180

[PATCH] i386: Make -march=x86-64-v[234] behave more like other -march= options

2020-12-14 Thread Jakub Jelinek via Gcc-patches
Hi! If somebody has -march=x86-64-v2 (or -v3 or -v4) in $CFLAGS, $CXXFLAGS etc., then -m32 or -mabi=ms stops working. What is worse, if one configures gcc --with-arch-32=x86-64-v2 (or -v3 or -v4), then -mabi=ms stops working. I think that is a nightmare user experience. It is ok that

Re: [PATCH][GCC][PR target/98177] aarch64: SVE: ICE in expand_direct_optab_fn

2020-12-14 Thread Richard Sandiford via Gcc-patches
Przemyslaw Wirkus writes: > Hi, > > Recent 'support SVE comparisons for unpacked integers' patch extends > operands of define_expands from SVE_FULL to SVE_ALL. This causes an ICE > hence this PR patch. > > This patch adds this relaxation for: > + reduc__scal_ and > + arch64_pred_reduc__ > in

[wwwdocs] Document new Hardware-assisted AddressSanitizer

2020-12-14 Thread Matthew Malcomson via Gcc-patches
gcc-11/changes: Document new Hardware-assisted AddressSanitizer. I have put it in the "general" section rather than AArch64 since the feature does add a general framework, so I believe the news is interesting for people interesting in architectures other than AArch64 that may want to implement

[PATCH v2] aix: Fixinclude updates [PR98208]

2020-12-14 Thread Ilya Leoshkevich via Gcc-patches
On Fri, 2020-12-11 at 07:51 -0500, Nathan Sidwell wrote: > > I'm pretty sure this is wrong. I think the test_text in > inclhack.def > should be a pre-fixed string that the testsuite presumably checks is > converted. You're right; I've added your change from the Bugzilla and updated the

Re: [PATCH v5] cacheflush.2: Document __builtin___clear_cache() as a more portable alternative

2020-12-14 Thread Heinrich Schuchardt via Gcc-patches
On 12/14/20 12:43 PM, Alejandro Colomar wrote: Reported-by: Heinrich Schuchardt Signed-off-by: Alejandro Colomar Reviewed-by: Heinrich Schuchardt --- man2/cacheflush.2 | 24 1 file changed, 24 insertions(+) diff --git a/man2/cacheflush.2 b/man2/cacheflush.2

[PATCH v5] cacheflush.2: Document __builtin___clear_cache() as a more portable alternative

2020-12-14 Thread Alejandro Colomar via Gcc-patches
Reported-by: Heinrich Schuchardt Signed-off-by: Alejandro Colomar --- man2/cacheflush.2 | 24 1 file changed, 24 insertions(+) diff --git a/man2/cacheflush.2 b/man2/cacheflush.2 index aba625721..7a2eed506 100644 --- a/man2/cacheflush.2 +++ b/man2/cacheflush.2 @@ -86,6

[committed] .dir-locals.el: Set 'fill-column' to 80 for c-mode

2020-12-14 Thread Andrea Corallo via Gcc-patches
Hi all, I've committed the attached patch as obvious. This is to set `fill-column' to 80 in c-mode (Emacs default it to 70) so now M-q does the right thing. I think is very handy especially in comments. Question: should we update the copyright manually for this file or have it updated by

Re: V3 [PATCH 1/2] Switch to a new section if the SECTION_RETAIN bit doesn't match

2020-12-14 Thread Vaseeharan Vinayagamoorthy via Gcc-patches
This patch fixes the section type conflict that I have been seeing. I have tested this patch using : Build: x86_64 Host: x86_64 Target: aarch64-none-linux-gnu On 08/12/2020, 12:52, "Gcc-patches on behalf of H.J. Lu via Gcc-patches" wrote: When definitions marked with used attribute and

RE: [PATCH]AArch64: Add NEON, SVE and SVE2 RTL patterns for Complex Addition, Multiply and FMA.

2020-12-14 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Tamar Christina > Sent: 10 December 2020 17:00 > To: gcc-patches@gcc.gnu.org > Cc: nd ; Richard Earnshaw ; > Marcus Shawcroft ; Kyrylo Tkachov > ; Richard Sandiford > > Subject: [PATCH]AArch64: Add NEON, SVE and SVE2 RTL patterns for > Complex Addition,

Re: [PATCH, v2, OpenMP 5.0, libgomp] Structure element mapping for OpenMP 5.0

2020-12-14 Thread Chung-Lin Tang
Ping. On 2020/12/4 10:15 PM, Chung-Lin Tang wrote: Hi Jakub, this is a new version of the structure element mapping patch for OpenMP 5.0 requirement changes. This one uses the approach you've outlined in your concept patch [1], basically to use more special REFCOUNT_* values to mark them,

  1   2   >