[PATCH] c-family: Fix up -fno-debug-cpp [PR111965]

2023-12-06 Thread Jakub Jelinek
Hi! As can be seen in the second testcase, -fno-debug-cpp is actually implemented the same as -fdebug-cpp and so doesn't turn the debugging off. The following patch fixes that. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2023-12-07 Andrew Pinski Jakub

Re: [PATCH] s390: Fix expansion of vec_step

2023-12-06 Thread Andreas Krebbel
On 12/4/23 11:14, Stefan Schulze Frielinghaus wrote: > Add missing "s390" while expanding vec_step to __builtin_s390_vec_step. > > gcc/ChangeLog: > > * config/s390/vecintrin.h (vec_step): Expand vec_step to > __builtin_s390_vec_step. Ok, Thanks! Andreas

Re: [PATCH] testsuite: Fix up gcc.target/s390/pr96127.c test for modern C [PR96127]

2023-12-06 Thread Andreas Krebbel
On 12/3/23 19:36, Jakub Jelinek wrote: > Hi! > > I've noticed this test regressed on s390x-linux with the addition of the > switch to modern C patchset. Haven't tried to reproduce the ICE, but as it > was a backend ICE and FE after warning used to add such casts before (now > errors), I think

[PATCH] expr: Handle BITINT_TYPE in count_type_elements [PR112881]

2023-12-06 Thread Jakub Jelinek
Hi! The following testcaser ICEs during gimplification, because count_type_elements doesn't handle BITINT_TYPE. It should handle it like other integral types. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2023-12-07 Jakub Jelinek PR middle-end/112881

[PATCH] tree-ssa-dce: Fix up maybe_optimize_arith_overflow for BITINT_TYPE [PR112880]

2023-12-06 Thread Jakub Jelinek
Hi! The following testcase ICEs because maybe_optimize_arith_overflow uses build_nonstandard_integer_type, which is inappropriate if type is large BITINT_TYPE. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2023-12-07 Jakub Jelinek PR

Re: veclower: improve selection of vector mode when lowering [PR 112787]

2023-12-06 Thread Richard Biener
On Wed, 6 Dec 2023, Andre Vieira (lists) wrote: > Hi, > > This patch addresses the issue reported in PR target/112787 by improving the > compute type selection. We do this by not considering types with more > elements > than the type we are lowering since we'd reject such types anyway. > >

Re: [PATCH] c++: Don't diagnose ignoring of attributes if all ignored attributes are attribute_ignored_p

2023-12-06 Thread Jakub Jelinek
On Wed, Dec 06, 2023 at 03:10:41PM +0100, Jakub Jelinek wrote: > So far tested with > GXX_TESTSUITE_STDS=98,11,14,17,20,23,26 make check-g++ > RUNTESTFLAGS="dg.exp=Wno-attributes* ubsan.exp=Wno-attributes*" > (which is all tests that use -Wno-attributes=), ok for trunk if it passes > full

Re: [PATCH v6] aarch64: New RTL optimization pass avoid-store-forwarding.

2023-12-06 Thread Richard Biener
On Wed, Dec 6, 2023 at 6:15 PM Manos Anagnostakis wrote: > > Hi again, > > I went and tested the requested changes and found out the following: > > 1. The pass is currently increasing insn_cnt on a NONJUMP_INSN_P, which is a > subset of NONDEBUG_INSN_P. I think there is no problem with depending

Re: [PATCH v6] aarch64: New RTL optimization pass avoid-store-forwarding.

2023-12-06 Thread Richard Biener
On Wed, Dec 6, 2023 at 7:44 PM Philipp Tomsich wrote: > > On Wed, 6 Dec 2023 at 23:32, Richard Biener > wrote: > > > > On Wed, Dec 6, 2023 at 2:48 PM Manos Anagnostakis > > wrote: > > > > > > This is an RTL pass that detects store forwarding from stores to larger > > > loads (load pairs). > >

Re: [PATCH] strub: enable conditional support

2023-12-06 Thread Richard Biener
On Thu, Dec 7, 2023 at 4:34 AM Alexandre Oliva wrote: > > On Dec 6, 2023, Alexandre Oliva wrote: > > > Disabling the runtime bits is easy, once we determine what condition we > > wish to test for. I suppose testing for target support in the compiler, > > issuing a 'sorry' in case the feature

Re: Causes to nvptx bootstrap fail: [PATCH v5] Introduce strub: machine-independent stack scrubbing

2023-12-06 Thread Richard Biener
On Wed, Dec 6, 2023 at 11:12 PM Alexandre Oliva wrote: > > On Dec 6, 2023, Thomas Schwinge wrote: > > > As I understand things, this cannot be implemented (at the call site) for > > nvptx, given that the callee's stack is not visible there: PTX is unusual > > in that the concept of a "standard"

Re: [PATCH v2] rs6000: Add new pass for replacement of contiguous addresses vector load lxv with lxvp

2023-12-06 Thread Kewen.Lin
on 2023/12/6 13:09, Michael Meissner wrote: > On Wed, Dec 06, 2023 at 10:22:57AM +0800, Kewen.Lin wrote: >> I'd expect you use UNSPEC_MMA_EXTRACT to extract V16QI from the result of >> lxvp, >> the current define_insn_and_split "*vsx_disassemble_pair" should be able to >> take >> care of it

Re: [patch-1v2, rs6000] enable fctiw on old archs [PR112707]

2023-12-06 Thread Kewen.Lin
Hi, on 2023/12/6 16:13, HAO CHEN GUI wrote: > Hi, > SImode in float register is supported on P7 above. It causes "fctiw" > can't be generated on old 32-bit processors as the output operand of > fctiw insn is an SImode in float/double register. This patch fixes the > problem by adding one expand

Re: [patch-2v2, rs6000] guard fctid on PPC64 and powerpc 476 [PR112707]

2023-12-06 Thread Kewen.Lin
Hi Haochen, on 2023/12/6 16:13, HAO CHEN GUI wrote: > Hi, > The "fctid" is supported on 64-bit Power processors and powerpc 476. It > need a guard to check it. The patch fixes the issue. > > Compared with last version, > https://gcc.gnu.org/pipermail/gcc-patches/2023-December/638859.html >

Re: [PATCH v3] LoongArch: Fix eh_return epilogue for normal returns

2023-12-06 Thread Yang Yujie
On Thu, Dec 07, 2023 at 11:02:58AM +0800, Xi Ruoyao wrote: > > I don't like this pair of {} for the for statement. It's not necessary > and it changes the indent level, causing the diff hard to review. > > Otherwise LGTM. I'm not sure why I didn't notice the eh_return issue > when I learnt

Re: [PATCH V3 2/3] Using pli for constant splitting

2023-12-06 Thread Kewen.Lin
Hi Jeff, on 2023/12/6 13:24, Jiufu Guo wrote: > Hi, > > For constant building e.g. r120=0x, which does not fit 'li or lis', > 'pli' is used to build this constant via 'emit_move_insn'. > > While for a complicated constant, e.g. 0xULL, when using >

Re: [PATCH V3 1/3]rs6000: update num_insns_constant for 2 insns

2023-12-06 Thread Kewen.Lin
Hi Jeff, on 2023/12/6 13:24, Jiufu Guo wrote: > Hi, > > Trunk gcc supports more constants to be built via two instructions: > e.g. "li/lis; xori/xoris/rldicl/rldicr/rldic". > And then num_insns_constant should also be updated. > > Function "rs6000_emit_set_long_const" is used to build

[PATCH v26 23/23] libstdc++: Optimize std::remove_pointer compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::remove_pointer by dispatching to the new remove_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (remove_pointer): Use __remove_pointer built-in trait. Signed-off-by: Ken Matsui ---

[PATCH v26 21/23] libstdc++: Optimize std::is_object compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_object by dispatching to the new __is_object built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_object): Use __is_object built-in trait. (is_object_v): Likewise. Signed-off-by: Ken Matsui ---

[PATCH v26 22/23] c++: Implement __remove_pointer built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::remove_pointer. gcc/cp/ChangeLog: * cp-trait.def: Define __remove_pointer. * semantics.cc (finish_trait_type): Handle CPTK_REMOVE_POINTER. gcc/testsuite/ChangeLog: * g++.dg/ext/has-builtin-1.C: Test existence of

[PATCH v26 19/23] libstdc++: Optimize std::is_function compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_function by dispatching to the new __is_function built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_function): Use __is_function built-in trait. (is_function_v): Likewise. Optimize its

[PATCH v26 20/23] c++: Implement __is_object built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_object. gcc/cp/ChangeLog: * cp-trait.def: Define __is_object. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_OBJECT. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise.

[PATCH v26 18/23] c++: Implement __is_function built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_function. gcc/cp/ChangeLog: * cp-trait.def: Define __is_function. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_FUNCTION. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise.

[PATCH v26 17/23] libstdc++: Optimize std::is_reference compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_reference by dispatching to the new __is_reference built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_reference): Use __is_reference built-in trait. (is_reference_v): Likewise. Signed-off-by:

[PATCH v26 16/23] c++: Implement __is_reference built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_reference. gcc/cp/ChangeLog: * cp-trait.def: Define __is_reference. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_REFERENCE. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise.

[PATCH v26 15/23] libstdc++: Optimize std::is_member_object_pointer compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_member_object_pointer by dispatching to the new __is_member_object_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_member_object_pointer): Use __is_member_object_pointer built-in trait.

[PATCH v26 14/23] c++: Implement __is_member_object_pointer built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_member_object_pointer. gcc/cp/ChangeLog: * cp-trait.def: Define __is_member_object_pointer. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_MEMBER_OBJECT_POINTER. * semantics.cc (trait_expr_value): Likewise.

[PATCH v26 13/23] libstdc++: Optimize std::is_member_function_pointer compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_member_function_pointer by dispatching to the new __is_member_function_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_member_function_pointer): Use __is_member_function_pointer built-in

[PATCH v26 12/23] c++: Implement __is_member_function_pointer built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_member_function_pointer. gcc/cp/ChangeLog: * cp-trait.def: Define __is_member_function_pointer. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_MEMBER_FUNCTION_POINTER. * semantics.cc (trait_expr_value):

[PATCH v26 11/23] libstdc++: Optimize std::is_member_pointer compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_member_pointer by dispatching to the new __is_member_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_member_pointer): Use __is_member_pointer built-in trait. (is_member_pointer_v):

[PATCH v26 10/23] c++: Implement __is_member_pointer built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_member_pointer. gcc/cp/ChangeLog: * cp-trait.def: Define __is_member_pointer. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_MEMBER_POINTER. * semantics.cc (trait_expr_value): Likewise.

[PATCH v26 09/23] libstdc++: Optimize std::is_scoped_enum compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_scoped_enum by dispatching to the new __is_scoped_enum built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_scoped_enum): Use __is_scoped_enum built-in trait. (is_scoped_enum_v): Likewise.

[PATCH v26 08/23] c++: Implement __is_scoped_enum built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_scoped_enum. gcc/cp/ChangeLog: * cp-trait.def: Define __is_scoped_enum. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_SCOPED_ENUM. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise.

[PATCH v26 07/23] libstdc++: Optimize std::is_bounded_array compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_bounded_array by dispatching to the new __is_bounded_array built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_bounded_array_v): Use __is_bounded_array built-in trait. Signed-off-by: Ken Matsui ---

[PATCH v26 06/23] c++: Implement __is_bounded_array built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_bounded_array. gcc/cp/ChangeLog: * cp-trait.def: Define __is_bounded_array. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_BOUNDED_ARRAY. * semantics.cc (trait_expr_value): Likewise.

[PATCH v26 05/23] libstdc++: Optimize std::is_array compilation performance

2023-12-06 Thread Ken Matsui
This patch optimizes the compilation performance of std::is_array by dispatching to the new __is_array built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_array): Use __is_array built-in trait. (is_array_v): Likewise. Signed-off-by: Ken Matsui ---

[PATCH v26 04/23] c++: Implement __is_array built-in trait

2023-12-06 Thread Ken Matsui
This patch implements built-in trait for std::is_array. gcc/cp/ChangeLog: * cp-trait.def: Define __is_array. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_ARRAY. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise.

[PATCH v26 03/23] c++: Accept the use of built-in trait identifiers

2023-12-06 Thread Ken Matsui
This patch accepts the use of built-in trait identifiers when they are actually not used as traits. Specifically, we check if the subsequent token is '(' for ordinary built-in traits or is '<' only for the special __type_pack_element built-in trait. If those identifiers are used differently, the

[PATCH v26 02/23] c-family, c++: Look up built-in traits via identifier node

2023-12-06 Thread Ken Matsui
Since RID_MAX soon reaches 255 and all built-in traits are used approximately once in a C++ translation unit, this patch removes all RID values for built-in traits and uses the identifier node to look up the specific trait. Rather than holding traits as keywords, we set all trait identifiers as

[PATCH v26 01/23] c++: Sort built-in traits alphabetically

2023-12-06 Thread Ken Matsui
This patch sorts built-in traits alphabetically for better code readability. gcc/cp/ChangeLog: * constraint.cc (diagnose_trait_expr): Sort built-in traits alphabetically. * cp-trait.def: Likewise. * semantics.cc (trait_expr_value): Likewise.

[PATCH v26 00/23] Optimize type traits compilation performance

2023-12-06 Thread Ken Matsui
This patch series optimizes type traits compilation performance by implementing built-in type traits and using them in libstdc++. Changes in v26: * Rebased on top of trunk. * Moved is_function_v under is_const_v. * Isolated is_const, is_volatile, is_pointer, and

RE: [PATCH v4] libgfortran: Replace mutex with rwlock

2023-12-06 Thread Zhu, Lipeng
> > [CCing Ian as libgcc maintainer] > > > > On Wed, 1 Nov 2023 10:14:37 + > > "Zhu, Lipeng" wrote: > > > > > > > > > > > > Hi Lipeng, > > > > > > > > > > >>> Sure, as your comments, in the patch V6, I added 3 test > > > > > >>> cases with OpenMP to test different cases in concurrency >

[PATCH v26 00/23] Optimize type traits compilation performance

2023-12-06 Thread Ken Matsui
This patch series optimizes type traits compilation performance by implementing built-in type traits and using them in libstdc++. Changes in v26: * Rebased on top of trunk. * Moved is_function_v under is_const_v. * Isolated patches for is_const, is_volatile, is_pointer,

[PATCH] strub: enable conditional support

2023-12-06 Thread Alexandre Oliva
On Dec 6, 2023, Alexandre Oliva wrote: > Disabling the runtime bits is easy, once we determine what condition we > wish to test for. I suppose testing for target support in the compiler, > issuing a 'sorry' in case the feature is required, would provide > something for libgcc configure and

Re: [PATCH v1] LoongArch: Modify the check type of the vector builtin function.

2023-12-06 Thread chenxiaolong
在 2023-12-05二的 20:44 +0800,Xi Ruoyao写道: > On Tue, 2023-12-05 at 17:21 +0800, chenxiaolong wrote: > > According to your suggestion, the check of the built-in function > > was modifiedin the simd_correctness_check.h file, and the types of > > the actual parameters > > of the built-in function were

Re: [PATCH v25 25/33] libstdc++: Optimize std::is_function compilation performance

2023-12-06 Thread Ken Matsui
On Tue, Oct 24, 2023 at 4:02 AM Jonathan Wakely wrote: > > > > On Tue, 24 Oct 2023 at 03:16, Ken Matsui wrote: >> >> This patch optimizes the compilation performance of std::is_function >> by dispatching to the new __is_function built-in trait. >> >> libstdc++-v3/ChangeLog: >> >> *

Re: Re: [PATCH 2/4][v2] RISC-V: Add crypto vector builtin function.

2023-12-06 Thread Feng Wang
OK. Will do it firstly. Thanks. ESWIN 海宁奕斯伟集成电路设计有限公司 王峰 From: juzhe.zh...@rivai.ai Date: 2023-12-07 10:39 To: wangfeng; gcc-patches CC: kito.cheng; jeffreyalaw; zhusonghe; panciyan; wangfeng Subject: Re: Re: [PATCH 2/4][v2] RISC-V: Add crypto vector builtin function. I think you can send a

Re: [PATCH v3] LoongArch: Fix eh_return epilogue for normal returns

2023-12-06 Thread Xi Ruoyao
On Thu, 2023-12-07 at 09:40 +0800, Yang Yujie wrote: >  static void >  loongarch_for_each_saved_reg (HOST_WIDE_INT sp_offset, > -   loongarch_save_restore_fn fn) > +   loongarch_save_restore_fn fn, > +   bool

Re: Re: [PATCH 2/4][v2] RISC-V: Add crypto vector builtin function.

2023-12-06 Thread juzhe.zh...@rivai.ai
I think you can send a single separate patch with adding unsigned int (*avail) (void) into current function_group_info first. And test full coverage current rvv intrinsics. juzhe.zh...@rivai.ai From: juzhe.zh...@rivai.ai Date: 2023-12-07 10:28 To: wangfeng; gcc-patches CC: kito.cheng;

Re: [PATCH 3/4][v2] RISC-V: Add crypto machine descriptions

2023-12-06 Thread juzhe.zh...@rivai.ai
+(define_insn "@pred_vandn" + [(set (match_operand:VI 0 "register_operand" "=vr,vr") +(if_then_else:VI + (unspec: +[(match_operand: 1 "vector_mask_operand" "vmWc1,vmWc1") + (match_operand 5 "vector_length_operand""rK,rK") +

Re: [PATCH 2/4][v2] RISC-V: Add crypto vector builtin function.

2023-12-06 Thread juzhe.zh...@rivai.ai
+/* There is no op_type name in vaesz overloaded intrinsic */ +if (!((strcmp (instance.base_name, "vaesz") == 0) && overloaded_p)) + b.append_name (operand_suffixes[instance.op_info->op]); You can dedicate a shape for vaesz to avoid use strcmp. diff --git

[PATCH 2/4][v2] RISC-V: Add crypto vector builtin function.

2023-12-06 Thread Feng Wang
Patch v2:Optimize function_shape class for crypto_vector. This patch add the intrinsic funtions of crypto vector based on the intrinsic doc(https://github.com/riscv-non-isa/rvv-intrinsic-doc/blob /eopc/vector-crypto/auto-generated/vector-crypto/intrinsic_funcs.md). Co-Authored by: Songhe Zhu

[PATCH 3/4][v2] RISC-V: Add crypto machine descriptions

2023-12-06 Thread Feng Wang
Patch v2: Add crypto vector ins into RATIO attr and use vr as destination register. This patch add the crypto machine descriptions(vector-crypto.md) and some new iterators which are used by crypto vector ext. Co-Authored by: Songhe Zhu Co-Authored by: Ciyan Pan gcc/ChangeLog: *

[PATCH 1/4][v2] RISC-V:Add crypto vector implied ISA info.

2023-12-06 Thread Feng Wang
Patch v2: Change the implied ISA info using the minimum set and add dependencies info into the python script. Due to the crypto vector entension is depend on the Vector extension, so the "v" info is added into implied ISA info with the corresponding crypto vector extension. gcc/ChangeLog:

Re: Re: [PATCH 1/4] RISC-V: Add crypto vector implied ISA info.

2023-12-06 Thread Feng Wang
2023-12-06 11:33 Tsukasa OI wrote: >On 2023/12/06 11:45, Feng Wang wrote: >> Due to the crypto vector entension is depend on the Vector extension, >> so the "v" info is added into implied ISA info with the corresponding >> crypto vector extension. > >Hi Feng, > >It's true

Re: Re: [PATCH 3/4] RISC-V: Add crypto vector machine descriptions

2023-12-06 Thread Feng Wang
2023-12-06 14:53 juzhe.zhong wrote: >Do vector crypto instruction demand RATIO ? > >If no, add them into: > >;; It is valid for instruction that require sew/lmul ratio. >(define_attr "ratio" "" >  (cond [(eq_attr "type" "vimov,vfmov,vldux,vldox,vstux,vstox,\ >   

Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types

2023-12-06 Thread Yang Yujie
On Thu, Dec 07, 2023 at 01:35:23AM +, Sam James wrote: > > Yang Yujie writes: > > > On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: > >> > >> > >> On 12/6/23 05:12, Florian Weimer wrote: > >> > * Yang Yujie: > >> > > >> > > From: Yang Yujie > >> > > Subject: [PATCH] testsuite:

[PATCH v3 0/1] LoongArch: Fix eh_return epilogue for normal returns

2023-12-06 Thread Yang Yujie
Updates: v1 -> v2: Add a test case. v2 -> v3: Fix code format. Yang Yujie (1): LoongArch: Fix eh_return epilogue for normal returns gcc/config/loongarch/loongarch-protos.h | 2 +- gcc/config/loongarch/loongarch.cc | 41 --- gcc/config/loongarch/loongarch.md

[PATCH v3] LoongArch: Fix eh_return epilogue for normal returns

2023-12-06 Thread Yang Yujie
On LoongArch, the regitsters $r4 - $r7 (EH_RETURN_DATA_REGNO) will be saved and restored in the function prologue and epilogue if the given function calls __builtin_eh_return. This causes the return value to be overwritten on normal return paths and breaks a rare case of libgcc's

Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types

2023-12-06 Thread Sam James
Yang Yujie writes: > On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: >> >> >> On 12/6/23 05:12, Florian Weimer wrote: >> > * Yang Yujie: >> > >> > > From: Yang Yujie >> > > Subject: [PATCH] testsuite: Adjust for the new permerror >> > > -Wincompatible-pointer-types >> > > To:

Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types

2023-12-06 Thread Yang Yujie
On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: > > > On 12/6/23 05:12, Florian Weimer wrote: > > * Yang Yujie: > > > > > From: Yang Yujie > > > Subject: [PATCH] testsuite: Adjust for the new permerror > > > -Wincompatible-pointer-types > > > To: gcc-patches@gcc.gnu.org > > > Cc:

Re: [PATCH 17/21]AArch64: Add implementation for vector cbranch for Advanced SIMD

2023-12-06 Thread Richard Sandiford
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Tuesday, November 28, 2023 5:56 PM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw >> ; Marcus Shawcroft >> ; Kyrylo Tkachov >> Subject: Re: [PATCH 17/21]AArch64: Add

Re: [PATCH v3 00/16] Support Intel APX NDD

2023-12-06 Thread Hongtao Liu
On Wed, Dec 6, 2023 at 8:11 PM Uros Bizjak wrote: > > On Wed, Dec 6, 2023 at 9:08 AM Hongyu Wang wrote: > > > > Hi, > > > > Following up the discussion of V2 patches in > > https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639368.html, > > this patch series add early clobber for all TImode

[pushed] analyzer: fix taint false positives with UNKNOWN [PR112850]

2023-12-06 Thread David Malcolm
PR analyzer/112850 reports a false positive from -Wanalyzer-tainted-allocation-size on the Linux kernel [1] where -fanalyzer complains that an allocation size is attacker-controlled despite the value being correctly sanitized against upper and lower limits. The root cause is that the expression

[PATCH] aarch64: add -fno-stack-protector to tests

2023-12-06 Thread Marek Polacek
Bootstrapped/regtested on aarch64-pc-linux-gnu, ok for trunk/13? -- >8 -- These tests fail when the testsuite is executed with -fstack-protector-strong. To avoid this, this patch adds -fno-stack-protector to dg-options. The list of FAILs is appended. As you can see, it's mostly about

Re: [Committed] RISC-V: Fix PR112888 ICE

2023-12-06 Thread Patrick O'Neill
Committed on behalf of Juzhe since he was having internet issues. Thanks, Patrick On 12/6/23 14:35, Juzhe-Zhong wrote: Committed as it is ovbious. gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (extract_single_source): new function. (pre_vsetvl::compute_lcm_local_properties):

Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime

2023-12-06 Thread Alexandre Oliva
On Dec 6, 2023, Jonathan Wakely wrote: >> -void *obj, void *dso_handle) >> +void *obj, [[maybe_unused]] void >> *dso_handle) > The patch is OK with that change. Thanks, here's what I'm going to install. Regstrapped on

[Committed] RISC-V: Fix PR112888 ICE

2023-12-06 Thread Juzhe-Zhong
Committed as it is ovbious. gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (extract_single_source): new function. (pre_vsetvl::compute_lcm_local_properties): Fix ICE. --- gcc/config/riscv/riscv-vsetvl.cc | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[PATCH] htdocs: correct spelling and use https in examples

2023-12-06 Thread Jonny Grant
Revised version of this patch after review. ChangeLog: htdocs: correct spelling and use https in examples. >From 52d413bce86827f2add424e78321b509661f6f59 Mon Sep 17 00:00:00 2001 From: Jonathan Grant Date: Wed, 6 Dec 2023 22:27:29 + Subject: [PATCH] htdocs: correct spelling and

Re: [PATCH] htdocs/git.html: correct spelling and use git in example

2023-12-06 Thread Jonny Grant
On 04/12/2023 20:37, Joseph Myers wrote: > On Fri, 1 Dec 2023, Jonny Grant wrote: > >> >> >> On 30/11/2023 23:56, Joseph Myers wrote: >>> On Thu, 30 Nov 2023, Jonny Grant wrote: >>> ChangeLog: htdocs/git.html: change example to use git:// and correct

Re: [PATCH] analyzer: deal with -fshort-enums

2023-12-06 Thread David Malcolm
On Wed, 2023-12-06 at 02:31 -0300, Alexandre Oliva wrote: > On Nov 22, 2023, Alexandre Oliva wrote: > > > Ah, nice, that's a great idea, I wish I'd thought of that!  Will > > do. > > Sorry it took me so long, here it is.  I added two tests, so that, > regardless of the defaults, we get both

Re: Causes to nvptx bootstrap fail: [PATCH v5] Introduce strub: machine-independent stack scrubbing

2023-12-06 Thread Alexandre Oliva
On Dec 6, 2023, Thomas Schwinge wrote: > As I understand things, this cannot be implemented (at the call site) for > nvptx, given that the callee's stack is not visible there: PTX is unusual > in that the concept of a "standard" stack isn't exposed. Not even when one PTX function calls

Re: [PATCH] RISC-V: xtheadfmemidx: Disable if xtheadmemidx is not available

2023-12-06 Thread Jeff Law
On 12/5/23 08:16, Christoph Müllner wrote: XTheadMemIdx provides register-register offsets for GP register loads/stores. XTheadFMemIdx does the same for FP registers. We've observed an issue with XTheadFMemIdx-only builds, where FP registers have been promoted to GP registers: (insn 26 22

Re: [PATCH] Reimplement __gnu_cxx::__ops operators

2023-12-06 Thread François Dumont
I think I still got no feedback about this cleanup proposal. Here is a new version. François On 15/06/2023 07:07, François Dumont wrote: I think we all agree that __gnu_cxx::__ops needed to be reimplemented, here it is. Note that I kept the usage of std::ref in , and .     libstdc++:

[PATCH] Fortran: function returning contiguous class array [PR105543]

2023-12-06 Thread Harald Anlauf
Dear all, the attached patch fixes a rejects-valid for functions returning a contiguous CLASS result. The problem occurs because attr.class_ok is inconsistent between sym and sym->result at the time the check of the contiguous attribute is done. I first thought that resolve_fl_procedure would

Re: [Committed V2] RISC-V: Fix VSETVL PASS bug

2023-12-06 Thread Patrick O'Neill
Hi Juzhe, An assert added in this patch is firing on a testcase on rv64gcv: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112888 Thanks, Patrick On 12/6/23 06:26, Juzhe-Zhong wrote: As PR112855 mentioned, the VSETVL PASS insert vsetvli in unexpected location. Due to 2 reasons: 1. incorrect

Re: {Patch, fortran] PR112834 - Class array function selector causes chain of syntax and other spurious errors

2023-12-06 Thread Harald Anlauf
Hi Paul, On 12/6/23 17:09, Paul Richard Thomas wrote: Dear All, This patch was rescued from my ill-fated and long winded attempt to provide a fix-up for function selector references, where the function is parsed after the procedure containing the associate/select type construct (PRs 89645 and

Re: {Patch, fortran] PR112834 - Class array function selector causes chain of syntax and other spurious errors

2023-12-06 Thread Jerry D
On 12/6/23 8:09 AM, Paul Richard Thomas wrote: Dear All, This patch was rescued from my ill-fated and long winded attempt to provide a fix-up for function selector references, where the function is parsed after the procedure containing the associate/select type construct (PRs 89645 and

Re: [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase

2023-12-06 Thread Palmer Dabbelt
On Wed, 06 Dec 2023 10:48:30 PST (-0800), Vineet Gupta wrote: On 12/6/23 08:22, Palmer Dabbelt wrote: Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail That's the original port submission, I'm actually kind of surprised it still builds/works at all. Full

veclower: improve selection of vector mode when lowering [PR 112787]

2023-12-06 Thread Andre Vieira (lists)
Hi, This patch addresses the issue reported in PR target/112787 by improving the compute type selection. We do this by not considering types with more elements than the type we are lowering since we'd reject such types anyway. gcc/ChangeLog: PR target/112787 *

Re: [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase

2023-12-06 Thread Vineet Gupta
On 12/6/23 08:22, Palmer Dabbelt wrote: >> Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail > That's the original port submission, I'm actually kind of surprised it > still builds/works at all. Full toolchain build would have been a stretch (matching pairing

Re: [PATCH v6] aarch64: New RTL optimization pass avoid-store-forwarding.

2023-12-06 Thread Philipp Tomsich
On Wed, 6 Dec 2023 at 23:32, Richard Biener wrote: > > On Wed, Dec 6, 2023 at 2:48 PM Manos Anagnostakis > wrote: > > > > This is an RTL pass that detects store forwarding from stores to larger > > loads (load pairs). > > > > This optimization is SPEC2017-driven and was found to be beneficial

Re: [PATCH] remove qmtest-related Makefile targets

2023-12-06 Thread Eric Gallager
On Wed, Dec 6, 2023 at 12:56 PM Jeff Law wrote: > On 12/5/23 09:41, Eric Gallager wrote: > > On GitHub, Joseph Myers (@jsm28 there) says in MentorEmbedded/qmtest#1 > > that the qmtest-related targets should have been removed long ago. This > > patch does so. > > > > Ref: > >

[pushed] v2: diagnostics: prettify JSON output formats

2023-12-06 Thread David Malcolm
I messed up the testing of the previous version of this patch, and it turned out to have regressions. Whilst fixing them, it turned out I needed a way to disable the formatting for some test cases, so this version of the patch restricts the formatting to just the diagnostics format, and adds a

Re: [C PATCH, v2] Add Walloc-size to warn about insufficient size in allocations [PR71219]

2023-12-06 Thread Eric Gallager
On Wed, Dec 6, 2023 at 10:13 AM Martin Uecker wrote: > > Am Mittwoch, dem 06.12.2023 um 16:01 +0100 schrieb Jakub Jelinek: > > On Wed, Dec 06, 2023 at 03:56:10PM +0100, Martin Uecker wrote: > > > > That would be my preference because then the allocation size is > > > > correct and it is purely a

Re: [PATCH 1/1] RISC-V: Add support for XCVbitmanip extension in CV32E40P

2023-12-06 Thread Jeff Law
On 12/5/23 08:30, Kito Cheng wrote: index 7d7b952d817..e7d4ad1760c 100644 --- a/gcc/config/riscv/corev.md +++ b/gcc/config/riscv/corev.md @@ -27,6 +27,25 @@ ;;CORE-V EVENT LOAD UNSPECV_CV_ELW + + ;;CORE-V BITMANIP + UNSPEC_CV_BITMANIP_EXTRACT + UNSPEC_CV_BITMANIP_EXTRACT_INSN +

Re: [PATCH] remove qmtest-related Makefile targets

2023-12-06 Thread Jeff Law
On 12/5/23 09:41, Eric Gallager wrote: On GitHub, Joseph Myers (@jsm28 there) says in MentorEmbedded/qmtest#1 that the qmtest-related targets should have been removed long ago. This patch does so. Ref: https://github.com/MentorEmbedded/qmtest/issues/1 gcc/ChangeLog: * Makefile.in:

Re: [PATCH] libgcc: Avoid -Wbuiltin-declaration-mismatch warnings in emutls.c

2023-12-06 Thread Jeff Law
On 12/6/23 03:04, Jakub Jelinek wrote: Hi! When libgcc is being built in --disable-tls configuration or on a target without native TLS support, one gets annoying warnings: ../../../../libgcc/emutls.c:61:7: warning: conflicting types for built-in function ‘__emutls_get_address’; expected

Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types

2023-12-06 Thread Jeff Law
On 12/6/23 05:12, Florian Weimer wrote: * Yang Yujie: From: Yang Yujie Subject: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types To: gcc-patches@gcc.gnu.org Cc: r...@cebitec.uni-bielefeld.de, mikest...@comcast.net, fwei...@redhat.com, Yang Yujie Date: Wed,

[pushed] diagnostics: use const and references for diagnostic_info

2023-12-06 Thread David Malcolm
No functional change intended. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r14-6227-g8fc4e6c397e1ce. gcc/c-family/ChangeLog: * c-opts.cc (c_diagnostic_finalizer): Make "diagnostic" param const. gcc/cp/ChangeLog: * cp-tree.h

Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads

2023-12-06 Thread Eric Gallager
On Mon, Dec 4, 2023 at 1:44 PM Tom Tromey wrote: > > > "Arsen" == Arsen Arsenović writes: > > Arsen> Thanks. I'll wait for the Binutils and GDB maintainers to weigh in > Arsen> before pushing (plus, I can't push there). > > Seems fine to me. Thank you. > > Tom LGTM; please post once it

Re: [PATCH v6] aarch64: New RTL optimization pass avoid-store-forwarding.

2023-12-06 Thread Manos Anagnostakis
Hi again, I went and tested the requested changes and found out the following: 1. The pass is currently increasing insn_cnt on a NONJUMP_INSN_P, which is a subset of NONDEBUG_INSN_P. I think there is no problem with depending on -g with the current version. Do you see something I don't or did

[committed v4 3/3] amdgcn, libgomp: low-latency allocator

2023-12-06 Thread Andrew Stubbs
This implements the OpenMP low-latency memory allocator for AMD GCN using the small per-team LDS memory (Local Data Store). Since addresses can now refer to LDS space, the "Global" address space is no-longer compatible. This patch therefore switches the backend to use entirely "Flat" addressing

[committed v4 1/3] libgomp, nvptx: low-latency memory allocator

2023-12-06 Thread Andrew Stubbs
This patch adds support for allocating low-latency ".shared" memory on NVPTX GPU device, via the omp_low_lat_mem_space and omp_alloc. The memory can be allocated, reallocated, and freed using a basic but fast algorithm, is thread safe and the size of the low-latency heap can be configured using

[committed v4 2/3] openmp, nvptx: low-lat memory access traits

2023-12-06 Thread Andrew Stubbs
The NVPTX low latency memory is not accessible outside the team that allocates it, and therefore should be unavailable for allocators with the access trait "all". This change means that the omp_low_lat_mem_alloc predefined allocator no longer works (but omp_cgroup_mem_alloc still does).

[committed v4 0/3] libgomp: OpenMP low-latency omp_alloc

2023-12-06 Thread Andrew Stubbs
Thank you, Tobias, for approving the v3 patch series with minor changes. https://patchwork.sourceware.org/project/gcc/list/?series=27815=%2A=both These patches are what I've actually committed. Besides the requested changes there were one or two bug fixes and minor tweaks, but otherwise the

[PATCH] libiberty/buildargv: POSIX behaviour for backslash handling

2023-12-06 Thread Andrew Burgess
GDB makes use of the libiberty function buildargv for splitting the inferior (program being debugged) argument string in the case where the inferior is not being started under a shell. I have recently been working to improve this area of GDB, and have tracked done some of the unexpected behaviour

Re: [PATCH] [arm] testsuite: make mve_intrinsic_type_overloads-int.c libc-agnostic

2023-12-06 Thread Richard Earnshaw
Sorry, I only just spotted this while looking at something else. On 23/05/2023 15:41, Christophe Lyon via Gcc-patches wrote: Glibc defines int32_t as 'int' while newlib defines it as 'long int'. Although these correspond to the same size, g++ complains when using the

RE: [PATCH 17/21]AArch64: Add implementation for vector cbranch for Advanced SIMD

2023-12-06 Thread Tamar Christina
> -Original Message- > From: Richard Sandiford > Sent: Tuesday, November 28, 2023 5:56 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; Marcus Shawcroft > ; Kyrylo Tkachov > Subject: Re: [PATCH 17/21]AArch64: Add implementation for vector cbranch for >

Re: [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase

2023-12-06 Thread Palmer Dabbelt
On Tue, 05 Dec 2023 16:39:06 PST (-0800), e...@rivosinc.com wrote: Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail That's the original port submission, I'm actually kind of surprised it still builds/works at all. was introduced. The test did pass at that hash

  1   2   >